- 17 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/ce8632a603ce..8b0273016734 git log ce8632a603ce..8b0273016734 --date=short --no-merges --format='%ad %ae %s' 2018-11-17 dgarrett@google.com Reland "CleanUpStage: Cleanup Workspaces." Created with: gclient setdep -r src/third_party/chromite@8b0273016734 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I34d85750ac873ca93bbbe7c4c7bc5a6d7ad4b67a Reviewed-on: https://chromium-review.googlesource.com/c/1341011Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/767024c68dfe..c6ffd7af7d84 git log 767024c68dfe..c6ffd7af7d84 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 brucedawson@chromium.org Include ARM64 bits into win_toolchain/package_from_installed.py Created with: gclient setdep -r src/third_party/depot_tools@c6ffd7af7d84 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:893460 TBR=agable@chromium.org Change-Id: Ib337c3d6591ad7ee19b4980fb79d9a0d3dd35e32 Reviewed-on: https://chromium-review.googlesource.com/c/1341012Reviewed-by:
-
Scott Chen authored
Bug: 881937 Change-Id: I01c66ec9463db1c76f8f45579be7cd210c780b8a Reviewed-on: https://chromium-review.googlesource.com/c/1338475 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#609078}
-
Fredrik Söderquist authored
For all of these properties[1][2][3][4], a negative value is considered illegal and should fail in the parser. (The value range is already corectly specified for instance for animation, and also for the corresponing presentation attributes.) [1] https://svgwg.org/svg2-draft/geometry.html#R [2] https://svgwg.org/svg2-draft/geometry.html#RX [3] https://svgwg.org/svg2-draft/geometry.html#RY [4] https://svgwg.org/svg2-draft/painting.html#StrokeWidthProperty Bug: 902346 Change-Id: I4b073288b97151d7a9df4b1c2ce99341dca9c8ee Reviewed-on: https://chromium-review.googlesource.com/c/1304561 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#609077}
-
Jamie Madill authored
This reverts commit 3ca3fb27. Reason for revert: Seems to be the incorrect way to handle multi-results. Instead of returning an array of values, we should compute the average and return a standard deviation as the last result. https://chromeperf.appspot.com/report?sid=3b11bf2aa2cf2281472588fed4dfc1e0a9f514ff10bd9db09cb208c5306ac3c9 Original change's description: > Add multi results in legacy perf dashboard script. > > Currently when the script reads multiple results it outputs the > last value read as well as a zero placehold for standard deviation. > > According to benjhayden@ we can return all results in an array. > This change does just that and adds a test. It also updates the > expected unit test output. > > Bug: 900677 > Change-Id: Icc38808ea83caddbdf6b8582e2ddc34db4f8cdf0 > Reviewed-on: https://chromium-review.googlesource.com/c/1338468 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: Jamie Madill <jmadill@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608882} TBR=jmadill@chromium.org,benjhayden@chromium.org,nednguyen@google.com,eyaich@chromium.org Change-Id: I24fe0fae6607bf4d1bf8fb55d2c4f78d18a74b71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 900677 Reviewed-on: https://chromium-review.googlesource.com/c/1341087Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#609076}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ec1a9198bde..f6e6e20b1722 Created with: gclient setdep -r src-internal@f6e6e20b1722 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:903558 TBR=mmoss@chromium.org Change-Id: I90c3292d0df200d0a9cb30dc775b9d1338c726f7 Reviewed-on: https://chromium-review.googlesource.com/c/1341010Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium efc231cc. With Chromium commits locally applied on WPT: c852d472 "Implement RTCQuicStream.waitForReadable()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I2a3c154d87e0be7ba7a170aa0a33ffefce42f9a9 Reviewed-on: https://chromium-review.googlesource.com/c/1341067 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#609074}
-
Katie D authored
Change-Id: Ifea9b06e406089ee6c969a28c987fe2e4160151f Reviewed-on: https://chromium-review.googlesource.com/c/1340975 Commit-Queue: Katie Dektar <katie@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609073}
-
khmel@chromium.org authored
This handles the cases when settings and learn more links may not present in text. Text comes from translation resources and may be omitted internationally or unintentionally. We can not validate all resources and also text may now don't have such links. So let be safe. In production that may lead to the case when such link might not work correctly (don't react). In test this is a reason for autotest failure that uses ARC OptIn flow. TBR=xiyuan@chromium.org BUG=805304 BUG=905958 TEST: Manually, with extra logging confirms that no report is generated. Change-Id: Iba5786b5361a6a99c4808cffdb8b0d7a3d155fb9 Reviewed-on: https://chromium-review.googlesource.com/c/1341074 Commit-Queue: Yury Khmel <khmel@chromium.org> Reviewed-by:
Josh Horwich <jhorwich@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609072}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/a8b6376430de..9a02a99a165d git log a8b6376430de..9a02a99a165d --date=short --no-merges --format='%ad %ae %s' 2018-11-16 tsepez@chromium.org Remove unused CBC_DataMatrixSymbolInfo144getDataLengthForInterleavedBlock() 2018-11-16 tsepez@chromium.org Remove unused CBC_CommonBitArray class. 2018-11-16 thestig@chromium.org Add FXSYS_IsOctalDigit() and use it where appropriate. 2018-11-16 thestig@chromium.org Remove "exceptions" from CBC_PDF417HighLevelEncoder. 2018-11-16 tsepez@chromium.org Remove uncallable ctors from CJS_PublicMethods. Created with: gclient setdep -r src/third_party/pdfium@9a02a99a165d The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I78cf05821c8c67508ad08c516bba78d85234d8de Reviewed-on: https://chromium-review.googlesource.com/c/1341006Reviewed-by:
-
David Black authored
Screenshot in the bug. Bug: b:119662514 Change-Id: Iee19fd5f23942fd13ed03ff61b804db04f36f66d Reviewed-on: https://chromium-review.googlesource.com/c/1340959Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#609070}
-
John Chen authored
According to W3C spec, new session capabilities with null values should be ignored, but they cause errors in ChromeDriver. This CL fixes it. See https://www.w3.org/TR/webdriver/#dfn-validate-capabilities, step 3, sub-steps 3 and 4. Bug: chromedriver:1997 Change-Id: Ibee5e383c46139df1e5efc9f8a46872820c81046 Reviewed-on: https://chromium-review.googlesource.com/c/1340834 Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#609069}
-
Kenneth Russell authored
Check for overflow in all callers before proceeding to fetch the associated shared memory region. Bug: 905459 Change-Id: I8701962cea4053d44b1a215d25a235af6db37984 Reviewed-on: https://chromium-review.googlesource.com/c/1338940 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#609068}
-
Andrey Kosyakov authored
This introduces a feature named "VirtualTime" and sets other command line flags that are required for virtual time if it's enabled. Change-Id: I0a6d30d9f47f0c59bd8ac815862b74a48448c7a8 Reviewed-on: https://chromium-review.googlesource.com/c/1340538Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#609067}
-
Gabriel Charette authored
As discussed @ https://groups.google.com/a/chromium.org/d/topic/chromium-dev/829Jj5eBhbk/discussion R=danakj@chromium.org Change-Id: I6a0d4a2d4d3091a48cc6c66994f4842f69aa3a87 Reviewed-on: https://chromium-review.googlesource.com/c/1340262 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#609066}
-
Robert Liao authored
BUG=881371,737995 R=sky,robliao Change-Id: I9798f20415975c7f98528b2f746aaffe6a66af1e Reviewed-on: https://chromium-review.googlesource.com/c/1316834 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609065}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I1e47f42b7e81bd55ad9b438db3ba39824e878422 Reviewed-on: https://chromium-review.googlesource.com/c/1341009Reviewed-by:
-
Matt Menke authored
All it has is an OWNERS file, left over from https://chromium-review.googlesource.com/c/chromium/src/+/1323791 Bug: 901419 Change-Id: Ifc6989523ffb102f4aa9f98d2d7c0c58c5e4971d Reviewed-on: https://chromium-review.googlesource.com/c/1340524Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#609063}
-
Ian Wells authored
This change causes results of attempts to load MHTML archives to be logged with a UMA histogram, providing some previously missing insight into the performance of MHTML loading. Bug: 901025 Change-Id: If82fda621fcf8d4256edc20a0da9172d0cde2455 Reviewed-on: https://chromium-review.googlesource.com/c/1313669Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#609062}
-
Esmael El-Moslimany authored
Bug: 906009 Change-Id: Ic3ad0336522415492c043bc125ced0fa5796f169 Reviewed-on: https://chromium-review.googlesource.com/c/1341059Reviewed-by:
Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#609061}
-
Donn Denman authored
This test is flaking a lot on Android now. Disabling. TBR=wjmaclean@chromium.org BUG=906204, 897173 Change-Id: I4226c043de09fd5cb6fd83343bbfac5b69a802d4 Reviewed-on: https://chromium-review.googlesource.com/c/1341140 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#609060}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a2187bf7629a..c217842bdd51 git log a2187bf7629a..c217842bdd51 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-16 michaelludwig@google.com Use vertex writer for per-edge aa; remove templated tessellate function 2018-11-16 mtklein@google.com refactor SkBitmapProcState_opts.h a bit 2018-11-16 brianosman@google.com Use GrVertexWriter in GrSmallPathRenderer Created with: gclient setdep -r src/third_party/skia@c217842bdd51 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=rmistry@chromium.org Change-Id: Ia377314ee596b69ccd37e0da1857dd0df131a435 Reviewed-on: https://chromium-review.googlesource.com/c/1341008Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6343daaa40fe..767024c68dfe git log 6343daaa40fe..767024c68dfe --date=short --no-merges --format='%ad %ae %s' 2018-11-16 sergiyb@chromium.org Revert "[gclient] Make getdep and setdep to provide builtin vars" 2018-11-16 johannes@chromium.org [DevTools] Add a fetch config for the inspector_protocol. Created with: gclient setdep -r src/third_party/depot_tools@767024c68dfe The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:906114 TBR=agable@chromium.org Change-Id: I03d70ea5017c4b1a326a169f98f7a6f9d3e81607 Reviewed-on: https://chromium-review.googlesource.com/c/1341020Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a64e6d552792..ce8632a603ce git log a64e6d552792..ce8632a603ce --date=short --no-merges --format='%ad %ae %s' 2018-11-16 wonderfly@google.com chromeos_config: Build R69 master-release once a week 2018-11-16 lamontjones@chromium.org signing: Fix unittest errors. 2018-11-16 dgarrett@google.com cbuildbot_launch: Attempt PreLoad from /preload/chromeos. 2018-11-16 achuith@chromium.org cros_run_vm_test: Support for running tests on a device. 2018-11-16 achuith@chromium.org cros_vm: Add super class Device. 2018-11-16 dgarrett@chromium.org Revert "CleanUpStage: Cleanup Workspaces." 2018-11-16 dgarrett@chromium.org Revert "generic_stage.GetRepoRepository: Make arguments flexible." 2018-11-16 dgarrett@chromium.org Revert "workspace_builders: Refactor inheritance." Created with: gclient setdep -r src/third_party/chromite@ce8632a603ce The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I8f7398b06ffe73587b65ba2ef091bc0ccbea501c Reviewed-on: https://chromium-review.googlesource.com/c/1341007Reviewed-by:
-
Hasan Khalil authored
==== Flip flags FLAGS_quic_reloadable_flag_quic_session_faster_get_stream and FLAGS_quic_reloadable_flag_quic_enable_server_epid_in_public_reset to true. ==== Ensure that QuicSession::OnCanCreateNewOutgoingStream is invoked when a the final by offset is received, even if the stream was previously closed. Merge internal change: 220855840 https://chromium-review.googlesource.com/c/1340886/ ==== all code driven from app, which has not been modified to call it Add API and code path to generate IETF QUIC STOP_SENDING Frames This CL adds an API facing the QUIC Application and the internal code path required to generate an IETF QUIC STOP_SENDING frame and unit tests of this path are added as well. The api is QuicStream::SendStopSending(). The application invokes this to generate an IETF QUIC STOP_SENDING frame and send it to the peer. This CL consists of the logic from QuicStream::SendStopSending through the generation of the frame and adding it ot the set of control frames that are to be transmitted. QuicStream::StopSending invokes QuicSession::StopSending, which in turn requests that QuicControlFrameManager create and transmit (or enqueue for later transmission) a STOP_SENDING frame. Additional STOP_SENDING work will be in follow on CLs. Merge internal change: 220799380 https://chromium-review.googlesource.com/c/1340885/ ==== logging only Add SNI to the QUIC_LOG about expected SCTs being empty. Merge internal change: 220686048 https://chromium-review.googlesource.com/c/1340884/ ==== test changes only Modify quic_stream_test so that parameterized tests are available. This CL extends quic_stream_test so that parameterized tests (different versions) can be executed. This is needed in support of IETF QUIC (version 99) STOP_SENDING work -- subject of a follow-on CL. Two tests have been converted over to be parameterized; this is not strictly necessary as they both failed during development due to an error in initialization. They've been kept as parameterized to provide a back-stop against other potential issues and to demonstrate that the parameterized tests actually are parameterized... Merge internal change: 220654875 https://chromium-review.googlesource.com/c/1340883/ ==== Add flag count only. Add a QUIC_FLAG_COUNT for flag FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames_2. Merge internal change: 220469321 https://chromium-review.googlesource.com/c/1340882/ ==== comment-only change Clarification for QuicSession::SendMessgage about blocked connection It was not obvious to me that SendMessage could fail if connection was congession controlled, so I wanted to add comments to the API. See also my comment about calling under OnCanWrite and assumption that message is alive until exiting the flusher's scope. Even if it's not a problem with OnCanWrite it's a dangerous assumption. Why not to copy message or accept a string by value and move to be on a safe side? Merge internal change: 220119478 https://chromium-review.googlesource.com/c/1340880/ ==== test only change Disable tests relying on goaway for QUIC v99. Merge internal change: 220095515 https: //chromium-review.googlesource.com/c/1340879/ Change-Id: Idade360d6baa9215e0825bddf8994c953fb43b37 Reviewed-on: https://chromium-review.googlesource.com/c/1340888 Commit-Queue: Hasan Khalil <hkhalil@google.com> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#609056}
-
Kenneth Russell authored
This reverts commit 9f069147. Reason for revert: failures were actually caused by colliding text expectations in Issue 905682 Original change's description: > Mark WebGL test gl-bindAttribLocation-matrix.html flaky > > TBR=kbr@chromium.org > BUG=906092 > > Change-Id: I11105b926d35b5bcb16c2930c04f98db20e5f4b4 > Reviewed-on: https://chromium-review.googlesource.com/c/1340788 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608946} TBR=kbr@chromium.org,eirage@chromium.org Change-Id: I4b0ee2ab77581a1710626308d8bb9942dfe0a595 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906092 Reviewed-on: https://chromium-review.googlesource.com/c/1341152Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#609055}
-
Zhenyao Mo authored
1) Need to change the way python launched Edge. This is the only way an URL can be passed to Edge that contains "&". 2) Add an option to pass command line switches in a file BUG=867155 R=sunnyps@chromium.org TEST=manual Change-Id: If5457a82661414c2a3453bff094d6a2ffadeeab0 Reviewed-on: https://chromium-review.googlesource.com/c/1332930 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#609054}
-
Wenzhao Zang authored
There're multiple places that check kHideWebStoreIcon. [1] is the place we're interested in. We should change the pref value right after profile is available, otherwise its value may already be used. (i.e. putting it in OnSessionStateChanged is too late.) Alternatively, we could check IsDeviceInDemoMode() when registering the pref, but I'd like to avoid spreading the checks everywhere when possible. [1] https://cs.chromium.org/chromium/src/chrome/browser/history/top_sites_factory.cc?type=cs&q=khidewebstoreicon&sq=package:chromium&g=0&l=75 Bug: 885367 Change-Id: I9454acca4f02d91d5d85665f2cc3c29125ec7fb0 Reviewed-on: https://chromium-review.googlesource.com/c/1333121Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#609053}
-
Bailey Berro authored
Fixes a bug where metrics were not recorded correctly for failed mounts due to invalid urls. Bug: chromium:902923 Change-Id: Iba8164d4869818a44faa10ee18503cdd1e24d424 Reviewed-on: https://chromium-review.googlesource.com/c/1340971Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#609052}
-
Caleb Rouleau authored
This also shortens test length, which is always nice. Bug: 859660 Change-Id: I83ec61d85b7629ebaa74514adddacc29a767535d Reviewed-on: https://chromium-review.googlesource.com/c/1341001Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#609051}
-
Antoine Labour authored
We need to reset GL_PIXEL_UNPACK_BUFFER in FeatureInfo initialization if it is non-0. We should always do that regardless of whether or not the current decoder exposes them, because with shared contexts it is possible that another decoder uses ES3 whereas the current one doesn't. Bug: 905519 Change-Id: I2c2f457fcdd76ca4812ac8d71c8f77d694506a57 Reviewed-on: https://chromium-review.googlesource.com/c/1340973 Commit-Queue: Antoine Labour <piman@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Hector Carmona authored
R=scottchen@chromium.org Bug: 901210 Change-Id: I04a20fe0b81d2ca599865ae664915d0cac060317 Reviewed-on: https://chromium-review.googlesource.com/c/1340872Reviewed-by:
-
John Z Wu authored
The previous implementation relied on autofill_agent finding forms, but it is only interested in address and credit card forms. Instead, we call the javascript function in CWVAutofillController to obtain all forms we care about. Also renamed delegate method from didFind to didScan since the former implies that at least one was found but in many cases there are 0. Bug: 905546 Change-Id: Ibb3144e767fe2257c20176d61315568cfde076cb Reviewed-on: https://chromium-review.googlesource.com/c/1339322 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#609048}
-
Becky Zhou authored
TBR=twellington@chromium.org Bug: 888129 Change-Id: I184b0e86872093b249b1c7f729be75d55e1c355d Reviewed-on: https://chromium-review.googlesource.com/c/1341023Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#609047}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/8e9be303b00b..cd22b3155708 git log 8e9be303b00b..cd22b3155708 --date=short --no-merges --format='%ad %ae %s' 2018-11-16 alanbaker@google.com Catch branch condition being a type Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@cd22b3155708 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5c9f01a5e69c2d702434ce8ef6879050dddcf95f Reviewed-on: https://chromium-review.googlesource.com/c/1340980Reviewed-by:
-
Max Moroz authored
Bug: 539572 Change-Id: I83ae6f7e74b29be928bd81d50704e59ec864394c Reviewed-on: https://chromium-review.googlesource.com/c/1340600 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#609045}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/721662b8ce13..6ec1a9198bde Created with: gclient setdep -r src-internal@6ec1a9198bde The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ibfe5ce71f92e799f8b5321cc6d820a2b5196e053 Reviewed-on: https://chromium-review.googlesource.com/c/1341019Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit 8226b54c. Reason for revert: The original bug is fixed. Original change's description: > Revert "Change Range::expand() to VisiblePosition-free functions for word and sentence" > > This reverts commit 775938b6. > > Reason for revert: need to revert this to revert r608849 > > Original change's description: > > Change Range::expand() to VisiblePosition-free functions for word and sentence > > > > This patch changes Range::expand() to call VP-free version of word and > > sentence start/end functions, by hoisting the creation of VP from > > the functions into itself. In this way we reduce the usage of functions > > relying on VP. > > > > Bug: 657237 > > Change-Id: I56ea3cb88972144887eba7701cfdc3628bdbf67b > > Reviewed-on: https://chromium-review.googlesource.com/c/1338719 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Reviewed-by: Yoichi Osato <yoichio@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#608855} > > TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org > > Bug: 657237, 906174 > Change-Id: I46b8df3cfd8ed7f7636f9ef1dabfa350168cb820 > Reviewed-on: https://chromium-review.googlesource.com/c/1340906 > Reviewed-by: Ella Ge <eirage@chromium.org> > Commit-Queue: Ella Ge <eirage@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608957} TBR=yosin@chromium.org,tkent@chromium.org,yoichio@chromium.org,xiaochengh@chromium.org,eirage@chromium.org Change-Id: Iad61aa1c53fc7225f9795a1aa0e5ff9cc0704bc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 657237, 906174 Reviewed-on: https://chromium-review.googlesource.com/c/1340837Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#609043}
-
Gary Kacmarcik authored
Previously, the Japanese layout was not returned as the highest-prio ASCII-capable layout because not all of the writing-system-keys produced printable characters. Specifically, the Backquote key is used as the hankaku/zenkaku key to switch between half-width and full-width chars. This cl fixes that by handling the Japanese/Backquote key as a special case, and the keyboard map returns a descriptive string. Bug: 891501 Change-Id: Ic473700866d711a532d3946be73ff5ec38db580a Reviewed-on: https://chromium-review.googlesource.com/c/1340970 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#609042}
-
Jesse McKenna authored
Bug: 889029 Change-Id: I6e3fa2029dc9875fd742d84fea65ceb8c071c61f Reviewed-on: https://chromium-review.googlesource.com/c/1333991 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#609041}
-
