GitLab

BUG=340886
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/262953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268004 0039d316-1c4b-4281-b951-d872f2087c98

Reports:

ui/app_list/app_list_model.h:126:  Add #include <string> for string
[build/include_what_you_use] [4]
ui/app_list/views/top_icon_animation_view.h:5:  #ifndef header guard has
wrong style, please use: UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_
[build/header_guard] [5]
ui/app_list/views/top_icon_animation_view.h:78:  #endif line should be
"#endif  // UI_APP_LIST_VIEWS_TOP_ICON_ANIMATION_VIEW_H_"
[build/header_guard] [5]
ui/app_list/views/folder_header_view.cc:169:  Add #include <algorithm>
for min  [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.cc:320:  Add #include <string>
for string  [build/include_what_you_use] [4]
ui/app_list/views/app_list_view.h:38:  Do not leave a blank line after
"public:"  [whitespace/blank_line] [3]
ui/app_list/views/apps_container_view.h:109:  Add #include <vector> for
vector<>  [build/include_what_you_use] [4]
ui/app_list/views/folder_header_view_delegate.h:26:  Add #include
<string> for string  [build/include_what_you_use] [4]
ui/app_list/views/apps_grid_view.h:328:  Add #include <string> for
string  [build/include_what_you_use] [4]
ui/app_list/views/app_list_folder_view.h:93:  Add #include <string> for
string  [build/include_what_you_use] [4]
ui/app_list/views/search_result_view.h:46:  Single-argument constructors
should be marked explicit.  [runtime/explicit] [5]

The report was generated by the following command line:
$ find ui/app_list -name "*.cc" -o -name "*.h" | grep -v cocoa | xargs
cpplint.py

After this the total errors found is ZERO!

BUG=337484
TEST=None, no functional changes
TBR=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/268813004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268003 0039d316-1c4b-4281-b951-d872f2087c98

FFmpeg has packet side data indicating how many frames should be
trimmed after decoding, we should use it to improve playback of
mp3 and aac audio via <audio> tag.

Specifically:
- AudioBuffer:TrimRange(start,end) is now supported.
- DecoderBuffer:discard_padding() is now a pair of (front, back)
  which indicates how much to trim off the front and rear of the
  data corresponding to the encoded buffer.
- AudioDiscardHelper has been updated to implement this trimming.
- FFmpegDemuxer inserts FFmpeg's skip_samples into DecoderBuffer.

This change paves the way for MediaSource to use this feature to
implement gapless playback support.

BUG=360961
TEST=new unittests!
NOTRY=true

Review URL: https://codereview.chromium.org/251893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268002 0039d316-1c4b-4281-b951-d872f2087c98

Introduce X11TopmostWindowFinder which merges the mostly duplicated functionality to find the topmost window at a point in:
- window_finder_x11.cc
- desktop_drag_drop_client_aurax11.cc
- desktop_screen_x11.cc

Having all of the similar functionality in one place will be helpful for testing

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/260263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368258

Review URL: https://codereview.chromium.org/252223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@268000 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove webkit's ResourceLoaderBridge interface. (https://codereview.chromium.org/226273005/)

Reason for revert:
Looks like it broke LSan bots:

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/2229
TBR=jam
NOTREECHECKS=true
NOTRY=true

Original issue's description:
> Remove webkit's ResourceLoaderBridge interface.
> 
> ResourceLoaderBridge was originally created to bridge code in //webkit that
> talked to WebURLLoaderImpl (which talked to Blink) with code in
> ResourceDispatcher in content which used IPC. Now that WebURLLoaderImpl
> is in content/child, we don't need this interface anymore.
> 
> As requested by John in -
> https://codereview.chromium.org/186193005/diff/1/content/public/child/resource_loader_bridge.h#newcode42
> 
> BUG=265753,338338,237249
> TEST=content_unittests
> R=jam@chromium.org
> TBR=darin
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267947

Review URL: https://codereview.chromium.org/267973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267999 0039d316-1c4b-4281-b951-d872f2087c98

Specifically, subclasses InfoBubbleWindow with the sole purpose of catching
calls to -performKeyEquivalent: and forward them to the parent window.

Longer explanation:
The base implementation of -performKeyEquivalent:, found in
ChromeEventProcessingWindow, attempts to hand browser key events off to 
the window’s responder or delegate.  The InfoBubbleWindow's responder and 
delegate do not implement the correct protocols to handle the events, and so 
the events are not completed.

This subclasses -performKeyEquivalent: to send the events to the parent 
window, which, if it is a browser window, will have the correct responder and 
thus handle the events.

BUG=367206

Review URL: https://codereview.chromium.org/265693009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267996 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369680

Review URL: https://codereview.chromium.org/267863006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=361761
TEST=no visible change

Review URL: https://codereview.chromium.org/261783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267994 0039d316-1c4b-4281-b951-d872f2087c98

This makes the LogoService respect the --google-base-url command line
flag when determining the URL from which to download Google doodles.
This allows easier manual testing of the doodle: if there's a doodle in
France today, set the flag --google-base-url=https://www.google.fr and
the current google in France will be shown.

BUG=369676
NOTRY=true

Review URL: https://codereview.chromium.org/264713013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267991 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267990 0039d316-1c4b-4281-b951-d872f2087c98

https://code.google.com/p/skia/source/list?num=9&start=14553
TBR=
BUG=

Review URL: https://codereview.chromium.org/262993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267989 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369550
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/269573010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267988 0039d316-1c4b-4281-b951-d872f2087c98

UI/Strings requested a change to be
"Try the new <a>Chrome Apps & Extensions Developer Tools</a>."

BUG=312396
TBR=finnur@chromium.org (for changes to strings in extension_settings_handler)

Review URL: https://codereview.chromium.org/262653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267987 0039d316-1c4b-4281-b951-d872f2087c98

This is nhiroki@'s change, previously landed as r267850 but reverted.
Re-landing with a fix suggested by michaeln@.

Original code review: http://crrev.com/265743012

BUG=369464
R=michaeln@chromium.org,nhiroki@chromium.org,kinuko@chromium.org

Review URL: https://codereview.chromium.org/261063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267986 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/268773007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267985 0039d316-1c4b-4281-b951-d872f2087c98

Specifically only look for re-entrancy that shrinks the queue. We know
that other types of iterator invalidation happens due to growing the
queue, but that doesn't match the symptom we're seeing.

BUG=369539

Review URL: https://codereview.chromium.org/265093004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267984 0039d316-1c4b-4281-b951-d872f2087c98

gzip files so clients can download faster.

BUG=362787

Review URL: https://codereview.chromium.org/268743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267983 0039d316-1c4b-4281-b951-d872f2087c98

The previous method for calculating playback time assumed all data
currently buffered contained audio data scaled at the same rate. In
reality, when the playback rate changes we enter a brief period where
audio data scaled at different rates is buffered. The end result was 
that the media clock would jump backwards/forwards, introducing playback
jank.

BUG=367343

Review URL: https://codereview.chromium.org/256163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267982 0039d316-1c4b-4281-b951-d872f2087c98

Relanding with a check for division by zero. Also reformating a few clunky
lines in RenderingStats.

R=tonyg@chromium.org
BUG=308652

Review URL: https://codereview.chromium.org/268803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267981 0039d316-1c4b-4281-b951-d872f2087c98

There were several cases in ContentViewCore where a MotionEvent was obtained
(copied) for offsetting purposes, but was not recycled because of early function
exit. Fix this by recycling the event in the finally clause. Also avoid copying
touch events if the current touch offset is zero.

Review URL: https://codereview.chromium.org/263833013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267980 0039d316-1c4b-4281-b951-d872f2087c98

BUG=364183
TEST=none
TBR=isherman

Review URL: https://codereview.chromium.org/269723007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267979 0039d316-1c4b-4281-b951-d872f2087c98

When a FileStream is deleted while Open is in progress, the file was being
closed on the wrong thread because it was not being transferred to the
FileStream::Context.

This CL transfers the file to the context even if it is orphaned.

BUG=322664
TEST=net_unittests

Review URL: https://codereview.chromium.org/250783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267977 0039d316-1c4b-4281-b951-d872f2087c98

Stupid natural numbers.

BUG=367636
R=estade@chromium.org

Review URL: https://codereview.chromium.org/264713008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267975 0039d316-1c4b-4281-b951-d872f2087c98

In debug builds, the callback parameters are validated. Since this value
is not sent on an alarm that doesn't exist, the validation fails.

The fix here is to make the parameter optional.

BUG=369636

Review URL: https://codereview.chromium.org/267723014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267974 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368728
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/261823009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267972 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267971 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/257953003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267970 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703
TBR=bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/268803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267969 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369461

Review URL: https://codereview.chromium.org/260903019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267968 0039d316-1c4b-4281-b951-d872f2087c98

To help make test results more informative, updated AppInfoPermissionsTabTest to
use EXPECT and ASSERT in appropriate places. Future test failures will now halt
or continue correctly depending on the failed check.

Also added other minor cleanups to make the test easier to read/maintain.

BUG=368758

Review URL: https://codereview.chromium.org/265703010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267966 0039d316-1c4b-4281-b951-d872f2087c98

This CL implements open_resource() in non-SFI mode.
1) Introduced a new sync message PpapiHostMsg_OpenResource
and its handlers.
2) Implement async version of OpenManifestEntry. As IPC's
handler is called on renderer's main thread, otherwise it
causes deadlock.

TEST=Run trybots.
BUG=358431

Review URL: https://codereview.chromium.org/249183004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267962 0039d316-1c4b-4281-b951-d872f2087c98

From the kitkat-release branch - these are needed to compile hardware.c.

BUG=358029

Review URL: https://codereview.chromium.org/254683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267960 0039d316-1c4b-4281-b951-d872f2087c98

We seem to be reporting the whole memory limit as unreleasable. In
reality the memory limit shouldn't play a role in what we have
allocated, whether it is releasable or not.

BUG=369481
R=reveman

Review URL: https://codereview.chromium.org/266003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267959 0039d316-1c4b-4281-b951-d872f2087c98

We are removing notifications (NotificationService API) from InfoBar
code. And thus we need to migrate its uses to the Observer style.
This is what this patch does.

BUG=354380
TEST=browser_tests --gtest_filter=AutofillInteractiveTest.*
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/269543010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267958 0039d316-1c4b-4281-b951-d872f2087c98

> Support 8bpp screens in X11
> 
> Use Xrender to do the color conversion to 8bpp.
> 
> BUG=368425
> 
> Review URL: https://codereview.chromium.org/264903004

TBR=jbauman@chromium.org

Review URL: https://codereview.chromium.org/267883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267957 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267956 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369703
R=bajones@chromium.org

Review URL: https://codereview.chromium.org/265933012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267955 0039d316-1c4b-4281-b951-d872f2087c98

Includes the following CLs:

Fix bugs in intel-gcm-x86-masm.asm and re-enable the Intel AES assembly
code.
https://codereview.chromium.org/254213002

R=agl@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/266673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267954 0039d316-1c4b-4281-b951-d872f2087c98

This fixes \src\chrome\common\extensions\dos\server2\integration_test.py
failure under Windows.  Here, path_utils.py requires path with separator '/', but it's given separator '\\' in Windows and fails.

BUG=369510
NOTRY=true

Review URL: https://codereview.chromium.org/264793013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@267952 0039d316-1c4b-4281-b951-d872f2087c98