GitLab

BUG=309847
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/126513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243471 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a class for extraction of audio and video metadata using ffmpeg.

This is needed to implement the Media Galleries Metadata API for Chrome extensions.

BUG=318450

Review URL: https://codereview.chromium.org/121383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243470 0039d316-1c4b-4281-b951-d872f2087c98

The extension provides fast bitmap operations with no external
dependencies. However, it is not available on all platforms.

BUG=323813
TEST=telemetry bitmap_unittest
R=bulach@chromium.org, tonyg@chromium.org

Review URL: https://codereview.chromium.org/121493004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243469 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/113653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243468 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Added to existing tests
R=sky

Review URL: https://codereview.chromium.org/126883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243467 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: Caused a 30% rasterization regression

TBR=reveman@chromium.org,senorblanco@chromium.org,vangelis@google.com,reed@google.com
BUG=310796,332137

Review URL: https://codereview.chromium.org/126343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243466 0039d316-1c4b-4281-b951-d872f2087c98

- Removed unused fields from DriveAppInfo.
  It is easy to recover them later when needed.
- A bit of rewriting for FindPreferredIcon.

BUG=332014
R=hashimoto@chromium.org

Review URL: https://codereview.chromium.org/125163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/125403006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243462 0039d316-1c4b-4281-b951-d872f2087c98

Ignore offset parameter in encode callback. It is ignored/deprecated by the caller, and bitmap.pixelRefOffset() is also deprecated

BUG=

Review URL: https://codereview.chromium.org/116693005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243461 0039d316-1c4b-4281-b951-d872f2087c98

The TrackableCallback manages the callback and the request ID so that we don't
need to manage them separately.

Also in this CL:
- Using media::Decryptor in .cc file.
- Renaming: pending_foo_cb_ -> foo_cb_

Review URL: https://codereview.chromium.org/105743010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243460 0039d316-1c4b-4281-b951-d872f2087c98

Before this, an OWNER of the entire directory that a new DEPS rule was pointing to would be required, even when the DEPS rule specified an individual file for which there are per-file OWNERS in the OWNERS file.

BUG=290401

Review URL: https://codereview.chromium.org/116443011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243459 0039d316-1c4b-4281-b951-d872f2087c98

The EME infobar should be dismissed when it was requested
in an iframe and it is navigated away.

BUG=297891

Review URL: https://codereview.chromium.org/107413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=310389
NOTRY=True

Review URL: https://codereview.chromium.org/117833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243457 0039d316-1c4b-4281-b951-d872f2087c98

Trying to get rid of GetDefaultProfile since it was depricated since 2011. See https://docs.google.com/a/google.com/document/d/1Fo0_ixnmOYDZKjcdzU3btED3yWINpdBvzpgl7EBOZro/edit#heading=h.5pkgd9yd16w5 for more informations!

BUG=322682
TEST=covered by existing unit tests

Review URL: https://codereview.chromium.org/101653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243456 0039d316-1c4b-4281-b951-d872f2087c98

It was previously "chrome_app_list" regardless of which build we are in.

BUG=331729

Review URL: https://codereview.chromium.org/120723006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243453 0039d316-1c4b-4281-b951-d872f2087c98

The structs are internal to the pnacl_shim.c.

BUG=none
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/126343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243452 0039d316-1c4b-4281-b951-d872f2087c98

BUG=124445
NOTRY=true
TBR=wtc@chromium.org

Review URL: https://codereview.chromium.org/127253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243451 0039d316-1c4b-4281-b951-d872f2087c98

(Except for two-phase read/writes in "may discard" mode, which isn't
supported yet.)

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/126663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243450 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243449 0039d316-1c4b-4281-b951-d872f2087c98

TBR=spang
BUG=318315

This reverts commit af01a3b5.

Review URL: https://codereview.chromium.org/127223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332148
TEST=mv ~/.boto ~/.boto.bak; rm tools/perf/page_sets/data/key_silk_cases_000.wpr; tools/perf/run_benchmark silk.key_silk_cases -v; mv ~/.boto.bak ~/.boto

Review URL: https://codereview.chromium.org/126093006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243447 0039d316-1c4b-4281-b951-d872f2087c98

This makes gyp_chromium pass defines defined via -D on the command line to GN.

Fixes double-escaping of strings from supplemental.gypi files.

Pass use_goma to the GN build.

Handle "use_goma" and "use_goma=1" (same for other boolean values). Previously values with no equals sign were getting converted to 'true', which doesn't match '1' which we look for.

Output goma wrappers in the GYP header for Windows toolchains.

R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/123463005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243446 0039d316-1c4b-4281-b951-d872f2087c98

This CL removed a deadlock on camera removal, but created a new one
on shutdown while a camera is running.

> When stopping QTKit video capture, call stopRunning before removeInput:.
> 
> Empirically, this prevents a browser hang when the active camera is
> unplugged.  The unplug event triggers both stopping the capturer and
> enumerating the available input devices at the same time.  It seems
> that calling removeInput: on a running capturer after an error
> produces a deadlock, but stopping the capturer first resolves the
> problem.
> 
> BUG=285053
> 
> Review URL: https://codereview.chromium.org/120963003

TBR=bemasc@chromium.org

Review URL: https://codereview.chromium.org/126883005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243445 0039d316-1c4b-4281-b951-d872f2087c98

This enables imports to use the built-in programatic variables like root_build_dir.

R=scottmg@chromium.org, scottmg

Review URL: https://codereview.chromium.org/126033006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243444 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: breaks license checker

TBR=darin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=318315

Review URL: https://codereview.chromium.org/127133002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243443 0039d316-1c4b-4281-b951-d872f2087c98

Revert 243438 "Revert 243413 "Resize the widget when top level p..."

> Revert 243413 "Resize the widget when top level popup windows cr..."
> 
> > Resize the widget when top level popup windows created by the content layer are resized.
> > 
> > The content layer creates top level popup windows, for select items on a page for e.g. When these
> > windows are resized we need to resize the parent widget hosting them.
> > 
> > BUG=330596
> > TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest
> > R=sky@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/125203005
> 
> TBR=ananta@chromium.org
> 
> Review URL: https://codereview.chromium.org/127073003

TBR=ccameron@chromium.org

Review URL: https://codereview.chromium.org/127163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243442 0039d316-1c4b-4281-b951-d872f2087c98

The use of a '.' in a trace name only breaks the telemetry value result if it
occurs in a value which does not have a trace_name.  This CL moves the assert
into the Value object so that the assert doesn't fire in other situations
(such as the media.tough_media_cases benchmark), where the use of the '.' is
actually ok.

BUG=332041,329845

Review URL: https://codereview.chromium.org/126013002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243441 0039d316-1c4b-4281-b951-d872f2087c98

For better memory ownership.

BUG=none

Review URL: https://codereview.chromium.org/115523011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243440 0039d316-1c4b-4281-b951-d872f2087c98

ToplevelWindowEventHandler::HandleMousePressed() has some comments about only handling events post target. Those comments are untrue so remove them.
It is also non trivial to get the originally desired behavior, namely getting mouse events to HTML elements with the "-webkit-app-region" CSS style applied. 

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/108723008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243439 0039d316-1c4b-4281-b951-d872f2087c98

> Resize the widget when top level popup windows created by the content layer are resized.
> 
> The content layer creates top level popup windows, for select items on a page for e.g. When these
> windows are resized we need to resize the parent widget hosting them.
> 
> BUG=330596
> TEST=Covered by views test DesktopAuraTopLevelOwnedPopupResizeTest
> R=sky@chromium.org
> 
> Review URL: https://codereview.chromium.org/125203005

TBR=ananta@chromium.org

Review URL: https://codereview.chromium.org/127073003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243438 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: this introduced a package dependency bug where ia32-libs cannot be installed on ubuntu precise systems

TBR=kkimlabs@chromium.org,cjhopman@chromium.org,pschmidt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=290225

Review URL: https://codereview.chromium.org/126543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243437 0039d316-1c4b-4281-b951-d872f2087c98

DrMemory: Disable IEImporterBrowserTest.IEImporterMalformedFavoritesRegistry which times out occasionally.

BUG=332219
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://codereview.chromium.org/127053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243435 0039d316-1c4b-4281-b951-d872f2087c98

BUG=168996
TEST=Go to google.com, click on the lock icon, click on "Show cookies", and remove site data from the Allowed pane.

Review URL: https://codereview.chromium.org/126123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243434 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=jzern@chromium.org

Review URL: https://codereview.chromium.org/126863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243433 0039d316-1c4b-4281-b951-d872f2087c98

This moves all lazy initialization code out of cc/base/switches.cc. Code
that needs the value of these switches in a critical path should not rely
on lazy initialization in cc/switches.cc but instead handle this on its own.

Thread-safe lazy initialization code of impl-side painting status has
been added to WebLayerImpl.

This also removes the cc::switches::IsGPURasterizationEnabled() function,
which for consistency should not exist unless the logic to determine the
value is more complicated than HasSwitch(kEnableGPURasterization). This
function was never used in performance sensitive code so lazy initialization
was never necessary.

BUG=330937
TBR=jamesr

Review URL: https://codereview.chromium.org/122063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243432 0039d316-1c4b-4281-b951-d872f2087c98

remove AddressValidator; the functionality will be added to AddressValidator

BUG=none

Review URL: https://codereview.chromium.org/125633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243430 0039d316-1c4b-4281-b951-d872f2087c98

It's no longer used.

BUG=
TBR=binji

Review URL: https://codereview.chromium.org/123933006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243429 0039d316-1c4b-4281-b951-d872f2087c98

[Android] Fixes app crash when using both enable and disable delegated renderer command line switch.

The function UsingDelegatedRenderer should also check for command line switch
--disable-delegated-renderer's presence while determining the usage of
delegated renderer.

BUG=330714

Review URL: https://codereview.chromium.org/110913010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243428 0039d316-1c4b-4281-b951-d872f2087c98

Currently as soon as we see an uncheckable include (like ipc/*macros.h or
windows.h) we stop checking the file. Instead we should just skip that line
and continue checking.

Review URL: https://codereview.chromium.org/105633012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243427 0039d316-1c4b-4281-b951-d872f2087c98

In the current gyp rules, the unittests depend on the following three
children: (1) java, (2) native and (3) jni generation. This is not
correct as (2) has a functional dependency on (2). Having (3) being a
sibling of (2), as it is now, introduces a race when building the
unittest target from clean.
This change fixes the problem making the jni generation step a
dependency of the native build, rather than a sibling.

BUG=None
TEST=ninja -C out/Debug android_webview_unittests_apk
NOTRY=true

Review URL: https://codereview.chromium.org/116043010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243426 0039d316-1c4b-4281-b951-d872f2087c98