GitLab

The methods BrowserNonClientFrameView::ShouldPaintAsThemed() and
BrowserFrame::ShouldUseTheme() are used for the same purpose
and have equivalent behaviour.
This CL replaces ShouldPaintAsThemed() with ShouldUseTheme() to
avoid divergence in behaviour.

This is a follow up clean up CL to
https://chromium-review.googlesource.com/c/chromium/src/+/1453558.
There are no changes in behaviour in this patch.

Bug: 927381
Change-Id: I2f4f28a79d0b24395057cb13f58ef8f56508ad20
Reviewed-on: https://chromium-review.googlesource.com/c/1453217
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629796}

Enable native controls in Cros player by default.
Remove integration tests for old controls.

Bug: 909963
Change-Id: I40a08bfd51ab757ac74c14dbbf80129764670c19
Reviewed-on: https://chromium-review.googlesource.com/c/1427575Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629795}

Change-Id: I7cca1653fff5f990785d7c1cf28e83a6d96ba26e
Reviewed-on: https://chromium-review.googlesource.com/c/1456981
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629794}

Migrate callsites from ComponentContext/zx::channel to strongly-typed
APIs and ServiceDirectoryClient.

Bug: 920920
Change-Id: I8fe642112562e3e75ad7230d55415d05e35b6cf8
Reviewed-on: https://chromium-review.googlesource.com/c/1450587
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629793}

This CL creates a WPT WebDriver Test Runner that is able to run WPT Webdriver tests against ChromeDriver. This allows us to detect whether the chromedriver current APIs and any future change to chromedriver consistently meet standardized WebDriver specifications.

Design doc:
https://docs.google.com/document/d/1VvVmKbr-AKJa4pl_hORStJe0r6IM6AbzbP2sCtKgibk/edit?ts=5be0d7e7#

No-Export: True
Change-Id: If8491519c81a2284d8c1e873f3461383879072d3
Bug: 881513
Reviewed-on: https://chromium-review.googlesource.com/c/1368404Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Kyle Ju <kyleju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629792}

It was accidentally disabled by r627247.

Change-Id: I847a40d3350cad56c4967af850a93e854ae15614
Reviewed-on: https://chromium-review.googlesource.com/c/1457007
Auto-Submit: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629791}

This CL changes the install warnings and errors to use the rule id whenever
possible (instead of the rule index). Also, now the rule index is one-based.

BUG=926609

Change-Id: Ie7046aa328817cf9cf45c4e0171d31fcec9efcc6
Reviewed-on: https://chromium-review.googlesource.com/c/1455642
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629790}

https://android.googlesource.com/platform/external/perfetto.git/+log/10ef8b33f128..82f670fd3d37


git log 10ef8b33f128..82f670fd3d37 --date=short --no-merges --format='%ad %ae %s'
2019-02-06 primiano@google.com Merge "Add notify_traceur option"


Created with:
  gclient setdep -r src/third_party/perfetto@82f670fd3d37

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ic9ccb7fc28e455d9a67c8d9ce3baf2f28a742f10
Reviewed-on: https://chromium-review.googlesource.com/c/1456764Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#629789}

This CL improves the install warnings for manifest rules which can't be parsed.
To do this enable error generation for the Declarative Net Request API. Another
side effect of this is that rules with unknown keys are now ignored (with an
install warning), instead of being parsed correctly.

Generate code diff- https://www.diffchecker.com/9d55eAZ5

BUG=926609

Change-Id: I695225f8dd8e96366d6462d31414402d0b14c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/1454085
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629788}

The old behaviour was to give the user a link directly to the auth
page, I think because that page used to display the auth code once
the user completed the OAuth flow. It doesn't do that any more, so
although a user could technically work it out from the redirect URL
parameters, it's not very useful, so I've just made code a mandatory
command-line option, and provide a link to the website if it isn't
present.

Change-Id: Ibbf56da86762688f7015cf2f09d499686e04f184
Reviewed-on: https://chromium-review.googlesource.com/c/1457224Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629787}

Users report touchpad sometime stop working. But it can not reproduce on our
side. I suspected the issue maybe:

1. Direct Manipulation failed at initialize
2. Direct Manipulation on incorrect state similar to issue 847611
3. Chrome does not cover some state transition for Direct Manipulation

In this patch, we add logs behind feature flag PrecisionTouchpadLogging to
help us debug. We use feature flag instead of VLOG because VLOG is not working
on Windows (issue 440172).

Bug: 914914
Change-Id: I02a28418914f18558667666f9e0779cb8d4d2eb7
Reviewed-on: https://chromium-review.googlesource.com/c/1450612
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629786}

All bugs reported from the first landing are now fixed. Fingers
crossed that covers all of them!

BUG=924370
TBR=liberato

Change-Id: I26b178a07b8b08b13f7946a327e36eee9e8c7372
Reviewed-on: https://chromium-review.googlesource.com/c/1457021Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629785}

Bug: 927910
Change-Id: Ie38157fb762da4963bba213caad1db3cbfabc515
Reviewed-on: https://chromium-review.googlesource.com/c/1450227
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629784}

The C++11 standard provides a portable high-resolution monotonic clock
for time duration measurements, and it has worked well for zlib_bench.
Use that steady clock [1] for image_decode_bench.

[1] https://en.cppreference.com/w/cpp/chrono/steady_clock

Bug: 601198
Change-Id: I60903a1b11a5481621815df586ddfb49822b2e67
Reviewed-on: https://chromium-review.googlesource.com/c/1453396Reviewed-by: Leon Scroggins <scroggo@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629783}

Three error states (timeout, keyNotRegistered, and keyAlreadyRegistered)
were previously considered 'postmortem' states. This meant that dialogs
corresponding to these states would be shown after a request was finished
and after a DOMException was sent to the RP.

This CL changes those states to instead block resolution of the request
until the user acknowledges the dialog, and then close the request.

Reworded 'postmortem' references to 'awaiting user acknowledgement'
to better reflect this behavior.

Bug: 897757
Change-Id: I04330f5a87ebbc960cd4c1e8d2c1b65fe97d9cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1428879
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#629782}

This reverts commit 311d14e9.

Relanding after fixing some color space issues in crrev.com/c/1389504,
and adding pixel tests for the now disabled code paths.

Original change's description:
> Revert "Enable decode swap chain feature on waterfall"
>
> This reverts commit e1f01a15.
>
> Reason for revert: Makes video pixel tests flaky: crbug.com/917399
>
> Original change's description:
> > Enable decode swap chain feature on waterfall
> >
> > Enables DirectCompositionUseNV12DecodeSwapChain and D3D11VideoDecoder
> > features on waterfall.
> >
> > Bug: 848093
> > Change-Id: I561f5910a32cbe2adb1c47bd9c35df355bdce1a4
> > Reviewed-on: https://chromium-review.googlesource.com/c/1364341
> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> > Reviewed-by: Ilya Sherman <isherman@chromium.org>
> > Reviewed-by: Frank Liberato <liberato@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#618447}
>
> TBR=isherman@chromium.org,sunnyps@chromium.org,liberato@chromium.org
>
> Change-Id: I13cb41b59140475eb46e789e8c94fc4e610ab614
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 848093, 917399
> Reviewed-on: https://chromium-review.googlesource.com/c/1388645
> Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#618549}

TBR=isherman@chromium.org,sunnyps@chromium.org,liberato@chromium.org


Bug: 848093, 917399, 927901
Change-Id: Iae0e57e4d2abb0332a42d37b51763e2a19bb5190
Reviewed-on: https://chromium-review.googlesource.com/c/1453576Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629781}

The 17763 version of d3dcompiler_47.dll requires ucrtbase.dll. Change
crrev.com/c/1450414 switched to this new version of d3dcompiler_47.dll
and adjusted the DLLs we ship in isolates but in the debug case it
only shipped ucrtbased.dll, not ucrtbase.dll. This fixes that.

Local testing shows that angle_end2end_tests.isolate now always contains
ucrtbase.dll.

Bug: 929295, 920704
Change-Id: I3bb64dde923407e94404073b8f8f9bfd57692eac
Reviewed-on: https://chromium-review.googlesource.com/c/1457018Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629780}

Bug: 929430
Change-Id: I9718e3b37672bd53915479cbec43c03509efee16
Reviewed-on: https://chromium-review.googlesource.com/c/1457418Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#629779}

This CL adds more tests to WebRtcGetDisplayMediaBrowserTest covering audio cases.

Bug: 896333
Change-Id: I6124237ceb43d18c3e3ecf9f2adc59b86952c19a
Reviewed-on: https://chromium-review.googlesource.com/c/1450853Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Emircan Uysaler <emircan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629778}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/117a1fd11f11..9b6ba4d1c57e


git log 117a1fd11f11..9b6ba4d1c57e --date=short --no-merges --format='%ad %ae %s'
2019-02-06 33432579+alan-baker@users.noreply.github.com Allow arrayed storage images for NonWritable decoration (#2358)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@9b6ba4d1c57e

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: If6816e4b22b1990c56d54e002acdfbf7305f620e
Reviewed-on: https://chromium-review.googlesource.com/c/1456610Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#629777}

With the updated Java tests window maximize tests are now passing.
Enabling these tests.

Change-Id: I01c701564b8f668b9d660126d373e36df24c0a34
Reviewed-on: https://chromium-review.googlesource.com/c/1457204Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629776}

This CL updates margins in signin_view.xml to match the mocks.

Bug: 927425
Change-Id: Ibe93a7768a041f8d93fe2d802e1097d2e4d3b81f
Reviewed-on: https://chromium-review.googlesource.com/c/1456059
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629775}

H264 GetNumReferenceFrames() was increased by 1 [1] for all platforms to
circumvent a limitation during introduction of the kReduced mode; this
CL:
- Renames VaVDA::BufferAllocationMode::kReduced to kSuperReduced.
- Takes that +1 out of h264_decoder
- Introduces kReduced to represent this H264 case where we +1 the
  amount of media pipeline frames allocated.

Note that this CL doesn't change ToT: there's an extra allocation
in the # codec reference frames _and_ in the amount of pipeline
buffers.

Test results ToT: https://pastebin.com/YG1Tcgya
With this change: https://pastebin.com/JgER07id and
https://paste.googleplex.com/5473272024006656 (2nd round) - similar.

This way, we can have all buffer amount calculations in one place,
specially with a view to introducing kReduced for platforms < SkyLake.

[1] https://cs.chromium.org/chromium/src/media/gpu/h264_decoder.cc?dr=C&sq=package:chromium&g=0&l=1428

TBR=hiroh@chromium.org (bc of
  http://crrev.com/c/1455302#message-3083834c541894c42a630b7fd73b6cd5095ce67e)

Test: tast run DEVICE_IP video.PlaybackPerfH2642160P60FPS on a SkyLake device (cave)
Bug: 912295, 920510
Change-Id: Ice286b1bd4db21f353d86cb9c65467e1322963be
Reviewed-on: https://chromium-review.googlesource.com/c/1455302Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629774}

The link opens up the system diagnostics tool, if there is one. On
Windows, URLs the diagnostics tool is used on is logged to disk.

Bug: 929141
Change-Id: I4130279eec02e932cf846017bab2e8956d9b79f8
Reviewed-on: https://chromium-review.googlesource.com/c/1456685
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629773}

Bug: chromedriver:2080
Change-Id: I9bbf0cdaf79c26ea6e83043b11698d39b0151579
Reviewed-on: https://chromium-review.googlesource.com/c/1457176Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629772}

This replaces MediaPlayerManager with MediaPlayerBridge::Client. It
also cleans up a lot of unused methods from the MediaPlayerBridge.

The only functional change should be a slightly different event flow
from converting OnMediaMetadataChanged into OnDurationChanged.

Bug: 570711, 790766
Change-Id: I7debb42406f2ae21d016c3c19597b9f6534f0de8
Reviewed-on: https://chromium-review.googlesource.com/c/1453110
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629771}

TBR=kenrb@chromium.org

Bug: 928825
Change-Id: I5402e4e2ec79f294862607adb94c4680803dc6b8
Reviewed-on: https://chromium-review.googlesource.com/c/1456199Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629770}

The Serial API cannot be implemented on Android so this change removes
all of the related code from the //content/browser build. The associated
//chrome/browser code is already disabled.

A follow-up change will also disable the API by default in Blink.

Bug: 928712
Change-Id: Ia6d099e7cbc9cb1ff8a3b4722bfd70a1bccafd24
Reviewed-on: https://chromium-review.googlesource.com/c/1455649
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629769}

-openOrReuseTabInMode can be executed while the app is in one of four states:

1) The current tab is not the NTP.
In this case, we create a new tab and load the new URL.

2) The current tab is the NTP, and it's fully loaded.
In this case, we load the new URL in the current tab.

3) The current tab is the NTP, but it has a pending load that hasn't yet committed.
The old code would have tried to clobber the NTP and load the new URL in the
current tab, but that was leading to crashes or broken behavior.

  3a) If the new URL is for a webpage, after this CL, we will instead load the
      URL in a new tab.
  3b) If we are instead being asked to create an NTP, we special case this and
      do nothing, because we've already got an NTP that's in the process of
      loading.

Bug: 929168
Change-Id: I24ce53ba755b8dd8d69ad81062036dd9c7605093
Reviewed-on: https://chromium-review.googlesource.com/c/1456639
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629768}

With the introduction of Windows 10 on ARM comes the need to cross-
compile for it. The Chromium build regularly uses symlinks from the
target output directory to the host output directory to make this
happen.

This change adds no-escalation symlink-ish functionality for Windows to
the script that implements symlinking in the Chromium build. The
biggest caveat to this support is that files are hard-linked, so any
time that a symlink target is deleted and replaced without recreating
the symlink, hard links will be stale. This is acceptable because the
Chromium build system always re-makes links when the original changes.

Bug: 893460,927113
Change-Id: I451a4f353bf6bc976d244b3b08a09a646b278368
Reviewed-on: https://chromium-review.googlesource.com/c/1447251Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629767}

The override of RegisterListPref taking a std::unique_ptr<base::Value>
is deprecated in favor of the method taking the base::Value by value.

Convert client code to either not pass default value if the value is just
an empty list (as there is an override doing this). If the list is not
empty, convert the code to create and pass it by value.

This CL was uploaded by git cl split.

Bug: 646113
Change-Id: Ib69414c8c81b129942a7b53ed7884ee5d449eef2
Reviewed-on: https://chromium-review.googlesource.com/c/1454583
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629766}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e5029b0b32bb..96982ab4da6c


Created with:
  gclient setdep -r src-internal@96982ab4da6c

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I276a747db0810fb2fb3e39265c6484c5faf2e92e
Reviewed-on: https://chromium-review.googlesource.com/c/1456768Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#629765}

This isn't required, and R8 now doesn't allow you to specify a main dex list
anymore, which will block us when we roll.

Change-Id: I588d64b41daa6d5246c893c7a8062b9ee9b73968
Reviewed-on: https://chromium-review.googlesource.com/c/1455114Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629764}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/35b498de..003f99ea

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4141e89d0b0c7e61eb6ff989c4f64f017cfee41f
Reviewed-on: https://chromium-review.googlesource.com/c/1456951Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#629763}

When we added a helper function to compute enabled state from the
variation the boolean condition was reversed, causing clients that
are enabled to cancel their background task (and not do any processing)
and the clients that are disabled to continue to do work.

Bug: 929371
Change-Id: I168b01644d0248c98a9af78cc7f674d541584fa4
Reviewed-on: https://chromium-review.googlesource.com/c/1456985Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629762}

Bug: chromedriver:2768
Change-Id: I767f85b03941e3b5ff99beae216e08cb7ba40d0a
Reviewed-on: https://chromium-review.googlesource.com/c/1456291Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629761}

Change-Id: I73234122c72b45b68b1d42e1d32a56f6f46b8f37
Reviewed-on: https://chromium-review.googlesource.com/c/1454905
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629760}

https://chromium.googlesource.com/catapult.git/+log/eeb21ab0411e..11e283fea253


git log eeb21ab0411e..11e283fea253 --date=short --no-merges --format='%ad %ae %s'
2019-02-06 achuith@chromium.org cros: No longer need --disable-logging-redirect.
2019-02-06 charliea@chromium.org Fix ftrace clock sync errors on CrOS


Created with:
  gclient setdep -r src/third_party/catapult@11e283fea253

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:928547,chromium:925366
TBR=sullivan@chromium.org

Change-Id: I76a487aa87cfb4c3b3505d03a4ab9790f9d91f47
Reviewed-on: https://chromium-review.googlesource.com/c/1456770Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#629759}

This issue is cause by an empty space between volume slider
and the container. When user hover on mute button in a small
video/audio frame, the volume slider shoot out towards right,
which makes the mouse ended up in the empty space which will
close the volume slider. Fixed by adding a container class around
mute button and volume slider and close the volume slider
only if user is not hovered on the container rather than
mute button/volume slider.

Bug: 921918
Change-Id: Ida2d943104fca3ab74290e58674856ada25555d5
Reviewed-on: https://chromium-review.googlesource.com/c/1413395
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629758}

The override of RegisterDictionaryPref taking a std::unique_ptr<base::Value>
is deprecated in favor of the method taking the base::Value by value.

Convert client code to either not pass default value if the value is just
an empty dictionary (as there is an override doing this). If the dictionary
is not empty, convert the code to create and pass it by value.

This CL was uploaded by git cl split.

Bug: 646113
Change-Id: I63568d465b7244af4cd687097380c628c54da7e6
Reviewed-on: https://chromium-review.googlesource.com/c/1454366
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Emily Stark <estark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629757}