GitLab

R=jkummerow@chromium.org


Review URL: http://codereview.chromium.org/9317028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120069 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/9315005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120068 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commits r120044 and r120053. '044 broke the Win Aura bot, '053 did not fix it, and it's been burning since.

BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com/9307036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120067 0039d316-1c4b-4281-b951-d872f2087c98

using src/build/protoc.gypi to offer consistency between the other
compilation steps, as well as ensuring that important variables (such as
hard_dependency) are always properly set.

BUG=109955


Review URL: http://codereview.chromium.org/9148084

TBR=kushi.p@gmail.com
Review URL: https://chromiumcodereview.appspot.com/9317034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120066 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:112027
TEST=unit test, see bug.


Review URL: http://codereview.chromium.org/9264070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120065 0039d316-1c4b-4281-b951-d872f2087c98

using src/build/protoc.gypi to offer consistency between the other
compilation steps, as well as ensuring that important variables (such as
hard_dependency) are always properly set.

BUG=109955


Review URL: http://codereview.chromium.org/9148084

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120063 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yuzo@chromium.org

BUG=112278
TEST=webkit valgrind bots

Review URL: https://chromiumcodereview.appspot.com/9309032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120062 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105624,111757
TEST=content_unittests

Review URL: https://chromiumcodereview.appspot.com/9301031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120061 0039d316-1c4b-4281-b951-d872f2087c98

This directory is now pulled in via DEPS.

BUG=111334


Review URL: http://codereview.chromium.org/9316030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120060 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=


Review URL: http://codereview.chromium.org/9293033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120059 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:18032
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=119897

Review URL: http://codereview.chromium.org/8819019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120058 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120057 0039d316-1c4b-4281-b951-d872f2087c98

    
BUG=111334
Review URL: https://chromiumcodereview.appspot.com/9293016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120056 0039d316-1c4b-4281-b951-d872f2087c98

This test was added as "FAILING" in

http://src.chromium.org/viewvc/chrome?view=rev&revision=119112

However, the test is  passing fine. Please see

http://codereview.chromium.org/9129024

for a discussion explaining why it passes.

BUG=111185
TEST=RenderWidgetHostTest.MultipleInputEvents


Review URL: http://codereview.chromium.org/9235056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120055 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:23743
TEST=Manual.


Review URL: http://codereview.chromium.org/9159065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Run aura_shell_unittests

Review URL: https://chromiumcodereview.appspot.com/9316029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120053 0039d316-1c4b-4281-b951-d872f2087c98

Linux: use the bounds from the most recent BrowserWindowGtk::OnConfigure() call to figure out whether to return early in a later call, rather than bounds that may also be updated by a debounced callback with different (but more accurate, for some window managers) values.

BUG=112041

Review URL: http://codereview.chromium.org/9307018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120050 0039d316-1c4b-4281-b951-d872f2087c98

- Increase line height by 1px so favicon can be visually centered.
- Ensure entry text cap height is centered on the favicon.
- Make checkboxes and drop-down buttons square.

BUG=111941
TEST=Check visual alignment of items on chrome://history.


Review URL: http://codereview.chromium.org/9293011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120048 0039d316-1c4b-4281-b951-d872f2087c98

Close login window after a browser is opened. This is necessary because browser has nested loop which wait for session data.
Don't apply sho/hide animation to lock screen.

This depends on http://codereview.chromium.org/9233044/ and I will run bots after it is landed.

BUG=none
TEST=manual

Review URL: https://chromiumcodereview.appspot.com/9264059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=111900
TEST=Verify that the 'Manage extensions' contextual menu invokes the extensions page.
Review URL: https://chromiumcodereview.appspot.com/9318019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120045 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104192
TEST=None


Review URL: http://codereview.chromium.org/9121050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120044 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=chromium-os:25272
TEST=Open the systems options page, make sure there is only one a11y option


Review URL: http://codereview.chromium.org/9295010

TBR=zork@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9316024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120043 0039d316-1c4b-4281-b951-d872f2087c98

Re-enabled synthesized mouse event for linux aura
Disabled synthesized mouse event for win aura.

TBR=ben@chromium.org
BUG=112222
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9314021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120042 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/9309013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120041 0039d316-1c4b-4281-b951-d872f2087c98

R=dmazzoni@chromium.org
BUG=chromium-os:25272
TEST=Open the systems options page, make sure there is only one a11y option


Review URL: http://codereview.chromium.org/9295010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120040 0039d316-1c4b-4281-b951-d872f2087c98

Undo attempt to disable from unit_tests.gtest_mac.txt as it didn't solve the problem.

BUG=51716
TEST=Chromium Mac (Valgrind)(1) bot

Review URL: https://chromiumcodereview.appspot.com/9316020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120039 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben
BUG=112246
TEST=green bots

Review URL: https://chromiumcodereview.appspot.com/9314029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120038 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=trybots,manual (build SDK, inspect headers)

Review URL: http://codereview.chromium.org/9309012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120036 0039d316-1c4b-4281-b951-d872f2087c98

* Rename "normal" to "overlapping", since there was some confusion about whether or not compact mode is "normal"
* Remove "--aura-workspace-manager" flag in favor of "--aura-window-mode=managed", as this feature is not compatible with compact mode.
* Change about:flags Window mode to a three-way choice between modes

BUG=112139
TEST=aura_shell_unittests ShellTest, manual check of about:flags


Review URL: http://codereview.chromium.org/9316005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120035 0039d316-1c4b-4281-b951-d872f2087c98

Make Ctrl+Alt+T open Crosh in HTML Terminal on Aura build.
If HTerm is not installed nothing should happen..

BUG=105649
TEST= manual on Stumpy VM with HTerm extension installed.


Review URL: http://codereview.chromium.org/9297008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120034 0039d316-1c4b-4281-b951-d872f2087c98

change labels to -webkit-inline-box. This doesn't change the children but the box itself will behave like an inline element rather than block (won't expand horizontally). Also remove box flex on the span as it's not necessary. Also add some padding on the end of the labels so that there is extra clickable area when the text is short (this doesn't change anything if the span is long enough to wrap).

In native dialogs:
On Linux/GTK, the clickable area extends all the way to the right (our behavior before this patch).
On Mac, the clickable area is only the text and the checkbox
On Windows, the clickable area extends beyond the text but not all the way to the far right.

I'm splitting the difference by matching Windows native behavior, which seems both logical and the middle road.

BUG=112091
TEST=1. Checkbox labels should be clickable on either the text or the checkbox, but not more than 100px from the right edge of the checkbox. 2. Long labels still wrap with indent (see bug 109334)

Review URL: https://chromiumcodereview.appspot.com/9307015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120033 0039d316-1c4b-4281-b951-d872f2087c98

cr.ui.List.ensureAllItemSizesInCache() has manipulate elements and it has sometimes changed the scroll position and/or the client height unexceptionally.

To prevent it, this CL moves reading of the positions before ensureAllItemSizesInCache().

BUG=110140
TEST=manual on taskmanager.

Review URL: http://codereview.chromium.org/9318012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120032 0039d316-1c4b-4281-b951-d872f2087c98

The exit-code from remoting_me2me_host will be used to communicate to the
daemon that the Host ID was rejected as invalid.


BUG=110046
TEST=Run remoting_me2me_host with invalid host.json


Review URL: http://codereview.chromium.org/9301026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120031 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9314027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=112137
TEST=sign into Chrome, open settings page, click Google Dashboard link

Review URL: https://chromiumcodereview.appspot.com/9310006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120028 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104418
TEST=none


Review URL: http://codereview.chromium.org/9316007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120027 0039d316-1c4b-4281-b951-d872f2087c98

BUG=108171



Review URL: http://codereview.chromium.org/9159068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120026 0039d316-1c4b-4281-b951-d872f2087c98

Adds two new observer methods to allow code to be notified when a Window is added/removed from a RootWindow. This allows hierarchy-specific cleanup code to execute when a Window is removed rather than when it is destroyed, necessary for multiple root windows.

http://crbug.com/112131
TEST=see unittests
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119976

Review URL: http://codereview.chromium.org/9315015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120025 0039d316-1c4b-4281-b951-d872f2087c98