GitLab

Storing MPEG-4 B-frames in AVI has always been a bit of a hack and by default av_read_frame() will return non-timestamped video packets for such content. AVFMT_FLAG_GENPTS takes advantage of AVI's constant framerate to generate presentation timestamps at the expense of parsing delay.

BUG=169570

Review URL: https://codereview.chromium.org/12209111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182310 0039d316-1c4b-4281-b951-d872f2087c98

This has to be committed *after* https://codereview.chromium.org/12221127/

BUG=161094


Review URL: https://chromiumcodereview.appspot.com/12218109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182309 0039d316-1c4b-4281-b951-d872f2087c98

BUG=174097
TEST=manually checked on goobuntu

Review URL: https://codereview.chromium.org/12248012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182307 0039d316-1c4b-4281-b951-d872f2087c98

This is split out from https://codereview.chromium.org/11881042

BUG=124830
TEST=None

Review URL: https://codereview.chromium.org/12087017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182305 0039d316-1c4b-4281-b951-d872f2087c98

BUG=173262

Review URL: https://codereview.chromium.org/12263016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182304 0039d316-1c4b-4281-b951-d872f2087c98

> Verify the signature on user cloud policy downloads.
> 
> The signature on the user cloud policy blob is already verified by the session
> manager on ChromeOS, but should also be verified by Chrome before storing new
> policy, and after loading policy from the cache.
> 
> BUG=174015
> 
> 
> Review URL: https://chromiumcodereview.appspot.com/12183017

TBR=joaodasilva@chromium.org
Review URL: https://codereview.chromium.org/12255017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182302 0039d316-1c4b-4281-b951-d872f2087c98

A Callback decides when it is constructed whether it needs to do a weak pointer
check when called.  Therefore, pass the weak pointer of NetErrorTabHelper to
base::Bind when we create the callback instead of binding it later in
StartDnsProbe.

BUG=174720

Review URL: https://chromiumcodereview.appspot.com/12223080

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182301 0039d316-1c4b-4281-b951-d872f2087c98

Random changes have been breaking Android bots. It turns
out async uploads isn't the issue, but rather simply that
old ICS Imagination drivers crash on glTexSubImage2D (very
consistantly).

This enables async uploads again, but also puts in a
work-around in our work-around :). When we fallback
to glTexSubImage2D, we use glTexImage2D instead.

BUG=174440
NOTRY=True

Review URL: https://codereview.chromium.org/12221161

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182299 0039d316-1c4b-4281-b951-d872f2087c98

> Revert 182242
> > Files.app: Add missing JSdoc for member methods/variables #1.
> > 
> > All the changes are in comment. No semantics are changed.
> > 
> > BUG=175657
> > TEST=none
> > TBR=mtomasz@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/12254009
> 
> TBR=yoshiki@chromium.org
> Review URL: https://codereview.chromium.org/12254015

TBR=rdsmith@chromium.org
Review URL: https://codereview.chromium.org/12262017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182298 0039d316-1c4b-4281-b951-d872f2087c98

This improves the performance of removing a tile from the list to O(1) from O(n).  The O(n) removal time was showing up as lag spikes in a trace.

BUG=175939

Review URL: https://codereview.chromium.org/12207146

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182297 0039d316-1c4b-4281-b951-d872f2087c98

Fix for change in crrev.com/182280. These files are not used in any
upstream build.

BUG=

Review URL: https://codereview.chromium.org/12258017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182295 0039d316-1c4b-4281-b951-d872f2087c98

> Ensure that when themes in desktop chrome AURA on Windows use the opaque browser frame view.
> 
> To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
> DesktopBrowserFrameAura::ShouldUseNativeFrame override.
> 
> The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace
> ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin
> and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the
> DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA
> 
> BUG=175372
> R=sky
> Review URL: https://codereview.chromium.org/12251010

TBR=ananta@chromium.org
Review URL: https://codereview.chromium.org/12257014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182294 0039d316-1c4b-4281-b951-d872f2087c98

This CL makes the chrome://policy page respect embedded line breaks in
long policy values, fixing the appearance of pretty-printed string policy
values.

BUG=175999
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/12230012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182293 0039d316-1c4b-4281-b951-d872f2087c98

Adding guillemotleft, guillemotright and degree condition into
KeyboardCodeFromXKeysym.
These KeySym is used in Canadian French keyboard.

BUG=175624
TEST=Checked with typing international-backslash key on Canadian French keyboard.


Review URL: https://chromiumcodereview.appspot.com/12211127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182292 0039d316-1c4b-4281-b951-d872f2087c98

BUG=175760
TBR=jianli@chromium.org

Review URL: https://codereview.chromium.org/12223100

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/12211102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182288 0039d316-1c4b-4281-b951-d872f2087c98

BUG=158004
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12209094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182287 0039d316-1c4b-4281-b951-d872f2087c98

> Files.app: Add missing JSdoc for member methods/variables #1.
> 
> All the changes are in comment. No semantics are changed.
> 
> BUG=175657
> TEST=none
> TBR=mtomasz@chromium.org
> 
> Review URL: https://codereview.chromium.org/12254009

TBR=yoshiki@chromium.org
Review URL: https://codereview.chromium.org/12254015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182285 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/12223082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182284 0039d316-1c4b-4281-b951-d872f2087c98

This will also help when deploying SPDY wire format changes,
such as those upcoming in SPDY 4.

This lands server change 41941878.

Review URL: https://codereview.chromium.org/12224137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182283 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nirnimesh@chromium.org

Review URL: https://chromiumcodereview.appspot.com/12217137

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182282 0039d316-1c4b-4281-b951-d872f2087c98

To achieve this we need to mimic the implementation in BrowserFrameWin::ShouldUseNativeFrame in the
DesktopBrowserFrameAura::ShouldUseNativeFrame override.

The code in BrowserFrameWin::ShouldUseNativeFrame has been moved to a helper function in the browser namespace
ShouldUseNativeFrame in the newly added files browser_frame_common_win.h/.cc. This is invoked from BrowserFrameWin
and from the BrowserDesktopRootWindowHostWin::ShouldUseNativeFrame override which is invoked via the
DesktopBrowserFrameAura::ShouldUseNativeFrame override for AURA

BUG=175372
R=sky
Review URL: https://codereview.chromium.org/12251010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182281 0039d316-1c4b-4281-b951-d872f2087c98

To implement CertVerifyProc on Android we refer to the Java 
side to query the platform trust managers. Currently the 
information we get from the platform is binary - each 
certificate chain is either identified as trusted or not, in 
which case we assume that this is due to not-trusted root.

This patch provides better granularity distinguishing the 
following cases: expired, not yet valid, incorrect (could not 
be parsed), not trusted root.

This allowed to reenable two net unittests:
- CertVerifyProcTest.ExtraneousMD5RootCert
- CertVerifyProcTest.IntermediateCARequireExplicitPolicy

The following net unittest had to be disabled as it joins 
the club of CertVerifyProc tests failing on bots with 
incorrect time/date settings:
- CertVerifyProcTest.InvalidKeyUsage

BUG=169762

Review URL: https://chromiumcodereview.appspot.com/12212135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182280 0039d316-1c4b-4281-b951-d872f2087c98

The signature on the user cloud policy blob is already verified by the session
manager on ChromeOS, but should also be verified by Chrome before storing new
policy, and after loading policy from the cache.

BUG=174015


Review URL: https://chromiumcodereview.appspot.com/12183017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182279 0039d316-1c4b-4281-b951-d872f2087c98

This patch contains a few other small changes in behavior:

1. Removing the src attribute after navigation in <webview> will immediately restore it.
2. browserPlugin.terminate() will not issue an IPC as long as the BrowserPlugin is in a crashed state.
3. WebViewTest.Shim was misbehaving because it had lingering <webview>s in the DOM all in the same partition and so terminating one webview terminated them all, and caused multiple exit listeners to fire. This was fixed.
4. Fixed a potential infinite loop that could happen if the src attribute is modified while in a crashed state.

BUG=175206
Test=WebViewTest.Shim: webViewAssignSrcAfterCrash, webViewRemoveSrcAttribute

Review URL: https://chromiumcodereview.appspot.com/12224094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182278 0039d316-1c4b-4281-b951-d872f2087c98

The SQL statements weren't actually getting called (no Step()).

BUG=175968
TEST=nonzero entries in the histograms

Review URL: https://chromiumcodereview.appspot.com/12252002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182277 0039d316-1c4b-4281-b951-d872f2087c98

darin, jam, brettw which are the elders

Theya are part of the eng-review team so they should be the gatekepers of third party

BUG=none
TEST=none
Review URL: https://codereview.chromium.org/12180003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182276 0039d316-1c4b-4281-b951-d872f2087c98

TBR=szym@chromium.org
BUG=176048
TEST=waterfall.sh

Review URL: https://codereview.chromium.org/12254014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182275 0039d316-1c4b-4281-b951-d872f2087c98

> Add a link (to view Permissions) to the Extension details on chrome://extensions.
> 
> BUG=170742
> TEST=None
> 
> Review URL: https://chromiumcodereview.appspot.com/12094034

BUG=170742,175071
TBR=finnur@chromium.org
Review URL: https://codereview.chromium.org/12263014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182274 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182271 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=none


Review URL: https://chromiumcodereview.appspot.com/12256010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182270 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
BUG=none


Review URL: https://chromiumcodereview.appspot.com/12255013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=159200

Review URL: https://chromiumcodereview.appspot.com/12208135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182268 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r10739: (mseaborn) Use "volatile" when reading tramp_ret/user_ret from the untrusted stack
r10740: (mcgrathr) toolchain_build: Update binutils and gcc revisions
r10741: (mark) Mac OS X 64-bit support for nacl_signal_unittest.
r10742: (mark) Work around a questionable behavior of shm_open/shm_unlink on Mac OS X 10.8.
r10743: (mark) Update command_tester.py for 64-bit Mac OS X.
r10744: (mcgrathr) Deploy new ARM toolchain
r10745: (shcherbina) Validator_ragel: add support for memory access in gen_dfa.py.
r10746: (jvoung) build_nexe.py: Be sure to pass link_flags to pnacl-translate to find the shim.
r10747: (mark) Fix trusted_mmap_test for Mac OS X on x86_64.
r10748: (mseaborn) Remove outdated comments about hard-coded constants in assembly files
r10749: (kschimpf) Simplify the generation of instruction decoder testers for ARM tables.
r10750: (kschimpf) Add ability to (incrementally) use generated baselines in ARM testing.
r10751: (jfb) Don't configure with x86 options on ARM.
r10752: (mseaborn) Exception handling test: Replace crash_at_known_address_*.S
r10753: (kschimpf) Add uses to two ARM tables.
r10754: (jfb) Run under QEMU only when on the wrong platform.
r10755: (kschimpf) Use generated actual decoders in load_store_word_and_unsigned_byte.
r10756: (kschimpf) Use generated actual decoders for ARM table: media_instructions.
r10757: (kschimpf) Use generated actual decoders for ARM table:
r10758: (kschimpf) Use generated actual decoders for ARM table:
r10759: (kschimpf) Use generated actual decoders for ARM table:
r10760: (kschimpf) Use generated actual decoders for ARM table:
r10761: (kschimpf) Use generated actual decoders for ARM table:
r10762: (kschimpf) Use generated actual decoders for ARM table:
r10763: (kschimpf) Use generated actual decoders for ARM table:
r10764: (mseaborn) Performance tests: Add a test for setjmp()/longjmp()
r10765: (jvoung) Update pnacl gold rev: [MIPS] Fix for gp0 when reginfo section is not present
r10766: (halyavin) Debug stub: Fix bug that allows access to invalid memory on Windows.
r10767: (mseaborn) Clarify register list in syscall_return_regs_test.c
r10768: (kschimpf) Add uses to ARM table advanced_simd_data_processing_instructions.
r10769: (mseaborn) Clean up sel_memory.h functions to follow NaCl's CamelCase naming style
r10770: (kschimpf) Use generated actual decoders for ARM table:
r10771: (kschimpf) Use generated actual decoders for ARM table:
r10772: (mseaborn) Factor out duplicated GioMemoryFileSnapshotCtor() + NaClAppLoadFile() calls
r10773: (kschimpf) Use generated actual decoders for ARM table:
r10774: (jfb) gitignore toolchain_build/{cache,out,src}/
r10775: (kschimpf) Use generated actual decoders for ARM table:
r10776: (kschimpf) Use generated actual decoders for ARM table:
r10777: (mseaborn) sel_ldr_launcher: Use the C IMC interface rather than the C++ IMC interface
r10778: (mseaborn) IMC: Remove unused nacl::Send() and nacl::Receive() functions
r10779: (jvoung) Remove non-streaming sandbox translator invocations from the driver.
r10780: (shcherbina) Validator_ragel: implement r/m-splitting in gen_dfa.py.
r10781: (shcherbina) Validator_ragel: implement byte/non-byte split for gen_dfa.py.
r10782: (shcherbina) Validator_ragel: get rid of show-memory-suffix-... attribute.
r10783: (shcherbina) Validator_ragel: don't support spurios data16 prefix in decoder when rex.W=1.

BUG=none
TEST=nacl_integration

Review URL: https://codereview.chromium.org/12257009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182266 0039d316-1c4b-4281-b951-d872f2087c98

We didn't set the size of webview in https://codereview.chromium.org/12218122
This change should fix that

Scaling should be done by the Compositor thread, and we are no longer using css transform to do scaling.

BUG=175121

Review URL: https://codereview.chromium.org/12230018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182263 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes a one-letter typo in a policy description.

BUG=None
TEST=None
TBR=mnissler@chromium.org


Review URL: https://chromiumcodereview.appspot.com/12230009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182262 0039d316-1c4b-4281-b951-d872f2087c98

Use "cat /dev/null" rather than "echo".
"echo" is not guaranteed to be in the path or the system image.
"cat" seems available on the images used by the bots.

BUG=175127


Review URL: https://chromiumcodereview.appspot.com/12230008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182261 0039d316-1c4b-4281-b951-d872f2087c98

Before the change, the database would contain leftover "namespace-namespaceid-"
keys with no areas. This change ensures that they are not left over, and that
the existing leftover keys are scavenged. (This will delete the leftover data
for users who have it.)

BUG=175232
R=michaeln


Review URL: https://chromiumcodereview.appspot.com/12224092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182259 0039d316-1c4b-4281-b951-d872f2087c98

Win8 default browser registration code is extracted into a fairly minimal .rgs script with a helper app that is then invoked by the ash unittests.

A full ICommandExecuteImpl implementation turns out to not be needed as the ash tests activate the registered default browser directly by AppUserModelId which avoids the need for
ICommandExecuteImpl and the other stuff in the production delegate_execute.exe.

BUG=154081
TEST=ash_unittests, eventually.

Review URL: https://chromiumcodereview.appspot.com/12096064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182258 0039d316-1c4b-4281-b951-d872f2087c98

> Disabled help page than shown when USB printer connected.
> 
> Need time to address privacy issues.
> 
> BUG=175941
> TBR=keybuk
> 
> Review URL: https://codereview.chromium.org/12251017

TBR=vitalybuka@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@182257 0039d316-1c4b-4281-b951-d872f2087c98