- 06 Feb, 2020 40 commits
-
-
Kramer Ge authored
SkiatOutputDeviceGL allocates gl_surface_ that contains swapchain images. Creation is abstract thus gpu memory consumption can only be estimated. Bug: 899905 Change-Id: Id2834a4b6cb34a6a4f8827ad0452cf7c93219600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037950Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#739002}
-
Richard Knoll authored
When we setup a WebRTC connection for Sharing messages we might not have the remote DeviceInfo available yet. Instead of always assume that's the case this CL tries to lookup the DeviceInfo first in case we do have it already. This is better as we can then log all metrics in the SharingMessageSender with the correct values. This also fixes a possible null dereference in SharingServiceProxyAndroid and adds logging for when the DeviceInfo was not available. Bug: 1049134 Change-Id: I509010108f2f685987a1b48f757d3ad0f2aefbec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039611Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#739001}
-
Mohamed Amir Yosef authored
This CL removes the previously introduced complexity in PasswordSaveUpdate bubble code. Instead it wires up the newly introduced PasswordSaveUpdateWithAccountStore bubble Bug: 1044038 Change-Id: Ib8503ba9988ee76cd57e0c15d89fb440cb45c460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038776 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#739000}
-
Mohamed Amir Yosef authored
Bug: 1049085 Change-Id: I88df16d795642d7e5e789f0b0ce2599d8bec1140 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041751 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f9b4bfac44f9..235511fbd715 git log f9b4bfac44f9..235511fbd715 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 fdegros@chromium.org Add user cros-disks to group android-everybody 2020-02-06 achuith@chromium.org paygen: Change chromeos check for payload generation. 2020-02-05 saklein@chromium.org flash_ap: sudo_run instead of build sudo commands 2020-02-05 saklein@chromium.org flash_ap: servo refactor in the board configs. 2020-02-05 saklein@chromium.org flash_ap: Begin servo and dut control refactoring 2020-02-05 chrome-bot@chromium.org Update config settings by config-updater. 2020-02-05 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@235511fbd715 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: I4e55e1fc8800075782cdac5f52d79a48d27995e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041577Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738998}
-
Mark Schillaci authored
This CL will enable setting paneTitle for AccessibilityNodeInfo on Android versions Pie/P/10 or higher. We create a new WebContents- Accessibility subclass specifically for Android P and higher. Original Buganizer bug can be found: https://b.corp.google.com/issues/111502315 Bug: 1048694 Change-Id: Icc6aa00210f1aabe513bedf87f9407bef27faac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037840 Commit-Queue: Mark Schillaci <mschillaci@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#738997}
-
Xiaohan Wang authored
This reverts commit 8de1c11b. Reason for revert: This CL is not related to the test failures. Original change's description: > Revert "media: Add a feature for CdmHostVerification" > > This reverts commit 15a1277e. > > Reason for revert: Suspecting cause for CDM test failures > https://ci.chromium.org/p/chromium/builders/ci/Network%20Service%20Linux/396 > > Original change's description: > > media: Add a feature for CdmHostVerification > > > > By default it's enabled. No effect if ENABLE_CDM_HOST_VERIFICATION > > buildflag is false. > > > > To disable this feature for testing, type the following in the command > > line: > > --disable-features=CdmHostVerification > > > > Bug: 658036 > > Test: Manually tested with the feature disabled > > Change-Id: Ia2d077436a1a8445aec29163a88d1bb4539c4811 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036257 > > Reviewed-by: John Rummell <jrummell@chromium.org> > > Commit-Queue: Xiaohan Wang <xhwang@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738795} > > TBR=xhwang@chromium.org,jrummell@chromium.org,hmchen@chromium.org > > Change-Id: I6fadbf600d281e3693001aab5abf9233cfa4c916 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 658036 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040642 > Reviewed-by: Keishi Hattori <keishi@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738842} TBR=xhwang@chromium.org,jrummell@chromium.org,keishi@chromium.org,hmchen@chromium.org Change-Id: I0b77bea43815ebe6131a56645e6473585b5d2db1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 658036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042399Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#738996}
-
Mike Frysinger authored
All callers of this API pass in string inputs as their data. Change the file mode to match as Python 3 enforces this. We make it an argument so callers can change this (which we will need in the future to write binary data). Because the Chrome CQ can't handle atomic sets, we squash in: grit: chrome_scaled_image: use bytes for all png data This code has been mixing bytes & strings when constructing the png test images which Python 3 doesn't allow. Clean it up to use bytes for everything and write out the tempfiles in binary mode. Bug: 983071 Test: `./grit/test_suite_all.py` passes Change-Id: I1c71bf3305b9a49faff79a49ec68e64bbbd6135a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757315 Commit-Queue: Mike Frysinger <vapier@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#738995}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/586d923fba12..d48320747592 Created with: gclient setdep -r src-internal@d48320747592 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5c5adb56cb628d09412a0bbca6cf1c19e20f7f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042111Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738994}
-
Yue Zhang authored
Currently, we check the number of incognito tabs in onIncognitoStateChanged in TabSwitcherModeTTPhone to decide whether we show new tab variation or not. We assumed that there will definitely be an incognito state change when we close all incognito tabs. However, this is not true in a corner case where user closes all incognito tabs from Android notification while staying in normal tab model. This CL covers this corner case by introducing a TabModelObserver to control the show/hide of new tab variation. Bug: 1028497 Change-Id: Ia71d829a9ea5a87e50c5930e60f2165759fbbb06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015833Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#738993}
-
Stepan Khapugin authored
Reorder startup code to have a continuous block of code that contains all per-window startup logic. This allows an easier move of this code to SceneController. Bug: none Change-Id: I6f4aa4b8e69cb3a9a7283ac1bf1f2473e4a209f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039610Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#738992}
-
Xida Chen authored
TBR=weiliangc@chromium.org Bug: None Change-Id: Ibfcf6f2a11cd4e839d4bacbc26b25cccc0d3ebb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041796Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738991}
-
Mohamed Amir Yosef authored
This is a reland of d7682c6e after fixing the failing test. Original change's description: > [Passwords] Introduce SaveUpdateWithAccountStore bubble > > This is a mechnical fork of the existing SaveUpdate bubble without > any change in functionality. > Follow up CLs will introduce extra funcationlaity and change in the UI > elements. > > Bug: 1044038 > Change-Id: I1ab6b08a9097b4f7adc06b53317676b42b3a2bf4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033072 > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738913} TBR=vasilii@chromium.org Bug: 1044038 Change-Id: I94abd07edf903d6c1982dffc3caa64ea8d332333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041661Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#738990}
-
Mohammad Refaat authored
Replace it with 2 methods: 1- restoreSessionToBrowser 2- addObserversToWebStateList Bug: 1049335 Change-Id: I7099e8fdfdc023fdd71bde00cd1384213690dd1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040008Reviewed-by:
-
Monica Basta authored
As part of Friendly settings, we are changing the encryption UI to be an expandable button. The menu is expanded by default in case of encryption with custom passphrase. Screenshots: http://screen/TjYzvt1Mm1Z http://screen/GuBbKarc59a http://screen/8sWerk9f6zQ Bug: 1046410 Change-Id: Ie106c4f50a50538f4514178440df0fcd32127f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025349 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738988}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/48258acabf56..065348503c2e git log 48258acabf56..065348503c2e --date=short --first-parent --format='%ad %ae %s' 2020-02-06 hbos@webrtc.org [Overuse] Move EncodeUsageResource/QualityScalerResource to own files. 2020-02-06 minyue@webrtc.org Add a method to report number of samples in MovingMedianFilter. 2020-02-06 mbonadei@webrtc.org Make rtp_generator buildable from Chromium. Created with: gclient setdep -r src/third_party/webrtc@065348503c2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:942546 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I2a20d82c07e050925949da7c0c13fe9eba3639f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042232Reviewed-by:
-
Javier Ernesto Flores Robles authored
- Add Autofill Credential Provider target behind gn flag. - Add empty main interface. - Add empty Credential Provider View Controller. - Add setup for i18n. Bug: 1044907 Change-Id: Ie6955ca9db897915d5a196c74b0dd507c51bdccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016626Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#738986}
-
Robert Flack authored
This test is flaking on the Linux Leak bot. TBR=sahel@chromium.org Bug: 1049599 Change-Id: I8c29b00080b380355fe56da5267189080c98df71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042083Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#738985}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f6e3eaf05150..cc21d0c1f2ce git log f6e3eaf05150..cc21d0c1f2ce --date=short --first-parent --format='%ad %ae %s' 2020-02-06 egdaniel@google.com Reland "Change refPinnedTextureProxy to return a view instead." Created with: gclient setdep -r src/third_party/skia@cc21d0c1f2ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: I9dd5910bedbee6d81a246d354ef71a36873cc7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042131Reviewed-by:
-
Xida Chen authored
The format in this file is in-consistent, sometimes there is one blank line after a test case, and sometimes it is two. I looked at other test cases and it seems two blank lines is the right format. This CL does the re-format, no beavior change. TBR=sadrul@chromium.org Bug: None Change-Id: I6e6246eb9278ed5bd5acd3d9bdd86d0468cc78f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041798Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#738983}
-
Ionel Popescu authored
This reverts commit ee4b369d. Reason for revert: the change caused an issue on ChromeOS where the autofill suggestions are not being read. Original change's description: > Update the aria role for datalist and its options to match the spec. > > According to https://w3c.github.io/html-aam/#el-datalist the aria role for > datalist should be listbox (currently it is menu). > > For datalist options according to https://w3c.github.io/html-aam/#el-option the aria > role should be option (currently it is menuitem). > > The unit test is also updated to use the new aria roles. > > Bug: 1011133 > Change-Id: Ia3541067e3d8ada622c5c3776f3b1b0ce0a26c54 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838997 > Reviewed-by: Akihiro Ota <akihiroota@chromium.org> > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Evan Stade <estade@chromium.org> > Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#706495} TBR=dtseng@chromium.org,estade@chromium.org,akihiroota@chromium.org,iopopesc@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1037649 Change-Id: Ib12a558f70972a28514c943f020f91a7c562c091 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042230Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Commit-Queue: Ionel Popescu <iopopesc@microsoft.com> Cr-Commit-Position: refs/heads/master@{#738982}
-
Aaron Leventhal authored
Bug: 988502 Change-Id: I45d7183335ca771e75f626c7996cbb0667a4cd44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036543Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
-
Xida Chen authored
There are 3 html files under this dir, thhis CL add one space to clean up the format. No behavior change. TBR=sadrul@chromium.org Bug: None Change-Id: I4854a145ab404dac5689005a9c79372b8af19404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041799Reviewed-by:
-
Gauthier Ambard authored
The test is consistently failing on the first run. TBR=stkhapugin@chromium.org Bug: 1049603 Change-Id: I8794ea5bed6d44b116b97336dc18b04b7dd8364d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042099Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#738979}
-
Daniel Cheng authored
Given that the overhead of dynamic histogram lookup is insignificant in most cases, encourage the use of functions over macros and remove the very specific reference to "ten calls per hour". Bug: 1047547 Change-Id: I334e1d3cca240c4d5bbae0865cfda8403e507c14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040006 Auto-Submit: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#738978}
-
Mikel Astiz authored
TBR=ccameron@chromium.org Bug: 1048149 Change-Id: Ia43d3612f17d99065b5f373f94fe7b5a075b0ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041602Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738977}
-
Rohit Rao authored
Previously the client interface returned a SchemaRegistryService, but that class was originally a KeyedService and is intended to be //chrome-specific. I was planning to move it to //components and reuse it on iOS, but now I think it would be better to leave it as a //chrome-specific implementation and write a separate implementation for iOS. The calling code only used the SchemaRegistryService to access its SchemaRegistry, so PolicyConversionsClient can simply return the SchemaRegistry directly instead. BUG=1027249 Change-Id: I8e8a86c96c15cf509993c180aac219f290a7fba6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042191Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#738976}
-
Anton Bikineev authored
This tests generational barriers issued in HeapAllocator::NotifyNewObject function. Bug: 1029379 Change-Id: I4d6c38a7095d43500c3a2aa7d3d935dbf7e080c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039451 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738975}
-
Thoren Paulson authored
This CL should allow Cast apps to run in the background on Android TV while playing nicely with other apps. This includes: * Disable kRequestSystemAudioFocus on Cast apps so Cast can manage audio focus. * Stop cast apps when audio focus is lost. * Don't tear down/finish CastWebContentsActivity when the user leaves. Bug: internal b/143313649, internal b/142828228 Test: manual Merge-With: eureka-internal/359240 Change-Id: I2ac25f7e0749abfdac2bb2ab98010f7489787f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036519 Auto-Submit: Thoren Paulson <thoren@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Luke Halliwell (slow) <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#738974}
-
Dmitry Gozman authored
This method allows to scroll specific rect into view if needed and ensure that no scrolling animations run. This ability is required for browser automation, for example to test user interaction with specific region of the element. Bug: 1049173 Change-Id: I7163d1cfd6ae17a676c64727ab3151d0300a6ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037847 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#738973}
-
Monica Basta authored
This CL contributes to changing the API to get the primary account from the identity manager to be consent-aware. |GetUnconsentedPrimaryAccountInfo| is replaced with |GetPrimaryAccountInfo(ConsentLevel::kNotRequired)|. TBR=treib@chromium.org,dvadym@chromium.org,hashimoto@chromium.org Bug: 1046746 Change-Id: I65e69e27ffafbcaab950ea7de4a9f69c7c35328b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039510 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#738972}
-
Dominique Fauteux-Chapleau authored
This change was started in crrev.com/c/1814619 but is a no-op on Mac without the changes in this CL. This only changes the drag+drop behavior of users with the appropriate policies enabled and doesn't affect other users. Bug: 1046921 Change-Id: I3603ae28a730472e6f88f0281c72720c4a71be03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037450Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#738971}
-
Mohammad Refaat authored
Now that cookies EG2 utility method is fixed this test can be enabled. Bug: 1038398, 1036133 Change-Id: I9c1b0d39f9dd74b3ed9fc01b2d51e8bcc63a367b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037832 Commit-Queue: Eugene But <eugenebut@chromium.org> Auto-Submit: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#738970}
-
Andrew Grieve authored
* Make --ignore-licenses skip download step * Show id package missing license rather than name * Show URL of failed downloads Bug: None Change-Id: I47415a0f79e3b825f6a4eac60dec5fd12fb7449a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040749Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#738969}
-
Yang Guo authored
We now always show the experiments section in DevTools settings to reduce the friction for users to enable experiments. This flag in the backend is now obsolete. Bug: 1048124 Change-Id: I5966cfae69b34e120bbd532d7e78a26ef912e94f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041432 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#738968}
-
Michael Thiessen authored
This reverts commit a25a688e. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1049536 Original change's description: > Migrate webview Webcontents#getVisibleUrl to GURL > > Bug: 783819 > Change-Id: Ib1970a41bb45a31907ea91358fd27bee6c6b20a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039301 > Reviewed-by: Bo <boliu@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738694} TBR=mthiesse@chromium.org,boliu@chromium.org Change-Id: Ib9a94a412c9ac7625b37dbc6075c61f2d7bcc9fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 783819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042087Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#738967}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b04bd5953150..d4802d647c64 git log b04bd5953150..d4802d647c64 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 aerotwist@chromium.org [e2e] Forces stronger reset on pages Created with: gclient setdep -r src/third_party/devtools-frontend/src@d4802d647c64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I17deeec9967b9e323146d97efe9d8178015f2313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041907Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/928314e9..aeb15b1b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I343975abf2ac6a60d5a97783789b2103d61e6857 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041951Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738965}
-
Maksim Moskvitin authored
InvalidatorRegistarWithMemory didn't update registrations when there are duplicates, but *did* update subscriptions. This behavior is confusing and may lead to the future bugs. This patch makes subscription/registration logic consistent. Bug: 1020117 Change-Id: I6ddf5f84f35517570c8c246c415106e71038859b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041470Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a9e10263044b..48258acabf56 git log a9e10263044b..48258acabf56 --date=short --first-parent --format='%ad %ae %s' 2020-02-06 hbos@webrtc.org [Overuse] Implement Resource and ResourceUsageListener. 2020-02-06 hbos@webrtc.org [Overuse] Add EncodeUsageResource and QualityScalerResource. Created with: gclient setdep -r src/third_party/webrtc@48258acabf56 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1ce0ce9ebb30d64204a24437cccf0dffb7cd2e9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2041908Reviewed-by:
-
