GitLab

Recently-added policy rules in the SSL client socket require that
we enable Certificate Transparency. This CL adds CT support by attaching
the relevant CT objects to the SSL client context.

R=khushalsagar@chromium.org
BUG=623684

Review-Url: https://codereview.chromium.org/2103143003
Cr-Commit-Position: refs/heads/master@{#402603}

Allows Blink to use base::debug::ScopedCrashKey.

BUG=621730

Review-Url: https://codereview.chromium.org/2105763002
Cr-Commit-Position: refs/heads/master@{#402602}

BUG=621397
R=ojan@chromium.org,japhet@chromium.org

Review-Url: https://codereview.chromium.org/2082463002
Cr-Commit-Position: refs/heads/master@{#402601}

This CL removes calls to deprecated methods MessageLoop::PostTask
and MessageLoop::RunUntilIdle in google_apis.

BUG=616447
TBR=rogerta@chromium.org

Review-Url: https://codereview.chromium.org/2083383002
Cr-Commit-Position: refs/heads/master@{#402600}

The existing behavior is to complete when the top loading frame's load event completes.

This adds 2 alternatives:
* When the main frame's DOMContentLoaded completes
* When the main frame's DOMContentLoaded completes, as well
as any images that started before DOMContentLoaded completes

BUG=513459
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/1860743002
Cr-Commit-Position: refs/heads/master@{#402599}

Made it so that import_tests makes all files starting with a shebang executable regardless of file permissions in upstream repo

BUG=574461

Review-Url: https://codereview.chromium.org/2096173002
Cr-Commit-Position: refs/heads/master@{#402598}

BUG=622424

Review-Url: https://codereview.chromium.org/2106873002
Cr-Commit-Position: refs/heads/master@{#402597}

There are two places users can update their cloud services pref:
- First run flow, with a checkbox
- Contextual menu, with a toggle

Currently, users can only update their cloud services pref if they have sync enabled. There is no technical tie-in between having sync active and using cloud services. This change makes it such that users can toggle their cloud services pref locally if sync is inactive. Now, we only check that the user is authenticated. While sync is off, however, the pref will not sync across their devices.

In the event where the user has already acknowledged the first run flow (locally on the profile), then turned on sync, we continue to enable cloud services.

[Reland Comments] This was initially reverted because it caused failures on official bots; there were #includes that were mistakenly removed.

BUG=621255, 623330

Committed: https://crrev.com/19a9b8f1411afe64b2163261a04245f617e25e17
Cr-Commit-Position: refs/heads/master@{#402072}

patch from issue 2078213002 at patchset 160001 (http://crrev.com/2078213002#ps160001)

Review-Url: https://codereview.chromium.org/2093353002
Cr-Commit-Position: refs/heads/master@{#402596}

* Fold LastWindowClosedLogoutReminder into LogoutConfirmationController
* Move LogoutConfirmationController ownership from Shell to WmShell
* Place the logout confirmation dialog in the system modal container, not
in the root (dialogs should not live directly in the root)
* Move LabelTrayView to //ash/common/system/tray since it is not chromeos-
specific

BUG=619636
TEST=ash_unittests, manual testing after forcing the button to show

Review-Url: https://codereview.chromium.org/2108793002
Cr-Commit-Position: refs/heads/master@{#402595}

Shift the position of the material design battery
alert badge at 2x device scale factor; currently
it is too low.

BUG=623417
TEST=manual

Review-Url: https://codereview.chromium.org/2107813002
Cr-Commit-Position: refs/heads/master@{#402594}

https://chromium.googlesource.com/native_client/src/native_client.git/+log/d1ea091dad37..41bda598ad1e

$ git log d1ea091da..41bda598a --date=short --no-merges --format='%ad %ae %s'
2016-06-28 mseaborn Futexes: Fix race between futex timeout and wakeup that can lose wakeups
2016-06-27 thakis nacl/mac: Remove outer_sandbox.c
2016-06-27 tandrii Make bucket names explicit in cq.cfg.

BUG=617627

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2104153002
Cr-Commit-Position: refs/heads/master@{#402593}

The "Duration" was missing in the
Scheduling.Browser.BeginMainFrameStartToCommitDuration
UMA.

BUG=603202
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2108943002
Cr-Commit-Position: refs/heads/master@{#402592}

Revert of [Chromecast] Use perceptually linear scaling for stream volumes (patchset #2 id:20001 of https://codereview.chromium.org/2073223003/ )

Reason for revert:
I think we should actually leave the per-stream volume multiplier as linear, and leave it up to whatever sets that multiplier to map correctly from user input to the desired volume curve. Otherwise, we tie the mixer implementation to a specific volume curve, which is looking less and less plausible (particularly since it is used with OEM devices that have an unknown volume curve).

Original issue's description:
> [Chromecast] Use perceptually linear scaling for stream volumes
>
> SetVolumeMultiplier(0.5) should give audio that sounds half as loud as
> SetVolumeMultiplier(1.0).
>
> BUG=internal b/29253848
> TEST=manual
>
> Committed: https://crrev.com/42e51772feb06a971921e4cfcd89ba7661cdf22a
> Cr-Commit-Position: refs/heads/master@{#401149}

TBR=igorc@chromium.org,alokp@chromium.org,halliwell@chromium.org,jyw@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=internal b/29253848

Review-Url: https://codereview.chromium.org/2100733002
Cr-Commit-Position: refs/heads/master@{#402591}

Device scale factor appeared TWICE inside a CompositorFrame:
  1. CompositorFrameMetadata
  2. DelegatedFrameData

The version in DelegatedFrameData seemed largely dead except for some
Mus code so I've updated Mus code.

BUG=611802
TBR=dpranke@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2101623002
Cr-Commit-Position: refs/heads/master@{#402590}

R=inferno@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2109853002
Cr-Commit-Position: refs/heads/master@{#402589}

GLFrameData sync_token and mailbox are now dead code as is MailboxOutputSurface.

BUG=none
TBR=dcheng@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2102153003
Cr-Commit-Position: refs/heads/master@{#402588}

Modify the size and layout of the items that appear
in the material design tray so that they conform
to the MD specs (notifications button, system tray, etc.)
This CL should only have user-visible changes for
material design, which is currently off by default behind
the --ash-md flag.

This CL also cleans up many constants specified in
tray_constants.h.

BUG=617295
TEST=manual

Review-Url: https://codereview.chromium.org/2099103002
Cr-Commit-Position: refs/heads/master@{#402587}

This adds the necessary plumbing to expose in devtools when public-key pinning is bypassed (due to a local trust anchor), by way of SecurityStyleExplanations. The goal is to allow the security panel to display when pins are bypassed, in order to help developers debug pinning implementations.

BUG=566144

Review-Url: https://codereview.chromium.org/2066483009
Cr-Commit-Position: refs/heads/master@{#402586}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/71bd2e3f..820a23aa

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/2101143003 .

Cr-Commit-Position: refs/heads/master@{#402585}

Instead of use EXPECT_EQ, use EXPECT_TRANSFORMATION_MATRIX_EQ to deal
with float in gfx::Transform.

R=danakj
BUG=620747
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2103963002
Cr-Commit-Position: refs/heads/master@{#402584}

With this CL, TaskSchedulerImpl::Create takes as argument a vector
of worker pool creation arguments and a callback that indicates in
which worker pool a task with given traits should run.

In the Chrome browser process, we plan to have 4 worker pools:
 - Background
 - Background with file i/o
 - Foreground
 - Foreground with file i/o
The number of workers per pool will be derived from system
characteristics and from variation params obtained from
variations::GetVariationParams.

In tests and in renderer processes, we might create a different
set of worker pools (e.g. file i/o doesn't make sense in a
renderer).

BUG=553459

Review-Url: https://codereview.chromium.org/2064073003
Cr-Commit-Position: refs/heads/master@{#402583}

Create an enum class Type in GLImage, which allows for safe downcasting.

BUG=619698
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2106843002
Cr-Commit-Position: refs/heads/master@{#402582}

The mus::GpuService will be used by chrome browser process
and chrome renderer process in mus+ash. The current chrome
browser may establish Gpu channel in both sync and async
modes. The renderer process will only establish gpu channel
synchronously. To satisfy chrome's requirements, we add the
async version EstablishGpuChannel on GpuService.

BUG=586390

Review-Url: https://codereview.chromium.org/2087333002
Cr-Commit-Position: refs/heads/master@{#402581}

Change includes lots of tests.

Screenshots of dialog in bug.

BUG=607347
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2079853002
Cr-Commit-Position: refs/heads/master@{#402580}

This change moves tracking of reloads, forward/back navigations
and new navigations into the core PLMO.

It's not unlikely that other observers may want to track load
metrics broken down by load types, so we annotate load types using
suffixes, rather than PageLoad.Clients.LoadType-style naming, which
would not generalize to other observers.

BUG=607063

Review-Url: https://codereview.chromium.org/2091353002
Cr-Commit-Position: refs/heads/master@{#402579}

Proguard config is already forwarded using a
separate mechanism. Remove this if-block
to get rid of the duplication.

BUG=623672

Review-Url: https://codereview.chromium.org/2101033002
Cr-Commit-Position: refs/heads/master@{#402578}

The Signed Certificate Timestamps (SCTs) are listed in detail in the Security panel of the DevTools.

BUG=591848

TEST=Visit a website whose certificate has Certificate Transparency information like mozilla.org, open the Security panel in DevTools, refresh and click on "https://www.mozilla.org" under "Main Origin". You should see three SCT sections underneath the certificate section.

Review-Url: https://codereview.chromium.org/1772603002
Cr-Commit-Position: refs/heads/master@{#402577}

Revert of Close the panel if show has been requested (patchset #1 id:1 of https://codereview.chromium.org/2097623003/ )

Reason for revert:
This patch does not entirely fix the issue since a panel can be opened by the panel manager without being requested.

Original issue's description:
> Close the panel if show has been requested
>
> When a panel is requested to show, it may not be visible yet and
> isShowing will return false. If two panels try to show simultaneously
> this can cause the incorrect panel to appear. This change keeps track
> of whether peek has been called so there can be a corresponding close
> call, regardless of panel visibility.
>
> BUG=623017
>
> Committed: https://crrev.com/967e335bb9ad405a0e13d7827d3cc1875d819914
> Cr-Commit-Position: refs/heads/master@{#402218}

TBR=twellington@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=623017

Review-Url: https://codereview.chromium.org/2108863003
Cr-Commit-Position: refs/heads/master@{#402576}

This enables Web Bluetooth through experimental frameworks in supported platforms.
Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/coyvHj1u2Z8

TEST=Manual testing required:
Launch chrome and perform the following tests:

On Chrome OS, Android and macOS devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

On Linux and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth blocked".

1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Not Present"
4. "Use Web Bluetooth"      should be "Bluetooth Unavailable".

Launch Chrome with the following command line flags:
--enable-web-bluetooth

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

On Chrome OS, Android, Linux, OSX, and Windows devices:
1. Visit: https://g-ortuno.github.io/web-bluetooth-sandbox/not-allowed.html
2. Press the "Run Test" button.
3. "Web Bluetooth bindings" should be "Present"
4. "Use Web Bluetooth"      should be "Bluetooth Works".

BUG=584113
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2080553002
Cr-Commit-Position: refs/heads/master@{#402575}

Dock swallows SIGHUP as of macOS 10.12. SIGTERM still works.

BUG=620385

Review-Url: https://codereview.chromium.org/2108703002
Cr-Commit-Position: refs/heads/master@{#402574}

with GN the paths passed to create_installer_archive.py are
relative to the build directory (e.g. out/Release), so the
path to syzygy/chrome.7z doesn't contain any '..' anymore
and 7za use the entire relative path as part of the file
paths in the archive (i.e. the tree in syzygy/chrome.packed.7z
is 'syzygy/chrome.7z' instead of just 'chrome.7z').

Also address some comments from Brett in https://codereview.chromium.org/2085813004/ (which has been landed by Dirk as https://codereview.chromium.org/2091023007)

BUG=525752

Review-Url: https://codereview.chromium.org/2106563002
Cr-Commit-Position: refs/heads/master@{#402573}

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2106643002
Cr-Commit-Position: refs/heads/master@{#402572}

BUG=623934

Review-Url: https://codereview.chromium.org/2103213002
Cr-Commit-Position: refs/heads/master@{#402571}

Supervised users can install apps and extension.  The extension will be
installed in a disabled state and an approval request will be sent to
their custodian.

If the custodian approves the request, the extension will be enabled.
If the custodian denies the request, the extension will be uninstalled.

BUG=619526

Review-Url: https://codereview.chromium.org/2004043002
Cr-Commit-Position: refs/heads/master@{#402570}

Add test to ensure serialization/deserialization produces unchanged
InputDevice and TouchScreenDevice objects.

BUG=601981

Review-Url: https://codereview.chromium.org/2100893002
Cr-Commit-Position: refs/heads/master@{#402569}

When run in-process, the GpuSwitchingManager is already notified in GpuDataManagerImplPrivate::HandleGpuSwitch. The call from GpuChildThread causes GpuSwitchingManager to notify its obervers on the GPU thread, while they're expecting it to be UI thread. As a result, a dozen or two of content_browsertests are failing for me in each run (mac debug build).

BUG=

Review-Url: https://codereview.chromium.org/2109643002
Cr-Commit-Position: refs/heads/master@{#402568}

gfx::Point -> gfx::PointF to fix rounding errors.

BUG=623776

Review-Url: https://codereview.chromium.org/2094343005
Cr-Commit-Position: refs/heads/master@{#402567}

BUG=

Review-Url: https://codereview.chromium.org/2103693004
Cr-Commit-Position: refs/heads/master@{#402566}

This CL does the following:
1. Makes V4Database the source of truth about the number and status of the lists being updated.
2. Fetch updates for 2 different lists: Malware and Social Engineering. Previously we were just downloading Malware.
3. Update requests are now incremental. Each V4Store updates its "state" when processing an update response so the next update request is incremental on top of that state.
4. Tests to verify that the V4Database and V4Store are being updated correctly.
5. Force enable V4 updates for debug builds (bringing it back).

Overall design document: https://goto.google.com/design-doc-v4store

After this CL:
1. V4LocalDatabaseManager tells V4Database about which lists to fetch (and their filename) at init time.
2. From here on, V4Database becomes the single source of truth for all information about the lists.
3. V4Database creates a V4Store for each of the lists.
4. When the V4Database is ready (this happens on the task runner), the update manager schedules the next update.
5. When the update is received, V4Database determines which stores to update and updates them on the task runner.
6. Updating a V4Store is done by creating a new store that's equivalent to the old store + the update.
7. When the new store is ready, the V4Database swaps it in for the old store.
8. When all the stores that needed to be updated have been updated,  the update manager schedules the next update.

BUG=543161

Review-Url: https://codereview.chromium.org/2062013002
Cr-Commit-Position: refs/heads/master@{#402565}

updates than we expected (by mapping to both  activity.onstart
and activity.onresume). And we only care the state changes
from RUNNING->STOPPED->RUNNING (activity.onStart following
activty.stop) to release/resume camera devices accordingly.
So it's better to do the filtering earlier in
app_status_listener_ callback than making a
decision later by checking capturing status.

BUG=615557
TEST=AutoTest

Review-Url: https://codereview.chromium.org/2086603002
Cr-Commit-Position: refs/heads/master@{#402564}