- 05 Sep, 2019 40 commits
-
-
Sasha McIntosh authored
Current cache usage histogram is dominated by samples in the 0-1 range, making percentile comparison difficult. This change prevents 0% samples from recording to the metric Renderer4.GpuImageDecodeState.CachePeakUsagePercent. Bug: 963619 Change-Id: I8a334d260ee5aeedd2cb6f9db2e8c1cf2f2bdb70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783303 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Auto-Submit: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#693776}
-
Clark DuVall authored
With this change, WebLayerShell now only depends on the weblayer/public dir, and has no other dependencies on chrome code. A new APK WebLayerSupport has all the implementation and must be installed alongside WebLayerShell for it to work. Change-Id: Iab3b346831c8d8737a0b3ca509455b7499b31ac9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779428Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#693775}
-
Brandon Goddard authored
This change enhances the accessibility of the Network tool Timing tab by making the following changes: - Add hidden global headers to give column context to screen readers - Slight modification of color contrast for section headers (> 4.5) - Updated "TIME" to "DURATION" to avoid confusion - Applied ARIA heading for soft headers - Restructured columns to remove empty table cells from being read by a screen reader - Added ARIA labels to waterfall column that read the start time of the request. (Column 3 indicates the duration of that part of the request timing). Bug: 963183 Before: https://imgur.com/qKzqyYv After (with screen reader): https://imgur.com/Sk6vuT6 Change-Id: Ife782e02929f2a1624fd0b827b4e1f729babd209 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1647132Reviewed-by:
Erik Luo <luoe@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693774}
-
Julie Jeongeun Kim authored
This CL converts NetworkContextRequest to new Mojo types. It also updates GetNetworkContext from resource_provider.mojom and CreateNetworkContext and network_service.mojom and methods and members which implement them. Bug: 955171, 978694 Change-Id: I053a8957685e4eed9d44615a5e74b451dc75fe49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782203Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#693773}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5339a20. With Chromium commits locally applied on WPT: e7387117 "[sms] Allow SMS Receiver for same origin iframes" 36b875c4 "[WPT/mixed-content] Regenerate test files warning: inexact rename detection was skipped due to too many files. warning: you may want to set your diff.renameLimit variable to at least 648 and retry the command." bb9c94d9 "Simplify fetch-event-within-sw.https.html using async/await" 668359aa "[Trusted Types] Rework default policy error handling." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I66564945d37cec158a1d26a76b3b32e70443f306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787957Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#693772}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /extensions. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=lazyboy@chromium.org Bug: 891670 Change-Id: I47605ff3866dc5c77c5e58944d27849ee2469534 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786949 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#693771}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /device/vr. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=alcooper@chromium.org Bug: 891670 Change-Id: Ib2a8e5bdbfa859777406af079f62760ce69b9b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786686 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#693770}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /chrome/browser/supervised_user. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=agawronska@chromium.org Bug: 891670 Change-Id: I808784b2f4c625f6a0284ce721aa2f0f7a071120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786826 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693769}
-
Stephen Chenney authored
Deferred commits (aka Paint Holding) is only allowed on same origin navigations using the http family of protocols. Test that we correctly compute the flag. Also clean up comments in cc tests. Bug: 805798 Change-Id: Ic6f4b1c5125188260eb43c7f01df5be14cbd3e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785921Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#693768}
-
Marina Ciocea authored
Per UX request[1], set the tab list to a fixed height equal to the equivalent of 10 tabs. [1] https://docs.google.com/presentation/d/1lSy73_cgj01sdhsV0HZAFL-hht99Iv-4QJyLWF1K_D8/edit?disco=AAAADnnSWPk Bug: 998485 Change-Id: Iafd40caa506ee7dbcad8f1302a23131fd415dcfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787382Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#693767}
-
Richard Knoll authored
This happens if OnThemeChanged is called on an error dialog and there are devices or apps to select from. Bug: 1001112 Change-Id: I0ce6873fa62dc2c3344412f9af6d1d3197d0da97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787546Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693766}
-
Vladimir Levin authored
This complicates the code a little bit. I don't think this is strictly necessary, since the savings it would provide for the single frame are defeated by the fact that we need to paint that frame, so we process the lifecycle anyway. When intersection observer runs, we'll still update the throttling status. I've re-opened the referenced bug with hopes of coming up with (and documenting) a good solution that would save us as much lifecycle processing time as possible. R=chrishtr@chromium.org, szager@chromium.org, erikchen@chromium.org Bug: 976391 Change-Id: I209ce44e4a17042c937de31d538e85548b583ac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783876Reviewed-by:
Stefan Zager <szager@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693765}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 891670 Change-Id: Iecc1db230e4c701499857b1376a721c845d13cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785598 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#693764}
-
Javier Ernesto Flores Robles authored
Bug: 999957 Change-Id: I04645a21455d0ed7aeb6dc014f68b234a09a3793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787500 Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693763}
-
Jan Krcal authored
This CL removes tests that become obsolete by http://crrev.com/660350. The only purpose of these tests was to test how a metric gets recorded. This metric was removed by the the CL above. Bug: 1000617, 1000455 Change-Id: I6c370e3fec9805942df379d8b752b5781533b391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786448 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#693762}
-
Yusuf Sengul authored
Bug: 1001031 Change-Id: Ia8c41cc878a3957686bb897af5c68c96280fe456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786832Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#693761}
-
Ian Clelland authored
Bug: 856601 Change-Id: I91a13f97a5c038e1a570f83ace203f9a52cc2a62 TBR: robertma@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786933Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#693760}
-
Alison Maher authored
This change adds a paint phase for backplates in forced colors mode. The backplate paint phase goes before the float and foreground paint phases and after the background paint phase. The new paint phase has been added for both the backplate implementation for LayoutNG and non-LayoutNG. Bug: 970285 Change-Id: I51badafa9564b6e477ab794fed9b8e2caee4b441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757271Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#693759}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/preferences. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=jonross@chromium.org Bug: 891670 Change-Id: I2267eede47df2efb13f39d8be4500a24f82d2de5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787112 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#693758}
-
Nick Diego Yamane authored
UpdateX11EventForChangedButtonFlags function is not used anywhere and UpdateX11EventForFlags is used in one unittest but with no effect (native_event() returns null) so remove both. Bug: 965991 Change-Id: Ida9b30be22a13cc8cdb2cac424b1968754aa3021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785182Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#693757}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /ui/events/blink. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=bokan@chromium.org Bug: 891670 Change-Id: I626ba137031b1d510206f119075f23024408141a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786940 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#693756}
-
Finnur Thorarinsson authored
Bug: 988275, 860467 Change-Id: I9b4d02e5dd8eb449ba7b0c98e36964fcd8eb31bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781429Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#693755}
-
Lowell Manners authored
NavigationControllerBrowserTest.HistoryBackTwiceFromRendererWithUserGesture SitePerProcessBrowserTest.TwoCrossSitePendingNavigationsAndMainFrameWins It looks like these were fixed. Probably either by javascript freezing or not caching pages that are currently loading. Bug: 999848 Change-Id: I69eb7ffb19651e796d9f94dee96f797036bffb6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787380Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#693754}
-
Rakina Zata Amni authored
Because the rendersubtree attribute is also cloned. Bug: 998030 Change-Id: I7bdf0c94578203feaf418d05dd150b4b6ad5c71a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787619Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693753}
-
Rakina Zata Amni authored
After the move from presentational hints to direct style adjustment, rendersubtree containment addition & locking works with SVG elements. Bug: 998030 Change-Id: Ibf10f2614b1562fd58b67fafbf25051b8608d75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787481Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#693752}
-
Friedrich Horschig authored
This CL fixes the spacing below title texts (which were mistakenly treated as UserInfo instances since both stem from LinearLayouts). Additionally it sets the correct color to the slash used as divider in credit card sheets. Bug: None Change-Id: I03a3bd11a991d848960f3301a0f315cdb362f910 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787542Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#693751}
-
Jimmy Gong authored
- The fix is for the SavedPrinters test suite to wait for getCupsPrintersList to be called before querying for the SavedPrintersElement. GetCupsPrintersList is responsible for querying and populating saved printers. Original commit message below: - The header for saved printers will be hidden when the saved printers list is empty. - Adds a browsertest to reflect this change. Bug: 993819, 999072 Test: browser tests, end to end manual Change-Id: I22d8c383812595c5a83587d4fc1d06f91df87b13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775203 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#693750}
-
Aga Wronska authored
Update submit button color in parent access view. Bug: 999389 Change-Id: I0db11ec38ec29ab418e12bc126ccf7be3fa8e696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785999Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#693749}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /components/web_resource. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I289ecffa9181d7090d1e052f942529a0d672b727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786841 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693748}
-
Owen Min authored
Add Greg and remove Georges. Change-Id: Ia1d75e45a5083d32ea7198394c34f274dc765a9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787864Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#693747}
-
Eric Orth authored
Changed DNS configuration (especially changes to use of the soon-to-be-enabled DNS-over-HTTPS) can have significant effect on redirect detection. Bug: 971411 Change-Id: Ia0ab92a18495d305a3f16dae1b5ee73357aa45da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781775 Auto-Submit: Eric Orth <ericorth@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#693746}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /services/data_decoder. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I661e8c04cf53a354ead7ff808eb2636f8a2248ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786970 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693745}
-
Geoff Lang authored
These failures only appear on Win/AMD/Vulkan and are not reproducable locally yet. BUG=angleproject:2898 TBR=kbr@chromium.org NOTRY=true Change-Id: Ic5024c0de700470ae55e6e17d051322dbc968f17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787586Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#693744}
-
Alex Clarke authored
We want to prioritize loading and compositing task until first contentful paint. This causes snav-search-outside-of-focused-scroller.html to flake because the test can sometimes run before all the resources have have loaded. Adding an onload handler fixes this. Bug: 971191 Change-Id: I1b0565a2e07177b19549852f35ba7114b12d38d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787280Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#693743}
-
Emily Stark authored
This adds a histogram that records whenever a user interacts with a Safety Tip (dismisses it or leaves the site). The histogram records the user interaction as well as the type of Safety Tip showing. Bug: 987754 Change-Id: If1a99506a6d92ac37b4025297552c38fdeb6652b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783710Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#693742}
-
Yusuf Sengul authored
Bug: 1001036 Change-Id: I44338b1fae6cdb85631b8178d3cfd2a5eb465193 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787737Reviewed-by:
Tien Mai <tienmai@chromium.org> Commit-Queue: Yusuf Sengul <yusufsn@google.com> Cr-Commit-Position: refs/heads/master@{#693741}
-
Gabriel Charette authored
These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/gpu. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=backer@chromium.org Bug: 891670 Change-Id: I219837178a228d5a0ce2fd45145666ff17ad118c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786802 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#693740}
-
Jesse Schettler authored
When print preview is closed, notify the PrintSessionImpl so it can close the ARC Custom Tab used for printing. Bug: b:139551164 Test: Close print preview in ARC Custom Tab and verify the tab is closed Change-Id: I5ed70a26eef781b9e8224bfa88617d93d7709a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782010 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#693739}
-
Jinfeng Ma authored
Custom scroll corners and resizers are LayoutScrollbarPart objects, they will set scrollable container box as parent by calling SetDangerousOneWayParent. By now, this one way parent is just used for getting the writing mode style. Bug: 999062 Change-Id: I7a31fe23e6558e70fb3de83519a473633c4303fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778899Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#693738}
-
Gabriel Charette authored
Backport some tests in /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm to SingleThreadTaskEnvironment These tests were previously migrated from single-threaded MessageLoop to a multi-threaded TaskEnvironment (then named ScopedTaskEnvironment) as part of crbug.com/891670. //base OWNERS decided in retrospect that it was better to keep a single-threaded option for TaskEnvironment and introduced SingleThreadTaskEnvironment. This CL retrofits that decision for /content/browser/renderer_host/render_widget_host_view_mac_editcommand_helper_unittest.mm. This CL is a no-op if it passes CQ. This CL was uploaded by git cl split. R=rsesek@chromium.org Bug: 891670 Change-Id: I21d55afc3729de3571d2c15215992656753cae7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786747 Auto-Submit: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#693737}
-