GitLab

BUG=936080

Change-Id: Ic1b64913d0594841e7edb521aa0502235e1171fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498615
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637872}

This patch changes all VisiblePositionInFlatTree-typed local variables
into PositionInFlatTreeWithAffinity as a preparation to remove
unnecessary canonicalizations from SelectionController.

Bug: 657237
Change-Id: Ic5603a8fd090d3337c1eb58487e1a6ad1809ae6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501035Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637871}

Flake (https://analysis.chromium.org/p/chromium/flake-portal/flakes)
found the 4 web tests as flaky and may fail in all types (fail,
timeout, crash). Hence, this patch marks them so.

Bug: 894651
Tbr: xiaochengh@chromium.org
NoTry: True
Change-Id: I8dca99fef9c6babd173631259febe3b7af48c688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503942Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637870}

Changes EULA screen to report exit status using a callback rather than
invoking BaseScreen::Finish (which calls BaseScreenDelegate).

Encodes whether metrics reporting was enabled into the ACCEPTED exit
code, and moves logic to track the last selected usage stats reporting
checkbox from WizardController to global variable in eula_screen.
This eliminates a need for EulaScreen::Delegate (which WizardScreen was
implementing).

Affected screens:
  SCREEN_OOBE_EULA

Affected exit codes:
  EULA_ACCEPTED
  EULA_BACK

BUG=930267

Change-Id: I6a706c8033ad46e876ee06470868ef1630ae8b55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1498507Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637869}

Change-Id: I9db43e0082628297ac8320c6eb34a763c8bb0996
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497302
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637868}

In BlinkGenPropertyTree (non-CompositeAfterPaint) mode, existence of
composited layers is determined by compositing-update-before-paint,
so PaintArtifactCompositor should not skip any layer.

The bug case is that we skipped a layer containing an animation,
causing CompositorAnimations to fall back to main thread animation
after fail to find the composited animation by the element id.

Bug: 931688
Change-Id: I121c935d2b417058047ccd8967761e28452e5a12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497761Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637867}

When requesting to delete handlers on the main thread, we exit early
if |rendering_orphan_handlers_| is empty. However,
|DeleteHandlersOnMainThread| will also process
|finished_tail_processing_handlers_|, so we're not processing them in
some cases.

Thus, do an early exit only if both |rendering_orphan_handlers_| and
|finished_tail_processing_handlers_| are empty.  Otherwise, there are
things that need to be deleted but aren't.

Change-Id: If4515a42253dc87aca25c009fccea69b243a06ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503998
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637866}

Bug: 936957
Change-Id: Id6ab4c33c299aeecf03894124f1d15c2d95d7d4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504257Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637865}

Currently in site details page, the focus will be lost after closing the
confirming dialog for clear data and reset settings. This CL fixes this
issue.

BUG=924943,835712

Change-Id: Ia83234f49a25fca0672f3fbe503e620d1002eead
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496402Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Maggie Cai <mxcai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637864}

It broke again after https://chromium-review.googlesource.com/c/chromium/tools/build/+/1501474

This should make it immune to future relands + reverts of the same change.

Bug: 926987, 938211
Change-Id: I99654cc71b1c8a83fdd29defc20b1e35cddb3fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504039Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637863}

Also, migrate the BrowserSwitcherEnabled policy in the other direction,
as "browser_switcher_enabled".

This CL refactors ChromeExtensionPolicyMigrator to make it easier to
transform values (e.g. convert types) as they are being migrated.

Bug: 909880
Change-Id: I0d49bd9296a096da713a2d6cface9eab724b29d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500203
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637862}

This resets the backoff state in order to re-run the experiment in India

Bug: 936028
Change-Id: Id55c80ce6ff3d4b4c824a4c1833a5f5d3c03d202
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504129Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637861}

Change the title from "Update expiration date" to "Enter expiration date"

Demo: https://screenshot.googleplex.com/N5Lzem5GFFV

Bug: 926316
Change-Id: I4ded120187dd31478e19e35f56807e0a97fb2f4e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504215Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Jared Saul <jsaul@google.com>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Auto-Submit: Siddharth Shah <siashah@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637860}

Replace usage to instead use JSONReader::Read that returns a
base::Optional<base::Value>.

Also convert IOSPaymentInstrumentLauncher (and its unit tests)
to use the new base::Value API instead of the deprecated one.

Bug: 925165, 646113
Change-Id: I74ddfbb9a0752967ead0b73ebe2ce3f06a96d225
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503373
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637859}

This is consistently failing. I will try finding a proper owners to
diagnose why it is failing but in the meantime disabling to get the
bots green.

Test: none
Bug: 938575
Change-Id: Ib3867bb01c67776ccd5b6aa0db082d485157c759
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504252Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637858}

Moving:
SetLayout/SetMargins/SetPagesPerSheet/SetColor =>
*_settings_test:'select option'

Moving:
DisableMarginsByPagesPerSheet =>
margins_settings_test: 'disabled by pages per sheet'

Adding some 'set setting' tests (all are almost identical) validating
that setting the setting updates the UI.

Also fixing some small issues found due to new individual section tests
running on debug builds:
- Missing includes
- Margins settings -> use an (already existing) enum, not hardcoded
values.

Change-Id: Ia29beafdfcb66634a33279c2c98fe08f9cea9084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501793Reviewed-by: Esmael El-Moslimany <aee@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637857}

web_tests/animations/animationworklet/scroll-timeline-overflow-hidden.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden.https.html

web_tests/animations/animationworklet/scroll-timeline-overflow-hidden-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-and-overflow-hidden-ref.html

web_tests/animations/animationworklet/scroll-timeline-root-scroller.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller.https.html

web_tests/animations/animationworklet/scroll-timeline-root-scroller-expected.html -> web_tests/external/wpt/animation-worklet/worklet-animation-with-scroll-timeline-root-scroller-ref.html

Bug: 915352
Change-Id: Ia48d26bb3a61e773d6e85a637f53790b568343ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490216Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#637856}

This change ensures that currency conversion answers are shortened to
offer just final result, eg. instead of:

   1,000 United State Dollar = 1,330.75 Canadian Dollar
   1000 usd to cad

this will show:

   1,330.75 Canadian Dollar
   1000 usd to cad

Bug: 936730
Change-Id: I1222c5fba17e6cca07947e37bc2494f89abec98e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500915Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Ender <ender@google.com>
Cr-Commit-Position: refs/heads/master@{#637855}

This patch added metrics for ContentCapture in renderer and
have the test for ContentCaptureTask related metrics.

Bug: 924681

Change-Id: I00913a46b53a7c5bc76b0fbd80b3cf2e51d9bd7e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1490762Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637854}

Bug: chromedriver:427
Change-Id: Ic17855832f7d865c42fb51f5d240de8e965d88ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497197Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Tatiana Buldina <buldina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637853}

The constructor name was not being passed correctly into the JSON,
which was causing static methods to be incorrectly parsed as
unique top level functions.

Bug: 913363
Change-Id: If0a94184cceef0c16b8755fe375aad3e2e48de0d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501495Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637852}

Bug: 929490, 853326
Change-Id: Ie2149b7a753d95c02067fcd1ff13c6c03426953a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501574Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637851}

If the tab pane itself is selected, as opposed to one of the buttons
we should move focus to the newly selected tab.

Bug: 854505
Change-Id: I6f1b440d65500ccb8dd4d3c8ceab749b6fa39131
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501949Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637850}

Previously we were bailing out of searches if the previous search
returned no results. But things might have changed since the last
search. So always perform a search if the user presses enter.

Bug: 859881
Change-Id: Ibd6a576c69a2e508583c377d7a4d064bbefa403e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500629Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637849}

This is not being used in actual production. This CL
- Removes the observer
- Marks the corresponding histograms as obsolete.
None of these are being recorded as per
 http://shortn/_87vkPT3VpS
- Removes some of the browsertests

Change-Id: I4c79538854076dfa2b990578ce1a3898a87365d0
Bug: 778222
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1496657Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637848}

The mojo API is a no-op other than on Android with |enabled| being
false. This patch refactors it and renames it into
|DisconnectSessionBridge| to make the behavior more explicit.

Bug: 814225
Change-Id: I786411375edd594806fb2f7bcdc7b884be4352fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500016
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637847}

Currently, the FrameTreeNode destructor ensures that its
navigation_request_ is cleared, but does not ensure that navigation
has been cancelled for any of the other criteria it uses to determine
that it is loading. Ensure that the current and speculative
RenderFrameHostImpls are reset as well.

Many tests tear down a WebContentsImpl without ensuring that it is
done loading, and that is benign. However, it is possible to get a
situation where a subframe FrameTreeNode is detached while still
loading. If it is the last frame loading, this will cause the
FrameTree to transition from loading to not loading without an
associated DidStopLoading() callback.
WebContentsObserverSanityChecker DCHECKs on the rare case where
that happens.

Bug: 916413, 795479
Change-Id: I5abed2648dba2eb99db66a222b4fb5a22d594612
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1455110
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Auto-Submit: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637846}

Bug: 938540
Change-Id: Ic4441c4bf5fbc2ca82b4a0393e96514ea4e99d20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504051Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637845}

Change-Id: I3a09a2b8d2fabacbb625e7029e97121a83a03250
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504217
Commit-Queue: Jarryd Goodman <jarrydg@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637844}

The perf trigger script requires that all shards are dispatched simultaneously.
The go implementation of 'swarming.py trigger' requires one invocation for each
shard. This CL adds a field to the perf trigger script dictionary so that the
recipe engine can correctly handle the different dispatch requirements.

Bug: 926987
Change-Id: I52b739afc707dd77acd012ca483f5ce27dd7bbb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501950Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637843}

Metric that logs when a strike is expired (per-project) and
metrics to track how many LocalCardMigration strikes there are
when migration was accepted.

Bug: 884817
Change-Id: Ia904c08b708b4da716670a39fceab2a4e54bbca3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497433Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#637842}

This modifies 3 parts of WebContentsViewMac and its friends.

1: Initiation of a drag from web contents
This action follows the following path
  * WebContentsViewMac::StartDragging is called, which calls
  * -[WebContentsViewCocoa startDragWithDropData...], which
  * Creates a WebDragSource (to store state for the drag) and calls
  * -[WebDragSource startDrag], which calls
  * -[NSWindow dragImage...]
This doesn't work across processes because the WebContentsViewMac
now exists in the browser process and the WebContentsViewCocoa
exists in the app shim process. Fix this by adding the mojo method
WebContentsNSViewBridge::StartDrag, which is called by
WebContentsViewMac::StartDragging in the browser process, and makes
the -[WebContentsViewCocoa startDragWithDropData...] when it is
received in the app shim process.

2: Completion of a drag via -[NSDraggingSource draggedImage...]
This method takes the following path
  * -[WebContentsViewCocoa(NSDraggingSource) draggedImage...] is
    called by the system, which then calls
  * -[WebDragSource endDragAt:], which then calls
  * WebContentsImpl::SystemDragEnded and
    WebContentsImpl::DragSourceEndedAt
This doesn't work across processes because the WebContentsViewCocoa
is in the app shim process while the WebContentsImpl is in the browser
process. Fix this by adding the mojo method
WebContentsNSViewClient::EndDrag, which is called by WebDragSource
in the app shim process, and makes the WebContentsImpl calls when
it is received in the browser process.

3: -[NSDraggingInfo namesOfPromisedFilesDroppedAtDestination] is called
This method takes the following path
  * -[WebContentsViewCocoa(NSDraggingInfo) namesOfPromised...] calls
  * -[WebDragSource dragPromisedFileTo...], which creates a
  * DragDownloadFile, which uses the WebContentsImpl
Same as the above, the WebContentsViewCocoa cannot access the
WebContentsImpl, so we add a mojo method to bridge between the two.

Move tracking of state for the drag (e.g, the source RenderWidgetHost)
from WebDragSource to WebContentsViewMac.

This eliminates the last need for accessing the WebContentsViewMac
in WebContentsViewCocoa and WebDragSource, to remove the related
member variables.

Because the use of base::ThreadRestrictions::ScopedAllowIO is moved
by this patch, update it to be ScopedAllowBlocking and add
WebContentsViewMac as a friend of ScopedAllowBlocking.

Bug: 898608
Change-Id: I4e7f069e96902b7f0ef26e8579444be96b765a20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1497543Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637841}

Bug: 915568
Change-Id: I1c35ab46ee53526efdfa356ffbe693935570990b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1501776Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Simon Que <sque@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637840}

This is failing on Win7 Tests (dbg)(1):
https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29?limit=200

Failures are causing python errors because the "failures" element must be a list.
The actual cause of the failure is not yet known.

Bug: 938020
Change-Id: I53742dbf49f97a8828af5675a0360e431ed376c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503614Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637839}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fc019f471fc2..6ce450029683


git log fc019f471fc2..6ce450029683 --date=short --no-merges --format='%ad %ae %s'
2019-03-05 cjmcdonald@chromium.org Added more configurations to VSCode Import Sorting
2019-03-05 evanhernandez@chromium.org branch_archive_stages: Support artifacts.json
2019-03-05 saklein@chromium.org cros_sdk_lib: Remove the memoized chroot updater.
2019-03-05 dgarrett@google.com cbuildbot_view_config: Add --builder.
2019-03-05 allenwebb@google.com usergroup_baseline: Remove /var/empty from nobody's homedir.


Created with:
  gclient setdep -r src/third_party/chromite@6ce450029683

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@chromium.org

Change-Id: I859e4db1722a48b283a9a941d4727b1a4ed3e812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1503797Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637838}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/59db7d4f1098..b56862dc292a


Created with:
  gclient setdep -r src-internal@b56862dc292a

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome

BUG=chromium:790399
TBR=shend@chromium.org,zmin@chromium.org,dvadym@chromium.org,petewil@chromium.org

Change-Id: I2d6955ff7430c9e886b73ce960ba7b4b1a1d64c5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504174Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#637837}

The test runner assumed resource filenames were unique, which recently
changed.

TBR=wnwen  # Expediting small change to fix bots

Bug: 935576, 938607
Change-Id: I3fb0105388c6d71427518a9f7b8831ed34388a05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504228Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637836}

Currently fcm channel and subscription to topics use same enum in order to track their
state. This Cl introduces separate enum for the Fcm channel state tracking.

Bug: 801985, 878446

Change-Id: I4a462414852d9bc77c45da125c2a0598afffa8e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502912
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637835}

This aims to restructure the tests so the functional diff from the fixes is
small enough to be reviewable.  There are minor functional changes in this patch
which aren't intended to meaningfully affect the tests.

Primarily, this involves refactoring so tests which do common functionality use
a common base class (so we can fix just one place); sequential steps are broken
into better-named pieces; and those pieces are named in ways that will
correspond to how they will be organized later (e.g. with widget observers
instead of direct calls eventually driving things).  Hopefully this CL is still
clearer on its own than the previous code, but in some cases the exact
organization of code may look a bit unmotivated.

Bug: none
Change-Id: I43560992eb83dff6c7d19c161dcb4ff8b6c52d21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1479421Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637834}

Replace connection_id_length in QuicPacketHeader with connection_id_included

Historically, QuicPacketHeader has included two fields:
destination_connection_id_length and source_connection_id_length,
because in older versions of gQUIC (that have since been deleted) there
was a way to compress the connection ID by only sending a variable
amount of bits. In all currently supported versions of QUIC, there are
only two options in a given header: connection ID present and connection
ID absent. Therefore this CL replaces these length fields with
corresponding destination_connection_id_included and
source_connection_id_included. This will allow us to support connection
ID lengths that are not 8 in the future.

Merge internal change: 236736901

https://chromium-review.googlesource.com/c/1504055/

Stop using AckBundling mode to send ack and replace ack_queued with scheduling ack_alarm to now.

No functional change expected, protected by
quic_reloadable_flag_quic_deprecate_ack_bundling_mode.

With this change, ACKs will be sent in 3 cases:
1) Anytime there is data to send, bundle an ACK if ack_alarm is set.
2) If there is no data to send or packets get received after frames get
queued, send an ACK only if ack_alarm expires now.
3) Send an ACK when ack_alarm goes off.

Merge internal change: 236725546

https://chromium-review.googlesource.com/c/1504126/

Deprecate quic_keep_ack_decimation_reordering.

Merge internal change: 236719336

https://chromium-review.googlesource.com/c/1504004/

Deprecate --quic_restart_flag_quic_check_blocked_writer_for_blockage

Merge internal change: 236709014

https://chromium-review.googlesource.com/c/1504125/

Add tests for version negotiation to QuartcEndpointTest.

Allows QuicVersionMangers to be injected into both client and server
implementations of QuartcEndpoint, in order to control version support in tests.
Adds two tests to QuartcEndpointTest for behaviors surrounding version
negotiation:
- One test actually performs version negotiation:  the client picks a version
that the server doesn't recognize and the server negotiates for an older one.
- One test confirms that the server can accept connections on any supported
version:  the client picks an older version and starts that.

Moves all the fakes from quartc_session_test into a shareable test-only library.

Merge internal change: 236677680

https://chromium-review.googlesource.com/c/1504124/

In QUIC, fix connection close's encryption level.

Protected by quic_reloadable_flag_quic_fix_termination_packets.

Merge internal change: 236663907

https://chromium-review.googlesource.com/c/1504123/

Fix Quartc 0rtt test in chromium.

More importantly, this fixes a lifetime issue that occurred in the
simulator. Simulator assumes that once an actor is added, it is alive
for the entire simulation. Destroying an actor (in this case the client
endpoint) may cause runtime failures. (in this case, new object was
allocated at the same address, which caused a DCHECK in simulator).

Merge internal change: 236660882

https://chromium-review.googlesource.com/c/1504120/

Deprecate quic_reloadable_flag_quic_encryption_driven_header_type

Merge internal change: 236650118

https://chromium-review.googlesource.com/c/1504118/

Deprecate gfe2_reloadable_flag_quic_always_reset_ietf_connections.

Merge internal change: 236645139

https://chromium-review.googlesource.com/c/1504001/

R=rch@chromium.org

Change-Id: I67c2e21e3f23108bb96c1fc1d861fbea5816dfff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1504233
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#637833}