GitLab

These symbols are used by chrome/browser/crash_handler_host_linux.cc when building with branding==Chrome, so they need to be exported for shared-library builds to work in that configuration.

BUG=none
TEST=builds

Review URL: http://codereview.chromium.org/7076007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86782 0039d316-1c4b-4281-b951-d872f2087c98

Revert "Revert "Add VideoCaptureImpl and VideoCaptureImplManager""
This reverts commit r86770

BUG=NONE
TEST=NONE
TBR=wjia@google.com

Review URL: http://codereview.chromium.org/6962006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86781 0039d316-1c4b-4281-b951-d872f2087c98

In our initial design of the beginInstallWithManifest function, we forgot that
some extensions have a name which needs token substitution for i18n/l10n. This
change renames beginInstallWithManifest to beginInstallWithManifest2, and
modifies the signature to take optional localizedName and locale parameters.

I also refactored how we compare the passed in manifest used in the
pre-download confirmation dialog - we now keep a copy of the source from the
.crx file to compare against, since i18n substututions can happen on the
manifest we use to construct the Extension object.

BUG=75821
TEST=Covered by browser tests for now; will require web store server-side
changes before it can be manually tested.

Review URL: http://codereview.chromium.org/6992047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86780 0039d316-1c4b-4281-b951-d872f2087c98

Remove the last prefs code from content.  I tried hard to move ShouldShowBookmarkBar out of TabContents, but this looked very tricky so I've punted and filed http://crbug.com/83975 to track that.

BUG=76697
Review URL: http://codereview.chromium.org/7068034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86779 0039d316-1c4b-4281-b951-d872f2087c98

Enable setting of file exclusion for non-admin/non-root users. We no longer support setting exclusion-by-path.
Enhanced error reporting in SetFileBackupExclusion.
Change exclusion calls for History and Thumbnail databases.
Made MacUtilTest.TestExcludeFileFromBackups more robust.

BUG=74053
TEST=Updated base_unittests's MacUtilTest.TestExcludeFileFromBackups.
Review URL: http://codereview.chromium.org/7069021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86778 0039d316-1c4b-4281-b951-d872f2087c98

This method is private to View class, and thus can be removed.

BUG=72040
TEST=None

R=ben@chromium.org

Review URL: http://codereview.chromium.org/7076002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=82167
TEST=none

Review URL: http://codereview.chromium.org/7044008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86774 0039d316-1c4b-4281-b951-d872f2087c98

This timeouts out often on chromeos.

BUG=83876
TEST=browser_tests on chromeos will no longer hang.

Review URL: http://codereview.chromium.org/7077002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86771 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r86758

Revert "fix clang"

This reverts commit r86761

BUG=NONE
TEST=NONE
TBR=wjia@google.com

Review URL: http://codereview.chromium.org/7071002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86770 0039d316-1c4b-4281-b951-d872f2087c98

The code path for window.open() call from extensions is not setting the
app_name_ on the browser instance which is causing the location bar to
be displayed.

This is a regression from "Cleanup popup related browser navigation
code." - svn://svn.chromium.org/chrome/trunk/src@83399

BUG=83692
TEST=Invoke window.open() from an extension background page.  There
should be no location bar displayed.

modified:   chrome/browser/extensions/extension_host.cc
modified:   chrome/browser/ui/browser_navigator.cc

Review URL: http://codereview.chromium.org/6992018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86768 0039d316-1c4b-4281-b951-d872f2087c98

wrong.

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/6992086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86767 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86766 0039d316-1c4b-4281-b951-d872f2087c98

In order to allow mocking function calls as soon as possible (before any javascript is
run), we create a factory capable of registering overrides per-host.

BUG=82437
R=estade@chromium.org
TEST=browser_tests --gtest_filter=TestChromeWebUIFactoryTest.*


Review URL: http://codereview.chromium.org/6992019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86764 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sergeyu@chromium.org
BUG=83949
TEST=none

Review URL: http://codereview.chromium.org/6976015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86763 0039d316-1c4b-4281-b951-d872f2087c98

This change implements a settings page that allows users to manage protocol
handlers registered via navigator.registerProtocolHandler.

tony: could you review the ProtocolHandlerRegistry stuff?
estade: could you review the webui stuff?

Thanks!

TEST=Unit tests provided.

Review URL: http://codereview.chromium.org/7033018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86762 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7062011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86761 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83942
TEST=downloads.DownloadsTest.testDownloadsPersistence
Review URL: http://codereview.chromium.org/6992090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86760 0039d316-1c4b-4281-b951-d872f2087c98

As soon as we start to handle an event, filter against the type of
nodes we care about (only text fields), rather than waiting to filter
in DidHandleMouseEvent().

Otherwise, PageClickTracker could hold a reference to the node until the
next mouse event, potentially keeping the node alive for longer than
necessary.

Review URL: http://codereview.chromium.org/7064012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86759 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=try bots
Review URL: http://codereview.chromium.org/6902166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86758 0039d316-1c4b-4281-b951-d872f2087c98

Removes now-upstreamed test_expectations updates.

TBR=ukai@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86757 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/6979025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86756 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=unit tests included; I also tested locally with a cross-filesystem-sync-copy layout test [that I'll add to webkit later], both with and without obfuscation.


Review URL: http://codereview.chromium.org/7066033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86755 0039d316-1c4b-4281-b951-d872f2087c98

BUG=83763
TEST=pdf.PDFTest.testPDFRunner, find_in_page.FindMatchTests.testSearchInPDF
Review URL: http://codereview.chromium.org/6987035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86754 0039d316-1c4b-4281-b951-d872f2087c98

Refactor tooltip string code to remove duplication.
R=mrossetti@chromium.org
BUG=70709
Review URL: http://codereview.chromium.org/6979021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86753 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dmaclach@chromium.org
BUG=83979
TEST=none

Review URL: http://codereview.chromium.org/7069032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86752 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionService is in turn owned by the Profile.

Also stop pretending that each event router observes more than one profile. (To support multi-profile, each profile would have its own ExtensionService and routers.)

BUG=81745
TEST=covered by existing tests

Review URL: http://codereview.chromium.org/6961027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86750 0039d316-1c4b-4281-b951-d872f2087c98

TBR=apatrick@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86749 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:15464
TEST=manual testing in chromeos-chrome on linux

Review URL: http://codereview.chromium.org/7069029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86748 0039d316-1c4b-4281-b951-d872f2087c98

Unrelated changes:
- Remove unnecessary {} around if clause.
- Tweak some comments in the header file.
- Move prev() and pos() getters to the end of public section.

BUG=None
TEST=out/Debug/base_unittests --gtest_filter=BreakIteratorTest.*

R=tsepez@chromium.org,evan@chromium.org

Review URL: http://codereview.chromium.org/6979019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86747 0039d316-1c4b-4281-b951-d872f2087c98

TBR=willchan

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86746 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60099
TEST=no

Review URL: http://codereview.chromium.org/6987017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86745 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86744 0039d316-1c4b-4281-b951-d872f2087c98

 - autofill.AutofillTest.testFIllProfileCrazyCharacters

TEST=none
BUG=83686
Review URL: http://codereview.chromium.org/6979027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86743 0039d316-1c4b-4281-b951-d872f2087c98

Made the OS_LINUX ifdefs in ui/ and webkit/ directories more cross-platform, so that these files can be used on multiple POSIX platforms.

Review URL: http://codereview.chromium.org/6990051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86742 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45079
TEST=NONE


Review URL: http://codereview.chromium.org/7067044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86741 0039d316-1c4b-4281-b951-d872f2087c98

This test appears to fail only when run in the background.

BUG=69619
TEST=search_engines.SearchEnginesTest.testDiscoverSearchEngine
Review URL: http://codereview.chromium.org/7031066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86740 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81621

R=cmp@chromium.org
TEST=

Review URL: http://codereview.chromium.org/6992077

TBR=nirnimesh@google.com
Review URL: http://codereview.chromium.org/6987034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86739 0039d316-1c4b-4281-b951-d872f2087c98

They seems to be same issue as in 83944.

TBR=kinuko@chromium.org
BUG=83944
TEST=webkit valgrind bots should cycle green

Review URL: http://codereview.chromium.org/7053027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86738 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/83663
TEST=none
Review URL: http://codereview.chromium.org/7069022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86736 0039d316-1c4b-4281-b951-d872f2087c98

Make the app provider match highlighting use the existing ClassifyMatchXXX() machinery, and set the correct base styles (NONE rather than DIM for the contents, and URL rather than DIM for the description).

This also switches from UTF-8 to UTF-16 for various temps/members since that's the destination encoding for the various AutocompleteMatch fields.

BUG=none
TEST=App matches in omnibox should have undimmed names and green URLs.
Review URL: http://codereview.chromium.org/7031058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86735 0039d316-1c4b-4281-b951-d872f2087c98