- 09 Apr, 2018 40 commits
-
-
Zhuoyu Qian authored
This change adds an overloaded GetSelectionTextFromBody() function in EditingTestBase. It returns text of Selection().GetSelectionInDOMTree(). This can simplify the test code and improve code health. Signed-off-by:
Zhuoyu Qian <zhuoyu.qian@samsung.com> Change-Id: I5548e4f168176a0e9921d2c4798fdf9126661b75 Reviewed-on: https://chromium-review.googlesource.com/1000655Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549135}
-
Tatsuhisa Yamaguchi authored
A file passed to Zip Archiver for packing may be removed before starting to zip it. It happens, for example, when multiple fils are passed to Zip Archiver and user removed the file while preceding files are processed. Bug: 830317 Test: Manually tested by the repro steps in the bug. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c8682ddf21abc7e11c0e9e7d427890b7093c233 Reviewed-on: https://chromium-review.googlesource.com/1002434 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#549134}
-
Daniel Bratell authored
There were two GetExtensionView functions which clashed in jumbo build experiments where they ended up in the same translation unit. This patch makes them member functions which removes the need to supply an argument, which in turn makes the code a bit simpler and easier to read. Bug: 803406 Change-Id: I09fad295de900d6d78092397654314e757761226 Reviewed-on: https://chromium-review.googlesource.com/997774Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#549133}
-
Leszek Swirski authored
Ensure that a resource fetched by a service worker has a non-null source origin before creating its CachedMetadataSender -- otherwise, use the null sender. Bug: chromium:828838 Change-Id: Ice176848b6cdb9c288df9294dcee9e2d55026359 Reviewed-on: https://chromium-review.googlesource.com/999655 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#549132}
-
Lei Zhang authored
Modernize code as well. BUG=714018 Change-Id: I7dd5330e094c190328ea9c6dd9faa042510962e5 Reviewed-on: https://chromium-review.googlesource.com/1001032Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#549131}
-
Ramin Halavati authored
Network traffic annotation in ProxyResolutionService was wrongly set in cases where proxy info was fetched through completely synchronous method, causing flaky test failures. The bug is fixed and tests are re-enabled. Bug: 822975 Bug: 826744 Bug: 823077 Change-Id: Ic63301ff053fc9160b1a96372af1ee289342396c Reviewed-on: https://chromium-review.googlesource.com/997656Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#549130}
-
Jan Krcal authored
This CL takes the (almost) last step in converting java code from protobuf nano to lite. The only remaining code with nano is //third_party/cacheinvalidation which is deprecated and should be replaced later this year. We still need to keep the generate_lite variable in rules.gni because it is used in the internal repo. After this CL, I will - remove instances of generate_lite from the internal repo and finally - remove generate_lite from rules.gni. Bug: 782237 Change-Id: I65f144c59d84e8c75fe3152543c6e1941e52a3dd Reviewed-on: https://chromium-review.googlesource.com/998033Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#549129}
-
Patrik Höglund authored
The bot is now correctly displayed in the main console, but it doesn't show up in the chromium.linux console or in the tryserver builder list. This should fix that. Bug: chromium:776284 Change-Id: Iea27c9f65510f8452dbaadb277e854bf30585b89 Reviewed-on: https://chromium-review.googlesource.com/997332Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#549128}
-
Benoit Lize authored
Also adds presubmit checks and unit tests to this directory. Sample output: $ python tools/android/native_lib_memory/code_pages_pss.py --app-package com.google.android.googlequicksearchbox --chrome-package com.android.chrome [...] com.google.android.googlequicksearchbox com.google.android.googlequicksearchbox:interactor com.google.android.googlequicksearchbox:search Total PSS from code pages = 2171kB INFO: root:Processes: Bug: 758566 Change-Id: I55cb0f3a5ca3fbadd9d2b095713258cd8b66caa5 Reviewed-on: https://chromium-review.googlesource.com/999714Reviewed-by:Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549127}
-
https://skia.googlesource.com/skia.git/+log/4473907dee6b..e697500577c5 $ git log 4473907de..e69750057 --date=short --no-merges --format='%ad %ae %s' 2018-04-09 angle-skia-autoroll Roll third_party/externals/angle2/ 5ae64c94d..6c7ab7fe8 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I637ba5efd92e2898d03115f6e2bb4d643f1d0f62 Reviewed-on: https://chromium-review.googlesource.com/1002292Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549126}
-
Matt Falkenhagen authored
This tests behavior discussed here: https://github.com/w3c/ServiceWorker/issues/1289 Namely it tests when a request for a worker goes through a redirect chain: 1) On redirect from A -> B, whether the service worker at B sees the request. 2) After the final redirect, which service worker controls the resulting client. The tests are written as specified today. Therefore, Firefox passes this test (verified in Nightly) and Chrome does not. (Actually a small change is required to the test to make Firefox pass it, see: https://bugzilla.mozilla.org/show_bug.cgi?id=1452528) Currently it only tests shared worker but dedicated worker can be added in a follow-up patch. Bug: 829720 Change-Id: Id3b1ea8b952760be0ef9917f2c6a3afe60ca1fb5 Reviewed-on: https://chromium-review.googlesource.com/999241 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#549125}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6943cf79. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15460 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mek@chromium.org: external/wpt/webmessaging rego@igalia.com: external/wpt/css/selectors TBR=lukebjerring No-Export: true Change-Id: Ic117bedf19e4417f304a9af11fd84ff014197858 Reviewed-on: https://chromium-review.googlesource.com/1002452 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#549124}
-
Yuzu Saijo authored
This CL intends to fix a bug where renderer oom detection stops running after reloading / navigation / switching tabs. This was caused because binding_ was never unbound although it was stated as one of the requirements to start detection in renderer. BUG=829725 Change-Id: I43507a5eb12a6206dca333be4d6d609b1c8fac72 Reviewed-on: https://chromium-review.googlesource.com/999224Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#549123}
-
Makoto Shimazu authored
This CL is disabling the following tests in WebviewClientCertsLoginTest. - SigninFrameAuthorityGiven - SigninFrameAuthorityGivenNoMatchingCert - SigninFrameCertNotAutoSelected - SigninFrameIntermediateAuthorityKnown - SigninFrameIntermediateAuthorityUnknown - SigninFrameNoAuthorityGiven TBR=achuith@chromium.org NOTRY=true Bug: 830337 Change-Id: I5b7c0817551d360bb4c143bdfa6f537a6d561a0e Reviewed-on: https://chromium-review.googlesource.com/1002714Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#549122}
-
Kent Tamura authored
This CL removes a lot of code for the flag. This CL has no behavior changes. Bug: 768828 Change-Id: I3950b41ced9bb56967c161aadcde99ed78c72ea6 Reviewed-on: https://chromium-review.googlesource.com/1002219Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549121}
-
Makoto Shimazu authored
This CL disables the following tests in SamlTest because they are frequently timed out. - MetaRefreshToHTTPDisallowed - NoticeUpdatedOnRedirect - PasswordConfirmFlow - SamlUI - ScrapedDynamic - ScrapedSingle - UseAutenticatedUserEmailAddress TBR=achuith@chromium.org NOTRY=true Bug: 830322 Change-Id: If18427f532ff7ad66e437b4c9bbd489749f3d797 Reviewed-on: https://chromium-review.googlesource.com/1001438Reviewed-by:
-
Giovanni Ortuño Urquidi authored
Otherwise POST form submissions could lose their encoding type. There are two parts to this change: 1. Save the request headers in NavigationHandle, so that we can access the headers in NavigationThrottles. 2. Change BookmarkAppNavigationThrottleUtils::OpenNewForegroundTab to also include the Content-Type header in the new navigation. Bug: 826158 Change-Id: I30a575fcdfab15442bb331c20685a988df3b4def Reviewed-on: https://chromium-review.googlesource.com/991616 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#549119}
-
Erik Luo authored
The [Affects=Nothing] extended attribute indicates a function has no JS-observable side effect. This CL adds plumbing to mark methods and marks Performance's nowMethod (performance.now()) as side-effect-free. Future CLs will let the extended attribute mark attributes and constructors, and other side-effect-free methods as well. Roadmap doc: https://goo.gl/8wGqxz Bug: 829571 Change-Id: I26900dff4f00b5374bbef7934f11609ff67aa75c Reviewed-on: https://chromium-review.googlesource.com/999012 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This CL disables these three tests: - ManyIframes - VerifySiteInstanceCountInBrowsingInstanceWithExtensions - IsolateExtensionsHostedApps TBR=nick@chromium.org NOTRY=true Bug: 830318 Change-Id: If31bcd377743229093123174568a88c251915e90 Reviewed-on: https://chromium-review.googlesource.com/1002224Reviewed-by:
-
Ricky Liang authored
Remove arc in the file / class / namespace names to avoid confusion, as the code is not ARC++ specific. BUG=b:73137420 TEST=Build and make sure camera works on soraka. Change-Id: Ie40c1149c42b27a5d5c5f2e6c9bfa0bbbae695be Reviewed-on: https://chromium-review.googlesource.com/981818Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#549116}
-
Makoto Shimazu authored
TBR=dsinclair@chromium.org NOTRY=true Bug: 826055 Change-Id: Ib74050857a0af95cb0d75bf1e84a2784e8219de1 Reviewed-on: https://chromium-review.googlesource.com/1002346 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Sorin Jianu authored
TBR: waffles Bug: 822990 Change-Id: I29c82551b2fbc5f7f8f8d5f8e87e88808fbf5d6a Reviewed-on: https://chromium-review.googlesource.com/1001392Reviewed-by:
Sorin Jianu <sorin@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549114}
-
Joe Downing authored
This CL adds a helper method to the event handling class used by Aura to mark events which originated from a KeyboardHook such that they are not handled by the browser. The idea here is that if KeyboardLock is enabled, we check to see if the key_code is in the list of keys to filter. If so, then we mark the event 'skip_in_browser' so it isn't handled by the browser. The exception is ESC which we want to give the fullscreen exit handler a chance to handle so that they user can exit fullscreen mode via the keyboard. This CL also makes one fix to the Windows KeyboardHook class where I was intercepting keys based on the key_code instead of the scan_code which is a problem because the keys_to_lock set that is passed down to it represents the 'native key codes' aka scan codes of the keys to intercept. BUG=680809 Change-Id: I795dd57bf68ebea777fecf8cd579f8776fb99ee2 Reviewed-on: https://chromium-review.googlesource.com/940531 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#549113}
-
Hiroki Nakagawa authored
This is a clean-up CL and doesn't change behavior. Before this CL, CanvasAsyncBlobCreator takes ParentFrameTaskRunners that is a set of task runners bound with the parent Document. However, the blob creater uses only one task runner type and doesn't have to take the full set of the task runners. This CL replaces ParentFrameTaskRunners with bare base::SingleThreadTaskRunner for simplification. Bug: 829119 Change-Id: I656f42abac46bf723fc9aa614bdd9d3294c0e562 Reviewed-on: https://chromium-review.googlesource.com/1002336Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#549112}
-
https://chromium.googlesource.com/angle/angle.git/+log/5ae64c94dbf1..6816d84382d5 $ git log 5ae64c94d..6816d8438 --date=short --no-merges --format='%ad %ae %s' 2018-03-31 jmadill Add two new fields to angle::Format. 2018-03-31 jmadill Vulkan: Update resource dependency semantics. 2018-03-31 jmadill Vulkan: Reorganize helper classes. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: Ie6eb2052a54a78485901b4055aed25568c448ec6 Reviewed-on: https://chromium-review.googlesource.com/1002312Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#549111}
-
Kent Tamura authored
Also, apply snake_case to file basenames. TBR=jam@chromium.org Bug: 768828 Change-Id: I28bead32daf1adbf15033b778c633b034a743562 Reviewed-on: https://chromium-review.googlesource.com/1001436Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#549110}
-
Makoto Shimazu authored
MediaEngagementAutoplayBrowserTest.DoNotBypassAutoplayLowEngagement/* are flaky. TBR=mlamouri@chromium.org Bug: 830003 Change-Id: I7bfd20eee54e2467231544f63c4afb5e7b6964ce Reviewed-on: https://chromium-review.googlesource.com/1002341Reviewed-by:
-
Manu Cornet authored
This flag effectively changes the shelf into a "hot-seat only" mode, where app shortcuts are shown to launch apps, but apps that have a running instance but are not pinned are not shown. This is only the case in tablet mode where shelf space is scarce. Change-Id: Ibc9e0ae2955fc1f0ee04fd5b02c98185b114a91d Reviewed-on: https://chromium-review.googlesource.com/979881 Commit-Queue: Manu Cornet <manucornet@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#549108}
-
Yoshifumi Inoue authored
This patch changes "insert-br-quoted-[1-7].html" to utilize |selection_test()| and integrated into "insert-br-quoted-001.html" for ease of maintenance. Note: "insert-br-quoted-002.html" and "insert-br-quoted-005.html" are same. Bug: 679977 Change-Id: I49a3e53eb2c314d9703339a672fdd95847ada354 Reviewed-on: https://chromium-review.googlesource.com/999075Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549107}
-
Jun Choi authored
Change all test data used in u2f_{register, sign}_unittest.cc to data specified in the CTAP specification. Also, explicitly check the first argument to MockFidoDevice::DeviceTransactPtr(). Bug: 827263 Change-Id: Id82934413d8058afe0c7c356bc562b75d72d05a0 Reviewed-on: https://chromium-review.googlesource.com/994346 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#549106}
-
Noel Gordon authored
Run VideoPlayerBrowserTestInGuestMode tests (there is only one, listed below) on all bots. VideoPlayerBrowserTestInGuestMode.OpenSingleVideoOnDownloads Bug: 804413,508949 Change-Id: I1f355725775bb104101e108b3872a4b25549a074 Reviewed-on: https://chromium-review.googlesource.com/1002334Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549105}
-
Matt Falkenhagen authored
- Try to define "provider" better. - Update for shared worker in S13nServiceWorker case. Change-Id: I3b24b8bb2db1fb795ddd9dc39cc098f851b26e99 Reviewed-on: https://chromium-review.googlesource.com/1001154Reviewed-by:
-
Rudy Xie authored
This is needed by downstream for conditional statement. Change-Id: I8dd2ed99306f308279a3cce2b3ec35d2edec285c Reviewed-on: https://chromium-review.googlesource.com/994792Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Rudy Xie <rudyxie@google.com> Cr-Commit-Position: refs/heads/master@{#549103}
-
Tatsuhisa Yamaguchi authored
Current implementation of Drive download / sync mechanism will persist cache of a file only when the entire file is downloaded, but discards and cancels download when app reads only a part of the file. Also it downloads the file from the beginning when only a middle of a file is read. As a result packing of a file by Zip Archiver didn't work efficiently when a file to be zipped is not cached at the beginning. This is a workaround for it by making a private API to ask for download and wait until the entire file is available in cache before starting intermittent read in Zip Archiver. Bug: 785086,797854 Test: Manually test by clearing cache and zipping ~100MB file on Drive Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba726587e3e42356fc8a6bf6b0e44982b628fbba Reviewed-on: https://chromium-review.googlesource.com/995654Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549102}
-
Matt Giuca authored
Renames it to HostedAppMenuButton. This was requested in a review of a larger refactor (https://crrev.com/c/983252). Bug: 791399 Change-Id: I173bb8fa11d427da428252dfcb8f19e779523b87 Reviewed-on: https://chromium-review.googlesource.com/999216Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#549101}
-
Hirokazu Honda authored
AllocateProtectedBuffersDeprecated() and ImportBufferForPicturesDeprecated() will never be used. This removes these functions and non used member variables. BUG=chromium:816327 TEST=Play Secure video using EXO Player TEST=CtsMediaTestCases TEST=GtsMediaTestCases Change-Id: I95b7482913dc02f91ed778aa80acfbce7c20a7f9 Reviewed-on: https://chromium-review.googlesource.com/989373Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#549100}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=anantha@chromium.org Change-Id: I6e99a0981afc3a79758216bde6f5f65dce3213c1 Reviewed-on: https://chromium-review.googlesource.com/1001698Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#549099}
-
Matt Falkenhagen authored
The two callsites can use GetClientProviderHostIterator() instead. Just code cleanup. This is also nicer as the callsites don't need to manually call is_execution_ready to filter out reserved clients. Change-Id: I427b52e18a745248dc15e214abf87acf53c980cd Reviewed-on: https://chromium-review.googlesource.com/994434Reviewed-by:
-
Kenichi Ishibashi authored
This is a follow-up CL of r548708. We don't have to use DeleteSoon(). It should be fine just deleting it when the mojo connection is disconnected. Use a strong binding instead. Bug: N/A Change-Id: I97dc9f8f7eea2c8498a5fb3bc4c53a48c9b8023b Reviewed-on: https://chromium-review.googlesource.com/1002213 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#549097}
-
Zhuoyu Qian authored
This patch changes to use GetCaretTextFromBody() instead of GetSelectionTextFromBody() with use Position directly. Signed-off-by:
-
