GitLab

EasyUnlockTpmKeyManager should not start poking TPM on worker thread
before TPM initialization is finished on IO thread in order to
prevent IO thread being blocked during startup waiting for easy
signin key pair being created.

BUG=464524
TEST=Easy signin works after initializing easy unlock and signin in
once.

Review URL: https://codereview.chromium.org/1138123003

Cr-Commit-Position: refs/heads/master@{#329475}

This brings paper-icon-button v0.8.0 into third_party/polymer/v0_8.

BUG=485381

Review URL: https://codereview.chromium.org/1136293002

Cr-Commit-Position: refs/heads/master@{#329474}

BUG=380227

Review URL: https://codereview.chromium.org/1130793006

Cr-Commit-Position: refs/heads/master@{#329473}

This measures time spent in DistillPageImpl(), which is mostly
ExecuteJavaScript(). This includes JavaScript compilation and execution.

We already have DomDistiller.Time.DistillationTotal, but it is measured
within JavaScript.

Review URL: https://codereview.chromium.org/1131493005

Cr-Commit-Position: refs/heads/master@{#329472}

Add two unittests to test the condition that triggers
ERR_REQUEST_FOR_SECURE_RESOURCE_OVER_INSECURE_QUIC.

BUG=

Review URL: https://codereview.chromium.org/1135103003

Cr-Commit-Position: refs/heads/master@{#329471}

Fix infinite loop bug on javascript.

BUG=486879

Review URL: https://codereview.chromium.org/1132113005

Cr-Commit-Position: refs/heads/master@{#329470}

Slimming paint is now much faster than PicturePile backed recording
for impl-side painting. It's what we're going to ship when we enable
impl-side, so make it the default. Left the disable switch just in case
to try out PicturePile if we need to for some reason until we turn
on impl-side by default.

R=piman@chromium.org, sky
BUG=466426

Review URL: https://codereview.chromium.org/1141583003

Cr-Commit-Position: refs/heads/master@{#329469}

This can be merged to ValidateAndMeasurePage method.

BUG=455391, 470147
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1124033004

Cr-Commit-Position: refs/heads/master@{#329468}

Revert of Cache IsNonBrowserProcess values, so we only take a loader-lock the first time. (patchset #4 id:60001 of https://codereview.chromium.org/1132473003/)

Reason for revert:
Possibly causing mysterious fails on the Win DBG bots:
https://build.chromium.org/p/chromium.webkit/builders/Win7%20%28dbg%29/builds/16344

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/37896

Original issue's description:
> Cache IsNonBrowserProcess values, so we only take a loader-lock the first time.
>
> BUG=485656,477137
>
> Committed: https://crrev.com/78d41b5d4e59dc7d52d7e7d6530fdd0a78b36d33
> Cr-Commit-Position: refs/heads/master@{#329246}

TBR=siggi@chromium.org,grt@chromium.org,csharp@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=485656,477137

Review URL: https://codereview.chromium.org/1134253002

Cr-Commit-Position: refs/heads/master@{#329467}

Only HTTP/1.1 (and below) sockets may renegotiate. This fix a
crash because SpdyHttpStream didn't account for this properly.
(And can't as the renego + client auth hack is inherently
incompatible with multiplexing.)

Tested manually against hacked up Go servers:

- HTTP/1.1 server which renegotiates with client auth before
  sending a response on a fresh socket.

- Same as above but with a reused socket (the server only
  requests renego when fetching /auth).

- HTTP/2 which incorrectly renegotiates with client auth upon
  requesting /auth. Verified that we get ERR_SSL_PROTOCOL_ERROR
  and not crash.

- HTTP/1.1 server which does two handshakes in a row with Finished
  and HelloRequest in the same record. NSS and BoringSSL differ in
  their behavior here, but in neither port should we miss the
  renego.

BUG=484543,462283

Review URL: https://codereview.chromium.org/1131763002

Cr-Commit-Position: refs/heads/master@{#329466}

Error buttons should not be visible in stable.
Error buttons should be visible in dev.

BUG=463245

Review URL: https://codereview.chromium.org/1132493004

Cr-Commit-Position: refs/heads/master@{#329465}

This brings paper-item v0.8.2 into third_party/polymer/v0_8.

I got a presubmit warning about not updating README.chromium.
Will that actually be a problem in the CQ?

BUG=485381

Review URL: https://codereview.chromium.org/1124133004

Cr-Commit-Position: refs/heads/master@{#329464}

Revert of [MemSheriff] Suppress use-after-free in content::RenderFrameImpl::~RenderFrameImpl (patchset #1 id:1 of https://codereview.chromium.org/791053005/)

Reason for revert:
The bug is expected to be fixed quite some time ago, reverting to check.

Original issue's description:
> [MemSheriff] Suppress use-after-free in content::RenderFrameImpl::~RenderFrameImpl
>
> BUG=445836
> TBR=lazyboy@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/bb25da2ef63be828fc0ae3303af0862cbca70123

TBR=bruening@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=445836

Review URL: https://codereview.chromium.org/1129973004

Cr-Commit-Position: refs/heads/master@{#329463}

This change decouples the DisplaySnapshot from the DrmDisplay since the
snapshot is only needed to IPC the display information to the browser
process. Also, move all the display configuration calls into the
DrmDisplay object to simplify state and clarify the intent of the
operations.

This change also moves the logic to parse the DRM display state into
DisplaySnapshot objects into a common location intended to be used by
both GPU and Browser processes. The parsing logic will be used in a
subsequent change to allow proper parsing of display configuration on
the browser side during startup.

BUG=484294

Review URL: https://codereview.chromium.org/1129923004

Cr-Commit-Position: refs/heads/master@{#329462}

This CL adds HTTP server and connection classes, and implements lifespan management for them.

The following work will be in future CLs:
- convert net::HttpServer::Delegate events about HTTP/WebSocket requests to HttpConnectionDelegate Mojo interface method calls.
- tests.

BUG=478249
TEST=None

Review URL: https://codereview.chromium.org/1134883002

Cr-Commit-Position: refs/heads/master@{#329461}

BUG=486240

Review URL: https://codereview.chromium.org/1136093004

Cr-Commit-Position: refs/heads/master@{#329460}

Moved the definition of a 10.7+ NSString constant into
mac/sdk_forward_declarations.h, and ensured that the NSString is explicitly
defined regardless of the OSX SDK version being compiled against.

BUG=471823

Review URL: https://codereview.chromium.org/1133523005

Cr-Commit-Position: refs/heads/master@{#329459}

explain why it is disabled in STABLE and UNKNOWN channels.

R=asvitkine@chromium.org
BUG=426203

Review URL: https://codereview.chromium.org/1130723005

Cr-Commit-Position: refs/heads/master@{#329458}

Introduced a PresentationServiceClient mojo interface implemented by
PresentationDispatcher. On connection to PresentationService,
PDispatcher will pass a proxy of itself to PSImpl.

Please note that screen availability updates are already throttled
from the browser's perspective.

When a screen availability update is available, it will be transmitted
back to PSDispatcher via the PresentationServiceClient interface.

In the future, I plan to use the same interface for other types of
observer-style APIs (e.g. default session start, session state change,
on message).

Also, simplified the ScreenAvailability API so it only operates on
the DPU (or 1-UA mode if absent). The current semantics to support
listening on arbitrarily presentation URLs + handling behavior for
DPU is very confusing. We should revisit the implementation when we
decide to support it.

This will also hopefully fix the bug where ScreenAvailability mojo
callbacks accumulate over time.

Also fix mojom indent.

BUG=485337

Review URL: https://codereview.chromium.org/1131053005

Cr-Commit-Position: refs/heads/master@{#329457}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/7da2e55..d995009

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/1135773003

Cr-Commit-Position: refs/heads/master@{#329456}

R=jbudorick@chromium.org
BUG=482067

Review URL: https://codereview.chromium.org/1140703004

Cr-Commit-Position: refs/heads/master@{#329455}

BUG=484734

Review URL: https://codereview.chromium.org/1128923006

Cr-Commit-Position: refs/heads/master@{#329454}

Post-commit nits from the original http://crrev.com/329363

BUG=485042
TEST=none

Review URL: https://codereview.chromium.org/1138283002

Cr-Commit-Position: refs/heads/master@{#329453}

Mac we had noticed UpdatePrefs is being called a lot. Would like to
track the caller (we think it could be extensions).

BUG=485314, 451256, 431476
R=mmenke@chromium.org, asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1139843002

Cr-Commit-Position: refs/heads/master@{#329452}

For additional context, see:
- https://codereview.chromium.org/1118613003/
- https://codereview.chromium.org/1115083002/

BUG=433140

Review URL: https://codereview.chromium.org/1129303002

Cr-Commit-Position: refs/heads/master@{#329451}

unit tests on each continous build.

build/ CL: https://codereview.chromium.org/1128313003

R=tbreisacher@chromium.org
BUG=393873

NOTRY=true

Review URL: https://codereview.chromium.org/1137933003

Cr-Commit-Position: refs/heads/master@{#329450}

This pulls in the following Native Client changes:

667d7cc: (phosek@chromium.org) Disable bitcode stream in pnacl-translate by default
d71f13c: (petarj@mips.com) Skip setting nnacl_tooldir for MIPS
9cf7d5a: (sbc@chromium.org) Add uname implementation to libnacl
b5365b4: (sbc@chromium.org) Remove chrome dependencies from ARM sysroot image

Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/c3aa3421888b5e69932e2389658969ac181b83f7..b5365b48a73962904e04229ca3bf97948d03d034

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build

Review URL: https://codereview.chromium.org/1129713005

Cr-Commit-Position: refs/heads/master@{#329449}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/804012f..9a048f2

TBR=dpranke@chromium.org,alancutter@chromium.org

Review URL: https://codereview.chromium.org/1131783004

Cr-Commit-Position: refs/heads/master@{#329448}

This CL fixes a crash on opening chrome://copresence
in incognito window.

BUG=485992

Review URL: https://codereview.chromium.org/1134733002

Cr-Commit-Position: refs/heads/master@{#329447}

When calling LayerOwner::RecreateLayer() on the root Layer, the Compositor gets
moved to the new layer after all children are added.

If there are ongoing animations while this occurs they are cancelled. If any
animation observer attempts to access the compositor in response it will crash
Chrome as the compositor is null.

Update LayerOwner::RecreateLayer() to set the Compositor on the new root layer
bfore adding children. This also brings it to the same timing as when the
compositor would be set while performing RecreateLayer on non-root layers.

TEST=LayerOwnerTestWithCompositor.RecreateRootLayerDuringAnimation,
compositor_unittests, ash_unittests, views_unittests
BUG=chrome-os-partner:40032

Review URL: https://codereview.chromium.org/1128103003

Cr-Commit-Position: refs/heads/master@{#329446}

Add NetworkChangeNotifierFactoryCast to create instance of
NetworkChangeNotifierLinux that ignores interfaces that will not be
used to connect to internet.

BUG=469863
R=gunsch@chromium.org

Review URL: https://codereview.chromium.org/1138923002

Cr-Commit-Position: refs/heads/master@{#329445}

In addition to the normal separation of MojoMain() into its own build
target, this patch also renames a class and moves a class into the
surfaces:: namespace. This was done because they were non-unique
symbol names in the resultant binary.

(There were two classes named mojo::ContextProviderMojo and had
different implementations.)

BUG=477435

Review URL: https://codereview.chromium.org/1138293002

Cr-Commit-Position: refs/heads/master@{#329444}

main change: Value::CreateNullValue returns a scoped_ptr

BUG=none

Review URL: https://codereview.chromium.org/1129083003

Cr-Commit-Position: refs/heads/master@{#329443}

For ensuring that the blink is always initialized with WebThread, the
call sites of blink must implement WebThread to expose the task runner.
UtilityThread is the only case where blink is run without exposing the
platform thread. This CL adds new WebThread implementation for
UtilityThread. After this change blink will always initialized with
platform thread and task runner exposed.

BUG=486782

Review URL: https://codereview.chromium.org/1133563007

Cr-Commit-Position: refs/heads/master@{#329442}

Prior to this fix the incoming connection to the content handler saw
an empty requesting url. This change makes the requesting url
correspond to the url of the first app connecting to the content
handler.

BUG=none
TEST=covered by test
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1130353005

Cr-Commit-Position: refs/heads/master@{#329441}

BUG=486916
TEST=See bug comment 1 for repro steps.

Review URL: https://codereview.chromium.org/1134193003

Cr-Commit-Position: refs/heads/master@{#329440}

BUG=486916
TEST=Histogram properly labeled

Review URL: https://codereview.chromium.org/1128993005

Cr-Commit-Position: refs/heads/master@{#329439}

Creates CRWTestJSWindowIdManager to enable force injection,
bypassing hasBeenInjected check in the inject method.

Moves crw_js_window_id_manager_unittest.mm out of public directory.

BUG=465898

Review URL: https://codereview.chromium.org/1129763003

Cr-Commit-Position: refs/heads/master@{#329438}

BatteryManager is offered as a system service and Chrome should not be
instantiating it. Updates the code to retrieve the correct instance.

Review URL: https://codereview.chromium.org/1133253003

Cr-Commit-Position: refs/heads/master@{#329437}

 * Add support for selecting the new OpenGL renderer.
 * Remove the --use-warp flag and merge it into the --use-angle flag.

BUG=485541

Review URL: https://codereview.chromium.org/1123343004

Cr-Commit-Position: refs/heads/master@{#329436}