- 10 Oct, 2019 40 commits
-
-
Xiaohui Chen authored
Bug: b:141751193 Test: locally build and unittests Change-Id: I1eb5ccfecb83723e54f67997283885c7f85c0fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845795Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704719}
-
Xida Chen authored
The test is actually using width interpolation to test that the 'vh' value is computed correctly. Bug: 900581 Change-Id: Icfffb6bd06e1d89a25110727fab8b3107f2c5613 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852580 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704718}
-
rbpotter authored
If more than one page was visible in the viewport, getPageAtY_(y) fell through to returning 0 when y was the bottom of the document, because in the last iteration of the loop, where max = min = page = N-1 (for an N page document), the bottom of the page was exactly equal to y, rather than strictly > y. This resulted in the most visible page being set to N-1 rather than N when the document was scrolled to the bottom in this case. Bug: 1000121 Change-Id: I541204141d1fb7891f1df1bc95d00be28d39bbfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851086 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#704717}
-
Yuta Kitamura authored
This CL adds more tests for Agent generation. They test the following cases: * HTTP frame loading a same-origin HTTPS child frame * iframe loaded as data: URL * iframe loaded with srcdoc attribute Bug: 961186 Change-Id: I21eae63c9b6e3d5a2be911cb4cce1eb975e48cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852325 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Auto-Submit: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#704716}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e6b95e45544d..14bf0b9d8122 git log e6b95e45544d..14bf0b9d8122 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 fmayer@google.com Merge "Improve tslint presubmit message." Created with: gclient setdep -r src/third_party/perfetto@14bf0b9d8122 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I88a6c4d24b8f5e0c69e3a97faa5d4f9f6e78df64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851687Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704715}
-
John Budorick authored
Built after crrev.com/c/1849429 landed: https://ci.chromium.org/p/chromium/builders/ci/android-avd-packager/9 Bug: 922145 Change-Id: I6bafd36290f01faf89c8e3770b6a1553e30ba8c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853108 Commit-Queue: John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#704714}
-
Ioana Pandele authored
Bug: 1013125 Change-Id: Ib1c5b60d62ec6d6c16f4600c7690149ed45ffa4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852428 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#704713}
-
Lijin Shen authored
This CL updates tab indicator style on downloads, translate infobar and clear browsing data tab layouts. Bug: 945924 Change-Id: Ic034af92ca78aae0e6813e29d3f6a2d78006b064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849210Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#704712}
-
Xianzhu Wang authored
Previously cc::Layer::DebugName() called LayerClient::TakeDebugInfo() which has side-effect to clear some debug information (e.g. raster invalidation tracking), causing layer name dump to interfere with raster invalidation tracking. Add the new method to avoid the problem. R=pdr@chromium.org TBR= # trivial change under ui/compositor. Change-Id: Ia4850298f8bc5a2a003dc92a00bda903a3b099d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850964 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#704711}
-
Yutaka Hirano authored
This reverts commit fe5510cf. Reason for revert: This has been successfully merged to M78. Let's revert this on M79. Original change's description: > Disable "HtmlImportsRequestInitiatorLock" > > We see some breakage on M78, so we are disabling the feature. After > merging this change to M78 I will revert this change. > > Bug: 1006292 > Change-Id: Ie56d2ac5cdd6ed8ea0fdf8c124a3f01c24731eed > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846832 > Commit-Queue: Yutaka Hirano <yhirano@chromium.org> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#703615} TBR=falken@chromium.org,yhirano@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1006292 Change-Id: I1adfa65ca6680f8677ac7342cecece16bb042f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852353 Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#704710}
-
Jack Lynch authored
In response to feedback on [1], this CL refactors the Watch expressions and Scope pane to keep all of their respective objects in one tree each instead of one tree per object. This allows simple keyboard navigation between watch expressions or scopes and creates more clarity for screen reader users. This change also allows users to edit watch expressions and editable object properties by pressing the enter key in order to make that functionality keyboard-accessible. There is still an issue where data-keyboard-focus is not applied when the tree element is selected after exiting a text prompt or context menu, but I believe that is an unrelated issue with treeoutline or UIUtils that can be fixed separately. Before: https://gyazo.com/656714c5e92b268e8a8a988d155bd592 After: https://gyazo.com/02e0df16e66c188c3c8f8d5b38dd3b42 Navigation gif: https://i.imgur.com/I5qT0UW.mp4 [1]: https://chromium-review.googlesource.com/c/chromium/src/+/1646644/9/third_party/blink/renderer/devtools/front_end/sources/WatchExpressionsSidebarPane.js#463 Bug: 963183 Change-Id: Iedb6d941364c457cef7614dae6a75ca6b8165c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719852Reviewed-by:
Lorne Mitchell <lomitch@microsoft.com> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#704709}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/232e3301c726..b484e7ce24c9 git log 232e3301c726..b484e7ce24c9 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 mtklein@google.com hand off frames to encoder as they come 2019-10-10 robertphillips@google.com Pass GrProgramInfo further down Vulkan call chain 2019-10-10 jvanverth@google.com Draw perspective text as paths. 2019-10-10 robertphillips@google.com Add computation of requestedFeatures to GrProgramInfo and use it 2019-10-10 kjlubick@google.com [debugger] Use alternate buffer 2019-10-10 nigeltao@google.com Update Wuffs version to 0.2.0-rc.1 2019-10-10 fmalita@chromium.org [SkVideoEncoder] Allow clients to control the color type Created with: gclient setdep -r src/third_party/skia@b484e7ce24c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: None Change-Id: Ia75206ef802bc5f797bb52861c4961bef75b315b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851689Reviewed-by:
-
Eric Orth authored
Add a simple CancelForContext mechanism that cancels probes iff the context being used matches the one being shutdown. Mostly the same as a solution implemented earlier in crrev.com/c/1823998 except no longer using the IsDohEnabled() mechanism to go out of the way to avoid changing when the experiment is disabled. Planning a subsequent CL to cleanup at least the API on this as SetRequestContextForProbes()/CancelProbesForContext() is not the greatest API for creating/cancelling cancelable actions and annoyingly inconsistent with the rest of HostResolver. Some minor fixes in dns_transaction_unittest.cc as there was some accidental method hiding of TearDown() that was otherwise breaking new tests. Bug: 1006902 Change-Id: I1e638f9f3d39b18b3443e4ddf478d2c2d37f2570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841241 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#704707}
-
Albert Chaulk authored
Turns out this was just being directed into the wrong EventHandler, we need to go into the RenderWidgetHostView's handler instead This also runs touch inputs through the gesture recognition pipeline, web content typically wants to interact with gestures and not raw touch events Bug: b/141992733 Test: local build Change-Id: I5e0722f7d268f936c92d25215ef85707d94e5289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850632Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Albert Chaulk <achaulk@chromium.org> Cr-Commit-Position: refs/heads/master@{#704706}
-
Mikhail Khokhlov authored
Bug: 981349 Change-Id: I1a47afea1dedcd352a0d6999f7119246b74b737f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849855 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#704705}
-
Joe Mason authored
Add section on blocklist/allowlist. Bug: 842296 Change-Id: I520835e8bc028407418943ea8c421208892a1e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848912Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#704704}
-
Scott Violet authored
This coverts from using the LayoutBox function to the StyleRef function, which works regardless of the implementation. After this there is only one call to IsDeprecatedFlexibleBox(), which has a cast to LayoutDeprecatedFlexibleBox. BUG=993813 TEST=covered by various layout tests Change-Id: I6a5569067a0acf492ef687dd07ae74da6910733b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849585 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#704703}
-
Martin Kreichgauer authored
CL:1800725 changed the way TouchIdAuthenticator was injected into the FidoRequestHandlerBase. As a result, the code in GetAssertionRequestHandler that was supposed to set |transport_availability_info().has_recognized_mac_touch_id_credential| to indicate to the UI whether it may dispatch a request to the Touch ID authenticator or not was never executed. As a result, all GetAssertion requests to Touch ID resulted in an immediate UI error. To fix, unify the two code paths for adding authenticators in FidoRequestHandlerBase. Fixed: 1012500 Change-Id: I3e6a4e84892c1843f2ca2acd947eaf68269089f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850799Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#704702}
-
Henrique Nakashima authored
Move it to FaviconUtils. Change-Id: Ifd693bd6ee62625282b0a175235f27dcb7213749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846399 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8e881f105660..1f67cf3bf610 git log 8e881f105660..1f67cf3bf610 --date=short --no-merges --format='%ad %ae %s' 2019-10-10 saklein@chromium.org goma_util: Fix tempdir creation for luci builders. Created with: gclient setdep -r src/third_party/chromite@1f67cf3bf610 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ibcf0b8cd14faad155a4205508ce65d6b59ef74e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853244Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c2dc845a..82019e80 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib4220e0f571980b604d39ce3a0cb716ddf8ba1ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1852606Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#704699}
-
Kasjan Siwek authored
Replacing RunUntilIdle() with QuitClosure()+Run() will make these unit tests deterministic and lets us avoid possible flakiness. Bug: 973005 Change-Id: I7f136b1bb8f6756877a71f224c60507c45d153c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848001 Commit-Queue: Kasjan Siwek <kasiwek@microsoft.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#704698}
-
Tarun Bansal authored
With this CL, Hints fetcher enforces the count of hosts that can be sent in the hints fetch request. The callers for the fetcher provide as many hosts as possible to the hints fetcher, and let the hints fetcher enforce the limit after filtering. Change-Id: I8a0a908c8849d43749355871ae691bc8999e941e Bug: 1012302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851764Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#704697}
-
Antonio Gomes authored
Moving these files (mock_peer_connection_dependency_factory.cc|h) to Blink, will allow various other unit tests to perform similar move. Similarly, for other files temporarily placed the Blink public API too. Note that given the circular inclusion, mock_peer_connection_impl.h|cc also got moved to Blink. BUG=787254 R=guidou@chromium.org, haraken@chromium.org Change-Id: I366180dd40ef6439d38de9561f8bff9c42bcccd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816789 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Pavel Shmakov authored
When Activity is restarted (either after configuration change, unless handled manually, or after being killed due to memory pressure), the system FragmentManager restores all the Fragments during Activity's onCreate event. The current APIs make it impossible to properly create a BrowserFragment without an instance of WebLayer, and that prohibits asynchronous WebLayer initialization. There are two ways to deal with it: - Disable it in a hacky way: the embedder runs savedInstanceState.remove("android:support:fragments"); in their activity prior to super.onCreate(). The embedder should then manually save and restore the parameters of each fragment they have. - Handle the restoration the "correct" way. More detailed discussion: This CL enables the second path. This means putting BrowserFragment on the top of dependency tree, which is opposite to what we have now (getWebLayer().createProfile().createBrowserFragment()). In this CL, BrowserFragment is created independently, and later attached to WebLayer instance. I suggest making BrowserFragment the only client-side object that can temporarily exist without the weblayer counterpart. All other objects should have the same lifecycle on both sides. This is achieved by making all browser APIs accessible only through BrowserFragmentController, which in turn can be accessed only after the embedder attaches BrowserFragment to WebLayer. More detailed discussion: https://docs.google.com/document/d/15xCcdO8V1tBYH-UJStmi0aEzLXcUWDkc-KWI_Wb7rdQ This CL doesn't enable async init of WebLayer after process restart: trying to retrieve BrowserFragmentController or attach BrowserFragment blocks the thread if WebLayer hasn't been already initialized, and in case of process restart it can't have been initialized. Change-Id: Ibe6fd369e8d60af5cedc256d3ebf1db210b579bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829082Reviewed-by:Bo <boliu@chromium.org> Reviewed-by:
-
Reilly Grant authored
This change makes the close() method return a Promise that is resolved when the streams have been canceled and aborted, and the browser has acknowledge that the port has been closed. This closes a loophole where close() would close these streams even if they were locked. Callers must how unlock their readers or writers before the port can be closed. Tests have been updated accordingly. Bug: 1012817 Change-Id: I0d38d7892eba52c3891f82280ccb3fb5ee65f2cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849200 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704694}
-
Robbie McElrath authored
Test: ninja -C out/aw system_webview_apk Bug: 934152 Change-Id: I54583c5c318e974b6eba1bca17e320f1f4bbf291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825580Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#704693}
-
Andrew Grieve authored
Bug: 982762 Change-Id: Ia381787192d654d21e7928afb58d461f94b6539c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851084Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#704692}
-
Kyle Horimoto authored
The PIN keyboard previously disallowed viewing a context menu (i.e., the menu shown when right-clicking). The reasoning for this change was that some users on touch screens would enter several digits, then decide they wanted to delete these digits and do so by pressing and holding the PIN keyboard's backspace button. Chrome OS would consider this a long press, which causes a context menu to be displayed. This CL fixes this issue by: (1) Moving the listener to the backspace button instead of on the entire element. (2) Editing the handler function to inspect the mouse button before blocking the context menu. In this case, button value 0 means a long press and button value 3 means a right-click. This CL ensures that the context menu is only blocked by a long press. Bug: 1004974 Change-Id: I93f60a77a8b374039f23f78561ebb73a667a905b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851044 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#704691}
-
Tao Bai authored
This patch added PageLoadMetricsObserverContentTestHarness in component, so chrome's observer unittests can be easily move to components. The main changes are - Moved PageLoadMetricsObserverTester to components - Moved PageLoadMetricsTestContentBrowserClient to separated files for sharing. - Moved use_counter_page_load_metrics_observer.cc to components to verify PageLoadMetricsObserverContentTestHarness working. - The other observers changes are renaming. Bug: 995880 Change-Id: I4f64d8c8941c586d5b44791911ddbc0606b6061c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838474Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Andrew Xu authored
The issue is introduced by my previous CL: crrev.com/c/1838993, where the shelf view notifies the parent view of icon removal at the end of fade out animation. However, when removing the app icon by gesture, fade out animation is not created. This CL fixes the issue by calling PreferredSizeChanged() explicitly under such circumstance. Bug: 1012984 Change-Id: I0bd651966b7f1a9ae82496dfe72fe2d4a02ff2ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850730 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Cr-Commit-Position: refs/heads/master@{#704689}
-
Toni Barzic authored
Minimal search results page width can be less than the max total search results tile items width - this cl makes search result tile item list view flex tile item views, and margins between items when required (with minimal in-between margins, all possible items should fit neatly into the search result tile item list). BUG=None Change-Id: I3ba6882b88d2a695f25caf2bfef38eec5e96109b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851231Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#704688}
-
Reilly Grant authored
This change employs a clever trick where rather than waiting for a new chunk to be enqueued before resolving the Promise returned by pull() we can resolve it immediately and rely on the fact that the stream will not call pull() again until a chunk has been enqueued. By not having an outstanding pull() in progress the stream is allowed to be canceled even if there is a call to read() in progress. Bug: 1012817 Change-Id: I3ae4b7ae267374acab13a55cb07b6e411bd837ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849105 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Thomas Tangl authored
... if the user is signed in. Screenshot: https://drive.google.com/open?id=1AGJJ-oRRBoCYme-Jz296Antg6rQKm0Pg Bug: 995720 Change-Id: I16da6abd99d80974d1029444dea6f529f2378440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853365Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#704686}
-
Sam Maier authored
Bug: 1012842 Change-Id: Id15489f524711aa9ca0b7192e0161ecadfe3e268 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850783Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#704685}
-
ckitagawa authored
Add ckitagawa@chromium.org to OWNERS of components/paint_preview Change-Id: I6ecdd1d6d7ef98ffba95d1536c2799b10ee35f05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853127 Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#704684}
-
Caroline Rising authored
Bug: 910739 Change-Id: Iae4fc31e8a9871426bd8e486a6c46e6c710597bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850775 Auto-Submit: Caroline Rising <corising@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#704683}
-
Jimmy Gong authored
- Updated expiry milestone for printer settings UI overhaul from M79 to M81. Bug: 1005905 Change-Id: Id8e6649a74d10ea8698a9116431ef50d208ab6fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853145 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#704682}
-
Vadym Doroshenko authored
Annotations are shown when show-autofill-type-predictions flag is on. Bug: 949519 Change-Id: Id048339d1eb56b50c6b9516f7355e35b905dc26b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847284 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#704681}
-
Raphael Kubo da Costa authored
This method is just calling its parent's implementation, so there is no need for it. Change-Id: I32bcab5f4f9af63947b3fff87fb276a321845ef5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851708 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#704680}
-
