- 23 Jan, 2020 40 commits
-
-
Finnur Thorarinsson authored
Bug: 950024, 895776, 656016 Change-Id: I7696bb02113c660069cef0c2083337625c1e0272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010771 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#734428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5c6594d..464fe259 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ieedbcaa85c11d08b602b7eedb1f3aba12f5fdc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014783Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734427}
-
Maks Orlovich authored
Many platforms (Android, Linux, Mac) have a cache directory that's outside the regular profile directory, and the cleanup code was not taking it in account. Test restored from what was accidentally dropped in https://chromium-review.googlesource.com/c/chromium/src/+/1640718 ... but only in an Android-specific version, since on other platforms *tests* will always have cache directory inside profile directory, even if regular users don't. Bug: 1040115 Change-Id: Ie635b25e40a4f76019b895d6f09f1683ede353fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992563Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#734426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e20606a24add..4ae5f4f5ce1e git log e20606a24add..4ae5f4f5ce1e --date=short --first-parent --format='%ad %ae %s' 2020-01-23 aerotwist@chromium.org [Global] Update refs to SDK.targetManager 2020-01-23 almuthanna@chromium.org Create Karma tests for CharacterIdMap and Settings 2020-01-23 aerotwist@chromium.org Fixes e2e hello world test Created with: gclient setdep -r src/third_party/devtools-frontend/src@4ae5f4f5ce1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1006759,chromium:1044632 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I21447508c90693209db93fa2f787832780de88d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015526Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734425}
-
vitaliii authored
They are not needed and get autoremoved on the server side, which impedes the reviews. Change-Id: Ie5a56e2d57946eaf09718b601dc6ddc8e75036f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015025 Commit-Queue: vitaliii <vitaliii@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#734424}
-
Finnur Thorarinsson authored
Bug: 895776, 656015 Change-Id: Ide9f2e54ea68f6f93d62bd7d2beaabb9bb7954c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015100 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. Bug: 1042208 Change-Id: Ib442aa79586586b2495dec1df11497713ee7e442 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011800 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734422}
-
Martin Šrámek authored
The "Show suggestions for similar pages when a page can't be found" setting is no longer needed as of crbug.com/1011893#c22. We will remove as a part of the next phase of the privacy settings redesign. Bug: 1032584, 1011893 Change-Id: I94c4a3747b64417ef7def0fc1d009c1a8bfccf2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007576 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#734421}
-
Ian Kilpatrick authored
Devtools had an issue where elements were sized at 0px height. This was caused by the relayout boundary logic not working correctly. In Devtools these elements had layout and size containment triggering ObjectIsRelayoutBoundary() to return true. The call to NGConstraintSpace::CreateFromLayoutObject for this flex-item was incorrect as it wasn't using the stretched size (as we don't set HasOverrideLogicalWidth(), etc). This refactors the various callers of NGConstraintSpace::CreateFromLayoutObject and create a new method UpdateInFlowBlockLayout which contains the previously (duplicated) logic. This new method will try and use the previous constraint space (if it is a layout root), instead of creating it. Bug: 845235 Change-Id: I52ddb9d58ae010305b980657bb434a30d5b7fbbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010983 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#734420}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If9a98513d2b170381ca4b9097aefbffd325a7a9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015061Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734419}
-
Alex Chau authored
Bug: 1044607 Change-Id: Ibe881eb03b538358492539af3330e79e0588944b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015047Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#734418}
-
Colin Blundell authored
After the recent change to have handling of SSL errors go through a //chrome-level wrapper that supplies embedder-level params to SSLErrorHandler::HandleSSLError(), the embedder's NetworkTimeTracker instance can be supplied via that wrapper rather than needing to be routed through SSLErrorNavigationThrottle. Bug: 1030692 Change-Id: I7bcdc5d2ea161ab289cf710df2b99b139a6a37b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014960 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#734417}
-
Olga Sharonova authored
This reverts commit c9552c88. Reason for revert: CrostiniPortForwarderTest.AddPortDuplicateFail failing on Linux Chromium OS ASan LSan Tests (1) First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36750 Failure example: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890488549187658624/+/steps/unit_tests/0/logs/Deterministic_failure:_CrostiniPortForwarderTest.AddPortDuplicateFail__status_CRASH_/0 Original change's description: > Crostini port forwarding activate and add port > > Port forwarding in Cros will allow users to add new ports and activate, > deactivate and remove existing ports. > > When any of the utilities are called, the port forwarding library will > invoke the permission broker client to change the ChromeOS port > forwarding settings. > > In future work we will also save port forwarding preferences such that a > user's preferences will persist over container shutdown. > > Bug: chromium:848127 > Test: crostini_port_forwarder_unittest.cc and everything builds > Change-Id: I9a0478f1486252fb09fab18ab3261e03d00eb480 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999972 > Reviewed-by: David Munro <davidmunro@google.com> > Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org> > Reviewed-by: Nic Hollingum <hollingum@google.com> > Commit-Queue: Matthew Chen <matterchen@google.com> > Cr-Commit-Position: refs/heads/master@{#734303} TBR=hashimoto@chromium.org,hollingum@google.com,davidmunro@google.com,matterchen@google.com Change-Id: Iabb6d856090b1f34776b547cd1b6ba652ebfb055 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:848127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015085Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#734416}
-
Rushan Suleymanov authored
SharingService has dependency on ProfileSyncService. Make SharingMessageBridge a separate service with its own factory to prevent cyclic dependency. This change does not wire the bridge to any existing service but provides the interface for creating and using it. Bug: 1034930 Change-Id: I9907eb2687e48c65b7203d1b10e6ad34ed981010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007269 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734415}
-
David Roger authored
Dice is now launched and pre-dice codepath can be removed. Bug: 891781 Change-Id: I15efa40c47b6c164f5aae521f19734390ec138a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013283 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/24627fa40a48..2439a3af02eb git log 24627fa40a48..2439a3af02eb --date=short --first-parent --format='%ad %ae %s' 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader b766e5e7fbf4..c514ab001bb0 (8 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ca9b61a4455f..aaba1e4e6aec (1 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src ac02c61ffc63..8317b28e672a (6 commits) 2020-01-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src af8c7e040f93..37d3a235af2c (2 commits) Created with: gclient setdep -r src/third_party/angle@2439a3af02eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: I3833067a4900eae31fab1261f855ef6bdec38381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016472Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/20d0f9299138..e4ddb8a7cddc git log 20d0f9299138..e4ddb8a7cddc --date=short --first-parent --format='%ad %ae %s' 2020-01-23 reed@google.com Revert "Specialize SkRectanzier to SkRectanizerSkyline" Created with: gclient setdep -r src/third_party/skia@e4ddb8a7cddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC benjaminwagner@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: benjaminwagner@google.com Change-Id: I547a89518739863aa6ca9e85ce085268899e73dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015524Reviewed-by:
-
Mathias Carlen authored
Before this patch when entering the prompt state, the sheet would always be expanded so that the buttons were visible to a user. This patch introduces a new proto field that allows this behavior to be configured from the backend. Additionally, the configure bottom sheet action is extended by a new field to expand or collapse the sheet programmatically. Bug: b/145204744 Change-Id: I9191e3e4f7b6b688d6a9dae800f730b56056b243 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004868 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#734411}
-
Colin Blundell authored
Intended to be eliminated as part of https://chromium-review.googlesource.com/c/chromium/src/+/2010943. TBR=carlosil@chromium.org Bug: 1030692 Change-Id: I16e1d357fb2652119d7075c60e0f45c69426931c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016629Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#734410}
-
Finnur Thorarinsson authored
1) Suppress FileRead violation (since the point of the test is to play a video). 2) Call dismissDialog at the end of the test to properly tear down decoder connection (no bug, found while addressing other violation). TBR: peconn Bug: 1044333, 895776 Change-Id: I9f93618be30016304770263bbbdf20431ce20950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013287 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#734409}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3df70e9c609d..e20606a24add git log 3df70e9c609d..e20606a24add --date=short --first-parent --format='%ad %ae %s' 2020-01-23 pfaffe@chromium.org Implement a Language-Specific Plugin System Created with: gclient setdep -r src/third_party/devtools-frontend/src@e20606a24add If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1042636 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic1ad7ed749dba53c5253983a046a1a22e917c298 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015522Reviewed-by:
-
Colin Blundell authored
The sending of the CAPTIVE_PORTAL_CHECK_RESULT notification is a blocker to the ongoing effort to componentize CaptivePortalService. A previous CL has introduced the ability to register for a callback with CaptivePortalService as an alternative mechanism of being informed on the results of captive portal queries. This CL converts the remaining consumers and eliminates the notification. Bug: 1030692 Change-Id: I9a2c5f6190922eb6ddb10d572dcbec6b52ffc3ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012383 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#734407}
-
Morten Stenshorne authored
Expectations changed with CL:2007629 TBR=futhark@chromium.org Bug: 1042760 Change-Id: I544455316f2e5c4fc87184a4a897c44c187bfb37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016644Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#734406}
-
Morten Stenshorne authored
Test added in CL:2003810 TBR=atotic@chromium.org Bug: 423997 Change-Id: I006328b54c9163e9185fc9f1ff7d7af8ceb0a36e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015083 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Swapnil authored
For manually installed extensions, the install location is set to INTERNAL. When it is added to the force installed list, the install location should be changed to EXTERNAL_POLICY_DOWNLOAD. This can be done by: Unloading the extension -> changing the extension install location -> Loading the extension. In case the extension is disabled by user, remove the disabled by user DISABLE_REASON as it is now required by policy. Bug: 1014123 Change-Id: I1329e62708e1ca083af1becfddf75d602dada58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911754 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#734404}
-
Morten Stenshorne authored
TBR=masonfreed@chromium.org Bug: 1035582 Change-Id: I49522593f975014a2e9936d080880668a8e19dd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015049 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Olga Sharonova authored
adjusting expectations TBR=seblalancette@chromium.org Bug: 1043450 Change-Id: I8cd670df6188c476f7c18d0a7b345cd489970418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015166Reviewed-by:
-
Colin Blundell authored
SSLErrorHandler currently checks internally whether the ability for the user to proceed past an SSL interstitial has been disabled via prefs. This pref is a //chrome-level one that WebLayer will never modify from the default behavior of allowing such proceeding. Thus, rather than componentize the pref, this CL instead passes the value of whether the user is allowed to proceed past SSL interstitials to SSLErrorHandler::HandleSSLError(), giving the boolean a default value of true so that embedders other than //chrome don't need to worry about what the default behavior should be. To avoid needing to thread this argument through SSLErrorNavigationThrottle, this CL also introduces a //chrome-level wrapper of SSLErrorHandler::HandleSSLError() that supplies //chrome-level parameters. This wrapper will be useful for a few other params, and we will change the current passing of NetworkTimeTracker to occur this way as well rather than being threaded through SSLErrorNavigationThrottle. Bug: 1030692 Change-Id: I840e97b41759e7982b6a0975570a82a9b52ed5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014504 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
Alice Wang authored
This CL renames the histogram UnifiedConsent.SyncAndGoogleServicesSettings to UnifiedConsent.MakeSearchesAndBrowsingBetter.OnStartup. Bug: 1024545 Change-Id: Id5f218e49fc433d89f2505ad16be38d00cde40be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006550Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#734400}
-
Himanshu Jaju authored
This is a reland of b23ba4d3 Reason for revert: Did not roll out internal DEPS (https://chrome-internal-review.googlesource.com/c/chrome/src-internal/+/2450652) TBR=msramek@chromium.org Original change's description: > Ice Server API integration > > Integrates network traversal API to fetch stun and turn servers for > webrtc p2p connection. Handles API failure by returning a list of > public Google stun servers as a fallback. > > Bug: 1031156 > Change-Id: I60b5d6ccdb749ce9375bcb3333dc2cbdab62aa18 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994295 > Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Reviewed-by: Richard Knoll <knollr@chromium.org> > Reviewed-by: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#733941} Bug: 1031156 Change-Id: Ib1f409842a3277b5e1f47d6511ede46361aa5fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013130 Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#734399}
-
Anton Bikineev authored
Members in stack allocated types issue redundant write-barriers. This CL provided an option --no-members-in-gc-allocated, which prohibits use of them. Bug: 1021889 Change-Id: Iae010f6a3154ba54963fafddc888b45a42b56698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015167Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#734398}
-
Jan Wilken Dörrie authored
This change updates ppapi::RunWhileLocked and ppapi::CallWhileUnlocked to use base::OnceClosure and base::OnceCallback instead of base::Closure and base::Callback. Bug: 714018 Change-Id: I7e827ecffe2baca3a681cf3e27982263c89f9f34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011927 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#734397}
-
David Roger authored
Dice is now enabled by default, there is no need to explicitly enable it. Bug: 891781 Change-Id: I2821873a1ff6d24cb34279276a9a6ab09be05e24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012032 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Koji Ishii authored
Following bot results are included. 1089 1090 1091 1092 1093 1094 1095 1096 1098 1100 41 lines were removed and 13 lines were deflaked by consecutive results since 1078. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: I5b46330b8ea78cc18996e8cb87c5ee55761cf3ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014482Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#734395}
-
Alex Danilo authored
CL:1345378 changed display of images in quickview to use the decode() API to allow the image to be decoded while the containing content node was detached from the DOM tree in order to avoid visible artifacts during decoding time. The decode() API fails when large image decodes are attempted resulting in nothing being displayed, even when those large images can be viewed from a simple <img src=...> container. Removes the use of decode() and instead, creates an Image object responsible for loading the image and uses the onload handler to reattach the content node to the DOM. Adds an onerror handler that sends an event to the host container in the case of load and/or decode failures. Note, this is in effect creating 2 images - the first is the host node in the content, the second is a temporary 'Image' object that is used to trigger the load/decode and when it's loaded the URL to the object is set on the host image node. That way, the image is already loaded so minimizes flicker when the 'src' is set, and in the error case it doesn't set the 'src' at all. (We call this the Double Image Device:) Bug: 645021, 1043799 Change-Id: Id14e01068c29d7cd373563ba20d2e13d7a4bbfe6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012368Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#734394}
-
Clemens Backes authored
The type check for "WasmModuleObject" was renamed from "IsWebAssemblyCompiledModule" to "IsWasmModuleObject" in https://crrev.com/c/2013109. This CL switches the only caller in chrome to the new API, so we can deprecate the old one. R=haraken@chromium.org Bug: v8:10021 Change-Id: Ibf4d59933ce91086eb3edd1769aae2e3da2a9368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016622Reviewed-by:
-
Colin Blundell authored
We will shortly be componentizing CaptivePortalService out of //chrome. This class depends on the Content API and should only be used on //content-based platforms, whereas the existing //components/captive_portal is shared with iOS. This CL moves the existing component into a layered component structure in anticipation of imminently moving CaptivePortalService and friends into a //content subdirectory. There are no functional changes here; it is a strict code move. TBR=jochen@chromium.org Bug: 1030692 Change-Id: Id231098e56b5c3f28c921c0082918fdf669ebeac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010982 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a0e6361d160f..313d98ee7b49 Created with: gclient setdep -r src-internal@313d98ee7b49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1c738d66209d0c9850f069c12284795e4bee32f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016470Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#734391}
-
Sylvain Defresne authored
Instead of forward declaring ChromeBrowserState in the ios namespace, use a header. This will allow moving the class to the global namespace without having to change all the forward declaration at the same time. This CL was uploaded by git cl split. R=erikchen@chromium.org Bug: 1042208 Change-Id: I9148cc5a2f2ecdfa4d081e27470660b22604f431 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007640 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#734390}
-
Olga Sharonova authored
This reverts commit b2a8b8b0. Reason for revert: Suspected root cause of All/TabletModeControllerTest.* failures on Linux ChromiumOS MSan Tests Example build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17429 Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8890504197399106784/+/steps/ash_unittests/0/logs/Deterministic_failure:_All__x2f_TabletModeControllerTest.DisplayDisconnectionDuringOverview__x2f_0__status_CRASH_/0 First build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/17428 Original change's description: > Fix the occasional black flash when fling an ARC window to home screen. > > Previous CL https://chromium-review.googlesource.com/c/chromium/src/+/1967804 > doesn't fix the issue entirely. Looking deeper in this issue, it's > actually caused by ClientControlledShellSurface::UpdateBackdrop() can be > called on a dragged window (whose backdrop has been disabled (kDisabled) > when drag starts) to re-enable the backdrop. > > This CL makes sure an ARC window with disabled backdrop mode won't be > modified. > > Bug: 1027269 > Change-Id: I4d138ddf17bbcee2ab07e1a5fb9785fc05b3fc0c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981133 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> > Commit-Queue: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#734250} TBR=sky@chromium.org,oshima@chromium.org,xdai@chromium.org,afakhry@chromium.org Change-Id: Iec4b80f5689c72ea9e73a8051b81f640a6e21fef No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1027269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016643Reviewed-by:
-
