GitLab

BUG=71975


Review URL: https://chromiumcodereview.appspot.com/10831194

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150557 0039d316-1c4b-4281-b951-d872f2087c98

We need to call release() on the scoped_refptr, otherwise it will
destroy the underlying object.

BUG=141041
TEST=used macbook to navigate to page using device orientation and didn't crash


Review URL: https://chromiumcodereview.appspot.com/10825245

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150556 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150555 0039d316-1c4b-4281-b951-d872f2087c98

Control: http://codereview.chromium.org/10830214/
Review URL: https://chromiumcodereview.appspot.com/10828207

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150554 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org
TBR=ben@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10826162

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150553 0039d316-1c4b-4281-b951-d872f2087c98

Sensitive requests are not usually signaled to extension event handlers
via events like onBeforeRequest.
This is checked by WebRequestPermissions::HideRequest(request).
However, a request might become sensitive after redirect. In that case
it could have been signaled via, e.g., onBeforeRequest, but not any more
via onErrorOcurred or onCompleted.
This causes problems (see BUG for more discussion).

This patch changes the processing of onErrorOccurred and onCompleted so
that even sensitive requests are signaled if they were signaled before.
This is a safe change, because onErrorOccurred and onCompleted handlers
cannot modify the request.

BUG=139982
TEST=Use the extension attached to BUG to log starts and ends of requests. Go to http://goo.gl/fKDKJ which redirects to a sensitive https://chrome.google.com/webstore, and observe that request's start and end being signaled. In general, every request's start and end should be signaled.


Review URL: https://chromiumcodereview.appspot.com/10837164

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150552 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150549 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824211
broke win build

TBR=reed@google.com
Review URL: https://chromiumcodereview.appspot.com/10823231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150548 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150546 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10824211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150545 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141273


Review URL: https://chromiumcodereview.appspot.com/10829234

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150544 0039d316-1c4b-4281-b951-d872f2087c98

Add a layer of abstraction between the |state| db field and DownloadItem::DownloadState. This will actually prevent the same problem from happening again when I reland http://codereview.chromium.org/10704026/

TBR=sky@chromium.org
BUG=140687

Review URL: https://chromiumcodereview.appspot.com/10823203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150542 0039d316-1c4b-4281-b951-d872f2087c98

The "Better Session Restore" features have been on by default for quite a while,
and there are no known problems.

This CL removes the effects of --disable-restore-session-state but keeps the
flag and the about:flags flag in place. New experimental features are ready to be
enabled by default, and this flag will be used again to disable them.

BUG=116947


Review URL: https://chromiumcodereview.appspot.com/10855022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150541 0039d316-1c4b-4281-b951-d872f2087c98

It broke unit tests on Chrome OS.

BUG=None
TBR=pneubeck@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10829235

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150540 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150538 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:27206
TEST=See included tests.


Review URL: https://chromiumcodereview.appspot.com/10827050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150536 0039d316-1c4b-4281-b951-d872f2087c98

* Boot time animation decreased from 2s to 1s (for both OOBE / normal boot).
* WebUI is initialized in hidden state in parallel with wallpaper animation.
* Using EASE_OUT instead of LINEAR for boot animation.

BUG=141150

Review URL: https://chromiumcodereview.appspot.com/10824203

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=no crash when opening "All cookies and site data" in a debug build
TBR=thakis@chromium.org - we should move those files to browsing_data/


Review URL: https://chromiumcodereview.appspot.com/10823225

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150534 0039d316-1c4b-4281-b951-d872f2087c98

- when commiting a main frame load (non fragment/history state), cancel old iframes
- when a cross process navigation is cancelled, send error events for that RVH

Also in this CL
- don't incorrectly set client_redirect on history state updates

BUG=139117
TEST=ExtensionApiTest.WebNavigationCrossProcess


Review URL: https://chromiumcodereview.appspot.com/10823169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150533 0039d316-1c4b-4281-b951-d872f2087c98

TBR=estade@chromium.org
BUG=140910
TEST=Manual


Review URL: https://chromiumcodereview.appspot.com/10830210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150531 0039d316-1c4b-4281-b951-d872f2087c98

See e.g. https://bugs.webkit.org/show_bug.cgi?id=78746#c29

BUG=none
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10855024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150530 0039d316-1c4b-4281-b951-d872f2087c98

Update third_party/mach_override from https://github.com/rentzsch/mach_star/mach_override to include the fix for building Chromium on 64 bits.

BUG=138535

Review URL: https://chromiumcodereview.appspot.com/10834127

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150529 0039d316-1c4b-4281-b951-d872f2087c98

BUG=123758


Review URL: https://chromiumcodereview.appspot.com/10824104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150528 0039d316-1c4b-4281-b951-d872f2087c98

Pref values are provided to the settings UI code by three different
classes. Each decorates the values slightly differently, adding
different metadata fields or none at all. This CL makes the classes
use a consistent decoration with identically named metadata fields,
simplifying the handling of pref values on the JS side.

BUG=104955


Review URL: https://chromiumcodereview.appspot.com/10834109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150527 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150524 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824215

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150523 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150522 0039d316-1c4b-4281-b951-d872f2087c98

Background: We plan to Add ReadDirectoryByPath() to GDataDirectoryService
and use the same ReadDirectoryCallback, and hide_hosted_documents  turned
out to be an obstacle. It's cleaner to check the setting in the caller,
where this setting matters anyway.

BUG=141147
TEST=confirm that the "show hosted documents" setting works as before

Review URL: https://chromiumcodereview.appspot.com/10836137

TBR=satorux@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10830211

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150520 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:85687
R=joaodasilva@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10855045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150519 0039d316-1c4b-4281-b951-d872f2087c98

For full access to Drive, we need less restrictive scope.
https://www.googleapis.com/auth/drive.file only allows accessing files
which is created on its own (i.e. Chrome), which is useless for
file browser purpose. Instead, we have to use
https://www.googleapis.com/auth/drive scope.

BUG=chromium:127728
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10832201

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150518 0039d316-1c4b-4281-b951-d872f2087c98

PendingCreateICRequest is no longer necessary because the libibus dependent code is gone, just state flag is fine.
In addition to this, PendingCreateICRequest cause memory leak if the response from ibus-daemon is lost.

BUG=134717,135049
TEST=ran ui_unittests and manually check on lumpy.

Review URL: https://chromiumcodereview.appspot.com/10834175

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150517 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
BUG=141255
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10825241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150516 0039d316-1c4b-4281-b951-d872f2087c98

Allows developers to explicitly specify what accept types they would like to allow in their file selectors, as well as whether they allow all files as a last option.

BUG=133066
TEST=Test cases, manual testing

Review URL: https://chromiumcodereview.appspot.com/10692105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150515 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150514 0039d316-1c4b-4281-b951-d872f2087c98

TBR=fmalita@chromium.org


Review URL: https://chromiumcodereview.appspot.com/10855043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150513 0039d316-1c4b-4281-b951-d872f2087c98

The isSuggestionsPageEnabled flag will be deprecated/be reassigned to suggestions coming from user history.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150512 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
BUG=141255
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10854035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150511 0039d316-1c4b-4281-b951-d872f2087c98

TBR=vandebo@chromium.org
BUG=141322
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10829232

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150510 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson@chromium.org
BUG=141255
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10828206

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150509 0039d316-1c4b-4281-b951-d872f2087c98