- 24 Jun, 2020 40 commits
-
-
Charlie Hu authored
Using |DefaultHash<mojom::blink::DocumentPolicyFeature>| to substitute |IntHash<mojom::blink::DocumentPolicyFeature>| fixes the timeout issue in release build. Note: Although |DefaultHash<mojom::blink::DocumentPolicyFeature>| is defined in document_policy_feature.mojom-blink-forward.h, its hash impl |blink_mojom_internal_DocumentPolicyFeature_DataHashFn| is defined in document_policy_feature.mojom-blink.h. Include forward.h is not enough for DefaultHash to be used as HashTrait. Bug: 1069021 Change-Id: Ia267c2de06f8fbc787e471103fcccc8ce861b1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264854Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Charlie Hu <chenleihu@google.com> Cr-Commit-Position: refs/heads/master@{#782020}
-
Jimmy Gong authored
- Status text was missing a set width, resulting in its column overlapping the "Date" column. Screenshot: https://screenshot.googleplex.com/kct7u0vDHPw Bug: 1055841 Change-Id: I9d251867a48dbacddaf7e2a0d036390c0edae751 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264498 Commit-Queue: jimmy gong <jimmyxgong@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: jimmy gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#782019}
-
Juan Mojica authored
Bug: 1098431 Change-Id: I59d6d61731c4eb515ee1bc648adf7c8607133f65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261258 Auto-Submit: Juan Mojica <juanmojica@google.com> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#782018}
-
Moe Ahmadi authored
crrev.com/c/2206222 broke this behavior by making the outer <div> focusable and preventing the inner <button> to which the click handler is attached to from gaining focus. This CL restores the original behavior by attaching the handlers to the outer focusable container. It also simplifies the a11y setup by making the outer container a real button and the inner container an unfocusable div. Bug: 1095549 Change-Id: Iacc1d5f673545cd25cc93965463d57d7447a7ff3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264801 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Auto-Submit: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#782017}
-
Mohamed Amir Yosef authored
This is a follow up to crrev.com/c/2254319 By using the layout constants instead of the hard coded values. For the combobox, this however affects only Mac The reason for that is on Mac both config.icons_in_label and type_ == Type::kCheckbox evaluated to true. while on Linux both were false. Screenshots: Before: https://screenshot.googleplex.com/YC96zjVu2Cx After: https://screenshot.googleplex.com/Uusea7yG6wd Bug: 1044038 Change-Id: I20ee4e2aa416e0405df7a660e419b2b3a01e16e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264335Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#782016}
-
Taylor Brandstetter authored
The underlying data channel always returns true on sending, asynchronously invoking a callback to notify that the message was sent, so there's no reason not to call it asynchronously at the blink level. This will make the main thread more responsive. Bug: webrtc:11547 Change-Id: I8a8fd518bf25d14242561501a3b05c614be0a3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255317 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#782015}
-
Matt Menke authored
It previously had no logic to evict unexpired entries, but we'll be keying it on NIK soon, which will potentially blow up the number of entries. To avoid this causing issues, either with memory usage, disk usage, or load time, we need to add such logic. Bug: 1091496 Change-Id: Ifa875726dfa36e1796a78c5e7ceac41cef7953af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240031 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#782014}
-
Lei Zhang authored
Now that this function exists, there is no need to reinvent it. Bug: 1009837 Change-Id: I2980378d90d7c2f7440caec519d532d3656ee569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261696Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#782013}
-
Haiyang Pan authored
Bug: 1098111, 997376 Change-Id: Ie7a98821799cb45e0db94cd4e1aa61fb064066b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261693Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#782012}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1592999982-db22937bc7e305fa743bdb260ed4ee93f882ca20.profdata to chrome-mac-master-1593021431-7b0ea0cd42ff146f154f99cb6b34c129710780a4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: liaoyuke@google.com,jeffyoon@google.com Change-Id: Ia94664cb2170f6f73d63338f6df5b7bbe1cd1a7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264850Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782011}
-
Anastasia Helfinstein authored
Instead of doing nothing if the focus ring manager hasn't yet been initialized, initialize it. Fixes a bug where there's no focus ring when the feature is enabled. TBR=dtseng@chromium.org AX-Relnotes: n/a. Bug: None Change-Id: I5cb3c4f7e837b5d0c6ffbdd969fc4594b9359b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264880Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#782010}
-
Chong Gu authored
Switch from headless ozone to scenic for viz_unittests. Bug: 865172 Change-Id: I1103b27b5e9285ad90612e6597b35b5c2bab0d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258360 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782009}
-
Sky Malice authored
Will be disabled when either SDK is <= M, or when run on an emulator. These are the configurations we're currently seeing flakes on. Bug: 1095535 Change-Id: I16aca30f1535cfafc706fe10932b42dcbebc50d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255125Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#782008}
-
Eric Lawrence authored
Previously, failing to invoke an external protocol handler ('foo://bar') would fail silently if the protocol was not registered or if the user gesture requirement was not met. This limitation made it difficult for web developers to troubleshoot such situations. This CL emits errors to the Developer Tools console when the protocol handler is not registered, is forbidden, or is temporarily blocked pending a user-gesture. Similarly, if an external handler is launched, an informational log entry is added. Bug: 1096610 Change-Id: Ie562d0c030f138f7e5ac0a09576ba73a79de3971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252848Reviewed-by:Matt Giuca <mgiuca@chromium.org> Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782007}
-
Asanka Herath authored
These settings are directly controlled via feature flags and field trials. On the browser, they are used to filter out surfaces that should be excluded from the study. Such exclusions are meant as a privacy measure. On the renderer, they are used to prevent specific surfaces from being sampled in the first place. Such an exclusion is meant as a granular kill switch to account for unforeseen adverse effects of the act of sampling a surface. Browser-side filtering of reported data cannot address such issues. Directory layout including per-directory division of responsibilities is now described in //docs/privacy_budget_code_locations.md. Bug: 973801 Change-Id: Id0ba366a4f5625a59d5b40031d80764d3584a892 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232892Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#782006}
-
Tibor Goldschwendt authored
Logging for dark image doodles works identical to light image doodles but with different logging URLs. + Remove DoodleLogging feature flag. Doodle logging is enabled since a long time and there is other code that assumes doodle logging is enabled. Bug: 688960 Change-Id: If825a29abb8e23c11fa837cac4fd7288e0107fa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262057 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#782005}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/external/github.com/videolan/dav1d.git/+log/54f92068caa2..47daa4df3387 $ git log 54f92068c..47daa4df3 --date=short --no-merges --format='%ad %ae %s' 2020-06-22 rsbultje Accumulate leb128 value using uint64_t as intermediate type Created with: roll-dep src/third_party/dav1d/libdav1d R=dalecurtis@chromium.org,tguilbert@chromium.org Bug: 1098714 Change-Id: Ie5ae97d3979ba5873d2f24b39eb2deb83cb9fbf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264798 Commit-Queue: Wan-Teh Chang <wtc@google.com> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#782004}
-
Jeremy Roman authored
This makes the origin trial functional pending the issuance of tokens. It includes a test that verifies that the default feature state is appropriate for this trial, and adjusts those defaults. Also as a consequence of this, cross-origin portals will now be disabled by default. They can be re-enabled for development purposes only via: flags: chrome://flags/#enable-portals-cross-origin or switch: --enable-features=PortalsCrossOrigin Finally, the toggling of these makes our tests a little wonky. Previously we were forcing the browser-side logic on in response to experimental web platform features, but some tests rely on cross-origin portals which probably shouldn't be on for all users with experimental web platform features. Instead these tests are moved to a virtual test suite for the time being, consistent with a number of other unlaunched features. Bug: 1040212,1093466 Change-Id: I7dd75e0e2053206368d806439eed4b6b918a1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240057 Auto-Submit: Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Lucas Gadani <lfg@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782003}
-
David Tseng authored
This reverts changes: 4fe3a6a4 Ensure AccessibilityManager::ChromeVoxDeferredLoader's warmup utterance targets Googletts 8df286c2 Moves load progress tones from js to native which were mainly workarounds for slow Google tts during the web assembly porteffort. This revert removes now unnecessary complexity around ChromeVox's load path now that text to speech is native. R=dmazzoni@chromium.org TBR=dmazzoni@chromium.org Change-Id: I8cdc9a946b1c112011aabfd3babd533aff03ed2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264193Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#782002}
-
Toni Barzic authored
When the user navigates through launcher using search + up or down, the a11y focus jumps from expand button (in app list widget) to search box view (in search box widget) using new focus override. When focus is about to move from the expand arrow to the search box, the expand arrow is announced twice - the wrapped cursor for the expand arrow node first transitions from (expand arrow node, -1 index) to (expand arrow node, 0 index), and the direct transitions are only looked up if the current and the next cursor are equal. This changes Cursor.move to keep the existing index if directional line move cannot find the next node, so wrapped cursor movement can fall-back to the node's next/prev focus. AX-Relnotes: Fix search + up/down traversal in Chrome OS launcher. BUG=1010967 Change-Id: Ib92351084350a7fcf2006441fa9e74998225354b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261992Reviewed-by:
-
David Van Cleve authored
It was changed around a month ago to be mandatory. Change-Id: I4c76887f77aee2dc62efb4c7ce034541cc96e9bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264840 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1593007185-9f44ccb8893f05162537134149388feea4a6ce51.profdata to chrome-win64-master-1593014209-7e980a1dfa67a2e51666ab74889d15022f0ab030.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I1fa97208cbe7355b5e32d27f8eca090c446dc681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264839Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I67baddf930ff8efec7cd14b7b456d905541a0630 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264624Reviewed-by:
-
Yusuf Sengul authored
Bug: 1097386 Change-Id: I2a9e634868fcda6c8acc46e482c2f6dc14bdc064 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255028 Commit-Queue: Rakesh Soma <rakeshsoma@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#781997}
-
Allen Bauer authored
views: :View - added TestMetadata test. views: :Button - added TestMetadata test. Change-Id: I7fc797f59e837d1c9eacc9004a39a882ac3afd93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2258340 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#781996}
-
Wei Li authored
Add unit tests for installable ink drop and its painter to increase the code coverage. Bug: none Change-Id: I3d987d79deb2fe8d59c6ff991e830569fca7f749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256766Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#781995}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e5f58adc98e4..a13d6a8f2b4d 2020-06-24 lalitm@google.com Merge "ui: switch cpu frequency and process scheduling to new quantization" 2020-06-24 lalitm@google.com Merge "tp: allow span join to propogate constraints on timestamps" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5ec3c03b099c4dca71264c3340798659ebf56f1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264834Reviewed-by:
-
Elly Fong-Jones authored
This is actively triaged by the dPWA team. Bug: None Change-Id: I6b68d2abe9a7ca5127be09c05bc095fa6676b5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261399 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#781993}
-
Christian Biesinger authored
This will be used to implement the CSS aspect-ratio property, so the name will no longer be ideal. Instead, name it has_aspect_ratio_without_intrinsic_size. R=atotic@chromium.org Bug: 1098475 Change-Id: I829b8460c7dae8e519c4adfdebe4fc163df5fd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261230 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#781992}
-
Chris Cunningham authored
TBR=roagarwal@chromium.org Bug: 1098751 Change-Id: I14f087795ee3d7f9729eb39bcdaf5d60216b2866 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264759Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#781991}
-
David Van Cleve authored
content::Referrer::SanitizeForRequest duplicates some relatively intricate URL-related logic that exists independently in //net. This change changes the method to be a thin wrapper around net::URLRequestJob::ComputeReferrerForPolicy, the other location that contains this logic. There's one behavior change: SanitizeForRequest no longer removes referrers for requests with non-HTTP(S) destination URLs. This makes it consistent with the other two places in Chromium where we compute referrers: net::URLRequestJob::ComputeReferrerForPolicy and blink::SecurityPolicy::GenerateReferrer. (I guess the benefit of having the same code in three places is that you can majority vote when the behavior disagrees!) R=mmenke Test: Existing tests (content_unittests, chrome:browser_tests) pass Bug: 1094526 Change-Id: I1004db373d686b877ebe492efbd200669151e789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243721 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#781990}
-
Caleb Raitto authored
The current summary references a method that doesn't exit. Bug: 973801 Change-Id: I7a0bbbb2460419dbe24d60f60d8a09af45ae80aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2174647Reviewed-by:
Asanka Herath <asanka@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#781989}
-
Adlai Holler authored
See (future) Skia CL: https://skia-review.googlesource.com/c/skia/+/298509 Bug: skia:10425 Change-Id: Ie090d0cdcc4f6aeee1a845cecf699f4e2f7bd617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261229 Auto-Submit: Adlai Holler <adlai@google.com> Commit-Queue: Adlai Holler <adlai@google.com> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#781988}
-
Nina Satragno authored
According to the spec [1], the basic constraints extension MUST have the CA component set to false for packed attestation certificates. This patch adds the basic constraints extension to attestation returned by virtual authenticators and sets CA to false. [1] https://www.w3.org/TR/webauthn/#packed-attestation-cert-requirements Fixed: 1090015 Change-Id: I780f2f2482be9c6c5168ed60df23dbf75ce2e2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264578 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#781987}
-
Chrome Cunningham authored
This reverts commit f85481f8. Reason for revert: Suspected as cause for these failures: https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3687 https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3686 Original change's description: > [base] Stop including check.h, notreached.h, etc. in logging.h > > The CHECK, CHECK_EQ etc., and NOTREACHED macros have moved out > of logging.h into separate, much cheaper to include, headers. > > Now that the code has been updated to use the new headers, and > to not rergess on that, stop including them in logging.h. > > Bug: 1031540 > Change-Id: Idfa891b991cbca1dfef93630c0f37b1b022f99df > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264413 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Auto-Submit: Hans Wennborg <hans@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781970} TBR=dcheng@chromium.org,thakis@chromium.org,hans@chromium.org Change-Id: I85745947db37577b6a584ec96b00c7409a7a0d7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1031540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264631Reviewed-by:
-
Elly Fong-Jones authored
This reverts commit c2864a25. Reason for revert: android-archive-rel failed to compile. [99345/99951] ACTION //chrome/test/android:chrome_java_test_webapk_launch_tests__test_apk__apk__java__validate_classpath(//build/toolchain/android:android_clang_arm) FAILED: obj/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk__java__validate_classpath.bytecode.stamp /b/s/w/ir/cipd_bin_packages/cpython/bin/python ../../build/android/gyp/bytecode_processor.py --script bin/helper/bytecode_processor --gn-target=//chrome/test/android:chrome_java_test_webapk_launch_tests__test_apk__apk__java --input-jar obj/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk.javac.jar --stamp obj/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk__java__validate_classpath.bytecode.stamp --direct-classpath-jars=@FileArg\(gen/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk.build_config:javac:classpath\) --full-classpath-jars=@FileArg\(gen/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk.build_config:deps_info:javac_full_classpath\) --full-classpath-gn-targets=@FileArg\(gen/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk.build_config:deps_info:javac_full_classpath_targets\) --sdk-classpath-jars=@FileArg\(gen/chrome/test/android/chrome_java_test_webapk_launch_tests__test_apk__apk.build_config:android:sdk_jars\) ============================= Dependency Checks Failed ============================= Target: //chrome/test/android:chrome_java_test_webapk_launch_tests__test_apk__apk__java Direct classpath is incomplete. To fix, add deps on: * //components/webapk/android/libs/client:java * org.chromium.components.webapk.lib.client.WebApkValidator (needed by org.chromium.chrome.test.pagecontroller.tests.webapk.MapsGoFirstRunTest) Traceback (most recent call last): File "../../build/android/gyp/bytecode_processor.py", line 67, in <module> sys.exit(main(sys.argv)) File "../../build/android/gyp/bytecode_processor.py", line 60, in main subprocess.check_call(cmd) File "/b/s/w/ir/cipd_bin_packages/cpython/lib/python2.7/subprocess.py", line 190, in check_call raise CalledProcessError(retcode, cmd) Original change's description: > WebLayer: share directly to WebApk as appropriate > > This matches the external intent handling in Chrome, where a WebApk is > opened without a chooser dialog when it's the only non-browser handler > for an intent. > > WebApkValidator, WebApkVerifySignature, and some constants are moved > to //components/webapk in a directory and build target structure that > mirrors //chrome/android/webapk, i.e. separate "client" and "common" > libraries. > > Bug: 1063874 > Change-Id: I55fb0968489a4a919bb383b182413e913091a020 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254350 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781934} TBR=blundell@chromium.org,estade@chromium.org,pkotwicz@chromium.org Change-Id: I6fbf1d01595d65d5fa107216af840c0906e288fb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1063874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264459Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#781985}
-
Tibor Goldschwendt authored
Implements the latest UX spec for boxed doodles. See crbug/1032312 for details. Bug: 688960 Change-Id: I03898db33822a19412d88c33414644a470e28c1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261722 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#781984}
-
Jae Hoon Kim authored
It's possible now to handle concurrent installation requests for the same DLC ID, this can be extended to any concurrent DLC requests as soon as platform dlcservice can batch/queue installation requests. This also simplifies the complex "holder" pattern used previously and allows for it to scale once platform dlcservice starts batching/queueing installation requests. Bug: 1095715, 1052183 Test: ./out/Default/unit_tests Change-Id: Id4e8dc025537d7e8fe81333cfefc09c349513829 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261480 Auto-Submit: Jae Hoon Kim <kimjae@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#781983}
-
Robbie McElrath authored
Bug: 1085553 Change-Id: I899f426dcde936b2c8d4443e657f7a6378576477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261699Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#781982}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5704cdf5e9b580da65a8829e168259a9414382d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264197Reviewed-by:
-
