- 16 Sep, 2019 40 commits
-
-
John Rummell authored
With the new Widevine CDM, support for AV1 has been added, so add AV1 to the list of codecs supported by Widevine on Linux and ChromeOS devices. Other OSes will get AV1 support from the manifest included with Widevine. Bug: 953504 Test: enabled browser_tests pass Change-Id: I33764dda1239c0ac4578d7ba09604fc59f2d1e79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802834 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#696973}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/c2da3ad9993b..542b7933970d git log c2da3ad9993b..542b7933970d --date=short --no-merges --format='%ad %ae %s' 2019-09-16 thestig@chromium.org Disable embedder tests that fail when Skia is enabled. 2019-09-16 thestig@chromium.org Disable embedder tests that fail when Skia or Skia Paths is enabled. 2019-09-16 thestig@chromium.org Change pdfium_test to show Skia build option. 2019-09-16 thestig@chromium.org Disable BarcodeTest when Skia or Skia Paths is enabled. 2019-09-16 thestig@chromium.org Delete dead CPDF_PageObject/CPDF_Path code. 2019-09-16 thestig@chromium.org Avoid some unnecessary copying in CPDF_TextPage. 2019-09-16 nigi@chromium.org [SkiaPaths] Avoid overlapping when drawing text. Created with: gclient setdep -r src/third_party/pdfium@542b7933970d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: I02e52076d90726ec153f7a67c9b67338d8452f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806420Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696972}
-
Nick Harper authored
The code that logged to these histograms was deleted in 2017, but I forgot to mark them as obsolete in histograms.xml. Change-Id: Idbca14571c01f0c81a76478d8967dd7f18bb61c4 Bug: 736978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802709 Auto-Submit: Nick Harper <nharper@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#696971}
-
Aran Gilman authored
Bug: 1002664 Change-Id: If9515337d146721919edb3add59d205f1786d6a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795999 Commit-Queue: Aran Gilman <gilmanmh@google.com> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#696970}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/497d3d907b45..09feed378ddc git log 497d3d907b45..09feed378ddc --date=short --no-merges --format='%ad %ae %s' 2019-09-16 saklein@chromium.org cros_mark_as_stable: Add auto_merge for server-side rebase. Created with: gclient setdep -r src/third_party/chromite@09feed378ddc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2274fcb8ead59a10e455643ced1832aa5fce0b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807853Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696969}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4a60db4c3e62..64d4a375c810 git log 4a60db4c3e62..64d4a375c810 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ehmaldonado@chromium.org git-cl: Return exit code of bb when executing git-cl try. Created with: gclient setdep -r src/third_party/depot_tools@64d4a375c810 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I94cb932a2063ece2f37df83bdd96ced4cb78293f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806419Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696968}
-
Tina Lu authored
This is in preparation for enforcing, via a presubmit check, that all histograms specify either their units or an associated enum. Bug: 656625 Change-Id: If7c5ed41a20acff3aa9144c1977fa3ee0acdc33e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802676Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696967}
-
Kurt Horimoto authored
HTTP auth dialogs are now presented as child view controllers. This allows for usage NonModalViewControllerPresenter, which has the durations provided by UX. Also, since the view controllers can be presented immediately, this CL also prevents the flicker from occurring when exiting the tab switcher by avoiding the asynchronicity of view controller presentation. Bug: 979030, 999960, 999962 Change-Id: I8aec7617bd4900aa05859aea514f2429b95f7d37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788513 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696966}
-
Kurt Horimoto authored
App launcher dialogs are now presented as child view controllers. This allows for usage of NonModalViewControllerPresenter, which has the durations provided by UX. Also, since the view controllers can be presented immediately, this CL also prevents the flicker from occurring when exiting the tab switcher by avoiding the asynchronicity of view controller presentation. Bug: 979030, 999960, 999962 Change-Id: I8b2c967e9cbe393f107bcfb68124ed9f214a7125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788246 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696965}
-
Nate Fischer authored
No change to logic, only docs. This expands on //android_webview/README.md, taking some content from //android_webview/docs/README.md. I'm taking this opportunity to update links to provide better context (ex. link to the package-summary rather than individual frameworks classes). The distinction between these two README files is: * //aw/README.md describes WebView overall * //aw/docs/README.md describes how to work with WebView in chromium Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I89fb481b16c1fd7258fb409c6d61989497573182 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807656Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#696964}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f5dec1c6af02..3d1647412c08 git log f5dec1c6af02..3d1647412c08 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 danilchap@webrtc.org in RtcpTransciever use lambdas with move capture. 2019-09-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1d12ff69..3cf04dec (696696:696812) 2019-09-16 danilchap@webrtc.org Delete deprecated rtc_event.h file Created with: gclient setdep -r src/third_party/webrtc@3d1647412c08 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I4511e169e65c202958e7dadfa17b15970fed5356 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696963}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I209c86526b663c5a216c1b9cebf88d2b9d41670f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807394Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696962}
-
Shakti Sahu authored
This CL removes some usages of download snack bar since essentially download infobar has replaced it for showing download progress. However there are certain failure messages that are not covered which are not exactly related to an active download. For those messages, snack bar will continue to show. Bug: 1003153 Change-Id: I97d626ca69b77cacb2bfc52390c9b1dadf49a65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799924Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#696961}
-
Kurt Horimoto authored
When dialogs are displayed from the main frame, the requesting page's URL is already visible in the location bar, so we don't need to add source information as the title. The message text is used instead. Bug: 999966 Change-Id: I6ea4f5286c2626055e0350f5746fe8968dde1dd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785013 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#696960}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d8359680722c..eb8f5aa220f6 git log d8359680722c..eb8f5aa220f6 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 mohsen@chromium.org Remove main_thread_scroll_latency metric Created with: gclient setdep -r src/third_party/catapult@eb8f5aa220f6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1000697 Change-Id: I3f741d8a4a7f00a850736814678008733aec64e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807601Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696959}
-
Avi Drissman authored
This reverts commit 2ce269f8. Reason for revert: Broke https://ci.chromium.org/p/chrome/builders/ci/android_arm64-builder-perf util.build_utils.CalledProcessError: Command failed: ( cd /b/s/w/ir/cache/builder/src/out/Release; java -jar ../../third_party/r8/lib/r8.jar --no-desugaring --no-data-resources [...] lib.java/clank/third_party/compressed_resources/LemonStandaloneRuntime.jar lib.java/clank/java/build_hooks_android_impl_java.jar ) In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizationpasses In ../../base/android/proguard/chromium_apk.flags: Ignoring option: -optimizations Item java.lang.String org.chromium.chrome.browser.gcore.ConnectedTask.getName() was not discarded. java.lang.String org.chromium.chrome.browser.gcore.ConnectedTask.getName() |- is invoked from: | void org.chromium.chrome.browser.gcore.ConnectedTask.debugLog(java.lang.String) |- is invoked from: | void org.chromium.chrome.browser.gcore.ConnectedTask.run() |- is defined in library method overridden by: | org.chromium.chrome.browser.gcore.ConnectedTask |- is reachable from: | com.google.android.apps.chrome.icing.IcingController$IcingLightweightTask |- is reachable from: | com.google.android.apps.chrome.icing.IcingController$6 |- is instantiated in: | void org.chromium.chrome.browser.gsa.ContextReporter.reportUsageOfCurrentContextIfPossible(org.chromium.chrome.browser.tab.Tab,boolean,org.chromium.chrome.browser.gsa.GSAContextDisplaySelection) |- is invoked from: | void org.chromium.chrome.browser.ChromeActivity.createContextReporterIfNeeded() |- is reachable from: | org.chromium.chrome.browser.ChromeActivity |- is referenced in keep rule: | ../../base/android/proguard/chromium_code.flags:35:1 Original change's description: > Use assumevalues instead of assumenosideffects for proguard. > > This seems to have the same meaning, however use of "return" in assumenosideffects is not working for some versions of proguard. > > Change-Id: Ie6dde7612d25c7ee5fd2d2fd42dfe74444188c41 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804064 > Reviewed-by: Sam Maier <smaier@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Commit-Queue: Eric Roman <eroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696911} TBR=eroman@chromium.org,agrieve@chromium.org,smaier@chromium.org Change-Id: Ia68d499e59e0b9e1dcda34bfa9389fa1977079b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808018Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#696958}
-
jonross authored
We were trying to have all vulkan_pixel_skia tests not fallback to software with the flag '--disable-software-compositing-fallback'. However several tests wish to explicitly run in that mode. This removes the flag from the test configuration, while looking to add it to tests which actually only want to test hardware compositing. TEST=vulkan_pixel_skia, pixel tests Bug: 984973 Change-Id: I5b54bcde0c10be874ad5fe5cd00168dfd98ba08a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795307 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#696957}
-
Yue Li authored
The cl replaces the use of webm video with lottie animation in Assistant opt-in flow. Bug: 1001713 Test: Manual Test Change-Id: I54162809464cdcb16e749dd74ec35122842f5237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804693Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#696956}
-
Alex Moshchuk authored
This CL adds two metrics, logged at ready-to-commit time: - Navigation.RequiresDedicatedProcess: whether or not the final SiteInstance picked for a navigation requires a dedicated process. - Navigation.IsLockedProcess: whether or not the process for a navigation has been locked to an origin. This will be useful to understand how many navigations are impacted by Site Isolation on Android (and other platforms). Bug: 1004371 Change-Id: I24defd60242056f01cc9ca1f68ecbfdec883fc12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807573Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#696955}
-
Wez authored
Bug: 961457 Change-Id: I2cc543e2ce0f836dfb1c7746f72270a1afa9c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630639Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Aaron Gable <agable@chromium.org> Auto-Submit: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#696954}
-
Yao Xiao authored
Currently, the NIK is not populated for <a download> request that doesn't go through the navigation path. This CL populates the NIK for that scenario. Created http://crbug/1003528 to track other cases that's not covered. Bug: 989067 Change-Id: I2c17500bba0e68cec941c961b6bc79885418a82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783305Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#696953}
-
dalyk authored
We were mistakenly using the time elapsed since a probe sequence was started when updating the RTT histogram on probe queries. This mistake affects the timeout that is set for subsequent queries (it may be far too large). The Net.DNS.DnsTransaction.SecureNotValidated.* histograms are also affected, as they are intended to record the probe query RTT rather than the cumulative sequence time. Bug: 1004439, 985589 Change-Id: I5bb2067893e2902cde1a620387524d438822ec65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804333 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#696952}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/2f0f741fd31b..191a60616c6b $ git log 2f0f741fd..191a60616 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 victorhsieh login: new DBus methods to control adb sideloading 2019-09-11 joelhockey system_api: Add seneschal share type LinuxFiles 2019-09-11 joelhockey system_api: set seneschal owners to vm_tools 2019-08-19 allenwebb system_api: Add D-Bus constants for usbguard device notifications. 2019-08-16 mcchou system_api: bluetooth: Add org.bluez.Error.InvalidArguments for GATT characteristic Created with: roll-dep src/third_party/cros_system_api TBR=juwa@google.com Change-Id: I1d86b903e13ddd02031fa4dcc29e3547cf9b1be4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806626Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#696951}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a0ba6a84..7720ac9d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia20da33f6e0435d872b7b6a8be818b778dffd0f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807653Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696950}
-
Esmael El-Moslimany authored
Change-Id: Ib08dbbb33f9277b6fd56ccabb141160981c2f601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803876 Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#696949}
-
Malay Keshav authored
The login page is a part of the OOBE screens. This means all of the OOBE screens are loaded when the login page is presented, but they are all marked hidden to not be visible to the user. Because everything is loaded, the lottie animations used for the fingerprint setup is also loaded and autoplayed. This resulted in a high CPU usage of ~30% on the login screen (nocturne). This patch removes the autoplay of the fingerprint setup animation and instead only plays it when the screen is made visible. To achieve this, the patch also adds supports for pausing and playing to the lottie player in third_party. Bug: 998991 Change-Id: I20700c9d807fc0dd4c08c1f2da66019881b15160 Tested: Manually for correctness and CPU usage. Also updated unit test Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777086Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#696948}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8f08fed925c5..b5560486ad22 git log 8f08fed925c5..b5560486ad22 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 shrekshao@google.com BaseInstance VertexAttribDivisor fix 2019-09-16 jmadill@chromium.org Vulkan: Require sampling support for attachments. Created with: gclient setdep -r src/third_party/angle@b5560486ad22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:891861 Change-Id: I931a7f67b458bfd15870145f917d416b092f5b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807443Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696947}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e73fcc9bb5dd..79e09388b11e Created with: gclient setdep -r src-internal@79e09388b11e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I8a00f58f66541edb88a57bb6e42cf7bc99beb1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807187Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696946}
-
jonross authored
Recent work has led to the majority of fast/canvas blink_web_tests to begin passing with SkiaRenderer (both GL and Vulkan) This patch expands the current test set of skia_renderer_*_blink_web_tests to include a subset of fast/canvas. Those with known failures, and another 75 randomly selected passing tests. This would expand the test count from 675 to 771. This seems to add an extra 20s to each run (Skia GL 38s-58s) (Vulkan 240s - 255s) Bug: 955450 TEST= skia_renderer_gl_blink_web_tests skia_renderer_swiftshader_blink_web_tests vulkan_native_blink_web_tests vulkan_swiftshader_blink_web_tests Change-Id: Ie0a3d766174755305d52a3fbe0555ff9f62f2678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790465Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#696945}
-
rbpotter authored
Handle cr.define() statements in files that define Polymer elements, assuming that: - There is only 1 cr.define() per file - Nothing after the cr_define_end annotation is needed (similar to js_modulizer.py). Also adding a test. Bug: 965770 Change-Id: I3e620289989653672eb735be48b2d5f712a3e7be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804692 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#696944}
-
Peter Kotwicz authored
ProcessInitializationHandler#handleDeferredStartupTasksInitialization() and WebApkUma#recordDeferredUma() call WebappRegistry#warmUpSharedPrefs() from the background thread and the UI thread respectively. Both calls occur from DeferredStartupHandler This CL changes WebappRegistry#initStorages() to mutate WebappRegistry#mStorages on the UI thread. BUG=1000949 Change-Id: I71ec4d049000d67a4052502c72da62a2ce1aadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801989 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#696943}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/765f9f266eec..cec6a1f798c4 git log 765f9f266eec..cec6a1f798c4 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 eseckler@google.com Merge "processor: Import chrome metadata / raw system traces with timestamps" Created with: gclient setdep -r src/third_party/perfetto@cec6a1f798c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ie1db65f73f07645e56a756287840a7debb84f0fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805727Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696942}
-
Ben Pastene authored
Their 3 machines were upgraded to 10.14.6 in crbug.com/1004017 TBR=ynovikov@chromium.org, kbr@chromium.org Bug: 1003183 Change-Id: I7a50fd70bb230c146729d482586bac28965bb241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807339 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#696941}
-
Matt Reynolds authored
Microsoft is expected to update the firmware for Xbox Wireless Controller (045e:02fd) to modify which field is populated with the Xbox button state. This CL modifies the gamepad standard mapping functions for this device on Linux and macOS to combine the state from the old and new fields into a single button in the remapped gamepad. BUG=1003984 Change-Id: I7d55a7d611d88930fb3efe7a8073fb4c3db19cb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804599Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#696940}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/30847688f059..7a7f630ffbad git log 30847688f059..7a7f630ffbad --date=short --no-merges --format='%ad %ae %s' 2019-09-16 srisser@google.com Fix integer overflows in ClipSrcRect Created with: gclient setdep -r src/third_party/swiftshader@7a7f630ffbad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: None Change-Id: Idcdc40859ea8b408af55d9a7d0f3a2989f8871e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807079Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#696939}
-
Ian Prest authored
Many of the UIA event tests are exhibiting a low-level of flakiness (too low to be disabled, but high enough to be noisy). These are mostly related to spurious focus events. It was determined that the logic that attempted to filter out focus events outside the frame was faulty; it was testing the "automation id", which is not necessarily unique. This has been changed to the "runtime id", which *is* unique. Bug: 928949 Change-Id: I4e1c6f820f42c796f909513b9de5bb03a711eb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804382Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Commit-Queue: Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#696938}
-
dalyk authored
There was a spurious base="true" tag on these histograms. Landing this change on ToT is sufficient. Bug: 1004409, 985589 Change-Id: I9790c88eecca045d7faf2e5bcf19e1389eb5a8d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807579Reviewed-by:
Eric Orth <ericorth@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#696937}
-
Yue Li authored
Remove the VISIBLE state and use AssistantVisibility instead. Also remove obsolete handling for AGSA animations. Bug: b/140823590 Test: Run existing tests Change-Id: Id64c5e536dfe6d3e10c9b003c135e76c96a9fee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802819 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#696936}
-
Khushal Sagar authored
R=ericrk@chromium.org Change-Id: I63db25f6e805dd644e42cc1c64f4f650c36d2812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805716 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#696935}
-
Christopher Grant authored
Change was reverted because of an lld issue with partitioned libraries in Debug builds. Original commit: f4d9d461 Revert commit: 28e5bc91 Description: - Add a new test case to exercise a native library. - Generalize the display of the result dialog for multiple test cases. - Specify a "pass" or "fail" in the results dialog text, to be parsed by the test, and also aid in manual testing (where the test activity may be spawned manually). - Component build coverage is stubbed out; it will be added once the component build places feature libs in DFMs. TBR=sorin@chromium.org,cjgrant@chromium.org,tiborg@chromium.org,fredmello@chromium.org Bug: 989646 Change-Id: I17b808e134419135d4eee307a2008d1638074bd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807071Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#696934}
-