GitLab

gl_unittests and ui_base_unittests should compile on Fuchsia now

Bug: 740608
Change-Id: Ie2a15c3ed42578a063f2f6e349b61902b9551966
Reviewed-on: https://chromium-review.googlesource.com/566993
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486568}

Currently, we only process 1 draw op when checking if a layer is solid
color, despite DisplayItemList::ShouldBeAnalyzedForSolidColor having
a cutoff of 10.

This change updates GetColorIfSolidInRect to take the number of ops to
analyze, and causes RecordingSource::DetermineIfSolidColor to use a
value of 10 for full-layer checks.

R=vmpstr
Bug:741219

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Id4b2a72994835d096ed0f4aad24deb663e90d459
Reviewed-on: https://chromium-review.googlesource.com/567554
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Vladimir Levin <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486567}

[CrOS Tether] Create PersistentHostScanCache, which persists host scan results to user prefs so that they can be accessed after the in-memory cache object has been deleted.

This is the first step of persisting host scan results so that we can recover from crashes. Steps listed below:
(1) Create a HostScanCache interface and move the concrete implementation to MasterHostScanCache.
(2 - this CL) Create a HostScanCache implementation which persists cache entries to user prefs.
(3) Move code which adds entries in the network stack to another HostScanCache implementation, and have MasterHostScanCache manage the other two HostScanCache implementations.

Bug: 672263, 737273
Change-Id: If4bd22df02e0c2eea577a738c16c0657465e4bde
Reviewed-on: https://chromium-review.googlesource.com/568172
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486566}

These will be used in new implementation of NTLMv2 and
consolidate the ad hoc buffer manipulation in the new and existing code.

Additionally useful as helpers for generating/validating data for
unit tests.

BUG=chromium:22532
TEST=builds and tests pass

Review-Url: https://codereview.chromium.org/2879353002
Cr-Commit-Position: refs/heads/master@{#486565}

Failing flakily on KitKat Tablet Tester.

TBR=hartmanng@chromium.org

Bug: 742430
Change-Id: Ideccbdb16ae9e5d8e9a25e44cbc07102b21076f1
Reviewed-on: https://chromium-review.googlesource.com/570186Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486564}

Bug: 741924
Change-Id: Ifd3355657a30a0e40d73517fbf79dca41d992512
Reviewed-on: https://chromium-review.googlesource.com/568716
Commit-Queue: Devdeep Ray <devdeepray@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486563}

BUG=717560

Review-Url: https://codereview.chromium.org/2900823002
Cr-Commit-Position: refs/heads/master@{#486562}

changes:
For fullscreen app list:
(1) Fix on the first all apps page, cannot drag to group apps into
folder. Fix is in AppsGridView::GetNearestTileIndexForPoint().
(2) enable more AppsGridViewTests because of (1).

Bug: 735702
TEST: covered by tests
Change-Id: I8a10cc68dd9564ebd9f8df676046b750254facfe
Reviewed-on: https://chromium-review.googlesource.com/567634
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486561}

This reverts commit 377951a2 and re-lands
4053f7ad, after fixing the issues that
led it to be reverted :).

R=machenbach@chromium.org
TBR=kbr@chromium.org, martiniss@chromium.org
BUG=662541

Change-Id: I7cfb2837736d7ca86c2cbda5cee109c6797e59bb
Reviewed-on: https://chromium-review.googlesource.com/569444Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486560}

- Copies the remaining methods in console-test.js into ConsoleTestRunner.js and adds JsDocs
- Migrates a console test (will delete original in f/u CL).

This will be followed-up by migrating batches of console test.

BUG=667560

Review-Url: https://codereview.chromium.org/2975523002
Cr-Commit-Position: refs/heads/master@{#486559}

This will make multiple sessions in TargetHandler easier to handle.

BUG=590878

Review-Url: https://codereview.chromium.org/2969753002
Cr-Commit-Position: refs/heads/master@{#486558}

The htmlcssguide.xml page explicitly says it's old and to use
htmlcssguide.html now.

The external javascriptguide.xml guide is still around, but it's
the old one now.  Internally, the javascript.xml page redirects
to the new markdown jsguide.html page.  Update our links.

Change-Id: I3113b366f7621982acf4111eadd18a294e362f06
Reviewed-on: https://chromium-review.googlesource.com/569412Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486557}

chrome-native: is a scheme used for placeholder navigations that allow
UIs to be drawn with platform native widgets instead of HTML. The scheme
should be treated as 'secure' because they entirely in the browser, so
there is no danger of manipulation or eavesdropping by third parties,
and we do not wish to trigger the Non Secure warnings that are landing
with the HTTPBad Phase 2 feature.

BUG=734581
TEST=unit_tests --gtest_filter=ChromeContentClientTest.AdditionalSchemes

Change-Id: I8ccddfae8d06b2035099e3e7b13ac237d81464ef
Reviewed-on: https://chromium-review.googlesource.com/570538Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486556}

Revert of [tracing] Add heap profiler perftests. (patchset #3 id:40001 of https://codereview.chromium.org/2976843002/ )

Reason for revert:
This broke Win 64:
https://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20Builder%20%28dbg%29&number=56316

Original issue's description:
> [tracing] Add heap profiler perftests.
>
> This CL creates a generic place for heap profiler perftests, and adds
> couple of stack frame deduplicator related perftests.
>
> BUG=739378
>
> Review-Url: https://codereview.chromium.org/2976843002
> Cr-Commit-Position: refs/heads/master@{#486544}
> Committed: https://chromium.googlesource.com/chromium/src/+/f43d398eac5c9d4c2bccda6d2630d108bbed1c99

TBR=primiano@chromium.org,dskiba@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=739378

Review-Url: https://codereview.chromium.org/2981833002
Cr-Commit-Position: refs/heads/master@{#486555}

Bug: 
Change-Id: I0360b904c54ae5fc0c42a9df46e41bfd5fb3f92b
Reviewed-on: https://chromium-review.googlesource.com/561876Reviewed-by: Florin Malita <fmalita@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Mike Reed <reed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486554}

With this CL, we leverage cc's animation curves, keyframes, etc. We do
however have to write a simplified player since animation management
logic in cc::AnimationPlayer is still cc-specific. The hope is that
this will ultimately move under gfx/.

Bug: 738644
Change-Id: I701b3035a50f356c789fc43633a4bf30d1c74354
Reviewed-on: https://chromium-review.googlesource.com/569258
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486553}

Reverted in: I95987e7b32ee2e057d731aa9593dd7601fa4fa06

Reason for reland: Guard the JNI registration with ENABLE_VR

Change-Id: I18e46b8504f3befafe833c48339a0dc6d1b7a664

TBR=bshe@chromium.org,mthiesse@chromium.org

Change-Id: I18e46b8504f3befafe833c48339a0dc6d1b7a664
Reviewed-on: https://chromium-review.googlesource.com/570270
Commit-Queue: Yipeng Wang <yipengw@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486552}

Bug: 723069
Change-Id: Ic029206b64001406858de8a18efeeec8d7c289c9
Reviewed-on: https://chromium-review.googlesource.com/571042Reviewed-by: Samuel Huang <huangs@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486551}

to calculated converter

Currently, converter for enum generate a list of
switch case statements. This is inefficient so we generate
the conversion with mathematical op to reduce the amount of switch
case statement because more switch case statement means longer runtime
and larger binary size.
Gen diff: https://gist.github.com/nguyen-minh-duc/166720ffe3821202093ef00ea83dd028/revisions
The graph represent the runtime of the switch case function (blue line) and the matops 
function (orange line). As we can see as the number of of case statement increase the
runtime increase linearly but the matops function is constant. So changing the switch 
case statement into math operation does generate a gain in runtime.

Graph: https://drive.google.com/a/google.com/file/d/0B-Uw1D6S_sSVN1FwUFVoaXA5NEk/view?usp=sharing
Bug: 
Change-Id: I4a68dd5e7f35c4879a75245b87409b44b11f1e78
Reviewed-on: https://chromium-review.googlesource.com/564903
Commit-Queue: Minh-Duc Nguyen <nmduc@google.com>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486550}

Adds the ability to run VR instrumentation tests with the DON flow enabled.
This is done by marking the test in question with the
RESTRICTION_TYPE_DON_ENABLED restriction and passing the --don-enabled flag
to the test runner.

Most of the time, we want the DON flow to be skipped so that we can actually
enter VR during automated testing. However, in some cases, we want to make sure
that we aren't doing things while the DON flow is active, which requires it to
be enabled.

Also adds one test that uses this and enables it on our FYI bot.

Bug: 737619
Change-Id: Ia20192065ace1f746a1bcdfcc503266b4330ee44
Reviewed-on: https://chromium-review.googlesource.com/567768Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486549}

These benchmarks have been failing for a long time, and we will be making new
benchmarks instead of reviving these.

Bug: 717218
Change-Id: I5bb6b81eb912e53141a25da25680a62648ace3df
Reviewed-on: https://chromium-review.googlesource.com/570483Reviewed-by: Walter Korman <wkorman@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#486548}

Presentations have the sandboxed-top-level-navigation-browsing-context-flag set [1],
so they should not be able to start top-level navigations that cross documents.

This patch allows this navigation policy to be enforced for offscreen tabs that
are started as presentations.

A companion change in Blink, https://chromium-review.googlesource.com/c/540498,
sets the appropriate flags on the Document for the presentation; this adds
additional enforcement in the WebContents layer.

[1] https://www.w3.org/TR/html51/browsers.html#sandboxed-top-level-navigation-browsing-context-flag

Bug: 697526
Change-Id: Ic1f797b408df82c226d6023966afe2f972d6d159
Reviewed-on: https://chromium-review.googlesource.com/538975
Commit-Queue: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486547}

Bug: None
Change-Id: Ie24bfa53b494775cd6c3f140a6e5655086c37b6c
Reviewed-on: https://chromium-review.googlesource.com/570190Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486546}

Call RegisterApp from OnAppWindowAdded (for single- and multi-profile).
Remove workarounds and comments for configuration differences.
Fix a test that was expecting broken/contradictory behavior...

Bug: 730876, 557406
Test: No behavior changes with extension window shelf icons.
Change-Id: Ifbfd64a6f107f0f651c8cc2c4d6bfa362f50c04c
Reviewed-on: https://chromium-review.googlesource.com/569260Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486545}

This CL creates a generic place for heap profiler perftests, and adds
couple of stack frame deduplicator related perftests.

BUG=739378

Review-Url: https://codereview.chromium.org/2976843002
Cr-Commit-Position: refs/heads/master@{#486544}

Because the registration of BluetoothAdvertisements is asynchronous,
it is possible for the object which registered it (in this case,
a BleAdvertiser::IndividualAdvertisement) to have been destroyed by
the time the BluetoothAdvertisement finished registering. Due to
crbug.com/741050, this results in a BluetoothAdvertisement without
an owner to unregister it eventually, leaving it permanently dangling.

This CL works around the issue (until it is resolved) by creating a
static method which is available when the registration callback
fires. If the IndividualAdvertisement is destroyed when registration
is finished, the BluetoothAdvertisement is unregistered.

Bug: 739883
Change-Id: I33f210f3bc89504ba670387460b3ffe2ba3fdcf1
Reviewed-on: https://chromium-review.googlesource.com/567561
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486543}

Bug: 
Change-Id: I2ba1fc5b7910720490710c74a3b90353c6670718
Reviewed-on: https://chromium-review.googlesource.com/570505Reviewed-by: Ken Rockot <rockot@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486542}

DomSnapshot is modified to populate NodeValue for textarea, input and option elements.

radio/checkbox and option elements are populated with a checked/selected string

BUG=546953

Review-Url: https://codereview.chromium.org/2971133002
Cr-Commit-Position: refs/heads/master@{#486541}

These currently imply monocularly rendered content which is quite
disruptive in VR. Until the UI for these requests is properly supported
in VR, we should deny them.

BUG: 728421
Change-Id: Iaeaa2c3f90d3f59667b199ee2ed850bb0bf9db4e
Reviewed-on: https://chromium-review.googlesource.com/569398
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486540}

This is the recommended way to use the new @available feature.
Also happens to work around clang-format not understanding
__attribute__.

Bug: 735328,741084
Change-Id: I3f518b23037d2cdd23a5e32c0fc3de1f865bedd0
Reviewed-on: https://chromium-review.googlesource.com/570007
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486539}

For more details, see https://goo.gl/q2GSav

Bug: chromium:720302
Change-Id: Iebdadcb48633b9c05a8a8e6af4cc1b01fac01d6d
Reviewed-on: https://chromium-review.googlesource.com/534934
Commit-Queue: Eric Holk <eholk@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486538}

Now when we move the mouse into an element while pressing the left button,
we do not update the hover states of the element. We should update hover
states of the element, which is now underneath the mouse cursor no matter
the mouse button is pressed or not.

The design doc:
https://docs.google.com/document/d/1TgqvDg8L_TkEiNjBUaz39FDgxpp5aj9ZdIWeQSanKHY/

BUG=122746

Review-Url: https://codereview.chromium.org/2965603002
Cr-Commit-Position: refs/heads/master@{#486537}

- The canonical name of the warning is now -Wunguarded-availability,
  so use that
- Remove a spurious dupe of the flag in device/gamepad which caused
  the flag to be passed twice to compiles there
- Remove a redeclaration that's no longer needed

Bug: 735328
Change-Id: I510c7b6f6835ef971df4fb746f612fdf875edc31
Reviewed-on: https://chromium-review.googlesource.com/570741
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486536}

after a refactoring at http://crrev.com/ad6d8a9bbf9bd5e2.
As a follow-up of the refactoring, this CL inlines the alias to its users
in //components

base: :StaticAtomicSequenceNumber is an alias of base::AtomicSequenceNumber
Change-Id: Iacd76aadcfd612e6886f368b1d209e9651d1045b
Reviewed-on: https://chromium-review.googlesource.com/568199
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486535}

1. InputDeviceManager becomes a thread-local singleton instead of a global
   singleton. UI Service instantiates DeviceDataManager, which is the service-
   side implementation of InputDeviceManager, while the browser uses
   InputDeviceClient, which is the client-side implementation.

2. PlatformEventSource also becomes a thread-local singleton. This is to prevent
   ash and the browser from executing code on the UI Service's thread by
   registering PlatformEventObservers (e.g. via UserActivityDetector). In the
   futurer we may need a client-side implementation of PlatformEventSource.

3. GPU Service checks if a PowerMonitor singleton exists before creating one.
   This is temporary until GPU Service runs in a separate process from the UI
   Service. (crbug.com/609317).

BUG=722527

Review-Url: https://codereview.chromium.org/2978873002
Cr-Commit-Position: refs/heads/master@{#486534}

It is possible to font loading to fail. Such as when the peer closes during a
synchronous mojo call to load a font.

Currently this is treated as a fatal error, which leads to flaky tests.

This change updates PlatformFontLinux to instead fallback to providing the
default font in these cases. While logging the error.

TEST=mash_browser_tests

Bug: 738441
Change-Id: I2717a0fdf561be82e6d393863a0cfd13b19ae480
Reviewed-on: https://chromium-review.googlesource.com/568789Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486533}

EnumerateInputMethodEditors() is a much simpler function that does
pretty much the same thing as what ShellExtensionEnumerator is doing.

This CL creates EnumerateShellExtensions() to replace
ShellExtensionEnumerator.

In addition to the code being simpler, this doesn't leave a useless
class instance laying around when it is finished.

Bug: 690173
Cq-Include-Trybots: master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Ib0ff9dfcbc20b307666cf1f9d1f676565f8c8f25
Reviewed-on: https://chromium-review.googlesource.com/562496Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486532}

TBR=scheib@chromium.org

Change-Id: I1fadaab55044a9a6dbf4717d189cd5168dd851cb
Reviewed-on: https://chromium-review.googlesource.com/571079Reviewed-by: Vincent Scheib <scheib@chromium.org>
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486531}

This will allow to pass any parameter to the test binary. For example
it's useful to pass --gtest-list-tests to get list of tests in the
binary.

Change-Id: I32ffb2e35df621a3fc6f6d8518cde8f744a599f3
Reviewed-on: https://chromium-review.googlesource.com/568600
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486530}

This reverts commit 5657b403.

Reason for revert: Telemetry test flakes, see: crbug.com/742039

Original change's description:
> Remove LayerImpl dependency from LayerTreeImpl::DidUpdateScrollOffset
> 
> This patch removes the LayerImpl references from DidUpdateScrollOffset.
> Instead of looking up scroll and transform property nodes with Layers,
> ElementId is used.
> 
> The invariant now used in LayerTreeImpl::DidUpdateScrollOffset (and
> Layer::UpdateScrollOffset) is that a scroll node should exist or the tree
> should be marked as needing a rebuild which will update the scroll node;
> there should be no other codepaths that update scroll offset. A TODO
> has been added to require that a scroll node exists in all cases.
> 
> Tests have been modified to ensure property trees exist before updating
> scroll offset. This should be true in all real cases but is not for
> synthetic testing scenarios.
> 
> A bug has been fixed in UpdateScrollChildPosition where the scroll layer
> was not actually scrollable.
> 
> Bug: 
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Change-Id: I75d881a0c05a6fd81ae028bdaead9481641d201f
> Reviewed-on: https://chromium-review.googlesource.com/560584
> Commit-Queue: Philip Rogers <pdr@chromium.org>
> Reviewed-by: enne <enne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#485335}

TBR=pdr@chromium.org,enne@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 742039
Change-Id: Idd87e6af6a88a3b033864310134b8a379316ab9e
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/570698Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486529}