GitLab

https://webrtc.googlesource.com/src.git/+log/096d016accb0..3e4c77f1c128


git log 096d016accb0..3e4c77f1c128 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 alessiob@webrtc.org Fix AGC2 fixed-adaptive gain controllers order.


Created with:
  gclient setdep -r src/third_party/webrtc@3e4c77f1c128

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I1f260f4564e8750cedc6dacbc5d1451d8b9fcb74
Reviewed-on: https://chromium-review.googlesource.com/c/1313629Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604782}

Change-Id: Ib2200678698b6ed7c2a7cc22390ff3df58227add
Reviewed-on: https://chromium-review.googlesource.com/c/1313557
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604781}

- Update string
- fix text not centering on small screens.

Bug: 900378
Change-Id: Iad5640c486974c1e515df9f2519e828098d900da
Reviewed-on: https://chromium-review.googlesource.com/c/1308909
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604780}

This is part of a reverted CL crrev.com/c/1300993, this is the part
that had caused flakiness on MSAN.

Change EntryList |updateSubDirectories| method to read its content
using FS API, which turns it into async. EntryList is used by MyFiles
so Downloads folder appearance is delayed comparing to previous
approach. Some tests expected Downloads to be readily available then
they become flaky, crrev.com/c/1313709 fixes this for most tests.

Fix unittest that started failing because it metadataModel was null.

Bug: 899664, 889511
Change-Id: If7cf4dea331938cb5919ef4a0ebaa73afaa2ec20
Reviewed-on: https://chromium-review.googlesource.com/c/1313711Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604779}

Metric collection was missing in OnFinishEnrollmentFailure.

Bug: 870138
Change-Id: Ia10d63753f7732257b1e7195d117fa4725ba1542
Reviewed-on: https://chromium-review.googlesource.com/c/1313754Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604778}

This is what we already do in the internal version

Merge internal change: 219706088

R=rch@chromium.org

Change-Id: I6dec6e90cd0022fd1047551b7aa7fd4b939c9d7b
Reviewed-on: https://chromium-review.googlesource.com/c/1313333Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604777}

This serves as documentation on how to trigger a stale preview page and
checks for the regression in the attached bug.

Bug: 898570
Change-Id: I17475d4e0f39021507f2365836e6d7955c4f7fd1
Reviewed-on: https://chromium-review.googlesource.com/c/1313744Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604776}

Flush is necessary for GLRenderer but not SkiaRenderer. So make it optional.

Bug: 897838
Change-Id: I96df913b7afd1fb6bf84314e3bd7ee0ed25ac497
Reviewed-on: https://chromium-review.googlesource.com/c/1312298Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Xing Xu <xing.xu@intel.com>
Cr-Commit-Position: refs/heads/master@{#604775}

Bug: 891212
Change-Id: Ib4026c1e896ec188cab54c4e30c8ac2f8eb6b98f
Reviewed-on: https://chromium-review.googlesource.com/c/1305496Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604774}

The logic in PreviewsHints::CreateFromConfig() has been modified so that
it now strips out optimizations that are disabled and only allows one of
each optimization type within a PageHint. Duplicate types encountered
are also stripped. This makes it so that enabling an experimental
optimization will automatically disable a subsequent optimization of the
same optimization type in the same PageHint. If all optimizations for a
page hint are stripped, then the page hint is also stripped.

This fixes a bug related to disabled page hint optimizations being
usable, as the disabled optimizations will no longer exist in the
hint cache.

As a result of this change, when the total page hints with resource
hints exceeds the cap, the number of page hints added will always
exactly match the cap. This is due to the logic for stripping hints
allowing us to add hints that only include some of their page hints.

A DCHECK has been added verifying that non-resource loading hint
optimizations never contain resource loading hints.

Additionally, the description of |whitelisted_optimizations| for the
PageHint proto has been updated to match expectations that it will be
provided as an ordered list.

Unittests have been added to verify that the stripping is handled
properly and that the number of page hints allowed stops exactly at the
cap. Some issues with unittests in PreviewsOptimizationGuideUnittest
using InitializeMultipleResourceLoadingHints() have also been fixed.

Bug: 900725, 900733
Change-Id: Ic8d8ce2de98e4e2993cab994906c3b2e43c31a22
Reviewed-on: https://chromium-review.googlesource.com/c/1311796Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Jered Gray <jegray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604773}

Remove more dead code.

Bug: 812085
Change-Id: I1ba634e3fb41d61511736dc7c057a5bbc5903c78
Reviewed-on: https://chromium-review.googlesource.com/c/1300315
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604772}

This is based on Yiming's CL here: https://chromium-review.googlesource.com/c/chromium/src/+/1241756
The idea is to store the autofill profile data in each test recipe at record time,
then load the data from the recipe when testing. This makes recording the tests
less fragile, and running the tests more self-contained.

Note that, as per Yiming, validateField still takes explicit information as to
what to validate, because websites may do some formatting on the autofilled data,
so a profile field such as "2018" might be validated as "18".

Bug: 881096
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia87e4d3ee0419264a3f37c18f6e19ee7ae5d6bf3
Reviewed-on: https://chromium-review.googlesource.com/c/1257855
Commit-Queue: ericale <ericale@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604771}

Avoid a call to CreatesNewFormattingContext() in the common case
and avoid a useless addref/release.

Change-Id: Ibda986a22c5f30d710ea3088b57afb2104207262
Reviewed-on: https://chromium-review.googlesource.com/c/1310475
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604770}

Bug: 895633
Change-Id: I6ce9829dedf5af302cce660d9d8bc09f7d63af39
Reviewed-on: https://chromium-review.googlesource.com/c/1313075Reviewed-by: Scott Chen <scottchen@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604769}

This is part of a reverted CL crrev.com/c/1300993, but this is the safe
part of it. I don't expect this to cause flakiness.

Change updateSubDirectories:
- use arrow function and const;
- change error callback calling style to match the same style used by
success callback (without if).
- change check from isFakeEntry to check for presence of the method
that's used "createReader".

Change the sorting to be an method, so it can be customized per
sub-class, later it will be used to sort My files to show Linux and Play
files at the bottom.

No changes in behaviour for users.

Change-Id: Ie8542464a360b5ed1970183dc888003119b423a9
Reviewed-on: https://chromium-review.googlesource.com/c/1313710
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604768}

Uses the GUARDED_BY annotation for the field we have protected by a
base::Lock in the VR browser test code.

As a result, switches all lock acquiring to AutoLock since the
annotation doesn't currently work with manually acquiring and
releasing.

Bug: 901136
Change-Id: I62b7726ca4ad56778b0354436a8f6d84f47fe86b
Reviewed-on: https://chromium-review.googlesource.com/c/1313752Reviewed-by: Bill Orr <billorr@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604767}

This adds an assignment that was removed in
http://crrev.com/f8c5470dd7bfe253825cce3272a1bbba913190dd

Bug: 901170
Change-Id: I43135804d2f0f6bee8ae3038cfc7682ccbfd7552
Reviewed-on: https://chromium-review.googlesource.com/c/1313337
Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604766}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/669b0a7d9028..73b23f5ede8f


Created with:
  gclient setdep -r src-internal@73b23f5ede8f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I977384d2909f6dfb8154b53fed3fe3c16f6ebcd3
Reviewed-on: https://chromium-review.googlesource.com/c/1313555Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604765}

https://skia.googlesource.com/skia.git/+log/21d4b4c50dbe..6c3879dcec38


git log 21d4b4c50dbe..6c3879dcec38 --date=short --no-merges --format='%ad %ae %s'
2018-11-01 csmartdalton@google.com ccpr: Age out path cache entries
2018-11-01 mtklein@google.com limit range of surface sizes in surface_image_unity
2018-11-01 michaelludwig@google.com Switch to postConcat from preConcat


Created with:
  gclient setdep -r src/third_party/skia@6c3879dcec38

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=herb@chromium.org

Change-Id: I4c5a3cc51029937d829e1e4caa7d7eeb4ca96e77
Reviewed-on: https://chromium-review.googlesource.com/c/1313688Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604764}

Add support for the --isolated-script-test-repeat,
--isolated-script-test-launcher-retry-limit and
--isolated-script-test-also-run-disabled-tests flags, and unit
tests for these flags' behavior.

Bug: 894258
Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I82cf1638779719b55b8b016c323100de572aae46
Reviewed-on: https://chromium-review.googlesource.com/c/1306662
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604763}

Also updated the old macro to use UMA_HISTOGRAM_CUSTOM_MICROSECONDS_TIMES

Bug: 894043
Change-Id: I334db198f48bfdad135525639f4bdd9b0ecbc8f6
Reviewed-on: https://chromium-review.googlesource.com/c/1289730
Commit-Queue: David Quiroz Marin <davidqu@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604762}

This patch updates line_location.js to support deciphering paths that fall
under Google Drive > Computers.

Adds an integration test which ensures that Computers entries can be navigated,
which has the side effect of also testing that the breadcrumbs are working as
breadcrumbs are used to work out where the navigation has actually navigated to.

Bug: 884020
Change-Id: I8ea14eb6716a5060005442e65d07125b41a9c4a3
Reviewed-on: https://chromium-review.googlesource.com/c/1312178
Commit-Queue: Stuart Langley <slangley@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604761}

If the name string of the service worker script or a service worker
client is too long, this patch restricts its width and denote the
overflow with ellipsis. Users can still get the string by hovering
above it, and the string is still clickable.

Bug: 847801
Change-Id: I9d3a07c410af6bb98ae42046894ea3d7223afcbc
Reviewed-on: https://chromium-review.googlesource.com/c/1312973
Commit-Queue: Haihong Li (Harley) <hhli@chromium.org>
Reviewed-by: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604760}

Locally modify Polymer 2 to exclude dir-mixin.html, since it is unnecessary
currently (we don't directly* use any :dir() CSS rules), and also causes a
performance regression (more notice-able in chrome://md-user-manager), due to a
Regex running over a fairly large amount of text (because of inlined PNG background
images).

*The only usage of :dir() was in paper-input-container.html, which is still used
by ChromeOS <gaia-input> element. Modified <paper-input-container> to directly
use :host-context instead. Also :dir() is not implemented in Chrome, so we should
not be using it in our own code anyway.

Ideally the usage of this mixin should be exposed as a Polymer option, so that
we don't need to manually modify our local Polymer 2 copy.

Bug: 899603
Change-Id: Ia20535fb2adb2c9a6bebf3046e4405a4ca31af6c
Reviewed-on: https://chromium-review.googlesource.com/c/1306515Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604759}

ViewsV2 eschews InputConnection in favor of using Scenic for delivering
input events to applications.

This adds input event handling for pointer and touch events via
ScenicSession.

Keyboard events are already being delivered by the ImeService and
are handled by InputMethodKeyboardControllerFuchsia, so no changes are
needed for receiving keyboard inputs.

      "tiles --input_path=new" switches.

Test: manual test against both "tiles --input_path=old" and
Bug: 900428
Change-Id: I8ba2e0c7d35d0dd9d52ef54379d6d693bd9e82d5
Reviewed-on: https://chromium-review.googlesource.com/c/1308910
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604758}

This CL moves the call to Init Previews into ProfileManager alongside
similar calls.

Bug: 896001
Change-Id: If1bcecd73b9b5cab9f4ec101bd1e0e09867dba28
Reviewed-on: https://chromium-review.googlesource.com/c/1308990Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604757}

https://chromium-review.googlesource.com/c/chromium/src/+/1278226
attempted to fix these, but there was still an issue because
last_upload_finish_time_ was being set to TimeTicks() instead of
Now().

Bug: 894909
Change-Id: Ibacc8755e53ed6a67fa0ba5a52cea1f281f32c36
Reviewed-on: https://chromium-review.googlesource.com/c/1310639Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604756}

conformance/rendering/gl-scissor-fbo-test.html
Flaky also in Release (Vulkan Win Nvidia passthrough)
deqp/data/gles2/shaders/swizzles.html
Fail (Vulkan Win Nvidia passthrough debug)

conformance2/textures/image_bitmap_from_video/*
Flaky on Linux Nvidia GL passthrough

TBR=kbr@chromium.org

Bug: 766918, angleproject:2939, angleproject:2940
Change-Id: I608b5a25275db953d8d2e0d2ac2fc5343caa64f0
Reviewed-on: https://chromium-review.googlesource.com/c/1313287Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604755}

Bug: 896865
Change-Id: Ide1f9ae86533d5f2c6296da8b77e35c08d8a264e
Reviewed-on: https://chromium-review.googlesource.com/c/1289675
Commit-Queue: Carlos IL <carlosil@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604754}

- Fixes issue where switching wifi networks while starting Mdns
  HostLocator would crash chrome.

Bug: chromium:900779
Test: end to end
Change-Id: Ide5e1bb53961dcd654aedadbffc6cf2a83c5d998
Reviewed-on: https://chromium-review.googlesource.com/c/1313331Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604753}

Bug: b/116166191
Test: Manual Test
Change-Id: Ia9270ce57d2fd4c2b1f563612c892877ee08e251
Reviewed-on: https://chromium-review.googlesource.com/c/1310913
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604752}

Bug=internal 117626741

Test=locally disable widevine and build on atv.

Change-Id: Ic30c773b8c37d6f2ef500dea0bb3ed2a3e94714b
Reviewed-on: https://chromium-review.googlesource.com/c/1308763Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Ziyang Cheng <ziyangch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604751}

The page had gotten badly out of date. This CL rewrites most
of it to reflect current policy and practice and stops pointing
to viewvc for other links ;)

Change-Id: I62cc952a6f56954af723f4d57b2fadfd84227bda
Reviewed-on: https://chromium-review.googlesource.com/c/1298650
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604750}

Changed DevTools SystemInfo.GetProcessInfo() process type from enum to string.

Change-Id: I7831d6b3fd9a4d2a1feb8aa4c4541d3f86c91a85
Reviewed-on: https://chromium-review.googlesource.com/c/1312117Reviewed-by: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Peter Kvitek <kvitekp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604749}

In this CL, four FeatureParams were added.

These 2 are added for "os_win && google_chrome_build" when
kNuxOnboardingFeature is enabled:

kNuxOnboardingNewUserModules
kNuxOnboardingReturningUserModules

And 2 more are added for when the feature is force-enabled with
kNuxOnboardingForceEnabled on other platforms/non-branded build:

kNuxOnboardingForceEnabledNewUserModules
kNuxOnboardingForceEnabledReturningUserModules

Sample command line to test the changes:

./out/gn/chrome --user-data-dir=/tmp/debug_chrome_1 \
    --enable-features="NuxOnboardingForceEnabled<study" \
    --force-fieldtrials=study/g1 \
    --force-fieldtrial-params=study.g1:new-user-modules/nux-google-apps/returning-user-modules/nux-email

TBR=mpearson@chromium.org

Bug: 874153
Change-Id: I495e6492ee66ce20ec8bfad8743d20c9c55acf53
Reviewed-on: https://chromium-review.googlesource.com/c/1311659
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604748}

This reverts commit 19b1b85c.

Reason for revert: breaks mac-dbg build

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-dbg/1574

In file included from ../../remoting/host/remoting_me2me_host.cc:15:
In file included from ../../base/bind.h:10:
In file included from ../../base/bind_internal.h:13:
In file included from ../../base/callback_internal.h:14:
In file included from ../../base/memory/ref_counted.h:16:
../../base/logging.h:786:26: error: comparison of integers of different signs: 'const unsigned int' and 'const int' [-Werror,-Wsign-compare]
DEFINE_CHECK_OP_IMPL(NE, !=)
~~~~~~~~~~~~~~~~~~~~~~~~~^~~
../../base/logging.h:774:33: note: expanded from macro 'DEFINE_CHECK_OP_IMPL'
    if (ANALYZER_ASSUME_TRUE(v1 op v2))                                      \
                             ~~ ^  ~~
../../base/logging.h:338:36: note: expanded from macro 'ANALYZER_ASSUME_TRUE'
#define ANALYZER_ASSUME_TRUE(arg) (arg)
                                   ^~~
../../remoting/host/remoting_me2me_host.cc:1576:3: note: in instantiation of function template specialization 'logging::CheckNEImpl<unsigned int, int>' requested here
  DCHECK_NE(getuid(), 0);
  ^
../../base/logging.h:960:31: note: expanded from macro 'DCHECK_NE'
#define DCHECK_NE(val1, val2) DCHECK_OP(NE, !=, val1, val2)
                              ^
../../base/logging.h:913:18: note: expanded from macro 'DCHECK_OP'
      ::logging::Check##name##Impl((val1), (val2),                     \
                 ^
<scratch space>:21:1: note: expanded from here
CheckNEImpl
^
1 error generated.


Original change's description:
> [MacOs Host] Provide user with a prompt to enable input injection on Mojave
> 
> This change is required due to new security restrictions in Mojave.  We can no longer
> inject input w/o being added as an accessibility app in the security applet.
> 
> While this sounds like a usefulk speedbump, it causes remote access applications quite
> a bit of trouble:
> 1.) We don't use the restricted API until a user connects so they cannot approve remotely
> 2.) The dialog appears to only show up once (regardless of approve/deny status)
> 3.) Users connecting to a locked machine will never see the dialog
> 
> This is affecting quite a few CRD users, basically everyone who upgrades to Mojave
> will experience this one way or another.  This is the simplest fix (and easiest to merge)
> that I could think of to unblock users.  The prompt will only be shown on 10.14+ platforms
> and the request is only shown if the app has not been approved.  I'd like to look at the
> user feedback after releasing this change to see if more work is needed.
> 
> One problem I anticipate is that the dialog shown doesn't have a lot of context and it
> refers to the wrapper script (org.chromium.chromoting.me2me.sh) instead of Chrome Remote
> Desktop.  If this is confusing, we can wrap the prompt request in a dialog where we control
> the text.  My concern with checking in the feature first is that the new strings won't be
> available for merging.
> 
> Another behavior to call about this impl is that the prompt will be displayed in two instances:
> 1.) When the host is first started (choosing enable via app/website)
> 2.) When the user signs in and the host service is started
> 
> Scenario #2 will have less context but that is the only way to ask for permission for
> users who upgraded and had CRD installed previously.  The dialog is not displayed at the login
> screen (i.e. when no one is signed in).
> 
> One last note, there is no way that I can see to specify this permission in the manifest or
> set up via a script / at install time.  It requires a user action to complete.
> 
> Bug: 901021
> Change-Id: I9dd1b24b6d4d083e7e019af32a0da816f6060a86
> Reviewed-on: https://chromium-review.googlesource.com/c/1313170
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#604723}

TBR=jamiewalch@chromium.org,joedow@chromium.org

Change-Id: I7c948b26c00f6c6fc7c4e0a3ec4175dcae17e459
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 901021
Reviewed-on: https://chromium-review.googlesource.com/c/1313747Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604747}

Bug: None
Change-Id: Id27ad0db8e6749efe25aca72d74e023cf9267ac1
Reviewed-on: https://chromium-review.googlesource.com/c/1308083Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604746}

EventGenerator::PressTouch would set |is_touch_down_| of aura::Env to
be true. And aura::Env is singleton and shared by test cases. So in CL,
AshTestBase::SetUp is modified to reset aura::Env's properties.

Bug: 586514
Change-Id: Iea96d7fcfc2fba1db857e0d8fe7a1931300cf0cd
Reviewed-on: https://chromium-review.googlesource.com/c/1293174Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604745}

The map to ContentRule is exclusively owned by
ChromeContentRulesRegistry, and it doesn't seem like there
is any necessity of ref-counting it via linked_ptr.

Make the map own these through unique_ptrs.

Bug: None
Change-Id: Ie55c9cce94b34c18bdad089c78f50c49d6df0658
Reviewed-on: https://chromium-review.googlesource.com/c/1306792Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604744}

This CL adds an ellipsis(...) before each of the subsequent tail
suggestions in the Omnibox tail suggestion list.

Bug: 726769
Change-Id: Ifba11bb5aca8474ee4a37dca652c9f9c676980c5
Reviewed-on: https://chromium-review.googlesource.com/c/1297726
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604743}