- 28 Apr, 2017 40 commits
-
-
eugenebut authored
BUG=583682 Review-Url: https://codereview.chromium.org/2852673002 Cr-Commit-Position: refs/heads/master@{#467949}
-
peconn authored
Revert "Revert of
📺 Move fullscreen web content to a new Activity. (patchset #11 id:200001 of https://codereview.chromium.org/2807663002/ )" This reverts commit d0f88cff. TBR=bauerb@chromium.org BUG=709042 Review-Url: https://codereview.chromium.org/2847823005 Cr-Commit-Position: refs/heads/master@{#467948} -
olivierrobin authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2808873002 Cr-Commit-Position: refs/heads/master@{#467947}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:static_cast changed to __bridge cast. BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2819283004 Cr-Commit-Position: refs/heads/master@{#467946}
-
i-ts authored
System default string resouce R.string.item_is_selected with expected pattern %s is changed to %d on Samsung's 5.x devices (S4, S5, Note 3, Core Prime etc.). This small change causes String.format() to throw exception when SimpleMonthView's content description is requested (for example Accessibility/TalkBack is ON). In case of Chromium this view is used only at DatePickerDialog. The solution is to suppress this exception on 5.x devices and give fixed string to view. This fix is based on: http://stackoverflow.com/q/28618405 R=mlamouri@chromium.org, leandrogracia@chromium.org, tkent@chromium.org BUG= crbug.com/710950 Review-Url: https://codereview.chromium.org/2790423002 Cr-Commit-Position: refs/heads/master@{#467945}
-
sdefresne authored
BUG=None Review-Url: https://codereview.chromium.org/2849783002 Cr-Commit-Position: refs/heads/master@{#467944}
-
dullweber authored
BUG= Review-Url: https://codereview.chromium.org/2847663004 Cr-Commit-Position: refs/heads/master@{#467943}
-
bsazonov authored
This CL makes several minor changes to MockAccountManager: 1. Add 'Delegate' to the name, because it implements AccountManagerDelegate and should be used with AccountManagerHelper. 2. Replace 'Mock' with 'Fake' in the name. 3. Remove redundant testContext from constructor arguments. BUG=698258 Review-Url: https://codereview.chromium.org/2845113003 Cr-Commit-Position: refs/heads/master@{#467942}
-
tkent authored
It was possible to show it in media query listener. BUG=714849 Review-Url: https://codereview.chromium.org/2845273002 Cr-Commit-Position: refs/heads/master@{#467941}
-
gambard authored
Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2838213002 Cr-Commit-Position: refs/heads/master@{#467940}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f20a4f79..63f6c513 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2846173003 Cr-Commit-Position: refs/heads/master@{#467939}
-
dgozman authored
BUG=none Review-Url: https://codereview.chromium.org/2844383003 Cr-Commit-Position: refs/heads/master@{#467938}
-
sacomoto authored
BUG= Review-Url: https://codereview.chromium.org/2849493002 Cr-Commit-Position: refs/heads/master@{#467937}
-
shanmuga.m authored
Validating a qualified name should only throw InvalidCharacterError, not NamespaceError, after: https://github.com/whatwg/dom/issues/319 https://github.com/w3c/web-platform-tests/issues/5161 https://github.com/whatwg/dom/issues/423 Latest spec: https://dom.spec.whatwg.org/#validate Webkit Patch: http://trac.webkit.org/changeset/215701/webkit BUG=702077 Review-Url: https://codereview.chromium.org/2841393003 Cr-Commit-Position: refs/heads/master@{#467936}
-
dtrainor authored
Adds the IPH that points to the data saver preview infobar. This includes three main changes: - Adding support for determining which kind of infobar is showing in Java. - Hooking up the info bar show code to log an event saying it was shown. - Hooking up the info bar show code to a function which can pick (if any) a feature and string to show which will point to that infobar. BUG=710648 Review-Url: https://codereview.chromium.org/2815653003 Cr-Commit-Position: refs/heads/master@{#467935}
-
Kenichi Ishibashi authored
Before this CL we used V8PrivateProperty to avoid cyclic references between V8 and Blink. Now we have trace wrapper and DOM object can have a reference to V8 objects. Use trace wrapper for CustomEvent BUG=501866,700680 Change-Id: I9089d9cf0828bb979467cc5bd859e460847b6c28 Reviewed-on: https://chromium-review.googlesource.com/484162 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#467934}
-
jif authored
BUG=None Review-Url: https://codereview.chromium.org/2850453002 Cr-Commit-Position: refs/heads/master@{#467933}
-
apisarev authored
There is callback map in extension function dispatcher, which store pointers on callback wrappers. But it force to remember to delete wrapper after erase from map. This may lead to memory leak. To prevent it, raw pointer in map was replaced by unique_ptr (like in other callback map in same class). BUG=None R=finnur Review-Url: https://codereview.chromium.org/2850533002 Cr-Commit-Position: refs/heads/master@{#467932}
-
jianli authored
We check the content's MIME type. If it is not meant for HTML page,we route to DownloadManager. BUG=673635 Review-Url: https://codereview.chromium.org/2841823004 Cr-Commit-Position: refs/heads/master@{#467931}
-
dtrainor authored
Simple improvements to make the throttle work in a more expected way. - Calling any method to update the underlying contents of the throttle will allow the all queued updates to flush. - Calling updates infrequently will not queue. Instead we track the time since the last update and don't queue if the time has been long enough. - Hook the throttle into the JNI bridge for the Android OfflineContentProvider. BUG=715669 Review-Url: https://codereview.chromium.org/2835323005 Cr-Commit-Position: refs/heads/master@{#467930}
-
dtrainor authored
In Java persisting the ContentId required it to be a guid. This removes that dependency. Note that legacy downloads still have their own checks for requiring the id to be a guid, but if the download isn't associated with a legacy download the checks should not occur. BUG=691805 Review-Url: https://codereview.chromium.org/2843073002 Cr-Commit-Position: refs/heads/master@{#467929}
-
shanmuga.m authored
Update the comment with spec link http://www.ecma-international.org/ecma-262/6.0/#sec-arraybuffer-constructor BUG=701391 Review-Url: https://codereview.chromium.org/2847873003 Cr-Commit-Position: refs/heads/master@{#467928}
-
dgozman authored
This is a speculative attempt to fight memory regression after recent overlay refactoring. I suspect that InspectorOverlayAgent is retained either by InspectorOverlayHost or InspectorPageOverlayDelegate. This patch tries to clean them up in Dispose and ensure that nothing will be created after that point (disposed_ field). BUG=715266 Review-Url: https://codereview.chromium.org/2850623002 Cr-Commit-Position: refs/heads/master@{#467927}
-
oka authored
TEST=run_compiler BUG=636289 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2852633003 Cr-Commit-Position: refs/heads/master@{#467926}
-
jianli authored
WebContents might not be loaded in some case, i.e. tab switcher. We need to check for that. BUG=715751 Review-Url: https://codereview.chromium.org/2847863003 Cr-Commit-Position: refs/heads/master@{#467925}
-
aleksandar.stojiljkovic authored
R16_EXT is supported on desktop core profile (OSX and Linux), and via OpenGL ES 3.1 GL_EXT_texture_norm16 extension (including ANGLE on Windows). Update khronos headers to get GL_R16_EXT definition. It is not exposed through WebGL but only used internally. Brings significant performance improvement, cutting the time spent on WebGL TexImage2D from ~1.2ms to ~0.2ms - see https://crbug.com/624436. BUG=624436 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2767063002 Cr-Commit-Position: refs/heads/master@{#467924}
-
thomasanderson authored
BUG=716118 R=eugenis@chromium.org Review-Url: https://codereview.chromium.org/2851493005 Cr-Commit-Position: refs/heads/master@{#467923}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/47389137..f20a4f79 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2843173004 Cr-Commit-Position: refs/heads/master@{#467922}
-
dpranke authored
Revert of Build browser tests on all gpu release bots (patchset #1 id:1 of https://codereview.chromium.org/2841833003/ ) Reason for revert: I don't think this CL is still needed after my fix for crbug.com/714976. Original issue's description: > Build browser tests on all gpu release bots > > Work-around as browser_tests are erroneously not rebuilt properly on > gpu bots. > > BUG=chromium:714976 > TBR=kbr@chromium.org,fjhenigman@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > NOTRY=true > > Review-Url: https://codereview.chromium.org/2841833003 > Cr-Commit-Position: refs/heads/master@{#467292} > Committed: https://chromium.googlesource.com/chromium/src/+/1d0ceecfb8153cce088d62bf28d9c94c6601de91 TBR=fjhenigman@chromium.org,kbr@chromium.org,hablich@chromium.org,phajdan.jr@chromium.org,machenbach@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:714976 Review-Url: https://codereview.chromium.org/2846883004 Cr-Commit-Position: refs/heads/master@{#467921}
-
yutak authored
Peek() always takes a reference to an existing slot in a table. Therefore, Peek() does not take a nullptr_t value, since nullptr_t is not stored in the backing buffer. BUG=715430 R=tzik@chromium.org Review-Url: https://codereview.chromium.org/2844583004 Cr-Commit-Position: refs/heads/master@{#467920}
-
andypaicu authored
Intent to remove: https://groups.google.com/a/chromium.org/d/msg/Blink-dev/ZD3NWqkk-bo/1txGi7hiBgAJ Spec: https://w3c.github.io/webcrypto/Overview.html#crypto-interface BUG=641526 Review-Url: https://codereview.chromium.org/2838603002 Cr-Commit-Position: refs/heads/master@{#467919}
-
zhaobin authored
BUG=687375 Review-Url: https://codereview.chromium.org/2844103002 Cr-Commit-Position: refs/heads/master@{#467918}
-
oka authored
There were circular deps between file_manager_commands and file_manager. This change removes dependency from file_manager_commands to file_manager by extracting an interface from FileManager needed for file_manager_commands to compile. Also inlined some simple methods in FileManager, which are used only from file_manager_commands. BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2846163002 Cr-Commit-Position: refs/heads/master@{#467917}
-
calamity authored
BUG=703848 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2811643002 Cr-Commit-Position: refs/heads/master@{#467916}
-
xinghua.cao authored
CMAA will be triggered by every readPixels call, even content does not be changed or committed. BUG=535198 TEST=conformance/readinging/fbo-remains-unchanged-after-read-pixels.html Review-Url: https://codereview.chromium.org/2597933002 Cr-Commit-Position: refs/heads/master@{#467915}
-
tengs authored
This code was used in our old BLE protocol, which is now obsolete. Review-Url: https://codereview.chromium.org/2843443003 Cr-Commit-Position: refs/heads/master@{#467914}
-
wkorman authored
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2852573002 Cr-Commit-Position: refs/heads/master@{#467913}
-
oka authored
- Removed dependency from file_transfor_controller to CommandHandler by registering the needed function from FileManager to FileTransferController as a constructor parameter. - Added drop_effect_and_label to compile target. BUG=636289 TEST=run_compiler CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2830223003 Cr-Commit-Position: refs/heads/master@{#467912}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/9c9ac13a2b02..778079b344c8 $ git log 9c9ac13a2..778079b34 --date=short --no-merges --format='%ad %ae %s' 2017-04-27 cywang [shared_page_state] Fix unit test Created with: roll-dep src/third_party/catapult BUG=714803 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic1b8f579e35bc46cd6673b97b780404f11552abc Reviewed-on: https://chromium-review.googlesource.com/489669 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#467911}
-
wzang authored
Using UpdateUIState() is insufficient because it does not have the mechanism to change 'add button disabled' state back to 'not disabled'. We should explicitly call UpdateAddButtonStatus(). BUG=411618 Review-Url: https://codereview.chromium.org/2850723002 Cr-Commit-Position: refs/heads/master@{#467910}
-