- 16 Sep, 2020 40 commits
-
-
Julie Jeongeun Kim authored
This CL is a follow-up CL of converting PrintHostMsg_DidGetPrintedPagesCount to mojo [1] and it updates the type for the page number and counts with uint32_t as it couldn't have a negative value. It keeps using int for JNI and dictionary values and uses 'base::checked_cast<int>' to convert uint to int. In order to make sure that the value is in the range to cast, this change also adds the maximum limit for the page number and counts and checks the value before passing it to JNI or dictionary. Given that the previous type is int, the maximum limit is std::numeric_limits<int>::max(). [1] https://crrev.com/c/2326857 Bug: 1008939 Change-Id: I5c86514be4e7d549f888c9623136078a3b0c88c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351580Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#807307}
-
Fabrice de Gans-Riberi authored
The target is missing a dependency and cannot be built in isolation. Bug: 1127044 Change-Id: I80b53f0d499e999182a2fc4daf6e24dac721b6c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404741 Auto-Submit: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#807306}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/b189aac83132..d48ef5f7ddc8 2020-09-16 treehugger-gerrit@google.com Merge "require_root for perfetto_integrationtests." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I233027b329a9d45839f8871a049834978e65b04d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413171Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807305}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c52a95b75bb2..60b89e50eba2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC yoichio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1126981,chromium:1128306 Tbr: yoichio@google.com Change-Id: I517c5b7b926fa8aba7e36236b0e2cf3ea60445a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413170Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#807304}
-
John Lee authored
This CL adds a context menu item labeled 'Copy link to text'. The menu is behind a flag, is currently disabled and currently does nothing. This CL is to mainly get the string in first, and will be completed soon. Bug: 1105862 Change-Id: I467786eabf878165c7c9f1aab9b2eac8b6e81068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410814Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#807303}
-
Liquan (Max) Gu authored
Change: * Move part of PRImpl#initAndValidate() into CPRImpl#initAndValidate() * Since the move of initAndValidate() involves Delegate.getInvalidSslCertificateErrorMessage(), PRImpl.Delegate is moved into CPRImpl becoming CPRImpl.Delegate. * Since the move of initAndValidate() involves mPaymentOptions and mRequestShipping, etc., they are duplicated in ComponentPaymentRequestImpl. This duplication is necessary because PRImpl and CPRImpl may lose access to each other, and is without the out-of-sync issue because mPaymentOptions is final. * Since the Delegate depends on ChromeActivity, the ChromeActivity dependencies is refactored to WebContents dependencies. * Simplifies Delegate#isOffTheRecord(), Delegate#isWebContentsActive(), Delegate#getTwaPackageName() because they don't need to rely on a WebContents/ChromeActivity parameter. Bug: 1102522 Change-Id: I62bb66ff7c799020c973394102f57c33c3d0392a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401783 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#807302}
-
Antonio Gomes authored
This CL moves audio_renderer_sink_cache.h temporarily to third_party/blink/public/web/modules/media/. The declaration of its ObserveFrame() static method is also temporarily moved to audio_renderer_sink_cache_impl.h. This step corresponds to phase 2.2 in the design doc [1]. [1] https://docs.google.com/document/d/19Zk6Fv1E-6QTQ2c33rpBjDNEkzlsSKvjb3hWkvZAE80/ BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I0757c99a4c30e792ca61c9d1c8a3f8acc01aea26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412133 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#807301}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/377e748714bf..1520b4d0fe34 2020-09-15 angle-autoroll@skia-public.iam.gserviceaccount.com Roll glslang from f8a5602c5560 to 9eaa69c21c45 (3 revisions) 2020-09-15 timvp@google.com Android: Set angle_enable_commit_id=false in roll_aosp.sh If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jmadill@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jmadill@google.com Test: Test: Manual verification in AOSP checkout Change-Id: I226c0888fc80cd6355fda2c3711a423d8b5e7127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412954 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Juanmi Huertas authored
Temporarily disabling canvas fuzzer to further investigate some false positives and a time out. Bug: 1124824, 1128300, 1124812 Change-Id: Ib3a186f3695fedf86bed9f57b77c2dcd583c7e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410287 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#807299}
-
Russell Davis authored
This fixes a couple things: 1) Ensures that match counts and highlighting always appear (see https://crbug.com/1124605). Another manifestation of this issue: if you search for something, then hit ESC, then click on the page to clear the selection, then hit Cmd-F, none of the search results will be highlighted, and the text in the search bar will still indicate the previous state (e.g. "3/8"). 2) Prevents the page from scrolling if there are off-screen matches. Simply opening the find bar should never cause the page to scroll — that can be confusing and disorienting, especially when you don't want to search for whatever is prefilled (e.g. the selection, or the global pasteboard on macs). With this change, the |find_next_if_selection_matches| option added at https://chromium-review.googlesource.com/c/chromium/src/+/2181570 is no longer needed, because we no long jump to the first match when opening the find bar with a selection. But it will still be highlighted, and find-next / find-previous work just like before, so there's no loss of functionality. Bug: 1124605 Change-Id: Ib82f9103cefb84c511b9fe2e4406e97256ed5564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404277 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#807298}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I717b1cb5328dc4790dd1206d8aeb5ca2c5621e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413169Reviewed-by:
-
Robert Ma authored
so that FindIt can route the bugs correctly. Change-Id: If722f7ecd78b9eb918d2a79253e9b0d4df6be06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398723 Auto-Submit: Robert Ma <robertma@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#807296}
-
Matt Wolenetz authored
The upcoming CrossThreadMediaSourceAttachment's implementation for attachment start will not return a MediaSourceTracer, since making that work in a Member<> in multiple Oilpan heaps is incompatible with the existing synchronous behavior for StartAttachingToMediaElement(). This change instead allows the resulting tracer to be nullptr even if there was a successful attachment start. HTMLMediaElement and the underlying attachment implementation are updated to use/implement this updated method, respectively. BUG=878133 Change-Id: Iedaf0b57a08b4437f3a34279b8e9d3c1c78262a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406956 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#807295}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ae073e44336f..e4642dac6c25 2020-09-15 joedow@google.com Updating the OWNERS file for desktop capture 2020-09-15 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5aa7e239..235f7418 (807011:807145) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I3de759a72ac182acb9e0ba284bcac1c543b4046a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412966Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I9ca8d0969017148f574fe3adcb4dcc7aa3da7b7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413168Reviewed-by:
-
Josh Nohle authored
Use the certificate storage class to remove expired private certificates. Bug: b/166112705 Change-Id: I029ab2fccaa35100adf9f2e5a03b9bbd7003e00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412485Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#807292}
-
Yoichi Osato authored
This reverts commit a27166e7. Reason for revert: Suspected many extension test failure: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/91600 Original change's description: > Extensions: use preprocessing for generating rollup input > > Bug: 1128583 > Change-Id: If798fc3db54305ccbf2c795c0fae6c332ce34bbf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410352 > Commit-Queue: Rebekah Potter <rbpotter@chromium.org> > Reviewed-by: dpapad <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807199} TBR=dpapad@chromium.org,rbpotter@chromium.org Change-Id: I0ec45eec5cd962f42043eed80e0765f8e01e18c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1128583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409689Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#807291}
-
Ahmed Mehfooz authored
Bug: 1127240 Change-Id: Id8cf046b24079cb5fc64bcc79d81e390f2b64bc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412829 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#807290}
-
Matt Wolenetz authored
This change drops two unnecessary methods from the MediaSourceAttachment interface: 1) As of r680382, HTMLMediaElement no longer needs the Oilpan/GarbageCollected TimeRanges version of Buffered() from the MediaSource API. Rather, it constructs its own TimeRanges when needed by consulting the underlying WebTimeRanges produced by BufferedInternal. 2) Also, when creating the core attachment interface and removing the core MediaSource interface, the duration() method was unnecessarily included in the attachment. Even before this MSE-in-Workers feature work, duration notification updates (where the media element is notified that the underlying MSE resource's duration has changed) did not involve this method. This change also includes some minor clean-ups of the modules/mediasource attachment includes. BUG=878133 Change-Id: I125f9db2bf1383c2eafb312225e3f843371a744f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402169 Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
-
Patrick Noland authored
This CL adds a OneshotSupplier interface and implementation. This allows for dependencies to express that they're only supplied once, and for dependent objects to avoid extra bookkeeping that handling changing dependencies requires, e.g. un-registering observers at destruction time. Bug: 1084528 Change-Id: I16a9036a49b117292c2673e29cb92aa97009eccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321067 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#807288}
-
Roman Arora authored
Bug: 1099917 Change-Id: I7e1f6a3eb3a90cf097839cf76778043c3adb2338 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388711 Commit-Queue: Roman Arora <romanarora@chromium.org> Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#807287}
-
Josh Nohle authored
We add the following methods to certificate storage: 1) UpdatePrivateCertificate(): Replaces the private certificate that has same ID; no-op if a certificate with that ID doesn't exist. This is necessary to update the private certificate's list of consumed salts that changes every time its metadata key is encrypted. This will be used in a follow-up CL. 2) RemoveExpiredPrivateCertificates(): Deletes all certificates with a not-after time later than the current time. This action is currently being performed by the certificate manager, but we want to move the logic to the storage class in a follow-up CL. 3) ClearPrivateCertificatesOfVisibility(): Deletes all private certificates of a given visibility. This is necessary for removing only the relevant certificates when contacts change; currently, all certificates are being cleared when the allowlist changes or the contact list changes. This will be used in a follow-up CL. We also implement most private-certificate methods in the base class so that they can also be used by the fake implementation. Bug: b/166473931, b/168022980, b/166112705, 1123134, 1121443 Change-Id: If3e873383e2289047200123939302e85587f441f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412479Reviewed-by:
-
John Palmer authored
Bug: 1111135 Change-Id: I740d8247b9770392cebc48ba434de775bbc9199a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412113 Commit-Queue: John Palmer <jopalmer@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Auto-Submit: John Palmer <jopalmer@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#807285}
-
Fergus Dall authored
This is a reland of e1df5c80 Original change's description: > Remove all references to StartVmConcierge > > With CL:2398353 debugd will no longer control the lifetime of > concierge. Instead, concierge will start on the login screen and stop > on session exit. Therefore, all references to starting and stopping > concierge in the chrome browser should be removed. > > Bug: 1126268 > Change-Id: Icc4ec0f1e893c0bf226613163a6e5f07f17054dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402858 > Commit-Queue: Fergus Dall <sidereal@google.com> > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > Reviewed-by: Joel Hockey <joelhockey@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806837} TBR=achuith@chromium.org,hidehiko@chromium.org,dominickn@chromium.org,joelhockey@chromium.org Bug: 1126268 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome,chromeos-kevin-chrome,chromeos-betty-pi-arc-chrome Change-Id: I247dc0f92b9f962c9598f772c1307d41a7a55ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410100 Commit-Queue: Fergus Dall <sidereal@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#807284}
-
Ben Pastene authored
Should fix presubmit warnings. R=dpranke Change-Id: I767511e997d23a4a43e1dc2e25be567fca804c5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412895Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#807283}
-
Yoichi Osato authored
This reverts commit 11c26e5e. Reason for revert: Compile failure: https://ci.chromium.org/p/chrome/builders/ci/mac-chrome/8170 I think this is a combination with https://chromium-review.googlesource.com/c/chromium/src/+/2410311 Original change's description: > Change the mac builder default to be either 10.13 or 10.15. > > Once the hosts are all upgraded to 10.15 we will remove the 10.13 option. > > Bug: 1121185 > Change-Id: I3177749f79ddd16b9d725693f21e79ebd752c22c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412757 > Commit-Queue: Erik Staab <estaab@chromium.org> > Auto-Submit: Erik Staab <estaab@chromium.org> > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807218} TBR=estaab@chromium.org,gbeaty@chromium.org Change-Id: Ic2d2b94ee254856e6fcacf88eb3bfe6eb7d04c2f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1121185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409723Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f01e83f96b0..0063ad80f210 2020-09-15 johnchen@chromium.org [Catapult] Fix links in README.md. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: zhanliang@google.com Change-Id: I32aad8bd9e09cc06d1ad75d01e755518d9e25a54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412962Reviewed-by:
-
Jeremie Boulic authored
ConvertPathToArcUrl rewrites file paths into URLs that can be resolved from ARC++. Tested manually that: - a .pdf file located within a ZIP file mounted with fuse-zip can be opened with an Android app (Adobe Acrobat). - The 'Share' button is functional. - Similar test for RAR files mounted with rar2fs. Bug: 912236 Test: Manual test mentioned above Change-Id: I62cdf2feee4ec535f579d470f0909c6593144c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411987Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#807280}
-
Jimmy Gong authored
Bug: 1106937 Change-Id: Ic2d5bf232dee7c12e3a207140b0824fc4c389fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407076 Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#807279}
-
Haiyang Pan authored
This reverts commit 37dea4b3. Reason for revert: Likely caused the test failure of DownloadTest#testDuplicateHttpPostDownload_Cancel__UseDownloadOfflineContentProviderEnabled in android builders since: * https://ci.chromium.org/p/chromium/builders/ci/android-marshmallow-x86-rel-non-cq/52 * https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester/26965 Original change's description: > Update message in permission dialog overlay warning > > The current overlay warning message does not directly address the > typical case: when dialer or chat bubble is displayed on the screen. > > One change in behavior is that "Cancel" button of overlay warning dialog > dismisses both overlay warning and permission dialog. > > BUG=1127455 > R=twellington@chromium.org > > Change-Id: I9d5c13a6c7d4e52a3fa73b3193d1ef463272ab64 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406148 > Reviewed-by: Theresa <twellington@chromium.org> > Reviewed-by: Andy Paicu <andypaicu@chromium.org> > Commit-Queue: Pavel Yatsuk <pavely@chromium.org> > Cr-Commit-Position: refs/heads/master@{#807089} TBR=pavely@chromium.org,twellington@chromium.org,andypaicu@chromium.org Change-Id: I6ebee34a6bb6383b7ff58782608b81d0ec6d5cbb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412836Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#807278}
-
Ken Rockot authored
All typemap files have been converted to inlined GN target configuration. This removes all support for aggregating .typemap files at buildgen time and any associated build logic needed to process those files. Fixed: 1059389 Change-Id: Iabf8b8680d3bd9c9e310830c36a01c1c8ca5c389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408274 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#807277}
-
Max Curran authored
These new classes will eventually be used to log UKM and UMA metrics related to Translate at the end of each page load. For now the classes are just skeletons with the key timings added. Design Doc with more details: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit Bug: 1114868 Change-Id: Ie03b807124b8cf0d44f22665978c67bfd51a4e72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360499 Commit-Queue: Max Curran <curranmax@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Auto-Submit: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#807276}
-
Haiyang Pan authored
This moves 3 shards from content_browsertests to network_service_out_of_process_content_browsertests which hopefully can mitigate the timeout issue for the latter test suite Bug: 1119314 Change-Id: Ia2d2ea767840ce9effa941886c55882b5a371b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411473 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
benjamin joyce <bjoyce@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#807275}
-
Chris Lu authored
Bug: 1107489 Change-Id: I10117e30eaf019fec202b05958af17b38133cdf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412786 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#807274}
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: NetworkComponentsNetworkProxyTest* Change-Id: I500d1455da3ecfcb3c53c8477db539eb353e88b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412969 Commit-Queue: James Hawkins <jhawkins@chromium.org> Reviewed-by:
-
chrome://multidevice-internalsRegan Hsu authored
Allows user to input fake PhoneHub notification data, and for notifications to eventually display via FakeNotificationManager. User can send, update, delete, and view a list of notifications. This CL also cleans up some of the other phonehub forms in chrome://multidevice-internals. Screenshots: https://screenshot.googleplex.com/9XNVYwEeAQUZeWG Disabled Send button https://screenshot.googleplex.com/4nz5PaMH8bfLbdR Enabled Send button https://screenshot.googleplex.com/AUsqtxMgJwMwHBs Sent notification https://screenshot.googleplex.com/5nCmMZW6xcviatK Updated! UI https://screenshot.googleplex.com/3fnNdKZcFDCWgcL Multiple notifications https://screenshot.googleplex.com/86y2Mqa2C8AmZSP Unique id & inline id Bug: 1106937 Change-Id: Ie5aecd70a03b6e84aa8745a2ece421e0d8086970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411546 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
-
Robert Ma authored
base.Port has some constants that need to be updated when e.g. concrete ports get new versions, which is easy to forget. Add unit tests to catch this and fix two existing issues (a typo and a missing version). Change-Id: I17dba9c47b8cc7fd345ccf104a482265f5ae0ae7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412368 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#807271}
-
Ken Rockot authored
The typemap configurations are merged into their respective mojom target definitions. Bug: 1059389 Change-Id: Id6822c500f9257fb2288f83d8173653a35474538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408272 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#807270}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7e0dbae74fcd..c52a95b75bb2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC davidbienvenu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: davidbienvenu@google.com Change-Id: Iafd23551befb8e41b44c08d79684e229e1fc7d7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412958Reviewed-by:
-
Dirk Pranke authored
The `resource_sizes_lacros_chrome` entry in //testing/buildbot/gn_isolate_map.pyl added a `script` parameter, which is no longer legal. Unfortunately, this is only checked when the target is actually used, which means that we didn't notice the problem for a few days because no one was looking at that bot over the weekend. Bug: 1128390 NoTry: true Change-Id: I079c1f3c5c81ae6ea8ae5600ce7ef9c30ac4f461 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410290 Commit-Queue: Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#807268}
-
