1. 19 Oct, 2020 40 commits
    • Lei Zhang's avatar
      Change PrefService::GetPreferenceValues() to return base::Value. · fc0abb9b
      Lei Zhang authored
      Update callers and remove deprecated base::Value API usage along the
      way.
      
      Bug: 1012811
      Change-Id: Ic2094c106538cf547cb69bfecdab976e6a095674
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478683Reviewed-by: default avatarDominic Battré <battre@chromium.org>
      Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
      Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
      Commit-Queue: Lei Zhang <thestig@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818674}
      fc0abb9b
    • Xianzhu Wang's avatar
      Remove GraphicsLayer::SetNeedsDisplay() · 80a372d9
      Xianzhu Wang authored
      With unified PaintController, to support SetNeedsDisplay() we would
      need to add PaintController mechanism to invalidate all display items
      in a range for a GraphicsLayer. Removing SetNeedsDisplay() can avoid
      that. We instead use the normal paint invalidation code path. For
      needed invalidation, now invalidate the display items of and in the
      GraphicsLayer. Some invalidations are not needed because we have
      already invalidated the DisplayItemClients.
      
      Also rename SetContentsNeedsDisplay() to InvalidateContents(), and
      SetNeedsDisplayInrect() to InvaldiateRaster() which is only called by
      RasterInvalidator.
      
      Bug: 1132717
      Change-Id: I535cdcc7ee1d07e23a490fdf2aa267573a54d0ba
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478026
      Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
      Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818673}
      80a372d9
    • Mark Schillaci's avatar
      Accessibility Image Descriptions Android Port, Part II - Settings · 8e0471f3
      Mark Schillaci authored
      This CL is the second part of an effort to port the existing Desktop
      feature to Android. This feature enables a user to send an image to
      Google to process to generate a descriptive alt text if a website
      does not provide one.
      
      Design Doc: go/2020-q1-android-image-descriptions
      Slide Deck: go/clank-imageDescriptions
      Launch Bug: 1057168
      
      Original Desktop Design Doc for reference:
      go/chrome-a11y-annotations-design
      
      This is a conservative approach, we use a separate set of profile
      Prefs for this feature rather than syncing with the Desktop Prefs.
      This can be updated in time as needed. We have also hidden the
      entire feature behind a feature flag, so this CL is not visible
      to an average user.
      
      ----------
      
      This CL adds the following:
      
      - Settings sub page for image descriptions
      - Preference options for image descriptions
      - Associated strings etc for above
      
      ----------
      
      AX-Relnotes: Adds feature to enable generating alt image descriptions
      Bug: 1057169
      Change-Id: Ie968e8e831b20df7bfbfe27f0ffad1282fd835c3
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268299
      Commit-Queue: Mark Schillaci <mschillaci@google.com>
      Reviewed-by: default avatarTed Choc <tedchoc@chromium.org>
      Reviewed-by: default avatarMark Schillaci <mschillaci@google.com>
      Reviewed-by: default avatarNatalie Chouinard <chouinard@chromium.org>
      Reviewed-by: default avatarTheresa  <twellington@chromium.org>
      Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818672}
      8e0471f3
    • mlcui's avatar
      Allow Amharic and Swahili to be selected as a CrOS device language · 074455f8
      mlcui authored
      We should now have translations for these two languages. The pak files
      were already being built and shipped with Chrome OS, but couldn't be
      used as they were explicitly disabled.
      
      Test: CL author switched device language and saw translated strings
      Bug: 1093583
      Change-Id: I401baabe4af8f04d9918332a7f26badf720038ba
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2459135Reviewed-by: default avatarNico Weber <thakis@chromium.org>
      Commit-Queue: Michael Cui <mlcui@google.com>
      Cr-Commit-Position: refs/heads/master@{#818671}
      074455f8
    • Robert Ogden's avatar
      Plumb prefetch results in IsolatedPrerender Metrics Collector · d17049f1
      Robert Ogden authored
      Also transitions the origin prober over to using the new probe result
      enum so that it can be passed to the metrics collector.
      
      ScopedRefPtr:
      The metrics collector uses a scoped ref ptr to manage its lifetime.
      For mainframe prefetching, the TabHelper has the only refptr to the
      collector. But during NSP, the refptr is shared to every subresource
      manager that is created.
      If the next navigation does not go to a prefetched page, all subresource
      managers are destroyed, as well as the TabHelper's CurrentPageLoad class
      which destroys the metrics collector. Since there would not be any
      cache reuse to record in the metrics, it can be safely destroyed then.
      If the next navigation goes to a prefetched page, then all refptrs to
      the metrics collector will be destroyed, except for the one in the
      subresource manager associated with that page. This allows the
      subresource manager to record cache reuse directly, without relying on
      the TabHelper to make some lifetime guarantee about the metrics
      collector.
      Furthermore, this pattern keeps the cache reuse logic out of the
      TabHelper when it is already isolated to the subresource manager.
      
      Bug: 1136174
      Change-Id: I4e0e52acb8f99a1490f67d98b44329f997e40720
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463544
      Commit-Queue: Robert Ogden <robertogden@chromium.org>
      Reviewed-by: default avatarRyan Sturm <ryansturm@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818670}
      d17049f1
    • Curt Clemens's avatar
      [Nearby] Improve Chromevox readability on discovery page · 34c3cc61
      Curt Clemens authored
      - Add radiogroup role to share target list.
      - Label share target list with page subtitle so that it's clear what the
        list is for.
      - Make share target list an aria-live region so that new share targets
        are announced as they arrive.
      - Add aria-modal="true" to page template.
      
      Bug: b/163036847
      Change-Id: I4ff89d4ad635c7299198d95249f6b5accbe3e6f0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485875
      Commit-Queue: Curt Clemens <cclem@google.com>
      Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818669}
      34c3cc61
    • Roberto Moura's avatar
      Specify activePage in transition from Browser to Tab Grid. · c93de1e8
      Roberto Moura authored
      This change fixes a bug where closing the last incognito tab would
      create a transition from the incognito grid to the regular browser,
      which existed before but gained more visibility after crbug.com/1134718
      was fixed.
      
      Add an active tab grid page argument to the method of the protocol
      GridTransitionAnimationLayoutProviding that provides the transition
      layout.
      
      Add active tab grid page as argument to both TabGridTransitionHandler
      methods.
      
      Bug: 1136882
      Change-Id: Ide742143bdefcd5aac4a7d02ea9225d385fe7fcf
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2471496
      Commit-Queue: Roberto Moura <mouraroberto@google.com>
      Reviewed-by: default avataredchin <edchin@chromium.org>
      Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
      Auto-Submit: Roberto Moura <mouraroberto@google.com>
      Cr-Commit-Position: refs/heads/master@{#818668}
      c93de1e8
    • Robert Sesek's avatar
      Add two specific callouts for the rule-of-2: · 16cedb5b
      Robert Sesek authored
      - Protobuf is similarly trusted for deserializing messages at high
        privilege (though it should be avoided if possible).
      - Many Android system APIs are Java facades around C++ and are not
        considered memory safe.
      
      Change-Id: Ia70520fc8b319a639b03cb78f1a664b478902528
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486113
      Commit-Queue: Robert Sesek <rsesek@chromium.org>
      Reviewed-by: default avatarChris Palmer <palmer@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818667}
      16cedb5b
    • Maks Orlovich's avatar
      Instrument media query evaluation for identifiability study. · 75a3c8f0
      Maks Orlovich authored
      We would like to see how much entropy is leaked via it.
      The approach taken here is to instrument at CSS layer, which means
      things that would be defined in CSS and checked via getComputedStyle or
      the like get caught, and not just things explicitly Window.matchMedia;
      but has the downside of counting purely declarative use that's not
      actually actively observed by the page.
      
      Bug: 973801
      Change-Id: If762d74c1b6b17ca96533b9040cd31e44fdb06cc
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2449913
      Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
      Reviewed-by: default avatarRune Lillesveen <futhark@chromium.org>
      Reviewed-by: default avatarAsanka Herath <asanka@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818666}
      75a3c8f0
    • Rafael Cintron's avatar
      Add Windows support for gfx::GpuFenceHandle and gl::GLFence · 90f042bd
      Rafael Cintron authored
      gfx::GpuFenceHandle and gl::GLFence previously only supported POSIX
      operating systems. This change adds support for Windows for both
      classes.
      
      Bug: 1131616
      Change-Id: Iea3bf9ae52c6c7d22527cdb2f48711dd6981dee7
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2466515Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Reviewed-by: default avatarZhenyao Mo <zmo@chromium.org>
      Reviewed-by: default avatarRobert Kroeger <rjkroege@chromium.org>
      Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
      Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#818665}
      90f042bd
    • Donn Denman's avatar
      [TTS] Fix a disabled test (OOP issue) · 61329208
      Donn Denman authored
      Speculate fix for testLivePrefetchFailoverRequestMadeAfterOpen
      which was failing with out-of-process network service error.
      
      BUG=1071721
      
      Change-Id: I95cc3bba5ffd17e38b58fc88a3ff227045fe9feb
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486072
      Commit-Queue: Sinan Sahin <sinansahin@google.com>
      Reviewed-by: default avatarSinan Sahin <sinansahin@google.com>
      Auto-Submit: Donn Denman <donnd@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818664}
      61329208
    • Prakhar's avatar
      Set isolate_profile_data for Win10 Tests x64 · 1fa733bc
      Prakhar authored
      It is the tester for windows coverage cq builder https://source.chromium.org/chromium/chromium/tools/build/+/master:recipes/recipe_modules/chromium_tests/trybots.py;l=1368
      
      Also removes the same from GPU tester bot as we are not interested in coverage data in GPU tests
      
      Bug: 1139007
      Change-Id: Ie9b9bb2238d868e5d8c19c85ed1564425b79ecc5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477693
      Commit-Queue: Prakhar Asthana <pasthana@google.com>
      Auto-Submit: Prakhar Asthana <pasthana@google.com>
      Reviewed-by: default avatarYuke Liao <liaoyuke@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818663}
      1fa733bc
    • Caitlin Fischer's avatar
      Remove the IPH_ReopenTab entry from the testing config. · c8f06863
      Caitlin Fischer authored
      Bug: 1126640
      Change-Id: I89f1904efad1073763f0e213f1cf1747a3038b7f
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485680Reviewed-by: default avatarCollin Baker <collinbaker@chromium.org>
      Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
      Cr-Commit-Position: refs/heads/master@{#818662}
      c8f06863
    • Lan Wei's avatar
      Revert "Give test hooks to allow autofill test to keep popup open" · 390929d8
      Lan Wei authored
      This reverts commit 4e484a8f.
      
      Reason for revert: 
      AutofillInteractiveTest.PrefillFormAndFill fails on Mac10.11 Tests,
      https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests.
      
      Original change's description:
      > Give test hooks to allow autofill test to keep popup open
      >
      > On some test bots, mac dock or external values cause the browser to
      > make minor resizings of the frame. These are extraneous to our tests
      > so we would like to ignore those during tests.
      >
      > This CL provides a test hook by adding test access methods to
      > ChromeAutofillClient to make the autofill popup more
      > resistant to hiding from frame resizes, and then has AutofillUiTest
      > access that hook when running Interactive UI tests.
      >
      > This re-enables autofill interactive tests on mac bots.
      >
      >
      > Bug: 967588
      > Change-Id: Id9e25988f0cf64f0aa0631a48d48eb982b116c34
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2473802
      > Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
      > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
      > Reviewed-by: Dominic Battré <battre@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#818550}
      
      TBR=battre@chromium.org,vasilii@chromium.org,ianstruiksma@google.com
      
      Change-Id: I82610a8d1f4a1161a13f0ce62771fac6a12b091f
      No-Presubmit: true
      No-Tree-Checks: true
      No-Try: true
      Bug: 967588
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485539Reviewed-by: default avatarLan Wei <lanwei@chromium.org>
      Commit-Queue: Lan Wei <lanwei@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818661}
      390929d8
    • Lan Wei's avatar
      Disable flaky test updating-the-finished-state.html on Mac10.15 · 204687a2
      Lan Wei authored
      virtual/threaded/external/wpt/web-animations/timing-model/animations/
      updating-the-finished-state.html is flaky on Mac10.15,
      https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests,
      disable it for now until it is fixed.
      
      TBR=xidachen@chromium.org
      NOTRY=True
      
      Bug: 1140228
      Change-Id: Id7b53abfee1bae911c5076738dce41ca61330f94
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486256Reviewed-by: default avatarLan Wei <lanwei@chromium.org>
      Commit-Queue: Lan Wei <lanwei@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818660}
      204687a2
    • Xianzhu Wang's avatar
      Use global display item index in DisplayItemList dump · 59e86b24
      Xianzhu Wang authored
      The global display item indices (in the whole DisplayItemList) are more
      meaningful than the previous local indices (in DisplayItemRanges, which
      are in PaintChunks in the output of ShowDebugData) because we use the
      former in PaintController logic.
      
      Change-Id: I40c6d12bbf99d0f9fbfbbfa19050e75bd6cf2a09
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483584
      Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
      Reviewed-by: default avatarPhilip Rogers <pdr@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818659}
      59e86b24
    • Ionel Popescu's avatar
      Don't open the eye dropper if it is already opened. · aa07aab6
      Ionel Popescu authored
      This CL adds a check to ensure that a new eye dropper is not opened
      while an eye dropper is already opened.
      
      Bug: 1137328
      Change-Id: I14a134a5cb6ec8d3923956d6f3a1bbf8b5604c0c
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481072Reviewed-by: default avatarMason Freed <masonfreed@chromium.org>
      Commit-Queue: Ionel Popescu <iopopesc@microsoft.com>
      Cr-Commit-Position: refs/heads/master@{#818658}
      aa07aab6
    • Elly Fong-Jones's avatar
      partalloc: refactor PurgeDiscardableManyPages · 96c7a70e
      Elly Fong-Jones authored
      This change:
      1) Introduces ScopedPageAllocation, to avoid tests needing to remember
         to free everything they allocate manually;
      2) Merges the two bodies of this test into one;
      3) Fixes this test on Mac-Arm64 via (2)
      
      Bug: 1128436
      Change-Id: I158fe54ffb6286168fb2995508bfc06db53aa0ff
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482342Reviewed-by: default avatarChris Palmer <palmer@chromium.org>
      Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818657}
      96c7a70e
    • Jan Wilken Dörrie's avatar
      [base] Cleanup IsContiguousIterator · 714925ed
      Jan Wilken Dörrie authored
      This change cleans up the implementation of base::IsContiguousIterator
      by no longer relying on details of several STL implementations, but
      rather doing type matching in a portable manner. Also adds a few more
      references to the standard.
      
      Bug: 828324
      Change-Id: I070dfabad822b276e336a017c0b3b5e4bd7fefda
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475037Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818656}
      714925ed
    • Peter Kasting's avatar
      Clang-tidy autofixes for ui/views/. · 21167fa5
      Peter Kasting authored
      Bug: none
      Change-Id: I2b94c49ce59825a613fc81a994104641bc02b948
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2483343
      Commit-Queue: Robert Liao <robliao@chromium.org>
      Reviewed-by: default avatarRobert Liao <robliao@chromium.org>
      Auto-Submit: Peter Kasting <pkasting@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818655}
      21167fa5
    • tby's avatar
      Remove Apps.LogDisplayTypeClickedResultZeroState metric · 8df2b388
      tby authored
      Bug: 1138392
      Change-Id: Ib8d204d5e8b073e7a54fea48a712cbf7a31e3147
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2477114Reviewed-by: default avatarRachel Wong <wrong@chromium.org>
      Commit-Queue: Tony Yeoman <tby@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818654}
      8df2b388
    • Moe Ahmadi's avatar
      [NTP][RQ] Adds support for repeatable queries in NTP MV tiles (Part 2) · 8d02ead0
      Moe Ahmadi authored
      Adds the Repeatable Queries Service as a source for the NTP MV tiles and
      gates the repeatable queries UI changes based on that new source.
      In practice, none of the tiles come from that service just yet.
      
      Bug: 1138578
      Change-Id: If8f35b70c4f5e1f464df12ec8c11ba7d3bd798b2
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2481070
      Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
      Reviewed-by: default avatarTibor Goldschwendt <tiborg@chromium.org>
      Reviewed-by: default avatarAlex Gough <ajgo@chromium.org>
      Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818653}
      8d02ead0
    • Sammie Quon's avatar
      capture_mode: Add testapi and remove button listener. · 5939e063
      Sammie Quon authored
      Move 4 CaptureSession test only functions to test file api. Use callback
      instead of overriding ButtonListener, seems to be new style [1].
      
      [1] https://bugs.chromium.org/p/chromium/issues/detail?id=772945
      
      Test: existing tests
      Bug: none
      Change-Id: Ic61bd06419e1c9f348fa35d62e648d42ab1ec9e6
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480812
      Commit-Queue: Sammie Quon <sammiequon@chromium.org>
      Reviewed-by: default avatarAhmed Fakhry <afakhry@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818652}
      5939e063
    • chromium-autoroll's avatar
      Roll DevTools Frontend from 46e1bcace932 to 99620c4bfcfc (1 revision) · 48b908f2
      chromium-autoroll authored
      https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/46e1bcace932..99620c4bfcfc
      
      2020-10-19 jalyn@microsoft.com Remove dependencies on ShortcutsScreen
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/devtools-frontend-chromium
      Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Bug: chromium:174309
      Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
      Change-Id: Ie4b4814a2c4e4b5b092e0d12de21b7f28ea5110d
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485608Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#818651}
      48b908f2
    • Majid Valipour's avatar
      [WebOTP] Update gms_play_services_auth_api_phone to 17.5.0 · 348083f4
      Majid Valipour authored
      The new version of the library [1] adds a new SMS Code Browser API [2]
      that we intend to use for WebOTP.
      
      Followed the instructions:
       - Update version in build.gradle
       - Run fetch_all.py
       - upload necessary artifacts to cipd
      
      
      [1] https://developers.google.com/android/guides/releases#october_07_2020
      [2] https://developers.google.com/android/reference/com/google/android/gms/auth/api/phone/SmsCodeBrowserClient
      
      Bug: 1101050
      Change-Id: I5f9219c62c331a049db76027ffd36c7a5ebc0e29
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485192
      Commit-Queue: Majid Valipour <majidvp@chromium.org>
      Reviewed-by: default avatarSam Maier <smaier@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818650}
      348083f4
    • Jonathan Ross's avatar
      Suppress Flaky WebGL2 Conformance Failures · 6b94a1e8
      Jonathan Ross authored
      Some tests withing webgl2_conformance_gl_passthrough_tests are flaky
      on ARM-based Mac DTKs. This change marks them to RetryOnFailure
      
      TEST=webgl2_conformance_gl_passthrough_tests
      Bug: 1130119
      
      Change-Id: I1ee39cbea8d1984a93b4cc1702b54ed06c0e1331
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485297Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
      Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
      Commit-Queue: Jonathan Ross <jonross@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818649}
      6b94a1e8
    • Dylan Cutler's avatar
      Remove blink::CanonicalCookie in favor of net::CanonicalCookie. · 13a23be2
      Dylan Cutler authored
      net::CanonicalCookie has slightly strange data representation which
      blink::CanonicalCookie matches field-for-field with corresponding
      blink types without the code to go with it. You can kind of see it in
      this DCHECK, in one of its constructors:
      
      DCHECK(ToNetCanonicalCookie(*this).IsCanonical());
      
      The type only exists to convert to and from a different JavaScript
      representation before/after talking over mojo, so it basically has to
      construct all the same data members of a net type without the type's
      code using Blink types which will then be promptly converted to browser
      types (and vice-versa). It seems more natural to go from JS to the
      net type, so that we can provide a proper construction function
      (cleanup of how net::CanonicalCookies are made is what motivated this)
      that does sensible things rather than have blink code know what net code
      does with leading dots in one of its data fields.
      
      Bug: 1124736
      Change-Id: I0c9e3ef366e89560a1fa4bedb397f28079a6b36a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463999Reviewed-by: default avatarNico Weber <thakis@chromium.org>
      Reviewed-by: default avatarAyu Ishii <ayui@chromium.org>
      Reviewed-by: default avatarMaksim Orlovich <morlovich@chromium.org>
      Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
      Commit-Queue: Dylan Cutler <dylancutler@google.com>
      Cr-Commit-Position: refs/heads/master@{#818648}
      13a23be2
    • rbpotter's avatar
      Reland WebUI: Add support for resource_path_rewrites to generate_grd · 35e5ce24
      rbpotter authored
      Bug: 1132403
      Change-Id: I12b524f643bf67ee87165797750e765b4a854c6a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2482465Reviewed-by: default avatardpapad <dpapad@chromium.org>
      Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818647}
      35e5ce24
    • chromium-autoroll's avatar
      Roll Perfetto from 7411aeba4d3b to e6f794f1dc5d (209 revisions) · 8c0f5f65
      chromium-autoroll authored
      https://android.googlesource.com/platform/external/perfetto.git/+log/7411aeba4d3b..e6f794f1dc5d
      
      2020-10-19 treehugger-gerrit@google.com Merge "test: Make IPC dependency optional"
      2020-10-19 treehugger-gerrit@google.com Merge "metrics: Convert RAILMode query to use protos"
      2020-10-19 skyostil@chromium.org test: Remove unneeded traced.h includes am: 9aeedae636
      2020-10-16 oysteine@google.com Merge "gn: Don't build end_to_end_integration test in Chrome" am: db25661ba2
      2020-10-16 primiano@google.com Merge "Remove ODR violations from Bazel builds" am: 112daf7c04
      2020-10-16 skyostil@google.com Merge "gn: Guard client_api_example target configuration" am: 7863f8fb8b
      2020-10-16 salg@google.com Merge "proto/processor: Add ChromeWindowHandleEventInfo" am: 8065f31f44
      2020-10-15 lalitm@google.com tp: add support for ingesting and using kernel symbols am: 24305ca78e
      2020-10-15 skyostil@google.com Merge "tracing: Add debug check for duplicated interned data indices" am: 51f19948ce
      2020-10-15 hjd@google.com Merge "ui: Support multiple thread tracks" am: 81c6a09c12
      2020-10-15 treehugger-gerrit@google.com Merge "tracing: Implement system consumer backend" am: 823dd74cd7
      2020-10-14 treehugger-gerrit@google.com Merge "tracing: Handle producer disconnection" am: 7411aeba4d
      2020-10-14 hjd@google.com Merge "Add fastrpc_dma_stat" am: 0581509dc2
      2020-10-14 hjd@google.com Merge "ui: Improve rendering of incomplete slices" am: 825d78c0eb
      2020-10-14 taylori@google.com Roll trace processor am: ca4153fa8b
      2020-10-14 treehugger-gerrit@google.com Merge "Add a new proto for ChromeRendererSchedulerState" am: a4ac7a10c9
      2020-10-14 simonmacm@google.com Merge "Update ugly suspend-resume heuristic for newer kernels." am: 00cd6e6114
      2020-10-14 hjd@google.com Merge "ui: Fix SQL query escaping" am: 1410c33130
      2020-10-14 hjd@google.com Merge "ui: Download trace in new tab" am: 1bf2339dc0
      2020-10-14 skyostil@chromium.org tracing: Don't try to observe events before connecting am: 363c2bd3d7
      2020-10-14 primiano@google.com Merge "init: mkdir /data/misc/perfetto-configs" am: 19ee1c9458
      2020-10-13 treehugger-gerrit@google.com Merge "docs: fix instructions for adb shell perfetto" am: 0150a791fc
      2020-10-13 treehugger-gerrit@google.com Merge "ipc: Fix use-after-free on connection failure" am: 095444c212
      2020-10-13 treehugger-gerrit@google.com Merge "tracing: Don't reuse trace writers across connections" am: a08dc37d19
      2020-10-12 treehugger-gerrit@google.com Merge "tp: implement async track set tracker" am: a4b8d27d96
      2020-10-12 hjd@google.com perfetto_cmd: Fix statsd based triggers am: 7c7b98f060
      2020-10-09 fmayer@google.com Merge "Document LD_PRELOAD heapprofd library." am: 109c355900
      2020-10-09 fmayer@google.com Merge "Allow to set base pointer for referred objects." am: 667f89a6e8
      2020-10-09 ngeoffray@google.com Merge "Add liblog as a dependency of libperfetto_client_experimental." am: aef1b91502
      2020-10-09 treehugger-gerrit@google.com Merge "Fix missing __libc_posix_memalign symbol." am: 815983783a
      2020-10-09 treehugger-gerrit@google.com Merge "Build heapprofd_preload when building heapprofd." am: 978e713841
      2020-10-09 treehugger-gerrit@google.com Merge "Fix slice combining in RAIL mode metric" am: 0ad07c9245
      2020-10-09 primiano@google.com Merge "Add support for symbolizing kernel symbols for ftrace events" am: c251d370b6
      2020-10-09 treehugger-gerrit@google.com Merge "Added key navigation for flow events" am: 2bf76269e1
      2020-10-09 treehugger-gerrit@google.com Merge "Skip ab/6749736 in stage." into stage-aosp-master
      2020-10-09 treehugger-gerrit@google.com Merge "trace_to_text: make endian functions portable" am: 7c2d888fdf
      2020-10-08 treehugger-gerrit@google.com Merge "Add missing beginPath when drawing instant event arrows" am: 628c64d7a1
      2020-10-08 fmayer@google.com Merge "Do not abort profile if main thread stack grows." am: 02a7aa75bb
      2020-10-08 primiano@google.com Merge changes Ic7aa1265,I4d418aac am: 8cf1557a5c
      2020-10-08 treehugger-gerrit@google.com Merge "perfetto-ui: Improve record page" am: 42e5254db8
      2020-10-08 treehugger-gerrit@google.com Merge "hprof converter skeleton" am: 823a6df243
      2020-10-08 primiano@google.com Merge "gn: Apply visibility rules to gn:default_{deps,config}" am: f2eb31d857
      2020-10-08 fmayer@google.com Improve docs about runtime signalling. am: 31b44b3a70
      2020-10-07 treehugger-gerrit@google.com Merge "get.perfetto.dev: filter out urls" am: 9fb07662e4
      2020-10-07 treehugger-gerrit@google.com Merge "processor: Update descriptor track names from first event's name" am: 2cb8216a1b
      2020-10-07 primiano@google.com Merge "build: Remove no-op calls to set_sources_assignment_filter" am: 3419b3b485
      2020-10-07 ddrone@google.com Merge "Manually copy Chrome extensions to Perfetto" am: b64eb281be
      2020-10-07 oksamyt@google.com Merge "[trace processor] Remove unused code from the WebView power metric" am: 91ab730685
      2020-10-07 hjd@google.com Merge "ui: Fix <O recording docs link" am: b364d20b12
      2020-10-07 treehugger-gerrit@google.com Merge "Fix build failure due to extra parent dir" am: 6e7d3e86fc
      2020-10-06 treehugger-gerrit@google.com Merge "perfetto-ui: Move query result to details panel" am: 8673284abb
      2020-10-06 lalitm@google.com Merge "tp: fix type affinity of string columns" am: 6632b1c5b5
      2020-10-05 ssid@google.com Add a typed event for mojo notify event am: 77ab7cfe84
      2020-10-05 cfijalkovich@google.com Merge "Calibrate HSC-emulated app launch measurements" am: d53debd86f
      2020-10-05 treehugger-gerrit@google.com Merge "Added new proto format for flow events" am: aeb4a3e63d
      2020-10-05 treehugger-gerrit@google.com Merge "Added category and name columns for flow details panel" am: aa07f43f0b
      2020-10-05 ilkos@google.com Merge "Fix quantization error" am: 78d8e2c4fe
      2020-10-05 lalitm@google.com Merge "tp: wait to fill buffers when parsing gzip before sending to next stage" am: 7c0969160a
      2020-10-05 hjd@google.com Merge changes I4f8eb249,I829c77e0 am: 9939fa32b2
      2020-10-05 hjd@google.com Merge "ui: Stitch small TraceHttpStream chunks" am: 7cdc44f903
      2020-10-05 treehugger-gerrit@google.com Merge "[trace processor] Add RAIL Mode power metrics" am: af6c5c6227
      2020-10-02 treehugger-gerrit@google.com Merge "ui: Bump state version for metrics changes" am: 1f8d793e3b
      2020-10-02 treehugger-gerrit@google.com Merge "Reduce max frame count." am: e9d7296b17
      2020-10-02 treehugger-gerrit@google.com Merge "Optimize the scroll_jank_cause_queuing_delay metric." am: 3b50b7c411
      2020-10-02 treehugger-gerrit@google.com Merge "Reserve space for frames in AllocRecord." am: 9b8970cc01
      2020-10-02 hjd@google.com Merge "ui: Search within slice args" am: c0482f7bd1
      2020-10-02 treehugger-gerrit@google.com Merge "Add memory snaphot tables." am: 2e66e50062
      2020-10-02 taylori@google.com Merge "perfetto-ui: Fix details panel height" am: 935a915963
      2020-10-02 hjd@google.com Merge "Remove extra join" am: df861c5206
      2020-10-01 fmayer@google.com Merge "Allow to use data_source_stop_timeout_ms in java_heap_dump." am: d2958971d9
      2020-10-01 treehugger-gerrit@google.com Merge "perfetto_cmd: Use monotime for sendfile timeout" am: ed322fe3fa
      2020-10-01 treehugger-gerrit@google.com Merge "Add missing stddef.h header in compiler.h" am: 7917fa2dd4
      2020-10-01 treehugger-gerrit@google.com Merge "processor: Update null names of legacy Chrome async tracks on lookup." am: d184e4ba02
      2020-10-01 hjd@google.com Merge "ui: Improve track names even more" am: 72a6843cad
      2020-10-01 lalitm@google.com Merge "Update CHANGELOG for v8.0 release" am: 9d0f922886
      2020-10-01 fmayer@google.com Merge "Pull heapprofd simpleperf into output directory." am: bce69fefbe
      2020-10-01 hjd@google.com Merge "Revert "ui: Add gn rule to copy protobufjs light"" am: a321d9ae25
      2020-10-01 hjd@google.com Merge "ui: Improve track names" am: c6475d45a9
      2020-10-01 taylori@google.com Merge "perfetto-ui: Order thread tracks" am: f01bf538a4
      2020-10-01 hjd@google.com Merge "ui: Don't go via trackState for trackState.id" am: 2fde3fac99
      2020-09-30 oksamyt@google.com Merge "[trace processor] Add Webview-only thread usage to WV power metric" am: 492d4a85a2
      2020-09-30 taylori@google.com Roll trace processor am: 670e999072
      2020-09-30 treehugger-gerrit@google.com Merge "Aggregate flamegraph by name rather than type id." am: 810b74c0d7
      2020-09-30 taylori@google.com Merge "ui: Don't allow selection in the track shell area" am: adc22042d0
      2020-09-29 treehugger-gerrit@google.com Merge "ui: Add a metrics page" am: bb5318dbbf
      2020-09-29 treehugger-gerrit@google.com Merge "Use CPU/wall time to descend TRACE_EVENTs when multiple children exist" am: 5b2eba1831
      2020-09-29 dproy@google.com Merge "HistogramName interning" am: 6f3ac1001f
      2020-09-29 treehugger-gerrit@google.com Merge "Added dynamic tables for preceding and following flows" am: 68983d39e5
      2020-09-29 treehugger-gerrit@google.com Merge "Fix typescript error" am: 76404b01d5
      2020-09-28 treehugger-gerrit@google.com Merge "Fixed data source index assert checking against wrong constant." am: 88c194fccd
      2020-09-28 cferris@google.com Merge "Update for libunwindstack change." am: 7ec44b1e23
      2020-09-25 treehugger-gerrit@google.com Merge "flamegraph: Compress text if it almost fits" am: df3ae5e6f9
      2020-09-25 hjd@google.com Merge "flamegraph: Reduce font size and improve rollover rendering" am: d3fe2d1611
      2020-09-25 treehugger-gerrit@google.com Merge "Add a query that will compute the CPU time per chrome thread slice." am: fe40be6924
      2020-09-25 fmayer@google.com Merge "Document weird looking if condition." am: c2e629442d
      2020-09-25 fmayer@google.com Merge "Include data_source_stop_timeout_ms in perfetto cmd TTL." am: d62c73fbf4
      2020-09-25 lalitm@google.com Merge "Make operator- const" am: a701e9d0da
      2020-09-25 taylori@google.com Merge "perfetto-ui: Warn user about old TP version" am: 0e384eef5e
      2020-09-25 hjd@google.com Merge "ui: Fix bug with computing maxDepth" am: c49e606913
      2020-09-25 fmayer@google.com Merge "Add field to ignored types in perfetto_hprof." am: 8718dc4d41
      2020-09-25 hjd@google.com Merge "Reland: Make GuessTraceType more selective about proto traces" am: 8f47f320f6
      2020-09-24 hjd@google.com Merge "ui: Swallow key events on crash dialog" am: df53732e1b
      2020-09-24 treehugger-gerrit@google.com Merge "Fix GPU memory metrics aggregation" am: d6e5d04ae0
      2020-09-24 taylori@google.com Merge "perfetto-ui: Make metrics non-breaking in UI" am: 71ee049b6b
      2020-09-24 hjd@google.com Merge changes I3ac1b577,I174ae837,I9d1f40a5 am: 63017f32d1
      2020-09-24 taylori@google.com Merge "Load trace and discard old state" am: 92706a8994
      2020-09-24 treehugger-gerrit@google.com Merge "Remove doc references to ftrace wildcard feature." am: 3d8fd27d9a
      2020-09-24 treehugger-gerrit@google.com Merge "Ftrace: don't log errors in case of ENODEV" am: f6b292d8a3
      2020-09-23 dproy@google.com Merge "metrics: Implement getting prototext formatted metric result" am: 4e32ab4dd7
      2020-09-23 fmayer@google.com Merge "Also deobfuscate frames from jit-cache." am: 61c15b0ea0
      2020-09-23 primiano@google.com Merge "Update libcxx, libcxxabi, libunwind, clang-format" am: 637111bf30
      2020-09-23 fmayer@google.com Add Known Issue about sampling_interval_bytes=0. am: 12494ee122
      2020-09-23 hjd@google.com Merge "Revert "Make GuessTraceType more selective about proto traces"" am: 06f3474ec4
      2020-09-23 hjd@google.com Merge "Make GuessTraceType more selective about proto traces" am: e6fa5ff79a
      2020-09-23 lalitm@google.com Merge "perfetto: bump integration test timeout" am: 8b4b90b0a0
      2020-09-23 fmayer@google.com Merge "Allow to specify separate sampling interval per heap." am: eb7e0e1acb
      2020-09-23 taylori@google.com ui: Fix logs panel am: e5e5768709
      2020-09-23 treehugger-gerrit@google.com Merge "Update clang to llvmorg-12-init-5035-gd0abc757-3" am: d937502d15
      2020-09-23 hjd@google.com Merge "Remove Dropbox code from android_internal" am: fd86b8d464
      2020-09-23 taylori@google.com Merge "perfetto-ui: Only intialize GA on prod or staging" am: 90adb47e5d
      2020-09-22 oysteine@google.com Merge "New/Updated typed arg types for Chrome" am: 4f973a50bb
      2020-09-22 treehugger-gerrit@google.com Merge "Larger default buffer config in UI." am: 3c7133e86f
      2020-09-22 fmayer@google.com Merge "Have separate sampler per heap." am: 82c70d9757
      2020-09-22 taylori@google.com Merge "ui: Don't show reload toast" am: ada5d5129f
      2020-09-22 hjd@google.com Merge "ui: Improve error message for invalid permalink" am: 9cf7a56afb
      2020-09-22 hjd@google.com Merge "Support loading traces from the Android Bug Tool" am: 791ed207e2
      2020-09-21 treehugger-gerrit@google.com Merge "Two small fixes for pages with a 16KB system page" am: b653fdea2f
      2020-09-21 treehugger-gerrit@google.com Merge "ui: Implement debug slices track" am: 6a7b87067b
      2020-09-21 treehugger-gerrit@google.com Merge "ui: Make it impossible to select the close permalink button" am: 2d461fa4a0
      2020-09-21 treehugger-gerrit@google.com Merge "Background mode for busy_threads" am: f2db91bc8a
      2020-09-21 treehugger-gerrit@google.com Merge "Always add a "args" dictionary even if empty." am: 5721bfd7a5
      2020-09-21 hjd@google.com Merge "Reland code changes for mithril v2.0" am: d485436734
      2020-09-21 fmayer@google.com Merge "Do not crash on missing root for flamegraph." am: 7f3209db71
      2020-09-18 fmayer@google.com Merge "Add multi ABI fix to changelog." am: c7865d989c
      2020-09-18 hjd@google.com Revert "Revert "Revert "ui: Upgrade mithril 1.0.2 -> 2.0.3""" am: 8b14ed3b82
      2020-09-17 fmayer@google.com Merge "Make sure we are using the correct stack base." am: bced72b4fb
      2020-09-17 primiano@google.com Merge "Docs: minor fix to the benchmark code" am: 3bcddbcefc
      2020-09-17 rslawik@google.com Require core layout for time in state metric am: e8d5e6f521
      2020-09-17 fmayer@google.com Rename all occurences of client_ext. am: 40c612f34e
      2020-09-17 lalitm@google.com Merge "tp: add support for shell on Android" am: 2f37178ebd
      2020-09-17 fmayer@google.com Merge "Rename client_ext.h to heap_profile.h." am: 511274afd2
      2020-09-17 fmayer@google.com Add missing fields from comparator for AllocMetadata. am: b85952a45e
      2020-09-17 treehugger-gerrit@google.com Merge "perfetto-ui: Fix null keyed fragments" am: 6280abf226
      2020-09-17 treehugger-gerrit@google.com Merge "Allow to write out profiles from HeapprofdEndToEnd." am: c97e37f982
      2020-09-17 treehugger-gerrit@google.com Merge "Exporting flow events to json from flow table" am: 29e4a94d1e
      2020-09-17 fmayer@google.com Merge "Rename com.android.malloc -> libc.malloc." am: 05efd8600d
      2020-09-17 treehugger-gerrit@google.com Merge "Flow events are highlighted when slice is hovered" am: d62add52c6
      2020-09-16 treehugger-gerrit@google.com Merge "tp: switch from using libprotoc to libprotobuf-full" am: a2ba0ce189
      2020-09-16 fmayer@google.com Merge changes I26d1c6e5,I9ceaa1ff am: 3504e85b74
      2020-09-16 treehugger-gerrit@google.com Merge "Fixed mouse hover over slice" am: b14a3f7cf6
      2020-09-16 treehugger-gerrit@google.com Merge "Log unwinding errors in heapprofd e2e test." am: 098b75940d
      2020-09-16 treehugger-gerrit@google.com Merge "probes: update vmstat counters to latest 4.14 and 4.19" am: 33010a1b33
      2020-09-16 hjd@google.com Merge "perfetto_cmd: Remove Dropbox upload code" am: 7d73d47538
      2020-09-16 primiano@google.com Merge "iorap API: fix thread race when initializing the consumer library" am: d1382ae74f
      2020-09-16 treehugger-gerrit@google.com Merge "Roll trace processor" am: 144228061e
      2020-09-16 treehugger-gerrit@google.com Merge "Fix broken default query." am: 38f0f40310
      2020-09-16 fmayer@google.com Merge "Clarify experimental_flamegraph example." am: 5e931ebb24
      2020-09-16 treehugger-gerrit@google.com Merge "require_root for perfetto_integrationtests." am: d48ef5f7dd
      2020-09-15 fmayer@google.com Merge "Fix invalid CHECK in flamegraph generation." am: b189aac831
      2020-09-15 hjd@google.com Merge "ui: Fix logcat dropdown" am: a309fd95e9
      2020-09-15 taylori@google.com Merge "Revert "ui: Upgrade immer from 1.12.0 -> 7.0.8"" am: e3da35d534
      2020-09-15 taylori@google.com Merge "perfetto-ui: Column sums" am: e049f9d1de
      2020-09-15 taylori@google.com Merge "perfetto-ui: Add privacy policy link" am: dfc49d1714
      2020-09-15 taylori@google.com perfetto-ui: Add isGoogler custom dimension am: 79cef0a5cf
      2020-09-15 lalitm@google.com Merge "tp: remove hack of stripping prefix for --run-metric files" am: df4ddebf1c
      2020-09-15 fmayer@google.com macOS linker does not have -Wl,--build-id. am: b0a548c7e6
      2020-09-15 hjd@google.com Merge "ui: Upgrade immer from 1.12.0 -> 7.0.8" am: 346ff6a4d7
      2020-09-15 treehugger-gerrit@google.com Merge "cppgen: Don't require full submessage definitions in gen headers" am: 53913fb84a
      2020-09-14 treehugger-gerrit@google.com Merge "Generate build ids." am: cfda0b2aaf
      2020-09-14 fmayer@google.com Merge "Count how long we sleep for the client spinlock." am: 10bc2ded1f
      2020-09-14 lalitm@google.com Merge "bazel: cleanup duplicate proto deps" am: ef8430ec39
      2020-09-14 fmayer@google.com Merge "Separate allocator wrapping logic from Bionic." am: fc73b4f240
      2020-09-14 hhb@google.com Merge "Using DoAll" am: 68550030dc
      2020-09-14 treehugger-gerrit@google.com Merge "TrackEvent: Add support for overriding interned data storage" am: 10df243381
      2020-09-14 lalitm@google.com Merge "ui: fix exponential memory usage for async slice tracks" am: ff21c0b51d
      2020-09-14 lalitm@google.com metrics: explicitly specify source_set generator for all metric protos am: eeae1e0ad1
      2020-09-14 treehugger-gerrit@google.com Merge "tp: migrate chrome metrics descriptor generation to build time" am: 4934cd57c7
      2020-09-14 treehugger-gerrit@google.com Merge "Add some additional special classes to histogram" am: 8d39c21bc7
      2020-09-14 lalitm@google.com Merge "tools: replace \ with _ in include guard as well" am: bef393a5a3
      2020-09-14 treehugger-gerrit@google.com Merge "Displaying Flow Events in the UI" am: 662cb23c78
      2020-09-14 lalitm@google.com Merge "gn: make generate_descriptor consistent between chrome and standalone" am: a2c843670e
      2020-09-11 treehugger-gerrit@google.com Merge "chrome_config: Add client priority setting" am: da650d02a5
      2020-09-11 fmayer@google.com Merge "Check whether all allocations are sampled for accurate test." am: d7a7a09b81
      2020-09-11 hjd@google.com Merge "ui: Fix build dependencies" am: af8f83971e
      2020-09-11 lalitm@google.com Merge "tp: add missing array header" am: 66cccba08f
      2020-09-11 lalitm@google.com Merge "as_pandas() -> as_pandas_dataframe(); add __str__ representation" am: 7c81d93f11
      2020-09-11 lalitm@google.com Merge "tp: move metrics descriptor generation to build time" am: 251239c02c
      2020-09-11 fmayer@google.com Remove outdated comment. am: 9edd1a906f
      2020-09-11 hjd@google.com Fix clock_tracker.cc am: 5dc147f282
      2020-09-11 ssid@google.com Merge "Avoid race in accessing log count" am: bb36b6a3f4
      2020-09-11 zzyiwei@google.com Define GPU metrics am: 617d3f67c3
      2020-09-11 zzyiwei@google.com Fix the scope of counter_span_view am: 48a955aeb0
      2020-09-11 treehugger-gerrit@google.com Merge "tp: add support for gzipped traces in DecompressTrace" am: a4cfaa2dfc
      2020-09-11 fmayer@google.com Merge changes Ief0ffa2c,Icce0f62c am: 3b19b9d334
      2020-09-11 hjd@google.com Merge "Remove d8, we never used it" am: 8bfaef6ad5
      2020-09-11 hjd@google.com Merge "ui: Add --incremental to TypeScript build" am: a6222ca1f5
      2020-09-11 delphij@google.com [automerger skipped] Merge "Merge Android R" am: 93b70685b2 -s ours
      2020-09-10 treehugger-gerrit@google.com Merge "ui: Add support to decode metrics in the UI" am: e89d2e06c6
      2020-09-10 treehugger-gerrit@google.com Merge "metrics: Extend metric proto before registering metric" am: feb1579dfb
      2020-09-10 treehugger-gerrit@google.com Merge "traceconv: add missing flush in output writer" am: 5f2455899f
      2020-09-10 treehugger-gerrit@google.com Merge "Add back reserved lines commented earlier" am: e25084872a
      2020-09-10 treehugger-gerrit@google.com Merge "tp: extract out tokenizing logic from ProtoTraceTokenizer" am: 625eb19759
      2020-09-10 lalitm@google.com ui: don't throw exception for zero-duration instants am: df5b7cb44e
      2020-09-10 rslawik@google.com Merge "Fix unique constraint failed error" am: b3f3e76c87
      2020-09-10 ssid@google.com Merge "Add source location as typed event argument" am: d07b48d3ed
      2020-09-10 taylori@google.com Merge "ui: Use id for thread state selection" am: 94d84fc8ff
      2020-09-10 treehugger-gerrit@google.com Merge "UI: allow ?=&; chars from postMessage strings" am: f2fd649d1f
      2020-09-10 treehugger-gerrit@google.com Merge "Use deobfuscated symbol name in callsites" am: 8d1bf91b4d
      2020-09-10 treehugger-gerrit@google.com Merge "Add a smoothness flag to per-frame state." am: e6cf965855
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/perfetto-chromium-autoroll
      Please CC perfetto-bugs@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
      Bug: None
      Tbr: perfetto-bugs@google.com
      Change-Id: Id76be450bd1c3bf503f2e33c26d85e69c393513a
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486191Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#818646}
      8c0f5f65
    • chromium-autoroll's avatar
      Roll Skia from bcd1fc030a2b to a670782ed315 (5 revisions) · 8d434743
      chromium-autoroll authored
      https://skia.googlesource.com/skia.git/+log/bcd1fc030a2b..a670782ed315
      
      2020-10-19 egdaniel@google.com Update GrAttachment budgeted and gpu memory size calculation.
      2020-10-19 csmartdalton@google.com Remove a redundant position assignment from stroke tessellation shaders
      2020-10-19 egdaniel@google.com Implement computeScratchKey virtual for GrAttachment.
      2020-10-19 brianosman@google.com Directly compute call counts, rather than mutating state
      2020-10-19 bsalomon@google.com Revert "Revert "New variant of SkImage::MakeFromYUVATextures.""
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/skia-autoroll
      Please CC egdaniel@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
      Cq-Do-Not-Cancel-Tryjobs: true
      Bug: None
      Tbr: egdaniel@google.com
      Change-Id: I70238ada6f0b6210ad5db9a77f47c3b88c58fc1b
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485607Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#818645}
      8d434743
    • Lan Wei's avatar
      Disable flaky test QuicTransportBrowserTest.ReceiveStream on Windows · a46a97bc
      Lan Wei authored
      QuicTransportBrowserTest.ReceiveStream is flaky on
      Windows,
      https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64,
      disable it for now until it is fixed.
      
      TBR=ricea@chromium.org
      NOTRY=True
      
      Bug: 1140193
      Change-Id: Id6d168ff87fe6dab8bd048cefa60c2e713604b93
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485274
      Commit-Queue: Lan Wei <lanwei@chromium.org>
      Reviewed-by: default avatarLan Wei <lanwei@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818644}
      a46a97bc
    • Lan Wei's avatar
      Disable flaky test LeaveSiteStillWarnsAfter on Windows · 5b8dde61
      Lan Wei authored
      SafetyTipPageInfoBubbleViewBrowserTest.LeaveSiteStillWarnsAfter is
      flaky on Windows,
      https://ci.chromium.org/p/chromium/builders/ci/Win10%20Tests%20x64,
      disable it for now until it is fixed.
      
      TBR=jdeblasio@chromium.org
      NOTRY=True
      
      Bug: 1140193
      Change-Id: I0245b63bbe209d8c65f8c94ca6117a552670db53
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486252Reviewed-by: default avatarLan Wei <lanwei@chromium.org>
      Commit-Queue: Lan Wei <lanwei@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818643}
      5b8dde61
    • Owen Min's avatar
      Replace the future flag for multiple policies III · 82e6d2cb
      Owen Min authored
      Using future_on instead future for following policies
      CastReceiverEnabled
      CastReceiverName
      ReportVersionData
      ReportPolicyData
      ReportMachineIDData
      ReportUserIDData
      ReportExtensionsAndPluginsData
      ReportDeviceLocation
      WebRestrictionsAuthority
      
      Except the ReportDeviceLocation, all policies will be filtered out in
      Beta and Stable.
      
      The following policies are deprecated at the same time as they will
      never be launched. They should be removed with crbug.com/1139964.
      CastReceiverEnabled
      CastReceiverName
      
      Delete following policies as they have been removed from code completely
      and they are never launched:
      ContentPackDefaultFilteringBehavior
      ContentPackManualBehaviorHosts
      ContentPackManualBehaviorURLs
      
      
      
      Bug: 1117637
      Change-Id: Ic4e516bfb3fa469db85e66ef107dd51131291e90
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2458907
      Commit-Queue: Owen Min <zmin@chromium.org>
      Reviewed-by: default avatarYves Arrouye <drcrash@chromium.org>
      Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
      Reviewed-by: default avatarJulian Pastarmov <pastarmovj@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818642}
      82e6d2cb
    • Ryan Heise's avatar
      Disable v8.browsing_mobile/browse:social:facebook:2019 · 767a2a9e
      Ryan Heise authored
      This test often hangs - example: https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=6456ceb55e1bef585b6be013c8a1c546a16e6313&as=benchmark_log.txt
      
      Bug: chromium:1139057
      Change-Id: I0169e3f746f7ec797e00f13c09491865eabaf188
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485558Reviewed-by: default avatarJohn Chen <johnchen@chromium.org>
      Commit-Queue: Ryan Heise <heiserya@google.com>
      Auto-Submit: Ryan Heise <heiserya@google.com>
      Cr-Commit-Position: refs/heads/master@{#818641}
      767a2a9e
    • Austin Sullivan's avatar
      Add OWNERS to Chromium codelab · 2ffabc04
      Austin Sullivan authored
      - Retain "*" as owner
      - Add primary/secondary owner(s)
      
      Bug: N/A
      Change-Id: Iab132e93d107ea6870bef09e40f7d0bc883280d2
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486076Reviewed-by: default avatarDirk Pranke <dpranke@google.com>
      Reviewed-by: default avatarVictor Costan <pwnall@chromium.org>
      Commit-Queue: Dirk Pranke <dpranke@google.com>
      Cr-Commit-Position: refs/heads/master@{#818640}
      2ffabc04
    • Aaron Leventhal's avatar
      Increase reporting of accessibility errors (Round 2) · 98fbece2
      Aaron Leventhal authored
      Make [de]serialization errors fatal for any kind of build used to
      debug Chromium errors. This also restores the fail fast behavior in
      ADDRESS_SANITIZER, which was removed in CL:2468238, because it
      was mistakenly believed the address sanitizer builds had DCHECks on.
      
      AX-RelNotes: n/a
      Bug: None
      Change-Id: I664ab8af7c667b932bbe650c732706d71db9a583
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480142Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
      Reviewed-by: default avatarSadrul Chowdhury <sadrul@chromium.org>
      Reviewed-by: default avatarDaniel Libby <dlibby@microsoft.com>
      Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
      Auto-Submit: Aaron Leventhal <aleventhal@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818639}
      98fbece2
    • chromium-autoroll's avatar
      Roll WebRTC from d40c764ba81e to e15fb15035fe (3 revisions) · 00e53a13
      chromium-autoroll authored
      https://webrtc.googlesource.com/src.git/+log/d40c764ba81e..e15fb15035fe
      
      2020-10-19 hta@webrtc.org Separate RTP object handling (senders, receivers, transceivers)
      2020-10-19 danilchap@webrtc.org Support layer skipping in S2T1 structure
      2020-10-19 olka@webrtc.org Move dynamic memory allocations of webrtc::AudioMixerImpl from RT thead
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/webrtc-chromium-autoroll
      Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Bug: None
      Tbr: webrtc-chromium-sheriffs-robots@google.com
      Change-Id: I59004c693a3ac397ac438e995e27bdaf6b6826a5
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486053Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#818638}
      00e53a13
    • chromium-autoroll's avatar
      Roll PDFium from 1105ef875a93 to 1dd069208c86 (2 revisions) · 458fefbf
      chromium-autoroll authored
      https://pdfium.googlesource.com/pdfium.git/+log/1105ef875a93..1dd069208c86
      
      2020-10-19 thestig@chromium.org Disallow some CFX_ScanlineCompositor conversions.
      2020-10-19 thestig@chromium.org Adjust conditions for some NOTREACHED() in CFX_DIBitmap.
      
      If this roll has caused a breakage, revert this CL and stop the roller
      using the controls here:
      https://autoroll.skia.org/r/pdfium-autoroll
      Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
      is aware of the problem.
      
      To report a problem with the AutoRoller itself, please file a bug:
      https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
      
      Documentation for the AutoRoller is here:
      https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md
      
      Bug: chromium:1017703,chromium:1037839
      Tbr: pdfium-deps-rolls@chromium.org
      Change-Id: I0103642f6d4fbae71c6a006ae2031ed546ad1da0
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486132Reviewed-by: default avatarchromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
      Cr-Commit-Position: refs/heads/master@{#818637}
      458fefbf
    • Trent Apted's avatar
      Load Piex WASM into chrome-untrusted://media-app for decoding RAW. · 8bb8a094
      Trent Apted authored
      Piex is the "Preview Image EXtractor" and is used by the Files app on
      ChromeOS for creating thumbnails inside the "image loader" component
      extension. It uses the `wasm-eval` CSP directive, which is only
      currently enabled for apps and extensions (standardisation being
      discussed at github.com/WebAssembly/content-security-policy/pull/13 ).
      
      To make the WASM work, this CL enables `wasm-eval` for
      chrome-untrusted://* CSP directives, and adds that to
      chrome-untrusted://media-app's CSP.
      
      Two new JS files are added to chrome-untrusted://media-app:
       - piex_module.js is a thin wrapper around the existing piex_loader.js
         to do (effectively) RAW -> JPEG conversions of Blob data.
       - piex_module_loader.js adds logic for runtime-loading of the
         WebAssembly, piex_loader.js, and piex_module.js
      
      An end-to-end test using the handcrafted "raw.orf" file is added to
      ensure the WASM loads and successfully extracts preview data, and it
      is successfully loaded by the app.
      
      Note this CL adds support, but doesn't change file handlers to direct
      RAW files to chrome://media-app, which will be gated behind a flag.
      
      Design Doc: go/bl-raw
      Launch Bug: https://crbug.com/1126203
      
      Bug: 1030935, b/154062029, b/167496867
      Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
      Change-Id: I0c1f1da8bc39c8e6223214b49d9ac09dc93bf420
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422100Reviewed-by: default avatardpapad <dpapad@chromium.org>
      Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
      Reviewed-by: default avatarNoel Gordon <noel@chromium.org>
      Reviewed-by: default avatarPatti <patricialor@chromium.org>
      Commit-Queue: Noel Gordon <noel@chromium.org>
      Auto-Submit: Trent Apted <tapted@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818636}
      8bb8a094
    • Andres Calderon Jaramillo's avatar
      Renew RasterTaskSchedulingDelayNoAtRasterDecodes UMAs. · b5c84d18
      Andres Calderon Jaramillo authored
      Bug: 1140002, 1140003
      Test: None
      Change-Id: I9ecdcd70aae53c4d891b8754e7087c1a989cb7d6
      Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485446Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
      Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#818635}
      b5c84d18