GitLab

In event test output, don't use document object's value, which is a URL.
This helps avoid arbitrary differences in tests, as the port numbers
change between runs.

Bug: None
Change-Id: I7c8d5aee6267b8863a5c8712db1287ded551e5c8
Reviewed-on: https://chromium-review.googlesource.com/1150434
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578663}

Bad-cast to base::TestMockTimeTaskRunner from invalid vptr
in base::TestMockTimeTaskRunner::MockClock::NowTicks

test_task_runner_ was getting destructed before the sequence
manager (which calls the test_task_runner_ upon its
destruction).

Bug: 867790
Change-Id: I412b6a720b4607deeaad1ce80d8bd601dfc04814
Reviewed-on: https://chromium-review.googlesource.com/1152979
Commit-Queue: Farah Charab <farahcharab@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578662}

We no longer have mash vs. classic configs in ash, and there's only one
implementation of ShellPort. As a step towards eliminating ShellPort,
remove the cursor handling methods from it.

Also clean up some code that checks to see if we have a cursor
manager -- ash always has one, for the lifetime of Shell.

This manually reverts parts of
https://codereview.chromium.org/2857963003/

Bug: 866523
Test: ash_unittests
Change-Id: Ic905b26587af6c2cebdd4fcbcf07f85d69515d1e
Reviewed-on: https://chromium-review.googlesource.com/1152544Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578661}

VisualProperties are passed to the RenderViewImpl::Create() method via
the IPC params, then are passed along to the RenderWidget, but in a
lot of different steps.

1st, screen info is passed to the RenderWidget constructor.
2nd, the display mode is set directly on the RenderWidget.
[ a bunch of other initialization here ]
3rd, the whole set of properties is passed to
OnSynchronizeVisualProperties like an IPC was just received.

The 3rd step sends the screen info and the display mode again, though
they won't be changed of course.

This combines step 1 and 2 into one step where they are passed to the
RenderWidget::Init() method. Then we can look at combining with step 3.

R=ajwong@chromium.org, avi@chromium.org

Bug: 419087
Change-Id: Ifcb8eaa0915bb235172e8c5b7bee188e863c18c3
Reviewed-on: https://chromium-review.googlesource.com/1150673
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578660}

Tab-switch requests that are made through devtools for telemetry tests
are not treated as user-gesture. So this metric can not reported in
telemetry tests. However, the cost of this function is not directly
related to the user-gesture itself. So always report this metric and
associated trace event. This allows this to be measured and monitored
in telemetry tests.

BUG=858944

Change-Id: Ib7112b4939c44af099ecfb751fe108bbe8ecec86
Reviewed-on: https://chromium-review.googlesource.com/1152888Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578659}

Fix a typo in
https://chromium-review.googlesource.com/c/chromium/src/+/1142449,that
resulted in over-eager execution of ozone/drm/mojo and hence the
firing of DCHECKs on CrOS in certain configurations.

BUG=867077
TEST=Run with DCHECKs always on.

Change-Id: I239f7927894a9d766d9057f3145e458a0fb2aa6b
Reviewed-on: https://chromium-review.googlesource.com/1152900Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578658}

This is a temp fix for a bug on chromecast screen reader whereby
the item that has a focus ring is not invoked after the user
double taps the screen.

When the touch exploration controller sets an anchor point
explicitly, it issues a click gesture rather than a simulated tap
when the user double clicks the screen.  The click never gets
processed properly by the background page because the
ax tree thinks no window has 'keyboard' focus.  This change
defaults the focus_id field of AXTreeData to be 1 (the root node)
since we only ever have one tree and one window to focus on
anyway.

A long term fix involves fixing other focus issues including
(but not limited to) 1) giving the root window focus via Focus()
call, 2) making sure the root window doesn't lose focus and
3) registering a native widget with the aura::Window or
altering the ax_object_cache logic to not require it when
trying to find the ax tree node corresponding to a window.

Bug: b/111911092
Change-Id: Ide68dbae72288f58711d436db99ef495e5ea9eb0
Reviewed-on: https://chromium-review.googlesource.com/1152897Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Randy Rossi <rmrossi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578657}

We changed the MIME type in https://github.com/w3c/reporting/issues/51
as part of the TAG review of the spec.

Bug: 868065
Change-Id: I4d8020bb39ef12b0695d5f5b16c56eaf2cf0a50e
Reviewed-on: https://chromium-review.googlesource.com/1152069Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Douglas Creager <dcreager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578656}

The string explaining that generated passwords are saved by the Chrome
has changed and does not include a link anymore. This CL removes the
link logic from the modal dialog.

Bug:867572,835234

Change-Id: Id984e5cebbf6bf7fc6e98006ca06b997cdf2575d
Reviewed-on: https://chromium-review.googlesource.com/1151204
Commit-Queue: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578655}

Commit 19105bf3 introduced using constexpr for lots of methods. It introduced
two kinds of regressions building with GCC:
- Some depended on FloatSize::IsZero, which is not only non constexpr, but
  it cannot be constexpr either, as it depends on fabs, that is not constexpr.
- Some depended on methods that were not constexpr (but we could fix them to
  be, as FloatQuat::P1() or FloatSize::SetWidth().

Those do not break in clang as it is a less picky in the scenario of
defining a constexpr method that depends on non-constexpr methods.

This patch fixes usage of constexpr in both cases adding constexpr
implementations when needed. In particular it replaces fabs calls that are
not constexpr at least in libc++ with a constexpr replacement, fixing
GCC build and adding some extra constexpr that were missing.

Bug: 819294
Change-Id: Ia1143ad4be1067bb8a918f0224b657523599ea97
Reviewed-on: https://chromium-review.googlesource.com/1150529
Commit-Queue: José Dapena Paz <jose.dapena@lge.com>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578654}

https://chromium.googlesource.com/catapult.git/+log/787a378926fb..6a67dd77dfc3


git log 787a378926fb..6a67dd77dfc3 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 mattcary@chromium.org Tracing: Fix native library stats for pre-N devices.


Created with:
  gclient setdep -r src/third_party/catapult@6a67dd77dfc3

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:758566
TBR=sullivan@chromium.org

Change-Id: I21b7d9a9d8d414220c338583ca44b04263a5c27f
Reviewed-on: https://chromium-review.googlesource.com/1152618Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578653}

This reverts commit c31de326.

Reason for revert: Findit thinks this is the cause for SingleClientAppsSyncTest.StartWithSomePlatformApps is Flaky becoming flaky. Debug output from the bot shows CHECK in process_handle_win:

[5744:6016:0727/011726.878:FATAL:process_handle_win.cc(29)] Check failed: result != 0 || GetLastError() != ERROR_INVALID_HANDLE. process handle = 00000FB4
Backtrace:
	base::debug::StackTrace::StackTrace [0x73D7A1D6+102]
	base::debug::StackTrace::StackTrace [0x73D7927B+27]
	logging::LogMessage::~LogMessage [0x73DDEFA4+148]
	base::GetProcId [0x73EC8E8E+254]
	content::ChildConnection::IOThreadContext::SetProcessHandleOnIOThread [0x617A7C58+232]
	base::internal::FunctorTraits<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),void>::Invoke<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A8001+81]
	base::internal::InvokeHelper<0,void>::MakeItSo<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *> [0x617A7F0C+124]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunImpl<void (__thiscall content::ChildConnectio [0x617A7E3F+111]
	base::internal::Invoker<base::internal::BindState<void (__thiscall content::ChildConnection::IOThreadContext::*)(void *),scoped_refptr<content::ChildConnection::IOThreadContext>,void *>,void __cdecl(void)>::RunOnce [0x617A7CE4+84]
	base::OnceCallback<void __cdecl(void)>::Run [0x73D1CA90+80]
	base::debug::TaskAnnotator::RunTask [0x73D7E9F3+1075]
	base::MessageLoop::RunTask [0x73E19A64+884]
	base::MessageLoop::DeferOrRunPendingTask [0x73E1A249+73]
	base::MessageLoop::DoWork [0x73E1A5BA+442]
	base::MessagePumpForIO::DoRunLoop [0x73E2775C+28]
	base::MessagePumpWin::Run [0x73E25CA7+119]
	base::MessageLoop::Run [0x73E19366+486]
	base::RunLoop::Run [0x73EDF518+488]
	base::Thread::Run [0x73FF8EF7+375]
	content::BrowserProcessSubThread::IOThreadRun [0x61B456A0+48]
	content::BrowserProcessSubThread::Run [0x61B45589+313]
	base::Thread::ThreadMain [0x73FF97BA+1402]
	base::PlatformThread::GetCurrentThreadPriority [0x73FEBC76+934]
	BaseThreadInitThunk [0x74AD336A+18]
	RtlInitializeExceptionChain [0x771F9902+99]
	RtlInitializeExceptionChain [0x771F98D5+54]

Original change's description:
> Fix invalid handle errors found with App Verifier
> 
> ChildProcessData was holding a raw ProcessHandle which meant that there
> was no guarantee that the handle would be valid when it was used. This
> change switches to a ScopedHandle on Windows, with the associated
> duplication of the handle, so that it is guaranteed to be valid. This
> fixes a frequently encountered use of an invalid handle that was
> detected by Application Verifier. This change also adds a CHECK to
> base::GetProcId to check for use of invalid handles even when not using
> Application Verifier.
> 
> ChildProcessData::handle is now a private member so all references to
> it were updated to use accessors.
> 
> When ChildProcessData::SetHandle is called the handle is duplicated.
> When a ChildProcessData object needs to be copied an explicit
> Duplicate function is called.
> 
> An IsHandleValid helper function was added.
> 
> An invalid test was removed because it was triggering the CHECK in
> base::GetProcId.
> 
> Bug: 417532,821453,865805
> Change-Id: I7e38140335c0140536919341f011f144f150c88f
> Reviewed-on: https://chromium-review.googlesource.com/1145767
> Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
> Reviewed-by: Jochen Eisinger <jochen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578419}

TBR=brucedawson@chromium.org,jochen@chromium.org

Change-Id: I8569cb32ec0cd9cbd99ecf6d5bba7feb672a88cd
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 417532, 821453, 865805, 868384
Reviewed-on: https://chromium-review.googlesource.com/1152374Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578652}

Bug: 866757
Test: chrome://histograms
Change-Id: I232a2869cae577c0fe9ca61f95cf43eb0f8b0416
Reviewed-on: https://chromium-review.googlesource.com/1144904Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Commit-Queue: Maajid <maajid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578651}

https://skia.googlesource.com/skia.git/+log/55b1e6168454..9acfc6cac2c6


git log 55b1e6168454..9acfc6cac2c6 --date=short --no-merges --format='%ad %ae %s'
2018-07-27 csmartdalton@google.com Add kAAHairline to GpuPathRenderers


Created with:
  gclient setdep -r src/third_party/skia@9acfc6cac2c6

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=benjaminwagner@chromium.org

Change-Id: I56878c9191e3e8ade77b7c5220a6401fee7e8dcf
Reviewed-on: https://chromium-review.googlesource.com/1152619Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578650}

This CL changes the descriptions of the strings used in personalized
sign-in promos to add more context for the translators.

Bug: b/111761802
Change-Id: If1064ce114f1c7f4998f4afcce4d65b49a0e8629
Reviewed-on: https://chromium-review.googlesource.com/1152976Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578649}

This reverts commit a73dae7e.

Reasons for revert: This CL breaks jpeg_encode_accelerator_unittest
The test failed with a SIGTRAP.
After reverting the CL, the test passes.

TBR: dcastagna@chromium.org
Bug: b:111832630
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If13254b68a0bbc08863cb477df13810a66874b30
Reviewed-on: https://chromium-review.googlesource.com/1152539
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Reviewed-by: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578648}

The current IdentityTestEnvironment APIs to wait for access token
requests and issue responses operate in a shotgun manner: when the next
access token request is received, the test API implementation issues a
response for *all* pending access token requests. However, unittests
that is targeted in an upcoming conversion requires more flexibility:
as the production code that it is testing interacts with multiple
accounts, the test issues access token requests for multiple accounts,
and then sequentially issues responses and checks that a specific flow
for each account in question was initiated in response to the specific
response. Moreover, one of these unittests issues responses in an
order different to the order in which the requests were made.

To accommodate porting of these tests, this CL adds the ability to wait
for an access token request for a given account and then issue a
response only for that account. If while waiting for a request from a
specific account a request for a *different* account is seen, the
waiting code forwards on the handling of the request for that other
account to the next iteration of the runloop; this allows for the case
where a test wants to handle requests for multiple accounts in an
order different to the order in which those requests were made.

We leave in a variant that does not take in the account ID and operates
as before, as this is convenient for the common case of tests that don't
care about this level of detail (usually because they are testing a
production flow that operates on the primary account).

Bug: 798699, 809923
Change-Id: I6b1d93efd47b1eba128ac0b62c833736700e5196
Reviewed-on: https://chromium-review.googlesource.com/1149876
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578647}

After r541507, requesting functor is not blocked until renderer side
generates a frame. However if functor is called without a frame, it
currently leaves the frame buffer untouched, which is a problem for
parts of the frame buffer that is otherwise untouched.

The ideal solution is to have functor draw the background color. But
hooking this up is relatively complicated.

Instead have java side draw the background color until UI thread
receives returned resources from render thread, which indicates that
parent side has received frames.

Bug: 864436
Change-Id: I8bbf5c6c1353138dff071ff9cfbf58eb6e217eb3
Reviewed-on: https://chromium-review.googlesource.com/1150779Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578646}

https://chromium.googlesource.com/angle/angle.git/+log/604d873e1df5..21e9baf71e6e


git log 604d873e1df5..21e9baf71e6e --date=short --no-merges --format='%ad %ae %s'
2018-07-27 thomasanderson@chromium.org Roll Vulkan-Loader to a835880


Created with:
  gclient setdep -r src/third_party/angle@21e9baf71e6e

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@chromium.org

Change-Id: Ic1232acf3a639dc3df17982206dbfc0faef287bc
Reviewed-on: https://chromium-review.googlesource.com/1152617Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578645}

TBR=zmo@chromium.org
NOTRY=true

BUG=868367
BUG=750896

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: If48cb102f9c217d5e4fcd5c86e2f94907619b10c
Reviewed-on: https://chromium-review.googlesource.com/1152991
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578644}

This test is flaking timeout on Linux (dbg), Mac (dbg), and Linux ASAN.

TBR=rmcilroy@chromium.org

Bug: 867982
Change-Id: I70037407985472c08a3912949a7687fbb78f5434
Reviewed-on: https://chromium-review.googlesource.com/1151764
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578643}

AppKit is eager to allow server-side dragging in the title bar area
(meaning marking the region as draggable at the window server level),
but Views currently decides on a click-by-click basis (see |-hitTest:|).
One AppKit requirement is that, for a view to block title bar dragging,
it needs to return YES from |-acceptsFirstResponder:|, even if it
doesn't actually accept first responder later. BridgedContentView
returned different values at different times, which made dragging
inconsistent. This was sidestepped by overriding |-[NSWindow
_copyDragRegion]|, but that method no longer exists on 10.14.

This change makes |-acceptsFirstResponder| always return YES and removes
the hack. A similar hack is left over to support 10.10. If this change
turns out to not be viable, an override like this should work instead:

    @implementation BrowserNativeWidgetWindow
    // …
    - (NSRect)_opaqueRectForWindowMoveWhenInTitlebar {
      return NSZeroRect;
    }
    //…
    @end

Bug: 855901
Change-Id: I4ef93f1bee1b2cc7b39fab0eec7fe82a526b61e4
Reviewed-on: https://chromium-review.googlesource.com/1152076Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578642}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7399ae5d..8c84d971

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Idd259a0c11d9a21f16a2ac4a6606f99d7a135f99
Reviewed-on: https://chromium-review.googlesource.com/1152892Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578641}

Prior to this CL each replaced element type implemented its own clipping.
This CL refactors it so that a clip node will be applied in the common
path, ReplacedPainter::Paint(), so the specialized
XyzPainter::PaintReplaced() won't need to apply their own clips.

BUG=730284

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4d30fa3a80dfe54d4729b17d1084cd685a8fb712
Reviewed-on: https://chromium-review.googlesource.com/1150866
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578640}

Don't test system impl as it doesn't always respond to interrupt.
Attempt to reduce race in test.

Bug: 866911
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I74dc6c4ffdec4654cb0e0ab2912fb54a8564d717
Reviewed-on: https://chromium-review.googlesource.com/1152988Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Paul Jensen <pauljensen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578639}

This test is working correctly on other platforms.
Try enabling the test to verify that it's no longer flaky.

Bug: 797261
Change-Id: Id31748868eacb41fbc560a877eef22db3e6c29b1
Reviewed-on: https://chromium-review.googlesource.com/1143597Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Liquan (Max) Gǔ <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578638}

|webView:decidePolicyForNavigationAction| is called on subresources
load as well. Pending item and context should not be updated in this
case, otherwise it causes the incorrect CL to be displayed.

Bug: 865893, 866379
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icd721c8044b32cb5088631812ffe2de3c95c9c1b
Reviewed-on: https://chromium-review.googlesource.com/1152112Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578637}

CORSURLLoader uses network::ResourceRequest::request_initiator which
ignores iframe sandboxing, which is a bug. Let's add a simple test for
the behavior.

Bug: 867834
Change-Id: Ia45113503f98b3d18e31c785e703d29eee658d08
Reviewed-on: https://chromium-review.googlesource.com/1151167
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578636}

I moved the code from PaintClosingTabs() to a local lambda and refactored
the code that checks for the hovered states into a separate lambda. Now,
when closing a hovered tab (especially if you add --animation-duration-scale=4.0)
you can clearly see the closing and hovered tab paint with the lower tails
visible until it's gone. While less likley to happen, the code will also
ensure that if there are multiple tabs being closed with an active hover
in progress, they will paint along with the non-closing hovered tabs in
the correct order.

Bug: 867167
Change-Id: Id5d28ef51857390b3f7ec641a8a0c071ce562859
Reviewed-on: https://chromium-review.googlesource.com/1150218
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578635}

This is timing out consistently on the CQ Mac bot, and occasionally
on the waterfall.

TBR=tkent@chromium.org

Bug: 868317
Change-Id: I1e20fd05870f28ed238f8bda6fc82acf1f5b9168
Reviewed-on: https://chromium-review.googlesource.com/1152898Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578634}

Provide a "Enable tracing" option in the menu of the SystemWebViewShell,
to demo/test the new Tracing API functionality. This requires Android P
SDK which has been dropped upstream recently.

When "Enable tracing" is selected the tracing is started. The following
configuration is used:
- trace web-developer categories
- use continuous tracing i.e. a ring buffer

When the user un-checks "Enable tracing" in the menu the tracing is stopped
and the trace data is written to webview_tracing.json in the application
file directory. An alert dialog showing the number of bytes written is
shown upon completion.

Note:
The trace file can be pulled from the device using "adb pull" using the
relevant local directory, e.g.
$ adb pull /data/user/0/org.chromium.webview_shell/files/webview_tracing.json .

BUG=798101

Change-Id: I2a22fbf5f07f12e9c3eadfe9fb027c05b892c092
Reviewed-on: https://chromium-review.googlesource.com/1143820
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578633}

This reverts commit 453eba23.

Reason for revert: Failing Linux ASAN/LSAN bot: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939853423518476256/+/steps/chromeos_unittests/0/logs/ServiceConnectionTest.BindModelProvider/0

Original change's description:
> Add basic ServiceConnection unit test
> 
> The is just testing that ServiceConnection::BindModelProvider returns
> successfully. The Mojo invitation won't go anywhere beyond the no-op
> FakeMachineLearningClient D-Bus client.
> 
> To make this test compile, I had to fix an #include from an
> overlooked file rename in an earlier CL ...
> 
> Bug: 863794
> 
> Change-Id: Ifd31fea950145561cd5954ae16e930b801bfe49b
> Reviewed-on: https://chromium-review.googlesource.com/1139942
> Commit-Queue: Andrew Moylan <amoylan@chromium.org>
> Reviewed-by: Ken Rockot <rockot@chromium.org>
> Reviewed-by: Dan Erat <derat@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578329}

TBR=derat@chromium.org,rockot@chromium.org,amoylan@chromium.org

Change-Id: I9878dee8885c78f88c0af50e70e921861ab87663
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 863794
Reviewed-on: https://chromium-review.googlesource.com/1152371Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578632}

This implements the discovery of BluetoothRemoteGattCharacteristics for
WinRT.

Bug: 821766
Change-Id: Iba0cbe9f7bae4d5a4403bd12193077ad57358387
Reviewed-on: https://chromium-review.googlesource.com/1136310
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578631}

Since it's been a week after pages in top_real_world_mobile were
refreshed, delete the old pages and their corresponding expectations.

Bug: 852530
Change-Id: Ic4d9cb9503fa22dd2b73735404a60c69e2a8a2ba
Reviewed-on: https://chromium-review.googlesource.com/1151104
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578630}

Record the results of the task UKM recording to ensure that we are not
dropping tasks anymore (we used to do so for OOPIFs).

R=eseckler@chromium.org,holte@chromium.org
BUG=866169

Change-Id: I814bd8f71e9e2c0ba6de75f861cb46ca1119aa31
Reviewed-on: https://chromium-review.googlesource.com/1150226
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578629}

This reverts commit f3f5b838.

Reason for revert: Breaks official build: https://crbug.com/868258

Original change's description:
> Reland "[ar] Do not refer to ARCore shim in APK merger"
> 
> This is a reland of 58e4a081
> 
> Original change's description:
> > [ar] Do not refer to ARCore shim in APK merger
> > 
> > This hard-coding should no longer be required.
> > 
> > Bug: 839191
> > Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843
> > Reviewed-on: https://chromium-review.googlesource.com/1147706
> > Commit-Queue: Ian Vollick <vollick@chromium.org>
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#577662}
> 
> Bug: 839191
> Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d
> Reviewed-on: https://chromium-review.googlesource.com/1151567
> Reviewed-by: Richard Coles <torne@chromium.org>
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578347}

TBR=vollick@chromium.org,torne@chromium.org

Change-Id: I1383b1330cb21619fe040ed420487fe33003101f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 839191, 868258
Reviewed-on: https://chromium-review.googlesource.com/1152274Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578628}

ModelAssociationManager used to DCHECK that all DataTypeControllers are
in a NOT_RUNNING state. This apparently assumes that it receives freshly
created DTCs, which isn't actually the case: ModelAssociationManager
gets destroyed during Sync shutdown, but the DTCs don't, so if Sync later
starts up again, there's no guarantee that the DTCs are NOT_RUNNING.

While we're here, also replace some iterator-based loops with range-based
loops.

Bug: 856179
Change-Id: I6a14cbe1955df11aea1c8796ae44b637ff777e58
Reviewed-on: https://chromium-review.googlesource.com/1152922Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578627}

TBR=dpranke@chromium.org

Bug: 868180
Change-Id: Ic9cb48f82954f102f60dd3e1b9c29bcca209f3bb
Reviewed-on: https://chromium-review.googlesource.com/1152566Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578626}

Bug: 866899
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9083c01776240859d0802ce0c09786a3d748daea
Reviewed-on: https://chromium-review.googlesource.com/1152485Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578625}

Always submit a CompositorFrame on OnFirstSurfaceActivation even if
the fallback doesn't change.

Bug: 827242
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I560b5251a188eae2a83db384367e2201ffcce83b
Reviewed-on: https://chromium-review.googlesource.com/1152209
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578624}