- 24 Oct, 2019 40 commits
-
-
Caleb Rouleau authored
Before, we did direct story_set manipulation. This is a bad pattern however per crbug.com/980758 and we would prefer to delete that functionality. Note that this problem could have been solved instead by passing --run-full-story-set into options_for_unittests, but then we would not be removing the usage of RemoveStory, and we would not be running the abridged stories as the smoke tests. Bug: 980758, 965158 Change-Id: I027783d0920409df2d645b7fe8f6c26392aee3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874821Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#709239}
-
Matt Menke authored
With the removal of URLRequestFileJob and URLRangeRequestJob, these classes are no longer in use. Bug: 934009 Change-Id: I68632b3d79609d72762c4fd8a186eac6d5d7c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869726 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709238}
-
Matt Menke authored
They weren't being used in production, other than URLRequestDataJob::BuildResponse(), which just wraps DataURL::BuildResponse, which this CL migrates both existing consumers to. Also slightly clean up the DataURL API. Bug: 934009 TBR: kojii@chromium.org Change-Id: Iea9ec1b607c25bcbc4ee80c12f498c2ad6832e42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869725 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Dan Beam authored
* border-radius on matches: 8px -> 16px * search magnifying glass icons (in matches): 20px -> 16px * change search icon in realbox to Google G icon Fixed: 1017495 Change-Id: I34005dda8e39a91efd35ec884d50e37050af300f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877618 Auto-Submit: Dan Beam <dbeam@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#709236}
-
Tibor Goldschwendt authored
This simplifies the selection code and prepares for moving components into modules. Bug: 870055 Change-Id: I7042eb396cb114a74f7e77933f644184d411ce7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874610 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#709235}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=dominickn@chromium.org Bug: 891670 Change-Id: Ied8aaf4fc0778567283544e64c84b37f3f547c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878373 Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#709234}
-
Mustaq Ahmed authored
It's not clear why this had been added originally 9+ years ago. No longer needed with UAv2. Bug: 959850 Change-Id: I597809c023d1f1b382a27fdca6823ce540b45a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875284Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#709233}
-
Devlin Cronin authored
Most of the JS-based DeclarativeContentCustomBindings are no longer necessary with native bindings (only the setIcon handling still is). Remove the majority of the JS bindings, as well as the CssNativeHandler class (which was only used by the DeclarativeContent JS bindings). Bug: 938998 TBR=halliwell@chromium.org (removing unused include) Change-Id: Ie9bf12f4a050b7b79cd55ef2ff361f19ab913cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879947 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#709232}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9d48adc199ee..1ac605ab1a88 git log 9d48adc199ee..1ac605ab1a88 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 lalitm@google.com trace_processor: add fast path for eq constraints on id columns 2019-10-24 lalitm@google.com perfetto: bump trace processor and traceconv shas to d4a217b1 2019-10-24 lalitm@google.com Merge "trace_processor: add more benchmarks for RowMap and macro tables" 2019-10-24 chiur@google.com Merge "Add VK command buffer to gpu_render_stage" Created with: gclient setdep -r src/third_party/perfetto@1ac605ab1a88 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: chromium:135177627,chromium:142489755 Change-Id: Ifb5f35867d3e4166647f68f291e275b76d03262b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#709231}
-
Xida Chen authored
All the blockers for this feature has been removed, and it is ready to be shipped. Note that normally the "enable-threaded-compositing" is not enabled when running the layout test, and off-thread paint worklet layout tests are meaningless without the compositor thread. So this CL makes the layout tests running on the main thread, which means we need to keep the virtual/threaded/external/wpt/css/css-paint-api/ tests. Bug: 829967 Change-Id: Ie7bd45e09c01729c238c1e3b8fb38e717e84e70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869332 Commit-Queue: Xida Chen <xidachen@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#709230}
-
Torne (Richard Coles) authored
This message gets logged when the WebView is being garbage collected and does not indicate an actual unexpected condition; the caller of getOrSetUserData should be explicitly handling a null return value and it's a bug otherwise. Downgrade the message to debug level so that it will be stripped in release, to avoid app developers assuming that something is broken. Change-Id: Ifb7e38dfc4dbad01cdb952bda1ed40a0431ee445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878989 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#709229}
-
Justin Donnelly authored
This feature's sole purpose is to allow users to opt in to expermental configurations in the Suggest backend. Change-Id: Iee93035a6427eb4999604748c760c37d81259aa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876731 Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#709228}
-
Steven Bingler authored
Modify storage partition cookie helper functions to use MakeAllInclusive() instead of the CookieOptions() in order to prevent test breakage when cookies become SameSite-by-Default. MakeAllInclusive() has a SameSite context of STRICT instead of CookieOptions()'s CROSS_SITE. Bug: 1016512 Change-Id: Id826eeaf0bea5c0bd60dc6380f57fd419d62388d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879561Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#709227}
-
Jan Wilken Dörrie authored
This change modifies base::CommandLine::StringType to be std::wstring on Windows. It relies on changing base::FilePath::StringType to std::wstring on Windows as well, in order to compile once base::string16 is no longer std::wstring. Bug: 911896 Change-Id: I07accc7e043fadf2b584799b699881f300e18bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875748Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#709226}
-
Gary Kacmarcik authored
Bug: 1012545 Change-Id: I8f8573b74691f7721e1549fa69e3ab6ff7949d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879780 Auto-Submit: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#709225}
-
Ryan Sleevi authored
The one place it was used, it was used incorrectly, passing a net::CertStatus instead of a net::Error TBR=mmenke@chromium.org Bug: 618799 Change-Id: Ia668f3e296835a2616aac14071026bf008669366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879848 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#709224}
-
Yuke Liao authored
This CL updates per-cl coverage documentation with percentages. Change-Id: Ib39834a06dfb03b48f4f3449223ebfce91c6a52a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876730 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#709223}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1906f405ba0f..b1a96724321f git log 1906f405ba0f..b1a96724321f --date=short --no-merges --format='%ad %ae %s' 2019-10-24 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-24 tikuta@chromium.org presubmit: remove reserved field from InputProperties Created with: gclient setdep -r src/third_party/depot_tools@b1a96724321f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1002153 Change-Id: I32022b23b8ca18275931ddc01380c77c6b7dd81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879415Reviewed-by:
-
rbpotter authored
showOnLeft_ was updated to be computed based on whether the viewer was in Print Preview, which is set at construction rather than after retrieving strings from the backend. As a result, the document text direction was not yet set and the computation returned the wrong result. Instead, compute show on left one time when strings are set, since neither isPrintPreview nor the document direction should change while the viewer is open. Fixed: 1017081 Change-Id: I849af87b361d889f1655d9d2bdb04b16fcffe454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877816Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#709221}
-
Dana Fried authored
This allows the text associated with the account icon in the toolbar to elide when displaying the entire text would cause the omnibox to become unusably small or force the kebab/wrench menu icon off the side of the toolbar and out of view (see attached bug). We also include some changes in view and label_button so that we don't accidentally report a stale size. The change to caching only text size is because that's the expensive part of the operation - the rest is relatively simple math. Bug: 1012681 Change-Id: I10db6848a317dfa120472b749bcd77762ce6f62b Fixes: 1012681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876128 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#709220}
-
Xianzhu Wang authored
There was another level of mocking in blink. Change-Id: I8824f71848cf775bbb40e9acf4948cc39fed0835 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879471Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#709219}
-
John Budorick authored
Bug: 1011474 Change-Id: I29d326b5d7cd21734b71c2bd4c54c31c265e6f85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879596Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#709218}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e107faa062c4..740f85949db2 git log e107faa062c4..740f85949db2 --date=short --no-merges --format='%ad %ae %s' 2019-10-24 herb@google.com Redo removing annoying link messages Created with: gclient setdep -r src/third_party/skia@740f85949db2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: Ic40f3081b61f708c803d46cfbf22efbd0ff7d0e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879414Reviewed-by:
-
Tom Anderson authored
This change makes it so you don't have to resetart Chrome to see cursor theme changes. Also move some X11 code out of gtk_ui.cc which didn't belong there. BUG=1013426 Change-Id: I1bd3b98cf374783c6805ac23fc839bbf4b21395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869557 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#709216}
-
Michael Spang authored
Avoid an arbitrary default display size of 800x600 on headless. Headless is used on some products that don't have an attached display and having a large dummy display can cause unnecessary work. This doesn't stop tests from creating 800x600 windows; it's fine to create a window larger than the display. Bug: 1017311, 891613 Change-Id: If0ef5b7f41df5a987c4ce1d819432661e00e2a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872949 Commit-Queue: Michael Spang <spang@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Sets up the builders "GPU FYI Win x64 DX12 Vulkan Builder" and "GPU FYI Win x64 DX12 Vulkan Builder (dbg)" along with their associated testers "Win10 FYI x64 DX12 Vulkan [Debug|Release] (NVIDIA)". Also sets up the manual trybot mirrors for these new pairs as "gpu-fyi-try-win10-nvidia-dx12vk-[dbg|rel]-64". Bug: 1010584 Change-Id: I1daa7cc721e50b5d2f44cf434eb33f08e4d128e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846482 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#709214}
-
Tibor Goldschwendt authored
All libraries that are depended on by a single module will be allotted to this module. All other libraries will be allotted to base. The allotment is added to the android_app_bundle template since only there we know about all libraries that are part of a bundle. See go/native-dfm-load-v2 for more context and details. Bug: 870055 Change-Id: Ia2be54a6b46b415842bb8860298e46352332d3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876975 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#709213}
-
Vladimir Levin authored
This replaces a leaky new with a local static variable for the display lock fuzzer environment. This is a speculative fix for the referenced bug. R=schenney@chromium.org Bug: 1013486 Change-Id: I717437eac8d3d6f3d81515e2822209a676047698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873916 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#709212}
-
Zhenyao Mo authored
It seems they cause video frame drop. BUG=995396 TEST=user R=sunnyps@chromium.org Change-Id: I0e0d227e564ba1390478b8020ab84fa2f7e28fae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877049 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#709211}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/13b94d068bdf..154145a8f4cf git log 13b94d068bdf..154145a8f4cf --date=short --no-merges --format='%ad %ae %s' 2019-10-24 tmrts@chromium.org [vinn] Enable snapshots and update Windows d8 binary to 7.6.303.31 Created with: gclient setdep -r src/third_party/catapult@154145a8f4cf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1001953 Change-Id: Ife50995ac73df07dad06c01e8ce970ba921b971b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878868Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1001696 Test: tast ui.OverviewPerf Change-Id: I9dd9ce83b2d626deed1bac718db46fc9c325967a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877533 Commit-Queue: Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709209}
-
Etienne Pierre-Doray authored
This refactors UnPackArchive to return UnPackStatus instead of GetLaastError(). Some errors don't have a clear DWORD mapping and it's more straigthforward to return UnPackStatus as the main result, and use it to decide success/failure at call sites. Change-Id: I0aef82ba65a7cd134a2ecd552cee9b600f188e89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846312Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#709208}
-
Hans Wennborg authored
Bug: 1016947 Change-Id: I5e5f36f5d0e727e35a7d8375cf47eefbfe47eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879927 Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#709207}
-
Tao Bai authored
This reverts commit b01447e6. Reason for revert: The issue cause the test failure has been fixed. Original change's description: > Disable flaky AwSettingsTest#testCacheModeWithBlockedNetworkLoads > > Test is flaky on Lollipop Tablet Tester > > TBR=boliu@chromium.org > > Bug: 1010034 > Change-Id: Ie0de96720fe2396da9032b1cc745445c06dfab61 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1851707 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#704537} TBR=boliu@chromium.org,perezju@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1010034 Change-Id: I295e3f92ba300297e550b9b1164fbf90ec85abb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879334Reviewed-by:
Tao Bai <michaelbai@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#709206}
-
Scott Violet authored
https://chromium-review.googlesource.com/c/chromium/src/+/1845506 modified LayoutBox::SizesLogicalWidthToFitContent() to return true for webkit-blox/webkit-inline-box. This is problematic as the display type does not necessarily correlate to the LayoutObject that is used. The right fix is to look at the display type *and* the LayoutObject used. BUG=1014001 TEST=external/wpt/compat/webkit-box-fieldset.html Change-Id: I80cc6d166e02c1e2ec6c2c0c58bcf770793ca41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874250 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#709205}
-
Kyle Horimoto authored
Spinner functionality in <network-config> broke due to a refactor [1] which started using a template with if="[[!managedProperties_]]". However, managedProperties_ starts out as undefined, and Polymer does not evaluate if's whose properties are all undefined [2]. Since, in this case, the managedProperties_ property is the only one used, all of the properties are undefined, and the template was never evaluated until the properties were received and the spinner was no longer needed. This CL fixes the issue by explicitly using null instead of undefined in this case. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1803724 [2] https://polymer-library.polymer-project.org/2.0/docs/devguide/observers#observers-and-element-initialization Fixed: 1014057 Change-Id: I1f8775fc3136387508959f1fc914aa564434fac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879752Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#709204}
-
Matt Menke authored
These used to query a global set of factories reflecting all schemes that Chrome supported, which have mostly long since gone away. The only remaining global factories it queries against are for http(s) and ws(s). I want to clean up those remaining two global factories, so this CL removes those functions and inlines the schemes into the pre-existing lists of all other supported schemes. Bug: 488166 Change-Id: I2ff34752a91a1c4eede18e271a90b6ed922314c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869398Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#709203}
-
Rohit Rao authored
BUG=987646 Change-Id: I2443f70f0981be8c9022e63c540625f88956d40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869331 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
Varun Khaneja authored
R=holte Bug: 963165,966646 Change-Id: I20bbbeaa848528e7a0705dc1c22492fd0efee8aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877665 Auto-Submit: Varun Khaneja <vakh@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#709201}
-
Eric Seckler authored
This was missing before, rendering the flag useless for non-browser process tracing. Change-Id: I49222c8582432b1ebe72695bca5d434f0097130f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877016 Auto-Submit: Eric Seckler <eseckler@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
