GitLab

https://chromium.googlesource.com/chromiumos/chromite.git/+log/81cbcd45e1a2..97b903782cf5


git log 81cbcd45e1a2..97b903782cf5 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 dgarrett@google.com binhost_test: Ignore boards from branch builders.


Created with:
  gclient setdep -r src/third_party/chromite@97b903782cf5

The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: I10b01f0474a15ce38af67d499bc4380cfdaa4000
Reviewed-on: https://chromium-review.googlesource.com/c/1355359Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612242}

APIPermission::CreateAPIPermission() returns a newly-created
APIPermission object. Update it to return a unique_ptr rather than a
raw c-style pointer.

Bug: 907661
TBR=dominickn@chromium.org (mechanical change to chrome_apps_api_permissions.cc)

Change-Id: Ia27e4d7da11fce00e30f0fd1720f110e22d74346
Reviewed-on: https://chromium-review.googlesource.com/c/1347796
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612241}

As of refs/heads/master@{#608185}, it is no longer a DrawingDisplayItem.

Change-Id: If25c6d41fdc15dd3bf3b21360eb3306105a1c75e
Reviewed-on: https://chromium-review.googlesource.com/c/1355322
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612240}

Bug: 906654
Change-Id: I08817df22c5043ec92ae51b7deeae15ceb1877ee
Reviewed-on: https://chromium-review.googlesource.com/c/1354690Reviewed-by: Emily Hanley <eyaich@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#612239}

Currently upon collecting the inputs for the mutation on main thread, we
don't offset the current time by the start time which is incorrect.

Note:
The layout test animations/animationworklet/worklet-animation-currentTime.html
fails the release build because AnimationClock::currentTime is often
incorrectly ahead of rAF time so that when asking for the current time
in a rAF via getComputedStyle it returns obsolete result. This bug is
tracked by https://crbug.com/785940.

Bug: 905405
Change-Id: I0b7e293ae942e47b96eb8a7a2a8fefd94be66773
Reviewed-on: https://chromium-review.googlesource.com/c/1343558
Commit-Queue: Yi Gu <yigu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612238}

Using wpt-import in Chromium fc5105a0.

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
mstensho@chromium.org:
  external/wpt/css/css-multicol

NOAUTOREVERT=true
TBR=kyleju

No-Export: true
Change-Id: Ife778af6d81007e56deb6b68e7b5d12b946551d0
Reviewed-on: https://chromium-review.googlesource.com/c/1351265
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612237}

Uses IdentityManager API instead of using the soon to be
private ProfileOAuth2TokenService and AccountTrackerService
APIs.

Bug: 908855
Change-Id: If533b43a698b2f2ea7c24ad43273b4ecba74091f
Reviewed-on: https://chromium-review.googlesource.com/c/1354447Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612236}

Migrated the SigninManager APIs to the identity APIs.

Bug: 890815
Change-Id: Id145953cdece6f58222bedaadbf3358ac3491665
Reviewed-on: https://chromium-review.googlesource.com/c/1354198
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612235}

Pass the account_id by const reference instead of requiring a
new std::string each time (since this is invoked in a loop, it
can cause lots of unnecessary allocations).

Bug: none
Change-Id: I5c2f2e53e12616ed5e518250fb965babbd9e68db
Reviewed-on: https://chromium-review.googlesource.com/c/1350910Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612234}

Removing the CTFont based construction when rolling to HarfBuzz' native
AAT lead us to falling back to attempting the mmap'ed access to the font
SkStreamAsset. However, the implementation for onOpenStream in
SkTypeface_Mac is highly inefficient and synthesizes a font from copying
all tables. Disable this type of instantiation on Mac and use the table
copy method instead.

This should address memory regression for the HarfBuzz AAT roll [1].

[1] https://chromium.googlesource.com/chromium/src/+/c67f53b0b70f33c47159d37f7e59bb44399b0d09

Bug: 908552
Change-Id: Ibf19ea6308f34fd4927e2b7fd59cdff20f3aad6d
Tbr: eae@chromium.org, behdad@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1355129Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Behdad Esfahbod <behdad@chromium.org>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612233}

Now that we're using Shadow DOM v1, we have the option to make the
shadow DOM unreachable by outside script by specifying a closed
encapsulation mode. Now GuestViews will behave more like other
elements defined by the browser which internally use shadow DOM.
This also prevents script from interfering with our internal elements
and producing unexpected behaviour.

Bug: 892886, 803274
Change-Id: I57b2513e3ff7290e286b3d8391e7d93bac2bc4e9
Reviewed-on: https://chromium-review.googlesource.com/c/1342768
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612232}

This change modifies the "Passwords" entry in the settings page to link
to the Google Password Manager if the necessary conditions are met.
Currently this includes users that are syncing their passwords without
a custom passphrase and for which the corresponding Google Password
Manager experiment is active.

Bug: 904821
Change-Id: If93ee671b1c1b9aee17467aa9382fe5e834ead55
Reviewed-on: https://chromium-review.googlesource.com/c/1350877
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612231}

TBR=dmazzoni@chromium.org
NOTRY=true

Change-Id: Ib20e44b272d84612d480bf3cccf4bbf8dec20fa1
Bug: 498881
Reviewed-on: https://chromium-review.googlesource.com/c/1355323
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612230}

This change allows the reprioritization of HttpProxyConnectJobs by
adding a SetPriority method to the underlying
HttpProxyClientSocketWrapper. Depending on the type of proxy client
socket being requested, the reprioritization is passed down to the
transport or SSL socket pool, or the SPDY or QUIC stream request.

Bug: 166689
Change-Id: I593632a48ee43141277e5c50f81fda57662f523c
Reviewed-on: https://chromium-review.googlesource.com/c/1343047
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612229}

The base perftests can take longer than the default 120 seconds to
execute -- especially on low end Android devices. Increase the timeout
on Android to 10 minutes.

Bug: 906686
Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918

TBR=fdoray@chromium.org

Change-Id: Iacfe08e3cbd1d6e7ef756a1a8c1028655a5d3918
Reviewed-on: https://chromium-review.googlesource.com/c/1353922Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612228}

Also adjusted the paddings to account for the different aspect ratio of the new image.

Bug: 806868
Change-Id: I7bd161dfd8b74b784d934ba5ec1dce37793bfe85
Reviewed-on: https://chromium-review.googlesource.com/c/1352161Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612227}

Records preview-type-agnostic counts for: Previews.OptOut.UserOptedOut,
Previews.PageEndReason, and Previews.EligibilityReason

Bug: 904009
Change-Id: I13506b3b002a83a78d38a79006a02afa13a1c29f
Reviewed-on: https://chromium-review.googlesource.com/c/1354564Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Doug Arnett <dougarnett@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612226}

We need OWNERS for the commands folder, especially as they are actively
being refactored.

Change-Id: I106373a92ea59db68514546d5315a5e4110610a9
Reviewed-on: https://chromium-review.googlesource.com/c/1354495
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612225}

Prevented ChromeOS-specific funcionality from compiling
for other platforms. To be used for EXO on cast shell.
This CL does not offer any additional functionality.

Bug: 896710
Test: Run exo_unittests on ChromeOS
Change-Id: I72678ae35efce395f932b7d0ade816d61dd6e992
Reviewed-on: https://chromium-review.googlesource.com/c/1327402
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612224}

Change-Id: Id425ec396cd9d1779138133e725dfcd0c2ef0f2c
Reviewed-on: https://chromium-review.googlesource.com/c/1354263Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Commit-Queue: Vincent Boisselle <vincb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612223}

Bug: 882404
Change-Id: I3fc0c70ba2694dd2e513c1a882c505471db6fccf
Reviewed-on: https://chromium-review.googlesource.com/c/1355161Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Commit-Queue: John Lin <chuanl@google.com>
Cr-Commit-Position: refs/heads/master@{#612222}

Bug: 905524
Change-Id: I7856854bada0ef0a0285a4f3b0d362f9c2113f97
Reviewed-on: https://chromium-review.googlesource.com/c/1354781Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612221}

https://chromium.googlesource.com/angle/angle.git/+log/5f01324fb627..a1442ecdf514


git log 5f01324fb627..a1442ecdf514 --date=short --no-merges --format='%ad %ae %s'
2018-11-29 syoussefi@chromium.org Vulkan: Uber-shader support


Created with:
  gclient setdep -r src/third_party/angle@a1442ecdf514

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: Ib215ad81b09d61c2a14339eb20274b0a40170b7d
Reviewed-on: https://chromium-review.googlesource.com/c/1354984Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612220}

Add a java interface AwFunctor to so AwContents does not have to
explicitly distinguish between GL and Vulkan functor. Rename some
method names so they make more sense, and make AwGLFunctor inherit
from the new interface.

Bug: 900965

Change-Id: I39cfa73696ce71f2fd38b11240665176718a8941
Reviewed-on: https://chromium-review.googlesource.com/c/1354679
Commit-Queue: Bo <boliu@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612219}

The Add to Homescreen feature will now consider "maskable" icons from
the web app manifest [1]. If a maskable icon is present and we are on
an Android O+ device, turn that "maskable" icon into an Android Adaptive
icon [2].

The icon is scaled to ensure that the safe zone is preserved [3].

[1]: https://w3c.github.io/manifest/#purpose-member
[2]: https://developer.android.com/guide/practices/ui_guidelines/icon_design_adaptive
[3]: https://github.com/w3c/manifest/issues/555#issuecomment-404097653

Bug: 904354
Change-Id: Iedfe61ace0fda4ca7f3ed3da6a5d07f2bff81443
Reviewed-on: https://chromium-review.googlesource.com/c/1341998
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612218}

Also cleanup the test names to be more descriptive of what parameter were used.

Bug: 907443
Change-Id: I4a42d1aad2856beda89911e63256ea8d0f67bb54
Reviewed-on: https://chromium-review.googlesource.com/c/1349751Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@google.com>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612217}

This CL is implementing the Phase 1 described in this doc:
https://docs.google.com/document/d/1v-k8Ck7x_2kpBfgaVmqg2NvQRvD1PqyOt50rdO141Wc/edit#

Basically, it redefines the StylePropertyMapReadOnly to be a pure
interface. Then it renames the existing StylePropertyMapReadOnly to
StylePropertyMapReadOnlyMainThread. Then it makes all subclasses of
StylePropertyMapReadOnly to be subclasses of
StylePropertyMapReadOnlyMainThread.

This CL should not introduce any behavior change.

Bug: 895579
Change-Id: I400981d1745ab3ee80b9ba9b77c3e3406cd0c1e7
Reviewed-on: https://chromium-review.googlesource.com/c/1354118
Commit-Queue: Xida Chen <xidachen@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612216}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f9b825600fd5..73b3bde2659f


Created with:
  gclient setdep -r src-internal@73b3bde2659f

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I08d3f91a6e9df0b9fae9c87647e6eef01b3fd175
Reviewed-on: https://chromium-review.googlesource.com/c/1354987Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#612215}

This CL moves the tests in http/tests/event-timing to external/wpt/event-timing.
The slow image is change from php based to python based. The click is now
handled by test driver. and setTimeout is replaced with step_timeout.

Bug: 841224, 908187, 907948, 907949
Change-Id: Ia6359878666cfb96645aa3b7cd7736ce9df97683
Reviewed-on: https://chromium-review.googlesource.com/c/1352617Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612214}

Point to paths that actually exist after the great Blink mv from a while
ago.

TBR=haraken

Change-Id: I22431a1abdf786ad9fe98188df5002e60733a182
Reviewed-on: https://chromium-review.googlesource.com/c/1355165Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Cr-Commit-Position: refs/heads/master@{#612213}

R=khorimoto@chromium.org

Bug: none
Test: none
Change-Id: I4056cee71621cb850d86d2a4e42d8c99ef90374d
Reviewed-on: https://chromium-review.googlesource.com/c/1354644Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: James Hawkins <jhawkins@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612212}

Specifics:
       +66,536 bytes main lib size
      +470,476 bytes main dex size
      +759,062 bytes normalized apk size
InstallSize:
      +291,292 bytes APK size
      +841,749 bytes Estimated installed size (Android Go)
    +2,192,016 bytes Estimated installed size
InstallBreakdown (+2,192,664 bytes):
        +2,706 bytes unwind_cfi (dev and canary only) size
        +2,690 bytes Non-compiled Android resources size
       +66,536 bytes Native code size
          +580 bytes Package metadata size
    +2,104,848 bytes Java code size
       +15,304 bytes Compiled Android resources size
Dex:
        +2,412 entries fields
        +3,295 entries methods
          +777 entries types
        +1,694 entries strings

Bug: 908594, 907155, 907085
Change-Id: I80b5466e726baa76aa05ecc9a01269094f0046ba
Reviewed-on: https://chromium-review.googlesource.com/c/1354350
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612211}

* Use dist_jar() rather than a custom script
  * Avoids needing to extract .jars.
  * Avoids needing to reference ".javac.jar" files, which
    are somewhat of an implementation detail.

* Added jar_excluded_patterns support to dist_jar()

* Merges zip.py and dist_jar.py, since they were doing the
  same thing.

Spot checked that these two jars are the same before/after:
* cronet/cronet_impl_common_java.jar
* cronet/cronet_impl_native_java.jar

Change-Id: I4d5a5f495ce0376ef2e53b6d4e3c9ebbc3d75ae1
Reviewed-on: https://chromium-review.googlesource.com/c/1349872Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612210}

This CL makes sure that the omnibox suggestions labels width is taking
into account the presence of the "switch to open tab" button.

Bug: 908874
Change-Id: I92ce30dabadc511a319b43879baa125fa080e0f8
Reviewed-on: https://chromium-review.googlesource.com/c/1353940
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612209}

base::ContainsValue tries to compare the value to the element in
container. Unfortunately for a map, this isn't possible since the
returned element is a pair<>.

Bug: None
Test: Compile cast_shell
Change-Id: I3d072442f7d9e9c895adc934133f626abe104a88
Reviewed-on: https://chromium-review.googlesource.com/c/1354348Reviewed-by: Alex Sakhartchouk <alexst@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612208}

MessageLoop will go away, eventually.

BUG=891670

Change-Id: I6b2246cf59b8454ab0a6522bc7825bbcd9e76e12
Reviewed-on: https://chromium-review.googlesource.com/c/1352368Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#612207}

Bug: 908834
Change-Id: I3b0b80f8fd31c88d29bafa5bcaff0f2f6ef104a7
Reviewed-on: https://chromium-review.googlesource.com/c/1355180Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612206}

This CL converts ImportDataCollectionViewController to use UITableView
instead of MDCCollectionViewController.

Bug: 894791
Change-Id: I38a99ae849ef2b30d90820b197f4ba56edadabba
Reviewed-on: https://chromium-review.googlesource.com/c/1352156
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612205}

Adding // namespace xxx after namespace definition.
This is simplify a little:
https://chromium-review.googlesource.com/c/chromium/src/+/1280249/68/ios/chrome/browser/signin/gaia_auth_fetcher_ios.h

Change-Id: Icd3b07d450ed2af65662587359bf036966f5f1f4
Reviewed-on: https://chromium-review.googlesource.com/c/1355100Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612204}

Change-Id: If915537bcca19f6b67ba8d70d8a9a944885faa8c
Reviewed-on: https://chromium-review.googlesource.com/c/1353926Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612203}