GitLab

BUG=596039
TEST=none
TBR=guidou

Review-Url: https://codereview.chromium.org/2028953003
Cr-Commit-Position: refs/heads/master@{#397108}

This CL adds a new API, V8PrivateProperty::hasValue().

BUG=

Review-Url: https://codereview.chromium.org/2027113003
Cr-Commit-Position: refs/heads/master@{#397107}

A ScriptLoader that has become detached from its document will not
execute the script once the script resource has loaded.

If in such a detached state, make sure the ScriptLoader lets go
of its PendingScript promptly.

R=
BUG=

Review-Url: https://codereview.chromium.org/2028613002
Cr-Commit-Position: refs/heads/master@{#397106}

This CL also moves out the dependency on skia
resource_format.h to resource_format_utils. This was to avoid
adding skia as a public dependency from the
TransferableResource StructTraits.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/2020993004
Cr-Commit-Position: refs/heads/master@{#397105}

Revert of [ios Mojo] Integration test for Mojo WebUI. (patchset #9 id:160001 of https://codereview.chromium.org/2006273005/ )

Reason for revert:
Breaks downstream ios_internal_unittests execution because ios_internal_unittests already has resource load code and the bundle ends up being loaded twice. Please remove this code downstream, also see comments in code review tool.

Original issue's description:
> [ios Mojo] Integration test for Mojo WebUI.
>
> Tests communication between WebUI page and the native code.
> When page is loaded it sends "syn" message to the native code,
> when native code receives "syn" it replies back with "ack",
> when page receives "ack" it replies back with "fin". Once "fin" is
> received the test succeeds.
>
> BUG=567809
>
> Committed: https://crrev.com/dc9e9709213948d4db6308f71c4097950b9da8fa
> Cr-Commit-Position: refs/heads/master@{#396972}

TBR=rockot@chromium.org,jyquinn@chromium.org,sdefresne@chromium.org,thestig@chromium.org,eugenebut@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=567809

Review-Url: https://codereview.chromium.org/2027983002
Cr-Commit-Position: refs/heads/master@{#397104}

BUG=589802
TEST=none
TBR=guidou

Review-Url: https://codereview.chromium.org/2032463002
Cr-Commit-Position: refs/heads/master@{#397103}

ClientResolution message contains DIPs and device size fields. DIPs
size was marked as legacy, but it was actually used by the host. It's
best to use DIPs for consistency with other messages, particularly
VideoTrackLayout. marked device-pixel size as deprecated and the host
now works when width/height fields are not specified.

Review-Url: https://codereview.chromium.org/2021773002
Cr-Commit-Position: refs/heads/master@{#397102}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/6f8618f8..349ac04f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2026243002
Cr-Commit-Position: refs/heads/master@{#397101}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/e288c0d9a188..14820dc4a7cd

$ git log e288c0d9a..14820dc4a --date=short --no-merges --format='%ad %ae %s'

BUG=613970

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2031473002
Cr-Commit-Position: refs/heads/master@{#397100}

BUG=459022

Review-Url: https://codereview.chromium.org/2027653004
Cr-Commit-Position: refs/heads/master@{#397099}

This is used by the Chrome on iOS today extension to get information
about the nearby devices and display them when user has enabled the
physical web integration.

Introduce a new target //ios:all to list all targets build on iOS
and add a dependency on it from //:gn_all. This will avoid changing
root BUILD.gn every time an iOS target is added upstream.

BUG=615799

Review-Url: https://codereview.chromium.org/2023833002
Cr-Commit-Position: refs/heads/master@{#397098}

* Do not parse Alt-Svc response on insecure connections, add regression test.
* Do not follow in-memory Alt-Svc on insecure connections, add regression test.

This CL has a shortcut: |enable_alt_svc_for_insecure_origin|, which is false in
production but true in tests (except for the two regression tests).  Adapting
the existing tests is a lot of work, that will come in one or more follow-up
CLs.

BUG=615497

Review-Url: https://codereview.chromium.org/2026863002
Cr-Commit-Position: refs/heads/master@{#397097}

This change puts into use the TreeStateTracker class by wiring it to:
* A global STHDistributor for receiving fresh STHs via the component
  updater.
* The per-profile CTVerifier for receiving notification of verified
  SCTs that should be checked for inclusion.

As discussed with sorin and rsleevi, the wiring of the STHSetComponentInstaller
is via a globally-accessible STHDistributor, created by the IOThread.

BUG=613501

Review-Url: https://codereview.chromium.org/2014573002
Cr-Commit-Position: refs/heads/master@{#397096}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/7a441a0..c0150c6

TBR=

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_archive_rel_ng;tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2028973002
Cr-Commit-Position: refs/heads/master@{#397095}

This removes the special string type the parser was using in favor of
StringView. In doing so it also makes all of the string allocations
inside the parser more explicit.

Doing this requires adding equalIgnoringASCIICase for StringView, and
also operator[], tests are included. :)

One major change is now StringView::toString() will attempt to create
an 8bit string from a 16bit StringView whenever possible. This does
mean potentially wasted work inside StringImpl::create8BitIfPossible
if callers are frequently making strings with unicode characters in
them. We should see how often this happens in practice, and probably
optimize the code in create8BitIfPossible to first scan the string
to avoid the wasted malloc.

BUG=615174

Review-Url: https://codereview.chromium.org/2024373002
Cr-Commit-Position: refs/heads/master@{#397094}

Revert of headless: Allow protocol handler customization (patchset #3 id:40001 of https://codereview.chromium.org/2024973002/ )

Reason for revert:
Doing another review round with net/.

Original issue's description:
> headless: Allow protocol handler customization
>
> Allow headless clients to provide custom protocol handlers. This lets
> the clients override how URL requests are fulfilled for different
> schemes types.
>
> Design doc: https://docs.google.com/document/d/1m4CCZGJWOJdHY5MVwQqY3sT-5kBoz7NqmGvIb6-l3fM/edit#bookmark=id.5bqp8w95liri
>
> BUG=595353
>
> Committed: https://crrev.com/789f9abbbc69e5d485984a9d7b4e3d167054919f
> Cr-Commit-Position: refs/heads/master@{#396884}

TBR=altimin@chromium.org,alexclarke@chromium.org,eseckler@chromium.org,rsleevi@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=595353

Review-Url: https://codereview.chromium.org/2026253002
Cr-Commit-Position: refs/heads/master@{#397093}

It has become flaky on the Win7 Tests bot.
Root cause for the flakiness is not clear yet.

BUG=616388
TBR=phoglung@chromium.org

Review-Url: https://codereview.chromium.org/2027963002
Cr-Commit-Position: refs/heads/master@{#397092}

The flakiness dashboard for
virtual/threaded/animations/restart-not-visible.html
shows that the test is currently timing out on debug builds and
passing everywhere else. This patch updates the entry for this test
in TestExpectations to be more specific.

BUG=567230

Review-Url: https://codereview.chromium.org/2022093003
Cr-Commit-Position: refs/heads/master@{#397091}

security_blacklist.txt is a merge of blacklist.txt and vptr_blacklist.txt.

BUG=609786

Review-Url: https://codereview.chromium.org/2018973002
Cr-Commit-Position: refs/heads/master@{#397090}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4ca545e6..6f8618f8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2026233002
Cr-Commit-Position: refs/heads/master@{#397089}

The method is clearly documented to be called regardless of the input type,
but for our purpose, it is needed only when the client is really requiring
text input.

BUG=b/28930470

Review-Url: https://codereview.chromium.org/2027123002
Cr-Commit-Position: refs/heads/master@{#397088}

Chrome on iOS needs to use "-ObjC" to link all symbols from static
libraries that define at least one Objective-C category or class.
Add it to the ios_app_bundle template so that it is used by all
executables.

BUG=459705

Review-Url: https://codereview.chromium.org/2024673002
Cr-Commit-Position: refs/heads/master@{#397087}

This change fixes ld.bfd failure when GN is used,
which was caused by missing "-Wl,-rpath-link=" path.

BUG=616082
TEST=Build Chromium for Linux MIPS using ld.bfd and GN

Review-Url: https://codereview.chromium.org/2025883002
Cr-Commit-Position: refs/heads/master@{#397086}

The spec was changed due to a compat problem in Gecko, and Gecko has
already changed as well, "since no one except for us bothered to
implement the spec":
https://bugzilla.mozilla.org/show_bug.cgi?id=1260515
https://github.com/whatwg/xhr/issues/66

Intent to Deprecate thread updated:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BOgLhbdljU4

BUG=383483

Review-Url: https://codereview.chromium.org/2025903002
Cr-Commit-Position: refs/heads/master@{#397085}

Get rid of an unused function FrameSelection::setNonDirectionalSelectionIfNeeded() for VisibleSelection

This patch gets rid of an unused function |VisibleSelection| version of
|FrameSelection::setNonDirectionalSelectionIfNeeded()| to reduce source code
size for improving code health.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2024703005
Cr-Commit-Position: refs/heads/master@{#397084}

This is a preparation of base::Bind for move-only variants of Callback,
and also a preparation of the oneshot variant of Callback.

On InvokeHelper mod, this CL moves Runnable from a class template
parameter to a function template parameter of InvokeHelper::MakeItSo,
so that it can run &&-qualified Run() method via rvalue-reference
Runnable.

On BindState mod, BindState ctor will forward Runnable as Perfect
Forwarding into its internal storage. So that BindState can hold
move-only Runnable into it.

BUG=554299

Review-Url: https://codereview.chromium.org/1798403002
Cr-Commit-Position: refs/heads/master@{#397083}

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssperspective

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG=610172

Review-Url: https://codereview.chromium.org/2024023002
Cr-Commit-Position: refs/heads/master@{#397082}

This patch suppresses opening the launcher and show app-installed notifications instead after user installs apps from CWS.

Even with this patch, the app launcher is opened to show the installation progress. It'll be suppressed in the separated patch,

BUG=606843
TEST=manual tested

Review-Url: https://codereview.chromium.org/1993583002
Cr-Commit-Position: refs/heads/master@{#397081}

Revert of Clear ui::Layer damaged_region_ after commit. (patchset #2 id:20001 of https://codereview.chromium.org/2018223002/ )

Reason for revert:
This CL is suspect of breaking Linux Tests bots.

See crbug.com/616387

I will reland if the revert doesn't fix the bots.

Original issue's description:
> Clear ui::Layer damaged_region_ after commit.
>
> This was only being cleared for ui::Layers with PictureLayers and not
> those with TextureLayers, so all frames afterwards would have
> unnecessary damage.
>
> BUG=610086
>
> Committed: https://crrev.com/5ab42edc1361fee3b5255dd36bc8663dfb44cb5e
> Cr-Commit-Position: refs/heads/master@{#396936}

TBR=danakj@chromium.org,jbauman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610086

Review-Url: https://codereview.chromium.org/2027953002
Cr-Commit-Position: refs/heads/master@{#397080}

When this class was implemented, it was used for only raster work. But
we had started using it for other tasks, along with raster tasks, being
scheduled with different interfaces provided in the class.

BUG=599863

Review-Url: https://codereview.chromium.org/2021323002
Cr-Commit-Position: refs/heads/master@{#397079}

Fix SVGElement::setCursorImageValue() to take a const
CSSCursorImageValue* instead of just a regular pointer. This is required
pre-work to make StyleBuilderFunctions take const references (since,
when calling into SVGElement::setCursorImageValue from
StyleBuilderFunctions, only a const pointer is available).

BUG=526586

Review-Url: https://codereview.chromium.org/2027113002
Cr-Commit-Position: refs/heads/master@{#397078}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/5199aa0a..4ca545e6

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2022253003
Cr-Commit-Position: refs/heads/master@{#397077}

BUG=591606

Committed: https://crrev.com/5adc4454691bffcbfdc7cd60866c145a4e67de0d
Cr-Commit-Position: refs/heads/master@{#396410}

Review-Url: https://codereview.chromium.org/2007283002
Cr-Commit-Position: refs/heads/master@{#397076}

To track permission usages even for constant permissions, call
PermissionUmaUtil::PermissionRequested() for such permission types from
PermissionManager::RequestPermissions().

BUG=n/a

Review-Url: https://codereview.chromium.org/2026663002
Cr-Commit-Position: refs/heads/master@{#397075}

IPC messages including WebSocket messages are dispatched on the default
task runner. We found WebSocket message handlers might call V8
functions. We plan to implement purge + suspend background tabs and need
to suspend all V8 function calls when purge + suspend happens, but the
default task runner can't be suspended since it'd be dangerous. Thus,
this CL delegates WebSocket message handlers from the default task
runner to the loading task runner.

BUG=607077
TEST=n/a

Review-Url: https://codereview.chromium.org/2000113002
Cr-Commit-Position: refs/heads/master@{#397074}

For the switch kEnableTransparentVisuals to be effective it requires
a compositing manager to run. Indeed ui::ChooseVisualForWindow checks
for the presence of the Atom _NET_WM_CM_S0 before looking for a 32
bit depth compatible visual.

BUG=589509

R=dpranke@chromium.org, piman@chromium.org, sky@chromium.org, danakj@chromium.org

Review-Url: https://codereview.chromium.org/2008833002
Cr-Commit-Position: refs/heads/master@{#397073}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c10547f3..5199aa0a

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2027073003
Cr-Commit-Position: refs/heads/master@{#397072}

I had different arguments in the code that the ones with which the histogram was constructed resulting in an error:
F/chromium(15305): [FATAL:record_histogram.cc(59)] Check failed: histogram->HasConstructionArguments(expected_min, expected_max, expected_bucket_count). NewTabPage.Snippets.CardClickedAge/0/4320/50 vs. NewTabPage.Snippets.CardClickedAge/1/4320/50

BUG=615379

Review-Url: https://codereview.chromium.org/2017013004
Cr-Commit-Position: refs/heads/master@{#397071}

BUG=591500
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/2027903002 .

Cr-Commit-Position: refs/heads/master@{#397070}

This patch introduces |m_scriptState| member variable to
|ScriptCustomeElementDefinition| class to hold |ScriptState| pointer, to
return |ScriptValue| for JavaScript's constructor, prototype, callbacks,
etc, on the context where JavaScript values created.

This patch is a preparation of crrev.com/1994093002, introduce
|CustomElementRegistry#get()| method.

BUG=594918
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2030443003
Cr-Commit-Position: refs/heads/master@{#397069}