GitLab

BUG=422235
R=sergiyb@chromium.org

Review URL: https://codereview.chromium.org/677023002

Cr-Commit-Position: refs/heads/master@{#301081}

Use size_t throughout, and avoid mixing size_t and uint32_t.

No behavioural effect.  Unsigned leb128 is currently used
only on 32-bit arm, and here uint32_t and size_t are equivalent.

BUG=385553

Review URL: https://codereview.chromium.org/668543003

Cr-Commit-Position: refs/heads/master@{#301080}

BUG=426020

Review URL: https://codereview.chromium.org/663183002

Cr-Commit-Position: refs/heads/master@{#301079}

BUG=

Review URL: https://codereview.chromium.org/675103003

Cr-Commit-Position: refs/heads/master@{#301078}

The removed comment speaks about StubContentSettingsClient, which was not created in https://codereview.chromium.org/646973002 after all, and thus does not exist in the ToT.

This is a comment-only change, thus skipping tests.

TBR=blundell@chromium.org
NOTRY=true
BUG=393248

Review URL: https://codereview.chromium.org/663933003

Cr-Commit-Position: refs/heads/master@{#301077}

Previously onMessage function of FileManagerBrowserTest returns a string, but
the format of the return values is not consistent among the message types.

Also the onMessage function retunrs the value even if it is fatal error, but for
the case, we can stop the test directly in the function.

The CL removes unrequired result values, and adds test assertions for fatal
errors.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/667843005

Cr-Commit-Position: refs/heads/master@{#301076}

Remove the old SocketStream-based WebSocket implementation from
content/.

Large parts of the implementation still exist in net/. They will be
removed in a subsequent CL.

There are also a few traces in chrome/, and some interfaces in Blink
that cannot be removed until this CL is submitted.

BUG=423201
TEST=layout tests, browser_tests

Review URL: https://codereview.chromium.org/655253006

Cr-Commit-Position: refs/heads/master@{#301075}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/62c1cfd..bcef85c

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/674873003

Cr-Commit-Position: refs/heads/master@{#301074}

This CL removes the 1 pixel padding around the app list main view. This
subtly changes the layout of the app list by changing the padding of
certain elements.

The dimensions of the app list window are still the same.

This is being done in preparation for the new experimental app list
layout.

BUG=425444

Review URL: https://codereview.chromium.org/676513003

Cr-Commit-Position: refs/heads/master@{#301073}

If not, it leads to a crash later because we don't expect invalied AX roles
in Chromium. We have to tolerate unknown AX roles from Blink because
otherwise there's no way for us to introduce new roles to the Blink enum.

BUG=426608
TBR=aboxhall

Review URL: https://codereview.chromium.org/673143002

Cr-Commit-Position: refs/heads/master@{#301072}

BUG=421850
TEST=None

Review URL: https://codereview.chromium.org/672173003

Cr-Commit-Position: refs/heads/master@{#301071}

Deleted the experiment to load either 200 or 1000 servers from disk.

+ Obsoleted the following histograms
  ++ Net.AlternateProtocolUsage.200Truncated
  ++ Net.AlternateProtocolUsage.1000Truncated

Reverted the changes related to the above from the following CL:
  https://codereview.chromium.org/298683010/

R=jar@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/675783005

Cr-Commit-Position: refs/heads/master@{#301070}

Since the features are not ready, information about the new API should not be
published on the official documentation.

TEST=Tested manually with a preview server.
BUG=425924

Review URL: https://codereview.chromium.org/663013004

Cr-Commit-Position: refs/heads/master@{#301069}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2814a56..62c1cfd

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/677623002

Cr-Commit-Position: refs/heads/master@{#301068}

Revert of Remove mojo test step from bb_device_steps.py (patchset #2 id:20001 of https://codereview.chromium.org/679553002/)

Reason for revert:
Breaks https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16413
and
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23666
like this:
build/android/buildbot/bb_device_steps.py '--factory-properties={"generate_gtest_json": true, "target": "Release", "gclient_env": {}, "build_url": "gs://chromium-android/android_main_rel", "clobber": false, "GYP_DEFINES": " component=static_library", "target_os": "android", "android_bot_id": "main-tests-rel"}' '--build-properties={"parentname": "Android Builder", "parent_wk_revision": "184325", "parent_got_v8_revision": "24827", "got_swarming_client_revision": "bcb3bc30328c38441d3f7656cb649b123803726c", "parent_build_archive_url": "gs://chromium-android/android_main_rel/full-build-linux_66e8568f2fc06dd2aa188d12c240ae2794b00ea0.zip", "parent_buildnumber": "39199", "got_revision": "66e8568f", "parent_revision": "66e8568f", "blamelist_real": ["blink-deps-roller@chromium.org", "brettw@chromium.org", "cjhopman@chromium.org", "dbeam@chromium.org", "hidehiko@chromium.org", "jamesr@chromium.org", "joth@chromium.org", "kelvinp@chromium.org", "kouhei@chromium.org", "ksakamoto@chromium.org", "mtomasz@chromium.org", "sashab@chromium.org", "skia-deps-roller@chromium.org", "tfarina@chromium.org", "wuchengli@chromium.org", "zsborbely.u-szeged@partner.samsung.com"], "got_webkit_revision_git": "721f3e2ce5a10cfb21d12f672bbcc2023d9a228d", "parent_slavename": "vm870-m1", "got_v8_revision_git": "26db57054e04a5b35e7ad88aecb3e05895491a5c", "project": "src", "repository": "https://chromium.googlesource.com/chromium/src", "parent_scheduler": "android", "parent_got_swarming_client_revision": "bcb3bc30328c38441d3f7656cb649b123803726c", "git_revision": "66e8568f", "slavename": "chromeperf72", "got_revision_cp": "refs/heads/master@{#301052}", "blamelist": "blink-deps-roller@chromium.org,brettw@chromium.org,cjhopman@chromium.org,dbeam@chromium.org,hidehiko@chromium.org,jamesr@chromium.org,joth@chromium.org,kelvinp@chromium.org,kouhei@chromium.org,ksakamoto@chromium.org,mtomasz@chromium.org,sashab@chromium.org,skia-deps-roller@chromium.org,tfarina@chromium.org,wuchengli@chromium.org,zsborbely.u-szeged@partner.samsung.com", "branch": "master", "patchset": "", "issue": "", "revision": "66e8568f", "workdir": "/b/build/slave/Android_Tests", "got_webkit_revision": "184325", "buildername": "Android Tests", "parent_try_job_key": "", "mastername": "chromium.linux", "parent_got_webkit_revision": "184325", "parent_builddir": "", "parent_branch": "master", "got_v8_revision_cp": "refs/heads/candidates@{#24827}", "primary_repo": "", "scheduler": "android_trigger_rel", "requester": "", "buildbotURL": "http://build.chromium.org/p/chromium.linux/", "parent_cr_revision": "66e8568f", "rietveld": "", "parent_got_nacl_revision": "", "parent_buildername": "Android Builder", "got_v8_revision": "24827", "parent_got_revision": "66e8568f", "got_webkit_revision_cp": "refs/heads/master@{#184325}", "buildnumber": 16413, "patch_url": "", "parent_git_number": "", "parentslavename": "vm870-m1", "root": ""}' -f ui -f unit -f mojo -f telemetry_perf_unittests -f chrome_proxy --cleanup --flakiness-server=test-results.appspot.com
Unknown tests ['mojo']

Please remove execution of the test from the buildbot configuration (recipe?) first, then reland this.

Original issue's description:
> Remove mojo test step from bb_device_steps.py
>
> This code is being developed and tested in the mojo repository.
>
> R=dpranke@chromium.org
> TBR=navabi@chromium.org
>
> Committed: https://crrev.com/7ec86e83523b60bab33f1739469ff0a0801c8eb4
> Cr-Commit-Position: refs/heads/master@{#301038}

TBR=dpranke@chromium.org,jbudorick@chromium.org,navabi@chromium.org,jamesr@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/646883003

Cr-Commit-Position: refs/heads/master@{#301067}

Revert of Specifies transparent background for the label in TileItemView. (patchset #2 id:10002 of https://codereview.chromium.org/655823005/)

Reason for revert:
Introduces static initializer, see https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/72389

Original issue's description:
> Specifies transparent background for the label in TileItemView.
>
> We may not use single background when it's in Athena (it's not
> used yet though).
>
> BUG=425717
> R=xiyuan@chromium.org
> TEST=manually
>
> Committed: https://crrev.com/3b74c2c950e3681a94601f61d48a6ff0e25f06f8
> Cr-Commit-Position: refs/heads/master@{#301007}

TBR=xiyuan@chromium.org,mukai@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=425717

Review URL: https://codereview.chromium.org/674083002

Cr-Commit-Position: refs/heads/master@{#301066}

BUG=chromedriver:913
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/680463002

Cr-Commit-Position: refs/heads/master@{#301065}

BUG=chromedriver:954
TBR=stgao@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/650593004

Cr-Commit-Position: refs/heads/master@{#301064}

BUG=chromedriver:955
TBR=jbudorick@chromium.org,klundberg@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/662433004

Cr-Commit-Position: refs/heads/master@{#301063}

1) Now, nacl_helper_nonsfi is built only when disable_nacl==0 and
disable_nacl_untrusted==0. Update the condition.
2) native_client/src/public/linux_syscall is now automatically
included by the PNaCl toolchain for the Non-SFI build.
3) Move include_dirs from variables to target.
4) Use relative path instead of <(DEPTH)

BUG=358465
TEST=Ran trybot.
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/656483005

Cr-Commit-Position: refs/heads/master@{#301062}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/721f3e2..2814a56

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/670063007

Cr-Commit-Position: refs/heads/master@{#301061}

Along the way,
  * Tighten up //components/variations and //components/metrics DEPS.
  * Fix up metrics and variations BUILD.gn files.
  * Add unit test targets for metrics and variations.

BUG=420110
TEST=compiles
R=asvitkine@chromium.org
TBR=jochen@chromium.org, cbentzel@chromium.org

Review URL: https://codereview.chromium.org/668863002

Cr-Commit-Position: refs/heads/master@{#301060}

BUG=383125
TBR=michaeln

Review URL: https://codereview.chromium.org/676963002

Cr-Commit-Position: refs/heads/master@{#301059}

BUG=

Review URL: https://codereview.chromium.org/664163002

Cr-Commit-Position: refs/heads/master@{#301058}

Rename files to avoid duplicate basename conflicts.
Fix missing titlecase strings.

BUG=425229

Review URL: https://codereview.chromium.org/657443004

Cr-Commit-Position: refs/heads/master@{#301057}

This is a resubmit of the previous fix that has been reverted due to the
flaky unittest that would hang under the load:
https://codereview.chromium.org/637413003

Please see delta between patch sets 1 and 2 for the
unit test fix.
The test would hang due to a race condition between
MessageLoop::RunUntilIdle call for the main UI thread and
submitting a task on the UI thread from SyncBackendRegistrar running on the sync thread.
The new test implementation runs the UI thread loop continuously
until the expected result is reached so that eliminates the
race condition and makes the test simpler.

I verified the fix by running the test while running
Chromium build in background. Using this method I reliably
reproduced the hang with the first implementation of the test.
This version of the test works reliably under the same condition.

BUG=423078

Review URL: https://codereview.chromium.org/640853008

Cr-Commit-Position: refs/heads/master@{#301056}

Whether or not Windows Aero is enabled on Windows platforms changes
whether a dialog is owned as a transient child or a child widget, and
this distinction is not useful. Changed Widget::GetAllOwnedWidgets to
return child widgets as well so widgets like dialogs can be detected in
tests and at runtime, without special checks for whether Aero is
currently enabled.

This also fixes the test AppListControllerAppInfoDialogBrowserTest.

BUG=378251

Review URL: https://codereview.chromium.org/588113002

Cr-Commit-Position: refs/heads/master@{#301055}

This provides the image assets for
https://codereview.chromium.org/664503006/

BUG=420813
TBR=bauerb@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/679503003

Cr-Commit-Position: refs/heads/master@{#301054}

There are reports of crashes in DeviceInfoDataTypeController destructor. The
crash occurs when DeviceInfoDataTypeController has a pending subscription to
LocalDeviceInfoProvider and LocalDeviceInfoProvider gets destroyed first. This
doesn't happen normally as the subscription gets cleared once
LocalDeviceInfoProvider finishes its initialization.

The fix is to clear subscription in StopModel overrides in the two classes that
hold DeviceInfoDataTypeController::Subscription.

BUG=426205

Review URL: https://codereview.chromium.org/672863002

Cr-Commit-Position: refs/heads/master@{#301053}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/355414e..721f3e2

TBR=kochi@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/671333003

Cr-Commit-Position: refs/heads/master@{#301052}

Before, we were using a timer in hope that the operation is started
synchronously, but it's a wrong assumption.

This patch resolves this issue by waiting until writing is really
started.

TEST=browser_test: *FileSystemProvider*Write*
BUG=426549

Review URL: https://codereview.chromium.org/677593002

Cr-Commit-Position: refs/heads/master@{#301051}

Review URL: https://codereview.chromium.org/638293007

Cr-Commit-Position: refs/heads/master@{#301050}

BUG=426600

Review URL: https://codereview.chromium.org/645703004

Cr-Commit-Position: refs/heads/master@{#301049}

gpu_info.h depended on media/video and media/ depended on gpu/.
gpu/ and media/ had a dependency cycle. Duplicate VEA::SupportedProfile
to gpu_info.h so gpu does not depend on media.

BUG=420801
TEST=Run apprtc loopback and ensure it uses HW encoder.

Review URL: https://codereview.chromium.org/668633002

Cr-Commit-Position: refs/heads/master@{#301048}

The patch has caused compilation error again.

TBR=sashab
NOTREECHECK=true

> This reverts commit 11778438.
>
> Enabled the App Info dialog on the Extensions page by default
>
> Changed the flag '--enable-extension-info-dialog' to
> '--disable-extension-info-dialog', which enables the App Info dialog as
> the default dialog for displaying permissions on the extensions page.
> Does not affect Mac platforms (where the old-style dialog is still
> used).
>
> BUG=395495
> Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0
> Cr-Commit-Position: refs/heads/master@{#301006}
>
> Committed: https://crrev.com/11778438dcb7670324f52e5df111e4007b9224ac
> Cr-Commit-Position: refs/heads/master@{#301046}

Review URL: https://codereview.chromium.org/671373002

Cr-Commit-Position: refs/heads/master@{#301047}

Changed the flag '--enable-extension-info-dialog' to
'--disable-extension-info-dialog', which enables the App Info dialog as
the default dialog for displaying permissions on the extensions page.
Does not affect Mac platforms (where the old-style dialog is still
used).

BUG=395495

Committed: https://crrev.com/a867ca2b5e42207b65e9d07702138ff79bed0bb0
Cr-Commit-Position: refs/heads/master@{#301006}

Review URL: https://codereview.chromium.org/668163002

Cr-Commit-Position: refs/heads/master@{#301046}

This skia API is marked as deprecated, so we need to remove all usages
of it, to be able to remove it in Skia.

BUG=None
TEST=None
TBR=skyostil@chromium.org

Review URL: https://codereview.chromium.org/669303005

Cr-Commit-Position: refs/heads/master@{#301045}

According to the DOM 3 Spec,
http://www.w3.org/TR/DOM-Level-3-Events-code/
the code value for VKEY_LCONTROL should be ControlLeft instead CtrlLeft.
(The same is also true for VKEY_RCONTROL)

BUG=426660

Review URL: https://codereview.chromium.org/640143003

Cr-Commit-Position: refs/heads/master@{#301044}

R=msw@chromium.org
BUG=366092

Review URL: https://codereview.chromium.org/420533002

Cr-Commit-Position: refs/heads/master@{#301043}

This does not change any behavior. It updates the test harness to write the already-computed autofill section to the output, and updates the expected outputs to include this data.

This will make it possible to add tests for this in a later pass.

Review URL: https://codereview.chromium.org/673923002

Cr-Commit-Position: refs/heads/master@{#301042}