- 08 Nov, 2018 40 commits
-
-
Marc Treib authored
This replaces a custom subclass of FakeSyncService with the standard syncer::TestSyncService. It also removed another custom subclass that's just not used at all. Bug: 859874 Change-Id: I0ef20ca70a1fdc81649c856c287ed6f1432956f8 Reviewed-on: https://chromium-review.googlesource.com/c/1326149Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606445}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2c774c363516..63ae28d13da9 Created with: gclient setdep -r src-internal@63ae28d13da9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7bcd30ddf6a80e058baf94d98035ae95668384d3 Reviewed-on: https://chromium-review.googlesource.com/c/1326323Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606444}
-
Rune Lillesveen authored
If we are changing :empty to match when there are whitespace children, we need to know to what extent this affects existing content. Bug: 447880 Change-Id: I53906fe6295f42cdc72d5ca6d6e58e1aa60786c3 Reviewed-on: https://chromium-review.googlesource.com/c/1326003 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#606443}
-
Marc Treib authored
This removes a bunch of methods/members that aren't used (anymore). Bug: 859874 Change-Id: Ia3d0c3be3b1bfdaa9230a26e0ad44c9ea359bf43 Reviewed-on: https://chromium-review.googlesource.com/c/1326004Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606442}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7a397415. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org, mstensho@chromium.org: external/wpt/css/CSS2 NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib28cea91f2861ffedc9562f3e9a5eeda6c0f7893 Reviewed-on: https://chromium-review.googlesource.com/c/1326223 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606441}
-
Antonio Gomes authored
This CL is a continuation of [1], where AdvancedProtectionStatusManager (production code) was migrated from SigninManager and OAuth2TokenService to IdentityManager. At this time the respective unittests are migrated. The CL adds the adds/changes the following testing APIs: - IdentityTestEnvironment::WaitForAccessTokenRequestIfNecessaryAndRespondWithToken receives an extra (optional) parameter |id_token|, and forward it to FakeProfileOAuth2TokenService::IssueAllTokensForAccount. This allows the body of AdvancedProtectionStatusManagerTest::MakeOAuthTokenFetchSucceed to be migrated flawlessly. - IdentityTestEnvironment::UpdateAccountInfoForAccount. This method updates the account information for a given known account, by calling AccountTrackerService::SeedAccountInfo. [1] https://crrev.com/c/1250968 BUG=887266 Change-Id: Ica84fd299794552f2ae6957dfc6c7dde6bba7afa Reviewed-on: https://chromium-review.googlesource.com/c/1308993 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#606440}
-
Antonio Gomes authored
This CL only migrates DiceResponseHandler production code away from SigninManager, leaves migration away from ProfileOAuth2TokenService and unittests for a follow up step. Note that the unittest c/b/signin/dice_response_handler_unittest.cc was minimally updated to keep passing. BUG=890790,902296 Change-Id: Iecdf43b80afe6514b7f19075c2bb62aadfbdbe4c Reviewed-on: https://chromium-review.googlesource.com/c/1318550 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
Bug: 739170 Change-Id: I147200074ddd29f49d89a246c2a3a9e6cee132d1 Reviewed-on: https://chromium-review.googlesource.com/c/1325987Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#606438}
-
Hans Wennborg authored
These bots often time out during clobber builds, blocking clang rolls. Bump the -j number to those used by similar bots. Bug: 903259 Change-Id: I4ea85b111faf9bf0a441c18730a6a8d0bee20d23 Reviewed-on: https://chromium-review.googlesource.com/c/1326153 Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606437}
-
Marc Treib authored
Bug: 859874 Change-Id: I7416dee32bd2daf93976f2e63f397a76e9a30b72 Reviewed-on: https://chromium-review.googlesource.com/c/1326006Reviewed-by:
-
Vadym Doroshenko authored
Sometimes sites change forms after adding them. For example removing/ adding fields. This CL makes NewPasswordFormManager process this situation, by updating |observed_form|, parsing it again and sending new data to the renderer. This first time this CL was uploaded on https://chromium-review.googlesource.com/c/chromium/src/+/1326010 (Patch 1) but it was reverted because of failures in password_generation_interactive_uitest.cc. The reason of failures is that no non-blacklisted confirmation because NewPasswordFormManager waits for server response. This CL fixes that by turning off waiting of server predictions. TBR=isherman@chromium.org Bug: 895411, 831123, 895788, 902805 Change-Id: I99174a73134c582a3975b1f06d797e61ec117855 Reviewed-on: https://chromium-review.googlesource.com/c/1326010Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This makes use of the helper IdentityTestEnvironmentProfileAdaptor. In order to be able to construct the Profile object the same way as the test originally was, and additional optional parameter was added to IdentityTestEnvironmentProfileAdaptor::CreateProfileForIdentityTestEnvironment. BUG=890783 Change-Id: I5c2a48dd4aa7e7377f8a7806717b513b7f27bfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1301814Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#606434}
-
Daniel Bratell authored
Currently disabling jumbo for a build target in a local build means that you also disable jumbo for all other targets with the same local name, and giving a fully qualified label as name won't work at all. This patch changes the matching to be more flexible so that you can supply both a local name (as before) but also a full path or qualified name like //third_party/blink/renderer/core/svg:svg Bug: 825240 Change-Id: I706e4d7c3f863a7996e576d36ddd62ac81b8cb12 Reviewed-on: https://chromium-review.googlesource.com/c/1323110 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Wojciech Dzierżanowski <wdzierzanowski@opera.com> Cr-Commit-Position: refs/heads/master@{#606433}
-
Morten Stenshorne authored
Change-Id: I6017cfa22dd176e88b6b6e64a3f594173e2851a2 Reviewed-on: https://chromium-review.googlesource.com/c/1326141Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#606432}
-
Takuto Ikuta authored
Bug: 894363 Change-Id: If32d6e9d3e968b1f063d2b2a59fc84975e34384c Reviewed-on: https://chromium-review.googlesource.com/c/1325575Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606431}
-
Vaclav Brozek authored
The FormData -> PasswordForm parser can see multiple hints from the server that a field is a new-password field. In particular, this happens if those fields have the same signature. The parser only can choose one new-parser field, and on that field, password generation is offered. If this is any other than the first field, the user has likely already thought of and typed their new password elsewhere. Therefore, this CL makes sure that the first hinted new-password field is marked as such by the parser. Bug: 902700 Change-Id: Idb065e7391526036347feb586b2a702d74f431a9 Reviewed-on: https://chromium-review.googlesource.com/c/1325986Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#606430}
-
Vadym Doroshenko authored
This reverts commit 5cb9cc29. Reason for revert: test PlatformThreadWinTest.SetBackgroundThreadModeFailsInIdlePriorityProcess which was added on this CL fails on some bots, https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests/40510 Original change's description: > Base: Ensure that SetCurrentThreadPriority(BACKGROUND) sets CPU priority on Windows. > > Previously, SetCurrentThreadPriority(BACKGROUND) did not affect CPU > priority on Windows in a IDLE process when the > "WindowsThreadModeBackground" feature was enabled. It only affected I/O > and memory priorities. > > With this CL, a second call to ::SetThreadPriority() is made to > ensure that CPU priority is affected. > > Bug: 901483 > Change-Id: I22640c8fa56eeec489fbf0fe516359b828e39541 > Reviewed-on: https://chromium-review.googlesource.com/c/1318438 > Commit-Queue: François Doray <fdoray@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606200} TBR=gab@chromium.org,fdoray@chromium.org Change-Id: I6ea74d6d1fa14a7b668292e7c7ef75c5ace643e6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 901483 Reviewed-on: https://chromium-review.googlesource.com/c/1325990Reviewed-by:
-
David Bokan authored
Bug: 798719 Change-Id: I05c0bc89c3e842f005be57db2226b4188ee4da3b Reviewed-on: https://chromium-review.googlesource.com/c/1320812Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606428}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5c68fccf..e1f79644 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ice2201b5d289351ae265b6151f3c505fed3f2f38 Reviewed-on: https://chromium-review.googlesource.com/c/1326222Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606427}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/538b8fbb4875..491b15b4a4a0 git log 538b8fbb4875..491b15b4a4a0 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 hiroh@chromium.org license_lib.py: Hard-code license of yasm package 2018-11-08 dhanyaganesh@chromium.org repository.py: force-sync supported by default 2018-11-08 dhanyaganesh@chromium.org precq-launcher: move fields from args to kwargs Created with: gclient setdep -r src/third_party/chromite@491b15b4a4a0 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I3ee1da7578bdcaffd52036327f6e8ec663d5b124 Reviewed-on: https://chromium-review.googlesource.com/c/1325862Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606426}
-
Vadym Doroshenko authored
This reverts commit 50ac3f62. Reason for revert: it breaks ios_webview build https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/988 Original change's description: > [ios] add manual fallback address cell > > Will merge the cell_utils with card_cell after crrev/c/1303730 is merged. > > Bug: 845472 > Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529 > Reviewed-on: https://chromium-review.googlesource.com/c/1317853 > Commit-Queue: David Jean <djean@chromium.org> > Reviewed-by: Eric Noyau <noyau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606423} TBR=noyau@chromium.org,mahmadi@chromium.org,javierrobles@chromium.org,djean@chromium.org Change-Id: Ib17331c289372d4ad6a1d46ba26906d63c2c3da8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 845472 Reviewed-on: https://chromium-review.googlesource.com/c/1326152Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/23d1f94faac1..fa8898747551 git log 23d1f94faac1..fa8898747551 --date=short --no-merges --format='%ad %ae %s' 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 448b99f1a580..905ee08219fa (1 commits) Created with: gclient setdep -r src/third_party/skia@fa8898747551 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I09fe40e62c87d00932116adc64db761a175db8c3 Reviewed-on: https://chromium-review.googlesource.com/c/1325863Reviewed-by:
-
David Jean authored
Will merge the cell_utils with card_cell after crrev/c/1303730 is merged. Bug: 845472 Change-Id: Iead98637aeaa8b7e3b0252057b8592ef4fff0529 Reviewed-on: https://chromium-review.googlesource.com/c/1317853 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#606423}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ie6a5db975ef6caa8b9f05643384687d249570e3a Reviewed-on: https://chromium-review.googlesource.com/c/1326322Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/34abcd63072e..2c774c363516 Created with: gclient setdep -r src-internal@2c774c363516 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I24c1d5ef4a28b2519e19856c5a694771c38f47ac Reviewed-on: https://chromium-review.googlesource.com/c/1326321Reviewed-by:
-
Patrik Höglund authored
I missed 4 (!) cases when disabling this test for win, so let's fix that. Bug: 893494 Change-Id: I6ebfe7d2db4462b4da378aa6a39497b60025f060 Tbr: emircan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1326146Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#606420}
-
Alexandr Ilin authored
This CL fixes flaky LoadingPredictorBrowserTest.PrepareForPageLoadWithPrediction test. If a navigation finishes earlier than the PreconnectManager completes all its preresolve jobs, remaining jobs will be cancelled and the test will fail by timeout. This CL uses TestNavigationManager that pauses navigations to avoid this race. Bug: 902963 Change-Id: I6aea05b3518627f7bbef0af18bb89bb1b1463f81 Reviewed-on: https://chromium-review.googlesource.com/c/1325984Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606419}
-
Rayan Kanso authored
The new version of the spec removes the clause about waiting for installing workers since that can easily cause deadlocks. Bug: 542437 Change-Id: I4192787248e3d147ec001516f86aa17ea361752f Reviewed-on: https://chromium-review.googlesource.com/c/1323717Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#606418}
-
Colin Blundell authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1302175, IdentityTestEnvironment now requires a properly set-up task environment. The error that ensues at runtime if this is lacking is currently quite cryptic. This CL adds documentation of the requirement and a transparent runtime error for the case where the task environment is missing. Bug: 798699 Change-Id: I7187b9d30f3072c2a0e697e7e325b01d238665bc Reviewed-on: https://chromium-review.googlesource.com/c/1323073 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#606417}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/905ee08219fa..743899de3f2d git log 905ee08219fa..743899de3f2d --date=short --no-merges --format='%ad %ae %s' 2018-11-08 jiajia.qin@intel.com ES31: Implement MAX_SHADER_STORAGE_BLOCK_SIZE Created with: gclient setdep -r src/third_party/angle@743899de3f2d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I5ffb4968b35f4cedde5d77bcc592dfdee4557bcc Reviewed-on: https://chromium-review.googlesource.com/c/1326101Reviewed-by:
-
Antonio Gomes authored
CL also converts ::GetMessagesForAvatarSyncError defined at c/b/sync/sync_ui_util.h|cc, (but not the whole file). BUG=890804,890796 Change-Id: I4d7dbbdb1c5ca6f86e44cf9b4b454143eac08d9d Reviewed-on: https://chromium-review.googlesource.com/c/1324589 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Vaclav Brozek authored
The test expectations for form_parser_unittest.cc contain the expected roles for form fields (username, new-password, etc.). There can be at most one of each, so if there are multiple same roles, all but one are ignored. This CL adds a DCHECK to guard that there are no multiple same roles specified, so that the expecations are not described in a confusing way. It is a DCHECK instead of an ASSERT/EXPECT, because this is something not depending on the tested code, just the way the test is written. Hence if it passes when submitting the CL, it will pass until the next change to the test file. Bug: 902700 Change-Id: I022daf5a1701f13e7d52c881b60acfc412cd2e96 Reviewed-on: https://chromium-review.googlesource.com/c/1325985Reviewed-by:
-
Fredrik Söderquist authored
Does not appear to be flaky anymore. TBR=schenney@chromium.org Bug: 306222 Change-Id: I4e381ca9d89e5495cb98286e0fd387b94d67c125 Reviewed-on: https://chromium-review.googlesource.com/c/1326008Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#606413}
-
Vasilii Sukhanov authored
Unnecessary update skews the metrics. Typical flow before the CL is - The profile chooser shown. - User clicks something. - The profile chooser is being hidden. - Some state changes and updates still existing bubble. Bug: 901449 Change-Id: Iee9b5c7757aad2f0d9c7149a1e26b33e6e954716 Reviewed-on: https://chromium-review.googlesource.com/c/1320172Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#606412}
-
Jordan Demeulenaere authored
The details image is now downloaded using the CachedImageFetcher introduced in http://crrev/c/1297639. This allows to safely download the image and avoid downloading the same one multiple times. Change-Id: I5ad8e433307b75fafc522fcd379e62c4b3938a9f Reviewed-on: https://chromium-review.googlesource.com/c/1326005Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#606411}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6b82a698270f..34abcd63072e Created with: gclient setdep -r src-internal@34abcd63072e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I5077536e0976082d868dc178292ae3c276c2f513 Reviewed-on: https://chromium-review.googlesource.com/c/1326061Reviewed-by:
-
Daniel Bratell authored
A change included an internal blink header in the public api layer which then leaked parts of blink's internal out into the wild dangerous world outside. This is a quick fix to close that leak. Might need some tuning. Bug: 902022 Change-Id: I076f4c5d0a27cd4c3070d8fe8a5be97f2f65e1e0 Reviewed-on: https://chromium-review.googlesource.com/c/1323715 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#606409}
-
Javier Ernesto Flores Robles authored
Creates and logs user actions for the following actions. ManualFallback_Close ManualFallback_ClosePopover ManualFallback_OpenPassword ManualFallback_OpenCreditCard ManualFallback_OpenProfile ManualFallback_Password_SelectUsername ManualFallback_Password_SelectPassword ManualFallback_Password_OpenOtherPassword ManualFallback_Password_OpenManagePassword Bug: 845472, 881734 Change-Id: If251294575be60b9c27296e79e06a394a277762e Reviewed-on: https://chromium-review.googlesource.com/c/1317914Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#606408}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 12dbcc93. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc meade@chromium.org: external/wpt/web-animations NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ic9532b352ac67df15f3784e65b5c289a19cd402a Reviewed-on: https://chromium-review.googlesource.com/c/1325563 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
-
Yi Su authored
Current implementation of search_engine.js finds Open Search <link> when the Js file is injected without a check on page's loading status. This CL adds a check for document.readyState, so that the finding process will only be executed when the page is fully loaded. Bug: 433824 Change-Id: I3384081dd3079f15dba6a727cf1373edc4b593ba Reviewed-on: https://chromium-review.googlesource.com/c/1323716 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#606406}
-
