GitLab

happen.

Before this change, ConfigureBottomSheetAction would return immediately
after asking for the viewport to be resized. Depending on how quickly
that happened, a Focus action following ConfigureBottomSheetAction might
see the window height before the resize and not be able to focus.

The current workaround for that is to wait after resizing the viewport
before focusing on an element, but the time it takes varies a lot.

With this change, ConfigureBottomSheetAction waits until the viewport
resize has been seen from the Javascript side, so we don't wait longer
than strictly necessary. A maximum wait time avoids scripts getting
stuck in this action.

Bug: b/133665079
Change-Id: Ia37076710634542bb4f15c77f30275c234383cb4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640408
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665557}

DeviceOAuth2TokenServiceDelegate currently overrides
OAuth2TokenServiceDelegate::RefreshTokenIsAvailable() but doesn't
override OAuth2TokenServiceDelegate::GetAccounts(). The latter has a
default implementation that returns an empty set of accounts.

We have a goal of implementing
OAuth2TokenService::RefreshTokenIsAvailable() on top of
OAuth2TokenService::GetAccounts() as a means of enforcing semantic
invariants around the relationship between these two methods (see bug
for details). As a step toward enabling this enforcement, this CL
changes DeviceOAuth2TokenServiceDelegate to implement GetAccounts()
and implement RefreshTokenIsAvailable() in terms of GetAccounts().

As O2TSDelegate::RefreshTokenIsAvailable() is marked const but
O2TSDelegate::GetAccounts() is not, this requires a bit of tap-dancing
in the implementation. This tap-dancing will go away in the followup,
which will change OAuth2TokenService to implement
RefreshTokenIsAvailable() directly rather than via the delegates.

This CL should have no behavioral impact, as an analysis done for
separate reasons showed that GetAccounts() is never invoked on
DeviceOAuth2TokenService:

https://docs.google.com/document/d/1IeaTv_BQZfpYDgEeenozB-8W65vW2cpZsTeADeXt8RU/edit#heading=h.pukrhlvsi449

Bug: 919793
Change-Id: I628fbc6eded0fee8b460006a746b59ceeecac4ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640978Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665556}

https://skia.googlesource.com/skia.git/+log/eca66b32fdb9..fec9b902a626


git log eca66b32fdb9..fec9b902a626 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 mtklein@google.com add unit scaling mode to benchmark/nanobench
2019-06-03 borenet@google.com [infra] Stop isolating the Android NDK
2019-06-03 jcgregorio@google.com Add 'modules' to doxygen generation.
2019-06-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial).
2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 0a56f0e3d22d..98f2167125a8 (8 commits)
2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader c0d7ee45d45f..bb575d48d5f9 (3 commits)
2019-06-03 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 8e522297..f75363e4 (402 commits)


Created with:
  gclient setdep -r src/third_party/skia@fec9b902a626

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jcgregorio@google.com

Change-Id: Ie75fc529cdc951b659d9c9b7f6f11e018fccb865
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641210Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665555}

When mouse events are captured, we use the capturing element instead of
doing hit test. The local_point is computed by AbsoluteToLocalPoint, but
we didn't apply transfroms. This is wrong and causes selection incorrect
when there is transform.
This CL removes the incorrect kIgnoreTransforms.

Bug: 969695
Change-Id: Icfcaf627f58999f037b793feeb3fe712a827ca8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634719
Commit-Queue: Ella Ge <eirage@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665554}

This code was necessary to avoid forcing a remote client to be visible
until occlusion tracking was enabled. Now that mash is no more, there are no
remote clients and this can be removed.

BUG=961763
TEST=none

Change-Id: I05d9603b82a14a1b394287540747e6b84269cb28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635292
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665553}

Change-Id: I4830739df4bf4458d9299cc9cc860f69bb4553c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636571Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665552}

MessageLoop will go away, eventually.

ScopedTaskEnvironment will per default start a ThreadPool, which should
be fine in most of the cases. If you belive your test needs to make sure
that no ThreadPool runs let me know and I will update the patch.

BUG=891670
This CL was uploaded by git cl split.

R=sdefresne@chromium.org

Change-Id: I6981ec15a6730394d64090021a8c58ce88f7ec3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636191Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Carlos Caballero <carlscab@google.com>
Auto-Submit: Carlos Caballero <carlscab@google.com>
Cr-Commit-Position: refs/heads/master@{#665551}

This is a step in eliminating the inheritance relationship between
SigninManager and SigninManagerBase, as motivated in this design doc:

https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.8jjdy95t6p7x

and described concretely here:

https://docs.google.com/document/d/15y-Db27BV08vrIyelHB-3CwiAfDYh-FigNKGXrqSWto/edit#heading=h.mbkrv9nkb93w

The functionality is ifdef-d out on ChromeOS, as it is currently not
used on that platform. However, in the near term we will enable it on
ChromeOS as part of unifying the flow of setting the primary account
between ChromeOS and desktop.

Bug: 952766
Change-Id: I4b408b0a9ead28367ef07fb06f7950609be4b369
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1565315
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665550}

 * Before: https://screenshot.googleplex.com/a7bmH8ZzaVL.png
 * After: https://screenshot.googleplex.com/3speSGf6PEA.png

Screenshots: 
Change-Id: I60cd9b7b700af31ef571ce3f7e204b61126444d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639391Reviewed-by: Stephane Zermatten <szermatt@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665549}

This moves the per-node type observers to the public interface, and
adds support for registering observers of this type to GraphImpl.

This allows reimplementing all existing GraphObserver implementations
using the public interface.

BUG=910288

Change-Id: Ie712de6301562f13b32f1fef10765f1d48aecd94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632097
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665548}

https://webrtc.googlesource.com/src.git/+log/4cd1c6a3db4c..1df841d446eb


git log 4cd1c6a3db4c..1df841d446eb --date=short --no-merges --format='%ad %ae %s'
2019-06-03 sakal@webrtc.org Target SDK level 29 in AppRTCMobile.
2019-06-03 eladalon@webrtc.org Buffer RTCP feedback messages in RtpVideoStreamReceiver


Created with:
  gclient setdep -r src/third_party/webrtc@1df841d446eb

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I45661d2131a6a9b260f99ec23a22c52be1c37d64
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640915Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665547}

Change-Id: I199db5d33a571a07e5bc9cc41ea4ac29a3295890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637560Reviewed-by: vmpstr <vmpstr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665546}

The Scoped* helpers will reset the modified runtime flag back for other
tests.

Change-Id: Ia8e0e914122393cc8e38101412fe3f88ce74fa3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637561Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665545}

TBR=jochen@chromium.org

Bug: 967643
Change-Id: Ief655352c6b95489b3a13605f7721057d529c587
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636197
Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665544}

This reverts commit 28c84c16.

Reason for revert: https://crbug.com/969587

Original change's description:
> [Mac] Preserve symbolic links in the copy_bundle_data tool
> 
> This is a reland of 6a008993, which was reverted in 235d842a.
> (Thus, this is a revert of that revert.)
> 
> Since the last attempt, the structure of the keystone_registration
> bundle_data rule in third_party/googlemac (via src-internal DEPS) has
> changed to avoid the dangling symbolic link problem previously
> encountered.
> 
> The description from 6a008993:
> 
> The copy_bundle_data tool is implemented in terms of pax for directories
> and ln hard links for files. The pax command does preserve symbolic
> links within the tree that is being copied. But with the way that pax is
> invoked by the tool, cd-ing into the source, if the source is itself
> a symbolic link to a directory, the tree will be logically copied rather
> than just as a symbolic link.
> 
> A similar issue exists with the non-directory symbolic link source case,
> where a hard link will be produced instead of a symbolic link.
> 
> Fix both of these cases by specifically testing if the source is a
> symbolic link and then re-creating it if so.
> 
> Bug: 955936
> Change-Id: Ia13ddf743603e98337c3523e9101e7627e1c31d0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637673
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Mark Mentovai <mark@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665203}

TBR=thakis@chromium.org,mark@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 955936
Change-Id: I4de6596c29598961ac15fbd24acc54b1f763735a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639152Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665543}

This CL makes sure GPUVertexInputDescriptor indexFormat defaults
to uint32 as spec'ed in https://github.com/gpuweb/gpuweb/pull/270

Bug: 877147
Change-Id: I625298abd78794a172d9296a511747b4363dbbe0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641263
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665542}

Bug: 911350
Change-Id: I3bc67c92eb9936fc72f6046a952dbc24a517599c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638680
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665541}

* Don't shrink SAML window - it hosts oobe-dialog anyway (which has
fixed size)
* Remove outdated css rules - it caused buttons be white on white (so
not visible but active)
* Stop showing back button on top at all - the screen has bottom back
butotn now
* Fix glitch with refresh button - it was shown for a second when
isManualEnrollment_ was not yet defined.

Bug: 965392
Change-Id: I680d7471a53a4e8c17aae4c37433633e120c11a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640643Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665540}

Use blink::UseCounter instead.

This CL keeps CountUsage and CountDeprecation on BaseFetchContext (and
subclasses). They may also be replaced by the use counter in the
future.

Bug: 914739
Change-Id: Ic8d00d8d47ad06e4d60d28cfee7fe88162c49cad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636666
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665539}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
TBR=cr-fuchsia+bot@chromium.org

Change-Id: If81534f6f4987a3b3ed236efa06a90a024db8116
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640910Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665538}

Bug: 963306
Change-Id: If948bfa3c49f819d8c908b3f4d179882c441427a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640919
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Auto-Submit: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665537}

viewport height.

This change fixes issues with the event filter of the overlay not
adapting to viewport height changes.

With this change, the position of highlighted elements are reported as
CSS pixels, relative to the page, instead of coordinates relative to the
viewport size. The viewport size and position within the page is tracked
and reported separately.

When displaying or comparing against filter coordinates, CSS pixels are
converted into physical pixels using the viewport width, which allows
adapting to zoom.

This change also simplifies the display of the highlighted area by
ignoring the offset reported to the onScroll methods as it was causing
issues. This allows the model to cache the element position and the
visual viewport position independently; when scrolling, unless the
element position is absolute, element position normally stay the same
and only the viewport changes.

Bug: b/133669408
Bug: b/129050125
Change-Id: I745584b496d960a2d73231238dd2006afb3f7eaf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634737Reviewed-by: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665536}

This CL extends the range of the E2E latency metrics from 1 hour to
1 week.

Bug: 966375
Change-Id: I4346b0538fed3d60480e8ccd7c4cfda5b87a8654
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626596
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Christopher Thompson <cthomp@chromium.org>
Auto-Submit: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665535}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/ddbb5499..0ec93e04

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I722b0102bbd8a7bd5ed0d1562b6c7bc09f1566a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640775Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665534}

https://webrtc.googlesource.com/src.git/+log/114e8bb7a68f..4cd1c6a3db4c


git log 114e8bb7a68f..4cd1c6a3db4c --date=short --no-merges --format='%ad %ae %s'
2019-06-03 gustaf@webrtc.org Lockless SwapQueue
2019-06-03 barrerap@webrtc.org Allow neteq_quality_test to read a complete file
2019-06-03 fhernqvist@webrtc.org Add fhernqvist to watchlist.
2019-06-03 barrerap@webrtc.org Expose audio decoder factory in neteq_quality_test
2019-06-03 nisse@webrtc.org Delete deprecated StartRtcEventLog override with PlatformFile
2019-06-03 hta@webrtc.org A threading explanation
2019-06-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 97b44755..aaa0f87a (665322:665423)


Created with:
  gclient setdep -r src/third_party/webrtc@4cd1c6a3db4c

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I9628971678d606b61a485819c8e65364999ef3a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640909Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665533}

We cannot safely assume, based on display type, that a DETAILS or
SUMMARY element is going to establish a new formatting context, since
they may ignore the display type and just create a regular block
container (which doesn't necessarily establish a new formatting
context).

Bug: 969619
Change-Id: Ie59fe7301f8706cd4d39b3312fe6748c4ffb17e6
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640410Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665532}

https://chromium.googlesource.com/angle/angle.git/+log/98f2167125a8..12a524231f53


git log 98f2167125a8..12a524231f53 --date=short --no-merges --format='%ad %ae %s'
2019-06-03 aleino@nvidia.com Sharpen GL test skip condition for NVIDIA
2019-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/glslang/src 6d88284607d2..a549bb817523 (2 commits)
2019-06-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 209ff0ce90ce..699e167d78ee (3 commits)
2019-06-03 jiajia.qin@intel.com Fix needStructMapping


Created with:
  gclient setdep -r src/third_party/angle@12a524231f53

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=geofflang@google.com

Change-Id: I82aeba86cc8a306b8b603db831db01e5ecd53f9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640911Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#665531}

Replace usage of TabModelObserver's didChangeTab with WebStateObserver's
didStartNavigation.


Bug: 911350
Change-Id: I35125a96a053e2ed4f27bfadfcb5a732d33d807a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630231Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665530}

When the network service is disabled the Android WebView's
DownloadListener.onDownloadStart() callback gets executed twice
for the same url.

This is due to the new code path (via AwDownloadManagerDelegate)
which is intended to be executed when the network service is
enabled is also run when it is disabled. This patch ensures that
the new code path only runs when the network service is enabled.

BUG=961264,841556

Change-Id: Ieec4a330d9d04173cf12ba23c90d9c37df08af47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638526Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665529}

This reverts commit 0fdf975b.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 665506 as the
culprit for flakes in the build cycles as shown on:
https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMGZkZjk3NWI3MDRjMTI5MDdlMThhYzA1NTQ1N2YwZDQ0M2E3ODMwNgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.12%20Tests/23593

Sample Failed Step: webkit_layout_tests on Intel GPU on Mac on Mac-10.12.6

Sample Flaky Test: virtual/blink-cors/http/tests/security/mixedContent/insecure-css-resources.html

Original change's description:
> OOR-CORS: Setup virtual layout tests for non OOR-CORS mode
> 
> Now the OOR-CORS is enabled by default at m76, but we want to
> run some of layout tests w/o OOR-CORS for the potential risk
> to postpone the launch beyond the m76. Legacy code path should
> work well until then.
> 
> Bug: 905971
> Change-Id: Ife79c90a031c9b729c629509da83e1ff2ac2a2c4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635081
> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
> Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#665506}


Change-Id: Ia6e60951a4f08bbc4372600be6d37d1dab465e9f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 905971
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640150
Cr-Commit-Position: refs/heads/master@{#665528}

The new exception is added in preparation of:
https://github.com/web-platform-tests/wpt/pull/16864

Also remove the unnecessary slashes from the regexes: '\' does not need
to be escaped again in Python raw strings.

Change-Id: I3453468b138f40e2adf1c7aaffa0076fbdb5f649
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636390
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665527}

Before this CL, we would occasionally crash when refreshing suggestions
for a field right after it was unfocused.

To prevent this, we now check that the focus is set and if it isn't, we
use an opaque origin for which we can never have suggestions since it is
a unique Nonce element.

Bug: 957549
Change-Id: I4118b5ea9b7d44416f2f5b3d652cba348487c2df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635570
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665526}

Updating code w.r.t. coding conventions:
https://chromium.googlesource.com/chromium/src/+/lkgr/styleguide/c++/c++.md#object-ownership-and-calling-conventions

Bug: 968109
Change-Id: Ib6aef90f69bfc10e7fe792502456427fce82a0e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639217Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Vladislav Kuzkokov <vkuzkokov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665525}

Bug: chromium:968093
Change-Id: I2081ec72c115618fa8a2478137f1f0b704185a57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634700Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Johannes Kron <kron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665524}

containers.

Before this change, when scrolling elements within scrollable container,
the element would be first taken to the desired position within the
screen, *then* scrolled within its container, which could result in the
element not even appearing within the window.

With this change, the element is scrolled into view within its container
before choosing how much to scroll the window vertically. At the end of
the scroll, the top of the element is always at the desired position
within its frame.

This change also switches the browsertest for scrolling to doing
synchronous checks, as we don't use smooth scrolling anymore.

Change-Id: I5bd090988ec8ca5441d15783d2b46ceb3982e57d
Bug: b/129046627
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636138
Commit-Queue: Stephane Zermatten <szermatt@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665523}

This CL sets the CRWWKNavigationHandler as the navigation handler of
WKWebView in CRWWebController. Unused public @property and methods of
CRWWKNavigationHandler are also cleaned up.

Bug: 956511
Change-Id: I1306d080c57872d4d5b293393b31d20f0bc81716
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634865
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665522}

This CL moves the WKNavigationDelegate method
"webViewWebContentProcessDidTerminate" from CRWWebController into
CRWWKNavigationHandler.

Bug: 956511
Change-Id: I496723eba0dcd2c4304f14ce5c55d8e65d4b40de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635256
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665521}

This CL moves the WKNavigationDelegate method
"didReceiveAuthenticationChallenge" from CRWWebController into
CRWWKNavigationHandler.

Bug: 956511
Change-Id: I6c306b3553781651a6edec88325c7aa57499bc6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635255
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665520}

WebAssembly defines a number of histograms with questionable value,
i.e. asm-wasm translation throughput and wasm decode times.
To comply with the guide lines, this CL defines an expiration date for
all of them. I chose the same expiration date we already use for other
histograms, so we can review which of the histograms we still need next
year.

R=jwd@chromium.org
CC=titzer@chromium.org

Change-Id: I98a5771052da7c01bb28115c9df4a529e5044d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636135Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665519}

This CL moves the WKNavigationDelegate method "didFailNavigation" from
CRWWebController into CRWWKNavigationHandler.

Bug: 956511
Change-Id: Ib376a5a9ffede6d950924796237549673f1da9b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634743
Commit-Queue: Yi Su <mrsuyi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#665518}