- 29 Jan, 2019 40 commits
-
-
Alexander Dunaev authored
Mock and test classes are moved into separate files and renamed appropriately. The new files are moved into a separate source set that will later be used by other tests. Use of the SetImplementation call is revised; the 'deprecated' version that doesn't take ownership is considered to be legitimate and renamed. Additional test and mock classes that model environment of the Wayland buffer manager are introduced. Bug: 926155 Change-Id: Ia1056a3d1051b12fdc49fd3a11c5fdeb7a558dbd Reviewed-on: https://chromium-review.googlesource.com/c/1443115Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#627044}
-
Becca Hughes authored
Media Session API should not be available in Android WebView so we should update expectations. BUG=925700 Change-Id: I52330a6fa1d42501ea4bc75e32ddde26db349e72 Reviewed-on: https://chromium-review.googlesource.com/c/1440908Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#627043}
-
Gauthier Ambard authored
This CL moves the password settings files to their own directory to avoid having too many files in settings/. Bug: 925357 Change-Id: Id54f78cfa3d8060152702756793a62720f87d069 Reviewed-on: https://chromium-review.googlesource.com/c/1437632 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#627042}
-
khmel@chromium.org authored
This adds base functionality of UI for ARC graphic buffers visualization tools. It provides. * UI to start graphic buffer tracing * UI to show captured model. * Show top level Chrome and Android Graphics events * Show graphic buffers events grouped per view. * Each events band is expandable/collapsible. * Tooltip automatically pops up to describe content under the mouse. This is kept behind the flag and not localized once not targeted to M73. BUG=b:122555793 TEST=Locally Change-Id: Ib285fbe9be6245cb2cb88cabbf11a07d28269c30 Reviewed-on: https://chromium-review.googlesource.com/c/1436135 Auto-Submit: Yury Khmel <khmel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#627041}
-
Miguel Casas authored
This CL teaches CheckNoGlError() in texture_upload_perftest.cc to dump the GL error as human readable string. Bug: 920626 Change-Id: I49c9ad3db9f343f0a031a7bce8505f99c6e4b832 Reviewed-on: https://chromium-review.googlesource.com/c/1440521 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#627040}
-
Gauthier Ambard authored
This CL moves the autofill settings files to their own directory to avoid having too many files in settings/. Bug: 925357 Change-Id: I1233ec715514206ff21960fe49ffce6d96aca5cf Reviewed-on: https://chromium-review.googlesource.com/c/1437279Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#627039}
-
Aaron Colwell authored
This change introduces necessary plumbing to allow future profile specific policy decisions to be made using the ResourceContext on the IO thread and the BrowserContext on the UI thread. - Store BrowserContext & ResourceContext in SecurityState so they can be looked up by the child_id. - Updated tests to pass in a BrowserContext when they add a child_id to ChildProcessSecurityPolicyImpl. - Added BrowserOrResourceContext to content/public so it could be used outside of content/ by code in chrome/ in followup CLs. Bug: 898281 Change-Id: I676ba22b618fb3ccddef8d743c7914e878ef0271 Reviewed-on: https://chromium-review.googlesource.com/c/1356133 Commit-Queue: Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#627038}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/acd0b9629023..0a525cd5cae5 git log acd0b9629023..0a525cd5cae5 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 fmayer@google.com profiling: Improve e2e test. 2019-01-29 fmayer@google.com profiling: Re-enable end to end tests. Created with: gclient setdep -r src/third_party/perfetto@0a525cd5cae5 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:121352331 TBR=perfetto-bugs@google.com Change-Id: I1d7316876e05344a8daf359f7909c7ebb20bbd2e Reviewed-on: https://chromium-review.googlesource.com/c/1443292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627037}
-
Daniel Bratell authored
Change-Id: Id4be15169850ae2347bd9f6e7bdfbcd12c466383 Reviewed-on: https://chromium-review.googlesource.com/c/1443114Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#627036}
-
Alex Newcomer authored
Observe homecher animations beginning and ending, this will allow us to better coordinate shelf background animations. Bug: 920420 Change-Id: I3efd0bcecb3acd5d10968ad1d78d89d1689098f6 Reviewed-on: https://chromium-review.googlesource.com/c/1418525Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#627035}
-
Kush Sinha authored
|ChromeOSOAuth2TokenServiceDelegate| should pre-emptively reject access token fetches and other operations on known dummy Gaia tokens instead of letting them go over the network and get rejected by Gaia server-side. This brings feature parity between |ChromeOSOAuth2TokenServiceDelegate| and |MutableProfileOAuth2TokenServiceDelegate|, which does the same thing. Bug: 915628 Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" Change-Id: I812a847fb1afd040a3ae743a9e491753878ca523 Reviewed-on: https://chromium-review.googlesource.com/c/1437627 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#627034}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8397f2b3f00..a66be38441d8 git log f8397f2b3f00..a66be38441d8 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 bsalomon@google.com Limit Analytic Clip FP workaround to powervr rogue on x86 2019-01-29 robertphillips@google.com Revert "Split GrContextThreadSafeProxy into its own files" Created with: gclient setdep -r src/third_party/skia@a66be38441d8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/123092993 TBR=borenet@chromium.org Change-Id: Iaa39ee9f192f7fbb2b3863a40b7e87f79174b3b7 Reviewed-on: https://chromium-review.googlesource.com/c/1443291Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627033}
-
Nikita Podguzov authored
Bug: 758679 Change-Id: I16ff15a0aa61e7d0a90d164f3d3f25aefd42d446 Reviewed-on: https://chromium-review.googlesource.com/c/1443111Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#627032}
-
Madeleine Barowsky authored
We currently exclude this directory from skia_config iOS simply because it has not been unused. However, due to modifications to PaintImage to support YUV decoding, there is header inclusion that leads back to third_party/skia/include/codec/SkEncodedOrigin.h. This caused a compile error leading to those YUV changes [1] to be reverted. [1] crrev.com/c/1368687 Bug: NOBUG Change-Id: Ie42587226f8f9cfd817f98e6157294deb4427ea0 Reviewed-on: https://chromium-review.googlesource.com/c/1440243Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Commit-Queue: Leon Scroggins <scroggo@chromium.org> Cr-Commit-Position: refs/heads/master@{#627031}
-
Andres Calderon Jaramillo authored
This CL adds code to insert an image cache entry in the service transfer cache upon the completion of an accelerated image decode. This involves adapting the ServiceImageTransferCacheEntry class to allow for the creation of the internal SkImage based on directly passed parameters instead of the deserialization of data passed from the renderer. The flow of data is as follows: 1) The IPC point of entry is the ImageDecodeAcceleratorStub::OnScheduleImageDecode method. Here, we start the actual decode in the ImageDecodeAcceleratorWorker and then schedule a task in the gpu::Scheduler to eventually release the decode sync token (but that task doesn't run yet because the scheduler sequence starts off disabled). 2) The ImageDecodeAcceleratorWorker does its job and completes the decode. At that point, it calls ImageDecodeAcceleratorStub::OnDecodeCompleted() which adds the completed decode to a queue. The CompletedDecode struct contains the decoded data and information about it. Then the scheduler sequence is enabled. 3) The task that was previously scheduled in the scheduler runs. This is the ImageDecodeAcceleratorStub::ProcessCompletedDecode() which is supposed to insert the decoded image in the transfer cache and then release the decode sync token to indicate that the image can now be used for rasterization. Test: unit tests are added in the follow-up CL to avoid noise here. Bug: 868400 Change-Id: I284599e98be4f102b334f786c97cf6d0950176dd Reviewed-on: https://chromium-review.googlesource.com/c/1368599Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#627030}
-
Arthur Hemery authored
As a prerequisite for patch https://chromium-review.googlesource.com/c/chromium/src/+/1344091, we need to make sure that we always go through SimulateCommitProcessed with DidCommit*Params. To ensure this, we DCHECK for params and remove the overload that provided nullptr params. Unfortunately a massive amount of tests still relied on this function, notably through TestWebContents::CommitPendingNavigation and RenderFrameHostTester::CommitPendingLoad. Among the things that needed to be modified in the Simulator to fit all these situations: - Redirect() now works for Browser initiated navigation. The non support was not documented but in practice only renderer initiated navigations used it. - NavigationSimulator creation from a pending entry was extended to be able to handle navigations that were not yet started and just had a pending entry. It uses NavigationControllerImpl (former internal) function NavigatePendingEntry* to do so. - Removed one of the DCHECK in NavigationSimulatorImpl:: InitializeFromStartedRequest since we can now have requests at the RESPONSE_STARTED stage. - DidCreateNewEntry() was not properly handling pending navigations, so we added an override to make sure this is also correct in this case. Another use of the SimulateCommitProcessed overload was aborting from the NavigationSimulator. This now uses a different function, and we removed the success parameter, as only abort had failed params. Bug: 784904 Change-Id: Ieec460a052029455b0e0233d13a2bcfa0204b1d5 Reviewed-on: https://chromium-review.googlesource.com/c/1411640Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#627029}
-
Guido Urdaneta authored
Bug: 921006 Change-Id: I9115fb109d2f4e2832b4591ce766754e091b7f6c Reviewed-on: https://chromium-review.googlesource.com/c/1443020Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#627028}
-
Ella Ge authored
This CL removes function SetCapturingMouseEventsElement(). The only remaining caller are slide thumb element and it's "set capture" are using SetPointerCapture(kMouseId), so we should use ReleasePointerCapture here as well. This CL also removes event_handler_will_reset_capturing_mouse_events_node_ *will_reset* is a boolean used with capturing_mouse_events_element_ After we remove SetCapturingMouseEventsElement, all remaining setter of capturing_mouse_events_element_ will set *will_reset_* to true. Therefore, there is no point to keep *will_reset* Bug: 919908 Change-Id: Ie1ba43515899a085b82502a907c12d48b3334b1a Reviewed-on: https://chromium-review.googlesource.com/c/1427220Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#627027}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/637ba4af..9ca06e4d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ied4ed02731da4629df81d55b6b30ab4cb25a2e27 Reviewed-on: https://chromium-review.googlesource.com/c/1443072Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627026}
-
Lowell Manners authored
FakeGaiaCookieManagerService is being eliminated in favor of setting expectations using TestURLLoaderFactory. This CL migrates account_reconcilor_unittest.cc to set expectations directly on TestURLLoaderFactory, a precursor to deleting FakeGaiaCookieManagerService. This is part of step 1a of the plan to eliminate FakeGCMS entirely: https://docs.google.com/document/d/1t0ZtuV7h-znzdItFgBW0aKPscAwWXIBuNZnNlEGgi7g/edit Bug: 907782 Change-Id: I8bd00448bb71ce919dd02b6a90dbb1f33e9300f1 Reviewed-on: https://chromium-review.googlesource.com/c/1436049Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Lowell Manners <lowell@chromium.org> Cr-Commit-Position: refs/heads/master@{#627025}
-
Ian Clelland authored
Change-Id: I21b76fb4be0fdde050d670d521f3192a392921b4 Reviewed-on: https://chromium-review.googlesource.com/c/1443313 Auto-Submit: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#627024}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cf011f990163..cf7834623053 git log cf011f990163..cf7834623053 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 dneto@google.com Add source/opt/block_merge_util.* to BUILD.gn (#2344) 2019-01-28 dneto@google.com Validate NonWritable decoration (#2263) 2019-01-28 stevenperron@google.com Remove code sinking for -O. (#2340) 2019-01-25 afdx@google.com Fixed names in ifdefs and GetName functions that had been forgotten in a previous refactoring. Also shortened names of test files as those files test both the new 'finder' classes introduced in the refactoring, as well as the 'reduction pass' class; the shorter names capture both. (#2336) 2019-01-25 afdx@google.com Extracted block merging functionality into its own utility file (#2325) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@cf7834623053 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia282523e4707742174f998252862f4d2967ddb56 Reviewed-on: https://chromium-review.googlesource.com/c/1443091Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627023}
-
Jordan Demeulenaere authored
Change-Id: I458615ffc7beaef6694b160578031eb653394ced Reviewed-on: https://chromium-review.googlesource.com/c/1443112Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#627022}
-
François Doray authored
With this CL, it is guaranteed that the file descriptor passed to FileDescriptorWatcher::Watch(Readable|Writable) isn't used after the returned Controller has been destroyed. To enforce this when the MessageLoopForIO used to watch the file descriptor lives on a separate thread, the destructor of Controller uses a WaitableEvent to wait until all work on this separate thread is done. Bug: 741188 Change-Id: Ie1a5ead5324ae90ce1d73339cfc191c589590222 Reviewed-on: https://chromium-review.googlesource.com/c/695914 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#627021}
-
Abhijeet Kandalkar authored
This CL replace use of AccountTrackerService{SetIsAdvancedProtectionAccount/ RemoveAccount} by AccountsMutator{UpdateAccountInfo/RemoveAccount} and removes unused headers. Bug: 922764 Change-Id: I24554f7dfc0e8e1f97ab5b4b98dca6d7eeed3b25 Reviewed-on: https://chromium-review.googlesource.com/c/1428505Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#627020}
-
Lucas Furukawa Gadani authored
It is not necessary to post a task to the IO thread since the WebViewRendererState was made thread-safe. This fixes a race between updating the info on the IO thread and spawning the renderer process. Bug: 925920 Change-Id: I2627011ca8ba5f9c77b2e090e65ff8c97a69aa91 Reviewed-on: https://chromium-review.googlesource.com/c/1440723Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#627019}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fdefacc215d5..7d8157f63dcc Created with: gclient setdep -r src-internal@7d8157f63dcc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I7e96dd93a2d148e1c208f38b21e5e7147cb6cf84 Reviewed-on: https://chromium-review.googlesource.com/c/1443032Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627018}
-
Kevin Ellis authored
* Creates 2 global scopes to facilitate enforcement of statelessness of non-stateful animations. * Defaults to stateful to reduce potential impact on existing worklets. * Separates logic for creating/removing animators from mutator updates. * Switch stateless global scope in a round-robin fashion after N mutation where N is rand in [1, 10)) * Update test expectations to reflect that some tests produce duplicate output (i.e. output for each global scope). Bug: 914918 Change-Id: If74eca7585a55ff4483f53572492e68db526ccb4 Reviewed-on: https://chromium-review.googlesource.com/c/1409844Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#627017}
-
Kevin McNee authored
This reverts commit 0dd5cc0a. Reason for revert: RemoveSupervisedUsersBrowserEnabledTest.SupervisedUserRemoved has a use-after-free https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31266 Original change's description: > Remove all legacy supervised users on startup. > > The flag is: RemoveSupervisedUsersOnStartup. > It is disabled by default. > > The tests in this CL verify that when the feature is disabled, no users > are removed, and when the feature is enabled, *only* the Supervised > users are removed. > > Bug: 916685 > Change-Id: I32882e786f457a27368724415b65e6a428e4b70b > Reviewed-on: https://chromium-review.googlesource.com/c/1384934 > Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Danan S <danan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626865} TBR=michaelpg@chromium.org,jdufault@chromium.org,danan@chromium.org Change-Id: I50a08e80981cdb609d0800f5f3ef1974a04e883b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 916685 Reviewed-on: https://chromium-review.googlesource.com/c/1443033Reviewed-by:
Kevin McNee <mcnee@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#627016}
-
Koji Ishii authored
Following bot results are included. 14324 14335 14342 14363 14376 14381 14385 14394 0 lines were removed and 1 lines were deflaked by consecutive results since 14293. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I2753b8b74157bdb67306abcf2c95e0f97b17197e Reviewed-on: https://chromium-review.googlesource.com/c/1439458Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#627015}
-
Brian White authored
Bug: 923083 Change-Id: Ida81994cad5060b20679eb71c50365cf2547dc0c Reviewed-on: https://chromium-review.googlesource.com/c/1442892 Auto-Submit: Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#627014}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/755d744023ff..ec061ddc31ca git log 755d744023ff..ec061ddc31ca --date=short --no-merges --format='%ad %ae %s' 2019-01-29 chiur@google.com Setup Kokoro linux build 2019-01-28 sugoi@google.com Framebuffer clear assert fix 2019-01-28 wez@chromium.org [Fuchsia] Use the read/write permission flag names when mapping VMOs. 2019-01-28 capn@google.com Fix LLVM 3.0 build issue. 2019-01-25 sugoi@google.com Implementation of partial clear 2019-01-25 sugoi@google.com Support for clearing Framebuffer attachments 2019-01-25 sugoi@google.com Basic RenderPass implementation 2019-01-25 sugoi@google.com QueryPool object creation 2019-01-24 sugoi@google.com vkGetImageSubresourceLayout implementation 2019-01-24 sugoi@google.com Fixed a crash using TransformFeedback with DrawArraysInstanced 2019-01-23 lfy@google.com Add GL_OES_EGL_image_external_essl3 2019-01-22 chrisforbes@google.com Use unique names for each LLVM IR dump 2019-01-21 chrisforbes@google.com Change routine names to be strings of char 2019-01-18 chrisforbes@google.com make NDEBUG version of UNIMPLEMENTED() macro variadic too Created with: gclient setdep -r src/third_party/swiftshader@ec061ddc31ca The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:925597,chromium:b/123193054,chromium:b/123193048 TBR=swiftshader-team+autoroll@chromium.org Change-Id: Ice2a2243acf5e1cb4b3546dfdf0a799800e3ef94 Reviewed-on: https://chromium-review.googlesource.com/c/1443031Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627013}
-
Roman Aleksandrov authored
Bug: 879146 Change-Id: I68231705893ab32b2bc21764c3d074c2fd995d79 Reviewed-on: https://chromium-review.googlesource.com/c/1422737Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#627012}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a09731e5cf3e..f8397f2b3f00 git log a09731e5cf3e..f8397f2b3f00 --date=short --no-merges --format='%ad %ae %s' 2019-01-29 robertphillips@google.com Split GrContextThreadSafeProxy into its own files Created with: gclient setdep -r src/third_party/skia@f8397f2b3f00 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I25c42f9adeaa28477294190668fe265e97456b05 Reviewed-on: https://chromium-review.googlesource.com/c/1442539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#627011}
-
Antonio Gomes authored
This reverts commit 71359b31. Reason for revert: message from the sheriff that reverted it [1]: " Well, theoretically there still could have been an interaction of your CL with another one that would have caused the failing test to change from ActivityKeptInPref to SupervisedUserRemoved. That said, the MSan build with my revert just finished and it's indeed still red. So your CL likely indeed wasn't the culprit. Sorry for that. Please go ahead and reland. " [1] https://bugs.chromium.org/p/chromium/issues/detail?id=926154#c10 Original change's description: > Revert "[s13n] Migrate ContentAreaAccountsMigration away from GCMS::Observer" > > This reverts commit 5f7f5569. > > Reason for revert: Seems to break multiple Chrome OS trybots. See crbug.com/926154 for more details. > > Original change's description: > > [s13n] Migrate ContentAreaAccountsMigration away from GCMS::Observer > > > > CL changes the inheritance ofi ContentAreaAccountsMigration from > > GaiaCookieManagerService::Observer to IdentityManager::Observer instead. > > > > No functionality change expected. > > > > BUG=859882 > > > > Change-Id: I907b2624d23e93b6a0ecbcda3e39f0322f238612 > > Reviewed-on: https://chromium-review.googlesource.com/c/1436916 > > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > > Reviewed-by: Lowell Manners <lowell@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#626748} > > TBR=xiyuan@chromium.org,tonikitoo@igalia.com,lowell@chromium.org > > Change-Id: Ide04520a6a6f249e5220a6b9086c80b591bc923e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 859882,926154 > Reviewed-on: https://chromium-review.googlesource.com/c/1442197 > Reviewed-by: Martin Šrámek <msramek@chromium.org> > Commit-Queue: Martin Šrámek <msramek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626972} TBR=xiyuan@chromium.org,msramek@chromium.org,tonikitoo@igalia.com,lowell@chromium.org Change-Id: I565d0335169be1e4fb61954f0d2f1a3dc8319cc7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859882, 926154 Reviewed-on: https://chromium-review.googlesource.com/c/1443231Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#627010}
-
Ella Ge authored
Spin button was setting capturing_ bit on mouse hover, and clear it on either mouse up or mouse move but not hover it. It's different from all other capture behavior, and it causes a bug that capturing_ bit will not be set to true again when click again without move mouse. This CL changes the spin button to set capture on mouse down instead of mouse move (which is align with other capture behavior such as slider thumb element) This CL also changes spin button element capturing to using set/releasePointerCapture api instead of the old method. Bug: 748073, 919908 Change-Id: I9c501e0b60501707d15f39a5be5efb4e8e12c620 Reviewed-on: https://chromium-review.googlesource.com/c/1432332Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#627009}
-
Keishi Hattori authored
Backings that we are freeing should not contain any interiors that are registered in HeapCompact. This adds a speculative check to diagnose a crash. Bug: 918064 Change-Id: I8c70bb4c2f455f7881474e981a56cb6c7197b94b Reviewed-on: https://chromium-review.googlesource.com/c/1437037Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#627008}
-
Corentin Wallez authored
This reverts commit 90f6b880. Reason for revert: see 926185 Original change's description: > gpu: support RGB10_A2 in copyTextureCHROMIUM > > This CL extends the copyTextureCHROMIUM implementation to support > RGB10_A2 (see bug for the use case). > > It also extends gl_copy_texture_CHROMIUM_unittest.cc appropriately, > and cleans it a tiny bit (const, removal of dead code, style). > > For some reason, glCopy(Sub)TextureCHROMIUM() fails on Adreno 4xx, > this CL adds a workaround for it, see crbug.com/925986. > > Bug: 922198, 925986 > Change-Id: I8e4e95d766e89282cec1fc11e86c2c2fadc807fc > Reviewed-on: https://chromium-review.googlesource.com/c/1418330 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Antoine Labour <piman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626896} TBR=mcasas@chromium.org,piman@chromium.org Change-Id: Ib4702d6cf59885f7c4044977b2d28f9075b6e571 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 922198, 925986 Reviewed-on: https://chromium-review.googlesource.com/c/1443113Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#627007}
-
dstockwell authored
* externs were fixed upstream, so the supplemental externs can be removed Bug: 902646 Change-Id: I9b0011af0d45a798adfc54557b3ae77dd34d52f4 Reviewed-on: https://chromium-review.googlesource.com/c/1440801Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Auto-Submit: dstockwell <dstockwell@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#627006}
-
Dmitry Gozman authored
The following tests were not waiting for the iframe to load, so they effectively excercised CSP against about:blank iframe: - to-javascript-parent-initiated-child-csp.html - to-javascript-parent-initiated-parent-csp.html One of the tests doesn't pass now, which needs investigation. Bug: 694525 Change-Id: I218426b5d6b1b163d5acfc01522ebf9606c977d6 Reviewed-on: https://chromium-review.googlesource.com/c/1438339Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#627005}
-