GitLab

TBR=sullivan@chromium.org

Bug: 906656
Change-Id: I6eb1c8604b8dc6307fde4df09bfbe7c2918aeb8a
Reviewed-on: https://chromium-review.googlesource.com/c/1343062Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609542}

Change-Id: I5a5f176793365ee972b0a857531df9daef99ec03
Reviewed-on: https://chromium-review.googlesource.com/c/1343523
Commit-Queue: Xi Cheng <chengx@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609541}

Bug: 640835
Change-Id: I4aa79b8af48f7dfd63c288dc7c4506fa4a4bf73e
Reviewed-on: https://chromium-review.googlesource.com/c/1338999Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Adrienne Porter Felt <felt@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609540}

When Crostini users invoke x-terminal-emulator $CMD, the contents of CMD
are eventually passed by CrostiniManager in an args[] array to crosh as part
of its URL.

Fixed in this CL: incorrect usage of vector<StringPiece>.
We were adding more pieces in line 1065 which were derived from temporaries
(return values of net::Escape...). The temporaries were thrown away but the
pieces still pointed to the same memory and we sent nonsense to
base::JoinString().

Bug: 898111
Change-Id: If5d3ffcb6ab28d01698ee48cd7fd3d2230381f95
Reviewed-on: https://chromium-review.googlesource.com/c/1341282
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609539}

WebglConformance_conformance2_rendering_canvas_resizing_with_pbo_bound is failing on
Linux Nvidia FYI release. Suppress this test.

BUG=906846
TBR=kbr@chromium.org

Change-Id: I4d93b16a54df7c247ce90022804fea36fc9408d4
Reviewed-on: https://chromium-review.googlesource.com/c/1343373Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Robert Kroeger <rjkroege@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609538}

https://webrtc.googlesource.com/src.git/+log/2e0c655bc6c5..b6787bcd79f8


git log 2e0c655bc6c5..b6787bcd79f8 --date=short --no-merges --format='%ad %ae %s'
2018-11-19 srte@webrtc.org Using data unit classes in DelayBasedBwe.


Created with:
  gclient setdep -r src/third_party/webrtc@b6787bcd79f8

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I337fe422ded952e3d233920072008c556733494a
Reviewed-on: https://chromium-review.googlesource.com/c/1343182Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609537}

In crrev.com/c/1256016, we moved FidoAuthenticator instantiation and
ownership into the respective FidoDiscovery subclasses. This also
eliminated FidoRequestHandlerBase::CreateAuthenticatorFromDevice() which
was where we previously wrapped a discovered FidoDevice in a
FidoDeviceAuthenticator before adding it to the request handler.

In fido_request_handler_unittest, this was used as a testing seam to
inject a FakeFidoAuthenticator implementation. Injection of the fake was
dropped, but the "real" FidoDeviceAuthenticator was still casted into a
pointer to the fake elsewhere. While this seems to not bother compilers
too much, it's probably a Bad Idea. This CL therefore entirely removes
the FakeFidoAuthenticator class (without changing semantics of the
fixture or the tests).

Bug: 903294
Change-Id: I7a6bad330b1152dc455ded5b6db3d3309f4eb3be
Reviewed-on: https://chromium-review.googlesource.com/c/1340903Reviewed-by: Jun Choi <hongjunchoi@chromium.org>
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609536}

Bug: 903972
Change-Id: Iba29af4d63e0e8dc68c728d0965e22c11bed8653
Reviewed-on: https://chromium-review.googlesource.com/c/1343354Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609535}

Bug: 835717, 880027
Change-Id: I074ea4b911132477853bf95be70a36b7d62c4f79
Reviewed-on: https://chromium-review.googlesource.com/c/1330903Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609534}

The model's visibility property starts off as false even though the
browsing mode bottom toolbar is visible initially. Also looks like we
had a bug in the view binder where visibility did the opposite of
what we wanted it to. Not sure how anything worked without this fix...

Bug: 905551
Change-Id: I6737aa480563f5c19d3938486b575dbd5841a184
Reviewed-on: https://chromium-review.googlesource.com/c/1341143Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609533}

For chromad kerberos users, we do not resolve mount paths and instead
rely on the domain controller to resolve it. This CL fixes a bug where
windows URIs were not converted to the cannoncial smb:// format that is
expected by libsmbclient resulting in an INVALID_OPERATION error.

Bug: chromium:906269
Change-Id: I363e9375a32d2d0d6a990c0fdaab11a4aced064a
Reviewed-on: https://chromium-review.googlesource.com/c/1341022Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609532}

Change-Id: Ic230f0ab94f94adfd96cb513710d1c129e96d1db
Reviewed-on: https://chromium-review.googlesource.com/c/1343053Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Artur Khachatryan <khachatryan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609531}

Replace std::vector in Network Quality Estimator (NQE) by an array.
This is an attempt to avoid the crash that happens only on
Windows when rtt_ms_observations_ vector is referenced.

Change-Id: I8a3e0e45be6881bfb02442a62c7403aaa5b8078f
Bug: 899808
TBR: ryansturm@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1343345Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Doug Arnett <dougarnett@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609530}

The phones were flashed to aosp recently and the exact version changed
a little.

R=jbudorick
NOTRY=true  # crbug.com/906840 for akar failures

Bug: 880623
Change-Id: If0e0b4f8e5cf5bcc6269b879af873f0f8dc5bf84
Reviewed-on: https://chromium-review.googlesource.com/c/1343295
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609529}

Change-Id: I59fe94a572d24fef984cb6d1494d6e209217d8f0
Reviewed-on: https://chromium-review.googlesource.com/c/1343497Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609528}

NotificationIntentInterceptorTest is based on UI automator to click on
Android UI outside Chrome UI, it relies on Android UI implementation,
that we probably can delete this test.

TBR=dtrainor@chromium.org, qinmin@chromium.org

Bug: 906843
Change-Id: I83f81f960ddbe8e9f6cb8d2a70820c811182a313
Reviewed-on: https://chromium-review.googlesource.com/c/1343375Reviewed-by: Xing Liu <xingliu@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609527}

Bug: 899437
Change-Id: I4d6167d30a7b7014c17393960fce3ecb1470b80e
Reviewed-on: https://chromium-review.googlesource.com/c/1342778
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609526}

More cleanups, this is just within ash, not within app_list or shelf.

Bug: 906684
Change-Id: I42b6a0b6765481685a1ec5e612b4d849f8f3f0ff
Reviewed-on: https://chromium-review.googlesource.com/c/1342766Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609525}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/26fa18517532..739d7c2cc952


Created with:
  gclient setdep -r src-internal@739d7c2cc952

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I5c7c5f663099d2f1d25bad9ffb663307531387b1
Reviewed-on: https://chromium-review.googlesource.com/c/1342944Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609524}

Bug: 900608
Change-Id: Ic1647bbcc227f8ac497b01a05a4ca4fcefe3b9ae
Reviewed-on: https://chromium-review.googlesource.com/c/1340829
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609523}

Some Linux drivers do not seem to recover well after OUT_OF_MEM and context lost.

BUG=893117
TEST=bots
R=piman@chromium.org

Change-Id: I55faefe2d631f3a682dd0b441d2a835836b792a6
Reviewed-on: https://chromium-review.googlesource.com/c/1343102Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609522}

Bug: chromium:905702
Test: manual, unit tests
Change-Id: I8e6902706a67eaa1e712c6c1147c4cc696b67fb2
Reviewed-on: https://chromium-review.googlesource.com/c/1338170
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609521}

NetworkContext::domain_reliability_monitor_ was being destroyed before the URLLoaders that are owned by NetworkContext::url_loader_factories_ because of the declaration order. Reset domain_reliability_monitor_ in the destructor so that it's not used later (since we null-check it before use).

Bug: 906452
Change-Id: Ib4ec198953142672a3991a4c62436733bd8da171
Reviewed-on: https://chromium-review.googlesource.com/c/1343337
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609520}

Bug: 876901
Change-Id: Ic8a37a79fe8bd41606f6be2ef5e5e2e6bc268e7e
Reviewed-on: https://chromium-review.googlesource.com/c/1341738Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609519}

GenericDmaBufVideoFrameValidator swaps U plane and V plane addresses so that
VideoFrameValidator is able to libyuv::I420Copy in the order Y, U and V. This
is a wrong design, meaning VideoFrameMapper does not only map but also
does something. VideoFrameMapper caller should expect the address acquired by
VideoFrame::data(UPlane) is V plane's and one by VideoFrame::data(VPlane) is U
plane's in the case of YV12 VideoFrame.

BUG=chromium:895230, chromium:856562
TEST=VDA unittest on hana with --frame_validator=check
TEST=VEA unittest on hana with --native_input

Change-Id: Ibf5e5685d95634fe6720f07dc154fd01907516d8
Reviewed-on: https://chromium-review.googlesource.com/c/1341783Reviewed-by: Pawel Osciak <posciak@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609518}

Using wpt-import in Chromium 0ce5f96e.
With Chromium commits locally applied on WPT:
5ee777f6 "Fix test exclusion logic of wpt/referrer-policy test generator
warning: inexact rename detection was skipped due to too many files.
warning: you may want to set your diff.renameLimit variable to at least 1920 and retry the command."


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I90af7441279da10c77821cd8bd343d11f5c41cd9
Reviewed-on: https://chromium-review.googlesource.com/c/1343252
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#609517}

This CL fixes a regression which replaced feature names on this page
with numbers representing the features. The regression was caused by
erroneous removal of the #include containing the operator<<() function
which prints the enum names.

Bug: 906836
Change-Id: Idb35e491ff379cc0ea97e63b57b4078a85efd0af
Reviewed-on: https://chromium-review.googlesource.com/c/1343350Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609516}

Bug: 835455
Change-Id: If3f4eacb975a8ee50a66bb787a55d257633cfb1e
Reviewed-on: https://chromium-review.googlesource.com/c/1242572
Commit-Queue: Alice Boxhall <aboxhall@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609515}

This enables the views version of the message_center, in preparation
for removing the Cocoa implementation.

Fixes:
- Use an EventGenerator in tests, rather than manually synthesizing
  events.
- NotificationInputContainerMD::HandleKeyEvent() now explicitly clears
  the text input field when handling VKEY_RETURN, as the test expects
  this.
- Disabling notifications is no longer handled in
  NotificationViewMD::ButtonPressed(), since it wasn't the button
  Listener for the block_all_button_ (the
  NotificationControlButtonsView is). Disabling is now handled in
  ToggleInlineSettings() instead.
- The SlideOut tests are disabled on Mac because the test framework
  doesn't support synthesizing gesture scroll events.

Bug: 739386
Change-Id: Id841779233662111f52d491ba78e5315422003b4
Reviewed-on: https://chromium-review.googlesource.com/c/1341091
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609514}

R=rouslan@chromium.org

Bug: 900477
Change-Id: I48e0221d6df217863427316967a166174c0acf04
Reviewed-on: https://chromium-review.googlesource.com/c/1342760
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609513}

This CL expands upon [1], which was a quick fix to fix a crash in the
M-71 branch. This follow-up CL makes the class more robust by ensuring
that if connection priority is updated before a connection attempt is
made, the connection will be made with the updated priority when it is
performed.

Additionally, this CL adds a test for this functionality.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1338322

Change-Id: I9a881c67276c5f571b9119c27d899762b9c5f02f
Reviewed-on: https://chromium-review.googlesource.com/c/1340977Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609512}

This is the first CL of web share target V2.

The goal of this CL is to add support for three new fields: method, enctype, and fields.
This is in reference to the new web share target spec.
https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#share_target-member

The purposes of each field are as follows:
method:  the HTTP method used for launching the web share target. Can be either GET or POST.
enctype: the encoding method used for launching a POST request web share target. Can be
         either application/x-www-form-urlencoded or multipart/form-data.
files:   a sequence of files each containing a name and an accepted sequence of mime types.
         Note that this can only be populated if the method is POST and the enctype is
         multipart/form-data.

Logic checks are performed in manifest_parser.cc to determine if the web share target
has a valid combination of fields.

Bug: 885308
Change-Id: I277fef7e1402620385cb28909a078eb09676c1fc
Reviewed-on: https://chromium-review.googlesource.com/c/1240867
Commit-Queue: Ethan Xu <xuethan@google.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Glenn Hartmann <hartmanng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609511}

This CL changes how the computation of the content insets of the scroll
view displaying the PDF is done on iOS 11.

Bug: 903635
Change-Id: I5dc8d69b4fbf0a6e68db1481f1991c9bdbc0b43b
Reviewed-on: https://chromium-review.googlesource.com/c/1341988
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609510}

The current comment suggests that it does, but it seems worthwhile to
make it explicit given that the name of the event might suggest
otherwise.

Change-Id: Ie0ab5a95a462e9e493336644fa1d7f4ecd5edc42
Reviewed-on: https://chromium-review.googlesource.com/c/1340859Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609509}

BUG=chromium:901830

Change-Id: I491fa83b4fe6e817e9bfb285ed81ce3b4356088f
Reviewed-on: https://chromium-review.googlesource.com/c/1341843Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609508}

Conditionally disables this test due to flakiness on this configuration.

BUG=906788

TBR=twellington@chromium.org

Change-Id: Ief4f08ae1d9f8c73b3055d136af655498a97892f
Reviewed-on: https://chromium-review.googlesource.com/c/1343361Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609507}

lossless encoder speedups and memory reduction when decoding corrupt images

Bug: 905157
Change-Id: I0122578ae12a3654ddb2b9dead13ef3823fddc19
Reviewed-on: https://chromium-review.googlesource.com/c/1337378Reviewed-by: Urvang Joshi <urvang@chromium.org>
Commit-Queue: James Zern <jzern@google.com>
Cr-Commit-Position: refs/heads/master@{#609506}

TBR=mmoroz@chromium.org

Change-Id: Ida8773dbc2d4d13a04dc96b2afc84e1a8d0c94f4
Bug: 904877
Reviewed-on: https://chromium-review.googlesource.com/c/1343245Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609505}

Bug: 630147
Change-Id: I20541f77c7e9e8d5a0085452d2a883e24563083c
Reviewed-on: https://chromium-review.googlesource.com/c/1330069
Commit-Queue: Steven Valdez <svaldez@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609504}

This'll make it easier for me to delete surrounding code, and I can't
find any references to it so I suspect that it's safe to prune.

Bug: 868398
Change-Id: Ib62d77f87df261200c6e6c1b821f99ed707041b9
Reviewed-on: https://chromium-review.googlesource.com/c/1343058
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609503}