- 06 Feb, 2018 40 commits
-
-
Rohit Rao authored
UIStackView automatically positions views in a vertical column, which allows us to remove a number of positioning constraints. This also makes it possible to change individual pieces of the incognito ui without needing to modify any constraints. BUG=805521 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib746a91202946235e6de3c20f88947d8e85ee49b Reviewed-on: https://chromium-review.googlesource.com/900182 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#534722}
-
Evan Stade authored
Various changes: - Start adding DEPS exceptions in preparation for banning ui/message_center dependencies more broadly. - Remove a file full of constants in ui/message_center - delete some unnecessary message_center.h includes - remove some message center color constants in favor of direct use of Label::SetAutoColorReadabilityEnabled. BUG=783018,723882 TBR=rogerta@chromium.org Change-Id: Ia7b9332d575a77581691f65f98c945754820c212 Reviewed-on: https://chromium-review.googlesource.com/879501Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#534721}
-
https://chromium.googlesource.com/catapult.git/+log/a1303e46889b..4c7a9a8e39f1 $ git log a1303e468..4c7a9a8e3 --date=short --no-merges --format='%ad %ae %s' 2018-02-05 estevenson [Dashboard] Add M64-M65 milestones to speed releasing dashboard. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1d55b4af1eeaa37a6b5931d07407ee44e3ffe876 Reviewed-on: https://chromium-review.googlesource.com/904805 Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#534720}
-
Pavol Marko authored
Move parsing of the 'Certificates' section of ONC to the new class OncParsedCertificates. CertificateImporter uses this as its input. This is a preparation for not importing policy-provided server and authority certificates into the NSS database anymore, but only making them available as temporary NSS certificates. chromeos_unittests --gtest_filter=*CertificateImporter* && chromeos_unittests --gtest_filter=OncParsedCertificatesTest* Bug: 787602 Test: unit_tests --gtest_filter=*NetworkConfigurationUpdater* && Change-Id: Id42f512c9b2287eb582ef3f6ade6b31f32eaf024 Reviewed-on: https://chromium-review.googlesource.com/898963Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#534719}
-
Hidehiko Abe authored
BUG=739622 TEST=Ran on bots. Change-Id: I6e968439859b4409a14621a03bd3a20f8ebe36f2 Reviewed-on: https://chromium-review.googlesource.com/901682 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#534718}
-
Chris Nardi authored
Import wpt/css/css-pseudo. 3 tests were added to NeverFixTests as ::marker has not been implemented. first-letter-001.html passes only on Mac and first-letter-002/003.html only fail on Linux. Bug: 808834, 808837 No-Export: true Change-Id: I3a248cb0d927de755313b05fb885b0348885886d Reviewed-on: https://chromium-review.googlesource.com/900686Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#534717}
-
Anita Woodruff authored
R=peter@chromium.org Change-Id: I7f66591e63807506f50614c7d19d0dbaf77d681d Reviewed-on: https://chromium-review.googlesource.com/904702 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#534716}
-
Dominik Röttsches authored
The discussion in 784493 shows that performing ink skipping for the SOLIDUS or slash character results in URLs looking jagged / appearing as multiple URLs. This depends on the font and device pixel ratio. In some fonts, the slash extends below the baseline, in some it does not. Depending on device pixel ratio the underline is rendered one or two device pixels below the baseline. Similarly, ink-skipping for underscores breaks up in the text in an unexpected way. As a compromise, exempt SOLIDUS, REVERSE SOLIDUS, LOW LINE from ink skipping, as we already do for CJK characters. Bug: 784493 Change-Id: I1d26cf1229b7f16e4a161b34758302a7e33230eb Reviewed-on: https://chromium-review.googlesource.com/897663 Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#534715}
-
Simon Que authored
Allow the rate limiter to start with and accrue up to 10 access allowances. This allows an extension to read multiple times from the API in a short burst, while still being throttled if it goes on for too long. BUG=808598 Change-Id: I03746f2ee3ade64c87e2b2184467a8e66206a6b8 Reviewed-on: https://chromium-review.googlesource.com/900183 Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#534714}
-
Doug Arnett authored
Also cleans up Amp Redirection from the internals page Interventions tab. Bug: 803221 Change-Id: I130dd7430236e87406696ff685d0a341dd87e641 Reviewed-on: https://chromium-review.googlesource.com/902383Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#534713}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ebe77c45..a24f6910 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: If26d46438cc2c27725be561dad8997261541e316 Reviewed-on: https://chromium-review.googlesource.com/903822Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#534712}
-
Hidehiko Abe authored
BUG=739622 TEST=Ran chromeos_unittests. Change-Id: Ic79e5491ccf36e2cb83642545dd5b29763c0eedc Reviewed-on: https://chromium-review.googlesource.com/903607Reviewed-by:
-
Sammie Quon authored
Increase font and change icon and paddings. Also change dimmed overview windows opacity. Test: manual Bug: 782320 Change-Id: I1cbb78e06389a7f7335bf9cff86fde0b7b7eacc8 Reviewed-on: https://chromium-review.googlesource.com/892087 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#534710}
-
Daniel Bratell authored
SpeechRecognizerState is an enum in the Windows platform API for speech so using that name for a Chrome internal type means that you get compilation errors if the platform headers and the internal headers end up in the same translation unit. In jumbo builds that could happen (and in general it can also happen) so this renames SpeechRecognizerState -> SpeechRecognizerStatus to avoid that. An alternative would be to move the enum to a different, more limited, scope. Bug: 746957 Change-Id: I479470340ea2c582480b2692424a15bc6fb4581a Reviewed-on: https://chromium-review.googlesource.com/901247Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#534709}
-
Anthony Berent authored
Having multiple directories for screenshots complicates adding the UI capture tests to the bots, and is no longer needed to identify the screenshots or to make the file names unique. Put all the screenshots in a single directory. Bug: None Change-Id: Ie25b9a1f9bacd5ada27e57fdbd742b1a9d893fa6 Reviewed-on: https://chromium-review.googlesource.com/902102 Commit-Queue: Anthony Berent <aberent@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#534708}
-
Peter Boström authored
These strings were missed as they were not in generated_resources.grd. Bug: chromium:807886 Change-Id: I3c0c812f751487fffa6dc167cff21e0af269bf73 Reviewed-on: https://chromium-review.googlesource.com/902187 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#534707}
-
arthursonzogni authored
All of this happens when S13nServiceWorker is enabled. The removed DCHECK was here to enforce that the ControllerServiceWorker is not updated after container host connection has been closed. A race condition can happen and triggers this DCHECK. After CommitNavigation(), if the browser process is slow enough, a javascript call can delete the iframe before the OnProviderCreated/SetController round trip between the browser and the renderer has been made. Deleting the iframe cause OnContainerHostConnectionClose() to be called. It happens before receiving the SetController call. ┌───────┐ ┌────────┐ │Browser│ │Renderer│ └───┬───┘ └───┬────┘ │CommitNavigation() │ │──────────────────>│ (ResetController()) │ │ │OnProviderCreated()│ │<──────────────────│ │─┐ │─┐ │ │ │ │ Remove the iframe. │ │ │ │ (OnContainerHostConnectionClose()) │ │ Sleep... │<┘ │ │ │ │<┘ │ │ │ │ SetController() │ │──────────────────>│ (ResetController()) ┌───┴───┐ ┌───┴────┐ │Browser│ │Renderer│ └───────┘ └────────┘ Note: The CL... https://chromium-review.googlesource.com/897629 ...shows adding a delay in the browser process causes several service worker tests to fail. Note: Doing SetController() on response to OnProviderCreated() is no really necessary since thttps://goo.gl/UztxVi was implemented by https://chromium-review.googlesource.com/742961. This was kept to update UseCounter. Bug: 808071 Change-Id: I46c4fd8e4db7eb4ed5e304bb1989d36d552567ad Reviewed-on: https://chromium-review.googlesource.com/899143 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#534706}
-
Eric Lawrence authored
To limit mischief, replace the target of JavaScript-scheme links in HTMLViewSourceDocument with about:blank. Bug: 705206, 808407 Change-Id: I185006d0cb29caabcd08dd9d5b9324357c79efaa Reviewed-on: https://chromium-review.googlesource.com/900099Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#534705}
-
Evan Stade authored
Intuit the button type from the presence or absence of the placeholder text. Bug: 797128 Change-Id: I6fe658f644e42b0556ffcaac9bc7322f44f88fea Reviewed-on: https://chromium-review.googlesource.com/900184Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
-
Ahmed Fakhry authored
This CL implements the skeleton of the Docked Magnifier code, including watching and updating user prefs, and the mojo APIs for communication between ash and Chrome so that Chrome can notify ash of focus change events in webpages. BUG=709824 TEST=ash_unittests --gtest_filter=DockedMagnifierTest.* Change-Id: I4a03103a36f4b99c2eeba86feabf304962800098 Reviewed-on: https://chromium-review.googlesource.com/898030Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Jacob Dufault authored
Reason for original revert: Causes the following browser_tests to segfault on Chromium OS ASAN/LSAN builders: WebviewLoginTest.AllowNewUser WebviewLoginTest.EmailPrefill WizardControllerCellularFirstTest.CellularFirstFlow WizardControllerFlowTest.ControlFlowMain - https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20(1)/25959 Bug: 784495 Change-Id: If19459259e6927e8e05127ebfb77472d1b1d7ddd Reviewed-on: https://chromium-review.googlesource.com/898385Reviewed-by:Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#534702}
-
khmel authored
Setting app launcher icon is multi-step process. At first step we set default (or pre-loaded icon) and then try to fetch, decode and load actual icon. For some app fetch/decode step may be skipped. At this case icon is left what was set at first step. With recent refactoring, app launcher icon and chrome app icon were split and synced via updater. App launcher item is created after Chrome app item. Some attributes from Chrome app are passed via metadata but not the icon. This CL sets the icon from Chrome app item to app laucnher item at the moment of creation app launcher item. Bug: 809269 Test: Manually Change-Id: Iee8f5701d41f2ea19533d7df3edcc3898d606044 Reviewed-on: https://chromium-review.googlesource.com/902610Reviewed-by:
-
Adam Langley authored
I fear that if we don't do this, we may not be able to add things in the future when we need to. Bug: none Change-Id: I94c49b8a5a336051ae7a62928fc48e4300649b19 Reviewed-on: https://chromium-review.googlesource.com/895392 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#534700}
-
Erik Staab authored
This reverts commit 744ac3cb. Reason for revert: Causing tree closure, https://crbug.com/809399 Original change's description: > Automated Commit: Committing new LKGM version 10378.0.0 for chromeos. > > TBR=chrome-os-gardeners@google.com > > Change-Id: I528bfa26dc2aa797c5c2e5911fa28f6055a03f67 > Reviewed-on: https://chromium-review.googlesource.com/903566 > Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534661} TBR=chrome-os-gardeners@google.com,chromeos-commit-bot@chromium.org Change-Id: Ic6927bf3095a02736c79c5c8db6b5568194c1fd5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/904862Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#534699}
-
Xianzhu Wang authored
Bug: 771643 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I4d2973be5eb7b13351de62d283b5feb88fa42490 TBR: Reviewed-on: https://chromium-review.googlesource.com/903104Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#534698}
-
Steve Kobes authored
Like previous RLS rebaselines, the layer trees reflect composited scrolling layers for documents, the elimination of PLC layers on iframes, and "flattenInheritedTransform": false (crbug.com/778060). "Child Containment Layer" appears for iframes that are composited by transform, but lack scrolling layers because they have no overflow or have scrolling="no" (crbug.com/784053). Bug: 544140 Change-Id: I03f5cf370724ff2f00de8f8f6b497fa0f39af76e Reviewed-on: https://chromium-review.googlesource.com/902746Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#534697}
-
Doug Turner authored
This test uses a client side redirect which causes two navigations. The first navigation loads the html document which has a meta refresh tag in it. The second navigation is caused by the redirect itself. The existing code would only wait for the *first* navigation to complete. On fast machines, this isn't a problem as the race would be usually won and the redirected page would be present when we reached the GetTitle check. On slower machines, it seems that this race is more frequently lost. This CL changes the test to wait for two navigations before continuing. Bug: 809187 Change-Id: If88bff4bcd8ff3cb5be23b54b9675c3edbe17983 Reviewed-on: https://chromium-review.googlesource.com/903239Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#534696}
-
Ehsan Karamad authored
In a hack was added to remember the position of last mouse down/up for context menus. The hack was intended to fix the position of context menu for BrowserPlugin-based <webview>'s under CSS-transforms. The code was added here: https://codereview.chromium.org/1293963002 With <webview> being implemented on top of OOPIFs now we no longer require such a hack to draw the context menu correctly. The code is currently stale and does not ever get called. Bug: 533069 Change-Id: I5f78c02210f0255c66df3f01622b6a0ffead801e Reviewed-on: https://chromium-review.googlesource.com/900702 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#534695}
-
Guido Urdaneta authored
Bug: 809537 Change-Id: I54951259e0b64944c92c0d28e06f16e4584b7460 TBR: reillyg@chromium.org Reviewed-on: https://chromium-review.googlesource.com/904643Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#534694}
-
Ken Rockot authored
Assuming based on a small amount of evidence that there may be a bug causing some ChannelAssociatedGroupController instances to leak, this CL ensures that in such cases, the object's outgoing message queue will not also leak. Bug: 808725 Change-Id: I256dd264b811f9ccb8e8e3ee86f2b58f916f1560 Reviewed-on: https://chromium-review.googlesource.com/902813Reviewed-by:
Yuzhu Shen <yzshen@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#534693}
-
Geoff Lang authored
TBR=jmadill@chromium.org BUG=809297 BUG=angleproject:2303 Change-Id: I5bd998c3b7eec3dfbba2a8012eba61da0e2b4041 Reviewed-on: https://chromium-review.googlesource.com/904686Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#534692}
-
Dylan Reid authored
The user hash of the active user is needed so crosh can determine which logged in user initiated a command. Crosh will use this data to pass the correct paths to commands that run containers on Chrome OS. Bug: 770766 R=chirantan@chromium.org, tbarzic@chromium.org, vapier@chromium.org Signed-off-by:
Dylan Reid <dgreid@chromium.org> Change-Id: I0e9ef3685dc3f01f15cfb428594b2f9752586676 Reviewed-on: https://chromium-review.googlesource.com/896105Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Mike Frysinger <vapier@chromium.org> Reviewed-by:
-
Leon Scroggins III authored
Bug: 807324 Without the proper fix, this image is truncated. Test that it is not. This image was posted to the bug (as d_AppReq.png), and the owner has given permission to use it: https://bugs.chromium.org/p/chromium/issues/detail?id=807324#c25 Change-Id: I114017e3cc625e0ac6c69056e34b0ee1ad906bb0 Reviewed-on: https://chromium-review.googlesource.com/904262Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#534690}
-
Ella Ge authored
This CL update the wpt test pointerevent_pointerlock_after_pointercapture. Previously this test request pointer lock on pointermove, it got a pointerlockerror event because it doesn't request the lock in a user gesture. This CL change the test to send lock request by a right click. Bug: 805052 Change-Id: I27b60475ccda94ca59e018ab76550379bc3852e4 Reviewed-on: https://chromium-review.googlesource.com/902450Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#534689}
-
Fabio Tirelo authored
This issue was identified in the Russian translation, in which the translation currently used doesn't make sense in that context. We decided to make the string more specific and add a meaning tag to keep it from sharing translation with other "Reset" strings in Chrome (such as reset some color). Change-Id: Ic8d279d450abfdce718d65be752fe8ee6cdeaf31 Reviewed-on: https://chromium-review.googlesource.com/902808 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#534688}
-
John Abd-El-Malek authored
Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I4187878bfb627fb0983dca3a218c65f86d889f7c Reviewed-on: https://chromium-review.googlesource.com/902624Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#534687}
-
Patrick Monette authored
Bug: 717696 Change-Id: I6ff0a2ca192b2fe11426f59336a5e5efe2a8b76e Reviewed-on: https://chromium-review.googlesource.com/887724Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#534686}
-
Batalov Vladislav authored
Pass correct status of network to error handler's constructor. R=jam@chromium.org, juliatuttle@chromium.org Change-Id: Ie48ab19418c87f20f0b441fbe1ab6d44a503da22 Reviewed-on: https://chromium-review.googlesource.com/878327 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Julia Tuttle <juliatuttle@chromium.org> Reviewed-by:
-
Maks Orlovich authored
This lets me change how it's actually passed to op-specific Complete callbacks freely, which I want to do, but is easier to review as a separate change, plus moving a unique_ptr to int feels a bit... silly. Change-Id: If8a3f445779477c4388daf060608fe64858507ec Reviewed-on: https://chromium-review.googlesource.com/902522Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Maks Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#534684}
-
Marcin authored
Currently Android Chrome is opening LINK tab as second in new context menu with two tabs. It can lead to many mistakes when user want to use fast "Open in new menu" for links. Patch is forcing changing tabs order and opening this menu on LINK tab in every situation. Bug: 799417 Change-Id: I1ef989a62501859c45e8a0ee36e6e685e234ed72 Reviewed-on: https://chromium-review.googlesource.com/880945 Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Reviewed-by:
-
