GitLab

BUG=396785
R=isherman@chromium.org

Review URL: https://codereview.chromium.org/417813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285714 0039d316-1c4b-4281-b951-d872f2087c98

The original revert can not be done in isolation. There are dependent
changes in Blink. This revert broke all of the tests on the GPU bots
and likely tests on other bots. Undoing the revert.

> Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/)
> 
> Reason for revert:
> It broke the component builds.
> 
> Original issue's description:
> > Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2
> > 
> > Blink should make use of blink_resources.grd for the inline resources of inspector.
> > This removes the dependency upon using xxd.py which embeds these resources as strings.
> > 
> > Part 1: https://crrev.com/401233003
> > Part 3: https://crrev.com/402033002
> > 
> > BUG=312586
> > 
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436
> 
> TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
> NOTREECHECKS=true
> NOTRY=true
> BUG=312586
> 
> Review URL: https://codereview.chromium.org/421623004

TBR=aurimas@chromium.org

Review URL: https://codereview.chromium.org/420923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285713 0039d316-1c4b-4281-b951-d872f2087c98

We need to support this new hidden api to avoid onDraw getting ahead of
DrawGL. Without this, onDraw can finish producing frame n+1 before DrawGL
consumes frame n, in which case DrawGL skips a frame.

Also make AwDrawGLInfo future proof.

BUG=397358

Review URL: https://codereview.chromium.org/414163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285712 0039d316-1c4b-4281-b951-d872f2087c98

Added UMA to report the type of net error that occurred
when the data reduction proxy probe failed due to a
network error. Note the probe can also fail due to
the response being modified, which this UMA does not
track.

BUG=397256

Review URL: https://codereview.chromium.org/417253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=397693
TBR=gab@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/422433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285710 0039d316-1c4b-4281-b951-d872f2087c98

Also add a |GetArray()| method to |UserPointer<>|.

And fix a bug in my previous change to convert ReadMessage...() (which
I'm too lazy to update) in |PutArray()|. (And also "restore"/convert one
of the ReadMessage...() tests ... which lead me to finding that bug.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/419973005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285709 0039d316-1c4b-4281-b951-d872f2087c98

In record_wpr, we did the following:

  temp_target_wpr_file_path = tempfile.mkstemp()[1]

In python, tempfile.mkstemp() will return a tuple containing the file handle and the file path. Since the script never closes this file handle, it looks like we throw a WindowsError when we try to move the file with the open file handle.

BUG=

Review URL: https://codereview.chromium.org/420893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285708 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395154

Review URL: https://codereview.chromium.org/410713002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285707 0039d316-1c4b-4281-b951-d872f2087c98

Causes compile failures on official builders:

e.g.,
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/

FAILED: ninja -t msvc -e environment.x64 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64\cl.exe" /nologo /showIncludes /FC @obj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj.rsp /c ..\..\chrome\installer\util\chrome_app_host_distribution.cc /Foobj\chrome\installer\util\installer_util_nacl_win64.chrome_app_host_distribution.obj /Fdobj\chrome\installer_util_nacl_win64.cc.pdb 
c:\b\build\slave\google-chrome-rel-win\build\src\chrome\installer\util\chrome_app_host_distribution.cc(126) :error C2065: 'kChromeAppHostGuid' : undeclared identifier
ninja: build stopped: subcommand failed.


> Remove some dead app host code.
> 
> app_host.exe was removed in r220555. This change removes some dead code
> that was left behind. Specifically:
> - chrome_launcher_support no longer exposes any methods related to the
>   AppHost.
> - Chrome's uninstall prompt no longer has a special case to handle
>   suppressing the "delete your profile" checkbox.
> - Chrome and its installer no longer have a dependency on
>   launcher_support.
> - The installer no longer supports installing items from the webstore.
> - GetUntrustedDataValue no longer has consumers and is gone.
> 
> BUG=297647
> R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org
> 
> Review URL: https://codereview.chromium.org/422453004

TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/422593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285706 0039d316-1c4b-4281-b951-d872f2087c98

The state is now taken from the label with the instructions within the bookmark bar.
Now an empty bookmark bar's label is accessible.

BUG=395895

Review URL: https://codereview.chromium.org/408103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285704 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/420663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285703 0039d316-1c4b-4281-b951-d872f2087c98

Also add a |PutArray()| method to |UserPointer<>|.

R=darin@chromium.org

Review URL: https://codereview.chromium.org/417303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285702 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2 (https://codereview.chromium.org/403273003/)

Reason for revert:
It broke the component builds.

Original issue's description:
> Migrate all usages of xxd.py to blink_resources.grd and remove xxd.py - Part 2
> 
> Blink should make use of blink_resources.grd for the inline resources of inspector.
> This removes the dependency upon using xxd.py which embeds these resources as strings.
> 
> Part 1: https://crrev.com/401233003
> Part 3: https://crrev.com/402033002
> 
> BUG=312586
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285436

TBR=jochen@chromium.org,abarth@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=312586

Review URL: https://codereview.chromium.org/421623004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285701 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285700 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178930:178950&mode=html
TBR=haraken@chromium.org,jchaffraix@chromium.org
BUG=

Review URL: https://codereview.chromium.org/417293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285699 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/417933003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285696 0039d316-1c4b-4281-b951-d872f2087c98

Refactors the sync_unit_tests target so it no longer uses strange
export_dependent_settings hacks.  Rather than creating three separate
targets with type 'none' and having the sync_unit_tests target depend on
them, the new setup just puts those dependencies and sources in the
sync_unit_tests target directly.

BUG=397574

Review URL: https://codereview.chromium.org/418163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285695 0039d316-1c4b-4281-b951-d872f2087c98

This has no functional change, but prepares the field for allowing the Mac
to use a different TaskRunner which will allow pumping during resize.

BUG=392031

Review URL: https://codereview.chromium.org/421483003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285694 0039d316-1c4b-4281-b951-d872f2087c98

Now when double tapping with no last touch exploration location, the tap timer is no longer fired, which was previously entering no fingers down state when a finger was actually down.

TEST=TouchExplorationTest.DoubleTapNoTouchExplore
BUG=397296

Review URL: https://codereview.chromium.org/419923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285693 0039d316-1c4b-4281-b951-d872f2087c98

This CL turns const by value return values into const by ref.

Replacing const value by a const ref when a member variable is returned
is safe, because the member variable will live at least as long as the
temporary object returned now. It can also be more efficient, because
returning a ref can spare copying.

BUG=393155

Review URL: https://codereview.chromium.org/423483006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285691 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285690 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/f7be19401b4e718fab8bdb3b70fb54076bbb4259..d6aeb6dc8fe21066f1a2c4813a4256a3acd3edf5

CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_layout_rel
TBR=robertphillips@google.com
BUG=

Review URL: https://codereview.chromium.org/421653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285689 0039d316-1c4b-4281-b951-d872f2087c98

BUG=396319

Review URL: https://codereview.chromium.org/412003003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285688 0039d316-1c4b-4281-b951-d872f2087c98

BUG=395240

Review URL: https://codereview.chromium.org/395333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/399593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285686 0039d316-1c4b-4281-b951-d872f2087c98

Previously we were using real time for event timestamps.
Switch to using fake timestamps.

BUG=396387

Review URL: https://codereview.chromium.org/415043005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285685 0039d316-1c4b-4281-b951-d872f2087c98

BUG=372911

Review URL: https://codereview.chromium.org/290103005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285684 0039d316-1c4b-4281-b951-d872f2087c98

This is a fix for a regression introduced by CL 358183004. On desktop,
small avatar images should not be centered but stretched to fill the
entire available space of 180px x 180px.

BUG=214904, 241790
TEST=Manual

Review URL: https://codereview.chromium.org/396193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285683 0039d316-1c4b-4281-b951-d872f2087c98

It's confusing because it prevents the bubble activation. As a side effect on Windows the bubble doesn't get LBUTTON_DOWN messages. The reason for that is in HWNDMessageHandler::OnMouseActivate(). It asks the bubble if it can be activated. It answers "no" due to implementation in BubbleDelegateView::CanActivate(). Windows gets MA_NOACTIVATEANDEAT and MouseDown event isn't dispatched. This is definitely unexpected.
The bubbles which indeed always inactive should use set_can_activate(false) at construction time.
The bubbles which can be active but created without focus by default should use ShowInactive() instead.


BUG=392734

Review URL: https://codereview.chromium.org/413433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/420583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/419143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285680 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/413363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285679 0039d316-1c4b-4281-b951-d872f2087c98

BoringSSL does not support AES-192. No current consumer uses AES-192, so remove
the test which asserts it works. This fixes crypto_unittests in the Mac OpenSSL
port. Blacklist AES-192 in the NSS implementation so that we do not
accidentally grow a new dependency on it.

BUG=338885

Review URL: https://codereview.chromium.org/420883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285678 0039d316-1c4b-4281-b951-d872f2087c98

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3362
R=binji@chromium.org
TEST=local

Review URL: https://codereview.chromium.org/417323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285677 0039d316-1c4b-4281-b951-d872f2087c98

They were previously enabled in shared_library builds for historical reasons.

Turning them off makes things nice and consistent across all build types,
and helps the Windows Clang build, which currently doesn't support exceptions.

Previous attemps failed due to:

- mojo_public_environment_unittests unreachable code warning in
  DrMemory shared_library Release builds (crbug.com/397465)
  Fixed in Chromium r285674.

- chrome_elf_unittests on x64 (crbug.com/396244)
  Fixed in Chromium r285377.

- blink_platform_unittests:DateTimeFormatTest.CommonPattern et al.
  Fixed in Blink r176189

BUG=82385
TBR=thakis

Review URL: https://codereview.chromium.org/419973003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285676 0039d316-1c4b-4281-b951-d872f2087c98

Causes compile failures on official builders:
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/25600
http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/70014

FAILED: ninja -t msvc -e environment.x86 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\browser\profile_resetter\browser_0.automatic_profile_resetter.obj.rsp /c ..\..\chrome\browser\profile_resetter\automatic_profile_resetter.cc /Foobj\chrome\browser\profile_resetter\browser_0.automatic_profile_resetter.obj /Fdobj\chrome\browser_0.cc.pdb 
c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\profile_resetter\automatic_profile_resetter.cc(109) :error C2039: 'GetVariationParams' : is not a member of 'chrome_variations'
c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\profile_resetter\automatic_profile_resetter.cc(109) :error C3861: 'GetVariationParams': identifier not found
ninja: build stopped: subcommand failed.

FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/profile_resetter/browser.automatic_profile_resetter.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=209387 -DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_X11=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_ANDROID=0 -DNACL_TARGET_SUBARCH=64 -DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -DNACL_BUILD_ARCH=x86 -DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DUSE_BRLAPI -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DAUTOFILL_ENABLE_SYNC -DPASSWORD_MANAGER_ENABLE_SYNC '-DPRECACHE_CONFIG_SETTINGS_URL="http://www.gstatic.com/chrome/wifiprefetch/precache_config"' '-DPRECACHE_MANIFEST_URL_PREFIX="http://www.gstatic.com/chrome/wifiprefetch/precache_manifest_"' -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS -DLIBXML_STATIC '-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"' -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DWEBRTC_POSIX -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -DRLZ_NETWORK_IMPLEMENTATION_CHROME_NET -DUSE_NSS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -Iobj/chrome/browser.gen -Iobj/chrome/browser.gen/chrome -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/package/proto_gen -Igen/chrome -Igen/components/strings -I../../third_party/WebKit -I../../net/third_party/nss/ssl -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../third_party/webrtc/overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -I../../third_party/zlib -Igen/ui/resources -Igen/ui/strings -I../../third_party/re2 -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/libaddressinput/chromium/override -I../../third_party/libaddressinput/src/cpp/include -Igen/third_party/libaddressinput/ -I../../third_party/libyuv/include -I../../third_party/libyuv -I../../third_party/npapi -I../../third_party/npapi/bindings -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/webkit -Igen/policy -Igen/ui/chromeos/resources -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -Wexit-time-destructors -m64 -march=x86-64 -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11  -c ../../chrome/browser/profile_resetter/automatic_profile_resetter.cc -o obj/chrome/browser/profile_resetter/browser.automatic_profile_resetter.o
../../chrome/browser/profile_resetter/automatic_profile_resetter.cc:109:3:error: no member named 'GetVariationParams' in namespace 'chrome_variations'; did you mean 'variations::GetVariationParams'?
  chrome_variations::GetVariationParams(kAutomaticProfileResetStudyName,
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  variations::GetVariationParams
../../components/variations/variations_associated_data.h:110:6: note: 'variations::GetVariationParams' declared here
bool GetVariationParams(const std::string& trial_name,
     ^
1 error generated.
ninja: build stopped: subcommand failed.

> Move variations component code to variations namespace.
> 
> BUG=284540
> TBR=sky@chromium.org, mathp@chromium.org
> 
> Review URL: https://codereview.chromium.org/412943002

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/416333008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285675 0039d316-1c4b-4281-b951-d872f2087c98

The test would fail to compile (warning treated as error) in certain build
configurations (GYP_DEFINES=component=shared_library build_for_tool=drmemory,
with exceptions disabled).

Instead of having NotCalled() call abort(), which doesn't return, just use
a variable to check that the function doesn't get called.

BUG=397465
R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/419933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285674 0039d316-1c4b-4281-b951-d872f2087c98

Revert of mojo: fix little bug in DynamicServiceLoader/Runner (https://codereview.chromium.org/414173004/)

Reason for revert:

One of the test this adds fails on linux clang bog:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62568


Original issue's description:
> mojo: fix little bug in DynamicServiceLoader/Runner
> 
> If the Runner wasn't actually told to Start(), the DelegateSimpleThread would
> DCHECK for not having been Started. This patch makes it so we don't allocate
> a DST unless we need to.
> 
> Also adds basic unittest files for DynamicServiceLoader and Runner.
> 
> BUG=
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285650

TBR=darin@chromium.org,tim@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/419683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285673 0039d316-1c4b-4281-b951-d872f2087c98

The EME spec is now using ArrayBuffer/ArrayBufferView instead of
Uint8Array as the type for data buffers. Calls from JavaScript
aren't affected as Uint8Array is an ArrayBufferView. However,
"message" events now pass back an ArrayBuffer and the tests expect
Uint8Array. This converts the returned message to a Uint8Array
to keep the code working.

This change works with and without the upcoming changes. If
Uint8Array is passed back, then the result is that another copy of
the view is made.

BUG=358271
TEST=encrypted media browser_tests pass

Review URL: https://codereview.chromium.org/405733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285672 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285671 0039d316-1c4b-4281-b951-d872f2087c98