- 17 Jul, 2020 40 commits
-
-
François Degros authored
BUG=chromium:912236 TEST=browser_tests --gtest_filter="*/FilesApp*" Change-Id: I0ea62bb92376ab0ee68aef2a76ab9594c45cf341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303932Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#789382}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I589b5758f6a674c07decd4475504b814e7aefd5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789381}
-
Sven Zheng authored
Previously tryjob failed with: MBErr: Builder name "linux-lacros-rel" not found under masters[tryserver.chromium.linux] in "/b/s/w/ir/cache/builder/src/tools/mb/mb_config.pyl" Bug: 1104291 Change-Id: I1a4b1cb2a306a0d1562da1a0d4e712adfd852cab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304311 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#789380}
-
Karel Král authored
Refactor function ValueToString from the class base::trace_event::TracedValue into namespace base::trace_event. This is a follow-up of http://crrev.com/c/2299722 Bug: 1103623 Change-Id: Ied92ce36da432d84fef4b186f902c8ac581b416b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302029Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#789379}
-
Guillaume Jenkins authored
Moves the ReportGenerator class from chrome/browser to components/enterprise so it can be reused by iOS code. As part of this move, the ReportGenerator constructor now also uses the base ReportingDelegateFactory instead of the desktop-specific one. Bug: 1092425 Change-Id: I634f898486bcec349d81425b3b5714f7a2c34328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298229 Commit-Queue: Guillaume Jenkins <gujen@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789378}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I73d4b14fbcc444a0042ac8d21e52b6ea219cc584 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304195Reviewed-by:
-
Rob Buis authored
When setting host, empty/incorrect port strings should not change the existing port [1, 2]. This CL also applies the new behavior to setting URL port with empty/incorrect value, since the code paths for setting port and host+port are shared. Behavior matches Firefox. [1] https://url.spec.whatwg.org/#host-state Step 2.4 [2] https://url.spec.whatwg.org/#port-state Step 2.2 Change-Id: I2aa62c1acaa4bc9c0f17dbd2e82c2f2bad1ccedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300103Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Rob Buis <rbuis@igalia.com> Cr-Commit-Position: refs/heads/master@{#789376}
-
Eliot Courtney authored
The current implementation only allows two buffers in flight at a time. This is because a new buffer may only be submitted when an old one is released, and initially clients of WBMH only submit the initial buffer plus one more (because of the immediate ack of the initial buffer). Further, only submitting a new buffer when an old buffer is released means that latency variation in receiving release messages directly translates into increased latency in submitting the next buffer. Under load when running linux Chrome on ChromeOS, IPC shunting release messages back from viz=>exo=>ozone can have latencies in the low tens of milliseconds. If buffers are shown in a separate DRM plane (i.e. not copied) they must be held onto for the duration of scanout. This plus the IPC release latency causes visible performance degredation. Currently this latency cannot be absorbed by the buffer queue in linux Chrome. This change introduces an output queue in WBMH. Note that this does not change the semantics of OnSubmission and OnPresentation (acking). For this change to be useful, clients (e.g. GbmSurfacelessWayland) also need to have an output queue, which I will add in a follow-up CL. In order to provide the guarantees swap ack expects this CL also adds some logic for destroyed buffers and out of order releases. For linux Chrome on ChromeOS, surface sync logic in Viz (in ChromeOS chrome) can cause buffer releases to be re-ordered - the new logic handles this case. Bug: 1062529 Test: added unit tests Test: Run linux chrome on chromeos Test: Run ozone linux chrome on Weston, software and hw accel Change-Id: I3574248c92a8cf12207154052194c0e021d2984f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287334 Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#789375}
-
Meilin Wang authored
Bug: b/149246117 Test: unittest. Change-Id: I660ebe59f003b004dca13e19e60f51092528d961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275361 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789374}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d72cb4c076b7..65a88eb4bed0 2020-07-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 1b9b53a39576 to cb2938a1afd7 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I33b357ec6127493532bc93de4a5ccef4090e8c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304370Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I21855838e72a69c32857e09d67e754267e571e4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304369Reviewed-by:
-
Patti authored
This reverts commit cbf18954. Reason for revert: Suspecting this roll to be causing compile failures seen in https://bugs.chromium.org/p/chromium/issues/detail?id=1106623, will revert. Original change's description: > Roll SwiftShader from e8dd233c7a85 to 0e82586297a8 (4 revisions) > > https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 > > 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) > 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 > 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs > 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds > > If this roll has caused a breakage, revert this CL and stop the roller > using the controls here: > https://autoroll.skia.org/r/swiftshader-chromium-autoroll > Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human > is aware of the problem. > > To report a problem with the AutoRoller itself, please file a bug: > https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug > > Documentation for the AutoRoller is here: > https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 > Bug: None > Tbr: swiftshader-team+autoroll@google.com > Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169 > Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#789366} TBR=chromium-autoroll@skia-public.iam.gserviceaccount.com,swiftshader-team+autoroll@google.com Change-Id: I30ccd584ef929ccfd353f208fed4537d1d13f443 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302980Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#789371}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie0ed5ccb637c1e3f17ed54ef1face49db93ae974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304331Reviewed-by:
-
Daniel Libby authored
Get rid of some cpplint warnings in these files. R=bokan@chromium.org Change-Id: I49793a90c4341e728dcde65c9509727597a4d582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302713 Auto-Submit: Daniel Libby <dlibby@microsoft.com> Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#789369}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b15083559691..587380c5809d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC patricialor@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1025990,chromium:1092528,chromium:1101179,chromium:1101820,chromium:812428 Tbr: patricialor@google.com Change-Id: If875208936d3c27ae7c4fc2033fc2b0c02b9c77e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304141Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789368}
-
Noel Gordon authored
Patch 3 / 3: menu and submenu margin-top in files-ng is handled by menu JS files. These files-ng specific CSS rules are now unused: ditch them. Bug: 1066727 Change-Id: I1f64f5df9b5d336bfb5edc94acf7ac58a042a8cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301715 Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#789367}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e8dd233c7a85..0e82586297a8 2020-07-17 amaiorano@google.com Fix MacOS Chromium build (source_set dupe) 2020-07-16 amaiorano@google.com Fix MacOS (darwin) Chromium build on LLVM 10 2020-07-16 amaiorano@google.com Added Fuchsia support to LLVM 10 update script and updated configs 2020-07-16 amaiorano@google.com Use LLVM 10 instead of 7 for GN builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I74abe18089392ee45812ce6f2a66537aac6db4bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304169Reviewed-by:
-
Takashi Sakamoto authored
Bug: 1092288 Change-Id: Ib0102bd587f2947f591babe9e1deee4e50c8e6fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298786 Commit-Queue: Takashi Sakamoto <tasak@google.com> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789365}
-
Xianzhu Wang authored
When we paint selected text in vertical mode, we need to rotate the selection rect because we are under a rotation transform. Bug: 1106205 Change-Id: I148e2bf7a7b8e2e90a8d48f483d16a73d16200c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303878Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#789364}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I647e3bf28628e03138dad0419358d47bd81a76d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304329Reviewed-by:
-
Mansi Awasthi authored
This CL removes the creation of span of page objects for AddRemainingAnnotations() method in PdfAccessibilityTreeBuilder class. Change-Id: I6a70fa70c40503a92be26857cc88bbd7ecd0b7c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279424 Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#789362}
-
Noel Gordon authored
Patch 2 / 3: next in the code flow that shows a menu, we must position the menu using a getComputedStyle done internally by cu.ui positioning code. Just before that style recalc, set the menu's margin-top: 8px in inline style. The inline style overrides all CSS and all action-bar menu's of files- app have 8px margin-top as a result (to provide tap-target gap). Bug: 1066727 Change-Id: Ie6e7a651d8bb974dc71581d460e04debb60892c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301713 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Maggie Cai authored
To support sharing, we added action condition in the intent filter. However this will be inconsistent with the stored preferred apps (contains intent filters). This will cause filter matching issues when we try to modify or delete preferred apps entry. This CL adds the support to upgrade the preferred apps if the flag is on. BUG=1092784 AppServiceImplTest.PreferredAppsUpgrade. Test: Unit test PreferredAppsConverterTest.UpgradePreferredApp and Change-Id: Ib6fb3e4d6128b7c2f83a63cac73d800993a4b440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301549Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#789360}
-
Mingjing Zhang authored
This CL adds CompositorLatency.TotalLatency to replace the pipeline:* breakdowns that are to be removed in the benchmark report. Bug: 1078160 Change-Id: I22241a5903d3b122c3e92cc80a1a019e697444e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211918Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Mingjing Zhang <mjzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#789359}
-
Mohsen Izadi authored
In order to be able to compare new EventLatency metrics with existing LatencyInfo-based metrics (Event.Latency.*) for scroll events, we need to measure latency from when the event is created until when gpu-swap has started. Instead, we were incorrectly measuring that latency up to when gpu-swap has ended which is not what existing scroll latency metrics report. This CL deprecates incorrect metrics and replaces them with correct one. This CL changes both UMA and UKM metrics for this. The UKM privacy doc is updated: https://docs.google.com/document/d/1SDxdua997Gm7ihJFVjinHz9qTdBzTJrEzC7GEeQHs-8/edit# Bug: 1079116 Change-Id: I7900e3eca397f863fdba975a2ff7df66f5e08460 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2280423Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#789358}
-
Ben Mason authored
This is a noop since UseDownloadOfflineContentProvider is set as enabled in fieldtrial_testing_config.json, so useDownloadOfflineContentProvider() always returns true and exits the test immediately. Disabling the test to prevent test failure on release testers, where fieldtrial_testing_config.json is not used and causes this test to fail. If this test is needed, can it be fixed up and re-enabled. Bug: 1106460 Change-Id: I0986131275f490ec9e75b26790e9aaaa07f172ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303787Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#789357}
-
Mike Wasserman authored
This single bit exposes whether the device has multiple screens. It informs the value of permission prompts to request more information. This CL adds the IDL, IPC, implementation, and testing. Add a mojo struct for GetDisplays results; reject on failure. Test with the DevTools console (and multiple screens) with: chrome://flags#enable-experimental-web-platform-features Bug: 1098861, 1080710 Test: window.isMultiScreen() works as expected Change-Id: I5d5d86716f1910bfc4ddc5dc70faef252b831a31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278529Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Auto-Submit: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#789356}
-
Aleks Totic authored
Does not fix the layout, but it prevents the DCHECK. Prcentage padding can cause negative widths in Legacy table layout. With TablesNG shipping soon, it is not worth investigating root cause. This clamp just prevents the DCHECK, and is not going to make anything look worse. Bug: 1105900 Change-Id: Id68369dbb906fa62238c71f83b7b87ac3743917a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303564Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#789355}
-
Dylan Cutler authored
This allows us to instrument navigator.languages using this annotation for the identifiability study on which Chromium APIs leak information about users' cross-origin identity. Bug: 973801 Change-Id: I6d3fcf3b193ce34b799e2312172ee4c9e3908e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297683 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#789354}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3164b4494fba..d72cb4c076b7 2020-07-17 csmartdalton@google.com Mixed samples/conservative raster cleanups for tessellation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC nifong@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: nifong@google.com Change-Id: I1b043867b13add22d5a1df3dbbb3f047dcc07694 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304192Reviewed-by:
-
chrome://media-appTrent Apted authored
Previously it used a return value, but that caused increased coupling. Just move the updated file properties into the AbstractFile which can already represent what's needed. Bug: b/161108779 Change-Id: I6dc4d2e889b8c6d3247af00fa613a8c768f27171 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300901Reviewed-by:
Rachel Carpenter <carpenterr@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#789352}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ic4578505f7f368f2e4982208de94569de6c240d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304191Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I9e0980bb3d0e7f09e97ffb26fad4a37be279c53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303287Reviewed-by:
-
Nate Chapin authored
If PolicyGetter() is not initialized, it can be nullptr. This was regressed in https://chromium-review.googlesource.com/c/chromium/src/+/2293475, which removed a special-case in OriginTrialContext which declined to initialize the TrialTokenValidator if there was no PolicyGetter(). Now, we always create the TrialTokenValidator, but it will early-exit with status kNotSupported if the PolicyGetter() isn't available. Bug: 1106240 Change-Id: I4a1188e3866ba225b380c761bd444225c744b719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303560 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#789349}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c4c3be736312..df50009d3ede 2020-07-16 lalitm@google.com test: update diff testing script to Python3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ic7c5085e264bf9a900b7efe68553c222971ae183 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303867Reviewed-by:
-
Philip Rogers authored
The main idea in this change is to use the layerization algorithm from CompositeAfterPaint to create cc::Layers from the paint chunks within a GraphicsLayer. PaintLayer is a requirement for creating a GraphicsLayer, so this is the first use of the CompositeAfterPaint architecture to composite content without a PaintLayer or GraphicsLayer. This is limited to SVG subtrees by only doing this for SVGRoot GraphicsLayers, which are now created if SVG descendants have compositing reasons. This has been implemented behind an off-by-default runtime flag: CompositeSVG. Changes: * Will-change and animations set direct compositing reasons in SVG. This is used to build property trees that support compositing. * LayoutSVGRoot creates a PaintLayer. It is non-self-painting if there are no compositing descendants, and self-painting otherwise (to composite). This is needed because PaintLayer existence needs to be decided before subtree compositing reasons are known. Code has been added to maintain a bit on LayoutSVGRoot for whether there are composited descendants. * LayoutSVGRoot creates a GraphicsLayer if there are compositing descendants via LayoutSVGRoot::AdditionalCompositingReasons. This limits post-paint layerization to the subtree below SVGRoot. * PaintArtifactCompositor::LayerizeGroup looks inside GraphicsLayers and, if |ShouldCreateLayersAfterPaint()| is true, creates PendingLayers for each paint chunk with compositing reasons. * GraphicsLayers determine if they layerize after paint by looking for direct compositing reasons on chunks within the layer. This is cached. * GraphicsLayers that layerize after paint do not finish their paint controller until after PAC::Update, to ensure raster invalidation data is available in PAC::Update. Bug: 1101002 Change-Id: I029d4d6c39dd89dbfe8f04a9e192fe5dd499e9e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250514 Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#789347}
-
nohe@chromium.org authored
The read file and copy to clipboard method was moved to a public method so we can utilize this tool in other contexts. We want to implement this method in the files app so we can copy images in the files app directly to the system clipboard. BUG=827333 Change-Id: I11d1429f48b3a087ad7f5251b8ca44dd81c0c75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273298 Commit-Queue: Alexander Nohe <nohe@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#789346}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c15c6eb9d8c3..e8e089ad282e 2020-07-16 enga@chromium.org Add missing headers to BUILD.gn and CMakeLists.txt 2020-07-16 enga@chromium.org Validate 1D texture bindings cannot be multisampled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1104737 Tbr: cwallez@google.com Change-Id: Ie809450969837e05a6c4e46ad75d85f1a9f8983f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304132Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ia672fcc1b00bf20447673c3b4c206e0ec83e5af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303786Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789344}
-
Kent Tamura authored
This CL removes LayoutObject::IsLayoutButton(), which check if |this| is a LayoutButton, and adds LayoutObject::IsButtonOrNGButton(), which check if |this| is a LayoutButton or a LayoutNGButton. Also, this replaces existing callsites of IsLayoutButton() with IsButtonOrNGButton(). This CL has no behavior changes because LayoutNGButton is no used yet. Bug: 1040826 Change-Id: I92f052d50a6467ea2d1c86c4e75d3d68db8a75cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302975 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
