- 31 Jan, 2018 40 commits
-
-
Jialiu Lin authored
To help diagnose the broken referrer chain problem to extension inline install, we want to use Proto instead of JSON as the content format, such that we can easily add more info to the request. In addition, when referrer chain appears broken (completely empty, or missing some entries), we are going to append recent navigation events (quantity controlled by Finch) and send them for SBER/SCOUT users when they are not in incognito. Bug: 780532 Change-Id: I37ee0e6bf7a5e295640fca3eee86cb249595c7f5 Reviewed-on: https://chromium-review.googlesource.com/850726Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#533146}
-
Marijn Kruisselbrink authored
Change-Id: I169564f989c6e17d433ccf31c9b7d50ae2b3cad3 Reviewed-on: https://chromium-review.googlesource.com/889417Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533145}
-
Michael Martis authored
This is required to roll out the heuristic language model to 1% on stable. Bug: 762352 Change-Id: Iba29ae1e9335b38e853f46abd5e267f16705c786 Reviewed-on: https://chromium-review.googlesource.com/894743Reviewed-by:
-
Sandeep Vijayasekar authored
Bug: internal b/72704032 Test: File feedback from home app Change-Id: I38aa32a796344c42c38bb9b0820376109586b803 Reviewed-on: https://chromium-review.googlesource.com/894641 Commit-Queue: Sandeep Vijayasekar <sandv@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#533143}
-
Xiaocheng Hu authored
A previous CL (crrev.com/c/889643) made the function no longer use any instance of RenderedPosition. As a follow-up, this CL moves the function to VisibleUnits to join its doppelganger AbsoluteCaretBoundsOf(). Change-Id: If95cca29354ece16beb461774fab800dc9f37db0 Reviewed-on: https://chromium-review.googlesource.com/891583 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533142}
-
https://chromium.googlesource.com/catapult.git/+log/9fd18084bd44..7c98d04db58b $ git log 9fd18084b..7c98d04db --date=short --no-merges --format='%ad %ae %s' 2018-01-29 dtu [pinpoint] Stats page. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifae1b140b38e251ec87c1e578b575c3b0b6eefdb Reviewed-on: https://chromium-review.googlesource.com/894733Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533141}
-
Bret Sepulveda authored
This reverts commit e1c22cc3. Reason for revert: Compile failure on Windows https://ci.chromium.org/buildbot/chromium/Win%20x64/18699 Original change's description: > Move url_loader_unittest.cc and network_service_unittest.cc to services/network. > > Their content dependencies have been removed in previous changes. > > Bug: 753658 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo > Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62 > Reviewed-on: https://chromium-review.googlesource.com/893651 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533113} TBR=jam@chromium.org,rockot@chromium.org,tsepez@chromium.org Change-Id: Id179d007751f72c0813162ed0995232b033e74a0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/894710Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#533140}
-
dpapad authored
The entirety of Polymer, seems to have been included on iOS, for no good reason. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1bfb524c0efec710de91601123800801a15ceea1 Reviewed-on: https://chromium-review.googlesource.com/892122Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Dan Beam (no longer on Chrome) <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#533139}
-
https://skia.googlesource.com/skia.git/+log/51494f6615b8..ac568a934f8f $ git log 51494f661..ac568a934 --date=short --no-merges --format='%ad %ae %s' 2018-01-25 mtklein 1010102, 101010x, 888x in sw 2018-01-30 reed saturate some irect ops for fuzzers 2018-01-30 halcanary SkQP: fix upload/download scripts 2018-01-30 bsalomon Fix mock tex rt gpu mem size 2018-01-30 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 513bc77df..bd6ae4aa1 (1 commit) 2018-01-30 jvanverth Revert "Reduce the amount of padding needed for SDFs, take 2" Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I93cdd6392681b0a670aba84f2c260f4a08519c1b Reviewed-on: https://chromium-review.googlesource.com/894172Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533138}
-
Bruce Dawson authored
On about 3-4% of Chrome builds on my workstation one of the executables generated and then used during the build will crash. The binary on disk is always fine but the loader sometimes maps in pages of zeroes where it should be mapping in pages from the just-generated binary. Having a page of zeroes where you are expecting useful instructions tends to lead to crashes. This appears to be a bug in the OS disk cache. My suspicion is that this kernel bug only happens on multi-socket systems, but this is speculation. This bug happens regardless of which compiler or linker is used, and appears to happen on multiple Windows versions. The best reproes have been on Windows 10 Creators Update, or at least that is where I have done most of my testing. Extensive testing - hundreds of overnight builds - has shown that the problem goes away if FlushFileBuffers is called on the output file after linking is finished. Eventually this fix/hack will be coded into lld-link.exe, but for now it is put in tool_wrapper.py to fix the bug for both link.exe and lld-link.exe. Earlier versions of this fix only applied it to files with .exe extensions. However the bug is believed to have happened with DLLs, and may also affect .lib files created by the linkers, so now it is done always. The belief is that the performance impact will be negligible. Importing of win32file required some trickiness because in the context of ninja builds of Chrome the depot_tools python.bat file is apparently not called. This means that the python directory is not added to the system path. The python runtime correctly finds win32file.pyd and calls LoadLibrary on it but the OS then finds its dependencies in another version of python installed on the system and the DLL load fails if those are 64-bit instead of 32-bit. Bug: 644525 Change-Id: I71d63b47050385e2e5ba46ced9c8018220370ba7 Reviewed-on: https://chromium-review.googlesource.com/876683 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Zachary Turner <zturner@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#533137}
-
Aaron Leventhal authored
When tables exist, we apply a heuristic to determine whether they are used for layout or for data. Previously, we only exposed tables using table roles if it appeared to be used for data. However, some screen readers on some platforms wish to make this determination. For some platforms, expose the layout table as a table with a hint that it is used for layout. We can more easily change this for each platform going forward by simply changing the mapping of Role::kLayoutTable and kLayoutTable[Cell|Column|Row] For now: - Windows and ChromeOS -- treat layout tables as tables - Mac and Android -- treat layout tables as ordinary text containers. For Mac, we are following this convention until we determine that it would be desirable to be different from Safari and how we worked before. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9 Bug: 804880 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I9a8f59e2a2d62b6d2e65b8beae59bd923fea25d9 Reviewed-on: https://chromium-review.googlesource.com/879283Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#533136}
-
Evan Stade authored
it's not necessary after 7a379f73 Bug: none Change-Id: I0bb31204eafcd258ce42be06f6da3b300e8125de Reviewed-on: https://chromium-review.googlesource.com/889380Reviewed-by:
-
Jacob Dufault authored
Bug: 803700 Change-Id: Ie88645a2ec0244b6f5870fdb3187087e918e8855 Reviewed-on: https://chromium-review.googlesource.com/884561 Commit-Queue: Jacob Dufault <jdufault@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533134}
-
Alan Cutter authored
When PWA menu buttons are visible in the title bar we fail to animate the minimize button to the correct position when exiting tablet mode. This CL fixes the bug by removing the assumption that the minimize button is the left-most button and generalises the slide animation to all buttons left of the size button. Bug: 802144 Change-Id: I8ad560c966f9b0fa04beabcf6b96850fe784b5aa Reviewed-on: https://chromium-review.googlesource.com/892186 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#533133}
-
Bret Sepulveda authored
The test is timeout-flaky. TBR=rdevlin.cronin@chromium.org Bug: 807471 Change-Id: Ie70d0217c21ce9ed3ae1c1a79b6a030dd70886f5 Reviewed-on: https://chromium-review.googlesource.com/894736Reviewed-by:
-
https://chromium.googlesource.com/native_client/src/native_client.git/+log/7f07816e463d..476698afdd0b $ git log 7f07816e4..476698afd --date=short --no-merges --format='%ad %ae %s' 2018-01-09 shenghuazhang [ndk] Add android ndk deps in native_client/SConstruct 2017-10-12 tandrii Remove Rietveld CQ config. Created with: roll-dep src/native_client The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mseaborn@chromium.org Change-Id: I045e06e136ddd154a84cfd5e3500758fa7c0522b Reviewed-on: https://chromium-review.googlesource.com/894187 Commit-Queue: Mark Seaborn <mseaborn@chromium.org> Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533131}
-
Bill Budge authored
This reverts commit 39dfc337. Reason for revert: Switching V8 to use page_allocator is blocked on removal of RWX permissions on that side. Reverting this temporarily so we can switch V8 to page_allocator. Original change's description: > [page_allocator] Don't allow read/write/execute permissions. > > - V8 is moving to a read/write read/execute system. We won't need > read/write/execute and should remove it from Chrome now. > > Bug: chromium:756050 > Change-Id: Icc8a3ec334535c460e74a413cb265de2872db9f5 > Reviewed-on: https://chromium-review.googlesource.com/822514 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Bill Budge <bbudge@chromium.org> > Cr-Commit-Position: refs/heads/master@{#523663} TBR=palmer@chromium.org,bbudge@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:756050 Change-Id: I3fd2b0172822af0ce7e5cf003c53f0b6f69305e8 Reviewed-on: https://chromium-review.googlesource.com/893609Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#533130}
-
Jaebaek Seo authored
ContentViewCore::UpdateFrameInfo() must receive positions and sizes in CSS pixel except top_shown_pix. When --use-zoom-for-dsf is enabled, those values given to ContentViewCore::UpdateFrameInfo() are in physical pixel. It results in test failures of ContentViewScrollingTest#testOverScroll and ContentViewScrollingTest#testScrollTo. This CL scales down those values given to ContentViewCore::UpdateFrameInfo() by the device scale factor. TEST=run_content_shell_test_apk -f ContentViewScrollingTest#testOverScroll (and ContentViewScrollingTest#testScrollTo) on NEXUS 5X Bug: 737777 Change-Id: I95be3ed63d569ec9d620fa431c0d6bfa932410ba Reviewed-on: https://chromium-review.googlesource.com/888183 Commit-Queue: Jaebaek Seo <jaebaek@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#533129}
-
https://pdfium.googlesource.com/pdfium.git/+log/1917cdd8c90b..2334660053e0 $ git log 1917cdd8c..233466005 --date=short --no-merges --format='%ad %ae %s' 2018-01-30 npm Use unsigned for char width 2018-01-30 dsinclair Shuffle more code out of CXFA_Node 2018-01-30 dsinclair Move CheckButton code from CXFA_Node to CXFA_CheckButton 2018-01-30 rharrison Clean up CSS Data Table entries and access 2018-01-30 tsepez Remove bare new from JS_Define.h 2018-01-30 hnakashima Check if opj_image_data_alloc returned null. 2018-01-30 dsinclair Cleanup some param passing code 2018-01-30 hnakashima Guard usages of tellp(). It may return -1 in error cases. 2018-01-30 dsinclair Cleanup duplicate RunScript code 2018-01-30 thestig Remove not reachable branch in fxge code. 2018-01-30 thestig Use anonymous namespace in gdiplus code. 2018-01-30 dsinclair Cleanup some SDK code 2018-01-30 tsepez Revert "Revert "Use UnownedPtr instead of T* in MaybeOwned."" 2018-01-30 tsepez Revert "Use UnownedPtr instead of T* in MaybeOwned." 2018-01-30 tsepez Use UnownedPtr instead of T* in MaybeOwned. Created with: roll-dep src/third_party/pdfium BUG=807214,805881 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iccd05c3211b080fc7392a482d0c2be722c1ec683 Reviewed-on: https://chromium-review.googlesource.com/894482Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533128}
-
Jaebaek Seo authored
AndroidScrollIntegrationTest.testUiScrollReflectedInJs has a precision issue when enabling --use-zoom-for-dsf. It is the same problem with the one described in crrev.com/c/844266. In crrev.com/c/844266, I did not apply the same thing to AndroidScrollIntegrationTest.testUiScrollReflectedInJs as a mistake. Bug: 737777 Change-Id: I9474e8cf424ed2bf6b10578ab3c7ff7fbf8b6c4b Reviewed-on: https://chromium-review.googlesource.com/892782Reviewed-by:
-
Scott Violet authored
It's expected that the providers are available when the service is committed, so it make it explicit. BUG=none TEST=none Change-Id: Ibc2f9be6ecec9261e1a2b9ebef18b16557882398 Reviewed-on: https://chromium-review.googlesource.com/890722 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#533126}
-
Jaebaek Seo authored
Enabling --use-zoom-for-dsf scales parameters given to OverscrollControllerAndroid::OnOverscrolled() by the device scale factor. Accordingly, crrev.com/c/638510 updated values given to glow_effect_->OnOverscrolled(), but related unit tests (i.e., OverscrollBehaviorContainPreventsNavigation and OverscrollBehaviorNonePreventsNavigationAndGlow of OverscrollControllerAndroidUnitTest) are not updated correctly. This CL changes those unit tests and solve those unit tests' failures that occur when --use-zoom-for-dsf is enabled. Bug: 737777 Change-Id: Ia52fa1bef039fb234bd731ca1919cb850602a70f Reviewed-on: https://chromium-review.googlesource.com/890141Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/bd6ae4aa145d..199f42941ab5 $ git log bd6ae4aa1..199f42941 --date=short --no-merges --format='%ad %ae %s' 2018-01-19 ynovikov Vulkan: Enable on Android Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: I00a1e9aaf6d69b996744ab032adcdff68e0bf85f Reviewed-on: https://chromium-review.googlesource.com/894727Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#533124}
-
Maria Khomenko authored
This reverts commit e4c53ce3. Reason for revert: Breaks Marshmallow Tester bot: https://uberchromegw.corp.google.com/i/chromium.android/builders/Marshmallow%2064%20bit%20Tester/builds/19160 Original change's description: > [Android] Cleanup ExternalNavigationHandlerTest > > This CL: > - Replaces calls to > ExternalNavigationDelegateImpl#isSpecializedHandlerAvailable() with calls to > #countSpecializedHandlers() because #isSpecializedHandlerAvailable() has just > one caller > - Replaces ChromeBrowserTestRule with NativeLibraryTestRule > - Uses a mock context for both ContextUtils#getApplicationContext() and for > TabRedirectHandler instead of just for TabRedirectHandler > - Makes TestPackageManager#queryIntentActivities() and > TestExternalNavigationDelegate#queryIntentActivities() use same > implementation. > - Changes tests to register relevant http:// and https:// handlers at the > beginning of the test. This is a change of behavior. Previously, most URLs > would be handled by the "foo" external app > - Changes TestExternalNavigationDelegate#mQueryIntentOverride from tristate to > boolean. The "true behavior" was nuked but the "false behavior" was > preserved. > > BUG=None > > Change-Id: If212afde6e4c12d4f08576c4bd26392b8732bc09 > Reviewed-on: https://chromium-review.googlesource.com/891744 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Maria Khomenko <mariakhomenko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532970} TBR=mariakhomenko@chromium.org,pkotwicz@chromium.org,thildebr@chromium.org Change-Id: Ifb044a014ac4d94a74fffaf493cc3aad32b42ad5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: None Reviewed-on: https://chromium-review.googlesource.com/894684Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Maria Khomenko <mariakhomenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#533123}
-
Steven Holte authored
Change-Id: I73ed14280aa909fff24aae9a9bffc4fca330cb61 Reviewed-on: https://chromium-review.googlesource.com/894463 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Victor Costan authored
This reverts commit b05f99c3. Reason for revert: Crashes the Linux build -- 807487 Original change's description: > sqlite: Disable unused features via compile-time options. > > This CL shrinks the Linux binary by 34KB (138,266,816 to 138,232,320). > Code savings aside, this makes sure we don't unintentionally start > depending on these features. > > The following compile-time options are recommended in the SQLite > documentation [1]: > > * SQLITE_LIKE_DOESNT_MATCH_BLOBS - The LIKE and GLOB operators don't > work on BLOB columns. This access pattern would be a performance > wrench, so it's nice to fail hard here. > * SQLITE_OMIT_DEPRECATED - This removes support for deprecated SQLite > APIs. Note that SQLite promises to maintain indefinite backwards > compatbility for SQL queries (modulo features disabled via > compile-time options), so this only applies to the SQLite API. We > should never be using deprecated APIs. > * SQLITE_OMIT_PROGRESS_CALLBACK - Remove sqlite3_progress_handler(). We > don't use this feature, and the documentation says it comes with a > small performance penalty. > * SQLITE_OMIT_SHARED_CACHE - Using a shared cache sounds nice from a > memory consumption standpoint, and we already do that for LevelDB. > Unfortunately, Chromium's SQLite databases use a variety of page > sizes, which makes cache sharing impossible. > * SQLITE_USE_ALLOCA - Use alloca() instead of malloc() for allocating > temporary spaces in functions. All of Chrome's platforms support this > option, and it results in a slightly smaller binary and less heap churn. > > The following compile-time options disable features that happen not to > be used. > > * SQLITE_OMIT_AUTOINIT: We initialize SQLite manually in //sql/connection.cc. > * SQLITE_OMIT_AUTORESET: We calls sqlite3_reset() correctly to reset prepared > statements. > * SQLITE_OMIT_GET_TABLE: We don't use sqlite3_{get,free}_table(). > * SQLITE_OMIT_LOAD_EXTENSION: We don't use sqlite3_{enable_}load_extension(). > Asides from the code savings, there's a tiny security benefit to > knowing that extension loading code is definitely not reachable from WebSQL. > * SQLITE_OMIT_TCL_VARIABLE: We don't use TCL variables. > * SQLITE_OMIT_TRACE: We don't use sqlite3_{profile,trace}(). > > Bug: 807093 > Change-Id: Ie5e59e55dd9b2ed52f7c27682a809c9f7c36d4a3 > Reviewed-on: https://chromium-review.googlesource.com/882961 > Commit-Queue: Victor Costan <pwnall@chromium.org> > Reviewed-by: Chris Mumford <cmumford@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532995} TBR=cmumford@chromium.org,pwnall@chromium.org Change-Id: Ib49bee7c6c815cafa9eef211c5dd154cd4dd2a8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 807093 Reviewed-on: https://chromium-review.googlesource.com/894707Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#533121}
-
Yoshifumi Inoue authored
This patch changes "5032095.html" to utilize |selection_test()| for ease of maintenance. Note: Following patch will rename this file to "insert_html_at_end_of_paragraph.html". This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: Ie25f8ffc08c581a52ecab0ab7f3cb715f95021a6 Reviewed-on: https://chromium-review.googlesource.com/892552Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#533120}
-
Min Qin authored
These files are moved: download_danger_type.h download_save_info.h download_save_info.cc download_source.h We are gradually moving all download related files from content/ to components/download. This allows us to make download a standlone component, and finally making it a service under services/download BUG=803135 Change-Id: Id5be2a98beabd8bbd8be000a0fd1a36d633c6f7b Reviewed-on: https://chromium-review.googlesource.com/891686 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sergey Volk <servolk@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#533119}
-
Yoshifumi Inoue authored
This patch changes "smart-delete-across-editable-boundaries-2.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: If0c815668d80ebfed826f4efd5e4bf9a428a627e Reviewed-on: https://chromium-review.googlesource.com/892556Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "move-by-word-001.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I197c5cdf3ef6848855f8c2e4257f67cc7574874a Reviewed-on: https://chromium-review.googlesource.com/890882Reviewed-by:
-
Yoshifumi Inoue authored
Utilize GetSelectionTextInFlatTreeFromBody() in VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell This patch changes |VisibleSelectionTest.ExpandUsingGranularityWithEmptyCell| to use |GetSelectionTextInFlatTreeFromBody()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Change-Id: Id4212be8044fe05a15abd77d72fd8bf9524fa646 Reviewed-on: https://chromium-review.googlesource.com/892800Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "extend-by-word-001.html" to utilize |selection_test()| for ease of maintenance. This patch is a preparation for the patch[1]. [1] http://crrev.com/c/737981 Introduce TextOffsetMapping to simplify word/paragraph selection Bug: 679977 Change-Id: I5144d907927a936b5e7712d3fa404a2167b7e44d Reviewed-on: https://chromium-review.googlesource.com/892580Reviewed-by:
-
Eric Lawrence authored
2x printer PNG images were checked in without optimization, and contain metadata bloat. This CL removes the metadata and optimizes the compression. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica542a73e9735c06a444c1413175a36340a218aa Reviewed-on: https://chromium-review.googlesource.com/894264Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Eric Lawrence <elawrence@chromium.org> Cr-Commit-Position: refs/heads/master@{#533114}
-
John Abd-El-Malek authored
Their content dependencies have been removed in previous changes. Bug: 753658 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic632759ef35cfef4e707d29acdc361ae836e9b62 Reviewed-on: https://chromium-review.googlesource.com/893651 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#533113}
-
Karan Bhatia authored
The method PermissionsSet::HasScriptableAccessToURL is currently not being used. Remove it. Any access by clients should ideally be made through the PermissionsData class or through the PermissionsSet::scriptable_hosts() method. BUG=None Change-Id: I22ca956315bb19de8e19dcd00f33baed460dd610 Reviewed-on: https://chromium-review.googlesource.com/894170Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#533112}
-
Christopher Cameron authored
Move the logic for calling NSDisableScreenUpdates into BrowserCompositorView from RenderWidgetHostViewMac. This is needed because we no longer will be getting SubmitCompositorFrame in RWHVMac -- the new equivalent is BrowserCompositorMac::OnFirstSurfaceActivation. Simplify the logic of pausing during resize in RenderWidgetHostImpl and its interactions with RenderWidgetHostViewBase. R=sdy TBR=avi (content/) Change-Id: I5276abade510b16b0b2c583b915ab248b48e5446 Reviewed-on: https://chromium-review.googlesource.com/890220 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533111}
-
Michael Moss authored
This reverts commit 6d438d70. Reason for revert: Causing errors in release scripts which is blocking canary release. BUG: 807318 Original change's description: > Add variable to conditionally fetch ios_internal. > > Add variable checkout_ios_internal to conditionally fetch ios_internal. > Use pinned revision to ensure build stays hermetic and reproducible. > > Bug: 803846 > Change-Id: Id8ba650400b283645f8c00629dd269739d813195 > Reviewed-on: https://chromium-review.googlesource.com/880903 > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Reviewed-by: Michael Moss <mmoss@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532437} TBR=rohitrao@chromium.org,mmoss@chromium.org,dpranke@chromium.org,sdefresne@chromium.org,jbudorick@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 803846 Change-Id: I15afba5e030ccd58b80a78c60ad452657c89169a Reviewed-on: https://chromium-review.googlesource.com/894242Reviewed-by:
Michael Moss <mmoss@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#533110}
-
Tarun Bansal authored
Update the http-equiv and preload scanner code path as well. The client hints are provided only on secure contexts if ClientHintsPersistentEnabled() feature is enabled. Bug: 782381 Change-Id: I28d75b6bfd14f36accdba8f87488ae687df049d7 Reviewed-on: https://chromium-review.googlesource.com/887924 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
kylechar authored
There was a rule that let anything components/viz/service have a dependency on anything else. This wasn't intended. Invert that rule and explicitly allow DEPS where they should exist. Bug: none Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ida5c3f86487807b8ae2ad9bee01cdd8227b6ed9d Reviewed-on: https://chromium-review.googlesource.com/892101 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#533108}
-
bsheedy authored
Adds a Python script for automatically bisecting VR perf regressions. This is a temporary solution while we wait for automatic bisects on the perf dashboard to support devices outside of the Telemetry lab. This is only meant to run on a developer's workstation, not as part of any automatation/on bots/etc. Change-Id: I6887210cc2d83823c4a09efc9b5581578f5d1c7e Reviewed-on: https://chromium-review.googlesource.com/894283Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#533107}
-
