GitLab

This fixes an issue where Hindi increases ToolbarButton's height
resulting in oblong InkDrop shapes. It also increases the font size for
touchable Chrome which matches the larger shape of the toolbar better.

Bug: chromium:862514
Change-Id: I66cd2d7e06a27e6c03402e28679b55eaaaeaccf8
Reviewed-on: https://chromium-review.googlesource.com/1150960Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578385}

https://chromium.googlesource.com/catapult.git/+log/f07f60ef0baa..721613b08607


git log f07f60ef0baa..721613b08607 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 perezju@chromium.org [devil] Fix PRESUBMIT errors in devil
2018-07-26 anthonyalridge@google.com Graph Data API change
2018-07-26 perezju@chromium.org Fix PRESUBMIT errors in catapult/experimental


Created with:
  gclient setdep -r src/third_party/catapult@721613b08607

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:867809,chromium:866423,chromium:867844
TBR=sullivan@chromium.org

Change-Id: I5f2e7a10c7729efd3daacdf25ca68340f2ee5ed1
Reviewed-on: https://chromium-review.googlesource.com/1151547Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578384}

When adjusting the radio buttons, hightlights only update for symbols
and not for containers. This is now fixed.

Additionally, the dynamic inputs (byteunit and highlight) previously
did not disappear from the URL when set back to the default value. This
is now fixed.

The UI code has been cleaned up a little and more comments have been
added.

Bug: 867760
Change-Id: I6671b28939d73a32222a1b5f6dcaf18da8783e68
Reviewed-on: https://chromium-review.googlesource.com/1151622Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Commit-Queue: Tiger Oakes <tigero@google.com>
Cr-Commit-Position: refs/heads/master@{#578383}

This is a reland of 82d1bd2b

Original change's description:
> Rebaseline a virtual PiP test and unskip it
> 
> TBR=foolip
> 
> Bug: 866802
> Change-Id: I633708217593c5b132beb69eeb27f7e6caeeedc0
> Reviewed-on: https://chromium-review.googlesource.com/1150632
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578084}

Bug: 866802
Change-Id: Ib6b87fa99899ec0d974c417cb6e2362ddeabcb1b
Reviewed-on: https://chromium-review.googlesource.com/1151467
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578382}

This reverts commit e630f950.

Reason for revert: AdaptiveToolbarViewControllerTest.DetectForceTouch failing on ios-uirefresh-simulator

Bug: 868017

Original change's description:
> Add unit test for toolbars' force touch gestures
> 
> This CL adds a unit test for the force touch gesture recognizer added
> to the toolbar buttons, triggering the popup menu.
> 
> Bug: 864430
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Icc2524f7e8e58bf20fb4b1381913cb82c57206a8
> Reviewed-on: https://chromium-review.googlesource.com/1150142
> Reviewed-by: Mark Cogan <marq@chromium.org>
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578349}

TBR=marq@chromium.org,gambard@chromium.org

Change-Id: I7d4833a56c139ce501c673cd305c19efa456e1e0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 864430
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1151927Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578381}

This reverts commit 4480bf47.

Reason for revert: Strong suspect for causing crashes in WidgetTest.FullscreenFrameLayout on linux-chromeos-rel

Bug: 868004

Original change's description:
> OopAsh: improve immersive fullscreen for app windows
> 
> Immersive fullscreen for an app window almost works aside from the fact
> that the normal frame remains when the app window is fullscreened. This
> is a result of not updating the client area inset when the window show
> state changes (e.g. from restored to fullscreen). The client area is
> updated when the window bounds change, as they would when entering
> fullscreen, but the bounds change comes through just before the state
> change. Thus, when ClientSideNonClientFrameView checks fullscreen state
> during layout, it still finds the widget is restored and calculates the
> wrong bounds. The solution is to explicitly kick off a layout when
> entering or exiting fullscreen.
> 
>       after launching with --enable-features=Mash --ash-dev-shortcuts
> 
> Test: enter and exit fullscreen on an app window with ctrl+shift+F
> Bug: 640365
> Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f
> Reviewed-on: https://chromium-review.googlesource.com/1150618
> Reviewed-by: Scott Violet <sky@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#578353}

TBR=sky@chromium.org,estade@chromium.org

Change-Id: I2effa307fa2da94610130e6b084b6979fc4c070e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 640365
Reviewed-on: https://chromium-review.googlesource.com/1151908Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578380}

When we send a download ping, show the referrer chain so that problems
with the referrer chain logic can be debugged.

Bug: 865761
Change-Id: Id3f5dac4345b9cf179dee80417f99d94f3c3d7b0
Reviewed-on: https://chromium-review.googlesource.com/1150573Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578379}

Using e.g. URLs as hash split keys is not possible ATM. Change this by
deliberately not expanding the dictionary tree on settings split hashes.

Change-Id: Ifbc09aedd546f2f7e774807e091caa2069e1d0a6
Reviewed-on: https://chromium-review.googlesource.com/1144880
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578378}

@IntDef/@StringDef annotation are preferred way for declaring
set of String/int values.

1. they need less space in APK than enum, see
https://developer.android.com/topic/performance/reduce-apk-size#remove-enums
2. they give more control over allowed values than "static final" values

Main goal of patch is writing "static final" values, enum
and some classes in one common @IntDef/@StringDef form:

1. with @IntDef/@StringDef first, @Retention second
   and related @interface third
2. with values inside @interface
3. with NUM_ENTRIES declaring number of entries if necessary
4. with comment about numbering from 0 without gaps when necessary
5. with @Retention(RetentionPolicy.SOURCE)
6. without "static final" in the @interface

Change-Id: Ifa37fd39666c206bf727f97fbf1f5c2e2a277ac0
Reviewed-on: https://chromium-review.googlesource.com/1147522Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#578377}

This CL rejects cross-origin redirects in top-level scripts of
classic (dedicated | shared) workers in WorkerClassicScriptLoader,
to ensure that the response and request URLs of
a worker top-level script are same-origin in successful cases.

As most of cross-origin redirects should be already rejected
by loaders, this CL affects only cross-origin-redirected workers
created from an extension origin that has permissions and CSP
settings to access both the origins of the request and response URLs,
which I expect extremely rare.

This CL also adds browser_tests that cover such cases.

Bug: 861965, 861564
Change-Id: I80c27f9df550490384b5066b4b192d6415210b6d
Reviewed-on: https://chromium-review.googlesource.com/1135916Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578376}

The change is required for the sign-in after local save project. It will allow the save card icon to be able to animate and display text as part of feedback to the user that their card was saved.

This will also allow the password manager icon to be able to animate and display text as well.

Bug: 855186
Change-Id: I4e769a8b92f51a34d0feec10cdc77d508cd47b57
Reviewed-on: https://chromium-review.googlesource.com/1142439Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Manas Verma <manasverma@google.com>
Cr-Commit-Position: refs/heads/master@{#578375}

Working on PaintTouchActionRects, I found this is unused. Removing this
makes the code cleaner.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I762933aac6c937b8f7f617eb047fffbf4ddd3123
Reviewed-on: https://chromium-review.googlesource.com/1150829Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578374}

The symbol name returned by SymFromName may not contains a NUL character
when the symbol name is exactly the size of the buffer. It believe this
may also happen when the symbol name is too long and truncated.

The original code is based on:
  https://msdn.microsoft.com/en-us/library/windows/desktop/ms680580(v=vs.85).aspx

A right implementation can be found here:
  https://cs.chromium.org/chromium/src/base/debug/stack_trace_win.cc?l=145&rcl=f4ecb9e37e9e2d59e32b8b96f23ac4a1e33b9552

As described here:
  https://msdn.microsoft.com/en-us/library/windows/desktop/ms680686(v=vs.85).aspx

  NameLen
    The length of the name, in characters, not including the null-terminating character.
  MaxNameLen
    The size of the Name buffer, in characters. If this member is 0, the Name member is not used.

This issue was causing the catapult symbolisation script to encode incorrect (random) characters into the symbol names.
See the example in the bug.

Original BUG=713741

Review-Url: https://codereview.chromium.org/2832643004
Cr-Commit-Position: refs/heads/master@{#466098}

BUG=724399,b:70905156

Change-Id: Ia6de4ddbd5c66a966b74ecec3fda5e853f36073b
Reviewed-on: https://chromium-review.googlesource.com/1147669Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Gabriel Marin <gmx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578373}

Bug: 866556
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ie9977ebaa733e43d54fa6006e88adb3fce7cfb50
Reviewed-on: https://chromium-review.googlesource.com/1146882Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578372}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/3190ae3f2fd3..52660b68f115


git log 3190ae3f2fd3..52660b68f115 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 dgarrett@google.com prototype-firmwarebranch: Switch to standard firmware configs.


Created with:
  gclient setdep -r src/third_party/chromite@52660b68f115

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Iccb54945bbf3ad54309b17dc34dc4184dbe7c63a
Reviewed-on: https://chromium-review.googlesource.com/1151507Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578371}

https://webrtc.googlesource.com/src.git/+log/17aff35e1dea..e4db6a151806


git log 17aff35e1dea..e4db6a151806 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 peah@webrtc.org AEC3: Improved the accuracy of the adaptive filter
2018-07-26 buildbot@webrtc.org Roll chromium_revision 56d60694..96177551 (578186:578286)
2018-07-26 titovartem@webrtc.org Untangle fft third party lib from dependon WebRTC
2018-07-26 mbonadei@webrtc.org Enable clang::find_bad_constructs for congestion_controller/goog_cc.


Created with:
  gclient setdep -r src/third_party/webrtc@e4db6a151806

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:867873,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ifa388fe6b4bb81c65959a0729af3afa38081cad5
Reviewed-on: https://chromium-review.googlesource.com/1151549Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578370}

Before this CL, WebRtcEventLogManager was made aware of newly
loaded profiles (BrowserContext-s) through code that called it
from BrowserContext::Initialize. However, this runs before Prefs
are loaded. We therefore introduce a KeyedService that will
inform WebRtcEventLogManager of newly loaded BrowserContext-s;
this happens after Prefs are loaded.

Bug: 775415
Change-Id: I7a6beed0fda161784e2c8683793c387fa4734bda
Reviewed-on: https://chromium-review.googlesource.com/1150023
Commit-Queue: Elad Alon <eladalon@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578369}

This is populated for RemoteSuggestions.
The plan is to use this in offline_pages/ to fetch the suggested image URL,
instead of relying on ntp_snippets to fetch the URL.

Bug: 841522
Change-Id: I18ad866ec3b6ad39509df50421eef51a7a976380
Reviewed-on: https://chromium-review.googlesource.com/1147319Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578368}

Allow extension policy schemas to specify "sensitiveValue": true, which
hides the policy value from the chrome://policy UI, from policy exports
and from being sent as part of enterprise reporting.
The "sensitiveValue": true annotation can be placed on any level in the
schema declaration. An example extension storage schema may be:
{
  "type": "object",
  "properties": {
    "VisibleStringPolicy": {
      "type": "string"
    },
    "SensitiveStringPolicy": {
      "type": "string",
      "sensitiveValue": true
    },
    "VisibleDictPolicy": {
      "type": "object",
      "properties": {
        "some_bool": { "type": "boolean" },
        "some_string": { "type": "boolean" }
      }
    }
    "SensitiveDictPolicy": {
      "type": "object",
      "properties": {
        "some_bool": { "type": "boolean" },
        "some_string": { "type": "boolean" }
      },
      "sensitiveValue": true
    }
  }
}
In this case, the values of VisibleStringPolicy and VisibleDictPolicy
will be displayed on chrome://policy. The values of
SensitiveStringPolicy and SensitiveDictPolicy will be replaced with the
masking string "********"".

      browser_tests --gtest_filter=*PolicyUITest*

Test: components_unittests --gtest_filter=*Schema* && \
Bug: 849657
Change-Id: I07fc5f30945dccd05f5ccb8f8d071e25b4105c79
Reviewed-on: https://chromium-review.googlesource.com/1140301Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578367}

This test is flaky-timeout on ChromeOS (dbg) and Mac.

TBR=hajimehoshi@chromium.org

Bug: 867954
Change-Id: Ib376a16e40f0788bf527160f53dd9d02b950a184
Reviewed-on: https://chromium-review.googlesource.com/1151712Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578366}

Previously, BackgroundWith1PxBorder was used to draw the pill. We now use
a solid background and a RoundedRectBorder.

Bug: 840897
Change-Id: I19650f98dfff257ab770a37920174c5a36485ffb
Reviewed-on: https://chromium-review.googlesource.com/1148955Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578365}

If it fails in a trybot run, the "without patch" rerun will add the
gtest arg, which the test runner doesn't like:
https://chromium-swarm.appspot.com/task?id=3eecdd4cb9de5f10

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If3dbee3dc5e37589f8f143edfb935d1870f45c9b
Reviewed-on: https://chromium-review.googlesource.com/1150962
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578364}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2428efd5..c55015f7

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Icfdad279dad6d3d3d68063283c91ccee2ccc2b1b
Reviewed-on: https://chromium-review.googlesource.com/1151102Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578363}

There are two remaining Mac Fling tests which fail under Viz. Work is
ongoing to land a fix, but there was flakiness if the resolution.

This change updates the failing tests to exit early when it is Viz on
Mac. This will unblock removing our filter files.

TEST=BrowserSideFlingBrowserTest.TouchpadFling
BrowserSideFlingBrowserTest.TouchscreenFling

Bug: 842325
Change-Id: I67e7c6165d821c9df4907ebf8803fe22fbdf1663
Reviewed-on: https://chromium-review.googlesource.com/1151392Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578362}

Previously, optimize-baselines assumes all all-PASS testharness.js
results are the same, partly to avoid special-casing the implicit
all-PASS results. However, in scenarios demonstrated in
https://crbug.com/866802#c4, we do need to differentiate different
all-PASS results to allow us to update all-PASS baselines (that are kept
to prevent fallback).

This CL implements a ResultDigest class with special equality
comparitors which treat implicit all-PASS results specially (equal to
any all-PASS results). Thanks to the abstraction, the call sites are
still kept simple.

Bug: 866802
Change-Id: Ic6a361caa86f12598f29ad7693711d527f63006f
Reviewed-on: https://chromium-review.googlesource.com/1150629
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578361}

App list is always shown in homecher mode, so tapping on the app icon of
active window on shelf will not minimize the window due to a piece of
code. And this piece of code will not be reached in non-homecher mode,
since launcher window will get closed when it loses focus. So remove
that code.

Bug: 865156

Change-Id: Iec5c0df445d5ee5f379398069659ebe2f6dcd264
Reviewed-on: https://chromium-review.googlesource.com/1103151Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Weidong Guo <weidongg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578360}

This DCHECK is meant to assert that placeholder navigation never fails.
However, webView.URL may have reverted to the previous entry when a
failure happens so is not always the URL that triggers the error. The
correct approach is to check the error URL.

Bug: 864525
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4efb01041a39f87c4c1ac36115c93364bd41aff9
Reviewed-on: https://chromium-review.googlesource.com/1151391Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578359}

This patch adds metrics to record how many times the internal apps have
been shown in the launcher as search results and how many times they
have been clicked.

Bug: 843839
Test: can see numbers in histogram.
Change-Id: Ia68fc36dbbf9aadf8b067c8a012748d08fc96e60
Reviewed-on: https://chromium-review.googlesource.com/1141221Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578358}

This CL include following changes:
- Added method to LoginDatabase that deleted entries which fail decryption process on MacOS.
- Added tests for the above changes.
- Added method SetBackendLocked to OSCryptMocker to test behavior when Keychain on Mac is locked.

Change-Id: I2173467771457d32d2b2d953d4e27d888965e475
Bug: 791541
Reviewed-on: https://chromium-review.googlesource.com/1146642
Commit-Queue: Tonko Sabolčec <tsabolcec@google.com>
Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578357}

Cache the properties and apply them on commit on DRM Atomic. This works
around the need to waste a vsync interval to applying the atomic
properties.

BUG=839487
TEST=Ran unittests

Change-Id: I23a300d98648c5f7dff86019c8f8b9cb11129fb8
Reviewed-on: https://chromium-review.googlesource.com/1108561
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578356}

HandleAccessibilityRequestCallback crashes if the chromevox view does
not have an AXPlatformNodeDelegate. This fixes the crash by ignoring
views without delegates in that call.

Change-Id: Iadc20f60ed6c3b6c1f351628ab408ab283abe08f
Reviewed-on: https://chromium-review.googlesource.com/1150859
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578355}

This now matches behavior from before m68 (when we used
a different ICC parser that rejected these profiles).

In the longer term, I'd like to evaluate what Windows
is doing with these profiles (ignoring them, or white
point correcting them).

Bug: chromium:847024
Change-Id: I662ea9217423d5c9a922ba1735d9de627133de12
Reviewed-on: https://chromium-review.googlesource.com/1150677Reviewed-by: ccameron <ccameron@chromium.org>
Reviewed-by: Mike Klein <mtklein@chromium.org>
Commit-Queue: Brian Osman <brianosman@google.com>
Cr-Commit-Position: refs/heads/master@{#578354}

Immersive fullscreen for an app window almost works aside from the fact
that the normal frame remains when the app window is fullscreened. This
is a result of not updating the client area inset when the window show
state changes (e.g. from restored to fullscreen). The client area is
updated when the window bounds change, as they would when entering
fullscreen, but the bounds change comes through just before the state
change. Thus, when ClientSideNonClientFrameView checks fullscreen state
during layout, it still finds the widget is restored and calculates the
wrong bounds. The solution is to explicitly kick off a layout when
entering or exiting fullscreen.

      after launching with --enable-features=Mash --ash-dev-shortcuts

Test: enter and exit fullscreen on an app window with ctrl+shift+F
Bug: 640365
Change-Id: I499e29427ed072f3428de1f195ede1dc9892e71f
Reviewed-on: https://chromium-review.googlesource.com/1150618Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578353}

Adds `generate_milestone_report.py`, a script to generate milestone
reports then upload the results to GCS. A new page for selecting a
milestone was also created, which directs the user to Super Size with
a certain data_url set.

Bug: 847599
Change-Id: I718e14814b021c7810e94a0b95bf55e1ed381be6
Reviewed-on: https://chromium-review.googlesource.com/1150738
Commit-Queue: Tiger Oakes <tigero@google.com>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578352}

To make the Resource Percentage work easier, we are splitting the
snapshot controller into a foreground and a background version.

Bug: 699313
Change-Id: Ideeea7d644a903290d9eeae2d7ab700ab0ff50b6
Reviewed-on: https://chromium-review.googlesource.com/1136023Reviewed-by: Dmitry Titov <dimich@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Peter Williamson <petewil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578351}

https://pdfium.googlesource.com/pdfium.git/+log/893e730d5c4d..2daa06ab9596


git log 893e730d5c4d..2daa06ab9596 --date=short --no-merges --format='%ad %ae %s'
2018-07-26 hnakashima@chromium.org Remove font cache from CFGAS_DefaultFontManager.
2018-07-26 delphick@chromium.org Fix usage of deprecated V8 Value::ToString method


Created with:
  gclient setdep -r src/third_party/pdfium@2daa06ab9596

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I535a3a0ebed172aa240f25d09711265adb9799d1
Reviewed-on: https://chromium-review.googlesource.com/1151548Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578350}

This CL adds a unit test for the force touch gesture recognizer added
to the toolbar buttons, triggering the popup menu.

Bug: 864430
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Icc2524f7e8e58bf20fb4b1381913cb82c57206a8
Reviewed-on: https://chromium-review.googlesource.com/1150142Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578349}

This CL creates a bottom toolbar button slot that is used for the
first two buttons in the bottom toolbar (home/clear tab and search
accelerator). The

Change-Id: I6442d22498959c80b5cde8125550feb98c742dd9
Reviewed-on: https://chromium-review.googlesource.com/1139034Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578348}

This is a reland of 58e4a081

Original change's description:
> [ar] Do not refer to ARCore shim in APK merger
> 
> This hard-coding should no longer be required.
> 
> Bug: 839191
> Change-Id: Id44f0f19da6efcee90ef79ea3e241eb2a7ea5843
> Reviewed-on: https://chromium-review.googlesource.com/1147706
> Commit-Queue: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#577662}

Bug: 839191
Change-Id: I42c3d31c0cbe49c1fe2d68c55d0db18dcdc3381d
Reviewed-on: https://chromium-review.googlesource.com/1151567Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578347}

This is a reland of 43a48785

After [1], the RPATH is no longer set for sanitizer builds.  Also, after [2],
the setuid bit is no longer set on chrome_sandbox anyway.

[1] https://chromium.googlesource.com/chromium/src.git/+/f002a96e9b788fe71fd1c773a4bc891940c409d8
[2] https://chromium.googlesource.com/chromiumos/chromite.git/+/de3a6f421ec7e32c45fd4131f50d2c0a98fcdd56

Original change's description:
> Stop removing rpath_for_built_shared_libraries from chrome_sandbox
>
> For instrumented builds like tsan, this causes chrome_sandbox to reference the
> wrong libc++.so due to a missing RPATH.
>
> Since all configurations we ship don't set RPATH, we don't have to worry about
> security vulnerabilities introduced by RPATH=$ORIGIN.  There's also a check to
> enforce this in chrome/installer/linux/common/installer.include.
>
> BUG=850682
>
> Change-Id: I25307bd9de388009acffdbb8de6717210873655b
> Reviewed-on: https://chromium-review.googlesource.com/1092077
> Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566099}

Bug: 850682
Change-Id: I82fda0bd5b8f0222d64dcf6c4b7d1199c7e5e585
Reviewed-on: https://chromium-review.googlesource.com/1150254Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578346}