- 02 Dec, 2020 21 commits
-
-
Yoshifumi Inoue authored
This patch gets rid of |enum SelectionType| because most of usage can be replaced with |IsRange()| to simplify source code for improving code health. Change-Id: Ibe73e8a6b98767191e3dcc25beea9a02311a3dc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566317 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#832596}
-
Hidehiko Abe authored
Currently, some key combinations, such as CTRL+V, is sent twice from exo to wayland client via wl_keyboard::key and text_input::keysym. Because, currently Lacros converts both to KeyEvent, so in Lacros the KeyEvent is dispatched twice, which is unexpected behavior. The long term solution is not to dispatch KeyEvent converted from text_input::keysym in Lacros, and instead, call TextInputClient::InsertChar directly. However, this approach hits another issue. Currently, exo does not send wl_keyboard::key event, if the delivered KeyEvent is being consumed by IME. This is the workaround for ARC, and planned to be removed in the near future. So, to workaround consumed-by-ime filtering for the short term, this CL introduces another filtering into text_input::keysym with the reversed condition, so that, KeyEvent dispatching in Lacros will become once. BUG=1149371 TEST=Ran on DUT. Ran exo_unittests. Change-Id: I64314dda4838ae611e3643dc0e16eace9cc6fcd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567283Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#832595}
-
Hajime Hoshi authored
This reverts commit 72367c7a. Reason for revert: Caused test failures: crbug.com/1154484 Original change's description: > Fix frame generation timing > > Bug: 1150492 > > Change-Id: Ifd8e735f5682ffc6f09ebcddc22f43cbcd5300ce > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562158 > Reviewed-by: Robert Flack <flackr@chromium.org> > Commit-Queue: Mitsuru Oshima <oshima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#832534} TBR=flackr@chromium.org,oshima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ib7281c1c6f0230beb68dfbc596622d263d7841b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1150492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567020Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832594}
-
Tanya Gupta authored
Bug: 1142520 Change-Id: Ie584b49f19820c19f91a7b566f86fe6d3e1278f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566093Reviewed-by:
Kyle Milka <kmilka@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Tanya Gupta <tgupta@chromium.org> Cr-Commit-Position: refs/heads/master@{#832593}
-
Yue Li authored
Add metrics to measure how long the context menu has shown before the usre close it. Bug: b/173809124 Test: None Change-Id: Ieb28c43078ff7ea81f2d51823d84c0d5414eb38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567634 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#832592}
-
Noel Gordon authored
When Blink renders a JPEG that has EXIF orientation via new Image() it now reports the image width / height with the EXIF orientation applied for some JPEG images [1]. The FilesApp file list also examines the JPEG image metadata and works out it has EXIF orientation, and requests that EXIF orientation in the thumbnail request it sends to the image loader. That combined with the Blink change causes the image loader cropping/resizing code to produce an output image that has the EXIF orientation applied twice. Fix this: override the image loader request's orientation during image processing operations of JPEG images to use EXIF orientation 1 so that the image orientation is applied by Blink alone. Restore the request's orientation after the processing operations. [1] Observation in testing: not every JPEG the image loader deals with is affected. The bug seems to depend on how the JPEG image is served: • Load the JPEG image from a file-system URL (normal files app case) or from a window.createObjectURL (piex-wasm) and the bug occurs. • Load the JPEG image from dataURL and the bug does not occur so the must apply the request orientation in that case. Bug: 1152084 Change-Id: I478dcf756846bf9e67ee37fe2009319c2af3b79b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567071Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#832591}
-
Melissa Zhang authored
Opacity fade in when expand view is shown. 0 - 100% opacity 100ms linear curve. Bug: 1148692 Change-Id: Ib4477a7219e5a9823f476ce98de5caa1e5ce0c99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557942 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#832590}
-
Jacques Newman authored
Refactors NGGridLayoutAlgorithm to reduce member variable usage. This change should not have any functional changes. The helpers used in NGGridLayoutAlgorithm::Layout need to be used to help compute the min/max sizes, to do this they must be static or const. This refactor has an emphasis on moving data from the class to the stack whenever possible. This change also removes the state machine, as the added complexity was determined to not be needed. Bug: 1045599 Change-Id: I6af79bc2e3093ccfd33d8c6cb5cc6d46c2ed3698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542766 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#832589}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0c2cc2356170..986c7fb8caea 2020-12-01 johnstiles@google.com Fix codegen errors with Metal return statements. 2020-12-01 brianosman@google.com Add ByteCode output to skslc 2020-12-01 johnstiles@google.com Enforce layout(location=...) on Metal out variables. 2020-12-01 herb@google.com remove use of initial matrix 2020-12-01 johnstiles@google.com Disallow global variables containing arrays of opaque types. 2020-12-01 ethannicholas@google.com Created SKSL_USE_THREAD_LOCAL define If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: westont@google.com Change-Id: Ie10d6a9a6a150ac30a1bfa5c5b58962d9437301b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566789Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#832588}
-
Ken Rockot authored
This mojom struct was used to provide both a legacy InterfaceProvider as well as a BrowserInterfaceBroker to renderers. All renderer-side consumers of InterfaceProvider have been migrated to BrowserInterfaceBroker and DocumentScopedInterfaceBundle is now merely a wrapper around a BrowserInterfaceBroker endpoint. This CL removes it. Bug: 977637 Change-Id: I748243f2b0975e30dd7ee9272c2ebcaa2815c0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568163Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#832587}
-
Stephanie Kim authored
Bug: 1149606 Change-Id: I1e1c675a9098e2c11bbeb8fca9d3558a6da8f8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568361Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Stephanie Kim <kimstephanie@google.com> Cr-Commit-Position: refs/heads/master@{#832586}
-
Adam Langley authored
When isolated splits are enabled the default Context won't find the class inside the module. It's possible to use a different class loader but since this View needs custom setup anyway, it's easier to just handle it in code. This is currently moot because isolated splits are disabled for the cablev2_authenticator module, but will matter when that changes. BUG=1002262 Change-Id: I86477e9f980a3754f3bb2cf9e3ff360e4abaf293 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555584 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#832585}
-
danakj authored
Future mojoms should use BitmapN32, and we will convert existing users of BitmapWithArbitraryBpp over to BitmapN32 wherever possible - the difficulty of switching comes primarily due to the use of "Stable" on the skia.mojom.Bitmap mojom and the gfx.mojom.Image mojom. We will likely need to split off a non-stable Image type as well for non- ChromeOS-API uses. This suggests perhaps that all "Stable" mojoms should be independent from the non-stable mojoms used throughout Chromium. R=dcheng@chromium.org Bug: 1144462 Change-Id: I110139960fc231e8ad2f6b0864fbc6200079cb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560398 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Reviewed-by:
Darin Fisher <darin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832584}
-
John Palmer authored
BUG=1110772 Change-Id: I9c960eb923612a97b9e5b65ba45c7dc4ba26bddf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554741Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#832583}
-
Chris Blume authored
Certain devices were seeing whites turn yellow-ish and reported bugs. This reverts commit 236dcacc. Bug: 735658,1151495 Change-Id: I4f9c26026402b028b0eefdffc2b7c0e00b7c9317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566781 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#832582}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/684460d29eb4..80cea4f5fc66 2020-12-01 vapier@chromium.org repo: only warn if update_depot_tools does not exist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1148984 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: If01705d42808ea2af515b378db3faad1b931be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568171 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Kenneth Russell authored
GpuProcess_one_extra_workaround and GpuProcess_disabling_workarounds_works have become flaky there too. Bug: 1154088 Change-Id: Ic07468cd98aa59dc616a9fdde82b24eb2b6d7c8f Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568638Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#832580}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/494efc70ded6..8e0ff2457021 2020-12-01 tsepez@chromium.org Remove most remaining CFXJSE_Value from CFXJSE_FormCalcContext. 2020-12-01 tsepez@chromium.org Rework XFA_ResolveNodeRS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I1d588370983459cd4d345965a43d763608348e3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567748Reviewed-by:
-
Daniel Cheng authored
There are Android crashes where sending an orientation change event seems to encounter mutually exclusive facts: - WebLocalFrameImpl::GetFrame() should only return a non-null pointer if the LocalFrame is attached. - Furthermore, GetFrame() and GetFrame()->DomWindow() both return non-null pointers (though GetFrame()->DomWindow() returning non- null does *not* imply the frame is attached). - ScreenOrientationController is looked up as a a LocalDOMWindow supplement, using a non-null DomWindow(). - ScreenOrientationController is an ExecutionContextLifecycleObserver, and uses the DomWindow() helper to look up frames to iterate through. - DomWindow() should only return null once the associated LocalDOMWindow is detached - Yet DomWindow() returns null, contradicting WebLocalFrameImpl... Bug: 1154141 Change-Id: Id4e695a542c47dbd9263db6dcfc3718653bec242 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566884 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#832578}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/c3830d436c47..6f5151f6572b 2020-12-01 senorblanco@chromium.org Enable D* end-to-end tests on OpenGL ES backend. 2020-12-01 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from eac3c5bf5197 to 782f6a5e3e3c (50 revisions) 2020-12-01 senorblanco@chromium.org Disable some further C* end2end tests on GLES. 2020-12-01 senorblanco@chromium.org Enable most C* end-to-end tests on OpenGL ES. 2020-12-01 senorblanco@chromium.org Enable BufferTests on OpenGL ES. 2020-12-01 senorblanco@chromium.org Fix SSBO bindings in GLES backend. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Id874878d53e59d053c104574ba0f5d06e012256a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568385Reviewed-by:
-
Jason Lin authored
The camera notification/indicator is shown when PluginVM accesses camera now. Note that flags pluginvm-show-camera-permissions and vm-camera-mic-indicators-and-notifications need to be turned on. Bug: b/167491603 Change-Id: Ib2e3f7bc85531313811d2525ecac394aadee6e17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557122Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#832576}
-
- 01 Dec, 2020 19 commits
-
-
Moe Ahmadi authored
Previously only the realbox header text was unselectable. Making all text in realbox dropdown unselectable is more consistent with omnibox. Fixed: 1147142 Change-Id: Iade45c037e8e9208aba7ff0e708c985aa9ea97bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566505 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#832575}
-
Chris Lu authored
IOSLaunchedBySearchInChromeIntent is being logged instead of IOSOpenByMainIntent. This change fixes that. Bug: 1154422 Change-Id: If77133adeceb18296e7fbc1f284c13348923793d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568650 Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#832574}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Id8edcc9b08c5ea5245b4f1a369f4017a87cfe53e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568362Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#832573}
-
Yuheng Huang authored
This CL makes Tab Search shortcut (cmd+shift+A) available when the Tab Search feature flag is off. Bug: 1099917, 1153526 Change-Id: Ic5ba4e16cd458f4f0e5541a852435bd07ada610e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568151Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
-
Kenneth Russell authored
Unexpectedly started flaking badly recently on these platforms. Bug: 1154088 Change-Id: Ia232f78ca76cfa7ac6f1647b3773952ad768e5eb Tbr: rjkroege@chromium.org Tbr: zmo@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568368Reviewed-by:
-
zhiyuancai authored
Bug: 1146636 Change-Id: If26b394b21e60147f54494e5e7bfa9c897177f5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568510Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Cr-Commit-Position: refs/heads/master@{#832570}
-
Gang Wu authored
Experiment enabled on canary and dev https://critique-ng.corp.google.com/cl/338608966 This CL prepares for beta rollout Change-Id: I0a7d69da22d9cf74f224f1704ff4605a9fa030b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565830Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#832569}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/225d4f420c39..6035f4a5832a 2020-12-01 michael.liao@microsoft.com [Font Editor Prototype]: Implements Experimental Typography CSS Editor in Styles Pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1093229 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7f412403fead3ec040e0c85abed6732a55163084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566788Reviewed-by:
-
Lan Wei authored
The scroll-snap-type property should be set on <html> rather than <body>, because scroll-snap-type should not be propagated from body element to the viewport, we should use its value on html instead. Bug: 984438 Change-Id: I9b42289cc217ae3d9b4aafc69171a16087a24de0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568433Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#832567}
-
Mohamed Heikal authored
This is a reland of 30310919 Original change's description: > Update bundletools to version 1.4.0 > > Bug: 1151352 > Change-Id: I2a117e5f6cb3bf1b08f7f9f68cea7e4a893db6fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553852 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Commit-Queue: Peter Wen <wnwen@chromium.org> > Auto-Submit: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#830240} Bug: 1151352 Change-Id: Iee6b2dc1b263d5bf2cf28df46db8ca3bdb421f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568352 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#832566}
-
Nancy Wang authored
Create the full restore service when the profile is ready. The full restore service must be called before 'NotifyUserProfileLoaded', because NotifyUserProfileLoaded notifies the ash to prepare the virtual desk restoration. However, the virtual desk restoration should be decided by the full restore service. So full restore service must be created before NotifyUserProfileLoaded is called. There is a full restore flag to control the full restore service: https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/full_restore/full_restore_service_factory.cc;l=25 The flag is disabled currently, so before the feature is ready, no impact on the current implementation. PRD:go/cros-full-restore-prd Mock:go/cros-full-restore Design doc: go/chrome-os-full-restore-dd BUG=1146900 Change-Id: I21f68ce61166557eb24f69a2afbd8921fa091ebc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563192Reviewed-by:
-
David Van Cleve authored
We've now landed code that (1) Adds a generic //content-to-embedder API for requesting Trust Tokens issuance satisfied by on-device providers like system services (2) Expands the network service code responsible for the general Trust Tokens protocol flow to handle cases where issuance operations get delegated to on-device providers via NetworkContextClient This CL wires StoragePartitionImpl to bind a Mojo remote that can talk to the //content-to-embedder API (1), so that it can do something useful when it receives requests from the network service in step (2), rather than its current behavior of always failing the requests it receives. Test: Adds unit tests covering the new StoragePartitionImpl logic Change-Id: Iecd48e51ac827534fcac3073f0ce22bef4b2d8b4 Fixed: 1130273 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493540 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#832564}
-
Daniel Cheng authored
ConversionInternalsUI and ProcessInternalsUI don't need to be WebContentsObservers at all, since WebUIController already provides a RenderFrameCreated() override that is scoped WebUI-specific RenderFrameHosts. Bug: 1148682, 1149125 Change-Id: Iebef544d7fb7c8938d273c84279ce7e8b19f90a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566889Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#832563}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Ifd76ac2aaab9e222a2e2ac15b61612517261018c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566786Reviewed-by:
-
Ben Pastene authored
crrev.com/i/3440720 allocates the machines for these builders. Bug: 1140727 Change-Id: Idb58c124a30f9535dd4b4a75aa2a40c4b2a54a19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568166 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by:
-
Dave Tapuska authored
The test was accessing the device_scale_factor() on the LTH. device_scale_factor() will always be 1.0f when UseZoomForDSFEnabled is enabled and otherwise will match main_web_widget()->GetOriginalScreenInfo().device_scale_factor. Change to just use the original screen info device scale factor that doesn't change when DSF is enabled/disabled. BUG=1097816 Change-Id: I478efd19f39b9400d6e2165a67d3ede6ae463d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566071 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#832560}
-
Yury Khmel authored
This sends request to ARC Android to set dalvik memory params based on device's memory config. BUG=b:160760318 TEST=unit test added Locally on device, early tests show improvements in app loading and ARC boot time up to 5%. This feature is currently optional and is behind Chrome feature. Next data will be collected on real user using finch experiment and in-lab tests by adding separate testing variation for few reference boards that activates this feature. Change-Id: Iacb1a8c6ce874fe74152204a2e41a35bb2fa9da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560789 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:Yusuke Sato <yusukes@chromium.org> Auto-Submit: Yury Khmel <khmel@google.com> Cr-Commit-Position: refs/heads/master@{#832559}
-
Lukasz Anforowicz authored
Bug: 1150940 Change-Id: Iadb1260fa89c4b9d3693cc0fbc5dcad7aab47535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550343 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Id03a79fa1bdf2fd11d2d590bfcdba12a0e732eda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2565691 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Cr-Commit-Position: refs/heads/master@{#832557}
-
