GitLab

Revert of Fix crash when the source browser window is deleted during a drag (patchset #3 id:160001 of https://codereview.chromium.org/795303002/)

Reason for revert:
Since landing this, Linux ChromiumOS Ozone Tests (1) is failing three DND tests.

http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Ozone%20Tests%20%281%29/builds/7685/steps/interactive_ui_tests/logs/stdio

@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #1):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #2):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #3):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_LINE@DND@BookmarkBarViewTest5.DND (run #4):@@@
@@@STEP_LOG_LINE@DND@[ RUN      ] BookmarkBarViewTest5.DND@@@
@@@STEP_LOG_LINE@DND@@@@
@@@STEP_LOG_END@DND@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #1):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #2):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #3):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@BookmarkBarViewTest7.DNDToDifferentMenu (run #4):@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@[ RUN      ] BookmarkBarViewTest7.DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDToDifferentMenu@@@@
@@@STEP_LOG_END@DNDToDifferentMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #1):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #2):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #3):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@BookmarkBarViewTest8.DNDBackToOriginatingMenu (run #4):@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@[ RUN      ] BookmarkBarViewTest8.DNDBackToOriginatingMenu@@@
@@@STEP_LOG_LINE@DNDBackToOriginatingMenu@@@@
@@@STEP_LOG_END@DNDBackToOriginatingMenu@@@

Original issue's description:
> Fix crash when the source browser window is deleted during a drag
>
> This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
> the browser window is deleted during a drag-drop operation. An extension can
> delete the browser window during the drag-drop operation.
>
> BUG=440534
> TEST=BookmarkBarViewTest22.*
>
> Committed: https://crrev.com/460bdd69c6f96191a4293da61e9e4999acd0f5ff
> Cr-Commit-Position: refs/heads/master@{#309360}

TBR=sky@chromium.org,pkotwicz@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=440534

Review URL: https://codereview.chromium.org/818983002

Cr-Commit-Position: refs/heads/master@{#309367}

It's not feasible to reference ANGLE's test targets directly because
Chromium must use base's test launcher and ANGLE may not refer to it.

This new target and angle_unittests have been refactored in terms of
.gypi files provided by the ANGLE workspace, allowing both workspaces
to build these targets, though their main.cpp files differ.

BUG=435726

Review URL: https://codereview.chromium.org/807753002

Cr-Commit-Position: refs/heads/master@{#309366}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/aae274e..c0d2f9f

TBR=

Review URL: https://codereview.chromium.org/822573002

Cr-Commit-Position: refs/heads/master@{#309365}

This CL sets capture to the window being dragged when dragging a window on
Ash. This allows state to be reset when a user opens the Ctrl+Alt+Delete dialog
on Windows Ash.

As a side effect, this CL fixes dragging windows from one screen to another on
ChromeOS ozone. Dragging windows from one screen to another
worked on X11 because X11 does an implicit grab when the mouse is pressed. This
implicit grab guarantees that events are sent to WindowTreeHost where the drag
started for the duration of the drag.

BUG=439703, 423383
TEST=None

Review URL: https://codereview.chromium.org/778043004

Cr-Commit-Position: refs/heads/master@{#309364}

This patch removes cc uses of auto with smart pointers. This ensures
that it's explicit and clear what type of smart pointer is being
used.

I think it's better to do this now before this is used as a precedent
for propagating this type of auto use.

R=danakj

Review URL: https://codereview.chromium.org/816193002

Cr-Commit-Position: refs/heads/master@{#309363}

WebRTC 7927:7972
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f1982eb..c2c971d

Libjingle 7925:7972
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/642135c..1aaae71

TBR=kjellander@chromium.org

Review URL: https://codereview.chromium.org/815043004

Cr-Commit-Position: refs/heads/master@{#309362}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/637cec4..aae274e

TBR=

Review URL: https://codereview.chromium.org/817553003

Cr-Commit-Position: refs/heads/master@{#309361}

This CL makes Widget::RunShellDrag() and DesktopDragDropClientWin not crash if
the browser window is deleted during a drag-drop operation. An extension can
delete the browser window during the drag-drop operation.

BUG=440534
TEST=BookmarkBarViewTest22.*

Review URL: https://codereview.chromium.org/795303002

Cr-Commit-Position: refs/heads/master@{#309360}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/752e7eb..f53ff62

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/820883002

Cr-Commit-Position: refs/heads/master@{#309359}

BUG=3268

Review URL: https://codereview.chromium.org/802533005

Cr-Commit-Position: refs/heads/master@{#309358}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8be1d7e..637cec4

TBR=

Review URL: https://codereview.chromium.org/813073003

Cr-Commit-Position: refs/heads/master@{#309357}

Revert of Refactor Vaapi video decoder/encoder in preparation of Freon support (patchset #6 id:100001 of https://codereview.chromium.org/807853005/)

Reason for revert:
Caused build failure on Linux ChromiumOS GN:
ninja: error: '../../content/common/content/common/gpu/media/va_x11.sigs',
needed by 'obj/content/common/libva_generate_stubs.inputdeps.stamp', missing
and no known rule to make it

Original issue's description:
> Refactor Vaapi video decoder/encoder in preparation of Freon support
>
> This introduces VaapiPicture which abstracts the output picture for the VaapiVideoDecodeAccelerator.
> This also splits out the x11 specific functions of LibVA into their own signature file.
> And finally this adds back GLImageGLX to match the code path that will be used on Freon, using GLImageLinuxDMABuffer.
>
> BUG=403058
> TEST=video_decode_accelerator_unittest and video_encode_accelerator_unittest
>
> Committed: https://crrev.com/289e96375e75be0d9158b86df2bd4faf2d7b2a64
> Cr-Commit-Position: refs/heads/master@{#309355}

TBR=reveman@chromium.org,posciak@chromium.org,scherkus@chromium.org,piman@chromium.org,lionel.g.landwerlin@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=403058

Review URL: https://codereview.chromium.org/804353003

Cr-Commit-Position: refs/heads/master@{#309356}

This introduces VaapiPicture which abstracts the output picture for the VaapiVideoDecodeAccelerator.
This also splits out the x11 specific functions of LibVA into their own signature file.
And finally this adds back GLImageGLX to match the code path that will be used on Freon, using GLImageLinuxDMABuffer.

BUG=403058
TEST=video_decode_accelerator_unittest and video_encode_accelerator_unittest

Review URL: https://codereview.chromium.org/807853005

Cr-Commit-Position: refs/heads/master@{#309355}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb1af8d..752e7eb

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/821553002

Cr-Commit-Position: refs/heads/master@{#309354}

Adding the chrome://copresence page. Initially this will just have debug info, but soon we need to add some settings too.

BUG=420889

Review URL: https://codereview.chromium.org/734243003

Cr-Commit-Position: refs/heads/master@{#309353}

For faked key events from virtual keyboard, the character is set but dom key is not set. In such case, forcibly set the dom key to unidentified.

BUG=443889
TEST=Verified on link_freon & clapper devices.

Review URL: https://codereview.chromium.org/815773003

Cr-Commit-Position: refs/heads/master@{#309352}

ManagedTileState has mainly two RasterTask and DrawInfo classes.
When TileManager get DrawInfo from tile, it should get the state
through referencing ManagedTileState. this makes a redundancy
reference.

This patch removes ManagedTileState and makes DrawInfo to
separated files(tile_draw_info). In addition, a tile has raster_task.

Review URL: https://codereview.chromium.org/793573006

Cr-Commit-Position: refs/heads/master@{#309351}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/795253005

Cr-Commit-Position: refs/heads/master@{#309350}

R=erikwright@chromium.org
BUG=412384

Review URL: https://codereview.chromium.org/811483006

Cr-Commit-Position: refs/heads/master@{#309349}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/c14e556..bb1af8d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=bensong@google.com

Review URL: https://codereview.chromium.org/800693003

Cr-Commit-Position: refs/heads/master@{#309348}

This patch renames some perftests that better reflect the functionality
that they test.

R=danakj, enne

Review URL: https://codereview.chromium.org/816163002

Cr-Commit-Position: refs/heads/master@{#309347}

BUG=363365,423899
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/784403004

Cr-Commit-Position: refs/heads/master@{#309346}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ceee600..8be1d7e

TBR=jbroman@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/818893002

Cr-Commit-Position: refs/heads/master@{#309345}

Revert of Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e (patchset #2 id:20001 of https://codereview.chromium.org/815353002/)

Reason for revert:
Breaks compilation on Win8 GN:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win8%20GN&number=2381

Original issue's description:
> Roll pdfium to 59dffb68f07c7ce583285a23ad580b768ce3cd3e
>
> 59dffb6 Fix new third_party/BUILD.gn to use the right build config.
> 06b087a Set the freetype options missing in the recent update.
> b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade.
> a09d50d Transform font size to user space for valid text size comparison.
> e4fc5ce Update freetype to 2.5.4.
>
> BUG=407341,438441,444243
> TBR=tsepez@chromium.org
>
> Committed: https://crrev.com/43a66cb1bff61ab967d767160287c0d9129128b8
> Cr-Commit-Position: refs/heads/master@{#309342}

TBR=tsepez@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=407341,438441,444243

Review URL: https://codereview.chromium.org/821543002

Cr-Commit-Position: refs/heads/master@{#309344}

Cr-Commit-Position: refs/heads/master@{#309343}

59dffb6 Fix new third_party/BUILD.gn to use the right build config.
06b087a Set the freetype options missing in the recent update.
b3a3230 Add the license back to ftmodule.h after the freetype 2.5.4 upgrade.
a09d50d Transform font size to user space for valid text size comparison.
e4fc5ce Update freetype to 2.5.4.

BUG=407341,438441,444243
TBR=tsepez@chromium.org

Review URL: https://codereview.chromium.org/815353002

Cr-Commit-Position: refs/heads/master@{#309342}

BUG=338338
TEST=
R=jamesr@chromium.org,piman@chromium.org
TBR=torne@chromium.org

Review URL: https://codereview.chromium.org/810273004

Cr-Commit-Position: refs/heads/master@{#309341}

To enable memory.top_7_stress benchmark.

BUG=440305
TEST=tools/perf/run_benchmark memory.top_7_stress

Review URL: https://codereview.chromium.org/793983003

Cr-Commit-Position: refs/heads/master@{#309340}

Also, fix a bug in decorators.py where every element in |enabled_strings| except the first one is ignored.

BUG=443981
TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=${host} smoothness.tough_pinch_zoom_cases

Review URL: https://codereview.chromium.org/820433003

Cr-Commit-Position: refs/heads/master@{#309339}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f102ebf..ceee600

TBR=jbroman@chromium.org,haraken@chromium.org

Review URL: https://codereview.chromium.org/815343002

Cr-Commit-Position: refs/heads/master@{#309338}

measurements/tab_switching.py creates power.PowerMetric (which calls StartMonitoringPower() in __init__) in WillStartBrowser() where |browser| is still None.
SysfsPowerMonitor should not expect |browser| to be always valid.

With this change, tab_switching.top_10 can output power related values as the result.

BUG=443077, 433442
TEST=tools/perf/run_benchmark --browser=cros-chrome --remote=172.23.69.61 tab_switching.top_10

Review URL: https://codereview.chromium.org/818653002

Cr-Commit-Position: refs/heads/master@{#309337}

This rolls mesa to a version which contains the fix for 443074.

BUG=chromium:443074
R=kbr@chromium.org

Review URL: https://codereview.chromium.org/816083002

Cr-Commit-Position: refs/heads/master@{#309336}

Something about automatic tree vectorization breaks ReduceLarge(), so
disable the optimization for this function until we determine the real
fix.

BUG=439566

Review URL: https://codereview.chromium.org/814273004

Cr-Commit-Position: refs/heads/master@{#309335}

TBR=tommi@chromium.org

Review URL: https://codereview.chromium.org/822503002

Cr-Commit-Position: refs/heads/master@{#309334}

new component with a stub SyncableService, and its
corresponding factory. This SyncableService is plumbed
into sync iff "--enable-wifi-credential-sync" is present
in the command-line.

Also:
- add sync integration tests (single client, and two client)
- add WifiSecurityClass: an enum to provide an internal
  representation of WiFi security classes (e.g. WEP, PSK).
- add WifiCredential: an abstraction of the parameters
  required to find and connect to a WiFi network
- add conversions between ModelType and NotificationType,
  for WIFI_CREDENTIALS

BUG=chromium:426693
BUG=chromium:426696
BUG=chromium:427595
TEST=sync_integration_tests --gtest_filter="*Wifi*"
TEST=components_unittests --gtest_filter="Wifi*"

Review URL: https://codereview.chromium.org/709683004

Cr-Commit-Position: refs/heads/master@{#309333}

BUG=397019

Review URL: https://codereview.chromium.org/809603003

Cr-Commit-Position: refs/heads/master@{#309332}

Use new nomenclature (DevTools instead of Inspector), to match rest of Chromium.

BUG=423954,443897

Review URL: https://codereview.chromium.org/811263005

Cr-Commit-Position: refs/heads/master@{#309331}

TileTaskWorkerPoolPerfTests/TileTaskWorkerPoolPerfTest.ScheduleTasks/3 Failed
because GrContext was returning nullptr

BUG=

Review URL: https://codereview.chromium.org/807193005

Cr-Commit-Position: refs/heads/master@{#309330}

Gather information about the bitmap size, how much virtual memory is used, etc., and ensure it's in the minidump. This might help up narrow down the causes of being unable to allocate more shared memory.

BUG=429763

Review URL: https://codereview.chromium.org/822433003

Cr-Commit-Position: refs/heads/master@{#309329}

IDS_FLAGS_DISAMBIGUATE_SERVER_NAME_TYPES removed here: https://codereview.chromium.org/796993002
IDS_FLAGS_ALTERNATE_SHELF_LAYOUT removed here: https://codereview.chromium.org/229453005
IDS_FLAGS_DISABLE_APP_LIST_VOICE_SEARCH removed here:
https://codereview.chromium.org/353793003
IDS_FLAGS_DISABLE_LAYER_SQUASHING removed here:
https://codereview.chromium.org/785323002
IDS_FLAGS_ENABLE_SPDY_PROXY_AUTH removed here:
https://codereview.chromium.org/14398005/

BUG=none

Review URL: https://codereview.chromium.org/792033004

Cr-Commit-Position: refs/heads/master@{#309328}