GitLab

Keep bounds we are given instead of only keeping the size. Allows tests requiring this information to pass.
Create allow_null_view_token_for_test, which allows tests to create a view themselves.

Change-Id: Icab59c3d622537d5651c128a6c9572c667187338
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462241Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Chong Gu <chonggu@google.com>
Auto-Submit: Chong Gu <chonggu@google.com>
Cr-Commit-Position: refs/heads/master@{#820310}

macOS Big Sur lies about its version number to apps
built with SDKs earlier than the 11.0 SDK. We already
have code (daad98ce)
to undo that lie for version functions that return
numbers, but the version functions that return a
human-readable string were still lying.

Set SYSTEM_VERSION_COMPAT to fix the lie of that
string.

SYSTEM_VERSION_COMPAT alone is not adequate; it has
no effect on tests that do not share that Info.plist
and that we do not go through the trouble of giving
Info.plists because they are not bundled. But at
least for the Chromium app launched by Launch Services
we can improve system version number display.

Fixed: 1141569
Bug: 1108832
Change-Id: If064037bbb27ad42198bdebaf687e90e526e8751
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495266
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820309}

As of r820148 the PRESUBMIT is tripping on bogus grd files only
used for the purposes of testing. With the following error:

[Errno 2] No such file or directory: u'/../ui/webui/resources/tools/tests/foo_resources.grdp'

Fix by explicitly ignoring such grd files from the PRESUBMIT checks.

Bug: 1132403
Change-Id: I4a8b1f2b69c7bec6e26bf7a1a0790969d1b57bfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495320
Auto-Submit: dpapad <dpapad@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820308}

AbortClientNavigation() resets the navigation client message pipe, so it
is impossible to be in a state where the navigation client message pipe
is still connected but the commit should be ignored.

Unfortunately, this doesn't mean that the race previously fixed in
https://crbug.com/763106 is gone. It just means that the browser process
can send a CommitNavigation() that the renderer will never hear about
because the renderer's endpoint is already gone.

There is one tricky case with CommitNavigationWithParams(), which
previously also checked if the commit should be ignored. This method is
asynchronously called by MHTMLBodyLoaderClient when the MHTML archive
body is fully loaded. However, since MHTMLBodyLoaderClient is reset with
the same timing as the navigation client message pipe, this turns out
not to be a problem in practice.

Bug: 1020175
Change-Id: I3a8dc816030071a30f315ebc62a819ef3cde143a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493669
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820307}

DismissButton is only used within one file and the button instance is
set to always focusable. This CL moves the focus behavior setting
directly into the class so it is clearer that this kind of button should
be always focusable.

Bug: 1001103
Change-Id: I6d2f8c59815170b19da776b029ba474fde8c03f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493088Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820306}

This CL uses the fallback mechanism available for fast API calls in V8
for the WebGL methods bindTexture and bindBuffer, which are known to
check error conditions and throw JS exceptions in case of errors.

Bug: chromium:1052746
Change-Id: I8c2e8ce7e152977ec3ace0827a102eae73d4151b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465849Reviewed-by: Austin Eng <enga@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Maya Lekova <mslekova@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820305}

This changes mojo::Wrap/UnwrapPlatformFile to use
base::ScopedPlatformFile instead of raw PlatformFile values.

In the process, this fixes potential file descriptor leaks in
chromeos_camera code.

Fixed: 710376
Change-Id: Id86db91695bf3a6e87e210c2226739dbc9d8fa01
Tbr: lamzin@google.com
Tbr: drubery@chromium.org
Tbr: rakeshsoma@google.com
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491545Reviewed-by: Shik Chen <shik@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#820304}

Bug: 1047547
Change-Id: Ia3de37aad0f0a004a14bd9311f658d0b78ae22ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494780Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820303}

This CL is moving the libspeech synthesizer code to a worker thread.

This CL is splitting the logic in two parts. The first part is the
control logic which stay on the UI Thread. The second part is the
synthesizer logic which is running on a worker thread.

Bug: 869399, 1133813
Change-Id: I212f58ff94e5deac7950e206e4aac484d285f0f9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488045
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820302}

This addresses a bug where preview sticks around forever when there is
no internet connection and an offline version of the page is available.

We should remove the preview and display the offline version when one
is available.

Bug: 1141086
Change-Id: I3b4ca2481899c3dd8fea5a3cb46ee7da140d15bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490268Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820301}

https://skia.googlesource.com/skia.git/+log/58cf3fe83b93..15d8174fc944

2020-10-23 johnstiles@google.com Add unit test for self-referential initializer expressions.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC egdaniel@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Cq-Do-Not-Cancel-Tryjobs: true
Bug: None
Tbr: egdaniel@google.com
Change-Id: I8422d091ba31fbbe5d65cf03f6628b0f78b83ce6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495323Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820300}

Passphrase type is an important setting, that should be not downgraded
even in case of data corruption. This patch changes the behavior of
NigoriSyncBridgeImpl in a way it checks not only |encryption_keybag|
emptiness, but also that |passphrase_type| is the default one (i.e.
IMPLICIT_PASSPHRASE).

Bug: 1141410
Change-Id: I1329fc3cdb4d89b73b8620db8bf389d7dd38e00e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494810Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#820299}

asserting that a media type which is not understood is still kept in the
answer.

Bug: webrtc:3513
Change-Id: Ice96c09d7d1990dba677095fe882aab0fbe1a91d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2270180Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com>
Cr-Commit-Position: refs/heads/master@{#820298}

There is only 1 pre-render service per BrowserState which makes
the last created BVC the delegate for the the pre-render service
so when there are multiple windows, the last one created will provide
the webState to be replaced to the service and the service will use that
to get the navigation history which will be wrong in cases where the
prerendered webstate is not on the last created window.

As a work around pass the webstate to be replaced to the service

Bug: 1139286
Change-Id: I5a8651ba1c52ecf9e0a9d2ea0a3a18c1e0afdfc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486961Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820297}

When looping over transform animations in UpdateTransform, originally to
check whether they preserve axis alignment, we also check for box size
box size dependencies. If such dependencies are found, check whether the
relevant sizes have changed (using a current value stored in the
KeyframeEffect), and if so, restart the animation on the compositor
(note that RestartAnimationOnCompositor is a no-op if the animation is
not already composited).

This makes composited relative transform keyframes (implemented behind a
flag) fully working for CSS boxes, which could potentially be selectively
enabled ahead of doing so for SVG.

Design doc: https://docs.google.com/document/d/1zgr5CHRMpvlqodn1e0eM9J3MjL2eEMfAHrHsZUK7gMM/

Bug: 389359
Change-Id: I9b8189a3f3e002902b5eec58c08bb54644039536
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492893
Commit-Queue: George Steel <gtsteel@chromium.org>
Reviewed-by: Kevin Ellis <kevers@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820296}

Bug: 772945
Change-Id: Iacbc74f727e4535ea1289b0fc7fe8d326dfe6501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490083
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820295}

go/cros-scanning specifies that saved scanned images will use the
format scan_[local timestamp]_[page number].png. Update scan
service from the old format of scan_[local timestamp]_page_[page
number].png. Also update the unit tests to make sure the file is
being saved correctly.

Bug: b:171512776
Change-Id: I22141319e0d1db79ff9f82da73d671327e015f8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492926Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Paul Moy <pmoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820294}

This CL is fixing the errors while loading the tts_demo
in recent chrome version. The demo is no longer working
due to restriction with the sandbox policies.

see:
   https://stackoverflow.com/questions/36324333/refused-to-execute-inline-event-handler-because-it-violates-csp-sandbox

The previous JS code for the click/focus handlers were not
executed since they are inlined handlers.

Bug: 1133813
Change-Id: I2e6df706a1f43257a1a3e254ddb955fa000220a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490262
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820293}

Bug: 1131543
Change-Id: I5726d096eb6e18f25435c92b8ac26a01129d8564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493780Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820292}

The pointerevent' spec has properties e.g. width, height, pressure...,
so we are working on adding the pointerevent's properties to Webdriver
Action API to simulate the inputs from devices such as touchscreen and
stylus, which have these additional properties. This CL adds these
properties to ChromeDriver's ExecutePerformActions.

Bug: 1139172
Change-Id: Ic45f04d9e8c1d61a7f4e1fb867f701bf5c890af6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488551Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820291}

See recorded video at
https://drive.google.com/file/d/1hjHkN_gA7IMTTor6RehgF1mWMWkeLK9T/view?usp=sharing

This cl doesn't include all the elements in system tray menu, more
elements of it will be updated in follow up cls.

Bug: 1131543
Change-Id: I3a395e529764ab4e23a51ea5066e3e105a502552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2486781Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820290}

The GPU info and config code has platform-specific bits which makes them
impossible to use when Ozone is enabled.  Platform-specific code must be
in the platform.

However, for the code in //gpu/config moving it down to platform code is
problematic because of internal non-trivial types used in the component.
For instance, gpu::GpuExtraInfo has some attributes defined only for X11
that should be handled at the platform level.  However, currently giving
it to the platform requires the platform to depend on //gpu/config which
creates a dependency cycle.

Here the gpu::GpuExtraInfo class is extracted into its own component, so
external code can now use it.

Bug: 1121945
Change-Id: I4ad166b43313d7e33e8e9f80e147a29b6eef5d88
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478362Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Alexander Dunaev <adunaev@igalia.com>
Cr-Commit-Position: refs/heads/master@{#820289}

Bug: 1140474
Change-Id: I264270edec37ffa425a1525af5a95a9e53009310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495005Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820288}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/afdo-chromium-autoroll
Please CC gbiv@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: gbiv@chromium.org
Change-Id: I3f8d3048ec07cdba7c0501454d09115322a32c23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495044Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820287}

Angle_perftests are now removed from perf waterfall on crrev/c/2491525. Now resharding to avoid empty shard on #0.

Bug: chromium:1137628
Change-Id: I6fcc31c6689b1c6cbaf011a1f3bd9970d2ba092e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493146
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Wenbin Zhang <wenbinzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#820286}

Chrome uses fibers to increase the size of its main thread's stack and
this was found to cause shutdown crashes in some cases, deep inside
msctf.dll and coremessage.dll. It turns out that avoiding these is as
simple as deleting the fibers before quitting.

There is still concern that these crashes were being missed, and it may
be time to start exiting with TerminateProcess (which also solves the
problem) but that is for another day.

Aside: the proper cleanup functions for ConvertThreadToFiberEx and
CreateFiberEx are not documented on MSDN and it is not obvious that they
actually use different cleanup functions. The official examples don't
bother cleaning up, but luckily this sample does:

https://devblogs.microsoft.com/oldnewthing/20200602-00/?p=103819

Testing showed that it was the ::DeleteFiber call which was needed to
avoid the shutdown crash, but both cleanup function calls were retained.

Bug: 981238, 1141408
Change-Id: Ifb3d4dc4d0ea8728e203e654c53f105fca615c02
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493664
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820285}

Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202010230700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/lEAXOymZqKYZxc3n_eeo68wecdG1sO1D9u__3SE-mwoC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll
Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: help-app@grotations.appspotmail.com
Change-Id: I6f6728d9fe195cf208103b1451eac5e5d9203f37
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495380Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820284}

Background: DevTools currently isn't able to inspect callsite
stacks for requests intercepted by a Service Worker. This change
adds a new parameter to the Request object to pass stack context
between the origin and Service Worker process to facilitate this.

Previously we added a request header to carry the stack id (without
enabling this feature). But that approach has issues with CORS
policies and may expose internal state to Javascript (e.g. via the
Headers object).

There was an existing test for the CDP method that covers the code
paths.

See updated explainer: https://tinyurl.com/y3zpcfdz

A frontend WIP link is here:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2466642

Change-Id: I71a39c87a0b3784fba7120833e0acf5e6675cb2e
Bug: crbug.com/1137299
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465285Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Brandon Maslen <brandm@microsoft.com>
Commit-Queue: Songtao Xia <soxia@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#820283}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0fef99f5c756..4504e3a3591f

2020-10-23 alexrudenko@chromium.org Show icons explaining flexbox-direction:row in Styles panel
2020-10-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-10-23 pfaffe@chromium.org TypeScriptify SourcesPanel

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1139945
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I7ab7bc09d0c48cfbfbab18aed50a6de268eaecb0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495322Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820282}

Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010230700_RC00.html

https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/PVqqlXYdmSiJgm_qMo5UaTJkdZ1YRuKTAypy1hRbjpsC

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll
Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: media-app@grotations.appspotmail.com
Change-Id: I21074669594bf3e9ab17ef4310c4f95b70ad7019
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495360Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820281}

Fleet has been upgraded to Win10 1909, so this is a no-op that removes
no-longer-needed exception.

Bug: 1124829
Change-Id: I86aa7c4d85aa9bd57238f891a82dfc14ee43be4c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493099Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#820280}

The test is flaky on Android bots and has been failing
recently on the "Marshmallow 64 bit Tester" bot in
particular.

BUG=1141870
TBR=horo@chromium.org

Change-Id: I82d73ac8c57595485047d6c8eb2a91195b155bcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495144Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820279}

This CL explictly makes uses of Regular profile in the tests as
OfflinePageBridge is null for OTR profiles and it's already tested in
OfflinePageBridgeTest

Bug: 1060940
Change-Id: If215f7ea0beee9a1c5d7cdb20863a8df321dc6c3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494860Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820278}

External paths aren't absolute paths, and thus need to be treated
differently. Actually blocking paths (like the root of the Downloads
directory) seems to have been broken already, so for now this just
allows all external paths. We should add special chrome-os logic to
block what we do want to block in a follow-up.

Bug: 1009970, 1134029
Change-Id: I8e5e437698b619d9df643706119c8b3492f58476
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2442901Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820277}

Bug: 1060940
Change-Id: I523009ba4a6d9ad6d257b9b2bc0e6b3061b379cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494724Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820276}

Fixes unintended behavior of clicking on ImageView not opening the dialog. The intended behavior is for a click anywhere in the preference row to open the dialog, for local consistency in preference behavior.

Bug: 1141799
Change-Id: I23b35c492819bec28f690f9f87d7ec4fddf68f7f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495321
Commit-Queue: Jordan Oroshiba <oroshiba@google.com>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Auto-Submit: Jordan Oroshiba <oroshiba@google.com>
Cr-Commit-Position: refs/heads/master@{#820275}

from c808aa3d15a42648d8b25a838024813990959e37

Change-Id: Ibec6a32fc4994773b728214ce9c1ab944dd00e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495242
Commit-Queue: Robert Ma <robertma@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Auto-Submit: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820274}

Currently it is not easy to test the supersize viewer without uploading
a dev version to the production site. Add option to
upload_html_viewer.py to host locally. Also adds a staging option
because WFH and local development don't mix so well.

Change-Id: Ieb79a47ba836898cf9da28805ce3c6a9a3e208a3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485781
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820273}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: I36a30aea10b4522a144328eedf1a6347ea47cd40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495324Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#820272}

This change adds two new histograms for tracking the availability of
manual translate from menus on both desktop (context menu) and mobile
platforms (app menu).
The first logs whether or not manual translation is available on the
current page. This replaces the existing
Translate.MobileMenuTranslate.Shown metric, which served a similar
purpose but was mobile-specific.
The second histogram logs all the reasons why manual translate is not
available in such an event. This metric will be used to investigate the
prevalence of these reasons, and leverage it to make the menu translate
feature more visible to users.

Logging is done from the shared TranslateManager::CanManuallyTranslate
through a flag. Logging is done once per menu open.

Bug: 1127094
Change-Id: Iddc46cc3e80d29a2cc8d757414fe9b74888ef02b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2468796
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Megan Jablonski <megjablon@chromium.org>
Reviewed-by: Scott Little <sclittle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820271}