GitLab

DownloadTests have been updated to manifest v2.
Remove the allowance for manifest v1 extensions.

Bug: 816679
Change-Id: If536e7da72deb5934305bf0a68b011b6b55582d5
Reviewed-on: https://chromium-review.googlesource.com/1026070Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553616}

Bug: skia:7794
Change-Id: I0d54fe15df6faed64bb057c3e74ebbeffc212616
Reviewed-on: https://chromium-review.googlesource.com/1027904Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Brian Salomon <bsalomon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553615}

This CL implements image manager, which is on top of FeedImageDatabase.
FeedImageManager will take request for images, check if the image is
cached in disk or not, if not, FeedImageManager will try to download
the image and cache it. FeedImageManager also does the garbage
collection for images not used recently.

Bug:807360

Change-Id: Id2f572abd72a2dc29dfa30e2573dc200715a4714
Reviewed-on: https://chromium-review.googlesource.com/1014461
Commit-Queue: Gang Wu <gangwu@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553614}

In db110f78, IDC_EXIT was changed to be
handled by Chrome instead of Ash. This reverts that change.

Originally, I thought Chrome would have to register the IDC_EXIT command
so that menus would show that shortcut in the relevant row. However,
the Exit command isn't shown in the Chrome OS app menu so it should be
fine to skip registering it completely and let Ash handle it.

Also verified that ctrl+shift+q is still treated as reserved, i.e. cannot
be eaten by a webpage. This site is useful for manually testing that:
  http://unixpapa.com/js/testkey.html


Bug: 834092
Change-Id: Ie6de31a0efa36da0f67def3ba7a5124b6c527bd3
Reviewed-on: https://chromium-review.googlesource.com/1024876
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553613}

Bug: 799482
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4b1a7da98378bc349986e92bfc1df845b655b0fc
Reviewed-on: https://chromium-review.googlesource.com/1025045Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553612}

-This CL re-introduces the ClearBrowsingData modal presentation from HistoryCoordinator
via HistoryTableVC.

-Creates a new displayPrivacySettings localDispatcher command.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia62f7f491b39e49c7d90bffb8bf42504ff343a13
Reviewed-on: https://chromium-review.googlesource.com/1026873Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553611}

https://webrtc.googlesource.com/src.git/+log/09408115cda7..ff61273c010c

$ git log 09408115c..ff61273c0 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc
BUG=chromium:836790,chromium:None,chromium:836729,chromium:None


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Icfa9b26e7de7db99d2c8f985b198097bb7805e49
Reviewed-on: https://chromium-review.googlesource.com/1028222Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553610}

The background color of a new tab is set to the root background
color of the old tab (https://codereview.chromium.org/2737553004/).
Prior to my change, the root background color will be auto
corrected to the correct color by receiving the next CompositorFrame
(UpdateBackgroundColor is called in SubmitCompositorFrame).
However, after my change, since no new render frame metadata is
created by switching tabs, the new tab will be set with root
background color of the old tab. When we open another new tab,
the same color will carry to the new tab creation.

I have worked on rewriting the background color setting logic,
https://docs.google.com/document/d/1GLJzDVYuOsnTjysYAnCDWxUFofvxDBHtqTgYE60sEC8

I believe the complete fix requires more testing before merging to M67,
so I reverted SetRootBackgroundColor related logics in this CL.

Bug:830540

Change-Id: I6f9efaa580f4cac67b2aa3493cdcc093b92076f5
Reviewed-on: https://chromium-review.googlesource.com/1027208Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Yi Xu <yiyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553609}

This will be implemented if necessary

Bug: b/73383411
Test: local build
Change-Id: I895c9e58e301a94d9814cb4f95247dd8e0131469
Reviewed-on: https://chromium-review.googlesource.com/1026465Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Albert Chaulk <achaulk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553608}

With this change we will stop using *1234 to obsfucate the card
number when we show a suggestion, for example, on a name field.
We can simply use ****1234 in all places instead.

The change applies to both the new and the deprecated dropdown.

Bug: 768881
Change-Id: Ic17c28f668dc0bed42f220d474a72924f02c7ad5
Reviewed-on: https://chromium-review.googlesource.com/1026213
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553607}

this cl changes:
- Move ash::prefs::kDockedMagnifierEnabled registration to chrome to
  avoid ShouldShowAccessibilityMenu() crash.

original changes:
The plan is to make MagnificationManager a class to make mojo calls to
ash for FullscreenMagnifier or DockedMagnifier when
- Focus changed in page.
- Corresponding feature is enabled.
This CL removes DockedMagnifierClient and merges it into
MagnificationManager.

TBR=dcheng@chromium.org

Bug: 817157, 831258
Test: existing tests and played on device working fine.
Change-Id: Ie8346291f03cc50b1b2580489413c3e45f6e38c8
Reviewed-on: https://chromium-review.googlesource.com/1018823
Commit-Queue: Qiang Xu <warx@google.com>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#552583}
Reviewed-on: https://chromium-review.googlesource.com/1027080Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#553606}

Make the iOS implementation more similar to other platforms by sending
FormFieldData.is_autofilled to the JS in order to avoid filling fields that
are not autofilled (e.g., <select> elements with default values in hidden
sections).

With this change, there is no need for checking to see if the element's
value has changed in order to mark the element as autofilled. There are
cases where the element's value doesn't change but it must be marked as
autofilled, e.g., a <select> element for credit card expiry month whose
default value is 'January' where the expiry month of the credit card used
for autofill is also January.

This CL avoids sending autofill data for fields with empty values to the JS
side since they're already ignored in JS.

Bug: 827108
Change-Id: If68d25cfa86eedd1467cd766fa55e7560048e660
Reviewed-on: https://chromium-review.googlesource.com/1026513
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553605}

This test needs the not-yet-implemented fullscreen behavior described
in the linked bug.

TBR=rdevlin.cronin@chromium.org

Bug: 836327
Change-Id: Id383aa9e5092cf707119f1940978965027479853
Reviewed-on: https://chromium-review.googlesource.com/1028176Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553604}

Restores the arc app notification badging on shelf icons by re-wiring
ArcNotificationManager get app id code path through mojo.

- Change ArcNotificationManager to handle get app id asynchronously;
- Add GetArcAppIdByPackageName to AshMessageCenterClient mojo interface;
- ArcNotificationManager use the mojo call to get app id;

Bug: 768439
Change-Id: I199636b374d539677d93e35be1fd4f7b9b900bca
Reviewed-on: https://chromium-review.googlesource.com/1012123Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553603}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

TBR=xdai@chromium.org

Bug: 825327
Change-Id: I25abbbca04c9753f602fa6c9d654f797aecd13bb
Reviewed-on: https://chromium-review.googlesource.com/1024294Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553602}

This reverts commit 34aec165.

Reason for revert: Reverted the wrong CL.

Original change's description:
> Revert "Reland "Remove ".dd" extension from VR icons""
> 
> This reverts commit 2aea307c.
> 
> Reason for revert: Introduces syntax error in build/android/gyp/compile_resources.py
> 
> Original change's description:
> > Reland "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit 14ebddd2.
> > 
> > Reason for revert: Fixing regex.
> > 
> > Original change's description:
> > > Revert "Remove ".dd" extension from VR icons"
> > > 
> > > This reverts commit c00fe466.
> > > 
> > > Reason for revert: Breaks canary push
> > > 
> > > Original change's description:
> > > > Remove ".dd" extension from VR icons
> > > > 
> > > > Bug: 834499
> > > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#552773}
> > > 
> > > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > > 
> > > NOTRY=true
> > > 
> > > Bug: 834499
> > > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553577}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 834499
> > Reviewed-on: https://chromium-review.googlesource.com/1028095
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553578}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I59661b7afd876e22e61455e766fdb7094ca5667e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028096
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553599}

TBR=ellyjones@chromium.org,mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I310cf29d1a60eb23de841faf0dd092961af017b6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028373Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553601}

This reverts commit bf799ef8.

Reason for revert:
Breaks CrSettingsIncompatibleApplicationsPageTest test in official builds.

Google internal failing bot:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/83282

Externally visible Clang ToT official bot:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1359

Original change's description:
> WebUI MD Refresh: Update paper-button styling up to spec.
> 
>  - Move some styles from shared_style_css.html to paper_button_style_css.html.
>  - Update paper-button styles per latest spec.
>  - Collapse previously different types of buttons "primary" and "action" into a
>    single button type.
> 
> Note this change is intentionally changing the shared styling for buttons. If a
> certain WebUI page needs a different pre-MD refresh style, should be updated
> individually to override (hopefully there are no such cases though).
> 
> Bug: 832173
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I8558db8ffd121ad09b100f8ba6ab4d843022f73f
> Reviewed-on: https://chromium-review.googlesource.com/1013330
> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
> Reviewed-by: Scott Chen <scottchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553382}

TBR=dpapad@chromium.org,scottchen@chromium.org

Change-Id: I0489c01e20af79b61db0e9ce1fdc2f292c178c98
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 832173
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028371Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553600}

This reverts commit 2aea307c.

Reason for revert: Introduces syntax error in build/android/gyp/compile_resources.py

Original change's description:
> Reland "Remove ".dd" extension from VR icons"
> 
> This reverts commit 14ebddd2.
> 
> Reason for revert: Fixing regex.
> 
> Original change's description:
> > Revert "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit c00fe466.
> > 
> > Reason for revert: Breaks canary push
> > 
> > Original change's description:
> > > Remove ".dd" extension from VR icons
> > > 
> > > Bug: 834499
> > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#552773}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > NOTRY=true
> > 
> > Bug: 834499
> > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553577}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028095
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553578}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I59661b7afd876e22e61455e766fdb7094ca5667e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028096Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553599}

This reverts commit c4a6b926.

Reason for revert: Fixing bad merge...

Original change's description:
> Revert "Reland "Remove ".dd" extension from VR icons""
> 
> This reverts commit 2aea307c.
> 
> Reason for revert: Bad merge. No idea how that happened.
> 
> Original change's description:
> > Reland "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit 14ebddd2.
> > 
> > Reason for revert: Fixing regex.
> > 
> > Original change's description:
> > > Revert "Remove ".dd" extension from VR icons"
> > > 
> > > This reverts commit c00fe466.
> > > 
> > > Reason for revert: Breaks canary push
> > > 
> > > Original change's description:
> > > > Remove ".dd" extension from VR icons
> > > > 
> > > > Bug: 834499
> > > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#552773}
> > > 
> > > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > > 
> > > NOTRY=true
> > > 
> > > Bug: 834499
> > > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#553577}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 834499
> > Reviewed-on: https://chromium-review.googlesource.com/1028095
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553578}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I41383360a58384fae4498e79dd637c755d24a424
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028370
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553597}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: Id1accbf1f59a27afc03d16e1b2b29789c5b5df63
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028332
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553598}

This reverts commit 2aea307c.

Reason for revert: Bad merge. No idea how that happened.

Original change's description:
> Reland "Remove ".dd" extension from VR icons"
> 
> This reverts commit 14ebddd2.
> 
> Reason for revert: Fixing regex.
> 
> Original change's description:
> > Revert "Remove ".dd" extension from VR icons"
> > 
> > This reverts commit c00fe466.
> > 
> > Reason for revert: Breaks canary push
> > 
> > Original change's description:
> > > Remove ".dd" extension from VR icons
> > > 
> > > Bug: 834499
> > > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > > Reviewed-by: Richard Coles <torne@chromium.org>
> > > Reviewed-by: agrieve <agrieve@chromium.org>
> > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#552773}
> > 
> > TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> > 
> > NOTRY=true
> > 
> > Bug: 834499
> > Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> > Reviewed-on: https://chromium-review.googlesource.com/1028092
> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#553577}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 834499
> Reviewed-on: https://chromium-review.googlesource.com/1028095
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553578}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I41383360a58384fae4498e79dd637c755d24a424
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028370Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553597}

This reverts commit e8acf697.

Reason for revert: Tests do not pass in official build configuration.

Google internal official bot link:
https://uberchromegw.corp.google.com/i/official.desktop.continuous/builders/win%20trunk/builds/83286

Externally visible clang ToT bot configured the same way:
https://ci.chromium.org/buildbot/chromium.clang/ToTWin64/1359

Original change's description:
> Print Preview Componentization: Migrate preview area error tests
> 
> Migrate some tests for errors that appear in the Preview Area:
> - No PDF plugin
> - Invalid Settings
> - Bad cloud print certificate
> 
> Bug: 814860
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: Ia87708ef2bc326d794b3be0f6aa9adeb87e5a3c2
> Reviewed-on: https://chromium-review.googlesource.com/1015850
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553416}

TBR=dpapad@chromium.org,rbpotter@chromium.org

Change-Id: I1431bd7e9c3bf612ecb979893b1ea1914134c7ad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 814860
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1028331Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553596}

std::ptr_fun and std::bind2nd are deprecated in C++11, and removed in
C++17. This CL removes their usage, so that the code base is ready for
C++17.

Bug: 752720
Change-Id: I5a33143768a32864367f6889c4d1dbd0a26ee9e2
Reviewed-on: https://chromium-review.googlesource.com/1025541Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553595}

Change-Id: I2333926b6d37544a535c6683078fd4f22f75aad9
Reviewed-on: https://chromium-review.googlesource.com/1017008
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553594}

These changes were scripted as part of the effort to restrict exposure of the
raw MessageLoop*.

Note that many static methods exposed on MessageLoopCurrent are also deprecated
so it is very well possible that this is migrating to an already deprecated
method.

The goal of this pass is to reduce usage of MessageLoop::current() (and
ultimately make it impossible to obtain the MessageLoop* statically).

As such I will not edit this CL unless the script did something logically wrong.
I defer to owners to fix highlighted usage of already deprecated APIs.

Possible script screw ups / things to look out for in this review:
 - Storing MessageLoopCurrent in a MessageLoop* variable or comparing it against
   one (I will go over that in a separate pass).

Includes should have been stripped if that was the last usage of message_loop.h
in that file.

Please CQ if LGTY

This CL was uploaded by git cl split.

R=mnissler@chromium.org

Bug: 825327
Change-Id: If841fcb08116a6b73fe0af84c94dd4f17ac9c290
Reviewed-on: https://chromium-review.googlesource.com/1024492
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Mattias Nissler <mnissler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553593}

BUG=693090
TBR=zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I882da7cb607592a58d9a022f5af656cb45278c2a
Reviewed-on: https://chromium-review.googlesource.com/1028171
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553592}

In the test case in 835713, the page calls context.resume()
twice. Once on load and once on a user gesture.  The first call to
resume has a promise pending that gets resolved when the second
promise is resolved when the context is finally allowed to start.

As part of the resolution of the promise, the context state is set to
"running", which happens in the first promise.  The second promise
does this again.  But SetContextState checks for valid state
transitions, and running->running isn't one of them.  However, if the
state isn't changing, there's nothing that needs to be done, so
SetContextStae can return early.

Bug: 835713
Test: repro case no longer DCHECKs
Change-Id: Iccfc88ce1caedc3cdf7cdfcf3e8ed4a84d4010e4
Reviewed-on: https://chromium-review.googlesource.com/1026082Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553591}

This CL hooks up the OmniboxView to the OmniboxClient, which retrieves
the favicon for the default search provider from the FaviconService.

The implementation below is a good start but there needs to be further
work in these two areas:

 a) Our coverage is currently limited to what FaviconService can
    provide us, but that is not adequate. Most search engine favicons
    are never populated into the FaviconService database. See bug
    88243.

 b) We need an in-memory synchronous cache to avoid hits to the sqlite
    Favicons database on every keystroke.

This CL works for search engines with a populated favicon. For example,
visiting search.yahoo.com, and then switching the default search
provider to Yahoo will work.

Bug: 823535
Change-Id: Ie4e4425d9cfa59f971bc3264c1b79104d1e5d958
Reviewed-on: https://chromium-review.googlesource.com/1026695Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553590}

Bug: 832981
Change-Id: I3711f0f03306a74b9a062f388beb2f3915eecb91
Reviewed-on: https://chromium-review.googlesource.com/1024969
Commit-Queue: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553589}

Before this CL, SetupSync would early-out if skip_passphrase_verification
was set to true. I don't see a good reason for this, so now it always gets
called.
For reference, this logic was added in
https://codereview.chromium.org/2716413003/, but I couldn't find an
explanation for it there.

This is an attempt to fix Sync's E2E tests. Locally, it fixes some of them,
though others still fail.
The problem was that a ClearServerData task got scheduled in
SyncSchedulerImpl, but then before that task actually got a chance to run,
the scheduler was put back into CONFIGURATION mode via
SyncBackendHostImpl::ConfigureDataTypes (race condition). This change makes
sure that ConfigureDataTypes (and its async tasks) gets completed before
we try to clear server data.
More details on the failure can be found on the bug.

Bug: 835250
Change-Id: I392376d23930540ce9442911ec16e00a42abf043
Reviewed-on: https://chromium-review.googlesource.com/1028050Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553588}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2875ae01..9990de59

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I0d62089410f323a98ce721bb95b3f18f244dc060
Reviewed-on: https://chromium-review.googlesource.com/1027794Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553587}

Zoom factors are double, but the code is using uint32_t to process them.
This patch fixes it.

Output on wayland info client:
OUTPUT0:

  connection:          internal
  device scale factor: 1.000

  geometry:
    x:                 2
    y:                 24
    physical width:    443 mm
    physical height:   264 mm
    subpixel:          unknown
    make:              unknown
    model:             unknown
    transform:         normal

  modes:
    1676x998:          60.00 Hz      current       preferred

  scales:
    0.500:
    0.750:
    1.000:             current       preferred
    1.250:
    1.500:
    1.750:
    2.000:
    2.250:
    2.500:

Bug: 836782
Change-Id: Id67582a637a67a608ae096a5fac992e8215aa47e
Component: Wayland, aura shell, scales
Reviewed-on: https://chromium-review.googlesource.com/1028217Reviewed-by: David Reveman <reveman@chromium.org>
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553586}

Extensions can register service workers from URLs like
chrome-extension://blahblahblah/sw.js. To load such URLs we must
use ExtensionURLLoaderFactory instead of the NetworkService.

This patch allows extension service workers to be registered.
But it doesn't yet allow subresource requests to fallback to
the ExtensionURLLoaderFactory.

This enables 41 of 49 failing browser tests.

Bug: 836129
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I21f513d892a813ba41c2414a7f0734d1d46898b2
Reviewed-on: https://chromium-review.googlesource.com/1025674
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553585}

Fixed menu widths turned out not to work well in locales with longer
strings. This change changes the menu widths to be minimums instead.
See screenshots attached to the bug for examples.

Bug: 832239
Change-Id: I4cae9efb53b86b08c4cd8b56d4eb089446e872d9
Reviewed-on: https://chromium-review.googlesource.com/1026052
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553584}

- Migrates deleteSelectedItemsFromHistory from the legacyImplementation.
- Deletes some related unused methods.

Bug: 805192
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I513672f7abf9b8474fa600571ad275a70ac1f770
Reviewed-on: https://chromium-review.googlesource.com/1026565Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553583}

- map editing specific gestures
swipe up/down: move by line
swipe left/right: move by character
swipe left/right with two fingers: move by word
- support gestures in Learn Mode

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I62cf03eecb6cb3d555fe5bfed741b032572e7d6d
Reviewed-on: https://chromium-review.googlesource.com/1024856Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553582}

identity::IdentityManager is the new API that replaces SigninManager[Base].

Bug: 825190, 814307
Change-Id: I3cf7261fad64a63bdc449c190f7d175025408d7c
Reviewed-on: https://chromium-review.googlesource.com/1025751Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553581}

https://pdfium.googlesource.com/pdfium.git/+log/a1d344230925..ac19439e28b6

$ git log a1d344230..ac19439e2 --date=short --no-merges --format='%ad %ae %s'
2018-04-25 dsinclair Remove m_NodeStack from CFX_XMLParser

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I539a7168cf9cd7e9fdc66078529047dfcbe8d99e
Reviewed-on: https://chromium-review.googlesource.com/1028211Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553580}

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I559908461026784530214507380cda6289141cf6
Reviewed-on: https://chromium-review.googlesource.com/1015660
Commit-Queue: Julia Tuttle <juliatuttle@chromium.org>
Reviewed-by: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553579}

This reverts commit 14ebddd2.

Reason for revert: Fixing regex.

Original change's description:
> Revert "Remove ".dd" extension from VR icons"
> 
> This reverts commit c00fe466.
> 
> Reason for revert: Breaks canary push
> 
> Original change's description:
> > Remove ".dd" extension from VR icons
> > 
> > Bug: 834499
> > Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> > Reviewed-on: https://chromium-review.googlesource.com/1023049
> > Reviewed-by: Richard Coles <torne@chromium.org>
> > Reviewed-by: agrieve <agrieve@chromium.org>
> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#552773}
> 
> TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org
> 
> NOTRY=true
> 
> Bug: 834499
> Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
> Reviewed-on: https://chromium-review.googlesource.com/1028092
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553577}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

Change-Id: I7c790d21587e2eb912217b9aebbf01570a0aec05
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 834499
Reviewed-on: https://chromium-review.googlesource.com/1028095
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553578}

This reverts commit c00fe466.

Reason for revert: Breaks canary push

Original change's description:
> Remove ".dd" extension from VR icons
> 
> Bug: 834499
> Change-Id: I673de864b05a6e6e30a848631d15dce3743ca946
> Reviewed-on: https://chromium-review.googlesource.com/1023049
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: agrieve <agrieve@chromium.org>
> Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#552773}

TBR=mthiesse@chromium.org,torne@chromium.org,agrieve@chromium.org

NOTRY=true

Bug: 834499
Change-Id: I5b0094ad101b5f734c58156e86a453c8566a918c
Reviewed-on: https://chromium-review.googlesource.com/1028092Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553577}