- 24 Jun, 2020 40 commits
-
-
Amruth Raj authored
During pointer lock, a kRelativeMotionEvent is sent to indicate a recenter when the mouse is nearing the screen boundary. This test verifies that these events are not coalesced with other user generated events. Bug=1090617 Change-Id: Ib62ccf2531f0c3f45e92f5baef7fdc420af4a21e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260292Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#782086}
-
Xinghui Lu authored
This CL is for refactoring. There is no functional change. Move part of SendRequest and OnURLLoaderComplete into the base class. This can maximize the code that can be reused by the enterprise URL lookup service. Add two virtual functions GetTrafficAnnotationTag and GetRealTimeLookupUrlPrefix that are configurable by the child classes. Bug: 1085261 Change-Id: Ie895ffceacc15b34653644091763744ca970150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247402 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#782085}
-
Joey Arhar authored
When a form submission is scheduled, this patch will make it so any attempt to navigate the target frame which was already sent to the browser process will be canceled in order to make the form submission take precedence over it. This is the same behavior that would occur if we had synchronous form submissions - a synchronous form submission would cancel any navigations already sent to the browser process. Bug: 1091583 Change-Id: I6c8421922960e3209fcc21a7e4582e0fbf7d4bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254443Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#782084}
-
Ted Choc authored
Replaces Criteria.equals usage as part of the migration. See https://groups.google.com/a/chromium.org/g/java/c/ZSj5TANUy8Q/m/gFL8BCVmBgAJ for more details. BUG=1071247 Change-Id: Id02d0a737b92533ba8abb462a48a20e2c685e58b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264023Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782083}
-
Yoichi Osato authored
This feature counts protocol distribution to upload stream. This is recorded per fetch upload attempt regardless of its result. Bug: 688906 Change-Id: I3bba246fe0c41ee987a6d2ae52974fd1ac08b659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255925Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#782082}
-
Christopher Cameron authored
On macOS, most frames should be submitted by CommitOverlayPlanes. Also remove the concept of damage, because on macOS it is not meaningful. Bug: 894929 Change-Id: Idf0d393fd94fbc43f80a1d729bccf8f587431a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264935Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#782081}
-
Li Lin authored
There is a issue with text classifier that some capitalized words are not annotated properly. Convert the text to lower case for now. Bug: b/159756246 Test: manual test Change-Id: I66d355f503890a2b1d3c183853210fb1fd4aa8a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261818Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782080}
-
Patrick Noland authored
Bug: 1098986 Change-Id: I00ae9f0a173b17e2b7bde98982ab4eb1925fcbe5 Tbr: michaelbai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264603Reviewed-by:
Patrick Noland <pnoland@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#782079}
-
Chrome Cunningham authored
This reverts commit 30e7e503. Reason for revert: Broke https://ci.chromium.org/p/chrome/builders/ci/win64-chrome/3694 Original change's description: > [Kaleidoscope] Add native parts to OSS repo > > Add the Kaleidoscope native parts to the OSS repo. > > BUG=1044741 > > Change-Id: I8562c8e35db2d1fa0ef8ce140ddbbc57ca7a9991 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255563 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Samuel Huang <huangs@chromium.org> > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782073} TBR=ellyjones@chromium.org,dcheng@chromium.org,huangs@chromium.org,beccahughes@chromium.org,steimel@chromium.org Change-Id: I534b8281aabb88bcf9af7f56881e297eaa1efb98 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1044741, 1099007 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264589Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#782078}
-
Elly Fong-Jones authored
This test uses an uninitialized variable to keep track of method calls. Bug: None Change-Id: Icf08c41265986052966420dd4b274e47c83057c1 Tbr: khorimoto@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264463Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#782077}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/43a6e176a60f..2639a144ff41 2020-06-23 kjlubick@google.com [demos] Add directory from which to serve demos.skia.org 2020-06-23 adlai@google.com Ignore calls to freeGpuResources on abandoned contexts If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com,egdaniel@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com,egdaniel@google.com Change-Id: I3618fe822937a3acc912f7b947e4d7b04f8b5fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265157Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#782076}
-
Matt Menard authored
When app installation info and activity is being collected from the user, we need to inform them on the chrome://management page. Bug: 1058453 Change-Id: I6b771870e68b55afe01cce9666a3625472ddcad0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170171 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Thiemo Nagel <tnagel@chromium.org> Reviewed-by:
Anqing Zhao <anqing@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#782075}
-
Charlene Yan authored
Bug: 1018320 Change-Id: I09e27413fc0597d6e4676d31b53dc62920f824b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261407 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#782074}
-
Becca Hughes authored
Add the Kaleidoscope native parts to the OSS repo. BUG=1044741 Change-Id: I8562c8e35db2d1fa0ef8ce140ddbbc57ca7a9991 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255563 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#782073}
-
chrome://net-internalsSteven Bennetts authored
This moves the network debugging level UI from chrome://net-internals to chrome://network. This removes the last of the chromeos specific code from chrome://net-internals. We should keep the links for discovery for at least a version or two, then the chromeos tab can be removed entirely from that UI. Bug: 921726 Change-Id: I589a73a227b24205dde431cb4d329d200a1b6787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261409 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#782072}
-
David Dorwin authored
These additional services are technically required always or when presenting using Scenic. Change-Id: If526d285e8d86d95878736562f1b5fd418dd361c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261167Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782071}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/bdfbdd275b29..87c8b9163983 2020-06-24 iannucci@chromium.org [cipd] Update to version with aix-ppc64 binary. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098127 Tbr: agable@chromium.org Change-Id: I2f941cb9c58cf9e0f7f77dd3c2baf572151859d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264843 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I1fbc26765c3b2b74abc98bc1bf81e3515998ccf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264888Reviewed-by:
-
Sunny Sachanandani authored
This reverts commit fc04607a. Reason for revert: Likely caused several regressions Original change's description: > cc: Subtract estimated display draw time from begin frame deadline > > Display draw time was being subtraced from display scheduler's deadline, > but a similar adjustment was missing from cc scheduler's deadline. To > fix this inconsistency, this CL applies the deadline adjustment at a > single place, the begin frame source so that there's no mismatch. > > This makes cc scheduler have a later deadline and can cause it to wait > longer for the main thread. Recent experimentation has shown improved > latency in the absence of a scheduler deadline. It's hoped that some of > the improvement can be achieved by just fixing the deadline. > > Bug: 1042584 > Change-Id: Ia948b64c1dbba5239d1b97062224e73487e35fba > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045210 > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> > Reviewed-by: Khushal <khushalsagar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#781159} TBR=sadrul@chromium.org,sunnyps@chromium.org,khushalsagar@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1042584, 1098444, 1098229 Change-Id: I3dcad61af5f1ef6d8a38a3290c6c2e04c503dbb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264629Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#782068}
-
Elly Fong-Jones authored
Bug: None Change-Id: Iade75c41046ef96acb32c9f074a0e632fbccd488 Tbr: chcunningham@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264863Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29d59a140248..75fd127640bd 2020-06-24 sprang@webrtc.org Allows FEC generation after pacer step. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia480a8d36ee44b65a2adaccf3d542f8f3729b6b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264916Reviewed-by:
-
Dominic Farolino authored
R=fs@opera.com Bug: 993273 Change-Id: If692195679f4b10f32449c04d34196260c22c55c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256853 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Scott Little <sclittle@chromium.org> Cr-Commit-Position: refs/heads/master@{#782065}
-
evliu authored
This CL updates the DefaultRendererFactory to use the "OnReady" speech recognition callback to determine if and when speech recognition is available rather than continuously making mojo calls to the render thread. Bug: 1098552 Change-Id: Iabf19155f350bb6bd5aac8a6b157decb457d110e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261740Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#782064}
-
Leonard Grey authored
Bug: 1062493 Change-Id: I9b157a9c7e1f03563c090e4b629babc1d682e83c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250347Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#782063}
-
Robert Ogden authored
If the origin probe fails, then no subresources should be loaded from the isolated cache. Bug: 1082505 Change-Id: I8f3411ad9e0fcbc2376cf43317fe8a6cfb125b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261411Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#782062}
-
Victor Fei authored
CL:2242046 introduced ui::UiaRegistrarWin for registering custom UIA property and event. This change moves the custom UIA event used for signaling test end to ui::UiaRegistrarWin. There is no functionality change. AX-Relnotes:n/a Bug: 847971 Change-Id: Id1b8852d788d5533e14bc63588fd26669ae78eb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261876Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Victor Fei <vicfei@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782061}
-
Meilin Wang authored
This is a follow-up CL of the original: https://chromium-review.googlesource.com/c/chromium/src/+/2253363/ Upon shown, wake lock will only be requested when the battery is charging, and also be release when the charger is disconnected later. Bug: b/159382866 Test: covered by unittests. Change-Id: I62d94d645a67c07c2310b6d1a7ee8220a24c77f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2259773 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#782060}
-
Ian Kilpatrick authored
Previously if we hit an anonymous flex-item we wouldn't update the hit-test result with the flexbox itself. This updates the hit-test with the flexbox if no node is set yet. Bug: 1097654 Change-Id: I4b9d1754061aae14dd8fa6a9f33d8d065c838db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264017Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#782059}
-
Jason Chase authored
Minor refactor to have all AddToken* methods have |token(s)| as the first parameter. Split off from http://crrev.com/c/2173473. Bug: 1073920 Change-Id: Icbb2699849e74743e7584f981aa831e407134986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261634Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#782058}
-
Darwin Huang authored
Change-Id: Ie2125b4bc4cf46db8f0e0f73f80dd30224ae049a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254352Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Jarryd Goodman <jarrydg@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782057}
-
Patrick Noland authored
This reverts commit ea45d4f3. Reason for revert: breaks compile (https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8876580958035597312/+/steps/compile/0/stdout) Original change's description: > Add supports to Lens Shopping experiments for google.com > - enable lens shopping experiments variants for google.com > - add unit tests to LensUtilsTest for shopping intent > > Bug: 158099013 > Change-Id: Ib605afcfe069320a0b2a52d4ea045759a39e3592 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261093 > Commit-Queue: Yu Su <yusuyoutube@google.com> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#782024} TBR=twellington@chromium.org,benwgold@google.com,yusuyoutube@google.com Change-Id: I8c607c310d540b6b491ff07c20147f9ba1ecdb7a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 158099013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264505Reviewed-by:
-
Tommy C. Li authored
Before this CL, Entity suggestions from ZeroSuggest would have their text color messed when switching back and forth between dark mode. This CL fixes it, and adds a TODO explaining some technical debt we have. This CL also makes a similar fix to Answers, which doesn't seem to happen in practice, since Answers don't show up in ZeroSuggest, but this is the more correct thing to do. Bug: 1095205 Change-Id: I2364bb578bbfe47705c594bfe423da694df6aad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264853 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#782055}
-
Evan Stade authored
This adds the glue code for MediaSession to work in WebLayer. A new Service class is required in the client library to display the notification. This service proxies lifetime events to WebLayer implementation, which then glues together componentized code. Of note: 1. notifications displayed with Service#startForeground cannot have a tag, so the ID must be unique across all application notifications. There's a default ID for the MediaSession notification, but an API is also added to WebLayer to allow setting a different ID, in case this one conflicts. 2. favicons are not supported (normally they'd be used as fallbacks for iconography/images not provided by the system) 3. Extra handling is required for the action button icons to work, see WebLayerNotificationBuilder. On L, we fall back to system icons, which look bad because of their low resolution, but are at least functional. https://googlechrome.github.io/samples/media-session/ Test: automated tests TODO; manual testing on Bug: 1066263 Change-Id: I5e2ae13a07315e73aae474251cb5c0424804a427 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220551Reviewed-by:Scott Violet <sky@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#782054}
-
Ng Zhi An authored
Tested with: python build.py --without-android --without-fuchsia \ --run-tests --skip-checkout With python == python3.7 (inside a pipenv). - get maxint from sys.maxsize from Py3 (sys.maxint is removed) - use StringIO from io - use .values() instead of .itervalues() - tweak lambda used in sort (became syntax error in Py3) - check_output with universal newlines, will open stream as text Bug: chromium:941669 Change-Id: I80ca9ae6d2f6d712c6e3cac5343627512ce84b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261715Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782053}
-
Alison Maher authored
http://crrev.com/c/2118693 caused the invert bubble to start showing up on Mac in increased contrast mode when a new incognito window was opened. http://crrev.com/c/2247407 addressed this temporarily by disabling the bubble for incognito windows. This change is a follow-up to http://crrev.com/c/2247407 as a more permanent solution to the original problem. The invert bubble should show up in the High Contrast dark theme on Windows. However, GetHighContrastColorScheme() was calling into UsesHighContrastColors() to detect this. The problem with this is that on Mac, UsesHighContrastColors() has a different meaning than on Windows. To fix this, make GetHighContrastColorScheme() a virtual function and only return the High Contrast theme on Windows. Bug: 1095855 Change-Id: I24a7ed2dd5b9194a795d1560ba1e5f4be85afd98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250224Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#782052}
-
Francois Doray authored
This CL uses the unaligned wake ups setting added to WakeUpBudgetPool in https://crrev.com/c/2249377 to allow unaligned wake ups in frames that are same-origin with the main frame. This completes implementation of the policy presented in this message: https://groups.google.com/a/chromium.org/g/blink-dev/c/8En_5DqV_fU/m/z0Xth2xLAgAJ Bug: 1075553 Change-Id: I1ac00f1efc58f1a701120514fb7ca4dcca94ba9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252935 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#782051}
-
Elad Alon authored
This is not really an error; it happens quite naturally if the user profile has not enabled remote logging. Bug: 1098331 Change-Id: Ia4393ff5ac42e8e3b6ddaaa3ab08a39e75e8ebb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2260875 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#782050}
-
Ben Schwartz authored
This replicates the desktop UI, with platform-appropriate adjustments. Bug: 1040146 Change-Id: I33cea7dd37086d87580e149404ed3619a828ee45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240456Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Ben Schwartz <bemasc@chromium.org> Auto-Submit: Ben Schwartz <bemasc@chromium.org> Cr-Commit-Position: refs/heads/master@{#782049}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2f852116281b..4c9667c115b0 2020-06-24 jec@chromium.org Update What's New UI for Chrome 85 2020-06-24 patrick.brosset@microsoft.com Grid: Skip line labels to avoid overlap 2020-06-24 janscheffler@chromium.org [Experience] Add related node to CLS 2020-06-24 tvanderlippe@chromium.org Add @types/estree to dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1098673,chromium:1098730,chromium:1098785 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I28c0afb47dd0ac77716909cfc1ffe4e060ace9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264915Reviewed-by:
-
Jorge Lucangeli Obes authored
set_robust_list(2) is blocked in the baseline BPF policy because it's used for inter-process futexes, which are not used by Chrome processes. However, because it's being EPERM'd, it's generating quite a bit of logspam on Chrome OS. Moreover, the syscall never EPERM's according to its manpage. Allow set_robust_list(2) for NaCl specifically. This syscall also doesn't allow interacting with other processes (only modifying the calling process), so it shouldn't be too bad to allow it. Moreover, NaCl is going away so this problem will solve itself in a few months. BUG=1051197 TEST=Enable NaCl on the open web in chrome:flags, TEST=Open NaCl demo, TEST=$ grep nacl /var/log/audit/audit.log is empty. Change-Id: I25cec12067a60c3379e55d36806e07c0f2b10caf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2264573Reviewed-by:
Derek Schuff <dschuff@chromium.org> Commit-Queue: Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#782047}
-
