1. 02 Feb, 2010 24 commits
    • dbates@webkit.org's avatar
      2010-02-01 Daniel Bates <dbates@webkit.org> · fc8a2755
      dbates@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27312
      
              Implements support for full page blocking via the X-XSS-Protection header.
      
              Tests: http/tests/security/xssAuditor/full-block-base-href.html
                     http/tests/security/xssAuditor/full-block-get-from-iframe.html
                     http/tests/security/xssAuditor/full-block-iframe-javascript-url.html
                     http/tests/security/xssAuditor/full-block-iframe-no-inherit.php
                     http/tests/security/xssAuditor/full-block-javascript-link.html
                     http/tests/security/xssAuditor/full-block-link-onclick.html
                     http/tests/security/xssAuditor/full-block-object-tag.html
                     http/tests/security/xssAuditor/full-block-post-from-iframe.html
                     http/tests/security/xssAuditor/full-block-script-tag-with-source.html
                     http/tests/security/xssAuditor/full-block-script-tag.html
                     http/tests/security/xssAuditor/malformed-xss-protection-header.html
      
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::shouldFullPageBlockForXSSProtectionHeader): Added.
              (WebCore::XSSAuditor::findInRequest): Modified to call method
              XSSAuditor::shouldFullPageBlockForXSSProtectionHeader.
              * page/XSSAuditor.h: Defined method shouldFullPageBlockForXSSProtectionHeader
              and fixed misspelled words in large comment block.
      2010-02-01  Daniel Bates  <dbates@webkit.org>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27312
      
              Tests that the header "X-XSS-Protection: full-block" leads to a full page block
              when an XSS attack is detected.
      
              * http/tests/security/xssAuditor/full-block-base-href-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-base-href.html: Added.
              * http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-get-from-iframe.html: Added.
              * http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-iframe-javascript-url.html: Added.
              * http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-iframe-no-inherit.php: Added.
              * http/tests/security/xssAuditor/full-block-javascript-link-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-javascript-link.html: Added.
              * http/tests/security/xssAuditor/full-block-link-onclick-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-link-onclick.html: Added.
              * http/tests/security/xssAuditor/full-block-object-tag-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-object-tag.html: Added.
              * http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-post-from-iframe.html: Added.
              * http/tests/security/xssAuditor/full-block-script-tag-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt: Added.
              * http/tests/security/xssAuditor/full-block-script-tag-with-source.html: Added.
              * http/tests/security/xssAuditor/full-block-script-tag.html: Added.
              * http/tests/security/xssAuditor/malformed-xss-protection-header-expected.txt: Added.
              * http/tests/security/xssAuditor/malformed-xss-protection-header.html: Added.
              * http/tests/security/xssAuditor/resources/echo-head-base-href.pl: Modified to optionally
              enable full page blocking.
              * http/tests/security/xssAuditor/resources/echo-intertag-click-and-notify.pl: Ditto.
              * http/tests/security/xssAuditor/resources/echo-intertag.pl: Ditto.
              * http/tests/security/xssAuditor/resources/utilities.js:
              (checkIfFrameLocationMatchesURLAndCallDone): Added.
              (sendRequestFromIFrame): Modified to optionally call callback function when done.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      fc8a2755
    • hamaji@chromium.org's avatar
      2010-02-01 Shinichiro Hamaji <hamaji@chromium.org> · 8db1691e
      hamaji@chromium.org authored
              Reviewed by Dmitry Titov.
      
              Convert textarea-rows-cols.html to dumpAsText()
              https://bugs.webkit.org/show_bug.cgi?id=34074
      
              Remove checks for the size of scrollbar as scrollbar doesn't
              appear on Windows.
      
              * fast/forms/script-tests/textarea-rows-cols.js:
              * fast/forms/textarea-rows-cols-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54201 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8db1691e
    • eric@webkit.org's avatar
      2010-02-01 Kwang Yul Seo <skyul@company100.net> · 155eb964
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Port SharedTimer with IShell_SetTimerEx.
              https://bugs.webkit.org/show_bug.cgi?id=33599
      
              As fireTime passed in setSharedTimerFireTime is the absolute time,
              we must calcalute the interval by subtracting currentTime() from
              fireTime and pass the result to ISHELL_SetTimerEx.
      
              * platform/brew/SharedTimerBrew.cpp: Added.
              (WebCore::invokeCallback):
              (WebCore::setSharedTimerFiredFunction):
              (WebCore::setSharedTimerFireTime):
              (WebCore::stopSharedTimer):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54200 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      155eb964
    • tkent@chromium.org's avatar
      2010-02-01 Kent Tamura <tkent@chromium.org> · b81112e0
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Date.UTC() should apply TimeClip operation.
              https://bugs.webkit.org/show_bug.cgi?id=34461
      
              ECMAScript 5 15.9.4.3:
              > 9 Return TimeClip(MakeDate(MakeDay(yr, m, dt), MakeTime(h, min, s, milli))).
      
              * runtime/DateConstructor.cpp:
              (JSC::dateUTC): Calls WTF::timeClip().
      
      2010-02-01  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Date.UTC() should apply TimeClip operation.
              https://bugs.webkit.org/show_bug.cgi?id=34461
      
              Add tests for corner cases of Date.UTC().
      
              * fast/js/date-utc-timeclip-expected.txt: Added.
              * fast/js/date-utc-timeclip.html: Added.
              * fast/js/script-tests/date-utc-timeclip.js: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b81112e0
    • tkent@chromium.org's avatar
      2010-02-01 Kent Tamura <tkent@chromium.org> · d5b4fe0d
      tkent@chromium.org authored
              Unreviewed. Add two more test cases which I forgot to add in r54197.
              https://bugs.webkit.org/show_bug.cgi?id=34462
      
              * fast/js/math-expected.txt:
              * fast/js/script-tests/math.js:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d5b4fe0d
    • tkent@chromium.org's avatar
      2010-02-01 Kent Tamura <tkent@chromium.org> · 7d2c7e3f
      tkent@chromium.org authored
              Reviewed by Darin Adler.
      
              Fix a bug that Math.round() retunrs incorrect results for huge integers
              https://bugs.webkit.org/show_bug.cgi?id=34462
      
              * runtime/MathObject.cpp:
              (JSC::mathProtoFuncRound): Avoid "arg + 0.5".
      
      2010-02-01  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Darin Adler.
      
              Fix a bug that Math.round() retunrs incorrect results for huge integers
              https://bugs.webkit.org/show_bug.cgi?id=34462
      
              * fast/js/math-expected.txt:
              * fast/js/script-tests/math.js: Add test cases for Math.round() for huge numbers.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54197 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7d2c7e3f
    • hamaji@chromium.org's avatar
      2010-02-01 Shinichiro Hamaji <hamaji@chromium.org> · d3dd007c
      hamaji@chromium.org authored
              [Chromium] Unreviewed attempt to fix the chromium build.
      
              Corresponding change: http://trac.webkit.org/changeset/54182
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/ScriptController.cpp:
              (WebCore::ScriptController::processingUserGesture):
              * bindings/v8/ScriptController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54196 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d3dd007c
    • hamaji@chromium.org's avatar
      2010-02-01 Shinichiro Hamaji <hamaji@chromium.org> · 50f43981
      hamaji@chromium.org authored
              Unreviewed attempt to fix the broken build.
      
              This was introduced in http://trac.webkit.org/changeset/54182
      
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::performMediaPlayerAction):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      50f43981
    • dimich@chromium.org's avatar
      When a live iframe element is moved between pages, it still depends on the old page. · d79180bd
      dimich@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=34382
      
      Reviewed by David Levin.
      
      WebCore:
      
      Test: fast/frames/iframe-reparenting-new-page.html
      
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::setName):
      Move the code setting the frame name into a separate function.
      
      (WebCore::HTMLFrameElementBase::setNameAndOpenURL):
      (WebCore::HTMLFrameElementBase::updateLiveFrame):
      Update frame tree, reset page in the contentFrame and re-set the name.
      
      (WebCore::HTMLFrameElementBase::insertedIntoDocument):
      * html/HTMLFrameElementBase.h:
      
      * page/Frame.cpp:
      (WebCore::Frame::setPage):
      * page/Frame.h: Add setPage method. It is only currently used when iframe is
                      moved between pages (so the ASSERT(m_ownerElement).
      
      LayoutTests:
      
      * fast/frames/iframe-reparenting-new-page-expected.txt: Added.
      * fast/frames/iframe-reparenting-new-page.html: Added.
      * fast/frames/resources/iframe-reparenting-new-page-1.html: Added.
      * fast/frames/resources/iframe-reparenting-new-page-2.html: Added.
      * fast/frames/resources/iframe-reparenting-new-page-iframe.html: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54194 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d79180bd
    • beidson@apple.com's avatar
      WebCore: Add common IRC ports to port blocking. · 2a253af3
      beidson@apple.com authored
      <rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
      
      Reviewed by Tim Hatcher.
      
      * platform/KURL.cpp:
      (WebCore::portAllowed):
      
      LayoutTests: Add common IRC ports to port blocking.
      <rdar://problem/7593895> and https://bugs.webkit.org/show_bug.cgi?id=34451
      * platform/mac-tiger/security/block-test-expected.txt:
      * platform/mac/security/block-test-expected.txt:
      * security/block-test.html:
      
      Reviewed by Tim Hatcher.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54193 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2a253af3
    • hamaji@chromium.org's avatar
      2010-02-01 Shinichiro Hamaji <hamaji@chromium.org> · 508ce224
      hamaji@chromium.org authored
              Unreviewed fix for an invalid function call.
      
              check-webkit-style: Remove filename parameter from all functions where no longer used
              https://bugs.webkit.org/show_bug.cgi?id=34249
      
              * Scripts/webkitpy/style/checker.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54192 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      508ce224
    • jorlow@chromium.org's avatar
      2010-01-27 Matt Perry <mpcomplete@chromium.org> · 1fdbb825
      jorlow@chromium.org authored
              Reviewed by Eric Seidel.
      
              Add support for addUserScript to chromium port.
      
              * public/WebView.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::addUserScript):
              (WebKit::WebViewImpl::removeAllUserContent):
              * src/WebViewImpl.h:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54191 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1fdbb825
    • jorlow@chromium.org's avatar
      2010-01-29 Jeremy Orlow <jorlow@chromium.org> · 1b847237
      jorlow@chromium.org authored
              Reviewed by Nate Chapin.
      
              [V8] Add compile time guards for IndexedDB custom functions
              https://bugs.webkit.org/show_bug.cgi?id=34368
      
              * bindings/v8/custom/V8IDBRequestCustom.cpp:
              * bindings/v8/custom/V8IndexedDatabaseRequestCustom.cpp:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54190 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1b847237
    • eric@webkit.org's avatar
      2010-02-01 Kwang Yul Seo <skyul@company100.net> · 71549f61
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              [BREWMP] Port WTF's currentTime
              https://bugs.webkit.org/show_bug.cgi?id=33567
      
              Combine GETUTCSECONDS and GETTIMEMS to calculate the number
              of milliseconds since 1970/01/01 00:00:00 UTC.
      
              * wtf/CurrentTime.cpp:
              (WTF::currentTime):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54183 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      71549f61
    • barraclough@apple.com's avatar
      Bug 34346 - With JSC bindings, make processingUserGesture work with events in Isolated Worlds · 670a72a3
      barraclough@apple.com authored
      WebCore: 
      
      Reviewed by Sam Weinig + Oliver Hunt.
      
      Change HTMLMediaElement methods that require checking whether the event is a user gesture to
      be passed a boolean.  This may be passed from the JSC bindings (where we have an exec state),
      or read from the event.  Add a Flag to the IDL to mark this information is required.
      
      * WebCore.Video.exp:
      * bindings/js/JSDOMBinding.cpp:
      (WebCore::processingUserGesture):
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::domWindowAllowPopUp):
      (WebCore::JSDOMWindow::open):
      (WebCore::JSDOMWindow::showModalDialog):
      * bindings/js/JSDocumentCustom.cpp:
      (WebCore::JSDocument::setLocation):
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::processingUserGesture):
      (WebCore::ScriptController::processingUserGestureEvent):
      (WebCore::ScriptController::anyPageIsProcessingUserGesture):
      * bindings/js/ScriptController.h:
      * bindings/scripts/CodeGeneratorJS.pm:
      * dom/Event.cpp:
      (WebCore::Event::isUserEvent):
      * dom/Event.h:
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::removedFromDocument):
      (WebCore::HTMLMediaElement::load):
      (WebCore::HTMLMediaElement::play):
      (WebCore::HTMLMediaElement::pause):
      (WebCore::HTMLMediaElement::beginScrubbing):
      (WebCore::HTMLMediaElement::documentDidBecomeActive):
      (WebCore::HTMLMediaElement::webkitEnterFullScreen):
      * html/HTMLMediaElement.h:
      * html/HTMLMediaElement.idl:
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::isProcessingUserGesture):
      * loader/MediaDocument.cpp:
      (WebCore::MediaDocument::defaultEventHandler):
      * page/DOMWindow.cpp:
      (WebCore::DOMWindow::allowPopUp):
      * rendering/MediaControlElements.cpp:
      (WebCore::MediaControlSeekButtonElement::defaultEventHandler):
      
      WebKit/mac: 
      
      Reviewed by Sam Weinig + Oliver Hunt.
      
      Pass processeing user gensture flag to media play/pause methods.
      
      * WebView/WebVideoFullscreenHUDWindowController.mm:
      (-[WebVideoFullscreenHUDWindowController setPlaying:]):
      
      WebKit/win: 
      
      Reviewed by Sam Weinig + Oliver Hunt.
      
      Pass processeing user gensture flag to media play/pause methods.
      
      * FullscreenVideoController.cpp:
      (FullscreenVideoController::play):
      (FullscreenVideoController::pause):
      
      LayoutTests: 
      
      Reviewed by Sam Weinig.
      
      * http/tests/security/isolatedWorld/resources/userGestureEvents-second-window.html: Added.
      * http/tests/security/isolatedWorld/userGestureEvents-expected.txt: Added.
      * http/tests/security/isolatedWorld/userGestureEvents.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54182 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      670a72a3
    • eric@webkit.org's avatar
      2010-02-01 Andreas Kling <andreas.kling@nokia.com> · e0304c07
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Use the fallback style on Maemo 5
      
              https://bugs.webkit.org/show_bug.cgi?id=34376
      
              * platform/qt/RenderThemeQt.cpp:
              (WebCore::RenderThemeQt::RenderThemeQt):
              (WebCore::RenderThemeQt::fallbackStyle):
              (WebCore::RenderThemeQt::qStyle):
              (WebCore::RenderThemeQt::setPaletteFromPageClientIfExists):
              * platform/qt/RenderThemeQt.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54180 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e0304c07
    • eric@webkit.org's avatar
      2010-02-01 Kavita Kanetkar <kkanetkar@chromium.org> · b197c33d
      eric@webkit.org authored
              Reviewed by Nate Chapin.
      
              [V8] Making V8 generated classes' GetTemplate() function public
              https://bugs.webkit.org/show_bug.cgi?id=34026
      
              * bindings/scripts/CodeGeneratorV8.pm: Generated code need not depend on V8CustomBinding.h, made GetTemplate() signature public.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54179 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b197c33d
    • mitz@apple.com's avatar
      <rdar://problem/7044385> Crash at NetscapePlugInStreamLoader::didReceiveResponse() · 727d0762
      mitz@apple.com authored
      Reviewed by Anders Carlsson.
      
      The crash was caused by having two streams with a streamID of 1.
      
      * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
      (WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy): Fixed a typo. Now
      correctly increments m_currentURLRequestID to account for the manual stream.
      (WebKit::NetscapePluginInstanceProxy::disconnectStream): If the stream is the manual stream,
      null it out instead of trying to remove it from the map. Added an assertion.
      (WebKit::NetscapePluginInstanceProxy::loadRequest): Added an assertion.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54178 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      727d0762
    • eric@webkit.org's avatar
      2010-02-01 Patrick Gansterer <paroga@paroga.com> · 1848851e
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              [Qt] WinCE buildfix after r52729 and fix for Q_BIG_ENDIAN typo.
              https://bugs.webkit.org/show_bug.cgi?id=34378
      
              * wtf/Platform.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54176 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1848851e
    • steveblock@google.com's avatar
      Adds V8-specific JNI bridge classes · 66b0de31
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=34166
      
      Reviewed by Ariya Hidayat.
      
      This is the V8 equivalent of bridge/jni/jsc/JNIBridgeJSC.
      
      No new tests, build fix only.
      
      * Android.v8bindings.mk: Modified. Added JNIBridge.cpp and JNIBridgeV8.cpp
      * bridge/Bridge.h: Modified. Added missing include for Noncopyable.h
      * bridge/jni/v8/JNIBridgeV8.cpp: Added.
      (JavaField::JavaField):
      * bridge/jni/v8/JNIBridgeV8.h: Added.
      (JSC::Bindings::JavaField::name):
      (JSC::Bindings::JavaField::type):
      (JSC::Bindings::JavaField::getJNIType):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54175 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      66b0de31
    • steveblock@google.com's avatar
      Adds V8-specific JNI utility functions. · 78303937
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33901
      
      Reviewed by Ariya Hidayat.
      
      This is the V8 equivalent of bridge/jni/jsc/JNIUtilityPrivate.
      
      No new tests, build fix only.
      
      * Android.v8bindings.mk: Modified. Add JNIUtilityPrivate.cpp
      * bridge/jni/v8/JNIUtilityPrivate.cpp: Added.
      (JSC::Bindings::convertNPVariantToJValue):
      (JSC::Bindings::convertJValueToNPVariant):
      * bridge/jni/v8/JNIUtilityPrivate.h: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54171 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      78303937
    • steveblock@google.com's avatar
      Adds V8 version of JavaClass · 1a1116c7
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33898
      
      Reviewed by Ariya Hidayat.
      
      This is the V8 equivalent of bridge/jni/jsc/JavaClassJSC
      
      No new tests, build fix only.
      
      * Android.v8bindings.mk: Modified. Added JavaClassV8.cpp
      * bridge/jni/v8/JavaClassV8.cpp: Added.
      (JavaClass::JavaClass):
      (JavaClass::~JavaClass):
      (JavaClass::methodsNamed):
      (JavaClass::fieldNamed):
      * bridge/jni/v8/JavaClassV8.h: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54169 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      1a1116c7
    • hamaji@chromium.org's avatar
      2010-02-01 Shinichiro Hamaji <hamaji@chromium.org> · 2e284ad3
      hamaji@chromium.org authored
              Reviewed by Darin Adler.
      
              REGRESSION: editing/selection/doubleclick-beside-cr-span.html times out on Windows
              https://bugs.webkit.org/show_bug.cgi?id=34069
      
              Make the sleep time shorter as this test timed out on Windows bot.
      
              * editing/selection/doubleclick-beside-cr-span.html:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54166 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2e284ad3
    • steveblock@google.com's avatar
      Adds V8 version of JavaInstance · d6285e33
      steveblock@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33951
      
      Reviewed by Ariya Hidayat.
      
      This is the V8 equivalent of bridge/jni/jsc/JavaInstanceJSC.
      Also fixes a typo in a comment in JavaInstanceJSC.cpp.
      
      No new tests, build fix only.
      
      * Android.v8bindings.mk: Modified. Added JavaInstanceV8.cpp
      * bridge/jni/jsc/JavaInstanceJSC.cpp: Modified.
      (JavaInstance::invokeMethod): Modified. Fixed comment
      * bridge/jni/v8/JavaInstanceV8.cpp: Added.
      (JavaInstance::JavaInstance):
      (JavaInstance::~JavaInstance):
      (JavaInstance::getClass):
      (JavaInstance::invokeMethod):
      (JObjectWrapper::JObjectWrapper):
      (JObjectWrapper::~JObjectWrapper):
      * bridge/jni/v8/JavaInstanceV8.h: Added.
      (JSC::Bindings::JObjectWrapper::instance):
      (JSC::Bindings::JObjectWrapper::setInstance):
      (JSC::Bindings::JObjectWrapper::ref):
      (JSC::Bindings::JObjectWrapper::deref):
      (JSC::Bindings::JavaInstance::javaInstance):
      (JSC::Bindings::JavaInstance::begin):
      (JSC::Bindings::JavaInstance::end):
      (JSC::Bindings::JavaInstance::virtualBegin):
      (JSC::Bindings::JavaInstance::virtualEnd):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54165 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d6285e33
  2. 01 Feb, 2010 16 commits
    • dumi@chromium.org's avatar
      Making sure that all in-progress transactions are rolled back on · 0c099fc8
      dumi@chromium.org authored
      the database thread before they're destroyed. Otherwise,
      SQLiteTransaction's destructor will try to do a rollback and that
      would cause an assertion failure, if the object is not destroyed
      on the DB thread.
      
      Reviewed by Eric Seidel.
      
      https://bugs.webkit.org/show_bug.cgi?id=34152
      
      * platform/sql/SQLiteTransaction.cpp:
      (WebCore::SQLiteTransaction::stop):
      * storage/SQLTransaction.cpp:
      (WebCore::SQLTransaction::notifyDatabaseThreadIsShuttingDown):
      * storage/SQLTransaction.h:
      * storage/SQLTransactionCoordinator.cpp:
      (WebCore::SQLTransactionCoordinator::shutdown):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54162 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0c099fc8
    • weinig@apple.com's avatar
      Fix EXPERIMENTAL_SINGLE_VIEW_MODE build. · 226bb49b
      weinig@apple.com authored
      Reviewed by Beth Dakin.
      
      * page/EventHandler.h:
      * page/mac/EventHandlerMac.mm:
      (WebCore::EventHandler::currentNSEvent):
      (WebCore::EventHandler::currentKeyboardEvent):
      (WebCore::EventHandler::mouseDown):
      (WebCore::EventHandler::mouseDragged):
      (WebCore::EventHandler::mouseUp):
      (WebCore::EventHandler::mouseMoved):
      (WebCore::EventHandler::keyEvent):
      (WebCore::EventHandler::wheelEvent):
      (WebCore::EventHandler::sendContextMenuEvent):
      (WebCore::EventHandler::eventMayStartDrag):
      (WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54156 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      226bb49b
    • eric@webkit.org's avatar
      2010-02-01 Diego Gonzalez <diego.gonzalez@openbossa.org> · 2f351093
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] DRT Provide global flag ability
              https://bugs.webkit.org/show_bug.cgi?id=34418
      
              Add the globalFlag property to the Qt LayoutTestController to allow
              cross-domain indications.
      
              * platform/qt/Skipped:
      2010-02-01  Diego Gonzalez  <diego.gonzalez@openbossa.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] DRT Provide global flag ability
              https://bugs.webkit.org/show_bug.cgi?id=34418
      
              Add the globalFlag property to the Qt LayoutTestController to allow
              cross-domain indications.
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::reset):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              (LayoutTestController::globalFlag):
              (LayoutTestController::setGlobalFlag):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54155 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2f351093
    • japhet@chromium.org's avatar
      2010-02-01 Nate Chapin <japhet@chromium.org> · d62b6928
      japhet@chromium.org authored
              Unreviewed, Chromium build fix.
      
              Failed to properly add new files for http://trac.webkit.org/changeset/54150.
      
              * bindings/v8/custom/V8BarInfoCustom.cpp: Added.
              * bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
              * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
              * bindings/v8/custom/V8CSSValueCustom.cpp: Added.
              * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
              * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
              * bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
              * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
              * bindings/v8/custom/V8SVGElementCustom.cpp: Added.
              * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
              * bindings/v8/custom/V8ScreenCustom.cpp: Added.
              * bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
              * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54153 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d62b6928
    • mpcomplete@chromium.org's avatar
      Add support for addUserScript to chromium port. · f9319ca9
      mpcomplete@chromium.org authored
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54152 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f9319ca9
    • eric.carlson@apple.com's avatar
      2010-02-01 Eric Carlson <eric.carlson@apple.com> · 78c25b47
      eric.carlson@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=34448
              <rdar://problem/7598130>
      
              RenderVideo::intrinsicSizeChanged infinite recursion
      
              * rendering/RenderImage.h:
              (WebCore::RenderImage::intrinsicSizeChanged): Make protected instead of private so it can
                  be called by RenderVideo.
              * rendering/RenderVideo.cpp:
              (WebCore::RenderVideo::intrinsicSizeChanged): Call RenderMedia::intrinsicSizeChanged, not
                  RenderVideo::intrinsicSizeChanged.
              (WebCore::RenderVideo::imageChanged): Call RenderMedia::imageChanged instead of 
                  RenderImage::imageChanged.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54151 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      78c25b47
    • japhet@chromium.org's avatar
      2010-02-01 Nate Chapin <japhet@chromium.org> · 01ac50fb
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              [V8] Generate toV8() converter for most WebCore->V8 conversions,
              and defined custom converters in their respective V8<class>Custom.cpp.
      
              Old converters in V8DOMWrapper will be deleted in a later patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=32563
      
              * Android.v8bindings.mk:
              * WebCore.gyp/WebCore.gyp:
              * WebCore.gypi:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8Collection.h:
              * bindings/v8/V8DOMWrapper.cpp:
              * bindings/v8/V8DOMWrapper.h:
              * bindings/v8/V8Proxy.h:
              * bindings/v8/custom/V8BarInfoCustom.cpp: Added.
              * bindings/v8/custom/V8CSSRuleCustom.cpp: Added.
              * bindings/v8/custom/V8CSSStyleSheetCustom.cpp: Added.
              * bindings/v8/custom/V8CSSValueCustom.cpp: Added.
              * bindings/v8/custom/V8CanvasPixelArrayCustom.cpp: Added.
              * bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
              * bindings/v8/custom/V8ConsoleCustom.cpp:
              * bindings/v8/custom/V8DOMSelectionCustom.cpp: Added.
              * bindings/v8/custom/V8DOMWindowCustom.cpp:
              * bindings/v8/custom/V8DocumentCustom.cpp:
              * bindings/v8/custom/V8ElementCustom.cpp:
              * bindings/v8/custom/V8EventCustom.cpp:
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
              * bindings/v8/custom/V8HTMLElementCustom.cpp: Added.
              * bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
              * bindings/v8/custom/V8HistoryCustom.cpp:
              * bindings/v8/custom/V8LocationCustom.cpp:
              * bindings/v8/custom/V8NamedNodeMapCustom.cpp:
              * bindings/v8/custom/V8NavigatorCustom.cpp:
              * bindings/v8/custom/V8NodeCustom.cpp:
              * bindings/v8/custom/V8SVGDocumentCustom.cpp: Added.
              * bindings/v8/custom/V8SVGElementCustom.cpp: Added.
              * bindings/v8/custom/V8SVGPathSegCustom.cpp: Added.
              * bindings/v8/custom/V8ScreenCustom.cpp: Added.
              * bindings/v8/custom/V8StyleSheetCustom.cpp: Added.
              * bindings/v8/custom/V8TreeWalkerCustom.cpp:
              * bindings/v8/custom/V8WebGLArrayCustom.cpp: Added.
              * bindings/v8/custom/V8WebGLByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLFloatArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
              * bindings/v8/custom/V8WebGLShortArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedByteArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedIntArrayCustom.cpp:
              * bindings/v8/custom/V8WebGLUnsignedShortArrayCustom.cpp:
              * dom/make_names.pl: Add options to generate wrapper factory for V8 bindings.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54150 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      01ac50fb
    • bweinstein@apple.com's avatar
      Rubber-stamped by Oliver Hunt. · 062f18de
      bweinstein@apple.com authored
      Check in (failing) expected results for fast/dom/Window/window-postmessage-clone-frames.
      This fails because of <rdar://problem/5230396> eventSender.beginDragWithFiles is unimplemented.
      
      * platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54149 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      062f18de
    • eric@webkit.org's avatar
      2010-02-01 Alexander Pavlov <apavlov@chromium.org> · 4a42fecb
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: lazy-load textual resources to avoid UI hangup
              https://bugs.webkit.org/show_bug.cgi?id=34332
      
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView.prototype._innerSelectContentTab):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView.prototype.show):
              (WebInspector.SourceView.prototype.contentTabSelected):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54148 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4a42fecb
    • eric.carlson@apple.com's avatar
      2010-02-01 Eric Carlson <eric.carlson@apple.com> · 43103d25
      eric.carlson@apple.com authored
              No review, build fix.
      
              https://bugs.webkit.org/show_bug.cgi?id=34447
              http/tests/media/video-referer.html fails on Windows
      
              * platform/win/Skipped:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54147 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      43103d25
    • ossy@webkit.org's avatar
      [Qt] Unreviewed trivial fix. · c3055fad
      ossy@webkit.org authored
      Platform dependent expected file updated after r54143.
      
      * platform/qt/fast/dom/Window/window-properties-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54146 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c3055fad
    • beidson@apple.com's avatar
      Crash in Safari opening new tabs to "same page" · 4e060c0d
      beidson@apple.com authored
      <rdar://problem/7593857> and https://bugs.webkit.org/show_bug.cgi?id=34444
      
      Reviewed by Adele Peterson.
      
      WebCore: 
      
      Test: fast/loader/crash-copying-backforwardlist.html
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::loadItem): Null check currentItem().
      
      * page/Page.cpp:
      (WebCore::Page::goToItem): Ditto.
      
      WebKitTools: 
      
      Add a mode (Mac-only for now) that exercises the WebView SPI _loadBackForwardListFromOtherView:
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (setNewWindowsCopyBackForwardListCallback):
      (LayoutTestController::staticFunctions):
      
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController::newWindowsCopyBackForwardList):
      (LayoutTestController::setNewWindowsCopyBackForwardList):
      
      * DumpRenderTree/mac/UIDelegate.mm:
      (-[UIDelegate webView:createWebViewWithRequest:]):
      
      LayoutTests: 
      
      * fast/loader/crash-copying-backforwardlist-expected.txt: Added.
      * fast/loader/crash-copying-backforwardlist.html: Added.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54145 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4e060c0d
    • kevino@webkit.org's avatar
      Reviewed by Kevin Ollivier. · d0a7a7bf
      kevino@webkit.org authored
      [wx] Remove unused file that doesn't seem to belong to the port.
              
      https://bugs.webkit.org/show_bug.cgi?id=34445
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54144 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d0a7a7bf
    • eric.carlson@apple.com's avatar
      2010-02-01 Eric Carlson <eric.carlson@apple.com> · 6e10cee3
      eric.carlson@apple.com authored
              Reviewed by Adele Peterson.
      
              Fullscreen API should be on HTMLVideoElement
              https://bugs.webkit.org/show_bug.cgi?id=34438
              
              Move fullscreen DOM APIs from HTMLMediaElement to HTMLVideoElement.
      
              * html/HTMLMediaElement.cpp:
              * html/HTMLMediaElement.h:
              * html/HTMLMediaElement.idl:
              * html/HTMLVideoElement.cpp:
              (WebCore::HTMLVideoElement::paint): Removed outdated FIXME.
              (WebCore::HTMLVideoElement::paintCurrentFrameInContext): Ditto.
              (WebCore::HTMLVideoElement::webkitEnterFullScreen): Moved from HTMLMediaElement.
              (WebCore::HTMLVideoElement::webkitExitFullScreen): Ditto.
              (WebCore::HTMLVideoElement::webkitSupportsFullscreen): Ditto.
              (WebCore::HTMLVideoElement::webkitDisplayingFullscreen): Ditto.
              * html/HTMLVideoElement.h:
              * html/HTMLVideoElement.idl:
      
      2010-02-01  Eric Carlson  <eric.carlson@apple.com>
      
              Reviewed by Adele Peterson.
      
              Fullscreen API should be on HTMLVideoElement
              https://bugs.webkit.org/show_bug.cgi?id=34438
      
              Update fullscreen tests now that <audio> doesn't have fullscreen API.
      
              * fast/dom/Window/window-properties-expected.txt:
              * media/media-fullscreen-inline-expected.txt:
              * media/media-fullscreen-not-in-document-expected.txt:
              * media/media-fullscreen.js:
              (buttonClickHandler):
              (canplaythrough):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54143 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6e10cee3
    • carol.szabo@nokia.com's avatar
      2010-02-01 Carol Szabo <carol.szabo@nokia.com> · 8c399da7
      carol.szabo@nokia.com authored
              Unreviewed.
      
              Add myself to list of committers.
      
              * Scripts/webkitpy/committers.py:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54142 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8c399da7
    • oliver@apple.com's avatar
      2010-02-01 Oliver Hunt <oliver@apple.com> · c18e7fd3
      oliver@apple.com authored
              Reviewed by Gavin Barraclough.
      
              Structure not accounting for anonymous slots when computing property storage size
              https://bugs.webkit.org/show_bug.cgi?id=34441
      
              Previously any Structure with anonymous storage would have a property map, so we
              were only including anonymous slot size if there was a property map.  Given this
              is no longer the case we should always include the anonymous slot count in the
              property storage size.
      
              * runtime/Structure.h:
              (JSC::Structure::propertyStorageSize):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@54141 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c18e7fd3