- 16 Nov, 2020 40 commits
-
-
Mohamed Mansour authored
There seems to be a timing issue between the AX queries for GetText and when the model is updating. Looking at the model it seems not all TabDestroyed calls are informing the Observers that the model has changed. The TableView uses Virtual AX Children that depends on the observers to call. Moved the observer call from TabDestroyed to Reset to handle all delegate_->TabDestroyed() calls defined below: - RenderProcessExited - RenderWidgetHostDestroyed - TabDestroyed, - RenderViewHostChanged - WebContentsDestroyed Bug: 1140454 Change-Id: Ie7fd07d6540b9509b998d5cd95d1fd16f47f9018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530295Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Mohamed Mansour <mmansour@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827900}
-
Natalie Chouinard authored
Replace !isKeyboardBlacklisted() with doesKeyboardSupportAutocomplete(). Bug: 1149550 Change-Id: I244f1966ad7d6e54e0435c09cdf906c9b044549a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541402Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#827899}
-
Ahmed Fakhry authored
It's not clear to me why calling base::ThreadTaskRunnerHandle::Get() from ArcProcessTaskProvider::ScheduleNextRequest() would fail, especially since this is happening on the UI thread. But I added a few things that may fix the issue: - I noticed that ArcProcessService dtor may be called, but we did't stop observing the ProcessSnapshotServer. - When the task manager is closed, let's invalidate all the weak_ptrs of ArcProcessTaskProvider, so we don't get any pending requested from ArcProcessService after that. BUG=1136378 Change-Id: Icdbc8161e397899a2decd7efac13a39462bb6d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536812Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#827898}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605506334-6616cc9fde8be6f4a346f03421646a2f18c74624.profdata to chrome-win32-master-1605526350-20402e3f73add4bc72f047c8e3796b7e4e1e9320.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I2647853ef4bfcd8892c9d7047bf1c01ddf4f3663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540655Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827897}
-
Jeff Yoon authored
Deprecate ios-simulator-cr-recipe bot as the iOS test harness revamp is complete for upstream. Bug: 912681 Change-Id: I413e3ae6d46fef7049461da007bc9180c201f18b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542046 Commit-Queue: Jeff Yoon <jeffyoon@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#827896}
-
Thomas Lukaszewicz authored
This CL fixes a bug whereby the WebView class was not updating its accessible parent view when reparented to a new Widget hierarchy. Using VoiceOver on Mac while reparenting the WebView otherwise results in a crash. Bug: 1148710 Change-Id: If690f1bdcb669cddde411cbdeb64890ac774bd0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537594 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#827895}
-
Henrique Nakashima authored
Bug: 1097249 Change-Id: Ifc815f8f94d485906b31b87ae06d39b0eea7eb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537060Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#827894}
-
Natalie Chouinard authored
Replace explore_sites comment usages of "blacklisted" with "blocked". Code usages already updated in: https://crrev.com/c/2495607. Bug: 1097286 Change-Id: I5cfa03de85a32bf94663a4266a4185d94ddf4079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541666 Auto-Submit: Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827893}
-
Chong Gu authored
Remove experiment percentage from the builder, help detect issues like https://crrev.com/c/2519039, which needed to be reverted. Bug: 1148424 Change-Id: Iacd92899e5b85a8a4f6508ba18be1c93b9af51ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537411Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Chong Gu <chonggu@google.com> Auto-Submit: Chong Gu <chonggu@google.com> Cr-Commit-Position: refs/heads/master@{#827892}
-
Nicolas Ouellet-Payeur authored
go/linux-annotator-rel and go/win-annotator-rel were red due to a mismatch between the id of an annotation and its hash_code. TBR=rhavalati@chromium.org Change-Id: I37d00034f25a8fc0fb70c837820c9054596233f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542123Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#827891}
-
Richard Coles authored
This reverts commit 0f543f1d. Reason for revert: Test was failing due to the device screen being locked, not a problem with this specific test. Original change's description: > Disable testTextZoomAutosizingWithTwoViews > > Disable AwSettingsTest#testTextZoomAutosizingWithTwoViews due to flaky. > > Bug: 1147937 > Tbr: boliu@chromium.org > Change-Id: Ia3f0cdcbe10717ee2eec415a6da6cb1b74d32996 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2534402 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826892} TBR=boliu@chromium.org,zmin@chromium.org,dbertoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1147937 Change-Id: I687a1a49ad13cc41913423b2f55545d48a75ca3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541925Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827890}
-
Richard Coles authored
This reverts commit 74872d88. Reason for revert: Test was failing due to the device screen being locked, not a problem with this specific test. Original change's description: > Disable testFlingScroll > > Disable > org.chromium.android_webview.test.AndroidScrollIntegrationTest#testFlingScroll > due to flaky > > Bug: 1147938 > Change-Id: Ic701876e9c09399309b06827d1384b665b9b9509 > Tbr: boliu@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535554 > Reviewed-by: Owen Min <zmin@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#826959} TBR=boliu@chromium.org,zmin@chromium.org,dbertoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1147938 Change-Id: I135d770ca7a98a56a00b3b617db6b69d787b845f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541649Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#827889}
-
Andrew Grieve authored
TBR=minor doc update Change-Id: I8d02a5b686009d45ba5fa9033f221157247b0101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541910Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#827888}
-
Victor Hugo Vianna Silva authored
Before this CL, sign-out would clear the pref representing whether Sync should be decoupled from the Android master sync toggle. This CL removes the clean-up logic and also makes sure that the pref is set whenever ProfileSyncService detects there's no syncing account (either on browser startup, or after sign-out). Indeed, by the time the DecoupleSyncFromAndroidMasterSync feature is enabled, only users who were already syncing but had the master toggle disabled should remain in the coupled state. Bug: 1105795 Change-Id: If5e36080159150fe976885b469696103df890ed4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539202 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#827887}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9f94f31cc09d..5160aada22ed 2020-11-16 brianosman@google.com Test and implement all "common" intrinsics (GLSL ES Sec. 8.3) 2020-11-16 scroggo@google.com Reland "SkAndroidCodec: Support decoding all frames" 2020-11-16 jvanverth@google.com Add activation events to sk_app. 2020-11-16 borenet@google.com [infra] Mac VMs running NativeFonts tasks were updated 2020-11-16 johnstiles@google.com Convert remaining Metal tests to golden outputs. 2020-11-16 robertphillips@google.com Allow gpu_blur_utils* GMs to run with *ooprddl configs 2020-11-16 jvanverth@google.com Add product bundle name to iOS Xcode projects 2020-11-16 robertphillips@google.com Remove SkBaseDevice::flush If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: lovisolo@google.com Change-Id: I6e6ac75f8fa50fef82f9f0054b631701d755f1ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541043Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827886}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c4294f0266f1..a73ba689e695 2020-11-16 futhark@google.com Change ::selection backgrounds according to Blink fix 2020-11-16 aerotwist@chromium.org TypeScriptify ObjectPropertiesSection.js 2020-11-16 aerotwist@chromium.org TypeScriptify TimelineGrid.js 2020-11-16 tvanderlippe@chromium.org Use TypeScript-authored files in sources/ 2020-11-16 tvanderlippe@chromium.org Update `@typescript-eslint` packages 2020-11-16 tvanderlippe@chromium.org Typecheck object_ui/RemoteObjectPreviewFormatter.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1018450,chromium:1149259 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I322ad5822614ad186f650359575573116214d810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541444Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827885}
-
David Tseng authored
Fixes more DEPS violations; make sure it passes buildtools/checkdeps/checkdeps.py chrome/browser/chromeos/input_method which doesn't appear to be run on presubmits. TBR=avi@chromium.org, shend@chromium.org Original change description: https://chromium-review.googlesource.com/c/chromium/src/+/2538141 - fix the regex that was matching against .*(...|)\.(cc|h) (aka all *.cc, *.h). - add a rule for dependees of tts_controller.h with commentary. Bug: 1148093, b/173144152 Change-Id: I193b4bd9d1122223fae8fddb570dc182f0607283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541725Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827884}
-
Mario Sanchez Prada authored
This call is no longer needed since crrev.com/c/1757935, so it's safe to remove it along with all the production & test code related to it. Bug: 1039252 Change-Id: Ib30f0d43b6d33ebfbbde1eca205fc26c31874118 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539196Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#827883}
-
Mario Bianucci authored
Calling saveLayer() on the canvas before drawing the delegated ink trail is unnecessarily expensive - it allocates a temporary buffer for the path to be drawn into for resolving and layer blending that may need to occur. However, since there is only one trail, this isn't required, and we can instead just use clipRect to ensure the trail is clipped to the bounds of the presentation area. Bug: 1148533 Change-Id: Id60d1def6215616f65838aae05658317c8fcd372 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536086Reviewed-by:
Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Mario Bianucci <mabian@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827882}
-
Vyshu authored
Add GetDlcState method to client as well as fake client and associated unittests. TEST=b:172223380 BUG=autoninja -C out/Default/ unit_tests && ./out/Default/unit_tests --gtest_filter=*Dlc* dlcservice: Change-Id: I6f26c75e7d73447d14e724558a1f381198de88d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540367Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Vyshu Khota <vyshu@google.com> Cr-Commit-Position: refs/heads/master@{#827881}
-
Matthias Körber authored
Change-Id: I11905913c5ed540f08ec9a290363951c83bf2a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540471 Auto-Submit: Matthias Körber <koerber@google.com> Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#827880}
-
minch authored
Only elements in "Dark theme" detailed view got live updated. We can add other elements later if necessary. See recorded video: https://drive.google.com/file/d/1L9WIaefJsmYZJkZ7dToIaamAItd0H0op/view?usp=sharing&resourcekey=0-TTa-8PRjR8KdAcQzVAC5UQ Bug: 1131543 Change-Id: Id68fcb43eb1c5a3a748e409e2020fd7b1ede9f50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539437Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#827879}
-
spdonghao authored
Bug: 1148813 Change-Id: Ia4ec5c44f8e00d2af18f5a161f3bfe1c84a1d9f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537115 Commit-Queue: Hao Dong <spdonghao@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#827878}
-
Jarryd authored
Quota.PercentUsedForTemporaryStorage2 and Quota.DaysBetweenRepeatedOriginEvictions extended by one year. Bug: 1140094 Change-Id: I539b0f3b045912db601ced6326ee76ec6f257e0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541125 Auto-Submit: Jarryd Goodman <jarrydg@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827877}
-
David Bienvenu authored
The underlying issue is that the kProfilesLastActive pref gets cleared when Chrome is launched with a specific profile, which prevents Chrome from iterating over the last active profiles and calling session restore on each of them. This CL stops clearing the pref when launched with --app-id, and avoids restoring sessions for the last active profiles if launched with --app-id. Also, ignore browser opens and closes if the browser window is for a web app, in order to prevent kProfilesLastActive pref from getting overwritten. Bug: 1022795 Change-Id: I350a54eaaf167dabb297b9bda9061fe965f0750e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984710Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827876}
-
Miguel Casas authored
This reverts commit 2ca0c46b. Reason for revert: broke some Tast tests https://crbug.com/1149134 Bug=1149134 Original change's description: > media/gpu/vaapi: reduce encoding quality on low power ChromeOSes > > This CL queries the driver for the encoding quality range and, if > available and the device is considered "low power" (celeron, pentium > and Core -Y devices), sets it to its maximum value, for highest speed > and lowest power consumption, albeit at lower encoding quality. The > quality difference should not be noticeable for video conference > scenarios. > > I followed the code in both of Intel's VA backends. > For the legacy i965: > - VP8 supports values 1-2 [1]. (ENCODER_LOW_QUALITY is 2 so at least > this CL can supersede the patch in [2] which is what it was set off to > do). > - AVC1 and VP9 support 1-7 [3,4], ENCODER_QUALITY_RANGE_(AVC,VP9) == 7 > see [5], but this only on Gen9 [6a, 6b] (VP9 encoding is only > available in Gen9+ FTR). > > For the modern intel-media-driver iHD, values are configured with > names, 1 being TARGETUSAGE_BEST_QUALITY ([7] and its following lines). > By default, the TARGETUSAGE_RT_SPEED == 4 is used, and 7 would be > TARGETUSAGE_BEST_SPEED. > > Improvements depend on the input content. I measured kohaku with > EncodeAccelPerf.h264_1080p_i420 and when ToT is ~204fps, 4.75W, with > this CL I see ~220 fps, 4.42W. > > [1] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1151 > [2] https://source.chromium.org/chromiumos/chromiumos/codesearch/+/master:src/third_party/chromiumos-overlay/x11-libs/libva-intel-driver/files/vp8-encoder-Workaround-to-force-perforamce-mode-enco.patch;l=36 > [3] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1142 > [4] https://github.com/intel/intel-vaapi-driver/blob/d87db2111a33b157d1913415f15d201cc5182850/src/i965_drv_video.c#L1149 > [5] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_drv_video.h#L76 > [6a] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1599 > [6b] https://github.com/intel/intel-vaapi-driver/blob/021bcb79d1bd873bbd9fbca55f40320344bab866/src/i965_encoder.c#L1653 > [7] https://github.com/intel/media-driver/blob/105f0341a21324ae3bc458cfa6c25c7df0517f3a/media_driver/agnostic/common/codec/shared/codec_def_common.h#L333 > > Bug: b:141147405 > Change-Id: I7e5c54f1e5a7ac7a51c5503f37168db16f9e99f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344526 > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Sreerenj Balachandran <sreerenj.balachandran@intel.com> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827439} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,sreerenj.balachandran@intel.com,sreerenj.balachandran@intel.corp-partner.google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:141147405 Change-Id: I343cb03a094c5e58f77a8f734b7eac2b0ecb51bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541744Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#827875}
-
Adrienne Walker authored
This is a little bit awkward for native file system handles, which aren't related to blob writing failures. However, these are already returned as "failure to write blobs", so it's not too far afield. Bug: 1144131 Change-Id: I800445b39a93e7fda9d36480092d2cff55760f94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538155 Commit-Queue: enne <enne@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#827874}
-
Corentin Wallez authored
The PSA in https://hackmd.io/uH1MI9cnQBG9GGOZG20COw deprecates a number of WebGPU APIs. Now that we are past the removal deadline we can remove them from Blink and only keep the supported paths. Bug: dawn:22 Change-Id: I9241e78db5578d6cb97593e9e3363b493fed481c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521120 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#827873}
-
Mark Pearson authored
This reverts commit aa74ca79. Reason for revert: Due to a bug in the original changelist, these histograms were never emitted. In particular, they weren't emitted because the implementation classes (the ones that actually emit the metrics) aren't part of the class. In other words, they're not overriding the parent class behavior and thus not getting called. When I fixed the bug and tested the fix, I realized that the way I hooked up the metrics emitting code is wrong. I expected the UnsentLogs.Sent-emitting code to be run only when persisted logs (logs from past sessions) were going to be sent. However, it records all logs that are sent, not only persisted ones. For example, it records (i) the initial stability log and (ii) the logs that happen at regular intervals. Neither of those are counted in UnsentLogs.IntendingToSend. Long story short: bug in original changelist. Fixing the bug is non-trivial and requires substantial changes. Reverting to start over fro a clean slate. Reverting the histograms.xml change is safe because these histograms were never logged. BUG=1148523 Original change's description: > Add Metrics about Uploading UMA Records from Previous Sessions > > Change-Id: I908a337129062e882b185a08329fecfd7db6c496 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504593 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Mark Pearson <mpearson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822037} TBR=mpearson@chromium.org,holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ie44b8bac5948cb19af245800ac42e6b5bab11996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537604Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#827872}
-
dpapad authored
The logo image was accidentally only included for optimize_webui=false at r827003. Bug: 1149235 Change-Id: Ie6a965529e9d31cebcffc0a75672b3a505cc6411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538397 Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#827871}
-
Christopher Cameron authored
This function used to use the helper functions CopyToByteArray and ConvertPixelsFromCanvasPixelFormatToImageDataStorageFormat to first copy the data, then the convert formats. The function PaintImage::readPixels can do the copy and conversion simultaneously. Use that instead. Add the capability to read to uint16 (as well as uint8 and float16), since getImageData will be changed to allow specifying the type. Remove a bunch of unused helper functions left behind. Bug: 1115317 Change-Id: I88e637c2f314385c62b1a450ea2c0c9e7fc29ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533833Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#827870}
-
Angus L. M. McLean IV authored
Bug: 1071218 Change-Id: I79da1693562db63262084853b1d3c35cdb97518e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537936 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#827869}
-
Peter Kvitek authored
This is required because inbound Mojo messages which do not have a registered handler are considered an error, and the render process is terminated. Bug: 1090429 Change-Id: I6979013e55a32f30bb32f2918df5fde8ba852dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530198 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#827868}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=djacobo@chromium.org Bug: 1145565 Change-Id: I436bf817ddb0820060ddcc817c324cf2ae5c9cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532715Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Commit-Queue: David Jacobo <djacobo@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827867}
-
manukh authored
Does not add logging for split rich autocompletion, only title and non-prefix autocompletion. Will only trigger if a rich autocompleted suggestion is actually the default suggestion during a session as otherwise they have no impact. Bug: 1062446 Change-Id: Idd6f11f94195fdae76a78dde70ec57f8725601ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2465804Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#827866}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/8dceaddf8503..3e551b3ce67d 2020-11-16 capn@google.com Work around LLVM ORCv2 issue affecting Cuttlefish If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I5b1c2ecbe4247ea94d638da74ac9cfcf70d1650a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2541102Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827865}
-
cfredric authored
Change-Id: Ic2fdb5d1adb515af42735a7af1b563dd0aba8ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2540571 Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#827864}
-
Jeffrey Young authored
Previously monitored prefs only if ambient mode was already enabled. BUG=b:169579102 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: I287ab1e710b8c45b6fb2b90ba6879fb5726fc2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535111 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#827863}
-
Clark DuVall authored
This change kicks off native library loading as early as possible in a separate thread, to reduce startup latency. There may be a few activities that don't actually need native libs, but the vast majority of the time we end up loading the native lib, and this seems like a good trade off for the perf improvements. Pinpoint results for messageloop_start_time in mobile.startup: Android Go: Cold start: -11.3% https://pinpoint-dot-chromeperf.appspot.com/job/10e6fbf3520000 Warm start: -23%: https://pinpoint-dot-chromeperf.appspot.com/job/1227a4cd520000 Pixel 2: Cold start: -0.3% https://pinpoint-dot-chromeperf.appspot.com/job/11822b23520000 Warm start: -1.7% https://pinpoint-dot-chromeperf.appspot.com/job/154a85cb520000 Bug: 1148803 Change-Id: I70256509cad47c20ec047222ba7bd0f576abe548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535732 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#827862}
-
Keishi Hattori authored
When using a binary operand with CheckedPtr and std::string, you get an invalid operands to binary expression error. With this CL, the rewriter matches CheckedPtr used with a std::string and adds .get() so the std::string/char* operator overrides gets used. Bug: 1073933 Change-Id: I4854d4d272ba1d9a107e7e346bfbe363e6861c06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2535908Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827861}
-