- 02 Apr, 2018 40 commits
-
-
Penny MacNeil authored
1) Add pe_image_safe project. 2) Rename packed_list_format to shared_defines, and all references. 3) Expose blacklist::DllMatch(), with new wrapper, in preparation for next CL. 4) Adjusted IMEs.cc to use the new centralized pe_image_safe source set. TBR=grt@chromium.org Bug=769590 Test=chrome_elf_unittests.exe Change-Id: Ice1272506237164e97e45d54901f4ec7712b2475 Reviewed-on: https://chromium-review.googlesource.com/957347 Commit-Queue: Penny MacNeil <pennymac@chromium.org> Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Cr-Commit-Position: refs/heads/master@{#547472}
-
Marijn Kruisselbrink authored
And use that in the XHR code. Bug: 754493, 712693, 791702 Change-Id: Ic0904558d43131cc2240805eaa794359f6a3f1d7 Reviewed-on: https://chromium-review.googlesource.com/957600 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#547471}
-
Daniel Cheng authored
Also use the two argument version of UMA_HISTOGRAM_ENUMERATION which autodeduces the boundary value. Bug: 742517 Change-Id: I41bb007b16869456baa16b5ab8753c1bd3e565cc Reviewed-on: https://chromium-review.googlesource.com/989418Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#547470}
-
Miguel Casas-Sanchez authored
This CL extends FaceDetectionImplMacTest to also use FaceDetectionImplMacVision when appropriate. services_unittests --gtest_filter=*Face* --use-gpu-in-tests Bug: 799319 Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng Change-Id: I06c04d9773cac223f5f3612daa6a534a744fa9d8 Reviewed-on: https://chromium-review.googlesource.com/968671 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#547469}
-
Alex Newcomer authored
Just adapt the context menu code the same way as the Shelf code. - Added the USE_TOUCHABLE_LAYOUT run type. - Added the BUBBLE_TOUCHABLE_LEFT anchor type. - Modified anchor rects. - Modified ContextMenu builder classes to pass icons. - Add virtual function to AppContextMenu which allows us to only add enabled menu options to the model. - Move all check items to the end of the context menu. - Modified tests to test the new context menus. - Added more assets. Bug: 793155 Change-Id: I1ac52331b437b13398143e1f6b96a48f64d0262d Reviewed-on: https://chromium-review.googlesource.com/987551 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#547468}
-
Raymond Toy authored
When FinishTailProcessing runs, swap out tail_processing_handlers_ before processing the list because DisableOutputs() can add new items to it, and reallocate the vector. Bug: 826232 Change-Id: I61e0c7b7ead40c7abe9807795c28699931402b59 Reviewed-on: https://chromium-review.googlesource.com/988298Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#547467}
-
Benjamin Pastene authored
Bug: 731962 Change-Id: I6a77909f45f14762ec94ced476c66999b02878f7 Reviewed-on: https://chromium-review.googlesource.com/990195Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#547466}
-
https://skia.googlesource.com/skia.git/+log/01a1cf92603c..3070926579a6 $ git log 01a1cf926..307092657 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 kjlubick Add mock gl fuzzer 2018-04-02 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ a0790e0c9..d2cc6a7f7 (1 commit) 2018-04-02 kjlubick Roll Pixel 2 XL version 2018-03-21 caryclark fix SkRRect fuzzer assert Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I794c773e16bee591452fa4da5893e1047e93bbaa Reviewed-on: https://chromium-review.googlesource.com/989848 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547465}
-
Victor Costan authored
Bug: 729800 Change-Id: Iccda36930b708927e5200d1d17740165a5e52346 Reviewed-on: https://chromium-review.googlesource.com/989841 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#547464}
-
Alexei Filippov authored
Change-Id: I937597ad03097bcf10222b530448c2bda11d8140 Reviewed-on: https://chromium-review.googlesource.com/986741 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547463}
-
Simeon Anfinrud authored
This can be used in lieu of mutating an ArrayList and using Hamcrest matchers to check the behavior of Observables. I have a couple of in-progress refactors that could use something like this to help with testing. Bug: None Test: cast_base_junit_tests Change-Id: Ieaac43cc2cb9d7f5b1577a7992b6211035fc36f9 Reviewed-on: https://chromium-review.googlesource.com/982514Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Simeon Anfinrud <sanfin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547462}
-
Jao-ke Chin-Lee authored
BUG=828051 Change-Id: I68e2285c72c7722c8380d143d10a0c42e0c43877 Reviewed-on: https://chromium-review.googlesource.com/989669Reviewed-by:
-
Xiaoqian Dai authored
If overview mode is ended because of snapping a window in splitscreen, we should only animate the snapped window. Bug: 822487 Change-Id: Ic4bb9b98acad9d6bb9f39b8f09327d2c6e461a6b Reviewed-on: https://chromium-review.googlesource.com/967509Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#547460}
-
erikchen authored
Bug: 712278 Change-Id: I20d490373e46fc09a3763b23bfcb86358e0d8c92 Reviewed-on: https://chromium-review.googlesource.com/988592Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547459}
-
https://pdfium.googlesource.com/pdfium.git/+log/8f4f0ede809a..3998067026e9 $ git log 8f4f0ede8..399806702 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 thestig Remove FPDF_SetPrintPostscriptLevel(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I84c103443dc6e91ad646e87aa56c66926313eb5e Reviewed-on: https://chromium-review.googlesource.com/989658Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547458}
-
Fady Samuel authored
Current evidence points to a race in cc that is causing surface invariants violations (No invariants violations detected in LayerTreeHost but detected in ClientLayerTreeFrameSink). My suspicion is viewport is updated out of sync with LocalSurfaceId and device scale factor. This CL adds a diagnostic CHECK between the pending and active LayerImpls to attempt to detect the race and produce a better stack trace. The invariant we want to test here is if active tree has an invalid viewport (viewport has changed), then the LocalSurfaceId MUST change. Bug: 672962 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I975c9dfb9c86c292d7aac052bac01510e6efb1c2 Reviewed-on: https://chromium-review.googlesource.com/989851Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#547457}
-
Pedro Amaral authored
Moving native android selection code to new director to allow amaralp@ to be OWNER of them. Change-Id: I91abd703303799745855cf40a7002c60c924197d Reviewed-on: https://chromium-review.googlesource.com/988798Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/heads/master@{#547456}
-
John Abd-El-Malek authored
It's helpful for tests outside of content. Bug: 825242 Change-Id: I44c3f39a4c2c01bf31481c68bd095f7de34b1cbe Reviewed-on: https://chromium-review.googlesource.com/989847 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#547455}
-
Steven Bennetts authored
Additional cleanup in preparation for moving the ash implementation to src/ash. Note: This CL simplifies and clarifies when and how DisplayProperties are applied. Bug: 682402 Change-Id: Ic89eefecbbb2c35b018d05861963044b46dad4c3 Reviewed-on: https://chromium-review.googlesource.com/983006 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#547454}
-
Matthew Jones authored
Bug: 814528 Change-Id: I3abfcf7c13e95964ad4d21488e2fad82c96dd4c7 Reviewed-on: https://chromium-review.googlesource.com/987619Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547453}
-
Becca Hughes authored
Switch to an image based gradient to improve memory usage. BUG=821961,821414 Change-Id: If5599c07cd5af0e6a5ca2fce49ed40a47ab98caa Reviewed-on: https://chromium-review.googlesource.com/986735Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#547452}
-
Chris Nardi authored
style-sheet-interfaces-001.html tested that styleSheet.media was read-only, but the spec changed to add a [PutForwards] attribute to |media|, meanining that the attribute is no longer truly read-only. assert_readonly can have side-effects if the property has a [PutForwards] attribute, so remove this check, as it was causing the next test to fail. Bug: 821780 Change-Id: I77bee2f11484f6e679e4aee6b0641179c686d1d3 Reviewed-on: https://chromium-review.googlesource.com/989407Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547451}
-
Min Qin authored
TBR=bashi@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I767f6fc522a4a70d13d85697772c6483a108ec10 Reviewed-on: https://chromium-review.googlesource.com/990083Reviewed-by:
Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547450}
-
Charlie Andrews authored
In all instances, I replaced it with it Android, which is functionally equivalent. Bug: 826138 Change-Id: I1b4c8a0adfc9c24542cd75d165fee0efac8089c3 Reviewed-on: https://chromium-review.googlesource.com/981497Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#547449}
-
Elly Fong-Jones authored
ScrollView, when using layers to scroll, imposes a layer on its contents; doing so implies by default that the contents opaquely fill their entire bounds. This is not true for many kinds of contents, so don't assume it to avoid patches of un-drawn area. Bug: 826472 Change-Id: I1364c06f43241e6cecbc4eaddb20311047b89bdf Reviewed-on: https://chromium-review.googlesource.com/987527Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547448}
-
Ryan Landay authored
My CL https://chromium-review.googlesource.com/801979 exposed a bug with PlainTextRange::CreateRange() when passed a collapsed range at the beginning of a table cell. TextIterator outputs a tab character ('\t') when iterating over a table cell boundary; PlainTextRange() is currently counting the tab character in its character count for this case, but returning a start/end position (they're the same since it's a collapsed range) before the <td> element, causing an off-by-one error. xiaochengh@ found a fix for this issue, so CreateRange() now returns a position inside the text node, instead of before the <td> element. Bug: 826615 Change-Id: Ief427ea6aeb0b93cf82bae3b6901cf1b2a8cb4c7 Reviewed-on: https://chromium-review.googlesource.com/987385Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Ryan Landay <rlanday@chromium.org> Cr-Commit-Position: refs/heads/master@{#547447}
-
Matthew Jones authored
The bottom container that hosts infobars and snackbars now listens to the bottom sheet. This allows the bottom container to stack on top of the sheet when it is showing. Bug: 827541 Change-Id: Ib130cf4149223afc892945f84483467b88c28588 Reviewed-on: https://chromium-review.googlesource.com/988063Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
-
Rohit Rao authored
Fixes minor issues with an underspecified "Cancel" button matcher and updated swizzling to use the new LocationBarCoordinator instead of the old LocationBarLegacyCoordinator. BUG=825431 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6ef8c3d585f8575939ed74c7ec6eb189d31d6f22 Reviewed-on: https://chromium-review.googlesource.com/989271Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547445}
-
Dan Harrington authored
These are all the tasks required to save, load, and cleanup thumbnails. base change: https://chromium-review.googlesource.com/c/chromium/src/+/984952 Bug: 794828 Change-Id: I1ce081f53913a9b4c24b7f00a9d173c3fc061696 Reviewed-on: https://chromium-review.googlesource.com/985014 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#547444}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/371913c4e6f0..fd5d1859f1e0 $ git log 371913c4e..fd5d1859f --date=short --no-merges --format='%ad %ae %s' 2018-03-26 achuith cros_vm: Safely create vm_dir. Created with: roll-dep src/third_party/chromite BUG=chromium:782664 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I5e35d45bd91fd417ef123d40fcf3db5f9580469e Reviewed-on: https://chromium-review.googlesource.com/989845Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#547443}
-
Eugene But authored
Previously BVC used self.view as superview for tab.view to animate NTP opening. This disallowed to create a view controller for _contentArea because views hierarchy should always match view controller's hierarchy. To allow view controller creation, this CL always uses _contentArea as superview for tab.view. In order to avoid animation issues, _contentArea is temporary resized during NTP opening animation. Doing this resize is fine in the short term, because _contentArea always hosts NTP for this specific case. In the long term this code will be removed because we will need a different NTP opening animation. A separate _contentArea view controller will allow to fix download manager presentation. That view controller will be a base view controller for download manager coordinator, so download manager will be presented in _contentArea behind the bottom toolbar. _contentArea is created in a separate CL: crrev.com/c/981684 Bug: 818264 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6e642d9e8fd856ef4c1a0fceb1cf7615dad050a7 Reviewed-on: https://chromium-review.googlesource.com/985150Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#547442}
-
Ian Swett authored
Enable better crypto retransmission in Quartc. This fixes an issue where sending empty Brain sync messages reset the timer for retransmitting lost crypto stream packets (most notably, the SHLO). This means Quartc will no longer fail to connect whenever the SHLO is lost. n/a (only changes the Quartc library) Merge internal change: 190280389 https://chromium-review.googlesource.com/c/chromium/src/+/988393 Base the QUIC crypto retransmission timer on the last sent crypto packet. Protected by FLAGS_quic_reloadable_flag_quic_better_crypto_retransmission Merge internal change: 190269115 https://chromium-review.googlesource.com/c/chromium/src/+/988974 Remove special logic for headers stream from QuicWriteBlockedList and replace it with a static streams map. Protected by FLAGS_quic_reloadable_flag_quic_register_static_streams Merge internal change: 189971751 https://chromium-review.googlesource.com/c/chromium/src/+/988972 In QUIC, initialize packet_number_length in QuicPacketHeader to be PACKET_4BYTE_PACKET_NUMBER instead of PACKET_6BYTE_PACKET_NUMBER. Not protected. No functional change expected. Also replace PACKET_6BYTE_PACKET_NUMBER used in tests to be PACKET_4BYTE_PACKET_NUMBER as well. Merge internal change: 189965758 https://chromium-review.googlesource.com/c/chromium/src/+/988474 Remove AndTypeByte from IETF methods in QuicFramer because they all append the type byte, and update other comments. n/a (method renames) Merge internal change: 189887458 https://chromium-review.googlesource.com/c/chromium/src/+/988494 Change the QUIC/Quartc write model to buffer all stream data up front. This isn't so much a change in model as a recognition of how things actually work and some tweaks to make handle that correctly. Whenever Quartc writes an outgoing frame (eg. video, audio, data, or control message) to QUIC, it writes the entirety of the frame to a new QUIC stream, followed immediately by a FIN. QUIC buffers all this data, sends as much as it can immediately, and saves the rest to write later. QUIC never calls OnCanWrite(), because Quartc gives it a FIN bit for the first write on every stream. Hence, this change replaces OnCanWrite() with OnBufferChanged(), a callback which occurs whenever the amount of data buffered by a QUIC stream increases or decreases. This change replaces bytes_written() with bytes_buffered(), which gives direct access to the data Quartc needs: how many bytes QUIC still needs to send. Whenever the buffer size changes, Quartc will report bytes_buffered() to the Brain. The initial call to Write() triggers a change in buffer size, and calls OnBufferChanged(), so Quartc no longer needs extra logic to report the initial buffer size. n/a (quartc change only) Merge internal change: 189824431 https://chromium-review.googlesource.com/c/chromium/src/+/988277 Remove call to Initialize from the MockQuicSession and MockQuicSpdySession constructors. n/a - test-only change Merge internal change: 189783811 https://chromium-review.googlesource.com/c/chromium/src/+/988276 deprecate flag FLAGS_quic_reloadable_flag_quic_close_session_on_too_many_outstanding_sent_packets. Merge internal change: 189774270 https://chromium-review.googlesource.com/c/chromium/src/+/988373 Add framers/deframers for IETF-format Quic BLOCKED, MAX_DATA, MAX_STREAM_DATA, MAX_STREAM_ID, STREAM BLOCKED, and STREAM ID BLOCKED frames in support of eventual migration to IETF Quic. Not applicable, code not used in production All of these frames have been done in one CL since they all are very similar. Merge internal change: 189569936 https://chromium-review.googlesource.com/c/chromium/src/+/987479 R=rch@chromium.org Change-Id: I3ef18060e76ecf66343a0d7f151402cc8c28bd6c Reviewed-on: https://chromium-review.googlesource.com/988597 Commit-Queue: Ian Swett <ianswett@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#547441}
-
Steven Bennetts authored
In mash, Shell::local_state_ is loaded asynchronously. Components that require access to local state should implement ShellObserver::OnLocalStatePrefServiceInitialized. Bug: 678949 Change-Id: I72917db3f83f56335333a3e7b40210c289f58a0c Reviewed-on: https://chromium-review.googlesource.com/988213 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#547440}
-
Bailey Berro authored
This change does some cleanup of SmbService, SmbFileSystem, and SmbProvider. These changes include: - Use AsWeakPtr() for SmbService. - Add an SmbService::GetSmbProviderClient() helper method. - Store provider_id_ as a member variable on SmbService. - Remove provider_id as a parameter from SmbService::Unmount() - Remove provider_id from the UnmountCallbacks held by SmbProvider and SmbFileSystem Bug: chromium:757625 Change-Id: Iaec9388b04f8bcd2aa781c654b00268ba0948aa2 Reviewed-on: https://chromium-review.googlesource.com/986629 Commit-Queue: Bailey Berro <baileyberro@chromium.org> Reviewed-by:Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#547439}
-
https://skia.googlesource.com/skia.git/+log/5ab52f6a3805..01a1cf92603c $ git log 5ab52f6a3..01a1cf926 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 kjlubick More nans causing infinite recursion in GrPathUtils::convertCubicToQuads Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: If1257cf17825bff214f8406007cc69f8176066d1 Reviewed-on: https://chromium-review.googlesource.com/990032 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
John Abd-El-Malek authored
Bug: 825242 Change-Id: Ifb779d7bdc42dc98558803298576568d65a95bc5 Reviewed-on: https://chromium-review.googlesource.com/988806 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547437}
-
Nico Weber authored
Bug: none Change-Id: Iacc611282edb2d53bf213b75c07e4b724b2ac0ac Reviewed-on: https://chromium-review.googlesource.com/989246Reviewed-by:
-
Rohit Rao authored
Modifies the test to use the TabSwitcherMode enum instead of checking IsIPadIdiom(). Adds some EG matchers for various elements of the tab grid. BUG=825431 TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I29de41c895696627f37cc26b0c7853ab068f1834 Reviewed-on: https://chromium-review.googlesource.com/988273 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547435}
-
https://skia.googlesource.com/skia.git/+log/c6a19f1d044e..5ab52f6a3805 $ git log c6a19f1d0..5ab52f6a3 --date=short --no-merges --format='%ad %ae %s' 2018-04-02 caryclark fix a couple of minor surface doc changes Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=reed@chromium.org Change-Id: I5f8c2fcfcf216d331629779dc8ce4e086268d3b9 Reviewed-on: https://chromium-review.googlesource.com/989843 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Chandan Padhi authored
Currently, default resolution is set to 2880x1800. This CL now sets it to the actual screen size. Bug: 257097 Change-Id: I547262c563453e31cd8be30e79148d4b92d8c90a Reviewed-on: https://chromium-review.googlesource.com/989531 Commit-Queue: Chandan Padhi <c.padhi@samsung.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#547433}
-
