- 25 Feb, 2018 28 commits
-
-
CrystalFaith authored
File paths not working to download. Updated location of image and linked to sample. Bug: 806073 Change-Id: Id1e9b1794ad54dfe748ed8cc5da862fe6271a030 Reviewed-on: https://chromium-review.googlesource.com/935499Reviewed-by:
Meggin Kearney <mkearney@chromium.org> Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Cr-Commit-Position: refs/heads/master@{#539053}
-
Gabriel Charette authored
After just doing a full pass of this code for issue 810464, I think leaving these CHECKs behind will help a future reader as well as enforce required calling semantics. R=fdoray@chromium.org Bug: 810464 Change-Id: I48bd2c3c0308be3b856ef518ed41382497ca5cf8 Reviewed-on: https://chromium-review.googlesource.com/934081 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#539052}
-
Dave Tapuska authored
This change restructures some chrome IPC code into a subclasses. On the renderer side the Chrome IPC is moved into the SynchronousCompositorProxyChromeIPC subclass and the base class is generalized to use callbacks that Mojo can use directly. On the browser side an impl of the mojo SynchronousCompositor interface is made to send Chrome IPC to the renderer. There are two Hosts for the Synchronous Compositor. The control host which is hosted by the SynchronousCompositorBrowserFilter on the IO thread and the host which is hosted on the browser ui thread. All mojo channels are associated channels with the widget_input_handler so input is handled in order. BUG=722928 Change-Id: I517ab8b391433fa6b5e4b4fe2f9440dcfed29c05 Reviewed-on: https://chromium-review.googlesource.com/830928 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#539051}
-
Rohit Rao authored
These tests use OCMClassMock() to mock out an NSDate class method. The OCMock documentation states that behavior is undefined if multiple objects try to mock the same class simultaneously. The documentation also states that the mock object must be deallocated in order to restore the original method implementations. I suspect that the autorelease pool is never being drained and therefore the mock object stays alive past the end of these tests. This is calling subsequent tests to fail, because NSDate no longer returns the correct date. Inheriting from PlatformTest wraps each test in an autorelease pool, which appears to be enough to get the tests passing again. BUG=815189 TEST=TextToSpeechListenerTest.ValidAudioDataTest passes on the bots. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0d8383b0d1f476ff2ab9840fff384f7b4aeb2dc3 Reviewed-on: https://chromium-review.googlesource.com/936222Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#539050}
-
https://skia.googlesource.com/skia.git/+log/3fd84fa4bff1..b8b6253df6e6 $ git log 3fd84fa4b..b8b6253df --date=short --no-merges --format='%ad %ae %s' 2018-02-23 liyuqian Add threaded backend sink to DM. Fix a scheduler bug. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I6b71ce567d732d34b7d9edd74899c94092740b96 Reviewed-on: https://chromium-review.googlesource.com/936458Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539049}
-
Mohamad Ahmadi authored
Fixes the bug where changes to existing autofill profiles and credit cards or adding new ones get reflected in PersonalDataManager when user is in incognito mode. Also refactors the details of adding/updating autofill profiles and credit cards into the paymentrequest.mm instead of the coordinators. Updates the unit tests accordingly. Bug: 814130 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2cc72032648d162304211fe3de6612bc23848350 Reviewed-on: https://chromium-review.googlesource.com/931625 Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539048}
-
https://pdfium.googlesource.com/pdfium.git/+log/26820b474343..1dbea185e709 $ git log 26820b474..1dbea185e --date=short --no-merges --format='%ad %ae %s' 2018-02-25 rharrison Add expectations for static XFA tests Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ia74f756c94d7e7f3de4fe5afbd390440326963dd Reviewed-on: https://chromium-review.googlesource.com/936457 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539047}
-
tzik authored
The previous implementation of it checks if T::AddRef is available, but it seems to fail on gcc on scoped_refptr, as it has private static AddRef and Release. This adjust the check to refer methods of T explicitly to avoid touching the static member functions. Change-Id: I7fde97a533df3b4a4b7ddbb0a8f7201c3744bd46 Reviewed-on: https://chromium-review.googlesource.com/933670Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/58a48f4f..d34b9924 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I508595b69ce0b071daeda92556922b9ec47a01f0 Reviewed-on: https://chromium-review.googlesource.com/936587Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#539045}
-
Christos Froussios authored
pulling out setting the password list and allowing to use a base::MockCallback<WriteCallback> in SetWriteForTesting directly to reduce noise in the PasswordManagerExporter test code. Bug: 789561 Change-Id: Ib703b8a720e38f75d57519b9f96f926e93e9a561 Reviewed-on: https://chromium-review.googlesource.com/924422 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539044}
-
https://skia.googlesource.com/skia.git/+log/88fdee9bde97..3fd84fa4bff1 $ git log 88fdee9bd..3fd84fa4b --date=short --no-merges --format='%ad %ae %s' 2018-02-23 liyuqian Set empty drawFn when init-once returns early 2018-02-23 liyuqian Copy the bitmap in SkThreadedBMPDevice::drawDevice Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I1776a8c76ed2ecf042b1dcafdc3c34b390600f58 Reviewed-on: https://chromium-review.googlesource.com/936456 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
-
Daniel Erat authored
Bug: none Change-Id: Ib3f5225cbe9283c96646ca47d6640bfc07c28713 Reviewed-on: https://chromium-review.googlesource.com/936686 Commit-Queue: Dan Erat <derat@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#539042}
-
https://skia.googlesource.com/skia.git/+log/1267efac7f0a..88fdee9bde97 $ git log 1267efac7..88fdee9bd --date=short --no-merges --format='%ad %ae %s' 2018-02-24 egdaniel Revert "Fixes to alignment issues with regards to mapped vulkan memory." Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: I260e3a4ba3b0936aa8c8aeb3bea996bc7d7c5827 Reviewed-on: https://chromium-review.googlesource.com/936685Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/8f392095..58a48f4f Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifadf1aeafd29af9fd8157386e3818e0b779773d8 Reviewed-on: https://chromium-review.googlesource.com/936585Reviewed-by:
-
Jennifer Apacible authored
This change allows videos to be shown in picture in picture mode. When the picture in picture media controls button on a video player is clicked, a window opens and the corresponding video plays in the window. This works behind a flag. This is the first of more patches and lays the ground work for additional behavioral implementations and tests. BUG: 726621 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I01cc0af01986030ccafb623bc06592ce143a8970 Reviewed-on: https://chromium-review.googlesource.com/854719 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#539039}
-
Findit authored
This reverts commit eb0af94b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 539037 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2ViMGFmOTRiMGIyOTQxMDdjNjU1ZjZjZmUxMWNlMWVhZGMyMDI1ZTIM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/59399 Sample Failed Step: compile Original change's description: > [webauthn] Close AuthenticatorImpl bindings before callbacks are destroyed. > > This will prevent crashing when a tab is closed while > an authenticator request is pending. > > (Also remove some stray logs in authenticator_impl_unittest.cc). > > Bug: 808096 > Change-Id: I00c67b7dea8d1e37d293428e28e61046ce1f3e98 > Reviewed-on: https://chromium-review.googlesource.com/905929 > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Reviewed-by: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#539037} Change-Id: I605ad40100f9a35cf6eecf4824ce0eb062a35ebd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 808096 Reviewed-on: https://chromium-review.googlesource.com/936302 Cr-Commit-Position: refs/heads/master@{#539038}
-
Kim Paulhamus authored
This will prevent crashing when a tab is closed while an authenticator request is pending. (Also remove some stray logs in authenticator_impl_unittest.cc). Bug: 808096 Change-Id: I00c67b7dea8d1e37d293428e28e61046ce1f3e98 Reviewed-on: https://chromium-review.googlesource.com/905929 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#539037}
-
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Ibd03f9375ef1148439cec844932ecbddb3b17495 Reviewed-on: https://chromium-review.googlesource.com/936684Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539036}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I14dcf8e855723ba3dca421a6340ce70643aa2306 Reviewed-on: https://chromium-review.googlesource.com/936584Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#539035}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ca261f0b..8f392095 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ib7334875cc32b3be74fc779d3faa6a362b8b952f Reviewed-on: https://chromium-review.googlesource.com/936604Reviewed-by:
-
Andrii Shyshkalov authored
R=nodir@chromium.org Bug: 790322 Change-Id: Iec2424df297bfebf9735dbe08632616724dab45b Reviewed-on: https://chromium-review.googlesource.com/936451 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#539033}
-
Andrii Shyshkalov authored
Also, add nodir@. R=estaab@chromium.org, nodir@chromium.org Bug: 790322 Change-Id: I4cc5f9e0ad7b019b502e1a69c9ea55ba84e96053 Reviewed-on: https://chromium-review.googlesource.com/936449 Commit-Queue: Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I0ae7c795584db3b8f1b676f41dcb373ff42bacab Reviewed-on: https://chromium-review.googlesource.com/936611Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: Ic358c554bc5e658991fcece5c03f497c36ca0184 Reviewed-on: https://chromium-review.googlesource.com/936609Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#539030}
-
Khushal authored
With skia running in the GPU process for OOP raster, it needs to be able to make discardable memory allocations. Set up a connection to the discardable memory service from the GPU process. R=piman@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I5cbd5677c5c6bffd3f7492862b1825d186b19a9d Reviewed-on: https://chromium-review.googlesource.com/923208 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
-
Ken MacKay authored
Also separate out fading and buffering code to simplify the logic. I will update the mixer unit tests in the next CL; otherwise git loses the history. BUG= internal b/71559266 Change-Id: I470d845f0379d048790e75121e65daabc79770a0 Reviewed-on: https://chromium-review.googlesource.com/911996 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#539028}
-
Andrii Shyshkalov authored
R=nodir@chromium.org Bug: 790322 Change-Id: Ibe0e7df0763c92f8ea16f7ca70afe45fa2a04e6b No-Try: True Reviewed-on: https://chromium-review.googlesource.com/936241Reviewed-by:
-
Michael Montvelishsky authored
Bug: None Test: None Change-Id: Ifb76bdbd3aa2fe3f17791803600eaf987daaa72c Reviewed-on: https://chromium-review.googlesource.com/932367Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Michael Montvelishsky <mont@chromium.org> Cr-Commit-Position: refs/heads/master@{#539026}
-
- 24 Feb, 2018 12 commits
-
-
Wez authored
These tests rely on thread sleeps for synchronization, which makes them racey when run on heavily-loaded systems. TBR: scottmg Bug: 816170, 735701 Change-Id: I9cad471cf8bc88fd91dc33662489983f13f18786 Reviewed-on: https://chromium-review.googlesource.com/936446Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#539025}
-
Michael Giuffrida authored
BrowserView should not call BrowserList::SetLastActive(Browser* browser) before the Browser's |window_| is set. This can currently happen if a BrowserView's widget receives an activation event before CreateBrowserWindow() returns. This also means SetLastActive is called before the Browser adds itself to the BrowserList. Since Browser only calls BrowserList::AddBrowser() after the Browser and BrowserWindow have been initialized, it's safe for BrowserList to check whether the window is active for itself and, if so, call SetLastActive() when the browser is added. Bug: 811243,811191 Change-Id: I621238e942ab689fdbfe00b1776957477a7b0c4e Reviewed-on: https://chromium-review.googlesource.com/915202Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#539024}
-
Yash Malik authored
Also moved the relavant tests from content_element_unittest.cc to text_input_info_unittest.cc This is a post-commit followup to https://chromium-review.googlesource.com/c/chromium/src/+/933701 Bug: 641470 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id2b938ae48049c2362ca9841fb6cc29388ac07bd Reviewed-on: https://chromium-review.googlesource.com/935286Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#539023}
-
David Benjamin authored
If an SSLPrivateKey is backed by a smartcard or other interesting module, the handle may eventually stop working. In particular, the smartcard may be removed at some point. Ideally, the OS would provide reliable fine-grained signals to clear relevant the cache entries, but the OS tends not to provide these APIs. We do drop the cache entry on failure, but the user is required to retry the operation. Instead, if an SSLPrivateKey was grabbed from the SSLClientAuthCache, assume it is potentially stale. Should the signing operation fail, we can not only drop the cache entry, but retry the request. This CL does not implement this logic for proxy client certificates, only server client certificates. Proxy client certificates a missing the cache clearing logic (https://crbug.com/814911), so we can fill this in once the plumbing is in place. Along the way, fill in some URLRequest-level client certificate unit tests. Bug: 813022 Change-Id: I9f0450e9f4df1383dd8b73d0297ebea5e3368fec Reviewed-on: https://chromium-review.googlesource.com/935723Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#539022}
-
Chandan Padhi authored
Bug: 293292 Change-Id: Id190bc93a1fc42b6ad5c0d0a313dabc6fe348dce Reviewed-on: https://chromium-review.googlesource.com/925203 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#539021}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b2d8fd3f..ca261f0b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4080bfe062b81be92e080b6f8e40f68b649a40d7 Reviewed-on: https://chromium-review.googlesource.com/936601Reviewed-by:
-
https://skia.googlesource.com/skia.git/+log/fc015d2d39d2..1267efac7f0a $ git log fc015d2d3..1267efac7 --date=short --no-merges --format='%ad %ae %s' 2018-02-24 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 20c46284f..3c43b4d1e (1 commit) 2018-02-22 reed handle conic underflow calc Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: Ibb10a67b3ba616429e80e16acabf547608a99916 Reviewed-on: https://chromium-review.googlesource.com/936469Reviewed-by:
-
https://chromium.googlesource.com/angle/angle.git/+log/20c46284f286..3c43b4d1e6d0 $ git log 20c46284f..3c43b4d1e --date=short --no-merges --format='%ad %ae %s' 2018-02-23 jiawei.shao Fix incorrect conversion in ConvertToGLint Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I221a79d67706946f4660a06f478669bb254c3513 Reviewed-on: https://chromium-review.googlesource.com/936467 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#539018}
-
wutao authored
Rename the keyboard shortcut viewer strings name to match the subdir name. Bug: 813914 Test: Local run and test have no error. Change-Id: Id40dde9cc63bc53020bbb19613d190b199fab75b Reviewed-on: https://chromium-review.googlesource.com/935373 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#539017}
-
wutao authored
Changes: 1. Center aligns the top line of the description label view and shortcut label view in the KeyboardShortcutItemView. 2. Balance the top and bottom padding after the center alignment. Bug: 768932 Test: KeyboardShortcutViewTest.TopLineCenterAlignedInItemView Change-Id: I19ac62451189681c488b18272a4380c6cef80ebf Reviewed-on: https://chromium-review.googlesource.com/923004 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#539016}
-
Xianzhu Wang authored
This avoids unnecessary existing and re-enter/exiting clips within the effect nodes. Bug: 814227 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iba12228c06663a4764a3c612cba2451ddc15b378 Reviewed-on: https://chromium-review.googlesource.com/934842 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#539015}
-
https://skia.googlesource.com/skia.git/+log/ed2312643124..fc015d2d39d2 $ git log ed2312643..fc015d2d3 --date=short --no-merges --format='%ad %ae %s' 2018-02-24 reed make 1dpatheffect more robust on deserial Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=djsollen@chromium.org Change-Id: I08feb49b75260c88a730854d99706e908b34d7ad Reviewed-on: https://chromium-review.googlesource.com/936465Reviewed-by:
-
