GitLab

Prior to this change the Device properties were only fetched the first
time the page was displayed and when a device property changes.
(Navigating to the page with a new network type would not always fetch
the correct device properties). This ensures that the device properties
are always fetched.

The MAC address comes from Device properties and thus was not always
updated correctly.

This also makes the code in the details page and the details dialog
consistent.

Bug: 1012045
Change-Id: I9c39bee6f1077518add306100ff05802a4dc506f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849265
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704343}

This will allow GpuMemoryBufferFactoryTest and GpuMemoryBufferImplTest
to run on ozone platforms (e.g. Chromebooks).

BUG=958387

Change-Id: Iff5704b5ac3bdd04ebdd1151be844ddc8888613c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806423Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Jonathan Backer <backer@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704342}

This CL converts base::Bind to BindOnce or BindRepeating, and also changes
relevant base::Callbacks or base::Closures to appropriate types.

This CL is split from https://crrev.com/1831621.

This CL was uploaded by git cl split.

R=csharrison@chromium.org

Bug: 1007760
Change-Id: I7a5689ed0f5fe3d14063312230f774a61e1b0111
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849477
Auto-Submit: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704341}

Changes from https://crrev.com/c/1825661 ensured PDF compositor
failures are propagated to the print preview UI.  A new crash scenario
is from trying to propagate a failure notification being made when the
enclosing tab is already being closed.

Managed to reproduce the crash by introducing in a developer build a
long delay in PdfCompositorImpl::HandleCompositionRequest() (of several
seconds).  This allows for a human to time the destruction of the
window at a time when the PDF compositor is active.

Resolve by dropping the failure notification if the associated web
contents is known to be destroyed or in the process of being destroyed.

Bug: 1011583
Change-Id: I9dea997c00c3c117ae144ad21b7a5c82f0f569c6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848433Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Alan Screen <awscreen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704340}

Added thread_checker in StreamProcessorHelper, SysmemBufferPool and
SysmemBufferWriterQueue. Also added sequence_checker in
Fuchsia*StreamDecryptor.

Change-Id: I467e53f3512bac5f105d18f6fa5d67fc01fa3d6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838625
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704339}

During "normal" dragging from overview (not drag-to-close), the cannot
snap warning shall be suppressed on the dragged overview item.

Test: ash_unittests SplitViewOverviewSessionTest.OverviewUnsnappableIndicatorVisibilityWhileDragging/?
Bug: 1012413
Change-Id: I9036d6160231f3074e5e6f4472efe43c80571f32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849414
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704338}

I think there's enough content here for it to live on its own page.
This also adds more advice.

Change-Id: I84caac9fc80f92f8fcc7b3a3fbd07f45068425b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849095
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704337}

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/621605ce2644..05b285760e40

git log 621605ce2644..05b285760e40 --date=short --no-merges --format='%ad %ae %s'
2019-10-09 rharrison@google.com Rolling 5 dependencies (#836)
2019-10-09 rharrison@google.com Add spvc compiler to returned result (#828)

Created with:
  gclient setdep -r src/third_party/shaderc/src@05b285760e40

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=radial-bots+chrome-roll@google.com

Bug: None
Change-Id: I7d82ab364210d15bcbac2beaa1b6702f172516e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850104Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704336}

This PR removes OVR_multiview2 as a draft extension and will now be available by default.

Bug: chromium:949249
Change-Id: I0b7ab9c35cc5b653dce0c6783fae187ee0d8c39b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849107Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Mingyu Hu <mihu@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#704335}

Bug: 1007887
Change-Id: Ic9ef9efe8069eb391a5b361950b7575a6a748f50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850511Reviewed-by: Denis Kuznetsov <antrim@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704334}

This reverts commit 5ea745a6.

Reason for revert: The CL this one was dependent on, whose revert caused
this CL to be reverted, was relanded (crrev.com/c/1829544).

Original change's description:
> Revert "Disable stack sampling profiler under App Verifier"
>
> This reverts commit 17178955.
>
> Reason for revert: The CL this one was dependent on caused crashes and had to
> be reverted: crrev.com/c/1828234
>
> Original change's description:
> > Disable stack sampling profiler under App Verifier
> >
> > The StackSamplingProfiler has been observed to cause crashes when
> > running under Application Verifier, a Windows utility used to detect
> > subtle programming errors. Samples collected by the
> > StackSamplingProfiler while Application Verifier is running are unlikely
> > to hold any value, as Application Verifier slows down execution
> > significantly.
> >
> > Because StackSamplingProfiler and Application Verifier are not
> > compatible, this change detects whether Application Verifier is running,
> > and does not start up StackSamplingProfiler if so.
> >
> > This is not expected to impact data collection, as Application Verifier
> > is used only by a few developers.
> >
> > Bug: 1004989
> > Change-Id: I014b3cee440e99d832ae8d84a03fe70777676a2b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783735
> > Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> > Reviewed-by: Lei Zhang <thestig@chromium.org>
> > Reviewed-by: Mike Wittman <wittman@chromium.org>
> > Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#700356}
>
> TBR=thestig@chromium.org,wittman@chromium.org,brucedawson@chromium.org,jessemckenna@google.com
>
> Change-Id: I1c55ab21a28ceef6c3d49f83cdb5c7689ec2402f
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 1004989
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827187
> Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
> Commit-Queue: Jesse McKenna <jessemckenna@google.com>
> Cr-Commit-Position: refs/heads/master@{#700491}

Change-Id: I7fbb6a7503b754bfc952e718b9bebd30e69742c0
Bug: 1004989
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829243Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Bienvenu <davidbienvenu@chromium.org>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Cr-Commit-Position: refs/heads/master@{#704333}

Since we split settings between browser vs. OS, the settings page which
alerts the user about whether an OS update is available is part of OS
settings. However, some existing users were used to visiting
chrome://settings/help to check for this information. To ensure that
these users are not confused, this CL adds a link from the "About Chrome"
settings page to the "About Chrome OS" settings page.

Bug: 1010996
Change-Id: Ia7efc888195f444668d7b89617a698d03d4b9466
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847906Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704332}

This CL adds a UseCounter to track L3-specific usage by tracking when
dictionaries are used in mark() and measure(). It also removes an
unneeded mark() method.

Change-Id: Ic519596c76a1892265be2eea9ee02b023e083850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848366
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Reviewed-by: Tom McKee <tommckee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704331}

This change fills in some missing documentation. I ran a spell
checker throughout traffic auditor code and corrected a bunch of
miscellaneous typos as well :)

Bug: 1005537
Change-Id: I1dab786db686370e2271828089ac336dbc048913
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814721
Commit-Queue: Nicolas Arciniega <niarci@microsoft.com>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704330}

fe52a01df1e9 linux: set dumpable for all signal handlers

Change-Id: I7ea79ca9c91a97399b2fd97691caf65e4873e8a7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848936Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704329}

R=thestig
BUG=None

Change-Id: I848e251de4bdbb6d848751b7b04c96831bb78e8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848346
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704328}

This enables us to remove arcvm.conf dependencies from
arcvm-server-proxy's start/stop stanzas.

BUG=b:142144019
TEST=arc.Boot still passes

Change-Id: I9ffdbdb547ce2f53c6f216ffbefc62d032a1619e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842620Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Yusuke Sato <yusukes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704327}

During the overview -> home animation ShelfConfig::is_in_app() was
momentarily returning true. This occurred during animation because
is_app_list_visible_ was false and overview->InOverviewSession() was
false.

OnOverviewModeEnded() can no longer be used since is_in_app() will
return the wrong value when overview mode has ended and still has a
running end animation.



Bug: 1011994
Change-Id: Ie3e9bd362979cd573c1261a5b7e23bd30866d18f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849172Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Commit-Queue: Matthew Mourgos <mmourgos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704326}

TESTED=Print PDF, print webpage, print a PDF statement from bank web site.

Change-Id: I49ec6db1663f5e58d6f20a2ada10f61addf83f8c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848548
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704325}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/bc88fe8e4a2c..1deec71ea11d

git log bc88fe8e4a2c..1deec71ea11d --date=short --no-merges --format='%ad %ae %s'
2019-10-09 chrome-bot@chromium.org Update config settings by config-updater.

Created with:
  gclient setdep -r src/third_party/chromite@1deec71ea11d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel
TBR=chrome-os-gardeners@google.com

Bug: None
Change-Id: Ia7822fbfd4ccd29526f58ac8becb3eeb27f06ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850356Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704324}

BUG=1002271
R=pkasting@chromium.org

Change-Id: I51d8b4b41bfab30271edb3d67ebada490da0535f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848617
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704323}

Bug: 1010199
Change-Id: I27237b3f1bc586626646a9c1c8712bcfa4a558c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845857Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704322}

Bug: 1001503
Change-Id: I28c6c8445407315d8b2e9ab364cfb86f451758d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848385
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704321}

Flakiness mostly occurs on TSAN* builders, so just disable on them.
There are two more flaky bookmarks tests:
SingleClientBookmarksSyncTest.ApplyRemoteCreationWithoutValidGUIDOrOCII
SingleClientBookmarksSyncTest.ApplyRemoteCreationWithoutValidGUID
But they have less scores and fails on ASAN* as well, so we don't
disable them in this CL.

Bug: 1012223, 1012222
Change-Id: I38374ee2b27585f34714699abb8fbcba8d708402
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850152
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Auto-Submit: Maksim Moskvitin <mmoskvitin@google.com>
Cr-Commit-Position: refs/heads/master@{#704320}

Prior to this change, VTVDA activated the most recently seen sequence
and picture parameter sets (SPS and PPS) at IDR slices.

With this change it will use the SPS and PPS indicated by the IDR slice
header.

Bug: 988555
Change-Id: Id197545558529abc30fb64c9e638baf0b57f29c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838688Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704319}

Bug: 869847
Change-Id: I825c179158f7fb560dc8c49e6af7cf160e5daa34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848382Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704318}

https://android.googlesource.com/platform/external/perfetto.git/+log/81425dcacf74..aa9175d6761d

git log 81425dcacf74..aa9175d6761d --date=short --no-merges --format='%ad %ae %s'
2019-10-09 treehugger-gerrit@google.com Merge "proto: Update prefix of GpuLog's Severity enum again"
2019-10-09 tneda@google.com Merge "Fixing main.cc for support passing pid and timestamps to trace_to_profile"
2019-10-09 taylori@google.com Merge "perfetto-ui: Fix small selection and search bugs"
2019-10-09 fmayer@google.com Merge "Add heap graph references."
2019-10-09 taylori@google.com Merge "perfetto-ui: Edit timeRange selection"
2019-10-09 ilkos@google.com Fix duplicate hash callsites returned
2019-10-09 eseckler@google.com Merge "processor: extract a public ReadTrace() function from shell"
2019-10-09 ilkos@google.com Merge "Heap profile callsites metric"
2019-10-09 eseckler@google.com proto: Fix GpuLog Severity
2019-10-08 chiur@google.com Merge "Add message for logging GPU message"
2019-10-08 hjd@google.com Merge "perfetto-ui: Fix ProcessScheduling track for upid = 0"

Created with:
  gclient setdep -r src/third_party/perfetto@aa9175d6761d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=perfetto-bugs@google.com

Bug: chromium:133745684
Change-Id: Ifaab94e5cbce7f89aefbb457129eeb9068a7a9d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849189Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704317}

Follow-up for: https://crrev.com/c/1825572

Now that ProcessInitExceptions are no longer checked. Simply raising it
is sufficient to prioritize startup errors via PureJavaExceptionHandler.

Bug: 1000651
Change-Id: Ia93973e12699bca752a37ce6d2d76d1ebe3b5782
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849270
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704316}

BUG=762641
TBR=achuith@chromium.org

Change-Id: I5272a1931c1cf787dcd296de78a70c9577efc977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850172Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#704315}

If a test is specified with the --run_with_custom_webkit flag, the
testrunner script will automatically set up environment variables to
load the bundled WebKit frameworks.

BUG=934252

Change-Id: I6c8ff3d107981f38c03163c28a56d3ff69855f3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849771Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704314}

- Adds SupportsAmbientColor() method to PowerManagerClient
- Corresponding platform change [1]

[1] - https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1825453

BUG=b/138731765
TEST=end to end

Change-Id: I43d1532dc121b3edef099dc81bc51964b8d89f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1835170
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704313}

unity_service didn't have any dependencies on GTK, so it doesn't belong
there.  We want libgtkui to be as small as possible because in the
future we want to have alternate implementations of LinuxUi for eg. QT5.

BUG=None
R=thestig

Change-Id: Id056698779a7175c16a6545b8d29e023ef7a8a9b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846668
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Auto-Submit: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704312}

Also adds a histogram to track times when the probe succeeds after a
reported failure.

Bug: 1011510
Change-Id: Ia656320eeaa7edf56eb13153c09aafd643270470
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849108Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704311}

https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/7c4e67f..2701c13

TBR=kbr@chromium.org

Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64
Change-Id: I95e43f8b4e0cce63efd944255649c8fd433c291e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849103Reviewed-by: Shrek Shao <shrekshao@google.com>
Commit-Queue: Shrek Shao <shrekshao@google.com>
Cr-Commit-Position: refs/heads/master@{#704310}

Bug: 948878
Change-Id: I79ef6f31524cb6cbca7acab42f5b488e1b2d9524
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849123Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704309}

When System#exit is used, it bypasses our normal crash reporting
pipeline. Thus ban its usage in favour of simply crashing with an
exception. It used to be the case that crashes before native is
initialized are dropped. Since we now have PureJavaExceptionHandler this
is no longer a concern.

Explicit usages of System.exit(0) are allowed since in that case the
intent is for a normal exit. Specific instances of System.exit(non-zero)
can be allowed in a similar manner as the one allowed in this CL.

Bug: 1000651
Change-Id: Ie3042ec2782dd5577636fcaec65de43d8f0990e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850352
Auto-Submit: Peter Wen <wnwen@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704308}

This is a reland of 8d1685b9

Problem that caused revert fixed by https://crrev.com/c/1849114

TBR=morlovich@chromium.org,mrefaat@chromium.org

Original change's description:
> Add CookieStore method to fetch all cookies with their access semantics
>
> This change adds a CookieStore method,
> GetAllCookiesWithAccessSemanticsAsync, which returns a list of all
> cookies in the CookieStore along with a list of the
> CookieAccessSemantics for each returned cookie. These lists will be in
> the same order, so that each cookie in the returned list of cookies has
> the access semantics at the same index in the other list.
>
> This is implemented for CookieMonster only, and other CookieStore
> implementations will use the default impl which returns UNKNOWN for
> all the cookies. A later CL will additionally expose this method
> via the CookieManager interface.
>
> Bug: 978172
> Change-Id: I8463806f5cc6ce6c8d200bec57bbecba5fe3aec6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846071
> Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703824}

Bug: 978172
Change-Id: I199ce9f779ce1f6a9cfe52393fd50207d2782781
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849143Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704307}

This version calls `RandomValue` less often, which exercises atomics less, so
should be faster.

Thanks to vtsyrklevich for the idea and technique.

Bug: 984742, 1006176, 1005678, 1005677, 1005248, 1005068, 1005066, 1006178, 1006071
Change-Id: I6a60e5a9b18588f56fff5b38a58c511f6ac0c850
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817188
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704306}

This UX is not finalized yet. This is just a
placeholder until the UX is finalized.

https: //screenshot.googleplex.com/a1HiDCrba5o
Bug: 1010764
Change-Id: I1b584cb3364f3b36ac6f25383d095099cb779392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842316
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Daniel Rubery <drubery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704305}

* Show X on row hover
* Show (X) (background) on icon hover
* Reserve space if any 1+ matches are removable

Fixed: 1002689
Change-Id: Idd1f4a623e013893d6e376eedaff3ea2ee26fdc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842622
Commit-Queue: Dan Beam <dbeam@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704304}