GitLab

We'll need them to implement shared memory.

(Also add TODOs for a bug that I spotted.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/169463012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252827 0039d316-1c4b-4281-b951-d872f2087c98

The text was sent to the LLVM mailing list, I edited it a bit and restified it. See:
http://lists.cs.uiuc.edu/pipermail/llvmdev/2013-June/063010.html

R= binji@chromium.org, sbc@chromium.org, dschuff@chromium.org, mseaborn@chromium.org, jvoung@chromium.org, stichnot@chromium.org, sehr@chromium.org, ncbray@chromium.org, mackinlay@chromium.org
TEST= none
BUG= none
NOTRY=true
(documentation only change)

Review URL: https://codereview.chromium.org/164413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252826 0039d316-1c4b-4281-b951-d872f2087c98

Added libjingle_nacl target that compile libjingle for PNaCl.
Removed dependency on jsoncpp.

BUG=276739

Review URL: https://codereview.chromium.org/173013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252825 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252824 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167634:167634&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/175463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252823 0039d316-1c4b-4281-b951-d872f2087c98

This helps to refactor raw_channel_posix_unittest to run on multiple
platforms.

TEST=mojo_common_unittests,mojo_system_unittests
BUG=None
TBR=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/176063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252822 0039d316-1c4b-4281-b951-d872f2087c98

This test is failing on ~25% of win_rel try jobs and the CQ is suffering.

http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268519
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268515
http://build.chromium.org/p/tryserver.chromium/builders/win_rel/builds/268511

> Re-enable MetricsServiceTest.RegisterSyntheticTrial.
> 
> The test passes locally and the failure stacktrace from
> the bug should have been fixed by http://crrev.com/240919.
> 
> BUG=320433
> 
> Review URL: https://codereview.chromium.org/174403003

TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/176423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252821 0039d316-1c4b-4281-b951-d872f2087c98

* Introduce an AppsClient for app_shell
* Create an AppsClient for tests
* Introduce ShellAppWindowDelegate whose sole purpose is to create a NativeAppWindowViews for windows in app_shell
* Extract Chrome-specific code from apps/app_window.cc

This is part 2 of 2 and depends on https://codereview.chromium.org/171003004/

BUG=343174
TEST=browser_tests PlatformApp*
TBR=sky@chromium.org for chrome/test/base/testing_browser_process.cc

Review URL: https://codereview.chromium.org/166833004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252820 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345657

Review URL: https://codereview.chromium.org/174883003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252819 0039d316-1c4b-4281-b951-d872f2087c98

Adds a BuildRasterTaskQueue test and improves code coverage of existing
tests by making every other task required for activation. A regression
in test results is expected result of making the tests do more work.

BUG=269841
TEST=cc_perftests --gtest_filter=RasterWorkerPool*

Review URL: https://codereview.chromium.org/171423015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252818 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252817 0039d316-1c4b-4281-b951-d872f2087c98

These constants are missing on certain devices, and won't actually be needed
until crrev.com/171773012 lands.  Remove them entirely to prevent further
breakage on Blink dbg bots.

BUG=345602
TBR=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/175693009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252816 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167622:167633&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/174823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252815 0039d316-1c4b-4281-b951-d872f2087c98

This cl adds support to cancel the SpeechRecognitionBubble on
pressing the Escape key.

BUG=344481

Review URL: https://codereview.chromium.org/167283005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252814 0039d316-1c4b-4281-b951-d872f2087c98

Cast: Plumb raw event logs up to CastSession, install EncodingEventSubscriber on CastSessionDelegate.

CastSessionDelegate will have one or two EncodingEventSubscribers listening to audio / video events respectively. These subscribers are created alongside the CastSender / CastTransportSender.


Next CL will be adding a JS API and a function in CastStreamingNativeHandler to get logs from CastSession.

Review URL: https://codereview.chromium.org/173713004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252813 0039d316-1c4b-4281-b951-d872f2087c98

This unit test is already in content_unittests target and with the
removal of src/webkit we need to move it over to content/.

BUG=265753
TEST=content_unittests --gtest_filter=BlinkPlatformTest.*
R=avi@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/175363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252812 0039d316-1c4b-4281-b951-d872f2087c98

done.

R=jar@chromium.org
BUG=342395

Review URL: https://codereview.chromium.org/168203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252811 0039d316-1c4b-4281-b951-d872f2087c98

We shouldn't create threads for each instance of CastSessionDelegate.

Cast encoding threads are now managed by a singleton object of
CastThreads. Threads used by Cast are now started and stopped
accordingly when there are CastSessionDelegate objects.

Tested with browser_tests --gtest_filter=CastStreaming*

BUG=317006

Review URL: https://codereview.chromium.org/174403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252810 0039d316-1c4b-4281-b951-d872f2087c98

This was broken for prevent-inline-autocomplete mode.  See bug.

BUG=345366

Review URL: https://codereview.chromium.org/169463011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252809 0039d316-1c4b-4281-b951-d872f2087c98

idb_perf has been superseded by indexeddb_perf.

BUG=237712

Review URL: https://codereview.chromium.org/156663003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252808 0039d316-1c4b-4281-b951-d872f2087c98

Revert of cc: Cleanup internal::WorkerPoolTaskClient interface. (https://codereview.chromium.org/170783007/)

Reason for revert:
Speculative revert. Suspecting that this CL may be causing a DCHECK to fire on Android in PixelBufferRasterWorkerPool::ScheduleMoreTasks(

http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18755/steps/slave_steps/logs/stdio

Original issue's description:
> cc: Cleanup internal::WorkerPoolTaskClient interface.
> 
> ::CompleteOnOriginThread is now called when RasterWorkerPool has
> completed all necessary initialization of resource, including
> texture uploads. This improves the WorkerPoolTask/Client interface
> significantly and will allow better resource recycling once
> ::RunReplyOnOriginThread is removed.
> 
> BUG=269841
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252790

TBR=vmpstr@chromium.org,alokp@chromium.org,sergeyberezin@chromium.org,reveman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=269841

Review URL: https://codereview.chromium.org/176403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252807 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Cast: Re-enable End2EndTest.StartSenderBeforeReceiver (https://codereview.chromium.org/175213004/)

Reason for revert:
The test is failing on all of the windows bots on the Chrome waterfall.
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/27822/steps/cast_unittests/logs/StartSenderBeforeReceiver

Original issue's description:
> Cast: Re-enable End2EndTest.StartSenderBeforeReceiver
> 
> I was not able to re-produce the non-determism.
> 
> BUG=314233
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252761

TBR=miu@chromium.org,hubbe@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=314233

Review URL: https://codereview.chromium.org/163883008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252803 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252798 0039d316-1c4b-4281-b951-d872f2087c98

::CompleteOnOriginThread is now called when RasterWorkerPool has
completed all necessary initialization of resource, including
texture uploads. This improves the WorkerPoolTask/Client interface
significantly and will allow better resource recycling once
::RunReplyOnOriginThread is removed.

BUG=269841

Review URL: https://codereview.chromium.org/170783007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252790 0039d316-1c4b-4281-b951-d872f2087c98

Port the Android platform's Scroller.java to C++, and wire the code up to
FlingAnimatorImpl. This has several benefits, including:

1) JNI hop and garbage elimination.
2) Fling updates in DIPs.
3) Animation timing independent of the Android view system.
4) Easy access to X and Y velocity components.

This may also prove useful for non-fling related scroll animations, e.g., smooth
scrolling from mousewheel and/or keyboard inputs on the compositor thread.

BUG=344370
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/172933004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252789 0039d316-1c4b-4281-b951-d872f2087c98

Fix indent typo, and get rid of really awkward use of closures.


BUG=None.
TEST=None.

Review URL: https://codereview.chromium.org/167733005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252788 0039d316-1c4b-4281-b951-d872f2087c98

Switches updating of state_.is_screen_locked to push rather than pull.
is_screen_locked is set when the lock animation starts and unset when
OnLockStateChanged is called with locked unset.
If is_screen_locked is set avoid generating notifications about inset
changes.

BUG=338377

Review URL: https://codereview.chromium.org/175473003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252785 0039d316-1c4b-4281-b951-d872f2087c98

CoreAnimation provides GPU backpressure from the browser process to the
renderer process by only acknowledging frames when they are displayed.
This mechanism has the side-effect of throttling the renderer to about
vsync, because the layer will not request to be displayed much more
than once per vsync.

Relieve this pressure by not going into isAsynchronous mode when
receiving new frames when vsync is disabled.

This exposed an issue where unluckily-timed setNeedsDisplay calls could
be dropped on the floor, hanging the renderer because it would never
get its ack. Work around this by calling setNeedsDisplay and
displayIfNeeded explicitly, and, if the draw is not triggered by that,
sending the ack explicitly. This bug has never triggered without vsync
disabled, but apply the workaround in both situations, to be sure.

Use a ScopedClosureRunner to ensure that the swap ack be issued in
CompositorSwapBuffers, rather than sprinkling ack calls all over the
function. Remove the TODOs because the scoped runner should solve
the problem they were working around.

BUG=245900

Review URL: https://codereview.chromium.org/171513012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252784 0039d316-1c4b-4281-b951-d872f2087c98

BUG=327826

Review URL: https://codereview.chromium.org/138343008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252783 0039d316-1c4b-4281-b951-d872f2087c98

The |cient_control->server_alive| mutex was being created for each
target (child) process and leaked (that part is necessary). Instead
a single mutex can be reused for all targets.

R=rvargas
BUG=331241

Review URL: https://codereview.chromium.org/167593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252782 0039d316-1c4b-4281-b951-d872f2087c98

Currently, GPU broker process has the same process title to GPU process. To
distinguish GPU broker process, this CL updates the process title as follows:
"exec --type=gpu-broker".

In addition, callback name in BrokerProcess::Init() is change to
broker_process_init_callback in order to clarify the broker process calls it.

In addition, use base::Callback instead of function pointer.

Review URL: https://codereview.chromium.org/163433011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252781 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252780 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- r152 Adding support for custom rc header formatting.

BUG=none

Review URL: https://codereview.chromium.org/175403005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252779 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=167604:167621&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/175583005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252778 0039d316-1c4b-4281-b951-d872f2087c98

Previously all command structures were declared as #pragma pack(1)
which was forcing byte-by-byte access to the command buffer; less
than optimal.

The command buffer and all commands are 4 byte aligned, so
changing to #pragma pack(4) should be safe and optimal.

BUG=339151

Review URL: https://codereview.chromium.org/152263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252777 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252776 0039d316-1c4b-4281-b951-d872f2087c98

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/165423002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252775 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:243605
TEST=build with updated .DEPS.git

Review URL: https://codereview.chromium.org/175443004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252774 0039d316-1c4b-4281-b951-d872f2087c98

Without floating point DIP coords in WebTouchPoint, it's possible that a
TouchMove physically outside the pixel slop region will be classified as
inside the DIP slop region. This leads to cases where a touch handler is
never offered a TouchMove before a ScrollBegin occurs.

Until the resolution of crbug.com/3336807, address this by conservatively
constructing the DIP slop region in the TouchEventQueue, ensuring that touch
handlers are offered at least one TouchMove before scrolling begins.

BUG=345507

Review URL: https://codereview.chromium.org/172263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252773 0039d316-1c4b-4281-b951-d872f2087c98

This breaks the dependency on the TestCompositor for
this test suite. Once it's no longer in use by any test
suite, we can remove it.

R=sky@chromium.org
BUG=270918

Review URL: https://codereview.chromium.org/164823007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252772 0039d316-1c4b-4281-b951-d872f2087c98