- 31 Jan, 2020 40 commits
-
-
Sylvain Defresne authored
This reverts commit 3edb7dbb. Reason for revert: consistently fails on downstream bots. Original change's description: > [iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature. > > Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests. > > The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup. > > Bug: 1045981 > Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737283} TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org Change-Id: I58ffda870f5d63c9b23fb9fb40903d14b2fd9ead No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1045981 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032120Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#737316}
-
Mohamed Amir Yosef authored
Since all Password views now have their own controller, let's get rid of the ManagePasswordsBubbleModel. Bug: 1044034 Change-Id: Id90d288d2bea3439dc251651185054242630b528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030767 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737315}
-
Ewann authored
- Resizes toolbars. - Updates fakeOmnibox height. screenshots: https://drive.google.com/drive/folders/1VloKJh9nJOi-73XmBTH_QAXQRbTN1wuo?usp=sharing Bug: 1035850 Change-Id: If97c06b1cb9257fe490a75a4d86b703f6426940b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978001 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#737314}
-
Clemens Arbesser authored
This CL adds a second container for generic UI to the CollectUserData action. The first container is right after prepended_sections (no change), the new second container is after appended_sections. Conceptually, this will allow the specification of additional sections, both prepended and appended ones, in either the dedicated proto or via generic UI. In the mid-term, I plan to remove those legacy additional sections completely, but for now, the two will co-exist. Bug: b/145043394 Change-Id: Iaabfa5fd7d3b71b287e9b0458fcd0790553ee490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030488 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#737313}
-
Mohamed Amir Yosef authored
This CL is one of many refactoring CLs that would split the ManagePasswordsBubbleModel into different controllers one per view. Bug: 1044034 Change-Id: I80836c2ce3bb89efcd6765108a59922a5459368c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022672 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
-
Stephen Nusko authored
Reason for reland: Keep ProducerEndpoint around forever. Managed to repro the flakiness locally and therefore fix the issue. The SMB was kept forever but the ProducerEndpoint contains the unique_ptr<SharedMemory> that the SMB uses which meant that when it went away we were left with a dangling pointer. Bug: 1007310 Change-Id: I0e5e09169e369f4c3c7d93d3b23f1931d977fc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027368Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737311}
-
sandromaggi authored
Before, chips were replaced as a list. Now they are compared one by one, if they are "the same", only the chip's |enabled| state is updated. Bug: b/144075373 Change-Id: I7e9e970217faa85e66c559194fe0159f98d67a4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027908Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
Tanmoy Mollik authored
setFirstSetupComplete() should not be called when user clicks settings on the SigninFragment. This cl add a test for checking that behavior. Bug: 1041412 Change-Id: Ia05191af117312c1ea8c11b31428ef8450d595f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012027 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737309}
-
Omer Katz authored
There are no usages of HeapDeque that use an inline buffer. Bug: 986235 Change-Id: I72d2c173690b5498cbb0726ae7521fdea2756a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032117Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#737308}
-
Hiroshige Hayashizaki authored
This CL migrates wpt/content-security-policy/securitypolicyviolation/upgrade-insecure-requests-reporting.https.html to use the new /common/security-features/ infrastructure. This CL removes the last use of wpt/upgrade-insecure-requests/support/testharness-helper.sub.js (other tests under wpt/upgrade-insecure-requests/ have been already migrated) and thus removes the file. Follow-up of a comment at https://chromium-review.googlesource.com/c/chromium/src/+/2024249 Bug: 906850 Change-Id: I7a992491652d988115d1d9e62eafe179473e534a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027899Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Eriko Kurimoto <elkurin@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#737307}
-
Chromium WPT Sync authored
Using wpt-import in Chromium aa7bc2f2. With Chromium commits locally applied on WPT: 64ab230d "Set network_isolation_key for signed exchange cert fetch" 20aa9a35 "ServiceWorkerSingleScriptUpdateChecker has credentials" d455934d "Clamp the presentation time to a usable range" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Id9c68ab8dab0a212087b11d6229fa8d6ed483e06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032940Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737306}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/10a83fb9a9da..d1e28ea0ef92 git log 10a83fb9a9da..d1e28ea0ef92 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@d1e28ea0ef92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia5fa9ecb956754faf877b9321832bd0adf849101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033109Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737305}
-
Mihai Sardarescu authored
This CL removes the robot account ID from the refresh token API of the DeviceOAuth2TokenService as there is a single account in the DeviceOAuth2TokenService. It also marks as private the OAuth2TokenManagerDelegate functions that it implements. Bug: 1028509 Change-Id: I0e6ab3255194d3181f3206304ddd61b3c4abda20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022705 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#737304}
-
Ioana Pandele authored
This test has been flaky for a few months. TBR=oshima@chromium.org Bug: 1047657 Change-Id: I25ae1733a3407c9f40f907f05505158409437739 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030961 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#737303}
-
Tarun Bansal authored
Change-Id: If8752e9b7a61d59537a528bd71d45462656ab9ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032423 Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737302}
-
Alex Ilin authored
This CL adds a helper method for parsing the consent result returned from Gaia via JavaScript. This method is used in GaiaRemoteConsentFlow to check that the consent was actually granted by the user. Bug: 1026237 Change-Id: I9d5b44f275d227316794dd06be69bf68878e24fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030948Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737301}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8ad9e74d62bf..bfe3ef8feb3b git log 8ad9e74d62bf..bfe3ef8feb3b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 eshr@google.com Report frame qp to quality scaler via overuse module Created with: gclient setdep -r src/third_party/webrtc@bfe3ef8feb3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Icc8f6776a0aa9fd6d90fa3e29ab4b9a7106468f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033104Reviewed-by:
-
Yuki Shiino authored
Resolves header include issues. Bug: 839389 Change-Id: I705d5265a0be2efbe917b408ffb3f7f89cfcd839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032694Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#737299}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/689295e34071..5de415c5e3f9 git log 689295e34071..5de415c5e3f9 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 6c3dc3581eaf..79b36b640692 (13 commits) 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src ebe1b7497acb..260679605f98 (1 commits) 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 44ac9b2f406f..fb94ccddb725 (1 commits) 2020-01-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 97f1d485b763..7a2d408dea60 (4 commits) Created with: gclient setdep -r src/third_party/angle@5de415c5e3f9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: If7338235a3f66214d3014a18965a9d2a0abc5160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033105Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/58ad98201e2e..d1b176ec137a git log 58ad98201e2e..d1b176ec137a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 primiano@google.com Merge "CI: switch to E3 instances" Created with: gclient setdep -r src/third_party/perfetto@d1b176ec137a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I550bfb018d3fbad6106b0ce443b1377b86a7b65a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033107Reviewed-by:
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: Ia038efd4afc044e09d87bed4d6286d50cb88d5c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030167Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#737296}
-
Anatoliy Potapchuk authored
To avoid potential risks, do not update launch url if its origin does not much the one provided by policy. Bug: 1046260 Change-Id: Ifa82de2eb45ada3bd9a68351ffbbf88324d9f9fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027849 Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737295}
-
Marc Treib authored
This adds comments to experiment_status.proto and experiments_specifics.proto explaining why these deprecated definitions can't be removed yet. Bug: 1009361 Change-Id: Id2519a51d9c66a569015be7a58580b2299fe852b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032111 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#737294}
-
Colin Blundell authored
Follows the componentization of the production class. One note is that there are multiple independent test classes in the unittest file that all construct TestSSLErrorHandler instances. As the manual construction of a CaptivePortalService instance is somewhat cumbersome, we did it only in the tests that actually need it; in the other tests we simply pass nullptr. This is analogous to the how the tests are handling the NetworkTimeTracker parameter of TestSSLErrorHandler. Finally, the test is augmented to account for the fact that on Chromecast, where the test now runs as part of components_unittests, captive portal detection is not enabled. Bug: 1030692 Change-Id: If9292ebbf26437ef85f42f248468325f6d1795f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030524 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#737293}
-
Rayan Kanso authored
This information is needed to figure out whether an WebAPK update is required. Bug: 1045588 Change-Id: I42485a8490b5ee639a433c5466ce54380270421a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030971Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#737292}
-
Friedrich Horschig authored
Currently, the member password_feature_manager_ is marked const in the ChromePasswordManagerClient but only ever accessed in a non-const context. This is possible since PasswordManagerClient::GetPasswordFeatureManager casts the const away. This CL removes the misleading const qualifier and the unused accessor to the const method as well. This clean-up is a precondition for the linked bug which needs non-const access to the feature manager in ChromePasswordManagerClient to call SetAccountStorageOptIn. Bug: 1047202 Change-Id: Ib1383043e25843052815999e00cd163453442d64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030866 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Leon Han authored
Some notable points: 1) Local type in WebNFC APIs is always prefixed by ':', but, the ':' will be omitted when it's actually written into the nfc tag. ":act" --> "act" to be written as the TYPE field into the nfc tag. ":text" --> "text" The reading direction is vice versa. "act" --> ":act" to be exposed as NDEFRecord#recordType. "text" --> ":text" 2) Only "smart-poster", external, and local type records are supposed to be able to carry a ndef message as payload. 3) Local type is only expected to exist inside a ndef message that is another ndef record's payload. Top level ndef message is not allowed to have a local type record. The spec changes: https://github.com/w3c/web-nfc/pull/491 https://github.com/w3c/web-nfc/pull/493 https://github.com/w3c/web-nfc/pull/495 https://github.com/w3c/web-nfc/pull/502 https://github.com/w3c/web-nfc/pull/506 BUG=520391 Change-Id: Ic2890c031109aa583437ac93a8901ff71992af78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1996946Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#737290}
-
Nicolás Peña Moreno authored
Currently, we use exclusively the size of the LayoutObject to compute the background image sizes. This is incorrect, for instance when looking at CSS styles like ::first-letter. This CL fixes this by passing the image border to ImagePaintTimingDetector and ImageElementTiming. Bug: 996921 Change-Id: I94e4a2f3c8873be765b144179f7729430c885dac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023523 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737289}
-
sandromaggi authored
Add error statements for all "false" returns in CreateOptionsFromProto to enable easier debugging when the action fails. Bug: none Change-Id: I3dfd353706ab7da0b4ad956fb57b86d62ba263ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029512 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
-
Reilly Grant authored
This change updates all base::Callbacks and calls to base::Bind() so that they explicitly choose between call-once and call-repeatedly semantics. Bug: 1007692 Change-Id: Ic570899bccfafe707d6ed8a723b49cc34e6a0339 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941272 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#737287}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I43b52c20d3b5428f49c44fc07094531b928e807d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032856Reviewed-by:
-
Ioana Pandele authored
This reverts commit 36911404. Reason for revert: Multiple test targets are failing on Win7 Tests with: 3724:4788:0131/021830.830:FATAL:dwrite_font_lookup_table_builder_win.cc(335)] Check failed: callbacks_access_task_runner_. Bug: 1047647 Original change's description: > Sequentialise access to callbacks in DWriteFontLookupTableBuilder > > Since there may be multiple instance of DWriteFontProxyImpl instantiated > for multiple RenderProcessHosts, and > DWriteFontProxyImpl::GetUniqueNameLookupTable may access > DWriteFontLookupTableBuilder::QueueShareMemoryRegionWhenReady from > separate threads, there may be race conditions around the > pending_callbacks_ member of DWriteFontLookupTableBuilder. > > Sequentialise and guard access to pending_callbacks_ with a separate > sequenced task runner. > > Fixed: 1047054 > Change-Id: Ib7d7a385273bd82eb4d1acf720dac5d688a3435e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030864 > Commit-Queue: Dominik Röttsches <drott@chromium.org> > Reviewed-by: Matthew Denton <mpdenton@chromium.org> > Auto-Submit: Dominik Röttsches <drott@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737252} TBR=drott@chromium.org,mpdenton@chromium.org Change-Id: I23ae8f14e6f82171d6b6950a937b51faa00b3a63 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031043Reviewed-by:
-
Ioana Pandele authored
TBR=thakis@chromium.org Bug: 1047205 Change-Id: I275cf85f2e24031a79af78d1e6d37605a1e78af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032110Reviewed-by:
-
Nohemi Fernandez authored
Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests. The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup. Bug: 1045981 Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#737283}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/ae510e8f08e8..ae2b962ce583 git log ae510e8f08e8..ae2b962ce583 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 sdefresne@chromium.org Tentative fix for roll-dep.py failing in generate commit message Created with: gclient setdep -r src/third_party/depot_tools@ae2b962ce583 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: Ia0a39f6094fddcf58373730e05c6253eccce49ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032861Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a66ca23b9f26..09b742896513 git log a66ca23b9f26..09b742896513 --date=short --first-parent --format='%ad %ae %s' 2020-01-31 fancl@chromium.org Fix sheriff-config return 500 without login Created with: gclient setdep -r src/third_party/catapult@09b742896513 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:953181 Tbr: wenbinzhang@google.com Change-Id: Ic978d764b39ac17d3a916d4977d667872c25ae88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032862Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/659962bc1b4c..10a83fb9a9da git log 659962bc1b4c..10a83fb9a9da --date=short --first-parent --format='%ad %ae %s' 2020-01-31 szuend@chromium.org Revert "Update DevTools DEPS." Created with: gclient setdep -r src/third_party/devtools-frontend/src@10a83fb9a9da If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I02564020d6adf46bf03acfe02c480f2b1b0a8a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032858Reviewed-by:
-
Matthew Denton authored
...instead of CertNetFetcherURLLoader, which fails when the URLLoaderFactory is reset. Bug: 1046326 Change-Id: Id9cfc0fbcb3f15776be1399902ad9ee00132c436 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032412Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#737279}
-
Clemens Arbesser authored
This CL enables logging of non-sensitive information in release builds. It should allow us to debug some/many issues directly in release builds. Bug: b/147645162 Change-Id: I7388a07ab67ba28883ca51d235fa322f552501ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000818 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit 88fbf344. Reason for revert: Breaks parsing of test expectations on the DevTools waterfall - https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/355 Original change's description: > [blinkpy] Integrate Typ's expectations_parser module into blinkpy > > This CL will replace blinkpy's test expectations logic with typ's > expectations_parser module. This change will significantly reduce the > amount the code used for parsing and maintaining test expectations. > Typ's expectations_parser module also parses the new expectations > format. > > Bug: 986447 > Change-Id: I16842bb2fcbc8a75221f3f208ed1550523470716 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918294 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: Luke Z <lpz@chromium.org> > Reviewed-by: John Chen <johnchen@chromium.org> > Commit-Queue: Rakib Hasan <rmhasan@google.com> > Cr-Commit-Position: refs/heads/master@{#737159} TBR=lpz@chromium.org,johnchen@chromium.org,jbudorick@chromium.org,robertma@chromium.org,rmhasan@google.com Change-Id: Id3b9bab45cae06dc21173d7d5fb99f294ec4e95f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030956Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737277}
-
