GitLab

This CL implements the touch-optimized design of the New Tab
Button in both incognito and normal modes. Button is flat
with no highlight, and has an ink drop ripple effect.

Demo is posted on the bug.

BUG=805245
TEST=manually

Change-Id: I33a2e5e213193318b70e1c01ee330a67d6af21f0
Reviewed-on: https://chromium-review.googlesource.com/903375
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537851}

Tracked requests are normally removed when the corresponding renderer
process dies.
However, it has been reported that this mechanism could be used to launch
a DoS attack against the browser process, resulting in "leaks".

This CL sets a limit of 1000 tracked gUM requests, which is a number
probably beyond what is practical for the webrtc-internals UI anyway.

Bug: 804440
Change-Id: I578fbb4ab6feee17f035beca2dbec86381376b6c
Reviewed-on: https://chromium-review.googlesource.com/926366
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537850}

changes:
- WindowState caches a member for saving PersistentWindowInfo, which is
  saved on OnWillProcessDisplayChanges() and restored on
  OnDisplayConfigurationChanged().
- Saving when it hasn't been saved.
- Restoring when (1) we have saved persistent info, (2) persistent
  display id is a valid display currently, (3) persistent display id
  is not current display id. We could have display position/layout
  changes, in which case we transform the window accordingly.
- Reset saved PersistentWindowInfo each time window bounds have restored
  or when bounds changed by user.

Bug: 805046
Test: ash_unittests --gtest_filter=PersistentWindowControllerTest*
Change-Id: I67426ca17f0d25f92284eb690f849bf77bb748be
Reviewed-on: https://chromium-review.googlesource.com/893644Reviewed-by: Mitsuru Oshima (In Tokyo) <oshima@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#537849}

This pseudo-header is defined in
https://tools.ietf.org/html/draft-ietf-httpbis-h2-websockets-00.

This CL lands server change 184848446 by bnc.

BUG=488484

Change-Id: I32000864d0f5cfef66767b8b23ddf4749c61cfc3
Reviewed-on: https://chromium-review.googlesource.com/925624
Commit-Queue: Bence Béky <bnc@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537848}

The Elements search bar shows the number of matches when active.
Upon a refresh/navigation, it cancels the search, but leaves
'0 out of 0' in the search box, even if there are matches.

This CL stops showing incorrect information and hides the match
count completely in those cases.

Screenshot: https://imgur.com/a/xdyD4

Bug: 554654
Change-Id: I49791d302ade2719ae0b609cab8d325a562bb87a
Reviewed-on: https://chromium-review.googlesource.com/920041Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537847}

When an OBJECT or EMBED element requests an image, it does so using
an ImageLoader. To ensure that Content-Security-Policy restrictions
are applied correctly in this scenario, we must adjust the request's
context to indicate the originating element.

Bug: 811691
Change-Id: I0fd8010970a12e68e845a54310695acc0b3f7625
Reviewed-on: https://chromium-review.googlesource.com/924589
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537846}

Metrics logged from the CaptivePortalMetricsTabHelper are useful to
determine the users affected by a broken connection due to a Captive
Portal. However, it is not necessary to log these metrics continuously.
Keeping the tab helper behind a flag allows re-enabling the metrics in
the future in order to examine the issues caused by Captive Portals.

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8c4fca02d85701ca1ef1b7bf0aec87cf08015bd0
Reviewed-on: https://chromium-review.googlesource.com/924571
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537845}

There are two tests that are currently flaking a lot, one
when running in multiprocess_mode.

Disabling these tests until they can be fixed.

TBR=wnwen@chromium.org

BUG=813837

Change-Id: I6f969a9f8bdfe3d74ff92d3d60b6f3d7d94c986b
Reviewed-on: https://chromium-review.googlesource.com/926969Reviewed-by: Donn Denman <donnd@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537844}

This is no longer necessary as of
https://boringssl-review.googlesource.com/24124.

Change-Id: I704668dd9bf9c1a08c7574c5b95b090485a7ade5
Reviewed-on: https://chromium-review.googlesource.com/924547Reviewed-by: Steven Valdez <svaldez@chromium.org>
Commit-Queue: David Benjamin <davidben@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537843}

This reverts commit 467ac499.

Reason for revert: This broke presubmit due to an owners change.

Original change's description:
> VR: Rename native vr_shell directory to vr
> 
> This change follows up on the namespace change, to relocate files,
> and address some of the presubmit warnings stirred up by that move
> (mainly BindRepeating/Once updates).
> 
> BUG=
> NOPRESUBMIT=true
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: Ieb4d0ad3fd039e5e85b0a8cf2204d1141d3438d9
> Reviewed-on: https://chromium-review.googlesource.com/921924
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#537822}

TBR=yfriedman@chromium.org,mthiesse@chromium.org,cjgrant@chromium.org

Change-Id: I23f72f9cf9a8a64a9f92dec0ca4d78f961fa2e02
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/926884Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537842}

Change-Id: I9986d7ca3468f6e5f3ce2c33da627b580c2ac7fe
Reviewed-on: https://chromium-review.googlesource.com/883768
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537841}

This test has non-flaky failures, so we can track them directly and
don't need to disable the test in TestExpectations.

Bug: 772076
Change-Id: Idd071879e02acfff7e77a3b4e923d4fe98f34cbc
Reviewed-on: https://chromium-review.googlesource.com/926721Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537840}

Make ChromeDriver more extensible on Android by allowing to set the
exec name and device socket as capabilities. The already existing
androidActivity capability can be used to specify the
exact Activity to launch.
This should benefit browsers other than Chrome, for instance Opera etc.

Bug: chromedriver:2280

Change-Id: Ice811df1c9b1985f47515c597731942a6e33a1cd
Reviewed-on: https://chromium-review.googlesource.com/924441Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#537839}

Large output on stderr will fill up the pipe and because wait is called
before the pipe is emptied, the process actually deadlocks. Swap around
the communicate() and wait() calls to make this work properly.

Bug: 813530
Change-Id: I58e05ac497b7c2d9aa2dd3fcd551421aea023242
Reviewed-on: https://chromium-review.googlesource.com/924224Reviewed-by: Michael Moss <mmoss@chromium.org>
Commit-Queue: Philipp Kern <pkern@google.com>
Cr-Commit-Position: refs/heads/master@{#537838}

https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/0062e4869f07..7a2563a51456

This is a less ambitions reland of https://crrev.com/c/900544 which was
reverted because it broke net_unittests on Windows Debug builds
https://crbug.com/810347. A full roll is blocked on solving a complex
issue documented in the attached bug. In the meantime, this roll reduces
the gap between Chrome and upstream.

$ git log 0062e4869..7a2563a51 --date=short --no-merges --format='%ad %ae %s'
2018-01-24 misterg revert, lets get this compiled
2018-01-23 misterg Many code merge/upstream changes
2018-01-23 misterg Merging, upstream http://cl/182836545
2018-01-22 misterg more code merge
2018-01-22 misterg merges, cl/155419551 and other
2018-01-22 misterg more merging
2018-01-22 misterg merging
2018-01-22 misterg code merge
2018-01-18 misterg Adding python tests to Bazel build file.
2018-01-18 ftrushkin Use fully qualified  in examples
2018-01-18 ftrushkin Document ScopedTrace utility
2018-01-11 pcc Check whether _MSC_VER is defined when detecting presence of cxxabi.h under libc++.
2018-01-17 ftrushkin Expose ScopedTrace utility in public interface
2018-01-15 misterg Reverting some changes, need to make the merge compile
2018-01-15 misterg Reverting some changes, need to make the merge compile
2018-01-15 misterg Reverting some changes, need to make the merge compile
2018-01-15 misterg Reverting some changes, need to make the merge compile
2018-01-15 misterg Test files for corresponding changes
2018-01-15 misterg Test files for corresponding changes
2018-01-15 misterg Test files for corresponding changes
2018-01-15 misterg Test files for corresponding changes
2018-01-15 misterg More code merges
2018-01-15 misterg Code merging
2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
2018-01-11 misterg continue upstream/merge, etc
2018-01-11 gennadiycivil Update .travis.yml
2018-01-11 gennadiycivil Update .travis.yml
2018-01-11 gennadiycivil Update .travis.yml
2018-01-11 gennadiycivil Update .travis.yml
2018-01-11 misterg Trying to fix travis
2018-01-11 misterg Upstream cl 103120214
2018-01-10 misterg More merge, cleanup
2018-01-10 misterg More merge, cleanup
2018-01-10 misterg Code merge, upstreaming accumulated changes, cleanup
2018-01-10 misterg revert
2018-01-10 misterg code merges, cleanup
2018-01-10 misterg revert googletest/test/gtest-param-test_test.cc
2018-01-10 gennadiycivil Update .travis.yml
2018-01-09 misterg code merge, cleanups
2018-01-09 misterg Upstream of cl 129104714
2018-01-09 misterg Revert one file
2018-01-09 misterg wip, cleanups/merge
2018-01-09 misterg cleanup, merge
2018-01-07 loorongjie [Bazel] Detect Windows with cpu value x64_windows and x64_windows_msvc
2018-01-08 misterg Small cleanups, merge
2018-01-05 coryan Use correct name for build event types.
2018-01-05 misterg Revert one file for now
2018-01-05 coryan Fixed test for pull request.
2018-01-05 coryan Fixed output and test for 'enabled_on_pr'
2018-01-04 misterg code cleanup in preparation for merges, cl 180857299
2018-01-04 coryan Optimize build matrix (#1)
2018-01-03 gennadiycivil upstreaming cl 124976692
2018-01-03 davidben Also define GTEST_ATTRIBUTE_PRINTF_ in clang-cl.
2017-02-10 davidben Pass the -Wmissing-declarations warning.
2018-01-02 misterg OSS Sync, cl 163329677
2018-01-02 davidben Fix testing::Combine on MSVC 2017.
2017-05-06 davidben Avoid warning C4619 in MSVC 2017.
2017-12-24 coryan Build both googletest and googlemock.
2017-12-24 coryan Create a autotools-based build for Travis.
2016-05-18 gregory.pakosz Re-enable MSVC++ C4389 warning in CmdHelperEq()
2017-12-03 coryan Run autoconf from top-level directory.
2017-12-02 romain.geissler Fix double free when building Gtest/GMock in shared libraries and linking a test executable with both.
2017-08-14 gaspard.petit Added support for WINAPI_PARTITION_TV_TITLE which is defined on XboxOne
2017-01-20 davidben Pass MSVC's C4826 warning.

Created with:
  roll-dep src/third_party/googletest/src

Bug: 813219
Change-Id: Id9ff41aa6a1a099749e2a36f07ca93385796b9d0
Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official;master.tryserver.chromium.linux:linux_chromium_msan_rel_ng;master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng;master.tryserver.chromium.mac:mac_chromium_asan_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/924844Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537837}

They flakily crash because of:
Check failed: layer_list_.empty() || *page_scale_factor == 1.

TBR: wangxianzhu@chromium.org
Bug: 706066
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I16e040451fdea20d1179c4fc531c120aba220386
Reviewed-on: https://chromium-review.googlesource.com/926907Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537836}

https://pdfium.googlesource.com/pdfium.git/+log/8c0a80087c42..0fdefc15d769

$ git log 8c0a80087..0fdefc15d --date=short --no-merges --format='%ad %ae %s'
2018-02-20 thakis Fix typo in method name FillSoildRect().

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I31c56d78c5dba006427574deb8adaf70e74d2324
Reviewed-on: https://chromium-review.googlesource.com/926706
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537835}

Move the click position slightly as it was causing a close of the tab
cause the test to not work on Linux.

Re-enable the tests for linux.

BUG=133361

Change-Id: Ie9332978e739f8795fe829e60935c48be7693c93
Reviewed-on: https://chromium-review.googlesource.com/924269
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537834}

Makes the WebVR motion to photon latency test actually fail if too many
iterations fail in a row. The issue was that we were raising an
an exception, but another thread was still alive, which prevented the
script as a whole from actually exiting. With this change, the thread
is killed before raising the exception, so the test will actually
fail instead of being killed by swarming when the timeout is reached.

Bug: 811474
Change-Id: I4a320739fcbb1efa4f34d87205abcc2013bf3d99
Reviewed-on: https://chromium-review.googlesource.com/922796
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537833}

This CL measures frame rates due to rAF animations.

Right now we have Scheduling.DrawIntervalWithCompositedAnimations2 and
WithMainThreadAnimations2 that measures frame rates due to css animations.
This CL basically tells whether the current frame has raf or not and pass
this bit all the way to the CompositorTimingHistory::DidDraw(). The
DidDraw function indicates that there is some visual updates in this frame,
in this case, we record frame rate into the WithMainThreadAnimations2
if either this frame has raf or there is a main thread css animation.

Bug: 786850
Change-Id: I337bbc3f4b448c11482ccb4cb9f83fc284a74c43
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/793750Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537832}

https://skia.googlesource.com/skia.git/+log/cefc1b97405d..c68ba1d7d981

$ git log cefc1b974..c68ba1d7d --date=short --no-merges --format='%ad %ae %s'
2018-02-20 caryclark fix more include generation bugs
2018-02-20 kjlubick Roll Pixel to O 8.1
2018-02-20 fmalita SlideDir focus tweaks
2018-02-20 fmalita Delete SkottieSlide2
2018-02-20 skcms-skia-autoroll Roll skia/third_party/externals/skcms/ c9b7366e8..08d4cf2b3 (1 commit)
2018-02-20 egdaniel Update createWrappedRenderTargetProxy with BackendRT to work with lazy proxies.
2018-02-16 dwkang Start thread pool in skia_dm on Android.
2018-02-20 stephana Revert "Increase ninja thread count for Android build on Linux."
2018-02-20 reed don't trust stored segment mask

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=djsollen@chromium.org

Change-Id: I42e49f355dc138073abd6901f0d98b0c588f82d5
Reviewed-on: https://chromium-review.googlesource.com/926703Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537831}

Like the unit tests, but these can test more robust browser activity.

Bug: 784639
Change-Id: I65ef78d56143d65811a05e7b8a1088e2ce9c372e
Reviewed-on: https://chromium-review.googlesource.com/905688
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537830}

KeyframeModel::is_controlling_instance() is explicitly meant to convey which
model is actually the impl side one. We should use that instead of
overloading |events| nulliness with being on impl side (or not). The latter
is brittle and not readable.

|KeyframeModel::is_controlling_instance_| is correctly set true for impl only
animation. In this case there is only a single animation instance which is
by definition the controlling instance. The CL fixes this.


See also: https://codereview.chromium.org/1151763011

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I4380228084fd9ed7199c66e949229e0936cf4fc3
Reviewed-on: https://chromium-review.googlesource.com/914704
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537829}

https://webrtc.googlesource.com/src.git/+log/645898a45433..6bd3cddcef0c

$ git log 645898a45..6bd3cddce --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I719e0ac6fc58fa82790c44842245525ae8986868
Reviewed-on: https://chromium-review.googlesource.com/926704Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#537828}

Comments explain the reason for recursive LoadHtml retry.

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Icd2b9a93e127500759c61a7e051e92ddc02df727
Reviewed-on: https://chromium-review.googlesource.com/926574
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537827}

This CL fixes a crash in Incognito where the Payment Request
IdentityProvider attempted to register an Observer on a null
SigninManager. It also brings Payment Request in line with Autofill,
where previously PR was displaying the Original Profile's Autofill data
but wasn't able to unlock cards because the IdentityProvider was invalid
in Incognito.

Bug: 813275
Change-Id: I3fb43ba45404f8884a300d77fda7f8fe0f8364af
Reviewed-on: https://chromium-review.googlesource.com/926563
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537826}

It's apparently possible for
BrowserList::SetLastActive(Browser* browser) to be called before
|browser| is added to the BrowserList. This might happen, e.g., if a
BrowserView's widget receives an activation event before
CreateBrowserWindow() returns.

This will cause WindowActivityWatcher's UpdateMetrics() helper function
to dereference the null pointer at browser->window().

Bug: 811243,811191
Change-Id: Ia377a810b73494f88d1cd2b4532367950f35b1f7
Reviewed-on: https://chromium-review.googlesource.com/924353
Commit-Queue: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537825}

Prior to https://chromium-review.googlesource.com/905273,
ScrollingCoordinator did not update touch event rects for OOPIF
subframes. To make sure that touch handlers in OOPIFs remained
functional, the code had a hack to set the entire root layer layer of
an OOPIF to be a touch event rect if the OOPIF contained any touch
handlers at all.

Now ScrollingCoordinator should be handling these rects for OOPIFs, so
this CL removes the hack.

Bug: 680606
Change-Id: I6a1b7badca7c9752c298a97ab17cbe28775e0eb8
Reviewed-on: https://chromium-review.googlesource.com/923583Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537824}

This is a test-only change.

Change ConstructSpdyDataFrame() to take a base::StringPiece argument
instead of separate data and length.  To prevent headaches while writing
unittests if one forgets to change the length and has a hard time
figuring out why mock data does not make any sense.

Also move |content| local variable from heap to stack in multiple tests.

Also use std::string::data() instead of std::string::c_str() where
substrings are constructed in tests.

Also replace some potentially politically incorrect text with more
neutral text of the exact same length.

Bug: 810752
Change-Id: Ib22f9ab5c12be8e2c95bd68205995547fda4e9ba
Reviewed-on: https://chromium-review.googlesource.com/926421Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537823}

This change follows up on the namespace change, to relocate files,
and address some of the presubmit warnings stirred up by that move
(mainly BindRepeating/Once updates).

BUG=
NOPRESUBMIT=true

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ieb4d0ad3fd039e5e85b0a8cf2204d1141d3438d9
Reviewed-on: https://chromium-review.googlesource.com/921924
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537822}

The log statements were added by error by
https://chromium-review.googlesource.com/c/chromium/src/+/867511

TBR=wittman@chromium.org

Bug: 668690
Change-Id: Iefaa5d6cf254762230d8dd4bf04b903689d36777
Reviewed-on: https://chromium-review.googlesource.com/926782Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537821}

--enable-demo-mode switch turns on new demo mode feature that is under
development.
Ctrl+Alt+D shortcut opens new demo mode setup flow from OOBE (sign in screen).
It is used for development and might change in the future.

Change-Id: Ie3c0d954cd7d3d82f030873b9472debb1ebb2a1d
Bug: 812460
Reviewed-on: https://chromium-review.googlesource.com/914846Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537820}

This allows for easy migration to the views version of ExtensionPopup.

BUG=728174

Change-Id: I2c9085952cd351247aeefa4247cef7fefa974c40
Reviewed-on: https://chromium-review.googlesource.com/924682Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537819}

Bug: 793754
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ia452a9c25fbd35b0ccc91ac6572e3e5c11dc8418
Reviewed-on: https://chromium-review.googlesource.com/926221Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537818}

. Content moves loading from PreCreateThreads() to
  PreEarlyInitialization() (or right after calling
  BrowserMainParts::PreEarlyInitialization()
  . This necessitated a change for cast to have content not init
    FieldTrials.
. Moves creation of FieldTrial in tests from
  TestBlinkWebUnitTestSupport to UnittestTestSuite. This is so code
  run after that (but before TestBlinkWebUnitTestSupport) has the
  FeatureList setup.

BUG=800357
TEST=none

Change-Id: I50e121f4c5654288571715b0e72bf04db340daf1
Reviewed-on: https://chromium-review.googlesource.com/925685Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537817}

Shelf Model sync allows Chrome to use a separate shelf model from Ash.
This functionality is required for the Chrome OS shelf to work in Mash.

This config has been running fine on stable for a couple milestones.
Remove the switch and flag to disable the functionality.

Bug: 557406
Test: No behavior changes; ShelfModel sync still works.
Change-Id: I6f1488dd983b7140c72934fa3ac27c26d4a48028
Reviewed-on: https://chromium-review.googlesource.com/923429Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537816}

These .cc files have been included accidentally.
Include the header file instead.

Bug: 713138
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If9ee44765e1bbd7d4d4d5c4a6367457dc62fd01f
Reviewed-on: https://chromium-review.googlesource.com/926583Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537815}

This reverts commit b9aa7421.

Reason for revert: Reverting temporarily to get canary data, as we suspect this CL might have regressed Omnibox.CharTypedToRepaintLatency.

Original change's description:
> Fix rlz disabling breakage on CrOS
> 
> Revert of "Cache the brand code to avoid hundreds of repeated reads."
> commit 04749717.
> https://codereview.chromium.org/2890943005
> 
> Disabling RLZ is communicated through an empty brand code. Thus the
> value of the brand code must not be cached before RLZ is initialized.
> 
> BUG=793162
> TEST=none
> 
> Change-Id: I7f9e223a9a39d19408f364f6aad95cb8c86f6d79
> Reviewed-on: https://chromium-review.googlesource.com/824363
> Reviewed-by: Peter Kasting <pkasting@chromium.org>
> Commit-Queue: Thiemo Nagel <tnagel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524012}

TBR=pkasting@chromium.org,tnagel@chromium.org,borisv@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 793162
Change-Id: Ifba1cd02df27c950416cc6433f0c4cba00d2cf47
Reviewed-on: https://chromium-review.googlesource.com/926622Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537814}

This prototypes the idea of uneliding when the user affirmatively
places the caret within the existing URL or makes a partial selection.

The partial selection can be made either via double-click or by
dragging. The unelision happens on mouseup.

It feels pretty good.

Change-Id: I5522a7b6dc8d94fe84c39c8b71995abc5007651a
Reviewed-on: https://chromium-review.googlesource.com/910110Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537813}

The WebView stub needs to be able to override this to Monochrome's
application class name.

Bug: 809636
Change-Id: Icbc68f84ce76a8cb2d3ed8ec11d0cca0e00e33e3
Reviewed-on: https://chromium-review.googlesource.com/926724Reviewed-by: Tobias Sargeant <tobiasjs@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537812}